[INFO] crate lz_diet 0.1.4 is already in cache [INFO] extracting crate lz_diet 0.1.4 into work/ex/clippy-test-run/sources/stable/reg/lz_diet/0.1.4 [INFO] extracting crate lz_diet 0.1.4 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/lz_diet/0.1.4 [INFO] validating manifest of lz_diet-0.1.4 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of lz_diet-0.1.4 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing lz_diet-0.1.4 [INFO] finished frobbing lz_diet-0.1.4 [INFO] frobbed toml for lz_diet-0.1.4 written to work/ex/clippy-test-run/sources/stable/reg/lz_diet/0.1.4/Cargo.toml [INFO] started frobbing lz_diet-0.1.4 [INFO] finished frobbing lz_diet-0.1.4 [INFO] frobbed toml for lz_diet-0.1.4 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/lz_diet/0.1.4/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting lz_diet-0.1.4 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/lz_diet/0.1.4:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 2963f7d4e6291851e0c299aa40887a101019fa8484b6d6c86f25f0f418147ce9 [INFO] running `"docker" "start" "-a" "2963f7d4e6291851e0c299aa40887a101019fa8484b6d6c86f25f0f418147ce9"` [INFO] [stderr] Checking binary-tree v0.2.0 [INFO] [stderr] Checking lz_diet v0.1.4 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/diet_node.rs:149:13 [INFO] [stderr] | [INFO] [stderr] 149 | interval: interval, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `interval` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/diet_node.rs:149:13 [INFO] [stderr] | [INFO] [stderr] 149 | interval: interval, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `interval` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/diet_node.rs:423:13 [INFO] [stderr] | [INFO] [stderr] 423 | self.right_mut().map(|node| if node.balance_factor() < 0 { [INFO] [stderr] | _____________^ [INFO] [stderr] | |_____________| [INFO] [stderr] | || [INFO] [stderr] 424 | || trace!("rotating right node right"); [INFO] [stderr] 425 | || [INFO] [stderr] 426 | || node.rotate_right() [INFO] [stderr] ... || [INFO] [stderr] 429 | || debug!("rotated right node right"); [INFO] [stderr] 430 | || }); [INFO] [stderr] | ||______________^- help: try this: `if let Some(node) = self.right_mut() { ... }` [INFO] [stderr] | |_______________| [INFO] [stderr] | [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::option_map_unit_fn)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/diet_node.rs:441:13 [INFO] [stderr] | [INFO] [stderr] 441 | self.left_mut().map(|node| if node.balance_factor() > 0 { [INFO] [stderr] | _____________^ [INFO] [stderr] | |_____________| [INFO] [stderr] | || [INFO] [stderr] 442 | || trace!("rotating left node left"); [INFO] [stderr] 443 | || [INFO] [stderr] 444 | || node.rotate_left() [INFO] [stderr] ... || [INFO] [stderr] 447 | || debug!("rotated left node left"); [INFO] [stderr] 448 | || }); [INFO] [stderr] | ||______________^- help: try this: `if let Some(node) = self.left_mut() { ... }` [INFO] [stderr] | |_______________| [INFO] [stderr] | [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of left operand [INFO] [stderr] --> src/diet_node.rs:721:12 [INFO] [stderr] | [INFO] [stderr] 721 | if &value < self.value().inclusive_start() { [INFO] [stderr] | ------^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: use the left value directly: `value` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::op_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of left operand [INFO] [stderr] --> src/diet_node.rs:739:19 [INFO] [stderr] | [INFO] [stderr] 739 | } else if &value > self.value().exclusive_end() { [INFO] [stderr] | ------^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: use the left value directly: `value` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the slice [INFO] [stderr] --> src/lib.rs:400:26 [INFO] [stderr] | [INFO] [stderr] 400 | for val in other.into_iter().cloned() { [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::into_iter_on_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/diet_node.rs:423:13 [INFO] [stderr] | [INFO] [stderr] 423 | self.right_mut().map(|node| if node.balance_factor() < 0 { [INFO] [stderr] | _____________^ [INFO] [stderr] | |_____________| [INFO] [stderr] | || [INFO] [stderr] 424 | || trace!("rotating right node right"); [INFO] [stderr] 425 | || [INFO] [stderr] 426 | || node.rotate_right() [INFO] [stderr] ... || [INFO] [stderr] 429 | || debug!("rotated right node right"); [INFO] [stderr] 430 | || }); [INFO] [stderr] | ||______________^- help: try this: `if let Some(node) = self.right_mut() { ... }` [INFO] [stderr] | |_______________| [INFO] [stderr] | [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::option_map_unit_fn)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/diet_node.rs:441:13 [INFO] [stderr] | [INFO] [stderr] 441 | self.left_mut().map(|node| if node.balance_factor() > 0 { [INFO] [stderr] | _____________^ [INFO] [stderr] | |_____________| [INFO] [stderr] | || [INFO] [stderr] 442 | || trace!("rotating left node left"); [INFO] [stderr] 443 | || [INFO] [stderr] 444 | || node.rotate_left() [INFO] [stderr] ... || [INFO] [stderr] 447 | || debug!("rotated left node left"); [INFO] [stderr] 448 | || }); [INFO] [stderr] | ||______________^- help: try this: `if let Some(node) = self.left_mut() { ... }` [INFO] [stderr] | |_______________| [INFO] [stderr] | [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of left operand [INFO] [stderr] --> src/diet_node.rs:721:12 [INFO] [stderr] | [INFO] [stderr] 721 | if &value < self.value().inclusive_start() { [INFO] [stderr] | ------^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: use the left value directly: `value` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::op_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of left operand [INFO] [stderr] --> src/diet_node.rs:739:19 [INFO] [stderr] | [INFO] [stderr] 739 | } else if &value > self.value().exclusive_end() { [INFO] [stderr] | ------^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: use the left value directly: `value` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the slice [INFO] [stderr] --> src/lib.rs:400:26 [INFO] [stderr] | [INFO] [stderr] 400 | for val in other.into_iter().cloned() { [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::into_iter_on_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 4.26s [INFO] running `"docker" "inspect" "2963f7d4e6291851e0c299aa40887a101019fa8484b6d6c86f25f0f418147ce9"` [INFO] running `"docker" "rm" "-f" "2963f7d4e6291851e0c299aa40887a101019fa8484b6d6c86f25f0f418147ce9"` [INFO] [stdout] 2963f7d4e6291851e0c299aa40887a101019fa8484b6d6c86f25f0f418147ce9