[INFO] crate lz4 1.23.1 is already in cache [INFO] extracting crate lz4 1.23.1 into work/ex/clippy-test-run/sources/stable/reg/lz4/1.23.1 [INFO] extracting crate lz4 1.23.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/lz4/1.23.1 [INFO] validating manifest of lz4-1.23.1 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of lz4-1.23.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing lz4-1.23.1 [INFO] finished frobbing lz4-1.23.1 [INFO] frobbed toml for lz4-1.23.1 written to work/ex/clippy-test-run/sources/stable/reg/lz4/1.23.1/Cargo.toml [INFO] started frobbing lz4-1.23.1 [INFO] finished frobbing lz4-1.23.1 [INFO] frobbed toml for lz4-1.23.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/lz4/1.23.1/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting lz4-1.23.1 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/lz4/1.23.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] f93d6792a52b8822d82050736b010838d6ae1a2a68bc55ac60f3e4eb92c88b65 [INFO] running `"docker" "start" "-a" "f93d6792a52b8822d82050736b010838d6ae1a2a68bc55ac60f3e4eb92c88b65"` [INFO] [stderr] Checking bytecount v0.4.0 [INFO] [stderr] Checking error-chain v0.12.0 [INFO] [stderr] Compiling lz4 v1.23.1 (/opt/crater/workdir) [INFO] [stderr] Checking cargo_metadata v0.6.4 [INFO] [stderr] Checking skeptic v0.13.4 [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/decoder.rs:27:13 [INFO] [stderr] | [INFO] [stderr] 27 | r: r, [INFO] [stderr] | ^^^^ help: replace it with: `r` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/decoder.rs:138:37 [INFO] [stderr] | [INFO] [stderr] 138 | ErrorWrapper { r: read, rng: rng } [INFO] [stderr] | ^^^^^^^^ help: replace it with: `rng` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/encoder.rs:83:13 [INFO] [stderr] | [INFO] [stderr] 83 | w: w, [INFO] [stderr] | ^^^^ help: replace it with: `w` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/decoder.rs:58:30 [INFO] [stderr] | [INFO] [stderr] 58 | if self.next == 0 || buf.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `buf.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/decoder.rs:64:28 [INFO] [stderr] | [INFO] [stderr] 64 | let need = match self.buf.len() < self.next { [INFO] [stderr] | ____________________________^ [INFO] [stderr] 65 | | true => self.buf.len(), [INFO] [stderr] 66 | | false => self.next, [INFO] [stderr] 67 | | }; [INFO] [stderr] | |_________________^ help: consider using an if/else expression: `if self.buf.len() < self.next { self.buf.len() } else { self.next }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] error: this comparison involving the minimum or maximum element for this type contains a case that is always true or always false [INFO] [stderr] --> src/decoder.rs:69:20 [INFO] [stderr] | [INFO] [stderr] 69 | if self.len <= 0 { [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::absurd_extreme_comparisons)] on by default [INFO] [stderr] = help: because 0 is the minimum value for this type, the case where the two sides are not equal never occurs, consider using self.len == 0 instead [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#absurd_extreme_comparisons [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `encoder::EncoderBuilder` [INFO] [stderr] --> src/encoder.rs:31:5 [INFO] [stderr] | [INFO] [stderr] 31 | / pub fn new() -> Self { [INFO] [stderr] 32 | | EncoderBuilder { [INFO] [stderr] 33 | | block_size: BlockSize::Default, [INFO] [stderr] 34 | | block_mode: BlockMode::Linked, [INFO] [stderr] ... | [INFO] [stderr] 38 | | } [INFO] [stderr] 39 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 30 | impl Default for encoder::EncoderBuilder { [INFO] [stderr] 31 | fn default() -> Self { [INFO] [stderr] 32 | Self::new() [INFO] [stderr] 33 | } [INFO] [stderr] 34 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/encoder.rs:76:25 [INFO] [stderr] | [INFO] [stderr] 76 | auto_flush: match self.auto_flush { [INFO] [stderr] | _________________________^ [INFO] [stderr] 77 | | false => 0, [INFO] [stderr] 78 | | true => 1, [INFO] [stderr] 79 | | }, [INFO] [stderr] | |_____________^ help: consider using an if/else expression: `if self.auto_flush { 1 } else { 0 }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/block/mod.rs:67:9 [INFO] [stderr] | [INFO] [stderr] 67 | / let dst_buf: &mut [u8]; [INFO] [stderr] 68 | | if prepend_size { [INFO] [stderr] 69 | | let size = src.len() as u32; [INFO] [stderr] 70 | | compressed[0] = size as u8; [INFO] [stderr] ... | [INFO] [stderr] 76 | | dst_buf = &mut compressed; [INFO] [stderr] 77 | | } [INFO] [stderr] | |_________^ help: it is more idiomatic to write: `let dst_buf = if prepend_size { ..; &mut compressed[4..] } else { &mut compressed };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/block/mod.rs:139:13 [INFO] [stderr] | [INFO] [stderr] 139 | (src[0] as i32) | (src[1] as i32) << 8 | (src[2] as i32) << 16 | (src[3] as i32) << 24; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `i32::from(src[0])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/block/mod.rs:139:31 [INFO] [stderr] | [INFO] [stderr] 139 | (src[0] as i32) | (src[1] as i32) << 8 | (src[2] as i32) << 16 | (src[3] as i32) << 24; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `i32::from(src[1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/block/mod.rs:139:54 [INFO] [stderr] | [INFO] [stderr] 139 | (src[0] as i32) | (src[1] as i32) << 8 | (src[2] as i32) << 16 | (src[3] as i32) << 24; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `i32::from(src[2])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/block/mod.rs:139:78 [INFO] [stderr] | [INFO] [stderr] 139 | (src[0] as i32) | (src[1] as i32) << 8 | (src[2] as i32) << 16 | (src[3] as i32) << 24; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `i32::from(src[3])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `lz4`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: build failed [INFO] running `"docker" "inspect" "f93d6792a52b8822d82050736b010838d6ae1a2a68bc55ac60f3e4eb92c88b65"` [INFO] running `"docker" "rm" "-f" "f93d6792a52b8822d82050736b010838d6ae1a2a68bc55ac60f3e4eb92c88b65"` [INFO] [stdout] f93d6792a52b8822d82050736b010838d6ae1a2a68bc55ac60f3e4eb92c88b65