[INFO] crate lyon_tessellation 0.11.0 is already in cache [INFO] extracting crate lyon_tessellation 0.11.0 into work/ex/clippy-test-run/sources/stable/reg/lyon_tessellation/0.11.0 [INFO] extracting crate lyon_tessellation 0.11.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/lyon_tessellation/0.11.0 [INFO] validating manifest of lyon_tessellation-0.11.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of lyon_tessellation-0.11.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing lyon_tessellation-0.11.0 [INFO] finished frobbing lyon_tessellation-0.11.0 [INFO] frobbed toml for lyon_tessellation-0.11.0 written to work/ex/clippy-test-run/sources/stable/reg/lyon_tessellation/0.11.0/Cargo.toml [INFO] started frobbing lyon_tessellation-0.11.0 [INFO] finished frobbing lyon_tessellation-0.11.0 [INFO] frobbed toml for lyon_tessellation-0.11.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/lyon_tessellation/0.11.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting lyon_tessellation-0.11.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/lyon_tessellation/0.11.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 8fe19f9627c878b7242e69df4f57bef5461c011a321fe53aa79dac6278541548 [INFO] running `"docker" "start" "-a" "8fe19f9627c878b7242e69df4f57bef5461c011a321fe53aa79dac6278541548"` [INFO] [stderr] Checking xmlparser v0.1.2 [INFO] [stderr] Checking euclid v0.18.2 [INFO] [stderr] Checking svgparser v0.6.4 [INFO] [stderr] Checking lyon_geom v0.11.1 [INFO] [stderr] Checking lyon_path v0.11.0 [INFO] [stderr] Checking lyon_svg v0.11.0 [INFO] [stderr] Checking lyon_tessellation v0.11.0 (/opt/crater/workdir) [INFO] [stderr] warning: lint name `suspicious_arithmetic_impl` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/fixed.rs:252:56 [INFO] [stderr] | [INFO] [stderr] 252 | #[cfg_attr(feature = "cargo-clippy", allow(suspicious_arithmetic_impl))] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::suspicious_arithmetic_impl` [INFO] [stderr] ... [INFO] [stderr] 312 | impl_fixed_point!(Fp64: i64); [INFO] [stderr] | ----------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = note: #[warn(renamed_and_removed_lints)] on by default [INFO] [stderr] [INFO] [stderr] warning: lint name `suspicious_arithmetic_impl` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/fixed.rs:252:56 [INFO] [stderr] | [INFO] [stderr] 252 | #[cfg_attr(feature = "cargo-clippy", allow(suspicious_arithmetic_impl))] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::suspicious_arithmetic_impl` [INFO] [stderr] ... [INFO] [stderr] 314 | impl_fixed_point!(Fp32: i32); [INFO] [stderr] | ----------------------------- in this macro invocation [INFO] [stderr] [INFO] [stderr] warning: lint name `suspicious_arithmetic_impl` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/fixed.rs:358:48 [INFO] [stderr] | [INFO] [stderr] 358 | #[cfg_attr(feature = "cargo-clippy", allow(suspicious_arithmetic_impl))] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::suspicious_arithmetic_impl` [INFO] [stderr] [INFO] [stderr] warning: lint name `suspicious_arithmetic_impl` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/fixed.rs:392:48 [INFO] [stderr] | [INFO] [stderr] 392 | #[cfg_attr(feature = "cargo-clippy", allow(suspicious_arithmetic_impl))] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::suspicious_arithmetic_impl` [INFO] [stderr] [INFO] [stderr] warning: lint name `suspicious_arithmetic_impl` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/fixed.rs:252:56 [INFO] [stderr] | [INFO] [stderr] 252 | #[cfg_attr(feature = "cargo-clippy", allow(suspicious_arithmetic_impl))] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::suspicious_arithmetic_impl` [INFO] [stderr] ... [INFO] [stderr] 312 | impl_fixed_point!(Fp64: i64); [INFO] [stderr] | ----------------------------- in this macro invocation [INFO] [stderr] [INFO] [stderr] Checking lyon_extra v0.11.0 [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/basic_shapes.rs:43:15 [INFO] [stderr] | [INFO] [stderr] 43 | _options: &FillOptions, [INFO] [stderr] | ^^^^^^^^^^^^ help: consider passing by value instead: `FillOptions` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/basic_shapes.rs:100:15 [INFO] [stderr] | [INFO] [stderr] 100 | _options: &FillOptions, [INFO] [stderr] | ^^^^^^^^^^^^ help: consider passing by value instead: `FillOptions` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/basic_shapes.rs:161:15 [INFO] [stderr] | [INFO] [stderr] 161 | _options: &FillOptions, [INFO] [stderr] | ^^^^^^^^^^^^ help: consider passing by value instead: `FillOptions` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/basic_shapes.rs:250:14 [INFO] [stderr] | [INFO] [stderr] 250 | options: &FillOptions, [INFO] [stderr] | ^^^^^^^^^^^^ help: consider passing by value instead: `FillOptions` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/basic_shapes.rs:532:14 [INFO] [stderr] | [INFO] [stderr] 532 | options: &FillOptions, [INFO] [stderr] | ^^^^^^^^^^^^ help: consider passing by value instead: `FillOptions` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/basic_shapes.rs:644:14 [INFO] [stderr] | [INFO] [stderr] 644 | for i in 1..num_points + 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: use: `1..=num_points` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/basic_shapes.rs:657:14 [INFO] [stderr] | [INFO] [stderr] 657 | options: &FillOptions, [INFO] [stderr] | ^^^^^^^^^^^^ help: consider passing by value instead: `FillOptions` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/basic_shapes.rs:660:8 [INFO] [stderr] | [INFO] [stderr] 660 | if radii.x == radii.y { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider comparing them within some error: `(radii.x - radii.y).abs() < error` [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::float_cmp)] on by default [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/basic_shapes.rs:660:8 [INFO] [stderr] | [INFO] [stderr] 660 | if radii.x == radii.y { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/basic_shapes.rs:748:15 [INFO] [stderr] | [INFO] [stderr] 748 | _options: &FillOptions, [INFO] [stderr] | ^^^^^^^^^^^^ help: consider passing by value instead: `FillOptions` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/basic_shapes.rs:818:14 [INFO] [stderr] | [INFO] [stderr] 818 | options: &FillOptions, [INFO] [stderr] | ^^^^^^^^^^^^ help: consider passing by value instead: `FillOptions` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/geometry_builder.rs:238:19 [INFO] [stderr] | [INFO] [stderr] 238 | pub fn offset(&self) -> Index { self.0 } [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/geometry_builder.rs:249:40 [INFO] [stderr] | [INFO] [stderr] 249 | fn from(v: u16) -> Self { VertexId(v as Index) } [INFO] [stderr] | ^^^^^^^^^^ help: try: `u32::from(v)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `geometry_builder::NoOutput` [INFO] [stderr] --> src/geometry_builder.rs:513:5 [INFO] [stderr] | [INFO] [stderr] 513 | / pub fn new() -> Self { [INFO] [stderr] 514 | | NoOutput { count: Count { vertices: 0, indices: 0 } } [INFO] [stderr] 515 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 512 | impl Default for geometry_builder::NoOutput { [INFO] [stderr] 513 | fn default() -> Self { [INFO] [stderr] 514 | Self::new() [INFO] [stderr] 515 | } [INFO] [stderr] 516 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/path_fill.rs:116:9 [INFO] [stderr] | [INFO] [stderr] 116 | / let mut winding = 1; [INFO] [stderr] 117 | | if is_after(a, b) { [INFO] [stderr] 118 | | swap(&mut a, &mut b); [INFO] [stderr] 119 | | winding = -1; [INFO] [stderr] 120 | | } [INFO] [stderr] | |_________^ help: it is more idiomatic to write: `let winding = if is_after(a, b) { ..; -1 } else { 1 };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/path_fill.rs:318:18 [INFO] [stderr] | [INFO] [stderr] 318 | options: &FillOptions, [INFO] [stderr] | ^^^^^^^^^^^^ help: consider passing by value instead: `FillOptions` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/path_fill.rs:337:18 [INFO] [stderr] | [INFO] [stderr] 337 | options: &FillOptions, [INFO] [stderr] | ^^^^^^^^^^^^ help: consider passing by value instead: `FillOptions` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/path_fill.rs:520:15 [INFO] [stderr] | [INFO] [stderr] 520 | prev: &TessPoint, [INFO] [stderr] | ^^^^^^^^^^ help: consider passing by value instead: `TessPoint` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/path_fill.rs:521:15 [INFO] [stderr] | [INFO] [stderr] 521 | next: &TessPoint, [INFO] [stderr] | ^^^^^^^^^^ help: consider passing by value instead: `TessPoint` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 33 [INFO] [stderr] --> src/path_fill.rs:535:5 [INFO] [stderr] | [INFO] [stderr] 535 | / fn process_vertex( [INFO] [stderr] 536 | | &mut self, [INFO] [stderr] 537 | | output: &mut GeometryBuilder, [INFO] [stderr] 538 | | ) { [INFO] [stderr] ... | [INFO] [stderr] 779 | | } [INFO] [stderr] 780 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (11/7) [INFO] [stderr] --> src/path_stroke.rs:875:1 [INFO] [stderr] | [INFO] [stderr] 875 | / fn tess_round_cap( [INFO] [stderr] 876 | | center: Point, [INFO] [stderr] 877 | | angle: (f32, f32), [INFO] [stderr] 878 | | radius: f32, [INFO] [stderr] ... | [INFO] [stderr] 935 | | ); [INFO] [stderr] 936 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::too_many_arguments)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/fixed.rs:158:42 [INFO] [stderr] | [INFO] [stderr] 158 | pub fn to_f64(self) -> f64 { self.bits as f64 / f64::from(1 << F::bits()) } // TODO [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `f64::from(self.bits)` [INFO] [stderr] ... [INFO] [stderr] 314 | impl_fixed_point!(Fp32: i32); [INFO] [stderr] | ----------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `lyon_tessellation`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: build failed [INFO] running `"docker" "inspect" "8fe19f9627c878b7242e69df4f57bef5461c011a321fe53aa79dac6278541548"` [INFO] running `"docker" "rm" "-f" "8fe19f9627c878b7242e69df4f57bef5461c011a321fe53aa79dac6278541548"` [INFO] [stdout] 8fe19f9627c878b7242e69df4f57bef5461c011a321fe53aa79dac6278541548