[INFO] crate lyon_tess2 0.11.0 is already in cache [INFO] extracting crate lyon_tess2 0.11.0 into work/ex/clippy-test-run/sources/stable/reg/lyon_tess2/0.11.0 [INFO] extracting crate lyon_tess2 0.11.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/lyon_tess2/0.11.0 [INFO] validating manifest of lyon_tess2-0.11.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of lyon_tess2-0.11.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing lyon_tess2-0.11.0 [INFO] finished frobbing lyon_tess2-0.11.0 [INFO] frobbed toml for lyon_tess2-0.11.0 written to work/ex/clippy-test-run/sources/stable/reg/lyon_tess2/0.11.0/Cargo.toml [INFO] started frobbing lyon_tess2-0.11.0 [INFO] finished frobbing lyon_tess2-0.11.0 [INFO] frobbed toml for lyon_tess2-0.11.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/lyon_tess2/0.11.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting lyon_tess2-0.11.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/lyon_tess2/0.11.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] cbbf565f64407871fdb17cd3fe3a40af02ae230951e99349559497ec5abe2a89 [INFO] running `"docker" "start" "-a" "cbbf565f64407871fdb17cd3fe3a40af02ae230951e99349559497ec5abe2a89"` [INFO] [stderr] Compiling tess2-sys v0.0.1 [INFO] [stderr] Checking lyon_geom v0.11.1 [INFO] [stderr] Checking lyon_path v0.11.0 [INFO] [stderr] Checking lyon_tessellation v0.11.0 [INFO] [stderr] Checking lyon_tess2 v0.11.0 (/opt/crater/workdir) [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/tessellator.rs:36:18 [INFO] [stderr] | [INFO] [stderr] 36 | options: &FillOptions, [INFO] [stderr] | ^^^^^^^^^^^^ help: consider passing by value instead: `FillOptions` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/tessellator.rs:61:18 [INFO] [stderr] | [INFO] [stderr] 61 | options: &FillOptions, [INFO] [stderr] | ^^^^^^^^^^^^ help: consider passing by value instead: `FillOptions` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/tessellator.rs:89:42 [INFO] [stderr] | [INFO] [stderr] 89 | fn do_tessellate(&mut self, options: &FillOptions) -> bool { [INFO] [stderr] | ^^^^^^^^^^^^ help: consider passing by value instead: `FillOptions` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/flattened_path.rs:204:37 [INFO] [stderr] | [INFO] [stderr] 204 | self.points.last().cloned().unwrap_or(Point::new(0.0, 0.0)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| Point::new(0.0, 0.0))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/tessellator.rs:36:18 [INFO] [stderr] | [INFO] [stderr] 36 | options: &FillOptions, [INFO] [stderr] | ^^^^^^^^^^^^ help: consider passing by value instead: `FillOptions` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/tessellator.rs:61:18 [INFO] [stderr] | [INFO] [stderr] 61 | options: &FillOptions, [INFO] [stderr] | ^^^^^^^^^^^^ help: consider passing by value instead: `FillOptions` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/tessellator.rs:89:42 [INFO] [stderr] | [INFO] [stderr] 89 | fn do_tessellate(&mut self, options: &FillOptions) -> bool { [INFO] [stderr] | ^^^^^^^^^^^^ help: consider passing by value instead: `FillOptions` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/flattened_path.rs:204:37 [INFO] [stderr] | [INFO] [stderr] 204 | self.points.last().cloned().unwrap_or(Point::new(0.0, 0.0)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| Point::new(0.0, 0.0))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 6.67s [INFO] running `"docker" "inspect" "cbbf565f64407871fdb17cd3fe3a40af02ae230951e99349559497ec5abe2a89"` [INFO] running `"docker" "rm" "-f" "cbbf565f64407871fdb17cd3fe3a40af02ae230951e99349559497ec5abe2a89"` [INFO] [stdout] cbbf565f64407871fdb17cd3fe3a40af02ae230951e99349559497ec5abe2a89