[INFO] crate lyon_extra 0.11.0 is already in cache [INFO] extracting crate lyon_extra 0.11.0 into work/ex/clippy-test-run/sources/stable/reg/lyon_extra/0.11.0 [INFO] extracting crate lyon_extra 0.11.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/lyon_extra/0.11.0 [INFO] validating manifest of lyon_extra-0.11.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of lyon_extra-0.11.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing lyon_extra-0.11.0 [INFO] finished frobbing lyon_extra-0.11.0 [INFO] frobbed toml for lyon_extra-0.11.0 written to work/ex/clippy-test-run/sources/stable/reg/lyon_extra/0.11.0/Cargo.toml [INFO] started frobbing lyon_extra-0.11.0 [INFO] finished frobbing lyon_extra-0.11.0 [INFO] frobbed toml for lyon_extra-0.11.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/lyon_extra/0.11.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting lyon_extra-0.11.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/lyon_extra/0.11.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 4adf40454dba4ae095b13ed804f1972079ff7ab27551b5a4dbfadda8fb685fd2 [INFO] running `"docker" "start" "-a" "4adf40454dba4ae095b13ed804f1972079ff7ab27551b5a4dbfadda8fb685fd2"` [INFO] [stderr] Checking xmlparser v0.1.2 [INFO] [stderr] Checking svgparser v0.6.4 [INFO] [stderr] Checking lyon_svg v0.11.0 [INFO] [stderr] Checking lyon_extra v0.11.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/triangle_rasterizer.rs:314:9 [INFO] [stderr] | [INFO] [stderr] 314 | x: x, [INFO] [stderr] | ^^^^ help: replace it with: `x` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/triangle_rasterizer.rs:315:9 [INFO] [stderr] | [INFO] [stderr] 315 | y: y, [INFO] [stderr] | ^^^^ help: replace it with: `y` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/triangle_rasterizer.rs:316:9 [INFO] [stderr] | [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] 316 | z: z, [INFO] [stderr] | ^^^^ help: replace it with: `z` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/triangle_rasterizer.rs:317:9 [INFO] [stderr] | [INFO] [stderr] 317 | w: w, [INFO] [stderr] | ^^^^ help: replace it with: `w` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/triangle_rasterizer.rs:314:9 [INFO] [stderr] --> src/image.rs:30:13 [INFO] [stderr] | [INFO] [stderr] | [INFO] [stderr] 30 | width: width, [INFO] [stderr] 314 | x: x, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `width` [INFO] [stderr] | ^^^^ help: replace it with: `x` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/image.rs:31:13 [INFO] [stderr] | [INFO] [stderr] 31 | height: height, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `height` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/image.rs:32:13 [INFO] [stderr] | [INFO] [stderr] 32 | stride: stride, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `stride` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/image.rs:33:13 [INFO] [stderr] | [INFO] [stderr] 33 | pixels: pixels, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `pixels` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/triangle_rasterizer.rs:315:9 [INFO] [stderr] | [INFO] [stderr] 315 | y: y, [INFO] [stderr] | ^^^^ help: replace it with: `y` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/triangle_rasterizer.rs:316:9 [INFO] [stderr] | [INFO] [stderr] 316 | z: z, [INFO] [stderr] | ^^^^ help: replace it with: `z` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/triangle_rasterizer.rs:317:9 [INFO] [stderr] | [INFO] [stderr] 317 | w: w, [INFO] [stderr] | ^^^^ help: replace it with: `w` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/image.rs:30:13 [INFO] [stderr] | [INFO] [stderr] 30 | width: width, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `width` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/image.rs:31:13 [INFO] [stderr] | [INFO] [stderr] 31 | height: height, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `height` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/image.rs:32:13 [INFO] [stderr] | [INFO] [stderr] 32 | stride: stride, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `stride` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/image.rs:33:13 [INFO] [stderr] | [INFO] [stderr] 33 | pixels: pixels, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `pixels` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/triangle_rasterizer.rs:139:5 [INFO] [stderr] | [INFO] [stderr] 139 | return (step_x, step_y, row); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(step_x, step_y, row)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/triangle_rasterizer.rs:191:9 [INFO] [stderr] | [INFO] [stderr] 191 | return (*a * wa + *b * wb + *c * wc) * inv_w; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(*a * wa + *b * wb + *c * wc) * inv_w` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/debugging.rs:34:5 [INFO] [stderr] | [INFO] [stderr] 34 | return polygons; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: remove `return` as shown: `polygons` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/debugging.rs:46:5 [INFO] [stderr] | [INFO] [stderr] 46 | return builder.build(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `builder.build()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/debugging.rs:107:5 [INFO] [stderr] | [INFO] [stderr] 107 | return polygons_to_path(&polygons); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `polygons_to_path(&polygons)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/image.rs:17:9 [INFO] [stderr] | [INFO] [stderr] 17 | return MutableImageSlice::with_stride(width, height, width, pixels); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `MutableImageSlice::with_stride(width, height, width, pixels)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/image.rs:29:9 [INFO] [stderr] | [INFO] [stderr] 29 | / return MutableImageSlice { [INFO] [stderr] 30 | | width: width, [INFO] [stderr] 31 | | height: height, [INFO] [stderr] 32 | | stride: stride, [INFO] [stderr] 33 | | pixels: pixels, [INFO] [stderr] 34 | | }; [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 29 | MutableImageSlice { [INFO] [stderr] 30 | width: width, [INFO] [stderr] 31 | height: height, [INFO] [stderr] 32 | stride: stride, [INFO] [stderr] 33 | pixels: pixels, [INFO] [stderr] 34 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/image.rs:55:13 [INFO] [stderr] | [INFO] [stderr] 55 | / return (MutableImageSlice { [INFO] [stderr] 56 | | width: split, [INFO] [stderr] 57 | | height: self.height, [INFO] [stderr] 58 | | stride: self.stride, [INFO] [stderr] ... | [INFO] [stderr] 65 | | pixels: pixels_right, [INFO] [stderr] 66 | | }); [INFO] [stderr] | |_______________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 55 | (MutableImageSlice { [INFO] [stderr] 56 | width: split, [INFO] [stderr] 57 | height: self.height, [INFO] [stderr] 58 | stride: self.stride, [INFO] [stderr] 59 | pixels: pixels_left, [INFO] [stderr] 60 | }, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/image.rs:84:13 [INFO] [stderr] | [INFO] [stderr] 84 | / return (MutableImageSlice { [INFO] [stderr] 85 | | width: self.width, [INFO] [stderr] 86 | | height: split, [INFO] [stderr] 87 | | stride: self.stride, [INFO] [stderr] ... | [INFO] [stderr] 94 | | pixels: pixels_right, [INFO] [stderr] 95 | | }); [INFO] [stderr] | |_______________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 84 | (MutableImageSlice { [INFO] [stderr] 85 | width: self.width, [INFO] [stderr] 86 | height: split, [INFO] [stderr] 87 | stride: self.stride, [INFO] [stderr] 88 | pixels: pixels_left, [INFO] [stderr] 89 | }, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/triangle_rasterizer.rs:139:5 [INFO] [stderr] | [INFO] [stderr] 139 | return (step_x, step_y, row); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(step_x, step_y, row)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/triangle_rasterizer.rs:191:9 [INFO] [stderr] | [INFO] [stderr] 191 | return (*a * wa + *b * wb + *c * wc) * inv_w; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(*a * wa + *b * wb + *c * wc) * inv_w` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/debugging.rs:34:5 [INFO] [stderr] | [INFO] [stderr] 34 | return polygons; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: remove `return` as shown: `polygons` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/debugging.rs:46:5 [INFO] [stderr] | [INFO] [stderr] 46 | return builder.build(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `builder.build()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/debugging.rs:107:5 [INFO] [stderr] | [INFO] [stderr] 107 | return polygons_to_path(&polygons); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `polygons_to_path(&polygons)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/image.rs:17:9 [INFO] [stderr] | [INFO] [stderr] 17 | return MutableImageSlice::with_stride(width, height, width, pixels); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `MutableImageSlice::with_stride(width, height, width, pixels)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/image.rs:29:9 [INFO] [stderr] | [INFO] [stderr] 29 | / return MutableImageSlice { [INFO] [stderr] 30 | | width: width, [INFO] [stderr] 31 | | height: height, [INFO] [stderr] 32 | | stride: stride, [INFO] [stderr] 33 | | pixels: pixels, [INFO] [stderr] 34 | | }; [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 29 | MutableImageSlice { [INFO] [stderr] 30 | width: width, [INFO] [stderr] 31 | height: height, [INFO] [stderr] 32 | stride: stride, [INFO] [stderr] 33 | pixels: pixels, [INFO] [stderr] 34 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/image.rs:55:13 [INFO] [stderr] | [INFO] [stderr] 55 | / return (MutableImageSlice { [INFO] [stderr] 56 | | width: split, [INFO] [stderr] 57 | | height: self.height, [INFO] [stderr] 58 | | stride: self.stride, [INFO] [stderr] ... | [INFO] [stderr] 65 | | pixels: pixels_right, [INFO] [stderr] 66 | | }); [INFO] [stderr] | |_______________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 55 | (MutableImageSlice { [INFO] [stderr] 56 | width: split, [INFO] [stderr] 57 | height: self.height, [INFO] [stderr] 58 | stride: self.stride, [INFO] [stderr] 59 | pixels: pixels_left, [INFO] [stderr] 60 | }, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/image.rs:84:13 [INFO] [stderr] | [INFO] [stderr] 84 | / return (MutableImageSlice { [INFO] [stderr] 85 | | width: self.width, [INFO] [stderr] 86 | | height: split, [INFO] [stderr] 87 | | stride: self.stride, [INFO] [stderr] ... | [INFO] [stderr] 94 | | pixels: pixels_right, [INFO] [stderr] 95 | | }); [INFO] [stderr] | |_______________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 84 | (MutableImageSlice { [INFO] [stderr] 85 | width: self.width, [INFO] [stderr] 86 | height: split, [INFO] [stderr] 87 | stride: self.stride, [INFO] [stderr] 88 | pixels: pixels_left, [INFO] [stderr] 89 | }, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] error: approximate value of `f{32, 64}::consts::PI` found. Consider using it directly [INFO] [stderr] --> src/rust_logo.rs:246:17 [INFO] [stderr] | [INFO] [stderr] 246 | vector(-3.141, -8.041), [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::approx_constant)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#approx_constant [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/triangle_rasterizer.rs:121:18 [INFO] [stderr] | [INFO] [stderr] 121 | fn init_edge(v0: &IntVector, v1: &IntVector, origin: &IntVector) -> (IntVec4, IntVec4, IntVec4) { [INFO] [stderr] | ^^^^^^^^^^ help: consider passing by value instead: `IntVector` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/triangle_rasterizer.rs:121:34 [INFO] [stderr] | [INFO] [stderr] 121 | fn init_edge(v0: &IntVector, v1: &IntVector, origin: &IntVector) -> (IntVec4, IntVec4, IntVec4) { [INFO] [stderr] | ^^^^^^^^^^ help: consider passing by value instead: `IntVector` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/triangle_rasterizer.rs:121:54 [INFO] [stderr] | [INFO] [stderr] 121 | fn init_edge(v0: &IntVector, v1: &IntVector, origin: &IntVector) -> (IntVec4, IntVec4, IntVec4) { [INFO] [stderr] | ^^^^^^^^^^ help: consider passing by value instead: `IntVector` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/triangle_rasterizer.rs:342:18 [INFO] [stderr] | [INFO] [stderr] 342 | pub fn tuple(&self) -> (bool, bool, bool, bool) { (self.x, self.y, self.z, self.w) } [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/triangle_rasterizer.rs:345:18 [INFO] [stderr] | [INFO] [stderr] 345 | pub fn array(&self) -> [bool; 4] { [self.x, self.y, self.z, self.w] } [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/debugging.rs:15:20 [INFO] [stderr] | [INFO] [stderr] 15 | if poly.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!poly.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/debugging.rs:37:35 [INFO] [stderr] | [INFO] [stderr] 37 | pub fn polygons_to_path(polygons: &Polygons) -> Path { [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `poly`. [INFO] [stderr] --> src/debugging.rs:41:18 [INFO] [stderr] | [INFO] [stderr] 41 | for i in 1..poly.len() { [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 41 | for in poly.iter().skip(1) { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the loop variable `p` is only used to index `polygons`. [INFO] [stderr] --> src/debugging.rs:90:14 [INFO] [stderr] | [INFO] [stderr] 90 | for p in 0..polygons.len() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 90 | for in &polygons { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/image.rs:49:33 [INFO] [stderr] | [INFO] [stderr] 49 | let q: *mut Pixel = p.offset(split as isize); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `p.add(split)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_offset_with_cast)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/image.rs:78:33 [INFO] [stderr] | [INFO] [stderr] 78 | let q: *mut Pixel = p.offset((self.stride * split) as isize); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `p.add((self.stride * split))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] error: approximate value of `f{32, 64}::consts::PI` found. Consider using it directly [INFO] [stderr] --> src/rust_logo.rs:246:17 [INFO] [stderr] | [INFO] [stderr] 246 | vector(-3.141, -8.041), [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::approx_constant)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#approx_constant [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/triangle_rasterizer.rs:121:18 [INFO] [stderr] | [INFO] [stderr] 121 | fn init_edge(v0: &IntVector, v1: &IntVector, origin: &IntVector) -> (IntVec4, IntVec4, IntVec4) { [INFO] [stderr] | ^^^^^^^^^^ help: consider passing by value instead: `IntVector` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/triangle_rasterizer.rs:121:34 [INFO] [stderr] | [INFO] [stderr] 121 | fn init_edge(v0: &IntVector, v1: &IntVector, origin: &IntVector) -> (IntVec4, IntVec4, IntVec4) { [INFO] [stderr] | ^^^^^^^^^^ help: consider passing by value instead: `IntVector` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/triangle_rasterizer.rs:121:54 [INFO] [stderr] | [INFO] [stderr] 121 | fn init_edge(v0: &IntVector, v1: &IntVector, origin: &IntVector) -> (IntVec4, IntVec4, IntVec4) { [INFO] [stderr] | ^^^^^^^^^^ help: consider passing by value instead: `IntVector` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] error: Could not compile `lyon_extra`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/triangle_rasterizer.rs:342:18 [INFO] [stderr] | [INFO] [stderr] 342 | pub fn tuple(&self) -> (bool, bool, bool, bool) { (self.x, self.y, self.z, self.w) } [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/triangle_rasterizer.rs:345:18 [INFO] [stderr] | [INFO] [stderr] 345 | pub fn array(&self) -> [bool; 4] { [self.x, self.y, self.z, self.w] } [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/debugging.rs:15:20 [INFO] [stderr] | [INFO] [stderr] 15 | if poly.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!poly.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/debugging.rs:37:35 [INFO] [stderr] | [INFO] [stderr] 37 | pub fn polygons_to_path(polygons: &Polygons) -> Path { [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `poly`. [INFO] [stderr] --> src/debugging.rs:41:18 [INFO] [stderr] | [INFO] [stderr] 41 | for i in 1..poly.len() { [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 41 | for in poly.iter().skip(1) { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the loop variable `p` is only used to index `polygons`. [INFO] [stderr] --> src/debugging.rs:90:14 [INFO] [stderr] | [INFO] [stderr] 90 | for p in 0..polygons.len() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 90 | for in &polygons { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/image.rs:49:33 [INFO] [stderr] | [INFO] [stderr] 49 | let q: *mut Pixel = p.offset(split as isize); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `p.add(split)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_offset_with_cast)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/image.rs:78:33 [INFO] [stderr] | [INFO] [stderr] 78 | let q: *mut Pixel = p.offset((self.stride * split) as isize); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `p.add((self.stride * split))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `lyon_extra`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "4adf40454dba4ae095b13ed804f1972079ff7ab27551b5a4dbfadda8fb685fd2"` [INFO] running `"docker" "rm" "-f" "4adf40454dba4ae095b13ed804f1972079ff7ab27551b5a4dbfadda8fb685fd2"` [INFO] [stdout] 4adf40454dba4ae095b13ed804f1972079ff7ab27551b5a4dbfadda8fb685fd2