[INFO] crate lyon_core 0.8.0 is already in cache [INFO] extracting crate lyon_core 0.8.0 into work/ex/clippy-test-run/sources/stable/reg/lyon_core/0.8.0 [INFO] extracting crate lyon_core 0.8.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/lyon_core/0.8.0 [INFO] validating manifest of lyon_core-0.8.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of lyon_core-0.8.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing lyon_core-0.8.0 [INFO] finished frobbing lyon_core-0.8.0 [INFO] frobbed toml for lyon_core-0.8.0 written to work/ex/clippy-test-run/sources/stable/reg/lyon_core/0.8.0/Cargo.toml [INFO] started frobbing lyon_core-0.8.0 [INFO] finished frobbing lyon_core-0.8.0 [INFO] frobbed toml for lyon_core-0.8.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/lyon_core/0.8.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting lyon_core-0.8.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/lyon_core/0.8.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 9e2b03f0cf12409d06c2f134d68fdd3634b4bf933f063fc08de03ae296268d9a [INFO] running `"docker" "start" "-a" "9e2b03f0cf12409d06c2f134d68fdd3634b4bf933f063fc08de03ae296268d9a"` [INFO] [stderr] Checking euclid v0.15.6 [INFO] [stderr] Checking lyon_core v0.8.0 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/events.rs:53:9 [INFO] [stderr] | [INFO] [stderr] 53 | / return match self { [INFO] [stderr] 54 | | PathEvent::MoveTo(to) => SvgEvent::MoveTo(to), [INFO] [stderr] 55 | | PathEvent::LineTo(to) => SvgEvent::LineTo(to), [INFO] [stderr] 56 | | PathEvent::QuadraticTo(ctrl, to) => SvgEvent::QuadraticTo(ctrl, to), [INFO] [stderr] 57 | | PathEvent::CubicTo(ctrl1, ctrl2, to) => SvgEvent::CubicTo(ctrl1, ctrl2, to), [INFO] [stderr] 58 | | PathEvent::Close => SvgEvent::Close, [INFO] [stderr] 59 | | }; [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 53 | match self { [INFO] [stderr] 54 | PathEvent::MoveTo(to) => SvgEvent::MoveTo(to), [INFO] [stderr] 55 | PathEvent::LineTo(to) => SvgEvent::LineTo(to), [INFO] [stderr] 56 | PathEvent::QuadraticTo(ctrl, to) => SvgEvent::QuadraticTo(ctrl, to), [INFO] [stderr] 57 | PathEvent::CubicTo(ctrl1, ctrl2, to) => SvgEvent::CubicTo(ctrl1, ctrl2, to), [INFO] [stderr] 58 | PathEvent::Close => SvgEvent::Close, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/events.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | / return match self { [INFO] [stderr] 64 | | PathEvent::MoveTo(to) => Some(to), [INFO] [stderr] 65 | | PathEvent::LineTo(to) => Some(to), [INFO] [stderr] 66 | | PathEvent::QuadraticTo(_, to) => Some(to), [INFO] [stderr] 67 | | PathEvent::CubicTo(_, _, to) => Some(to), [INFO] [stderr] 68 | | PathEvent::Close => None, [INFO] [stderr] 69 | | }; [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 63 | match self { [INFO] [stderr] 64 | PathEvent::MoveTo(to) => Some(to), [INFO] [stderr] 65 | PathEvent::LineTo(to) => Some(to), [INFO] [stderr] 66 | PathEvent::QuadraticTo(_, to) => Some(to), [INFO] [stderr] 67 | PathEvent::CubicTo(_, _, to) => Some(to), [INFO] [stderr] 68 | PathEvent::Close => None, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/events.rs:75:9 [INFO] [stderr] | [INFO] [stderr] 75 | / return match self { [INFO] [stderr] 76 | | FlattenedEvent::MoveTo(to) => SvgEvent::MoveTo(to), [INFO] [stderr] 77 | | FlattenedEvent::LineTo(to) => SvgEvent::LineTo(to), [INFO] [stderr] 78 | | FlattenedEvent::Close => SvgEvent::Close, [INFO] [stderr] 79 | | }; [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 75 | match self { [INFO] [stderr] 76 | FlattenedEvent::MoveTo(to) => SvgEvent::MoveTo(to), [INFO] [stderr] 77 | FlattenedEvent::LineTo(to) => SvgEvent::LineTo(to), [INFO] [stderr] 78 | FlattenedEvent::Close => SvgEvent::Close, [INFO] [stderr] 79 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/events.rs:83:9 [INFO] [stderr] | [INFO] [stderr] 83 | / return match self { [INFO] [stderr] 84 | | FlattenedEvent::MoveTo(to) => PathEvent::MoveTo(to), [INFO] [stderr] 85 | | FlattenedEvent::LineTo(to) => PathEvent::LineTo(to), [INFO] [stderr] 86 | | FlattenedEvent::Close => PathEvent::Close, [INFO] [stderr] 87 | | }; [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 83 | match self { [INFO] [stderr] 84 | FlattenedEvent::MoveTo(to) => PathEvent::MoveTo(to), [INFO] [stderr] 85 | FlattenedEvent::LineTo(to) => PathEvent::LineTo(to), [INFO] [stderr] 86 | FlattenedEvent::Close => PathEvent::Close, [INFO] [stderr] 87 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/fixed.rs:343:9 [INFO] [stderr] | [INFO] [stderr] 343 | return tmp.to_fixed(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `tmp.to_fixed()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/fixed.rs:382:9 [INFO] [stderr] | [INFO] [stderr] 382 | return Fp32::from_raw(tmp.bits as i32); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Fp32::from_raw(tmp.bits as i32)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/events.rs:53:9 [INFO] [stderr] | [INFO] [stderr] 53 | / return match self { [INFO] [stderr] 54 | | PathEvent::MoveTo(to) => SvgEvent::MoveTo(to), [INFO] [stderr] 55 | | PathEvent::LineTo(to) => SvgEvent::LineTo(to), [INFO] [stderr] 56 | | PathEvent::QuadraticTo(ctrl, to) => SvgEvent::QuadraticTo(ctrl, to), [INFO] [stderr] 57 | | PathEvent::CubicTo(ctrl1, ctrl2, to) => SvgEvent::CubicTo(ctrl1, ctrl2, to), [INFO] [stderr] 58 | | PathEvent::Close => SvgEvent::Close, [INFO] [stderr] 59 | | }; [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 53 | match self { [INFO] [stderr] 54 | PathEvent::MoveTo(to) => SvgEvent::MoveTo(to), [INFO] [stderr] 55 | PathEvent::LineTo(to) => SvgEvent::LineTo(to), [INFO] [stderr] 56 | PathEvent::QuadraticTo(ctrl, to) => SvgEvent::QuadraticTo(ctrl, to), [INFO] [stderr] 57 | PathEvent::CubicTo(ctrl1, ctrl2, to) => SvgEvent::CubicTo(ctrl1, ctrl2, to), [INFO] [stderr] 58 | PathEvent::Close => SvgEvent::Close, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/events.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | / return match self { [INFO] [stderr] 64 | | PathEvent::MoveTo(to) => Some(to), [INFO] [stderr] 65 | | PathEvent::LineTo(to) => Some(to), [INFO] [stderr] 66 | | PathEvent::QuadraticTo(_, to) => Some(to), [INFO] [stderr] 67 | | PathEvent::CubicTo(_, _, to) => Some(to), [INFO] [stderr] 68 | | PathEvent::Close => None, [INFO] [stderr] 69 | | }; [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 63 | match self { [INFO] [stderr] 64 | PathEvent::MoveTo(to) => Some(to), [INFO] [stderr] 65 | PathEvent::LineTo(to) => Some(to), [INFO] [stderr] 66 | PathEvent::QuadraticTo(_, to) => Some(to), [INFO] [stderr] 67 | PathEvent::CubicTo(_, _, to) => Some(to), [INFO] [stderr] 68 | PathEvent::Close => None, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/events.rs:75:9 [INFO] [stderr] | [INFO] [stderr] 75 | / return match self { [INFO] [stderr] 76 | | FlattenedEvent::MoveTo(to) => SvgEvent::MoveTo(to), [INFO] [stderr] 77 | | FlattenedEvent::LineTo(to) => SvgEvent::LineTo(to), [INFO] [stderr] 78 | | FlattenedEvent::Close => SvgEvent::Close, [INFO] [stderr] 79 | | }; [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 75 | match self { [INFO] [stderr] 76 | FlattenedEvent::MoveTo(to) => SvgEvent::MoveTo(to), [INFO] [stderr] 77 | FlattenedEvent::LineTo(to) => SvgEvent::LineTo(to), [INFO] [stderr] 78 | FlattenedEvent::Close => SvgEvent::Close, [INFO] [stderr] 79 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/events.rs:83:9 [INFO] [stderr] | [INFO] [stderr] 83 | / return match self { [INFO] [stderr] 84 | | FlattenedEvent::MoveTo(to) => PathEvent::MoveTo(to), [INFO] [stderr] 85 | | FlattenedEvent::LineTo(to) => PathEvent::LineTo(to), [INFO] [stderr] 86 | | FlattenedEvent::Close => PathEvent::Close, [INFO] [stderr] 87 | | }; [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 83 | match self { [INFO] [stderr] 84 | FlattenedEvent::MoveTo(to) => PathEvent::MoveTo(to), [INFO] [stderr] 85 | FlattenedEvent::LineTo(to) => PathEvent::LineTo(to), [INFO] [stderr] 86 | FlattenedEvent::Close => PathEvent::Close, [INFO] [stderr] 87 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/fixed.rs:343:9 [INFO] [stderr] | [INFO] [stderr] 343 | return tmp.to_fixed(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `tmp.to_fixed()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/fixed.rs:382:9 [INFO] [stderr] | [INFO] [stderr] 382 | return Fp32::from_raw(tmp.bits as i32); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Fp32::from_raw(tmp.bits as i32)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `path_state::PathState` [INFO] [stderr] --> src/path_state.rs:17:5 [INFO] [stderr] | [INFO] [stderr] 17 | / pub fn new() -> Self { [INFO] [stderr] 18 | | PathState { [INFO] [stderr] 19 | | current: point(0.0, 0.0), [INFO] [stderr] 20 | | first: point(0.0, 0.0), [INFO] [stderr] 21 | | last_ctrl: point(0.0, 0.0), [INFO] [stderr] 22 | | } [INFO] [stderr] 23 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 16 | impl Default for path_state::PathState { [INFO] [stderr] 17 | fn default() -> Self { [INFO] [stderr] 18 | Self::new() [INFO] [stderr] 19 | } [INFO] [stderr] 20 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: methods called `from_*` usually take no self; consider choosing a less ambiguous name [INFO] [stderr] --> src/path_state.rs:165:26 [INFO] [stderr] | [INFO] [stderr] 165 | pub fn from_relative(&self, v: Vec2) -> Point { self.current + v } [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::wrong_self_convention)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/fixed.rs:154:71 [INFO] [stderr] | [INFO] [stderr] 154 | pub fn from_f64(val: f64) -> Self { Self::from_raw((val * (1 << F::bits()) as f64) as $bits_type) } // TODO [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(1 << F::bits())` [INFO] [stderr] ... [INFO] [stderr] 311 | impl_fixed_point!(Fp64: i64); [INFO] [stderr] | ----------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/fixed.rs:158:61 [INFO] [stderr] | [INFO] [stderr] 158 | pub fn to_f64(self) -> f64 { self.bits as f64 / (1 << F::bits()) as f64 } // TODO [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(1 << F::bits())` [INFO] [stderr] ... [INFO] [stderr] 311 | impl_fixed_point!(Fp64: i64); [INFO] [stderr] | ----------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: defining a method called `rem` on this type; consider implementing the `std::ops::Rem` trait or choosing a less ambiguous name [INFO] [stderr] --> src/fixed.rs:166:13 [INFO] [stderr] | [INFO] [stderr] 166 | pub fn rem(self, other: Self) -> Self { Self::from_raw(self.bits % other.bits) } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 311 | impl_fixed_point!(Fp64: i64); [INFO] [stderr] | ----------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::should_implement_trait)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/fixed.rs:154:71 [INFO] [stderr] | [INFO] [stderr] 154 | pub fn from_f64(val: f64) -> Self { Self::from_raw((val * (1 << F::bits()) as f64) as $bits_type) } // TODO [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(1 << F::bits())` [INFO] [stderr] ... [INFO] [stderr] 313 | impl_fixed_point!(Fp32: i32); [INFO] [stderr] | ----------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/fixed.rs:158:42 [INFO] [stderr] | [INFO] [stderr] 158 | pub fn to_f64(self) -> f64 { self.bits as f64 / (1 << F::bits()) as f64 } // TODO [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `f64::from(self.bits)` [INFO] [stderr] ... [INFO] [stderr] 313 | impl_fixed_point!(Fp32: i32); [INFO] [stderr] | ----------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/fixed.rs:158:61 [INFO] [stderr] | [INFO] [stderr] 158 | pub fn to_f64(self) -> f64 { self.bits as f64 / (1 << F::bits()) as f64 } // TODO [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(1 << F::bits())` [INFO] [stderr] ... [INFO] [stderr] 313 | impl_fixed_point!(Fp32: i32); [INFO] [stderr] | ----------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: defining a method called `rem` on this type; consider implementing the `std::ops::Rem` trait or choosing a less ambiguous name [INFO] [stderr] --> src/fixed.rs:166:13 [INFO] [stderr] | [INFO] [stderr] 166 | pub fn rem(self, other: Self) -> Self { Self::from_raw(self.bits % other.bits) } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 313 | impl_fixed_point!(Fp32: i32); [INFO] [stderr] | ----------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait [INFO] [stderr] [INFO] [stderr] warning: casting i32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/fixed.rs:253:35 [INFO] [stderr] | [INFO] [stderr] 253 | $name::from_raw(((self.bits as i64 * other.bits as i64) >> F::bits()) as $bits_type) [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `i64::from(self.bits)` [INFO] [stderr] ... [INFO] [stderr] 313 | impl_fixed_point!(Fp32: i32); [INFO] [stderr] | ----------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/fixed.rs:253:54 [INFO] [stderr] | [INFO] [stderr] 253 | $name::from_raw(((self.bits as i64 * other.bits as i64) >> F::bits()) as $bits_type) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `i64::from(other.bits)` [INFO] [stderr] ... [INFO] [stderr] 313 | impl_fixed_point!(Fp32: i32); [INFO] [stderr] | ----------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/fixed.rs:330:25 [INFO] [stderr] | [INFO] [stderr] 330 | Fp32::from_raw((self.bits as i64 * m.bits as i64 / d.bits as i64) as i32) [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `i64::from(self.bits)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/fixed.rs:330:44 [INFO] [stderr] | [INFO] [stderr] 330 | Fp32::from_raw((self.bits as i64 * m.bits as i64 / d.bits as i64) as i32) [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `i64::from(m.bits)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/fixed.rs:330:60 [INFO] [stderr] | [INFO] [stderr] 330 | Fp32::from_raw((self.bits as i64 * m.bits as i64 / d.bits as i64) as i32) [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `i64::from(d.bits)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/fixed.rs:342:43 [INFO] [stderr] | [INFO] [stderr] 342 | let tmp: Fp64 = Fp64::from_raw(self.bits as i64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `i64::from(self.bits)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: Suspicious use of binary operator in `Div` impl [INFO] [stderr] --> src/fixed.rs:357:46 [INFO] [stderr] | [INFO] [stderr] 357 | let self64: i64 = (self.bits as i64) << 32; [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::suspicious_arithmetic_impl)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_arithmetic_impl [INFO] [stderr] [INFO] [stderr] warning: casting i32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/fixed.rs:357:27 [INFO] [stderr] | [INFO] [stderr] 357 | let self64: i64 = (self.bits as i64) << 32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `i64::from(self.bits)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/fixed.rs:358:28 [INFO] [stderr] | [INFO] [stderr] 358 | let other64: i64 = other.bits as i64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `i64::from(other.bits)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `lyon_core`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: you should consider adding a `Default` implementation for `path_state::PathState` [INFO] [stderr] --> src/path_state.rs:17:5 [INFO] [stderr] | [INFO] [stderr] 17 | / pub fn new() -> Self { [INFO] [stderr] 18 | | PathState { [INFO] [stderr] 19 | | current: point(0.0, 0.0), [INFO] [stderr] 20 | | first: point(0.0, 0.0), [INFO] [stderr] 21 | | last_ctrl: point(0.0, 0.0), [INFO] [stderr] 22 | | } [INFO] [stderr] 23 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 16 | impl Default for path_state::PathState { [INFO] [stderr] 17 | fn default() -> Self { [INFO] [stderr] 18 | Self::new() [INFO] [stderr] 19 | } [INFO] [stderr] 20 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: methods called `from_*` usually take no self; consider choosing a less ambiguous name [INFO] [stderr] --> src/path_state.rs:165:26 [INFO] [stderr] | [INFO] [stderr] 165 | pub fn from_relative(&self, v: Vec2) -> Point { self.current + v } [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::wrong_self_convention)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/fixed.rs:154:71 [INFO] [stderr] | [INFO] [stderr] 154 | pub fn from_f64(val: f64) -> Self { Self::from_raw((val * (1 << F::bits()) as f64) as $bits_type) } // TODO [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(1 << F::bits())` [INFO] [stderr] ... [INFO] [stderr] 311 | impl_fixed_point!(Fp64: i64); [INFO] [stderr] | ----------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/fixed.rs:158:61 [INFO] [stderr] | [INFO] [stderr] 158 | pub fn to_f64(self) -> f64 { self.bits as f64 / (1 << F::bits()) as f64 } // TODO [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(1 << F::bits())` [INFO] [stderr] ... [INFO] [stderr] 311 | impl_fixed_point!(Fp64: i64); [INFO] [stderr] | ----------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: defining a method called `rem` on this type; consider implementing the `std::ops::Rem` trait or choosing a less ambiguous name [INFO] [stderr] --> src/fixed.rs:166:13 [INFO] [stderr] | [INFO] [stderr] 166 | pub fn rem(self, other: Self) -> Self { Self::from_raw(self.bits % other.bits) } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 311 | impl_fixed_point!(Fp64: i64); [INFO] [stderr] | ----------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::should_implement_trait)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/fixed.rs:154:71 [INFO] [stderr] | [INFO] [stderr] 154 | pub fn from_f64(val: f64) -> Self { Self::from_raw((val * (1 << F::bits()) as f64) as $bits_type) } // TODO [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(1 << F::bits())` [INFO] [stderr] ... [INFO] [stderr] 313 | impl_fixed_point!(Fp32: i32); [INFO] [stderr] | ----------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/fixed.rs:158:42 [INFO] [stderr] | [INFO] [stderr] 158 | pub fn to_f64(self) -> f64 { self.bits as f64 / (1 << F::bits()) as f64 } // TODO [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `f64::from(self.bits)` [INFO] [stderr] ... [INFO] [stderr] 313 | impl_fixed_point!(Fp32: i32); [INFO] [stderr] | ----------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/fixed.rs:158:61 [INFO] [stderr] | [INFO] [stderr] 158 | pub fn to_f64(self) -> f64 { self.bits as f64 / (1 << F::bits()) as f64 } // TODO [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(1 << F::bits())` [INFO] [stderr] ... [INFO] [stderr] 313 | impl_fixed_point!(Fp32: i32); [INFO] [stderr] | ----------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: defining a method called `rem` on this type; consider implementing the `std::ops::Rem` trait or choosing a less ambiguous name [INFO] [stderr] --> src/fixed.rs:166:13 [INFO] [stderr] | [INFO] [stderr] 166 | pub fn rem(self, other: Self) -> Self { Self::from_raw(self.bits % other.bits) } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 313 | impl_fixed_point!(Fp32: i32); [INFO] [stderr] | ----------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait [INFO] [stderr] [INFO] [stderr] warning: casting i32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/fixed.rs:253:35 [INFO] [stderr] | [INFO] [stderr] 253 | $name::from_raw(((self.bits as i64 * other.bits as i64) >> F::bits()) as $bits_type) [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `i64::from(self.bits)` [INFO] [stderr] ... [INFO] [stderr] 313 | impl_fixed_point!(Fp32: i32); [INFO] [stderr] | ----------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/fixed.rs:253:54 [INFO] [stderr] | [INFO] [stderr] 253 | $name::from_raw(((self.bits as i64 * other.bits as i64) >> F::bits()) as $bits_type) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `i64::from(other.bits)` [INFO] [stderr] ... [INFO] [stderr] 313 | impl_fixed_point!(Fp32: i32); [INFO] [stderr] | ----------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/fixed.rs:330:25 [INFO] [stderr] | [INFO] [stderr] 330 | Fp32::from_raw((self.bits as i64 * m.bits as i64 / d.bits as i64) as i32) [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `i64::from(self.bits)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/fixed.rs:330:44 [INFO] [stderr] | [INFO] [stderr] 330 | Fp32::from_raw((self.bits as i64 * m.bits as i64 / d.bits as i64) as i32) [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `i64::from(m.bits)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/fixed.rs:330:60 [INFO] [stderr] | [INFO] [stderr] 330 | Fp32::from_raw((self.bits as i64 * m.bits as i64 / d.bits as i64) as i32) [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `i64::from(d.bits)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/fixed.rs:342:43 [INFO] [stderr] | [INFO] [stderr] 342 | let tmp: Fp64 = Fp64::from_raw(self.bits as i64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `i64::from(self.bits)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: Suspicious use of binary operator in `Div` impl [INFO] [stderr] --> src/fixed.rs:357:46 [INFO] [stderr] | [INFO] [stderr] 357 | let self64: i64 = (self.bits as i64) << 32; [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::suspicious_arithmetic_impl)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_arithmetic_impl [INFO] [stderr] [INFO] [stderr] warning: casting i32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/fixed.rs:357:27 [INFO] [stderr] | [INFO] [stderr] 357 | let self64: i64 = (self.bits as i64) << 32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `i64::from(self.bits)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/fixed.rs:358:28 [INFO] [stderr] | [INFO] [stderr] 358 | let other64: i64 = other.bits as i64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `i64::from(other.bits)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `lyon_core`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "9e2b03f0cf12409d06c2f134d68fdd3634b4bf933f063fc08de03ae296268d9a"` [INFO] running `"docker" "rm" "-f" "9e2b03f0cf12409d06c2f134d68fdd3634b4bf933f063fc08de03ae296268d9a"` [INFO] [stdout] 9e2b03f0cf12409d06c2f134d68fdd3634b4bf933f063fc08de03ae296268d9a