[INFO] crate lv2_raw 0.2.0 is already in cache [INFO] extracting crate lv2_raw 0.2.0 into work/ex/clippy-test-run/sources/stable/reg/lv2_raw/0.2.0 [INFO] extracting crate lv2_raw 0.2.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/lv2_raw/0.2.0 [INFO] validating manifest of lv2_raw-0.2.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of lv2_raw-0.2.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing lv2_raw-0.2.0 [INFO] finished frobbing lv2_raw-0.2.0 [INFO] frobbed toml for lv2_raw-0.2.0 written to work/ex/clippy-test-run/sources/stable/reg/lv2_raw/0.2.0/Cargo.toml [INFO] started frobbing lv2_raw-0.2.0 [INFO] finished frobbing lv2_raw-0.2.0 [INFO] frobbed toml for lv2_raw-0.2.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/lv2_raw/0.2.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting lv2_raw-0.2.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/lv2_raw/0.2.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 3b3a7ef50020d79a1903be30ba0d85f0938e30978ae19e505e304150329ba07e [INFO] running `"docker" "start" "-a" "3b3a7ef50020d79a1903be30ba0d85f0938e30978ae19e505e304150329ba07e"` [INFO] [stderr] Checking lv2_raw v0.2.0 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/atom.rs:220:57 [INFO] [stderr] | [INFO] [stderr] 220 | pub unsafe fn foreach(&mut self, mut closure: F) -> () [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unused_unit)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/atom.rs:292:57 [INFO] [stderr] | [INFO] [stderr] 292 | pub unsafe fn foreach(&mut self, mut closure: F) -> () [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/coreutils.rs:101:5 [INFO] [stderr] | [INFO] [stderr] 101 | return 0 as *const c_char; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `0 as *const c_char` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/atomutils.rs:72:5 [INFO] [stderr] | [INFO] [stderr] 72 | result [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/atomutils.rs:71:18 [INFO] [stderr] | [INFO] [stderr] 71 | let result = i as *const u8 >= (body as *const u8).offset(size as isize); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/atomutils.rs:89:66 [INFO] [stderr] | [INFO] [stderr] 89 | pub unsafe fn lv2_atom_sequence_clear(seq: *mut LV2AtomSequence) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/atomutils.rs:221:5 [INFO] [stderr] | [INFO] [stderr] 221 | return matches; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: remove `return` as shown: `matches` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/atomutils.rs:282:5 [INFO] [stderr] | [INFO] [stderr] 282 | return matches; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: remove `return` as shown: `matches` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/atomutils.rs:276:13 [INFO] [stderr] | [INFO] [stderr] 276 | return true; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `true` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/atomutils.rs:286:68 [INFO] [stderr] | [INFO] [stderr] 286 | pub unsafe fn foreach(&mut self, size: u32, mut closure: F) -> () [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/atomutils.rs:200:17 [INFO] [stderr] | [INFO] [stderr] 200 | let mut q = query; [INFO] [stderr] | ----^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/atom.rs:220:57 [INFO] [stderr] | [INFO] [stderr] 220 | pub unsafe fn foreach(&mut self, mut closure: F) -> () [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unused_unit)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/atom.rs:292:57 [INFO] [stderr] | [INFO] [stderr] 292 | pub unsafe fn foreach(&mut self, mut closure: F) -> () [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/coreutils.rs:101:5 [INFO] [stderr] | [INFO] [stderr] 101 | return 0 as *const c_char; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `0 as *const c_char` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/atomutils.rs:72:5 [INFO] [stderr] | [INFO] [stderr] 72 | result [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/atomutils.rs:71:18 [INFO] [stderr] | [INFO] [stderr] 71 | let result = i as *const u8 >= (body as *const u8).offset(size as isize); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/atomutils.rs:89:66 [INFO] [stderr] | [INFO] [stderr] 89 | pub unsafe fn lv2_atom_sequence_clear(seq: *mut LV2AtomSequence) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/atomutils.rs:221:5 [INFO] [stderr] | [INFO] [stderr] 221 | return matches; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: remove `return` as shown: `matches` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/atomutils.rs:282:5 [INFO] [stderr] | [INFO] [stderr] 282 | return matches; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: remove `return` as shown: `matches` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/atomutils.rs:276:13 [INFO] [stderr] | [INFO] [stderr] 276 | return true; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `true` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/atomutils.rs:286:68 [INFO] [stderr] | [INFO] [stderr] 286 | pub unsafe fn foreach(&mut self, size: u32, mut closure: F) -> () [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: transmute from a `i64` to a `f64` [INFO] [stderr] --> src/atom.rs:252:18 [INFO] [stderr] | [INFO] [stderr] 252 | unsafe { transmute::(self.time_in_frames) } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using: `f64::from_bits(self.time_in_frames as u64)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::transmute_int_to_float)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_int_to_float [INFO] [stderr] [INFO] [stderr] warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name [INFO] [stderr] --> src/midi.rs:124:18 [INFO] [stderr] | [INFO] [stderr] 124 | pub fn to_u8(self) -> u8 { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::wrong_self_convention)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: `0 as *const _` detected. Consider using `ptr::null()` [INFO] [stderr] --> src/coreutils.rs:41:19 [INFO] [stderr] | [INFO] [stderr] 41 | let nul = 0 as *const LV2Feature; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::zero_ptr)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zero_ptr [INFO] [stderr] [INFO] [stderr] warning: `0 as *mut _` detected. Consider using `ptr::null_mut()` [INFO] [stderr] --> src/coreutils.rs:56:5 [INFO] [stderr] | [INFO] [stderr] 56 | 0 as *mut c_void [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zero_ptr [INFO] [stderr] [INFO] [stderr] warning: `0 as *const _` detected. Consider using `ptr::null()` [INFO] [stderr] --> src/coreutils.rs:101:12 [INFO] [stderr] | [INFO] [stderr] 101 | return 0 as *const c_char; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zero_ptr [INFO] [stderr] [INFO] [stderr] error: casting from `*const atom::LV2AtomSequenceBody` to a more-strictly-aligned pointer (`*mut atom::LV2AtomEvent`) [INFO] [stderr] --> src/atomutils.rs:54:5 [INFO] [stderr] | [INFO] [stderr] 54 | body.offset(1) as *mut LV2AtomEvent [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::cast_ptr_alignment)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_ptr_alignment [INFO] [stderr] [INFO] [stderr] error: casting from `*const u8` to a more-strictly-aligned pointer (`*const atom::LV2AtomEvent`) [INFO] [stderr] --> src/atomutils.rs:62:5 [INFO] [stderr] | [INFO] [stderr] 62 | (body as *const u8).offset(lv2_atom_pad_size(size) as isize) as *const LV2AtomEvent [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_ptr_alignment [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/atomutils.rs:79:15 [INFO] [stderr] | [INFO] [stderr] 79 | let ptr = (i as *const u8).offset(off as isize); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(i as *const u8).add(off)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_offset_with_cast)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] error: casting from `*const u8` to a more-strictly-aligned pointer (`*mut atom::LV2AtomEvent`) [INFO] [stderr] --> src/atomutils.rs:81:5 [INFO] [stderr] | [INFO] [stderr] 81 | ptr as *mut LV2AtomEvent [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_ptr_alignment [INFO] [stderr] [INFO] [stderr] warning: `0 as *const _` detected. Consider using `ptr::null()` [INFO] [stderr] --> src/atomutils.rs:113:16 [INFO] [stderr] | [INFO] [stderr] 113 | return 0 as *const LV2AtomEvent; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zero_ptr [INFO] [stderr] [INFO] [stderr] error: casting from `*const u8` to a more-strictly-aligned pointer (`*const atom::LV2Atom`) [INFO] [stderr] --> src/atomutils.rs:144:17 [INFO] [stderr] | [INFO] [stderr] 144 | let value = (i as *const u8).offset((2 * size_of::()) as isize) as *const LV2Atom; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_ptr_alignment [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/atomutils.rs:144:17 [INFO] [stderr] | [INFO] [stderr] 144 | let value = (i as *const u8).offset((2 * size_of::()) as isize) as *const LV2Atom; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(i as *const u8).add((2 * size_of::()))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] error: casting from `*mut u8` to a more-strictly-aligned pointer (`*mut atom::LV2AtomPropertyBody`) [INFO] [stderr] --> src/atomutils.rs:147:5 [INFO] [stderr] | [INFO] [stderr] 147 | (i as *mut u8).offset(offset as isize) as *mut LV2AtomPropertyBody [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_ptr_alignment [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/atomutils.rs:187:9 [INFO] [stderr] | [INFO] [stderr] 187 | let ref mut object = *obj; [INFO] [stderr] | ----^^^^^^^^^^^^^^-------- help: try: `let object = &mut (*obj);` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] error: Variable in the condition are not mutated in the loop body. This either leads to an infinite or to a never running loop. [INFO] [stderr] --> src/atomutils.rs:193:11 [INFO] [stderr] | [INFO] [stderr] 193 | while (*q).key != 0 { [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::while_immutable_condition)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_immutable_condition [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/atomutils.rs:204:25 [INFO] [stderr] | [INFO] [stderr] 204 | let ref mut val = (*prop).value; [INFO] [stderr] | ----^^^^^^^^^^^----------------- help: try: `let val = &mut (*prop).value;` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: the variable `n_queries` is used as a loop counter. Consider using `for (n_queries, item) in query.enumerate()` or similar iterators [INFO] [stderr] --> src/atomutils.rs:254:15 [INFO] [stderr] | [INFO] [stderr] 254 | for it in query { [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::explicit_counter_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop [INFO] [stderr] [INFO] [stderr] error: aborting due to 6 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `lv2_raw`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/atomutils.rs:200:17 [INFO] [stderr] | [INFO] [stderr] 200 | let mut q = query; [INFO] [stderr] | ----^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: transmute from a `i64` to a `f64` [INFO] [stderr] --> src/atom.rs:252:18 [INFO] [stderr] | [INFO] [stderr] 252 | unsafe { transmute::(self.time_in_frames) } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using: `f64::from_bits(self.time_in_frames as u64)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::transmute_int_to_float)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#transmute_int_to_float [INFO] [stderr] [INFO] [stderr] warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name [INFO] [stderr] --> src/midi.rs:124:18 [INFO] [stderr] | [INFO] [stderr] 124 | pub fn to_u8(self) -> u8 { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::wrong_self_convention)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: `0 as *const _` detected. Consider using `ptr::null()` [INFO] [stderr] --> src/coreutils.rs:41:19 [INFO] [stderr] | [INFO] [stderr] 41 | let nul = 0 as *const LV2Feature; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::zero_ptr)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zero_ptr [INFO] [stderr] [INFO] [stderr] warning: `0 as *mut _` detected. Consider using `ptr::null_mut()` [INFO] [stderr] --> src/coreutils.rs:56:5 [INFO] [stderr] | [INFO] [stderr] 56 | 0 as *mut c_void [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zero_ptr [INFO] [stderr] [INFO] [stderr] warning: `0 as *const _` detected. Consider using `ptr::null()` [INFO] [stderr] --> src/coreutils.rs:101:12 [INFO] [stderr] | [INFO] [stderr] 101 | return 0 as *const c_char; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zero_ptr [INFO] [stderr] [INFO] [stderr] error: casting from `*const atom::LV2AtomSequenceBody` to a more-strictly-aligned pointer (`*mut atom::LV2AtomEvent`) [INFO] [stderr] --> src/atomutils.rs:54:5 [INFO] [stderr] | [INFO] [stderr] 54 | body.offset(1) as *mut LV2AtomEvent [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::cast_ptr_alignment)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_ptr_alignment [INFO] [stderr] [INFO] [stderr] error: casting from `*const u8` to a more-strictly-aligned pointer (`*const atom::LV2AtomEvent`) [INFO] [stderr] --> src/atomutils.rs:62:5 [INFO] [stderr] | [INFO] [stderr] 62 | (body as *const u8).offset(lv2_atom_pad_size(size) as isize) as *const LV2AtomEvent [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_ptr_alignment [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/atomutils.rs:79:15 [INFO] [stderr] | [INFO] [stderr] 79 | let ptr = (i as *const u8).offset(off as isize); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(i as *const u8).add(off)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_offset_with_cast)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] error: casting from `*const u8` to a more-strictly-aligned pointer (`*mut atom::LV2AtomEvent`) [INFO] [stderr] --> src/atomutils.rs:81:5 [INFO] [stderr] | [INFO] [stderr] 81 | ptr as *mut LV2AtomEvent [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_ptr_alignment [INFO] [stderr] [INFO] [stderr] warning: `0 as *const _` detected. Consider using `ptr::null()` [INFO] [stderr] --> src/atomutils.rs:113:16 [INFO] [stderr] | [INFO] [stderr] 113 | return 0 as *const LV2AtomEvent; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zero_ptr [INFO] [stderr] [INFO] [stderr] error: casting from `*const u8` to a more-strictly-aligned pointer (`*const atom::LV2Atom`) [INFO] [stderr] --> src/atomutils.rs:144:17 [INFO] [stderr] | [INFO] [stderr] 144 | let value = (i as *const u8).offset((2 * size_of::()) as isize) as *const LV2Atom; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_ptr_alignment [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/atomutils.rs:144:17 [INFO] [stderr] | [INFO] [stderr] 144 | let value = (i as *const u8).offset((2 * size_of::()) as isize) as *const LV2Atom; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(i as *const u8).add((2 * size_of::()))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] error: casting from `*mut u8` to a more-strictly-aligned pointer (`*mut atom::LV2AtomPropertyBody`) [INFO] [stderr] --> src/atomutils.rs:147:5 [INFO] [stderr] | [INFO] [stderr] 147 | (i as *mut u8).offset(offset as isize) as *mut LV2AtomPropertyBody [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_ptr_alignment [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/atomutils.rs:187:9 [INFO] [stderr] | [INFO] [stderr] 187 | let ref mut object = *obj; [INFO] [stderr] | ----^^^^^^^^^^^^^^-------- help: try: `let object = &mut (*obj);` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] error: Variable in the condition are not mutated in the loop body. This either leads to an infinite or to a never running loop. [INFO] [stderr] --> src/atomutils.rs:193:11 [INFO] [stderr] | [INFO] [stderr] 193 | while (*q).key != 0 { [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::while_immutable_condition)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_immutable_condition [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/atomutils.rs:204:25 [INFO] [stderr] | [INFO] [stderr] 204 | let ref mut val = (*prop).value; [INFO] [stderr] | ----^^^^^^^^^^^----------------- help: try: `let val = &mut (*prop).value;` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: the variable `n_queries` is used as a loop counter. Consider using `for (n_queries, item) in query.enumerate()` or similar iterators [INFO] [stderr] --> src/atomutils.rs:254:15 [INFO] [stderr] | [INFO] [stderr] 254 | for it in query { [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::explicit_counter_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop [INFO] [stderr] [INFO] [stderr] error: aborting due to 6 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `lv2_raw`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "3b3a7ef50020d79a1903be30ba0d85f0938e30978ae19e505e304150329ba07e"` [INFO] running `"docker" "rm" "-f" "3b3a7ef50020d79a1903be30ba0d85f0938e30978ae19e505e304150329ba07e"` [INFO] [stdout] 3b3a7ef50020d79a1903be30ba0d85f0938e30978ae19e505e304150329ba07e