[INFO] crate luther-derive 0.1.0 is already in cache [INFO] extracting crate luther-derive 0.1.0 into work/ex/clippy-test-run/sources/stable/reg/luther-derive/0.1.0 [INFO] extracting crate luther-derive 0.1.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/luther-derive/0.1.0 [INFO] validating manifest of luther-derive-0.1.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of luther-derive-0.1.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing luther-derive-0.1.0 [INFO] finished frobbing luther-derive-0.1.0 [INFO] frobbed toml for luther-derive-0.1.0 written to work/ex/clippy-test-run/sources/stable/reg/luther-derive/0.1.0/Cargo.toml [INFO] started frobbing luther-derive-0.1.0 [INFO] finished frobbing luther-derive-0.1.0 [INFO] frobbed toml for luther-derive-0.1.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/luther-derive/0.1.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting luther-derive-0.1.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/luther-derive/0.1.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] d61ee1856cbcf1cad2d62a99c44b0534f0f4938873f24579e1075ea97331e057 [INFO] running `"docker" "start" "-a" "d61ee1856cbcf1cad2d62a99c44b0534f0f4938873f24579e1075ea97331e057"` [INFO] [stderr] Compiling vec_map v0.6.0 [INFO] [stderr] Checking redfa v0.0.2 [INFO] [stderr] Checking syn v0.12.15 [INFO] [stderr] Checking luther v0.1.0 [INFO] [stderr] Compiling luther-derive v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: bounds on generic parameters are not enforced in type aliases [INFO] [stderr] --> src/generate.rs:15:25 [INFO] [stderr] | [INFO] [stderr] 15 | type State<'info, 'ast: 'info> = redfa::State>>; [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(type_alias_bounds)] on by default [INFO] [stderr] = help: the bound will not be checked when the type alias is used, and should be removed [INFO] [stderr] [INFO] [stderr] warning: bounds on generic parameters are not enforced in type aliases [INFO] [stderr] --> src/dfa.rs:89:37 [INFO] [stderr] | [INFO] [stderr] 89 | type RegexVariant<'re, 'info, 'ast: 'info> = [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: the bound will not be checked when the type alias is used, and should be removed [INFO] [stderr] [INFO] [stderr] warning: bounds on generic parameters are not enforced in type aliases [INFO] [stderr] --> src/lib.rs:126:23 [INFO] [stderr] | [INFO] [stderr] 126 | type Dfa<'info, 'ast: 'info> = redfa::Dfa>>; [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: the bound will not be checked when the type alias is used, and should be removed [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/enum_info.rs:51:24 [INFO] [stderr] | [INFO] [stderr] 51 | fn make_dfa_name(name: &syn::Ident) -> String { [INFO] [stderr] | ^^^^^^^^^^^ help: consider passing by value instead: `syn::Ident` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/enum_info.rs:114:28 [INFO] [stderr] | [INFO] [stderr] 114 | .map_or(0, |s| convert_priority_group(s)), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `convert_priority_group` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/enum_info.rs:281:17 [INFO] [stderr] | [INFO] [stderr] 281 | let s = match self { [INFO] [stderr] | _________________^ [INFO] [stderr] 282 | | &Dfa => "dfa", [INFO] [stderr] 283 | | &Regex => "regex", [INFO] [stderr] 284 | | &PriorityGroup => "priority_group", // COV_EXCL_LINE [INFO] [stderr] 285 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 281 | let s = match *self { [INFO] [stderr] 282 | Dfa => "dfa", [INFO] [stderr] 283 | Regex => "regex", [INFO] [stderr] 284 | PriorityGroup => "priority_group", // COV_EXCL_LINE [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: bounds on generic parameters are not enforced in type aliases [INFO] [stderr] --> src/generate.rs:15:25 [INFO] [stderr] | [INFO] [stderr] 15 | type State<'info, 'ast: 'info> = redfa::State>>; [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(type_alias_bounds)] on by default [INFO] [stderr] = help: the bound will not be checked when the type alias is used, and should be removed [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/generate.rs:180:18 [INFO] [stderr] | [INFO] [stderr] 180 | .map(|s| syn::PathSegment::from(s)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `syn::PathSegment::from` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/dfa.rs:42:5 [INFO] [stderr] | [INFO] [stderr] 42 | / match regexs [INFO] [stderr] 43 | | .iter() [INFO] [stderr] 44 | | .position(|re| re.nullable()) [INFO] [stderr] 45 | | .map(|i| &info.variants[i].regex) [INFO] [stderr] ... | [INFO] [stderr] 48 | | _ => {} [INFO] [stderr] 49 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 42 | if let Some(re) = regexs [INFO] [stderr] 43 | .iter() [INFO] [stderr] 44 | .position(|re| re.nullable()) [INFO] [stderr] 45 | .map(|i| &info.variants[i].regex) { panic!("luther: regex \"{}\" matches the empty string", re) } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/dfa.rs:72:13 [INFO] [stderr] | [INFO] [stderr] 72 | regexs: &'re Vec>, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: change this to: `&[Regex]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/dfa.rs:73:10 [INFO] [stderr] | [INFO] [stderr] 73 | vis: &'info Vec>, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `&[VariantInfo<'ast>]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/dfa.rs:74:13 [INFO] [stderr] | [INFO] [stderr] 74 | simple: &'re Vec, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: change this to: `&[bool]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: bounds on generic parameters are not enforced in type aliases [INFO] [stderr] --> src/dfa.rs:89:37 [INFO] [stderr] | [INFO] [stderr] 89 | type RegexVariant<'re, 'info, 'ast: 'info> = [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: the bound will not be checked when the type alias is used, and should be removed [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/dfa.rs:135:35 [INFO] [stderr] | [INFO] [stderr] 135 | fn compare_for_simple_string(lhs: &bool, rhs: &bool) -> Ordering { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `bool` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/dfa.rs:135:47 [INFO] [stderr] | [INFO] [stderr] 135 | fn compare_for_simple_string(lhs: &bool, rhs: &bool) -> Ordering { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `bool` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/dfa.rs:144:5 [INFO] [stderr] | [INFO] [stderr] 144 | / match regex { [INFO] [stderr] 145 | | &Regex::Cat(ref regexs) => regexs.iter().all(|re| match re { [INFO] [stderr] 146 | | &Regex::Alt(ref ts, ref res) => ts.len() == 1 && res.len() == 0, [INFO] [stderr] 147 | | _ => false, [INFO] [stderr] 148 | | }), [INFO] [stderr] 149 | | _ => false, [INFO] [stderr] 150 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 144 | match *regex { [INFO] [stderr] 145 | Regex::Cat(ref regexs) => regexs.iter().all(|re| match re { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/dfa.rs:145:59 [INFO] [stderr] | [INFO] [stderr] 145 | &Regex::Cat(ref regexs) => regexs.iter().all(|re| match re { [INFO] [stderr] | ___________________________________________________________^ [INFO] [stderr] 146 | | &Regex::Alt(ref ts, ref res) => ts.len() == 1 && res.len() == 0, [INFO] [stderr] 147 | | _ => false, [INFO] [stderr] 148 | | }), [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 145 | &Regex::Cat(ref regexs) => regexs.iter().all(|re| match *re { [INFO] [stderr] 146 | Regex::Alt(ref ts, ref res) => ts.len() == 1 && res.len() == 0, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/dfa.rs:146:62 [INFO] [stderr] | [INFO] [stderr] 146 | &Regex::Alt(ref ts, ref res) => ts.len() == 1 && res.len() == 0, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `res.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: bounds on generic parameters are not enforced in type aliases [INFO] [stderr] --> src/lib.rs:126:23 [INFO] [stderr] | [INFO] [stderr] 126 | type Dfa<'info, 'ast: 'info> = redfa::Dfa>>; [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: the bound will not be checked when the type alias is used, and should be removed [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/enum_info.rs:51:24 [INFO] [stderr] | [INFO] [stderr] 51 | fn make_dfa_name(name: &syn::Ident) -> String { [INFO] [stderr] | ^^^^^^^^^^^ help: consider passing by value instead: `syn::Ident` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/enum_info.rs:114:28 [INFO] [stderr] | [INFO] [stderr] 114 | .map_or(0, |s| convert_priority_group(s)), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `convert_priority_group` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/enum_info.rs:281:17 [INFO] [stderr] | [INFO] [stderr] 281 | let s = match self { [INFO] [stderr] | _________________^ [INFO] [stderr] 282 | | &Dfa => "dfa", [INFO] [stderr] 283 | | &Regex => "regex", [INFO] [stderr] 284 | | &PriorityGroup => "priority_group", // COV_EXCL_LINE [INFO] [stderr] 285 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 281 | let s = match *self { [INFO] [stderr] 282 | Dfa => "dfa", [INFO] [stderr] 283 | Regex => "regex", [INFO] [stderr] 284 | PriorityGroup => "priority_group", // COV_EXCL_LINE [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: bounds on generic parameters are not enforced in type aliases [INFO] [stderr] --> src/generate.rs:15:25 [INFO] [stderr] | [INFO] [stderr] 15 | type State<'info, 'ast: 'info> = redfa::State>>; [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(type_alias_bounds)] on by default [INFO] [stderr] = help: the bound will not be checked when the type alias is used, and should be removed [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/generate.rs:180:18 [INFO] [stderr] | [INFO] [stderr] 180 | .map(|s| syn::PathSegment::from(s)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `syn::PathSegment::from` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/dfa.rs:42:5 [INFO] [stderr] | [INFO] [stderr] 42 | / match regexs [INFO] [stderr] 43 | | .iter() [INFO] [stderr] 44 | | .position(|re| re.nullable()) [INFO] [stderr] 45 | | .map(|i| &info.variants[i].regex) [INFO] [stderr] ... | [INFO] [stderr] 48 | | _ => {} [INFO] [stderr] 49 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 42 | if let Some(re) = regexs [INFO] [stderr] 43 | .iter() [INFO] [stderr] 44 | .position(|re| re.nullable()) [INFO] [stderr] 45 | .map(|i| &info.variants[i].regex) { panic!("luther: regex \"{}\" matches the empty string", re) } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/dfa.rs:72:13 [INFO] [stderr] | [INFO] [stderr] 72 | regexs: &'re Vec>, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: change this to: `&[Regex]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/dfa.rs:73:10 [INFO] [stderr] | [INFO] [stderr] 73 | vis: &'info Vec>, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `&[VariantInfo<'ast>]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/dfa.rs:74:13 [INFO] [stderr] | [INFO] [stderr] 74 | simple: &'re Vec, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: change this to: `&[bool]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: bounds on generic parameters are not enforced in type aliases [INFO] [stderr] --> src/dfa.rs:89:37 [INFO] [stderr] | [INFO] [stderr] 89 | type RegexVariant<'re, 'info, 'ast: 'info> = [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: the bound will not be checked when the type alias is used, and should be removed [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/dfa.rs:135:35 [INFO] [stderr] | [INFO] [stderr] 135 | fn compare_for_simple_string(lhs: &bool, rhs: &bool) -> Ordering { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `bool` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/dfa.rs:135:47 [INFO] [stderr] | [INFO] [stderr] 135 | fn compare_for_simple_string(lhs: &bool, rhs: &bool) -> Ordering { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `bool` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/dfa.rs:144:5 [INFO] [stderr] | [INFO] [stderr] 144 | / match regex { [INFO] [stderr] 145 | | &Regex::Cat(ref regexs) => regexs.iter().all(|re| match re { [INFO] [stderr] 146 | | &Regex::Alt(ref ts, ref res) => ts.len() == 1 && res.len() == 0, [INFO] [stderr] 147 | | _ => false, [INFO] [stderr] 148 | | }), [INFO] [stderr] 149 | | _ => false, [INFO] [stderr] 150 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 144 | match *regex { [INFO] [stderr] 145 | Regex::Cat(ref regexs) => regexs.iter().all(|re| match re { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/dfa.rs:145:59 [INFO] [stderr] | [INFO] [stderr] 145 | &Regex::Cat(ref regexs) => regexs.iter().all(|re| match re { [INFO] [stderr] | ___________________________________________________________^ [INFO] [stderr] 146 | | &Regex::Alt(ref ts, ref res) => ts.len() == 1 && res.len() == 0, [INFO] [stderr] 147 | | _ => false, [INFO] [stderr] 148 | | }), [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 145 | &Regex::Cat(ref regexs) => regexs.iter().all(|re| match *re { [INFO] [stderr] 146 | Regex::Alt(ref ts, ref res) => ts.len() == 1 && res.len() == 0, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/dfa.rs:146:62 [INFO] [stderr] | [INFO] [stderr] 146 | &Regex::Alt(ref ts, ref res) => ts.len() == 1 && res.len() == 0, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `res.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: bounds on generic parameters are not enforced in type aliases [INFO] [stderr] --> src/lib.rs:126:23 [INFO] [stderr] | [INFO] [stderr] 126 | type Dfa<'info, 'ast: 'info> = redfa::Dfa>>; [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: the bound will not be checked when the type alias is used, and should be removed [INFO] [stderr] [INFO] [stderr] warning: All variants have the same prefix: `State` [INFO] [stderr] --> tests/simple-derive.rs:20:10 [INFO] [stderr] | [INFO] [stderr] 20 | #[derive(Lexer, Debug)] [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::enum_variant_names)] on by default [INFO] [stderr] = help: remove the prefixes and use full paths to the variants instead of glob imports [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#enum_variant_names [INFO] [stderr] [INFO] [stderr] warning: All variants have the same prefix: `State` [INFO] [stderr] --> tests/clex-derive.rs:17:10 [INFO] [stderr] | [INFO] [stderr] 17 | #[derive(Lexer, Debug, PartialEq)] [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::enum_variant_names)] on by default [INFO] [stderr] = help: remove the prefixes and use full paths to the variants instead of glob imports [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#enum_variant_names [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 32.85s [INFO] running `"docker" "inspect" "d61ee1856cbcf1cad2d62a99c44b0534f0f4938873f24579e1075ea97331e057"` [INFO] running `"docker" "rm" "-f" "d61ee1856cbcf1cad2d62a99c44b0534f0f4938873f24579e1075ea97331e057"` [INFO] [stdout] d61ee1856cbcf1cad2d62a99c44b0534f0f4938873f24579e1075ea97331e057