[INFO] crate luther 0.1.0 is already in cache
[INFO] extracting crate luther 0.1.0 into work/ex/clippy-test-run/sources/stable/reg/luther/0.1.0
[INFO] extracting crate luther 0.1.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/luther/0.1.0
[INFO] validating manifest of luther-0.1.0 on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of luther-0.1.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing luther-0.1.0
[INFO] finished frobbing luther-0.1.0
[INFO] frobbed toml for luther-0.1.0 written to work/ex/clippy-test-run/sources/stable/reg/luther/0.1.0/Cargo.toml
[INFO] started frobbing luther-0.1.0
[INFO] finished frobbing luther-0.1.0
[INFO] frobbed toml for luther-0.1.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/luther/0.1.0/Cargo.toml
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting luther-0.1.0 against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/luther/0.1.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 30bf5086a603f42e91507d8c2d511c5569ba343362e52b420c101d8169b4b07e
[INFO] running `"docker" "start" "-a" "30bf5086a603f42e91507d8c2d511c5569ba343362e52b420c101d8169b4b07e"`
[INFO] [stderr]     Checking luther v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions
[INFO] [stderr]   --> src/dfa.rs:81:31
[INFO] [stderr]    |
[INFO] [stderr] 81 |     fn init_dfa(&mut self) -> StdResult<(Location, Location, D), Option<Result<Span<T>, F>>> {
[INFO] [stderr]    |                               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::type_complexity)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity
[INFO] [stderr] 
[INFO] [stderr] warning: this loop could be written as a `while let` loop
[INFO] [stderr]    --> src/dfa.rs:119:9
[INFO] [stderr]     |
[INFO] [stderr] 119 | /         loop {
[INFO] [stderr] 120 | |             match self.input.peek() {
[INFO] [stderr] 121 | |                 Some(&Ok(ref span)) => {
[INFO] [stderr] 122 | |                     let next_state = state.transition(*span.value_ref());
[INFO] [stderr] ...   |
[INFO] [stderr] 134 | |             self.input.next();
[INFO] [stderr] 135 | |         }
[INFO] [stderr]     | |_________^ help: try: `while let Some(&Ok(ref span)) = self.input.peek() { .. }`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::while_let_loop)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop
[INFO] [stderr] 
[INFO] [stderr] warning: use of `ok_or` followed by a function call
[INFO] [stderr]    --> src/dfa.rs:142:18
[INFO] [stderr]     |
[INFO] [stderr] 142 |                 .ok_or(LexError::InvalidToken(tok_str)),
[INFO] [stderr]     |                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| LexError::InvalidToken(tok_str))`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::or_fun_call)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: the loop variable `index` is only used to index `buffer`.
[INFO] [stderr]    --> src/spanned.rs:142:18
[INFO] [stderr]     |
[INFO] [stderr] 142 |     for index in 1..(count + 1) {
[INFO] [stderr]     |                  ^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_range_loop)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stderr] help: consider using an iterator
[INFO] [stderr]     |
[INFO] [stderr] 142 |     for <item> in buffer.iter_mut().skip(1).take(count) {
[INFO] [stderr]     |         ^^^^^^    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: an inclusive range would be more readable
[INFO] [stderr]    --> src/spanned.rs:142:18
[INFO] [stderr]     |
[INFO] [stderr] 142 |     for index in 1..(count + 1) {
[INFO] [stderr]     |                  ^^^^^^^^^^^^^^ help: use: `1..=count`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::range_plus_one)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one
[INFO] [stderr] 
[INFO] [stderr] warning: All variants have the same prefix: `State`
[INFO] [stderr]    --> src/dfa.rs:244:5
[INFO] [stderr]     |
[INFO] [stderr] 244 | /     enum DfaStates {
[INFO] [stderr] 245 | |         State0,
[INFO] [stderr] 246 | |         State1,
[INFO] [stderr] 247 | |         State2,
[INFO] [stderr] 248 | |         State3,
[INFO] [stderr] 249 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::enum_variant_names)] on by default
[INFO] [stderr]     = help: remove the prefixes and use full paths to the variants instead of glob imports
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#enum_variant_names
[INFO] [stderr] 
[INFO] [stderr] warning: unused arithmetic operation that must be used
[INFO] [stderr]    --> src/span.rs:132:9
[INFO] [stderr]     |
[INFO] [stderr] 132 |         Location::new(usize::max_value()) + 3;
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(unused_must_use)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: statement can be reduced
[INFO] [stderr]    --> src/span.rs:132:9
[INFO] [stderr]     |
[INFO] [stderr] 132 |         Location::new(usize::max_value()) + 3;
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `Location::new(usize::max_value());3;`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::unnecessary_operation)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_operation
[INFO] [stderr] 
[INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions
[INFO] [stderr]   --> src/dfa.rs:81:31
[INFO] [stderr]    |
[INFO] [stderr] 81 |     fn init_dfa(&mut self) -> StdResult<(Location, Location, D), Option<Result<Span<T>, F>>> {
[INFO] [stderr]    |                               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::type_complexity)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity
[INFO] [stderr] 
[INFO] [stderr] warning: this loop could be written as a `while let` loop
[INFO] [stderr]    --> src/dfa.rs:119:9
[INFO] [stderr]     |
[INFO] [stderr] 119 | /         loop {
[INFO] [stderr] 120 | |             match self.input.peek() {
[INFO] [stderr] 121 | |                 Some(&Ok(ref span)) => {
[INFO] [stderr] 122 | |                     let next_state = state.transition(*span.value_ref());
[INFO] [stderr] ...   |
[INFO] [stderr] 134 | |             self.input.next();
[INFO] [stderr] 135 | |         }
[INFO] [stderr]     | |_________^ help: try: `while let Some(&Ok(ref span)) = self.input.peek() { .. }`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::while_let_loop)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop
[INFO] [stderr] 
[INFO] [stderr] warning: use of `ok_or` followed by a function call
[INFO] [stderr]    --> src/dfa.rs:142:18
[INFO] [stderr]     |
[INFO] [stderr] 142 |                 .ok_or(LexError::InvalidToken(tok_str)),
[INFO] [stderr]     |                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| LexError::InvalidToken(tok_str))`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::or_fun_call)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: this creates an owned instance just for comparison
[INFO] [stderr]    --> src/dfa.rs:332:36
[INFO] [stderr]     |
[INFO] [stderr] 332 |                                 if *s == "a".to_string());
[INFO] [stderr]     |                                    ^^^^^^^^^^^^^^^^^^^^^ try implementing the comparison without allocating
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::cmp_owned)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned
[INFO] [stderr] 
[INFO] [stderr] warning: the loop variable `index` is only used to index `buffer`.
[INFO] [stderr]    --> src/spanned.rs:142:18
[INFO] [stderr]     |
[INFO] [stderr] 142 |     for index in 1..(count + 1) {
[INFO] [stderr]     |                  ^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_range_loop)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stderr] help: consider using an iterator
[INFO] [stderr]     |
[INFO] [stderr] 142 |     for <item> in buffer.iter_mut().skip(1).take(count) {
[INFO] [stderr]     |         ^^^^^^    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: an inclusive range would be more readable
[INFO] [stderr]    --> src/spanned.rs:142:18
[INFO] [stderr]     |
[INFO] [stderr] 142 |     for index in 1..(count + 1) {
[INFO] [stderr]     |                  ^^^^^^^^^^^^^^ help: use: `1..=count`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::range_plus_one)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one
[INFO] [stderr] 
[INFO] [stderr] warning: redundant closure found
[INFO] [stderr]    --> src/spanned.rs:254:42
[INFO] [stderr]     |
[INFO] [stderr] 254 |         let iter = bytes.into_iter().map(|b| Ok(b));
[INFO] [stderr]     |                                          ^^^^^^^^^ help: remove closure as shown: `Ok`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::redundant_closure)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
[INFO] [stderr] 
[INFO] [stderr] warning: All variants have the same prefix: `State`
[INFO] [stderr]   --> tests/token_tests.rs:25:1
[INFO] [stderr]    |
[INFO] [stderr] 25 | / enum TokensDfa {
[INFO] [stderr] 26 | |     State0, // ["ab", "acc*"]
[INFO] [stderr] 27 | |     State1, // [ null, null ]
[INFO] [stderr] 28 | |     State2, // ["b", "cc*"]
[INFO] [stderr] 29 | |     State3, // ["", null]
[INFO] [stderr] 30 | |     State4, // [null, "c*"]
[INFO] [stderr] 31 | | }
[INFO] [stderr]    | |_^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::enum_variant_names)] on by default
[INFO] [stderr]    = help: remove the prefixes and use full paths to the variants instead of glob imports
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#enum_variant_names
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 4.37s
[INFO] running `"docker" "inspect" "30bf5086a603f42e91507d8c2d511c5569ba343362e52b420c101d8169b4b07e"`
[INFO] running `"docker" "rm" "-f" "30bf5086a603f42e91507d8c2d511c5569ba343362e52b420c101d8169b4b07e"`
[INFO] [stdout] 30bf5086a603f42e91507d8c2d511c5569ba343362e52b420c101d8169b4b07e