[INFO] crate lunardate 0.1.4 is already in cache [INFO] extracting crate lunardate 0.1.4 into work/ex/clippy-test-run/sources/stable/reg/lunardate/0.1.4 [INFO] extracting crate lunardate 0.1.4 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/lunardate/0.1.4 [INFO] validating manifest of lunardate-0.1.4 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of lunardate-0.1.4 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing lunardate-0.1.4 [INFO] finished frobbing lunardate-0.1.4 [INFO] frobbed toml for lunardate-0.1.4 written to work/ex/clippy-test-run/sources/stable/reg/lunardate/0.1.4/Cargo.toml [INFO] started frobbing lunardate-0.1.4 [INFO] finished frobbing lunardate-0.1.4 [INFO] frobbed toml for lunardate-0.1.4 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/lunardate/0.1.4/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting lunardate-0.1.4 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/lunardate/0.1.4:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 47e8203b89bdb4d86b24376f675bd99dd04dac668506a5b04a7e2095129bcae5 [INFO] running `"docker" "start" "-a" "47e8203b89bdb4d86b24376f675bd99dd04dac668506a5b04a7e2095129bcae5"` [INFO] [stderr] Checking lunardate v0.1.4 (/opt/crater/workdir) [INFO] [stderr] warning: the loop variable `i` is only used to index `YEAR_INFOS`. [INFO] [stderr] --> src/lib.rs:33:18 [INFO] [stderr] | [INFO] [stderr] 33 | for i in 0..YEAR_INFOS.len() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 33 | for in &YEAR_INFOS { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/lib.rs:140:9 [INFO] [stderr] | [INFO] [stderr] 140 | year_info = year_info / 2; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `year_info /= 2` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/lib.rs:228:34 [INFO] [stderr] | [INFO] [stderr] 228 | pub fn from_naive_date(date: &NaiveDate) -> Result { [INFO] [stderr] | ^^^^^^^^^^ help: consider passing by value instead: `NaiveDate` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `YEAR_DAYS`. [INFO] [stderr] --> src/lib.rs:264:18 [INFO] [stderr] | [INFO] [stderr] 264 | for i in 0..year_index { [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 264 | for in YEAR_DAYS.iter().take(year_index) { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: casting u32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:268:41 [INFO] [stderr] | [INFO] [stderr] 268 | Ok(*START_DATE + Duration::days(offset as i64)) [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `i64::from(offset)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: Suspicious use of binary operator in `Sub` impl [INFO] [stderr] --> src/lib.rs:362:14 [INFO] [stderr] | [INFO] [stderr] 362 | self + Duration::from_std(rhs).unwrap() [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::suspicious_arithmetic_impl)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_arithmetic_impl [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `lunardate`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: the loop variable `i` is only used to index `YEAR_INFOS`. [INFO] [stderr] --> src/lib.rs:33:18 [INFO] [stderr] | [INFO] [stderr] 33 | for i in 0..YEAR_INFOS.len() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 33 | for in &YEAR_INFOS { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/lib.rs:140:9 [INFO] [stderr] | [INFO] [stderr] 140 | year_info = year_info / 2; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `year_info /= 2` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/lib.rs:228:34 [INFO] [stderr] | [INFO] [stderr] 228 | pub fn from_naive_date(date: &NaiveDate) -> Result { [INFO] [stderr] | ^^^^^^^^^^ help: consider passing by value instead: `NaiveDate` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `YEAR_DAYS`. [INFO] [stderr] --> src/lib.rs:264:18 [INFO] [stderr] | [INFO] [stderr] 264 | for i in 0..year_index { [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 264 | for in YEAR_DAYS.iter().take(year_index) { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: casting u32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:268:41 [INFO] [stderr] | [INFO] [stderr] 268 | Ok(*START_DATE + Duration::days(offset as i64)) [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `i64::from(offset)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: Suspicious use of binary operator in `Sub` impl [INFO] [stderr] --> src/lib.rs:362:14 [INFO] [stderr] | [INFO] [stderr] 362 | self + Duration::from_std(rhs).unwrap() [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::suspicious_arithmetic_impl)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_arithmetic_impl [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `lunardate`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "47e8203b89bdb4d86b24376f675bd99dd04dac668506a5b04a7e2095129bcae5"` [INFO] running `"docker" "rm" "-f" "47e8203b89bdb4d86b24376f675bd99dd04dac668506a5b04a7e2095129bcae5"` [INFO] [stdout] 47e8203b89bdb4d86b24376f675bd99dd04dac668506a5b04a7e2095129bcae5