[INFO] crate luminance 0.30.1 is already in cache [INFO] extracting crate luminance 0.30.1 into work/ex/clippy-test-run/sources/stable/reg/luminance/0.30.1 [INFO] extracting crate luminance 0.30.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/luminance/0.30.1 [INFO] validating manifest of luminance-0.30.1 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of luminance-0.30.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing luminance-0.30.1 [INFO] finished frobbing luminance-0.30.1 [INFO] frobbed toml for luminance-0.30.1 written to work/ex/clippy-test-run/sources/stable/reg/luminance/0.30.1/Cargo.toml [INFO] started frobbing luminance-0.30.1 [INFO] finished frobbing luminance-0.30.1 [INFO] frobbed toml for luminance-0.30.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/luminance/0.30.1/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting luminance-0.30.1 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/luminance/0.30.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 3dab6cd8249420562a09baf10fe8c5ea0e7846cc39224ce80f465387d15503fd [INFO] running `"docker" "start" "-a" "3dab6cd8249420562a09baf10fe8c5ea0e7846cc39224ce80f465387d15503fd"` [INFO] [stderr] Checking luminance v0.30.1 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/buffer.rs:149:9 [INFO] [stderr] | [INFO] [stderr] 149 | bytes: bytes, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `bytes` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/buffer.rs:150:9 [INFO] [stderr] | [INFO] [stderr] 150 | len: len, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `len` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/framebuffer.rs:237:9 [INFO] [stderr] | [INFO] [stderr] 237 | handle: handle, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `handle` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/framebuffer.rs:478:41 [INFO] [stderr] | [INFO] [stderr] 478 | let GTup(a, GTup(b, GTup(c, GTup(d, e)))) = GTup::, GTup, GTup, GTup, Texture>>>>::reify_textures(ctx, size, mipmaps, textures); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::many_single_char_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/framebuffer.rs:503:46 [INFO] [stderr] | [INFO] [stderr] 503 | let GTup(a, GTup(b, GTup(c, GTup(d, GTup(e, f))))) = GTup::, GTup, GTup, GTup, GTup, Texture>>>>>::reify_textures(ctx, size, mipmaps, textures); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> src/framebuffer.rs:503:49 [INFO] [stderr] | [INFO] [stderr] 503 | let GTup(a, GTup(b, GTup(c, GTup(d, GTup(e, f))))) = GTup::, GTup, GTup, GTup, GTup, Texture>>>>>::reify_textures(ctx, size, mipmaps, textures); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/framebuffer.rs:529:46 [INFO] [stderr] | [INFO] [stderr] 529 | let GTup(a, GTup(b, GTup(c, GTup(d, GTup(e, GTup(f, g)))))) = GTup::, GTup, GTup, GTup, GTup, GTup, Texture>>>>>>::reify_textures(ctx, size, mipmaps, textures); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> src/framebuffer.rs:529:54 [INFO] [stderr] | [INFO] [stderr] 529 | let GTup(a, GTup(b, GTup(c, GTup(d, GTup(e, GTup(f, g)))))) = GTup::, GTup, GTup, GTup, GTup, GTup, Texture>>>>>>::reify_textures(ctx, size, mipmaps, textures); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 7th binding whose name is just one char [INFO] [stderr] --> src/framebuffer.rs:529:57 [INFO] [stderr] | [INFO] [stderr] 529 | let GTup(a, GTup(b, GTup(c, GTup(d, GTup(e, GTup(f, g)))))) = GTup::, GTup, GTup, GTup, GTup, GTup, Texture>>>>>>::reify_textures(ctx, size, mipmaps, textures); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/framebuffer.rs:556:46 [INFO] [stderr] | [INFO] [stderr] 556 | let GTup(a, GTup(b, GTup(c, GTup(d, GTup(e, GTup(f, GTup(g, h))))))) = GTup::, GTup, GTup, GTup, GTup, GTup, GTup, Texture>>>>>>>::reify_textures(ctx, size, mipmaps, textures); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> src/framebuffer.rs:556:54 [INFO] [stderr] | [INFO] [stderr] 556 | let GTup(a, GTup(b, GTup(c, GTup(d, GTup(e, GTup(f, GTup(g, h))))))) = GTup::, GTup, GTup, GTup, GTup, GTup, GTup, Texture>>>>>>>::reify_textures(ctx, size, mipmaps, textures); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 7th binding whose name is just one char [INFO] [stderr] --> src/framebuffer.rs:556:62 [INFO] [stderr] | [INFO] [stderr] 556 | let GTup(a, GTup(b, GTup(c, GTup(d, GTup(e, GTup(f, GTup(g, h))))))) = GTup::, GTup, GTup, GTup, GTup, GTup, GTup, Texture>>>>>>>::reify_textures(ctx, size, mipmaps, textures); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 8th binding whose name is just one char [INFO] [stderr] --> src/framebuffer.rs:556:65 [INFO] [stderr] | [INFO] [stderr] 556 | let GTup(a, GTup(b, GTup(c, GTup(d, GTup(e, GTup(f, GTup(g, h))))))) = GTup::, GTup, GTup, GTup, GTup, GTup, GTup, Texture>>>>>>>::reify_textures(ctx, size, mipmaps, textures); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/buffer.rs:149:9 [INFO] [stderr] | [INFO] [stderr] 149 | bytes: bytes, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `bytes` [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/framebuffer.rs:584:46 [INFO] [stderr] | [INFO] [stderr] 584 | let GTup(a, GTup(b, GTup(c, GTup(d, GTup(e, GTup(f, GTup(g, GTup(h, i)))))))) = GTup::, GTup, GTup, GTup, GTup, GTup, GTup, GTup, Texture< L, D, P8>>>>>>>>>::reify_textures(ctx, size, mipmaps, textures); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> src/framebuffer.rs:584:54 [INFO] [stderr] | [INFO] [stderr] 584 | let GTup(a, GTup(b, GTup(c, GTup(d, GTup(e, GTup(f, GTup(g, GTup(h, i)))))))) = GTup::, GTup, GTup, GTup, GTup, GTup, GTup, GTup, Texture< L, D, P8>>>>>>>>>::reify_textures(ctx, size, mipmaps, textures); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] [INFO] [stderr] warning: 7th binding whose name is just one char [INFO] [stderr] --> src/framebuffer.rs:584:62 [INFO] [stderr] | [INFO] [stderr] 584 | let GTup(a, GTup(b, GTup(c, GTup(d, GTup(e, GTup(f, GTup(g, GTup(h, i)))))))) = GTup::, GTup, GTup, GTup, GTup, GTup, GTup, GTup, Texture< L, D, P8>>>>>>>>>::reify_textures(ctx, size, mipmaps, textures); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] --> src/buffer.rs:150:9 [INFO] [stderr] | [INFO] [stderr] 150 | len: len, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `len` [INFO] [stderr] [INFO] [stderr] | [INFO] [stderr] warning: 8th binding whose name is just one char [INFO] [stderr] --> src/framebuffer.rs:584:70 [INFO] [stderr] | [INFO] [stderr] 584 | let GTup(a, GTup(b, GTup(c, GTup(d, GTup(e, GTup(f, GTup(g, GTup(h, i)))))))) = GTup::, GTup, GTup, GTup, GTup, GTup, GTup, GTup, Texture< L, D, P8>>>>>>>>>::reify_textures(ctx, size, mipmaps, textures); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] [INFO] [stderr] warning: 9th binding whose name is just one char [INFO] [stderr] --> src/framebuffer.rs:584:73 [INFO] [stderr] | [INFO] [stderr] 584 | let GTup(a, GTup(b, GTup(c, GTup(d, GTup(e, GTup(f, GTup(g, GTup(h, i)))))))) = GTup::, GTup, GTup, GTup, GTup, GTup, GTup, GTup, Texture< L, D, P8>>>>>>>>>::reify_textures(ctx, size, mipmaps, textures); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/framebuffer.rs:613:46 [INFO] [stderr] | [INFO] [stderr] 613 | let GTup(a, GTup(b, GTup(c, GTup(d, GTup(e, GTup(f, GTup(g, GTup(h, GTup(i, j))))))))) = GTup::, GTup, GTup, GTup, GTup, GTup, GTup, GTup, GTup, Texture>>>>>>>>>::reify_textures(ctx, size, mipmaps, textures); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> src/framebuffer.rs:613:54 [INFO] [stderr] | [INFO] [stderr] 613 | let GTup(a, GTup(b, GTup(c, GTup(d, GTup(e, GTup(f, GTup(g, GTup(h, GTup(i, j))))))))) = GTup::, GTup, GTup, GTup, GTup, GTup, GTup, GTup, GTup, Texture>>>>>>>>>::reify_textures(ctx, size, mipmaps, textures); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 7th binding whose name is just one char [INFO] [stderr] --> src/framebuffer.rs:613:62 [INFO] [stderr] | [INFO] [stderr] 613 | let GTup(a, GTup(b, GTup(c, GTup(d, GTup(e, GTup(f, GTup(g, GTup(h, GTup(i, j))))))))) = GTup::, GTup, GTup, GTup, GTup, GTup, GTup, GTup, GTup, Texture>>>>>>>>>::reify_textures(ctx, size, mipmaps, textures); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 8th binding whose name is just one char [INFO] [stderr] --> src/framebuffer.rs:613:70 [INFO] [stderr] | [INFO] [stderr] 613 | let GTup(a, GTup(b, GTup(c, GTup(d, GTup(e, GTup(f, GTup(g, GTup(h, GTup(i, j))))))))) = GTup::, GTup, GTup, GTup, GTup, GTup, GTup, GTup, GTup, Texture>>>>>>>>>::reify_textures(ctx, size, mipmaps, textures); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 9th binding whose name is just one char [INFO] [stderr] --> src/framebuffer.rs:613:78 [INFO] [stderr] | [INFO] [stderr] 613 | let GTup(a, GTup(b, GTup(c, GTup(d, GTup(e, GTup(f, GTup(g, GTup(h, GTup(i, j))))))))) = GTup::, GTup, GTup, GTup, GTup, GTup, GTup, GTup, GTup, Texture>>>>>>>>>::reify_textures(ctx, size, mipmaps, textures); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 10th binding whose name is just one char [INFO] [stderr] --> src/framebuffer.rs:613:81 [INFO] [stderr] | [INFO] [stderr] 613 | let GTup(a, GTup(b, GTup(c, GTup(d, GTup(e, GTup(f, GTup(g, GTup(h, GTup(i, j))))))))) = GTup::, GTup, GTup, GTup, GTup, GTup, GTup, GTup, GTup, Texture>>>>>>>>>::reify_textures(ctx, size, mipmaps, textures); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/framebuffer.rs:237:9 [INFO] [stderr] | [INFO] [stderr] 237 | handle: handle, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `handle` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/framebuffer.rs:478:41 [INFO] [stderr] | [INFO] [stderr] 478 | let GTup(a, GTup(b, GTup(c, GTup(d, e)))) = GTup::, GTup, GTup, GTup, Texture>>>>::reify_textures(ctx, size, mipmaps, textures); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::many_single_char_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/framebuffer.rs:503:46 [INFO] [stderr] | [INFO] [stderr] 503 | let GTup(a, GTup(b, GTup(c, GTup(d, GTup(e, f))))) = GTup::, GTup, GTup, GTup, GTup, Texture>>>>>::reify_textures(ctx, size, mipmaps, textures); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/shader/program.rs:84:25 [INFO] [stderr] | [INFO] [stderr] 84 | Ok(RawProgram { handle: handle }) [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `handle` [INFO] [stderr] | [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> src/framebuffer.rs:503:49 [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] | [INFO] [stderr] 503 | let GTup(a, GTup(b, GTup(c, GTup(d, GTup(e, f))))) = GTup::, GTup, GTup, GTup, GTup, Texture>>>>>::reify_textures(ctx, size, mipmaps, textures); [INFO] [stderr] | ^ [INFO] [stderr] [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/framebuffer.rs:529:46 [INFO] [stderr] | [INFO] [stderr] 529 | let GTup(a, GTup(b, GTup(c, GTup(d, GTup(e, GTup(f, g)))))) = GTup::, GTup, GTup, GTup, GTup, GTup, Texture>>>>>>::reify_textures(ctx, size, mipmaps, textures); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> src/framebuffer.rs:529:54 [INFO] [stderr] | [INFO] [stderr] 529 | let GTup(a, GTup(b, GTup(c, GTup(d, GTup(e, GTup(f, g)))))) = GTup::, GTup, GTup, GTup, GTup, GTup, Texture>>>>>>::reify_textures(ctx, size, mipmaps, textures); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 7th binding whose name is just one char [INFO] [stderr] --> src/framebuffer.rs:529:57 [INFO] [stderr] | [INFO] [stderr] 529 | let GTup(a, GTup(b, GTup(c, GTup(d, GTup(e, GTup(f, g)))))) = GTup::, GTup, GTup, GTup, GTup, GTup, Texture>>>>>>::reify_textures(ctx, size, mipmaps, textures); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] --> src/shader/program.rs:457:7 [INFO] [stderr] | [INFO] [stderr] 457 | program: program, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `program` [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/shader/program.rs:458:7 [INFO] [stderr] | [INFO] [stderr] 458 | index: index, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `index` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/framebuffer.rs:556:46 [INFO] [stderr] | [INFO] [stderr] 556 | let GTup(a, GTup(b, GTup(c, GTup(d, GTup(e, GTup(f, GTup(g, h))))))) = GTup::, GTup, GTup, GTup, GTup, GTup, GTup, Texture>>>>>>>::reify_textures(ctx, size, mipmaps, textures); [INFO] [stderr] --> src/shader/program.rs:465:7 [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] 465 | program: program, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `program` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> src/framebuffer.rs:556:54 [INFO] [stderr] | [INFO] [stderr] 556 | let GTup(a, GTup(b, GTup(c, GTup(d, GTup(e, GTup(f, GTup(g, h))))))) = GTup::, GTup, GTup, GTup, GTup, GTup, GTup, Texture>>>>>>>::reify_textures(ctx, size, mipmaps, textures); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 7th binding whose name is just one char [INFO] [stderr] --> src/framebuffer.rs:556:62 [INFO] [stderr] | [INFO] [stderr] 556 | let GTup(a, GTup(b, GTup(c, GTup(d, GTup(e, GTup(f, GTup(g, h))))))) = GTup::, GTup, GTup, GTup, GTup, GTup, GTup, Texture>>>>>>>::reify_textures(ctx, size, mipmaps, textures); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 8th binding whose name is just one char [INFO] [stderr] --> src/framebuffer.rs:556:65 [INFO] [stderr] | [INFO] [stderr] 556 | let GTup(a, GTup(b, GTup(c, GTup(d, GTup(e, GTup(f, GTup(g, h))))))) = GTup::, GTup, GTup, GTup, GTup, GTup, GTup, Texture>>>>>>>::reify_textures(ctx, size, mipmaps, textures); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/framebuffer.rs:584:46 [INFO] [stderr] | [INFO] [stderr] 584 | let GTup(a, GTup(b, GTup(c, GTup(d, GTup(e, GTup(f, GTup(g, GTup(h, i)))))))) = GTup::, GTup, GTup, GTup, GTup, GTup, GTup, GTup, Texture< L, D, P8>>>>>>>>>::reify_textures(ctx, size, mipmaps, textures); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/shader/stage.rs:56:11 [INFO] [stderr] | [INFO] [stderr] 56 | handle: handle, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `handle` [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> src/framebuffer.rs:584:54 [INFO] [stderr] | [INFO] [stderr] 584 | let GTup(a, GTup(b, GTup(c, GTup(d, GTup(e, GTup(f, GTup(g, GTup(h, i)))))))) = GTup::, GTup, GTup, GTup, GTup, GTup, GTup, GTup, Texture< L, D, P8>>>>>>>>>::reify_textures(ctx, size, mipmaps, textures); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: 7th binding whose name is just one char [INFO] [stderr] --> src/framebuffer.rs:584:62 [INFO] [stderr] | [INFO] [stderr] 584 | let GTup(a, GTup(b, GTup(c, GTup(d, GTup(e, GTup(f, GTup(g, GTup(h, i)))))))) = GTup::, GTup, GTup, GTup, GTup, GTup, GTup, GTup, Texture< L, D, P8>>>>>>>>>::reify_textures(ctx, size, mipmaps, textures); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/shader/stage.rs:57:11 [INFO] [stderr] | [INFO] [stderr] 57 | ty: ty [INFO] [stderr] | ^^^^^^ help: replace it with: `ty` [INFO] [stderr] warning: 8th binding whose name is just one char [INFO] [stderr] --> src/framebuffer.rs:584:70 [INFO] [stderr] | [INFO] [stderr] 584 | let GTup(a, GTup(b, GTup(c, GTup(d, GTup(e, GTup(f, GTup(g, GTup(h, i)))))))) = GTup::, GTup, GTup, GTup, GTup, GTup, GTup, GTup, Texture< L, D, P8>>>>>>>>>::reify_textures(ctx, size, mipmaps, textures); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: 9th binding whose name is just one char [INFO] [stderr] --> src/framebuffer.rs:584:73 [INFO] [stderr] | [INFO] [stderr] 584 | let GTup(a, GTup(b, GTup(c, GTup(d, GTup(e, GTup(f, GTup(g, GTup(h, i)))))))) = GTup::, GTup, GTup, GTup, GTup, GTup, GTup, GTup, Texture< L, D, P8>>>>>>>>>::reify_textures(ctx, size, mipmaps, textures); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/framebuffer.rs:613:46 [INFO] [stderr] | [INFO] [stderr] 613 | let GTup(a, GTup(b, GTup(c, GTup(d, GTup(e, GTup(f, GTup(g, GTup(h, GTup(i, j))))))))) = GTup::, GTup, GTup, GTup, GTup, GTup, GTup, GTup, GTup, Texture>>>>>>>>>::reify_textures(ctx, size, mipmaps, textures); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 6th binding whose name is just one char [INFO] [stderr] --> src/framebuffer.rs:613:54 [INFO] [stderr] | [INFO] [stderr] 613 | let GTup(a, GTup(b, GTup(c, GTup(d, GTup(e, GTup(f, GTup(g, GTup(h, GTup(i, j))))))))) = GTup::, GTup, GTup, GTup, GTup, GTup, GTup, GTup, GTup, Texture>>>>>>>>>::reify_textures(ctx, size, mipmaps, textures); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 7th binding whose name is just one char [INFO] [stderr] --> src/framebuffer.rs:613:62 [INFO] [stderr] | [INFO] [stderr] 613 | let GTup(a, GTup(b, GTup(c, GTup(d, GTup(e, GTup(f, GTup(g, GTup(h, GTup(i, j))))))))) = GTup::, GTup, GTup, GTup, GTup, GTup, GTup, GTup, GTup, Texture>>>>>>>>>::reify_textures(ctx, size, mipmaps, textures); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 8th binding whose name is just one char [INFO] [stderr] --> src/framebuffer.rs:613:70 [INFO] [stderr] | [INFO] [stderr] 613 | let GTup(a, GTup(b, GTup(c, GTup(d, GTup(e, GTup(f, GTup(g, GTup(h, GTup(i, j))))))))) = GTup::, GTup, GTup, GTup, GTup, GTup, GTup, GTup, GTup, Texture>>>>>>>>>::reify_textures(ctx, size, mipmaps, textures); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 9th binding whose name is just one char [INFO] [stderr] --> src/framebuffer.rs:613:78 [INFO] [stderr] | [INFO] [stderr] 613 | let GTup(a, GTup(b, GTup(c, GTup(d, GTup(e, GTup(f, GTup(g, GTup(h, GTup(i, j))))))))) = GTup::, GTup, GTup, GTup, GTup, GTup, GTup, GTup, GTup, Texture>>>>>>>>>::reify_textures(ctx, size, mipmaps, textures); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 10th binding whose name is just one char [INFO] [stderr] --> src/framebuffer.rs:613:81 [INFO] [stderr] | [INFO] [stderr] 613 | let GTup(a, GTup(b, GTup(c, GTup(d, GTup(e, GTup(f, GTup(g, GTup(h, GTup(i, j))))))))) = GTup::, GTup, GTup, GTup, GTup, GTup, GTup, GTup, GTup, Texture>>>>>>>>>::reify_textures(ctx, size, mipmaps, textures); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/tess.rs:179:11 [INFO] [stderr] | [INFO] [stderr] 179 | vao: vao, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `vao` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/tess.rs:189:11 [INFO] [stderr] | [INFO] [stderr] 189 | vert_nb: vert_nb, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `vert_nb` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/tess.rs:190:11 [INFO] [stderr] | [INFO] [stderr] 190 | vao: vao, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `vao` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/tess.rs:277:9 [INFO] [stderr] | [INFO] [stderr] 277 | vert_nb: vert_nb, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `vert_nb` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/tess.rs:278:9 [INFO] [stderr] | [INFO] [stderr] 278 | vao: vao, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `vao` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/tess.rs:416:7 [INFO] [stderr] | [INFO] [stderr] 416 | tess: tess, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `tess` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/shader/program.rs:84:25 [INFO] [stderr] | [INFO] [stderr] 84 | Ok(RawProgram { handle: handle }) [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `handle` [INFO] [stderr] --> src/tess.rs:440:7 [INFO] [stderr] | [INFO] [stderr] 440 | tess: tess, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `tess` [INFO] [stderr] | [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/tess.rs:442:7 [INFO] [stderr] | [INFO] [stderr] 442 | vert_nb: vert_nb, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `vert_nb` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/tess.rs:467:7 [INFO] [stderr] | [INFO] [stderr] 467 | tess: tess, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `tess` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/shader/program.rs:457:7 [INFO] [stderr] | [INFO] [stderr] 457 | program: program, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `program` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/shader/program.rs:458:7 [INFO] [stderr] | [INFO] [stderr] 458 | index: index, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `index` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/shader/program.rs:465:7 [INFO] [stderr] | [INFO] [stderr] 465 | program: program, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `program` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/shader/stage.rs:56:11 [INFO] [stderr] | [INFO] [stderr] 56 | handle: handle, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `handle` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/shader/stage.rs:57:11 [INFO] [stderr] | [INFO] [stderr] 57 | ty: ty [INFO] [stderr] | ^^^^^^ help: replace it with: `ty` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/tess.rs:179:11 [INFO] [stderr] | [INFO] [stderr] 179 | vao: vao, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `vao` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/tess.rs:189:11 [INFO] [stderr] | [INFO] [stderr] 189 | vert_nb: vert_nb, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `vert_nb` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/tess.rs:190:11 [INFO] [stderr] | [INFO] [stderr] 190 | vao: vao, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `vao` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/tess.rs:277:9 [INFO] [stderr] | [INFO] [stderr] 277 | vert_nb: vert_nb, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `vert_nb` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/tess.rs:278:9 [INFO] [stderr] | [INFO] [stderr] 278 | vao: vao, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `vao` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/tess.rs:416:7 [INFO] [stderr] | [INFO] [stderr] 416 | tess: tess, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `tess` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/tess.rs:440:7 [INFO] [stderr] | [INFO] [stderr] 440 | tess: tess, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `tess` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/tess.rs:442:7 [INFO] [stderr] | [INFO] [stderr] 442 | vert_nb: vert_nb, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `vert_nb` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/tess.rs:467:7 [INFO] [stderr] | [INFO] [stderr] 467 | tess: tess, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `tess` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unneeded unit expression [INFO] [stderr] --> src/framebuffer.rs:343:68 [INFO] [stderr] | [INFO] [stderr] 343 | ) -> Self where C: GraphicsContext, I: Iterator { () } [INFO] [stderr] | ^^ help: remove the final `()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unused_unit)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit expression [INFO] [stderr] --> src/framebuffer.rs:641:5 [INFO] [stderr] | [INFO] [stderr] 641 | () [INFO] [stderr] | ^^ help: remove the final `()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/shader/stage.rs:118:21 [INFO] [stderr] | [INFO] [stderr] 118 | const GLSL_PRAGMA: &'static str = "\ [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: unneeded unit expression [INFO] [stderr] --> src/framebuffer.rs:343:68 [INFO] [stderr] | [INFO] [stderr] 343 | ) -> Self where C: GraphicsContext, I: Iterator { () } [INFO] [stderr] | ^^ help: remove the final `()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unused_unit)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit expression [INFO] [stderr] --> src/framebuffer.rs:641:5 [INFO] [stderr] | [INFO] [stderr] 641 | () [INFO] [stderr] | ^^ help: remove the final `()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/shader/stage.rs:118:21 [INFO] [stderr] | [INFO] [stderr] 118 | const GLSL_PRAGMA: &'static str = "\ [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: item `buffer::Buffer` has a public `len` method but no corresponding `is_empty` method [INFO] [stderr] --> src/buffer.rs:134:1 [INFO] [stderr] | [INFO] [stderr] 134 | / impl Buffer { [INFO] [stderr] 135 | | /// Create a new `Buffer` with a given number of elements. [INFO] [stderr] 136 | | pub fn new(ctx: &mut C, len: usize) -> Buffer where C: GraphicsContext { [INFO] [stderr] 137 | | let mut buffer: GLuint = 0; [INFO] [stderr] ... | [INFO] [stderr] 280 | | } [INFO] [stderr] 281 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_without_is_empty)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/buffer.rs:175:16 [INFO] [stderr] | [INFO] [stderr] 175 | let x = *ptr.offset(i as isize); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `ptr.add(i)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_offset_with_cast)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/buffer.rs:209:8 [INFO] [stderr] | [INFO] [stderr] 209 | *ptr.offset(i as isize) = x; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `ptr.add(i)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name [INFO] [stderr] --> src/buffer.rs:259:17 [INFO] [stderr] | [INFO] [stderr] 259 | pub fn to_raw(self) -> RawBuffer { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::wrong_self_convention)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the slice [INFO] [stderr] --> src/buffer.rs:391:18 [INFO] [stderr] | [INFO] [stderr] 391 | self.deref().into_iter() [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::into_iter_on_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the slice [INFO] [stderr] --> src/buffer.rs:417:18 [INFO] [stderr] | [INFO] [stderr] 417 | self.deref().into_iter() [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter_mut() and will not move the slice [INFO] [stderr] --> src/buffer.rs:426:22 [INFO] [stderr] | [INFO] [stderr] 426 | self.deref_mut().into_iter() [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter_mut` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: this lifetime isn't used in the function definition [INFO] [stderr] --> src/pipeline.rs:174:19 [INFO] [stderr] | [INFO] [stderr] 174 | pub fn pipeline<'a, L, D, CS, DS, F>( [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::extra_unused_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/render_state.rs:29:19 [INFO] [stderr] | [INFO] [stderr] 29 | pub fn blending(&self) -> Option<(Equation, Factor, Factor)> { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/render_state.rs:40:21 [INFO] [stderr] | [INFO] [stderr] 40 | pub fn depth_test(&self) -> DepthTest { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/render_state.rs:51:23 [INFO] [stderr] | [INFO] [stderr] 51 | pub fn face_culling(&self) -> Option { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/shader/program.rs:80:31 [INFO] [stderr] | [INFO] [stderr] 80 | let mut linked: GLint = gl::FALSE as GLint; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `i32::from(gl::FALSE)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/shader/program.rs:83:20 [INFO] [stderr] | [INFO] [stderr] 83 | if linked == (gl::TRUE as GLint) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(gl::TRUE)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/shader/program.rs:220:8 [INFO] [stderr] | [INFO] [stderr] 220 | ) -> Result<(Program, Vec), (ProgramError, Self)> [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::type_complexity)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/shader/program.rs:234:8 [INFO] [stderr] | [INFO] [stderr] 234 | ) -> Result<(Program, Vec), (ProgramError, Self)> [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: item `buffer::Buffer` has a public `len` method but no corresponding `is_empty` method [INFO] [stderr] --> src/buffer.rs:134:1 [INFO] [stderr] | [INFO] [stderr] 134 | / impl Buffer { [INFO] [stderr] 135 | | /// Create a new `Buffer` with a given number of elements. [INFO] [stderr] 136 | | pub fn new(ctx: &mut C, len: usize) -> Buffer where C: GraphicsContext { [INFO] [stderr] 137 | | let mut buffer: GLuint = 0; [INFO] [stderr] ... | [INFO] [stderr] 280 | | } [INFO] [stderr] 281 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_without_is_empty)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 32 [INFO] [stderr] --> src/shader/program.rs:850:1 [INFO] [stderr] | [INFO] [stderr] 850 | / fn uniform_type_match(program: GLuint, name: &str, ty: Type) -> Result<(), String> { [INFO] [stderr] 851 | | let mut size: GLint = 0; [INFO] [stderr] 852 | | let mut typ: GLuint = 0; [INFO] [stderr] 853 | | let c_name = CString::new(name.as_bytes()).unwrap(); [INFO] [stderr] ... | [INFO] [stderr] 915 | | } [INFO] [stderr] 916 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/buffer.rs:175:16 [INFO] [stderr] | [INFO] [stderr] 175 | let x = *ptr.offset(i as isize); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `ptr.add(i)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_offset_with_cast)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/buffer.rs:209:8 [INFO] [stderr] | [INFO] [stderr] 209 | *ptr.offset(i as isize) = x; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `ptr.add(i)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name [INFO] [stderr] --> src/buffer.rs:259:17 [INFO] [stderr] | [INFO] [stderr] 259 | pub fn to_raw(self) -> RawBuffer { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::wrong_self_convention)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/shader/stage.rs:51:33 [INFO] [stderr] | [INFO] [stderr] 51 | let mut compiled: GLint = gl::FALSE as GLint; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `i32::from(gl::FALSE)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/shader/stage.rs:54:22 [INFO] [stderr] | [INFO] [stderr] 54 | if compiled == (gl::TRUE as GLint) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(gl::TRUE)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the slice [INFO] [stderr] --> src/buffer.rs:391:18 [INFO] [stderr] | [INFO] [stderr] 391 | self.deref().into_iter() [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::into_iter_on_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the slice [INFO] [stderr] --> src/buffer.rs:417:18 [INFO] [stderr] | [INFO] [stderr] 417 | self.deref().into_iter() [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter_mut() and will not move the slice [INFO] [stderr] --> src/buffer.rs:426:22 [INFO] [stderr] | [INFO] [stderr] 426 | self.deref_mut().into_iter() [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter_mut` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/tess.rs:333:19 [INFO] [stderr] | [INFO] [stderr] 333 | fn dim_as_size(d: &Dim) -> GLint { [INFO] [stderr] | ^^^^ help: consider passing by value instead: `Dim` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/tess.rs:357:109 [INFO] [stderr] | [INFO] [stderr] 357 | gl::VertexAttribPointer(i as GLuint, dim_as_size(&f.dim), opengl_sized_type(&f), gl::FALSE, stride, ptr::null::().offset(off as isize)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `ptr::null::().add(off)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/tess.rs:362:99 [INFO] [stderr] | [INFO] [stderr] 362 | gl::VertexAttribIPointer(i as GLuint, dim_as_size(&f.dim), opengl_sized_type(&f), stride, ptr::null::().offset(off as isize)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `ptr::null::().add(off)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/tess.rs:487:3 [INFO] [stderr] | [INFO] [stderr] 487 | fn slice<'a>(&'a self, idx: Idx) -> TessSlice<'a, V>; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/tess.rs:491:3 [INFO] [stderr] | [INFO] [stderr] 491 | / fn slice<'a>(&'a self, _: RangeFull) -> TessSlice<'a, V> { [INFO] [stderr] 492 | | TessSlice::one_whole(self) [INFO] [stderr] 493 | | } [INFO] [stderr] | |___^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/texture.rs:440:14 [INFO] [stderr] | [INFO] [stderr] 440 | sampler: &Sampler [INFO] [stderr] | ^^^^^^^^ help: consider passing by value instead: `Sampler` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name [INFO] [stderr] --> src/texture.rs:478:17 [INFO] [stderr] | [INFO] [stderr] 478 | pub fn to_raw(mut self) -> RawTexture { [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/texture.rs:632:12 [INFO] [stderr] | [INFO] [stderr] 632 | sampler: &Sampler [INFO] [stderr] | ^^^^^^^^ help: consider passing by value instead: `Sampler` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/texture.rs:724:54 [INFO] [stderr] | [INFO] [stderr] 724 | fn apply_sampler_to_texture(target: GLenum, sampler: &Sampler) { [INFO] [stderr] | ^^^^^^^^ help: consider passing by value instead: `Sampler` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this lifetime isn't used in the function definition [INFO] [stderr] --> src/pipeline.rs:174:19 [INFO] [stderr] | [INFO] [stderr] 174 | pub fn pipeline<'a, L, D, CS, DS, F>( [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::extra_unused_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/render_state.rs:29:19 [INFO] [stderr] | [INFO] [stderr] 29 | pub fn blending(&self) -> Option<(Equation, Factor, Factor)> { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/render_state.rs:40:21 [INFO] [stderr] | [INFO] [stderr] 40 | pub fn depth_test(&self) -> DepthTest { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/render_state.rs:51:23 [INFO] [stderr] | [INFO] [stderr] 51 | pub fn face_culling(&self) -> Option { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/shader/program.rs:80:31 [INFO] [stderr] | [INFO] [stderr] 80 | let mut linked: GLint = gl::FALSE as GLint; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `i32::from(gl::FALSE)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/shader/program.rs:83:20 [INFO] [stderr] | [INFO] [stderr] 83 | if linked == (gl::TRUE as GLint) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(gl::TRUE)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/shader/program.rs:220:8 [INFO] [stderr] | [INFO] [stderr] 220 | ) -> Result<(Program, Vec), (ProgramError, Self)> [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::type_complexity)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/shader/program.rs:234:8 [INFO] [stderr] | [INFO] [stderr] 234 | ) -> Result<(Program, Vec), (ProgramError, Self)> [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 32 [INFO] [stderr] --> src/shader/program.rs:850:1 [INFO] [stderr] | [INFO] [stderr] 850 | / fn uniform_type_match(program: GLuint, name: &str, ty: Type) -> Result<(), String> { [INFO] [stderr] 851 | | let mut size: GLint = 0; [INFO] [stderr] 852 | | let mut typ: GLuint = 0; [INFO] [stderr] 853 | | let c_name = CString::new(name.as_bytes()).unwrap(); [INFO] [stderr] ... | [INFO] [stderr] 915 | | } [INFO] [stderr] 916 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/shader/stage.rs:51:33 [INFO] [stderr] | [INFO] [stderr] 51 | let mut compiled: GLint = gl::FALSE as GLint; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `i32::from(gl::FALSE)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/shader/stage.rs:54:22 [INFO] [stderr] | [INFO] [stderr] 54 | if compiled == (gl::TRUE as GLint) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(gl::TRUE)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/tess.rs:333:19 [INFO] [stderr] | [INFO] [stderr] 333 | fn dim_as_size(d: &Dim) -> GLint { [INFO] [stderr] | ^^^^ help: consider passing by value instead: `Dim` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/tess.rs:357:109 [INFO] [stderr] | [INFO] [stderr] 357 | gl::VertexAttribPointer(i as GLuint, dim_as_size(&f.dim), opengl_sized_type(&f), gl::FALSE, stride, ptr::null::().offset(off as isize)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `ptr::null::().add(off)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] warning: use of `offset` with a `usize` casted to an `isize` [INFO] [stderr] --> src/tess.rs:362:99 [INFO] [stderr] | [INFO] [stderr] 362 | gl::VertexAttribIPointer(i as GLuint, dim_as_size(&f.dim), opengl_sized_type(&f), stride, ptr::null::().offset(off as isize)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `ptr::null::().add(off)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_offset_with_cast [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/tess.rs:487:3 [INFO] [stderr] | [INFO] [stderr] 487 | fn slice<'a>(&'a self, idx: Idx) -> TessSlice<'a, V>; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/tess.rs:491:3 [INFO] [stderr] | [INFO] [stderr] 491 | / fn slice<'a>(&'a self, _: RangeFull) -> TessSlice<'a, V> { [INFO] [stderr] 492 | | TessSlice::one_whole(self) [INFO] [stderr] 493 | | } [INFO] [stderr] | |___^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/texture.rs:440:14 [INFO] [stderr] | [INFO] [stderr] 440 | sampler: &Sampler [INFO] [stderr] | ^^^^^^^^ help: consider passing by value instead: `Sampler` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name [INFO] [stderr] --> src/texture.rs:478:17 [INFO] [stderr] | [INFO] [stderr] 478 | pub fn to_raw(mut self) -> RawTexture { [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/texture.rs:632:12 [INFO] [stderr] | [INFO] [stderr] 632 | sampler: &Sampler [INFO] [stderr] | ^^^^^^^^ help: consider passing by value instead: `Sampler` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/texture.rs:724:54 [INFO] [stderr] | [INFO] [stderr] 724 | fn apply_sampler_to_texture(target: GLenum, sampler: &Sampler) { [INFO] [stderr] | ^^^^^^^^ help: consider passing by value instead: `Sampler` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 2.69s [INFO] running `"docker" "inspect" "3dab6cd8249420562a09baf10fe8c5ea0e7846cc39224ce80f465387d15503fd"` [INFO] running `"docker" "rm" "-f" "3dab6cd8249420562a09baf10fe8c5ea0e7846cc39224ce80f465387d15503fd"` [INFO] [stdout] 3dab6cd8249420562a09baf10fe8c5ea0e7846cc39224ce80f465387d15503fd