[INFO] crate luhn2 0.1.2 is already in cache [INFO] extracting crate luhn2 0.1.2 into work/ex/clippy-test-run/sources/stable/reg/luhn2/0.1.2 [INFO] extracting crate luhn2 0.1.2 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/luhn2/0.1.2 [INFO] validating manifest of luhn2-0.1.2 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of luhn2-0.1.2 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing luhn2-0.1.2 [INFO] finished frobbing luhn2-0.1.2 [INFO] frobbed toml for luhn2-0.1.2 written to work/ex/clippy-test-run/sources/stable/reg/luhn2/0.1.2/Cargo.toml [INFO] started frobbing luhn2-0.1.2 [INFO] finished frobbing luhn2-0.1.2 [INFO] frobbed toml for luhn2-0.1.2 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/luhn2/0.1.2/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting luhn2-0.1.2 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/luhn2/0.1.2:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] c29adb1ebfa7750adaa433af23a28cda6ccf0a37b5e485529667e159a96a4b19 [INFO] running `"docker" "start" "-a" "c29adb1ebfa7750adaa433af23a28cda6ccf0a37b5e485529667e159a96a4b19"` [INFO] [stderr] Checking num-digitize v0.4.2 [INFO] [stderr] Checking luhn2 v0.1.2 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:71:5 [INFO] [stderr] | [INFO] [stderr] 71 | return luhn % 10 == 0; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `luhn % 10 == 0` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/lib.rs:12:39 [INFO] [stderr] | [INFO] [stderr] 12 | fn take_digits(card_number_digits: &Vec, mut take_function: F) -> Vec [INFO] [stderr] | ^^^^^^^^ help: change this to: `&[i8]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/lib.rs:26:16 [INFO] [stderr] | [INFO] [stderr] 26 | fn sum(vector: &Vec) -> u64 { [INFO] [stderr] | ^^^^^^^^ help: change this to: `&[i8]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:71:5 [INFO] [stderr] | [INFO] [stderr] 71 | return luhn % 10 == 0; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `luhn % 10 == 0` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:94:26 [INFO] [stderr] | [INFO] [stderr] 94 | assert!(validate(49927398716)); [INFO] [stderr] | ^^^^^^^^^^^ help: consider: `49_927_398_716` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:95:26 [INFO] [stderr] | [INFO] [stderr] 95 | assert!(validate(1234567812345670)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider: `1_234_567_812_345_670` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:96:26 [INFO] [stderr] | [INFO] [stderr] 96 | assert!(validate(79927398713)); [INFO] [stderr] | ^^^^^^^^^^^ help: consider: `79_927_398_713` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:101:26 [INFO] [stderr] | [INFO] [stderr] 101 | assert!(validate(4242424242424241) == false); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider: `4_242_424_242_424_241` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:102:26 [INFO] [stderr] | [INFO] [stderr] 102 | assert!(validate(49927398717) == false); [INFO] [stderr] | ^^^^^^^^^^^ help: consider: `49_927_398_717` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:103:26 [INFO] [stderr] | [INFO] [stderr] 103 | assert!(validate(1234567812345678) == false); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider: `1_234_567_812_345_678` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/lib.rs:12:39 [INFO] [stderr] | [INFO] [stderr] 12 | fn take_digits(card_number_digits: &Vec, mut take_function: F) -> Vec [INFO] [stderr] | ^^^^^^^^ help: change this to: `&[i8]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/lib.rs:26:16 [INFO] [stderr] | [INFO] [stderr] 26 | fn sum(vector: &Vec) -> u64 { [INFO] [stderr] | ^^^^^^^^ help: change this to: `&[i8]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: equality checks against false can be replaced by a negation [INFO] [stderr] --> src/lib.rs:101:17 [INFO] [stderr] | [INFO] [stderr] 101 | assert!(validate(4242424242424241) == false); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `!validate(4242424242424241)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::bool_comparison)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: equality checks against false can be replaced by a negation [INFO] [stderr] --> src/lib.rs:102:17 [INFO] [stderr] | [INFO] [stderr] 102 | assert!(validate(49927398717) == false); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `!validate(49927398717)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: equality checks against false can be replaced by a negation [INFO] [stderr] --> src/lib.rs:103:17 [INFO] [stderr] | [INFO] [stderr] 103 | assert!(validate(1234567812345678) == false); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `!validate(1234567812345678)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 2.88s [INFO] running `"docker" "inspect" "c29adb1ebfa7750adaa433af23a28cda6ccf0a37b5e485529667e159a96a4b19"` [INFO] running `"docker" "rm" "-f" "c29adb1ebfa7750adaa433af23a28cda6ccf0a37b5e485529667e159a96a4b19"` [INFO] [stdout] c29adb1ebfa7750adaa433af23a28cda6ccf0a37b5e485529667e159a96a4b19