[INFO] crate lucky_commit 1.0.1 is already in cache [INFO] extracting crate lucky_commit 1.0.1 into work/ex/clippy-test-run/sources/stable/reg/lucky_commit/1.0.1 [INFO] extracting crate lucky_commit 1.0.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/lucky_commit/1.0.1 [INFO] validating manifest of lucky_commit-1.0.1 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of lucky_commit-1.0.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing lucky_commit-1.0.1 [INFO] finished frobbing lucky_commit-1.0.1 [INFO] frobbed toml for lucky_commit-1.0.1 written to work/ex/clippy-test-run/sources/stable/reg/lucky_commit/1.0.1/Cargo.toml [INFO] started frobbing lucky_commit-1.0.1 [INFO] finished frobbing lucky_commit-1.0.1 [INFO] frobbed toml for lucky_commit-1.0.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/lucky_commit/1.0.1/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting lucky_commit-1.0.1 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/lucky_commit/1.0.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 70b2693e220aaccfa82f4773619a65370a6f1a3c1ec168f5c0ce059611096d64 [INFO] running `"docker" "start" "-a" "70b2693e220aaccfa82f4773619a65370a6f1a3c1ec168f5c0ce059611096d64"` [INFO] [stderr] Checking lucky_commit v1.0.1 (/opt/crater/workdir) [INFO] [stderr] warning: the loop variable `thread_index` is only used to index `u32_ranges`. [INFO] [stderr] --> src/main.rs:145:25 [INFO] [stderr] | [INFO] [stderr] 145 | for thread_index in 0..num_threads { [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 145 | for in u32_ranges.iter().take(num_threads) { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the loop variable `thread_index` is used to index `u64_ranges` [INFO] [stderr] --> src/main.rs:157:25 [INFO] [stderr] | [INFO] [stderr] 157 | for thread_index in 0..num_threads * 2 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 157 | for (thread_index, ) in u64_ranges.iter().enumerate().take(num_threads * 2) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:181:9 [INFO] [stderr] | [INFO] [stderr] 181 | / match result_sender.send(iterate_for_match(¶ms)) { [INFO] [stderr] 182 | | /* [INFO] [stderr] 183 | | * If an error occurs when sending, then the receiver has already received [INFO] [stderr] 184 | | * a match from another thread, so ignore the error. [INFO] [stderr] ... | [INFO] [stderr] 187 | | Err(_) => () [INFO] [stderr] 188 | | } [INFO] [stderr] | |_________^ help: try this: `if let Ok(_) = result_sender.send(iterate_for_match(¶ms)) { () }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: statement can be reduced [INFO] [stderr] --> src/main.rs:224:13 [INFO] [stderr] | [INFO] [stderr] 224 | &mut hash_data[start_index..start_index + 8].copy_from_slice(&padding::PADDING_LIST[padding_index]); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `hash_data[start_index..start_index + 8].copy_from_slice(&padding::PADDING_LIST[padding_index]);` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_operation)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_operation [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/main.rs:331:5 [INFO] [stderr] | [INFO] [stderr] 331 | encoder.write(data)?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::unused_io_amount)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `lucky_commit`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: the loop variable `thread_index` is only used to index `u32_ranges`. [INFO] [stderr] --> src/main.rs:145:25 [INFO] [stderr] | [INFO] [stderr] 145 | for thread_index in 0..num_threads { [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 145 | for in u32_ranges.iter().take(num_threads) { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the loop variable `thread_index` is used to index `u64_ranges` [INFO] [stderr] --> src/main.rs:157:25 [INFO] [stderr] | [INFO] [stderr] 157 | for thread_index in 0..num_threads * 2 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 157 | for (thread_index, ) in u64_ranges.iter().enumerate().take(num_threads * 2) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:181:9 [INFO] [stderr] | [INFO] [stderr] 181 | / match result_sender.send(iterate_for_match(¶ms)) { [INFO] [stderr] 182 | | /* [INFO] [stderr] 183 | | * If an error occurs when sending, then the receiver has already received [INFO] [stderr] 184 | | * a match from another thread, so ignore the error. [INFO] [stderr] ... | [INFO] [stderr] 187 | | Err(_) => () [INFO] [stderr] 188 | | } [INFO] [stderr] | |_________^ help: try this: `if let Ok(_) = result_sender.send(iterate_for_match(¶ms)) { () }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: statement can be reduced [INFO] [stderr] --> src/main.rs:224:13 [INFO] [stderr] | [INFO] [stderr] 224 | &mut hash_data[start_index..start_index + 8].copy_from_slice(&padding::PADDING_LIST[padding_index]); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `hash_data[start_index..start_index + 8].copy_from_slice(&padding::PADDING_LIST[padding_index]);` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_operation)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_operation [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/main.rs:331:5 [INFO] [stderr] | [INFO] [stderr] 331 | encoder.write(data)?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::unused_io_amount)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `lucky_commit`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "70b2693e220aaccfa82f4773619a65370a6f1a3c1ec168f5c0ce059611096d64"` [INFO] running `"docker" "rm" "-f" "70b2693e220aaccfa82f4773619a65370a6f1a3c1ec168f5c0ce059611096d64"` [INFO] [stdout] 70b2693e220aaccfa82f4773619a65370a6f1a3c1ec168f5c0ce059611096d64