[INFO] crate lsystems 0.2.1 is already in cache [INFO] extracting crate lsystems 0.2.1 into work/ex/clippy-test-run/sources/stable/reg/lsystems/0.2.1 [INFO] extracting crate lsystems 0.2.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/lsystems/0.2.1 [INFO] validating manifest of lsystems-0.2.1 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of lsystems-0.2.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing lsystems-0.2.1 [INFO] removed 0 missing examples [INFO] finished frobbing lsystems-0.2.1 [INFO] frobbed toml for lsystems-0.2.1 written to work/ex/clippy-test-run/sources/stable/reg/lsystems/0.2.1/Cargo.toml [INFO] started frobbing lsystems-0.2.1 [INFO] removed 0 missing examples [INFO] finished frobbing lsystems-0.2.1 [INFO] frobbed toml for lsystems-0.2.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/lsystems/0.2.1/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting lsystems-0.2.1 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/lsystems/0.2.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] aa986208cb8aa3ecbcb281b67197c70446dd96989f4d49e2f17c4f0720bd4649 [INFO] running `"docker" "start" "-a" "aa986208cb8aa3ecbcb281b67197c70446dd96989f4d49e2f17c4f0720bd4649"` [INFO] [stderr] Checking lsystems v0.2.1 (/opt/crater/workdir) [INFO] [stderr] warning: use of deprecated item 'rand::sample': renamed to seq::sample_iter [INFO] [stderr] --> src/lib.rs:17:24 [INFO] [stderr] | [INFO] [stderr] 17 | use rand::{thread_rng, sample}; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'rand::sample': renamed to seq::sample_iter [INFO] [stderr] --> src/lib.rs:94:9 [INFO] [stderr] | [INFO] [stderr] 94 | sample(&mut rng, vals.into_iter(), 1)[0].clone() [INFO] [stderr] | ^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of `or_insert` followed by a function call [INFO] [stderr] --> src/lib.rs:71:55 [INFO] [stderr] | [INFO] [stderr] 71 | self.rules.entry((path, predecessor.1, tree)).or_insert(Vec::new()).push(successor.into()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_insert_with(Vec::new)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/lib.rs:91:22 [INFO] [stderr] | [INFO] [stderr] 91 | fn default(vals: &Vec) -> String { [INFO] [stderr] | ^^^^^^^^^^^^ help: change this to: `&[String]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the Vec [INFO] [stderr] --> src/lib.rs:94:31 [INFO] [stderr] | [INFO] [stderr] 94 | sample(&mut rng, vals.into_iter(), 1)[0].clone() [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::into_iter_on_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/lib.rs:144:29 [INFO] [stderr] | [INFO] [stderr] 144 | let b = before [INFO] [stderr] | _____________________________^ [INFO] [stderr] 145 | | .to_string() [INFO] [stderr] 146 | | .chars() [INFO] [stderr] 147 | | .into_iter() [INFO] [stderr] | |____________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] help: consider removing `.into_iter()` [INFO] [stderr] | [INFO] [stderr] 144 | let b = before [INFO] [stderr] 145 | .to_string() [INFO] [stderr] 146 | .chars() [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/lib.rs:159:29 [INFO] [stderr] | [INFO] [stderr] 159 | let a = after [INFO] [stderr] | _____________________________^ [INFO] [stderr] 160 | | .to_string() [INFO] [stderr] 161 | | .chars() [INFO] [stderr] 162 | | .into_iter() [INFO] [stderr] | |____________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] help: consider removing `.into_iter()` [INFO] [stderr] | [INFO] [stderr] 159 | let a = after [INFO] [stderr] 160 | .to_string() [INFO] [stderr] 161 | .chars() [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'rand::sample': renamed to seq::sample_iter [INFO] [stderr] --> src/lib.rs:17:24 [INFO] [stderr] | [INFO] [stderr] 17 | use rand::{thread_rng, sample}; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'rand::sample': renamed to seq::sample_iter [INFO] [stderr] --> src/lib.rs:94:9 [INFO] [stderr] | [INFO] [stderr] 94 | sample(&mut rng, vals.into_iter(), 1)[0].clone() [INFO] [stderr] | ^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of `or_insert` followed by a function call [INFO] [stderr] --> src/lib.rs:71:55 [INFO] [stderr] | [INFO] [stderr] 71 | self.rules.entry((path, predecessor.1, tree)).or_insert(Vec::new()).push(successor.into()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_insert_with(Vec::new)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/lib.rs:91:22 [INFO] [stderr] | [INFO] [stderr] 91 | fn default(vals: &Vec) -> String { [INFO] [stderr] | ^^^^^^^^^^^^ help: change this to: `&[String]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the Vec [INFO] [stderr] --> src/lib.rs:94:31 [INFO] [stderr] | [INFO] [stderr] 94 | sample(&mut rng, vals.into_iter(), 1)[0].clone() [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::into_iter_on_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/lib.rs:144:29 [INFO] [stderr] | [INFO] [stderr] 144 | let b = before [INFO] [stderr] | _____________________________^ [INFO] [stderr] 145 | | .to_string() [INFO] [stderr] 146 | | .chars() [INFO] [stderr] 147 | | .into_iter() [INFO] [stderr] | |____________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] help: consider removing `.into_iter()` [INFO] [stderr] | [INFO] [stderr] 144 | let b = before [INFO] [stderr] 145 | .to_string() [INFO] [stderr] 146 | .chars() [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/lib.rs:159:29 [INFO] [stderr] | [INFO] [stderr] 159 | let a = after [INFO] [stderr] | _____________________________^ [INFO] [stderr] 160 | | .to_string() [INFO] [stderr] 161 | | .chars() [INFO] [stderr] 162 | | .into_iter() [INFO] [stderr] | |____________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] help: consider removing `.into_iter()` [INFO] [stderr] | [INFO] [stderr] 159 | let a = after [INFO] [stderr] 160 | .to_string() [INFO] [stderr] 161 | .chars() [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> tests/main.rs:43:27 [INFO] [stderr] | [INFO] [stderr] 43 | fn distribution(vals: &Vec) -> String { [INFO] [stderr] | ^^^^^^^^^^^^ help: change this to: `&[String]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 2.22s [INFO] running `"docker" "inspect" "aa986208cb8aa3ecbcb281b67197c70446dd96989f4d49e2f17c4f0720bd4649"` [INFO] running `"docker" "rm" "-f" "aa986208cb8aa3ecbcb281b67197c70446dd96989f4d49e2f17c4f0720bd4649"` [INFO] [stdout] aa986208cb8aa3ecbcb281b67197c70446dd96989f4d49e2f17c4f0720bd4649