[INFO] crate lsm303c 0.1.5 is already in cache [INFO] extracting crate lsm303c 0.1.5 into work/ex/clippy-test-run/sources/stable/reg/lsm303c/0.1.5 [INFO] extracting crate lsm303c 0.1.5 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/lsm303c/0.1.5 [INFO] validating manifest of lsm303c-0.1.5 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of lsm303c-0.1.5 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing lsm303c-0.1.5 [INFO] finished frobbing lsm303c-0.1.5 [INFO] frobbed toml for lsm303c-0.1.5 written to work/ex/clippy-test-run/sources/stable/reg/lsm303c/0.1.5/Cargo.toml [INFO] started frobbing lsm303c-0.1.5 [INFO] finished frobbing lsm303c-0.1.5 [INFO] frobbed toml for lsm303c-0.1.5 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/lsm303c/0.1.5/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting lsm303c-0.1.5 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/lsm303c/0.1.5:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 66adcde756b20c487614d6d6a0ae8d4412c09d3d2e770065b643b07061de78ad [INFO] running `"docker" "start" "-a" "66adcde756b20c487614d6d6a0ae8d4412c09d3d2e770065b643b07061de78ad"` [INFO] [stderr] Checking rand v0.5.6 [INFO] [stderr] Checking approx v0.3.1 [INFO] [stderr] Checking alga v0.7.2 [INFO] [stderr] Checking nalgebra v0.16.13 [INFO] [stderr] Checking lsm303c v0.1.5 (/opt/crater/workdir) [INFO] [stderr] error: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/accel.rs:46:17 [INFO] [stderr] | [INFO] [stderr] 46 | pub fn addr(&self) -> u8 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] note: lint level defined here [INFO] [stderr] --> src/lib.rs:39:9 [INFO] [stderr] | [INFO] [stderr] 39 | #![deny(warnings)] [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] = note: #[deny(clippy::trivially_copy_pass_by_ref)] implied by #[deny(warnings)] [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] error: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/conf.rs:69:30 [INFO] [stderr] | [INFO] [stderr] 69 | pub(crate) fn resolution(&self) -> f32 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] error: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/conf.rs:149:30 [INFO] [stderr] | [INFO] [stderr] 149 | pub(crate) fn resolution(&self) -> f32 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] error: you should consider deriving a `Default` implementation for `conf::LsmConfig` [INFO] [stderr] --> src/conf.rs:415:5 [INFO] [stderr] | [INFO] [stderr] 415 | / pub fn new() -> Self { [INFO] [stderr] 416 | | LsmConfig { accel_scale: None, [INFO] [stderr] 417 | | mag_scale: None, [INFO] [stderr] 418 | | accel_data_rate: None, [INFO] [stderr] ... | [INFO] [stderr] 426 | | temp_control: None } [INFO] [stderr] 427 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] note: lint level defined here [INFO] [stderr] --> src/lib.rs:39:9 [INFO] [stderr] | [INFO] [stderr] 39 | #![deny(warnings)] [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] = note: #[deny(clippy::new_without_default_derive)] implied by #[deny(warnings)] [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 383 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] error: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/mag.rs:29:17 [INFO] [stderr] | [INFO] [stderr] 29 | pub fn addr(&self) -> u8 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] error: the operation is ineffective. Consider reducing it to `offset` [INFO] [stderr] --> src/lib.rs:447:67 [INFO] [stderr] | [INFO] [stderr] 447 | Vector3::new(((u16(buffer[offset + 1]) << 8) | u16(buffer[offset + 0])) [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: lint level defined here [INFO] [stderr] --> src/lib.rs:39:9 [INFO] [stderr] | [INFO] [stderr] 39 | #![deny(warnings)] [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] = note: #[deny(clippy::identity_op)] implied by #[deny(warnings)] [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] error: aborting due to 6 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `lsm303c`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/accel.rs:46:17 [INFO] [stderr] | [INFO] [stderr] 46 | pub fn addr(&self) -> u8 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] note: lint level defined here [INFO] [stderr] --> src/lib.rs:39:9 [INFO] [stderr] | [INFO] [stderr] 39 | #![deny(warnings)] [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] = note: #[deny(clippy::trivially_copy_pass_by_ref)] implied by #[deny(warnings)] [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] error: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/conf.rs:69:30 [INFO] [stderr] | [INFO] [stderr] 69 | pub(crate) fn resolution(&self) -> f32 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] error: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/conf.rs:149:30 [INFO] [stderr] | [INFO] [stderr] 149 | pub(crate) fn resolution(&self) -> f32 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] error: you should consider deriving a `Default` implementation for `conf::LsmConfig` [INFO] [stderr] --> src/conf.rs:415:5 [INFO] [stderr] | [INFO] [stderr] 415 | / pub fn new() -> Self { [INFO] [stderr] 416 | | LsmConfig { accel_scale: None, [INFO] [stderr] 417 | | mag_scale: None, [INFO] [stderr] 418 | | accel_data_rate: None, [INFO] [stderr] ... | [INFO] [stderr] 426 | | temp_control: None } [INFO] [stderr] 427 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] note: lint level defined here [INFO] [stderr] --> src/lib.rs:39:9 [INFO] [stderr] | [INFO] [stderr] 39 | #![deny(warnings)] [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] = note: #[deny(clippy::new_without_default_derive)] implied by #[deny(warnings)] [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 383 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] error: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/mag.rs:29:17 [INFO] [stderr] | [INFO] [stderr] 29 | pub fn addr(&self) -> u8 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] error: the operation is ineffective. Consider reducing it to `offset` [INFO] [stderr] --> src/lib.rs:447:67 [INFO] [stderr] | [INFO] [stderr] 447 | Vector3::new(((u16(buffer[offset + 1]) << 8) | u16(buffer[offset + 0])) [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: lint level defined here [INFO] [stderr] --> src/lib.rs:39:9 [INFO] [stderr] | [INFO] [stderr] 39 | #![deny(warnings)] [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] = note: #[deny(clippy::identity_op)] implied by #[deny(warnings)] [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] error: aborting due to 6 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `lsm303c`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "66adcde756b20c487614d6d6a0ae8d4412c09d3d2e770065b643b07061de78ad"` [INFO] running `"docker" "rm" "-f" "66adcde756b20c487614d6d6a0ae8d4412c09d3d2e770065b643b07061de78ad"` [INFO] [stdout] 66adcde756b20c487614d6d6a0ae8d4412c09d3d2e770065b643b07061de78ad