[INFO] crate lru-disk-cache 0.2.0 is already in cache [INFO] extracting crate lru-disk-cache 0.2.0 into work/ex/clippy-test-run/sources/stable/reg/lru-disk-cache/0.2.0 [INFO] extracting crate lru-disk-cache 0.2.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/lru-disk-cache/0.2.0 [INFO] validating manifest of lru-disk-cache-0.2.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of lru-disk-cache-0.2.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing lru-disk-cache-0.2.0 [INFO] finished frobbing lru-disk-cache-0.2.0 [INFO] frobbed toml for lru-disk-cache-0.2.0 written to work/ex/clippy-test-run/sources/stable/reg/lru-disk-cache/0.2.0/Cargo.toml [INFO] started frobbing lru-disk-cache-0.2.0 [INFO] finished frobbing lru-disk-cache-0.2.0 [INFO] frobbed toml for lru-disk-cache-0.2.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/lru-disk-cache/0.2.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting lru-disk-cache-0.2.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/lru-disk-cache/0.2.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 5e0e3066e0c111cda27dffb3994e00ca6019db84fe46d87ec9b1127b9c0678ce [INFO] running `"docker" "start" "-a" "5e0e3066e0c111cda27dffb3994e00ca6019db84fe46d87ec9b1127b9c0678ce"` [INFO] [stderr] Checking linked-hash-map v0.2.1 [INFO] [stderr] Checking lru-disk-cache v0.2.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lru_cache.rs:241:13 [INFO] [stderr] | [INFO] [stderr] 241 | meter: meter, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `meter` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lru_cache.rs:327:13 [INFO] [stderr] | [INFO] [stderr] 327 | meter: meter, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `meter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lru_cache.rs:241:13 [INFO] [stderr] | [INFO] [stderr] 241 | meter: meter, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `meter` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lru_cache.rs:327:13 [INFO] [stderr] | [INFO] [stderr] 327 | meter: meter, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `meter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/lru_cache.rs:83:48 [INFO] [stderr] | [INFO] [stderr] 83 | fn measure(&self, _: &Q, _: &V) -> () [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unused_unit)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:88:9 [INFO] [stderr] | [INFO] [stderr] 88 | / match self { [INFO] [stderr] 89 | | &Error::FileTooLarge => "File too large", [INFO] [stderr] 90 | | &Error::FileNotInCache => "File not in cache", [INFO] [stderr] 91 | | &Error::Io(ref e) => e.description(), [INFO] [stderr] 92 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 88 | match *self { [INFO] [stderr] 89 | Error::FileTooLarge => "File too large", [INFO] [stderr] 90 | Error::FileNotInCache => "File not in cache", [INFO] [stderr] 91 | Error::Io(ref e) => e.description(), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:96:9 [INFO] [stderr] | [INFO] [stderr] 96 | / match self { [INFO] [stderr] 97 | | &Error::Io(ref e) => Some(e), [INFO] [stderr] 98 | | _ => None, [INFO] [stderr] 99 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 96 | match *self { [INFO] [stderr] 97 | Error::Io(ref e) => Some(e), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/lru_cache.rs:83:48 [INFO] [stderr] | [INFO] [stderr] 83 | fn measure(&self, _: &Q, _: &V) -> () [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unused_unit)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:88:9 [INFO] [stderr] | [INFO] [stderr] 88 | / match self { [INFO] [stderr] 89 | | &Error::FileTooLarge => "File too large", [INFO] [stderr] 90 | | &Error::FileNotInCache => "File not in cache", [INFO] [stderr] 91 | | &Error::Io(ref e) => e.description(), [INFO] [stderr] 92 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 88 | match *self { [INFO] [stderr] 89 | Error::FileTooLarge => "File too large", [INFO] [stderr] 90 | Error::FileNotInCache => "File not in cache", [INFO] [stderr] 91 | Error::Io(ref e) => e.description(), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:96:9 [INFO] [stderr] | [INFO] [stderr] 96 | / match self { [INFO] [stderr] 97 | | &Error::Io(ref e) => Some(e), [INFO] [stderr] 98 | | _ => None, [INFO] [stderr] 99 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 96 | match *self { [INFO] [stderr] 97 | Error::Io(ref e) => Some(e), [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> src/lib.rs:339:33 [INFO] [stderr] | [INFO] [stderr] 339 | c.insert_bytes("file3", &vec![0; 10]).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^ help: you can use a slice directly: `&[0; 10]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_vec)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> src/lib.rs:350:33 [INFO] [stderr] | [INFO] [stderr] 350 | c.insert_bytes("a/b/c", &vec![0; 10]).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^ help: you can use a slice directly: `&[0; 10]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> src/lib.rs:352:33 [INFO] [stderr] | [INFO] [stderr] 352 | c.insert_bytes("a/b/d", &vec![0; 10]).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^ help: you can use a slice directly: `&[0; 10]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> src/lib.rs:355:33 [INFO] [stderr] | [INFO] [stderr] 355 | c.insert_bytes("x/y/z", &vec![0; 10]).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^ help: you can use a slice directly: `&[0; 10]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> src/lib.rs:367:33 [INFO] [stderr] | [INFO] [stderr] 367 | c.insert_bytes("file1", &vec![1; 10]).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^ help: you can use a slice directly: `&[1; 10]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> src/lib.rs:368:33 [INFO] [stderr] | [INFO] [stderr] 368 | c.insert_bytes("file2", &vec![2; 10]).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^ help: you can use a slice directly: `&[2; 10]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> src/lib.rs:370:33 [INFO] [stderr] | [INFO] [stderr] 370 | c.insert_bytes("file3", &vec![3; 10]).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^ help: you can use a slice directly: `&[3; 10]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> src/lib.rs:380:37 [INFO] [stderr] | [INFO] [stderr] 380 | c.insert_bytes("file1", &vec![1; 10]).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^ help: you can use a slice directly: `&[1; 10]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> src/lib.rs:381:37 [INFO] [stderr] | [INFO] [stderr] 381 | c.insert_bytes("file2", &vec![2; 10]).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^ help: you can use a slice directly: `&[2; 10]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> src/lib.rs:385:37 [INFO] [stderr] | [INFO] [stderr] 385 | c.insert_bytes("file3", &vec![3; 10]).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^ help: you can use a slice directly: `&[3; 10]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> src/lib.rs:408:37 [INFO] [stderr] | [INFO] [stderr] 408 | c.insert_bytes("file4", &vec![4; 10]).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^ help: you can use a slice directly: `&[4; 10]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> src/lib.rs:419:39 [INFO] [stderr] | [INFO] [stderr] 419 | match c.insert_bytes("a/b/c", &vec![0; 2]) { [INFO] [stderr] | ^^^^^^^^^^^ help: you can use a slice directly: `&[0; 2]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] warning: the `x @ _` pattern can be written as just `x` [INFO] [stderr] --> src/lib.rs:421:13 [INFO] [stderr] | [INFO] [stderr] 421 | x @ _ => panic!("Unexpected result: {:?}", x), [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 2.73s [INFO] running `"docker" "inspect" "5e0e3066e0c111cda27dffb3994e00ca6019db84fe46d87ec9b1127b9c0678ce"` [INFO] running `"docker" "rm" "-f" "5e0e3066e0c111cda27dffb3994e00ca6019db84fe46d87ec9b1127b9c0678ce"` [INFO] [stdout] 5e0e3066e0c111cda27dffb3994e00ca6019db84fe46d87ec9b1127b9c0678ce