[INFO] crate lru 0.1.10 is already in cache [INFO] extracting crate lru 0.1.10 into work/ex/clippy-test-run/sources/stable/reg/lru/0.1.10 [INFO] extracting crate lru 0.1.10 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/lru/0.1.10 [INFO] validating manifest of lru-0.1.10 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of lru-0.1.10 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing lru-0.1.10 [INFO] finished frobbing lru-0.1.10 [INFO] frobbed toml for lru-0.1.10 written to work/ex/clippy-test-run/sources/stable/reg/lru/0.1.10/Cargo.toml [INFO] started frobbing lru-0.1.10 [INFO] finished frobbing lru-0.1.10 [INFO] frobbed toml for lru-0.1.10 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/lru/0.1.10/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting lru-0.1.10 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/lru/0.1.10:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] f5bf6799a02646a5ed4da1269a7231dd2b0f322fae0315e5e74129d39cb09c29 [INFO] running `"docker" "start" "-a" "f5bf6799a02646a5ed4da1269a7231dd2b0f322fae0315e5e74129d39cb09c29"` [INFO] [stderr] Checking lru v0.1.10 (/opt/crater/workdir) [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/lib.rs:359:5 [INFO] [stderr] | [INFO] [stderr] 359 | / pub fn peek_lru<'a>(&'a self) -> Option<(&'a K, &'a V)> { [INFO] [stderr] 360 | | if self.len() == 0 { [INFO] [stderr] 361 | | return None; [INFO] [stderr] 362 | | } [INFO] [stderr] ... | [INFO] [stderr] 371 | | Some((key, val)) [INFO] [stderr] 372 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/lib.rs:360:12 [INFO] [stderr] | [INFO] [stderr] 360 | if self.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: this loop could be written as a `while let` loop [INFO] [stderr] --> src/lib.rs:552:9 [INFO] [stderr] | [INFO] [stderr] 552 | / loop { [INFO] [stderr] 553 | | match self.remove_last() { [INFO] [stderr] 554 | | Some(_) => (), [INFO] [stderr] 555 | | None => break, [INFO] [stderr] 556 | | } [INFO] [stderr] 557 | | } [INFO] [stderr] | |_________^ help: try: `while let Some(_) = self.remove_last() { .. }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::while_let_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/lib.rs:359:5 [INFO] [stderr] | [INFO] [stderr] 359 | / pub fn peek_lru<'a>(&'a self) -> Option<(&'a K, &'a V)> { [INFO] [stderr] 360 | | if self.len() == 0 { [INFO] [stderr] 361 | | return None; [INFO] [stderr] 362 | | } [INFO] [stderr] ... | [INFO] [stderr] 371 | | Some((key, val)) [INFO] [stderr] 372 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/lib.rs:360:12 [INFO] [stderr] | [INFO] [stderr] 360 | if self.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: this loop could be written as a `while let` loop [INFO] [stderr] --> src/lib.rs:552:9 [INFO] [stderr] | [INFO] [stderr] 552 | / loop { [INFO] [stderr] 553 | | match self.remove_last() { [INFO] [stderr] 554 | | Some(_) => (), [INFO] [stderr] 555 | | None => break, [INFO] [stderr] 556 | | } [INFO] [stderr] 557 | | } [INFO] [stderr] | |_________^ help: try: `while let Some(_) = self.remove_last() { .. }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::while_let_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.13s [INFO] running `"docker" "inspect" "f5bf6799a02646a5ed4da1269a7231dd2b0f322fae0315e5e74129d39cb09c29"` [INFO] running `"docker" "rm" "-f" "f5bf6799a02646a5ed4da1269a7231dd2b0f322fae0315e5e74129d39cb09c29"` [INFO] [stdout] f5bf6799a02646a5ed4da1269a7231dd2b0f322fae0315e5e74129d39cb09c29