[INFO] crate lp-modeler 0.3.2 is already in cache
[INFO] extracting crate lp-modeler 0.3.2 into work/ex/clippy-test-run/sources/stable/reg/lp-modeler/0.3.2
[INFO] extracting crate lp-modeler 0.3.2 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/lp-modeler/0.3.2
[INFO] validating manifest of lp-modeler-0.3.2 on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of lp-modeler-0.3.2 on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing lp-modeler-0.3.2
[INFO] finished frobbing lp-modeler-0.3.2
[INFO] frobbed toml for lp-modeler-0.3.2 written to work/ex/clippy-test-run/sources/stable/reg/lp-modeler/0.3.2/Cargo.toml
[INFO] started frobbing lp-modeler-0.3.2
[INFO] finished frobbing lp-modeler-0.3.2
[INFO] frobbed toml for lp-modeler-0.3.2 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/lp-modeler/0.3.2/Cargo.toml
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting lp-modeler-0.3.2 against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/lp-modeler/0.3.2:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 58d43dd99984a5b52e71baface1ebf9c1020365e98151e04e0f5a87ee1250655
[INFO] running `"docker" "start" "-a" "58d43dd99984a5b52e71baface1ebf9c1020365e98151e04e0f5a87ee1250655"`
[INFO] [stderr]     Checking lp-modeler v0.3.2 (/opt/crater/workdir)
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/problem.rs:85:21
[INFO] [stderr]    |
[INFO] [stderr] 85 |         LpProblem { name: name, unique_name: unique_name, objective_type: objective, obj_expr: None, constraints: Vec::new() }
[INFO] [stderr]    |                     ^^^^^^^^^^ help: replace it with: `name`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/problem.rs:85:33
[INFO] [stderr]    |
[INFO] [stderr] 85 |         LpProblem { name: name, unique_name: unique_name, objective_type: objective, obj_expr: None, constraints: Vec::new() }
[INFO] [stderr]    |                                 ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `unique_name`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/solvers.rs:49:49
[INFO] [stderr]    |
[INFO] [stderr] 49 |         GurobiSolver { name: self.name.clone(), command_name: command_name, temp_solution_file: self.temp_solution_file.clone() }
[INFO] [stderr]    |                                                 ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `command_name`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/solvers.rs:99:46
[INFO] [stderr]    |
[INFO] [stderr] 99 |         CbcSolver { name: self.name.clone(), command_name: command_name, temp_solution_file: self.temp_solution_file.clone() }
[INFO] [stderr]    |                                              ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `command_name`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/solvers.rs:102:87
[INFO] [stderr]     |
[INFO] [stderr] 102 |         CbcSolver { name: self.name.clone(), command_name: self.command_name.clone(), temp_solution_file: temp_solution_file }
[INFO] [stderr]     |                                                                                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `temp_solution_file`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/solvers.rs:157:47
[INFO] [stderr]     |
[INFO] [stderr] 157 |         GlpkSolver { name: self.name.clone(), command_name: command_name, temp_solution_file: self.temp_solution_file.clone() }
[INFO] [stderr]     |                                               ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `command_name`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/solvers.rs:160:88
[INFO] [stderr]     |
[INFO] [stderr] 160 |         GlpkSolver { name: self.name.clone(), command_name: self.command_name.clone(), temp_solution_file: temp_solution_file }
[INFO] [stderr]     |                                                                                        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `temp_solution_file`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/problem.rs:85:21
[INFO] [stderr]    |
[INFO] [stderr] 85 |         LpProblem { name: name, unique_name: unique_name, objective_type: objective, obj_expr: None, constraints: Vec::new() }
[INFO] [stderr]    |                     ^^^^^^^^^^ help: replace it with: `name`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/problem.rs:85:33
[INFO] [stderr]    |
[INFO] [stderr] 85 |         LpProblem { name: name, unique_name: unique_name, objective_type: objective, obj_expr: None, constraints: Vec::new() }
[INFO] [stderr]    |                                 ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `unique_name`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/solvers.rs:49:49
[INFO] [stderr]    |
[INFO] [stderr] 49 |         GurobiSolver { name: self.name.clone(), command_name: command_name, temp_solution_file: self.temp_solution_file.clone() }
[INFO] [stderr]    |                                                 ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `command_name`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/solvers.rs:99:46
[INFO] [stderr]    |
[INFO] [stderr] 99 |         CbcSolver { name: self.name.clone(), command_name: command_name, temp_solution_file: self.temp_solution_file.clone() }
[INFO] [stderr]    |                                              ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `command_name`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/solvers.rs:102:87
[INFO] [stderr]     |
[INFO] [stderr] 102 |         CbcSolver { name: self.name.clone(), command_name: self.command_name.clone(), temp_solution_file: temp_solution_file }
[INFO] [stderr]     |                                                                                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `temp_solution_file`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/solvers.rs:157:47
[INFO] [stderr]     |
[INFO] [stderr] 157 |         GlpkSolver { name: self.name.clone(), command_name: command_name, temp_solution_file: self.temp_solution_file.clone() }
[INFO] [stderr]     |                                               ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `command_name`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/solvers.rs:160:88
[INFO] [stderr]     |
[INFO] [stderr] 160 |         GlpkSolver { name: self.name.clone(), command_name: self.command_name.clone(), temp_solution_file: temp_solution_file }
[INFO] [stderr]     |                                                                                        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `temp_solution_file`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/solvers.rs:90:23
[INFO] [stderr]    |
[INFO] [stderr] 90 |             Err(_) => return Err("Cannot open file".to_string())
[INFO] [stderr]    |                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err("Cannot open file".to_string())`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/solvers.rs:148:23
[INFO] [stderr]     |
[INFO] [stderr] 148 |             Err(_) => return Err("Cannot open file".to_string())
[INFO] [stderr]     |                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err("Cannot open file".to_string())`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/solvers.rs:230:23
[INFO] [stderr]     |
[INFO] [stderr] 230 |             Err(_) => return Err("Cannot open file".to_string())
[INFO] [stderr]     |                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err("Cannot open file".to_string())`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/solvers.rs:170:38
[INFO] [stderr]     |
[INFO] [stderr] 170 |                                 _ => return Err("Incorrect solution format".to_string())
[INFO] [stderr]     |                                      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err("Incorrect solution format".to_string())`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/solvers.rs:172:34
[INFO] [stderr]     |
[INFO] [stderr] 172 |                             _ => return Err("Incorrect solution format".to_string())
[INFO] [stderr]     |                                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err("Incorrect solution format".to_string())`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/solvers.rs:175:26
[INFO] [stderr]     |
[INFO] [stderr] 175 |                     _ => return Err("Incorrect solution format".to_string())
[INFO] [stderr]     |                          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err("Incorrect solution format".to_string())`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: this `else { if .. }` block can be collapsed
[INFO] [stderr]    --> src/variables.rs:155:18
[INFO] [stderr]     |
[INFO] [stderr] 155 |               }else{
[INFO] [stderr]     |  __________________^
[INFO] [stderr] 156 | |                 if let &LitVal(..) = e2 {
[INFO] [stderr] 157 | |                     return MulExpr(rc_e2.clone(), rc_e1.clone());
[INFO] [stderr] 158 | |                 }else {
[INFO] [stderr] 159 | |                     return MulExpr(rc_e1.clone(), rc_e2.clone());
[INFO] [stderr] 160 | |                 }
[INFO] [stderr] 161 | |             }
[INFO] [stderr]     | |_____________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::collapsible_if)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stderr] help: try
[INFO] [stderr]     |
[INFO] [stderr] 155 |             }elseif let &LitVal(..) = e2 {
[INFO] [stderr] 156 |     return MulExpr(rc_e2.clone(), rc_e1.clone());
[INFO] [stderr] 157 | }else {
[INFO] [stderr] 158 |     return MulExpr(rc_e1.clone(), rc_e2.clone());
[INFO] [stderr] 159 | }
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/solvers.rs:90:23
[INFO] [stderr]    |
[INFO] [stderr] 90 |             Err(_) => return Err("Cannot open file".to_string())
[INFO] [stderr]    |                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err("Cannot open file".to_string())`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/solvers.rs:148:23
[INFO] [stderr]     |
[INFO] [stderr] 148 |             Err(_) => return Err("Cannot open file".to_string())
[INFO] [stderr]     |                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err("Cannot open file".to_string())`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/solvers.rs:230:23
[INFO] [stderr]     |
[INFO] [stderr] 230 |             Err(_) => return Err("Cannot open file".to_string())
[INFO] [stderr]     |                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err("Cannot open file".to_string())`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/solvers.rs:170:38
[INFO] [stderr]     |
[INFO] [stderr] 170 |                                 _ => return Err("Incorrect solution format".to_string())
[INFO] [stderr]     |                                      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err("Incorrect solution format".to_string())`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/solvers.rs:172:34
[INFO] [stderr]     |
[INFO] [stderr] 172 |                             _ => return Err("Incorrect solution format".to_string())
[INFO] [stderr]     |                                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err("Incorrect solution format".to_string())`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/solvers.rs:175:26
[INFO] [stderr]     |
[INFO] [stderr] 175 |                     _ => return Err("Incorrect solution format".to_string())
[INFO] [stderr]     |                          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err("Incorrect solution format".to_string())`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: this `else { if .. }` block can be collapsed
[INFO] [stderr]    --> src/variables.rs:155:18
[INFO] [stderr]     |
[INFO] [stderr] 155 |               }else{
[INFO] [stderr]     |  __________________^
[INFO] [stderr] 156 | |                 if let &LitVal(..) = e2 {
[INFO] [stderr] 157 | |                     return MulExpr(rc_e2.clone(), rc_e1.clone());
[INFO] [stderr] 158 | |                 }else {
[INFO] [stderr] 159 | |                     return MulExpr(rc_e1.clone(), rc_e2.clone());
[INFO] [stderr] 160 | |                 }
[INFO] [stderr] 161 | |             }
[INFO] [stderr]     | |_____________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::collapsible_if)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stderr] help: try
[INFO] [stderr]     |
[INFO] [stderr] 155 |             }elseif let &LitVal(..) = e2 {
[INFO] [stderr] 156 |     return MulExpr(rc_e2.clone(), rc_e1.clone());
[INFO] [stderr] 157 | }else {
[INFO] [stderr] 158 |     return MulExpr(rc_e1.clone(), rc_e2.clone());
[INFO] [stderr] 159 | }
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]    --> src/problem.rs:92:13
[INFO] [stderr]     |
[INFO] [stderr] 92  | /             match expr {
[INFO] [stderr] 93  | |                 &ConsBin(LpBinary { ref name, .. }) |
[INFO] [stderr] 94  | |                 &ConsInt(LpInteger { ref name, .. }) |
[INFO] [stderr] 95  | |                 &ConsCont(LpContinuous { ref name, .. })
[INFO] [stderr] ...   |
[INFO] [stderr] 103 | |                 _ => ()
[INFO] [stderr] 104 | |             }
[INFO] [stderr]     | |_____________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::match_ref_pats)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]     |
[INFO] [stderr] 92  |             match *expr {
[INFO] [stderr] 93  |                 ConsBin(LpBinary { ref name, .. }) |
[INFO] [stderr] 94  |                 ConsInt(LpInteger { ref name, .. }) |
[INFO] [stderr] 95  |                 ConsCont(LpContinuous { ref name, .. })
[INFO] [stderr] 96  |                 => { lst.push((name.clone(), expr)); },
[INFO] [stderr] 97  | 
[INFO] [stderr]   ...
[INFO] [stderr] 
[INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead
[INFO] [stderr]    --> src/problem.rs:120:9
[INFO] [stderr]     |
[INFO] [stderr] 120 |         try!(buffer.write(self.to_lp_file_format().as_bytes()));
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[deny(clippy::unused_io_amount)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount
[INFO] [stderr]     = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info)
[INFO] [stderr] 
[INFO] [stderr] warning: this loop could be written as a `for` loop
[INFO] [stderr]    --> src/problem.rs:140:46
[INFO] [stderr]     |
[INFO] [stderr] 140 |             while let Some(ref constraint) = cstrs.next() {
[INFO] [stderr]     |                                              ^^^^^^^^^^^^ help: try: `for ref constraint in cstrs { .. }`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::while_let_on_iterator)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_on_iterator
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]    --> src/problem.rs:156:17
[INFO] [stderr]     |
[INFO] [stderr] 156 | /                 match v {
[INFO] [stderr] 157 | |                     &ConsInt(LpInteger { ref name, lower_bound, upper_bound })
[INFO] [stderr] 158 | |                     | &ConsCont(LpContinuous { ref name, lower_bound, upper_bound }) => {
[INFO] [stderr] 159 | |                         if let Some(l) = lower_bound {
[INFO] [stderr] ...   |
[INFO] [stderr] 186 | |                     _ => (),
[INFO] [stderr] 187 | |                 }
[INFO] [stderr]     | |_________________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]     |
[INFO] [stderr] 156 |                 match *v {
[INFO] [stderr] 157 |                     ConsInt(LpInteger { ref name, lower_bound, upper_bound })
[INFO] [stderr] 158 |                     | ConsCont(LpContinuous { ref name, lower_bound, upper_bound }) => {
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]    --> src/problem.rs:176:29
[INFO] [stderr]     |
[INFO] [stderr] 176 | /                             match v {
[INFO] [stderr] 177 | |                                 &ConsCont(LpContinuous { .. }) => {
[INFO] [stderr] 178 | |                                     res.push_str("  ");
[INFO] [stderr] 179 | |                                     res.push_str(&name);
[INFO] [stderr] ...   |
[INFO] [stderr] 182 | |                                 _ => ()
[INFO] [stderr] 183 | |                             }
[INFO] [stderr]     | |_____________________________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::single_match)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] help: try this
[INFO] [stderr]     |
[INFO] [stderr] 176 |                             if let &ConsCont(LpContinuous { .. }) = v {
[INFO] [stderr] 177 |     res.push_str("  ");
[INFO] [stderr] 178 |     res.push_str(&name);
[INFO] [stderr] 179 |     res.push_str(" free\n");
[INFO] [stderr] 180 | }
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]    --> src/problem.rs:176:29
[INFO] [stderr]     |
[INFO] [stderr] 176 | /                             match v {
[INFO] [stderr] 177 | |                                 &ConsCont(LpContinuous { .. }) => {
[INFO] [stderr] 178 | |                                     res.push_str("  ");
[INFO] [stderr] 179 | |                                     res.push_str(&name);
[INFO] [stderr] ...   |
[INFO] [stderr] 182 | |                                 _ => ()
[INFO] [stderr] 183 | |                             }
[INFO] [stderr]     | |_____________________________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]     |
[INFO] [stderr] 176 |                             match *v {
[INFO] [stderr] 177 |                                 ConsCont(LpContinuous { .. }) => {
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]    --> src/problem.rs:195:17
[INFO] [stderr]     |
[INFO] [stderr] 195 | /                 match v {
[INFO] [stderr] 196 | |                     &ConsInt(LpInteger { ref name, .. }) => {
[INFO] [stderr] 197 | |                         res.push_str(name);
[INFO] [stderr] 198 | |                         res.push_str(" ");
[INFO] [stderr] 199 | |                     },
[INFO] [stderr] 200 | |                     _ => (),
[INFO] [stderr] 201 | |                 }
[INFO] [stderr]     | |_________________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] help: try this
[INFO] [stderr]     |
[INFO] [stderr] 195 |                 if let &ConsInt(LpInteger { ref name, .. }) = v {
[INFO] [stderr] 196 |     res.push_str(name);
[INFO] [stderr] 197 |     res.push_str(" ");
[INFO] [stderr] 198 | }
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]    --> src/problem.rs:195:17
[INFO] [stderr]     |
[INFO] [stderr] 195 | /                 match v {
[INFO] [stderr] 196 | |                     &ConsInt(LpInteger { ref name, .. }) => {
[INFO] [stderr] 197 | |                         res.push_str(name);
[INFO] [stderr] 198 | |                         res.push_str(" ");
[INFO] [stderr] 199 | |                     },
[INFO] [stderr] 200 | |                     _ => (),
[INFO] [stderr] 201 | |                 }
[INFO] [stderr]     | |_________________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]     |
[INFO] [stderr] 195 |                 match *v {
[INFO] [stderr] 196 |                     ConsInt(LpInteger { ref name, .. }) => {
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]    --> src/problem.rs:209:17
[INFO] [stderr]     |
[INFO] [stderr] 209 | /                 match v {
[INFO] [stderr] 210 | |                     &ConsBin(LpBinary { ref name }) => {
[INFO] [stderr] 211 | |                         res.push_str(name);
[INFO] [stderr] 212 | |                         res.push_str(" ");
[INFO] [stderr] 213 | |                     },
[INFO] [stderr] 214 | |                     _ => (),
[INFO] [stderr] 215 | |                 }
[INFO] [stderr]     | |_________________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] help: try this
[INFO] [stderr]     |
[INFO] [stderr] 209 |                 if let &ConsBin(LpBinary { ref name }) = v {
[INFO] [stderr] 210 |     res.push_str(name);
[INFO] [stderr] 211 |     res.push_str(" ");
[INFO] [stderr] 212 | }
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]    --> src/problem.rs:209:17
[INFO] [stderr]     |
[INFO] [stderr] 209 | /                 match v {
[INFO] [stderr] 210 | |                     &ConsBin(LpBinary { ref name }) => {
[INFO] [stderr] 211 | |                         res.push_str(name);
[INFO] [stderr] 212 | |                         res.push_str(" ");
[INFO] [stderr] 213 | |                     },
[INFO] [stderr] 214 | |                     _ => (),
[INFO] [stderr] 215 | |                 }
[INFO] [stderr]     | |_________________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]     |
[INFO] [stderr] 209 |                 match *v {
[INFO] [stderr] 210 |                     ConsBin(LpBinary { ref name }) => {
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/problem.rs:237:12
[INFO] [stderr]     |
[INFO] [stderr] 237 |         if cstr_str.len() > 0 {
[INFO] [stderr]     |            ^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!cstr_str.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/problem.rs:244:12
[INFO] [stderr]     |
[INFO] [stderr] 244 |         if bound_str.len() > 0 {
[INFO] [stderr]     |            ^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!bound_str.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/problem.rs:251:12
[INFO] [stderr]     |
[INFO] [stderr] 251 |         if generals_str.len() > 0 {
[INFO] [stderr]     |            ^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!generals_str.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/problem.rs:259:12
[INFO] [stderr]     |
[INFO] [stderr] 259 |         if binaries_str.len() > 0 {
[INFO] [stderr]     |            ^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!binaries_str.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: you should consider deriving a `Default` implementation for `solvers::GurobiSolver`
[INFO] [stderr]   --> src/solvers.rs:45:5
[INFO] [stderr]    |
[INFO] [stderr] 45 | /     pub fn new() -> GurobiSolver {
[INFO] [stderr] 46 | |         GurobiSolver { name: "Gurobi".to_string(), command_name: "gurobi_cl".to_string(), temp_solution_file: format!("{}.sol", Uuid::new_v4().to_string()) }
[INFO] [stderr] 47 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::new_without_default_derive)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 28 | #[derive(Default)]
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: redundant pattern matching, consider using `is_some()`
[INFO] [stderr]   --> src/solvers.rs:59:20
[INFO] [stderr]    |
[INFO] [stderr] 59 |               if let Some(_) = buffer.split(" ").next() {
[INFO] [stderr]    |  _____________-      ^^^^^^^
[INFO] [stderr] 60 | |                 for line in file.lines() {
[INFO] [stderr] 61 | |                     let l = line.unwrap();
[INFO] [stderr] 62 | |
[INFO] [stderr] ...  |
[INFO] [stderr] 79 | |                 return Err("Incorrect solution format".to_string())
[INFO] [stderr] 80 | |             }
[INFO] [stderr]    | |_____________- help: try this: `if buffer.split(" ").next().is_some()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_pattern_matching)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]   --> src/solvers.rs:59:43
[INFO] [stderr]    |
[INFO] [stderr] 59 |             if let Some(_) = buffer.split(" ").next() {
[INFO] [stderr]    |                                           ^^^ help: try using a char instead: `' '`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::single_char_pattern)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: useless use of `format!`
[INFO] [stderr]   --> src/solvers.rs:72:50
[INFO] [stderr]    |
[INFO] [stderr] 72 |                             Err(e) => return Err(format!("{}", e.to_string()))
[INFO] [stderr]    |                                                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: `to_string()` is enough: `e.to_string()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::useless_format)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
[INFO] [stderr]    = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info)
[INFO] [stderr] 
[INFO] [stderr] warning: you should consider deriving a `Default` implementation for `solvers::CbcSolver`
[INFO] [stderr]   --> src/solvers.rs:95:5
[INFO] [stderr]    |
[INFO] [stderr] 95 | /     pub fn new() -> CbcSolver {
[INFO] [stderr] 96 | |         CbcSolver { name: "Cbc".to_string(), command_name: "cbc".to_string(), temp_solution_file: format!("{}.sol", Uuid::new_v4().to_string()) }
[INFO] [stderr] 97 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 33 | #[derive(Default)]
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: you should consider deriving a `Default` implementation for `solvers::GlpkSolver`
[INFO] [stderr]    --> src/solvers.rs:153:5
[INFO] [stderr]     |
[INFO] [stderr] 153 | /     pub fn new() -> GlpkSolver {
[INFO] [stderr] 154 | |         GlpkSolver { name: "Glpk".to_string(), command_name: "glpsol".to_string(), temp_solution_file: format!("{}.sol", Uuid::new_v4().to_string()) }
[INFO] [stderr] 155 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive
[INFO] [stderr] help: try this
[INFO] [stderr]     |
[INFO] [stderr] 38  | #[derive(Default)]
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression
[INFO] [stderr]    --> src/solvers.rs:246:25
[INFO] [stderr]     |
[INFO] [stderr] 246 | /                         let mut status = Status::SubOptimal;
[INFO] [stderr] 247 | |                         if String::from_utf8(r.stdout).expect("").contains("Optimal solution found") {
[INFO] [stderr] 248 | |                             status = Status::Optimal;
[INFO] [stderr] 249 | |                         }
[INFO] [stderr]     | |_________________________^ help: it is more idiomatic to write: `let <mut> status = if String::from_utf8(r.stdout).expect("").contains("Optimal solution found") { Status::Optimal } else { Status::SubOptimal };`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::useless_let_if_seq)] on by default
[INFO] [stderr]     = note: you might not need `mut` at all
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]    --> src/variables.rs:150:9
[INFO] [stderr]     |
[INFO] [stderr] 150 | /         if let &MulExpr(ref rc_e1, ref rc_e2) = self {
[INFO] [stderr] 151 | |             let ref e1 = **rc_e1;
[INFO] [stderr] 152 | |             let ref e2 = **rc_e2;
[INFO] [stderr] 153 | |             if let &LitVal(..) = e1 {
[INFO] [stderr] ...   |
[INFO] [stderr] 161 | |             }
[INFO] [stderr] 162 | |         }
[INFO] [stderr]     | |_________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]     |
[INFO] [stderr] 150 |         if let MulExpr(ref rc_e1, ref rc_e2) = *self {
[INFO] [stderr]     |                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^   ^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead
[INFO] [stderr]    --> src/variables.rs:151:17
[INFO] [stderr]     |
[INFO] [stderr] 151 |             let ref e1 = **rc_e1;
[INFO] [stderr]     |             ----^^^^^^----------- help: try: `let e1 = &(**rc_e1);`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::toplevel_ref_arg)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg
[INFO] [stderr] 
[INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead
[INFO] [stderr]    --> src/variables.rs:152:17
[INFO] [stderr]     |
[INFO] [stderr] 152 |             let ref e2 = **rc_e2;
[INFO] [stderr]     |             ----^^^^^^----------- help: try: `let e2 = &(**rc_e2);`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]    --> src/variables.rs:153:13
[INFO] [stderr]     |
[INFO] [stderr] 153 | /             if let &LitVal(..) = e1 {
[INFO] [stderr] 154 | |                 return self.clone();
[INFO] [stderr] 155 | |             }else{
[INFO] [stderr] 156 | |                 if let &LitVal(..) = e2 {
[INFO] [stderr] ...   |
[INFO] [stderr] 160 | |                 }
[INFO] [stderr] 161 | |             }
[INFO] [stderr]     | |_____________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]     |
[INFO] [stderr] 153 |             if let LitVal(..) = *e1 {
[INFO] [stderr]     |                    ^^^^^^^^^^   ^^^
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]    --> src/variables.rs:156:17
[INFO] [stderr]     |
[INFO] [stderr] 156 | /                 if let &LitVal(..) = e2 {
[INFO] [stderr] 157 | |                     return MulExpr(rc_e2.clone(), rc_e1.clone());
[INFO] [stderr] 158 | |                 }else {
[INFO] [stderr] 159 | |                     return MulExpr(rc_e1.clone(), rc_e2.clone());
[INFO] [stderr] 160 | |                 }
[INFO] [stderr]     | |_________________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]     |
[INFO] [stderr] 156 |                 if let LitVal(..) = *e2 {
[INFO] [stderr]     |                        ^^^^^^^^^^   ^^^
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]    --> src/variables.rs:171:5
[INFO] [stderr]     |
[INFO] [stderr] 171 | /     match e {
[INFO] [stderr] 172 | |         &LitVal(n) => n.to_string(),
[INFO] [stderr] 173 | |         &AddExpr(ref e1, ref e2) => str_left_mult.to_string() + &show(e1, with_parenthesis) + " + " + &show(e2, with_parenthesis) + str_right_mult,
[INFO] [stderr] 174 | |         &SubExpr(ref e1, ref e2) => str_left_mult.to_string() + &show(e1, with_parenthesis) + " - " + &show(e2, with_parenthesis) + str_right_mult,
[INFO] [stderr] ...   |
[INFO] [stderr] 200 | |         _ => "EmptyExpr!!".to_string()
[INFO] [stderr] 201 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]     |
[INFO] [stderr] 171 |     match *e {
[INFO] [stderr] 172 |         LitVal(n) => n.to_string(),
[INFO] [stderr] 173 |         AddExpr(ref e1, ref e2) => str_left_mult.to_string() + &show(e1, with_parenthesis) + " + " + &show(e2, with_parenthesis) + str_right_mult,
[INFO] [stderr] 174 |         SubExpr(ref e1, ref e2) => str_left_mult.to_string() + &show(e1, with_parenthesis) + " - " + &show(e2, with_parenthesis) + str_right_mult,
[INFO] [stderr] 175 |         MulExpr(ref e1, ref e2) => {
[INFO] [stderr] 176 |             let ref deref_e1 = **e1;
[INFO] [stderr]   ...
[INFO] [stderr] 
[INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead
[INFO] [stderr]    --> src/variables.rs:176:17
[INFO] [stderr]     |
[INFO] [stderr] 176 |             let ref deref_e1 = **e1;
[INFO] [stderr]     |             ----^^^^^^^^^^^^-------- help: try: `let deref_e1 = &(**e1);`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]    --> src/variables.rs:178:13
[INFO] [stderr]     |
[INFO] [stderr] 178 | /             match deref_e1 {
[INFO] [stderr] 179 | |                 &LitVal(v) if v == 1.0 => {
[INFO] [stderr] 180 | |                     //e2.to_lp_file_format()
[INFO] [stderr] 181 | |                     str_left_mult.to_string() + &" ".to_string() + &show(e2, with_parenthesis) + str_right_mult
[INFO] [stderr] ...   |
[INFO] [stderr] 187 | |                 _ => str_left_mult.to_string() +  &show(e1, with_parenthesis) + str_op_mult + &show(e2, with_parenthesis) + str_right_mult
[INFO] [stderr] 188 | |             }
[INFO] [stderr]     | |_____________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]     |
[INFO] [stderr] 178 |             match *deref_e1 {
[INFO] [stderr] 179 |                 LitVal(v) if v == 1.0 => {
[INFO] [stderr] 180 |                     //e2.to_lp_file_format()
[INFO] [stderr] 181 |                     str_left_mult.to_string() + &" ".to_string() + &show(e2, with_parenthesis) + str_right_mult
[INFO] [stderr] 182 |                 },
[INFO] [stderr] 183 |                 LitVal(v) if v == -1.0 => {
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] error: strict comparison of f32 or f64
[INFO] [stderr]    --> src/variables.rs:179:31
[INFO] [stderr]     |
[INFO] [stderr] 179 |                 &LitVal(v) if v == 1.0 => {
[INFO] [stderr]     |                               ^^^^^^^^ help: consider comparing them within some error: `(v - 1.0).abs() < error`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[deny(clippy::float_cmp)] on by default
[INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available.
[INFO] [stderr]    --> src/variables.rs:179:31
[INFO] [stderr]     |
[INFO] [stderr] 179 |                 &LitVal(v) if v == 1.0 => {
[INFO] [stderr]     |                               ^^^^^^^^
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp
[INFO] [stderr] 
[INFO] [stderr] error: strict comparison of f32 or f64
[INFO] [stderr]    --> src/variables.rs:183:31
[INFO] [stderr]     |
[INFO] [stderr] 183 |                 &LitVal(v) if v == -1.0 => {
[INFO] [stderr]     |                               ^^^^^^^^^ help: consider comparing them within some error: `(v - -1.0).abs() < error`
[INFO] [stderr]     |
[INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available.
[INFO] [stderr]    --> src/variables.rs:183:31
[INFO] [stderr]     |
[INFO] [stderr] 183 |                 &LitVal(v) if v == -1.0 => {
[INFO] [stderr]     |                               ^^^^^^^^^
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp
[INFO] [stderr] 
[INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead
[INFO] [stderr]    --> src/variables.rs:303:13
[INFO] [stderr]     |
[INFO] [stderr] 303 |         let ref lhs_expr = simplify(&(lhs - rhs));
[INFO] [stderr]     |         ----^^^^^^^^^^^^-------------------------- help: try: `let lhs_expr = &simplify(&(lhs - rhs));`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]    --> src/variables.rs:310:5
[INFO] [stderr]     |
[INFO] [stderr] 310 | /     match expr {
[INFO] [stderr] 311 | |         &AddExpr(ref rc_e1, ref rc_e2) => {
[INFO] [stderr] 312 | |             let ref e1 = **rc_e1;
[INFO] [stderr] 313 | |             let ref e2 = **rc_e2;
[INFO] [stderr] ...   |
[INFO] [stderr] 329 | |         _ => (0.0,expr.clone())
[INFO] [stderr] 330 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]     |
[INFO] [stderr] 310 |     match *expr {
[INFO] [stderr] 311 |         AddExpr(ref rc_e1, ref rc_e2) => {
[INFO] [stderr] 312 |             let ref e1 = **rc_e1;
[INFO] [stderr] 313 |             let ref e2 = **rc_e2;
[INFO] [stderr] 314 |             if let &LitVal(c) = e2 {
[INFO] [stderr] 315 |                 (c, e1.clone())
[INFO] [stderr]   ...
[INFO] [stderr] 
[INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead
[INFO] [stderr]    --> src/variables.rs:312:17
[INFO] [stderr]     |
[INFO] [stderr] 312 |             let ref e1 = **rc_e1;
[INFO] [stderr]     |             ----^^^^^^----------- help: try: `let e1 = &(**rc_e1);`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg
[INFO] [stderr] 
[INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead
[INFO] [stderr]    --> src/variables.rs:313:17
[INFO] [stderr]     |
[INFO] [stderr] 313 |             let ref e2 = **rc_e2;
[INFO] [stderr]     |             ----^^^^^^----------- help: try: `let e2 = &(**rc_e2);`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]    --> src/variables.rs:314:13
[INFO] [stderr]     |
[INFO] [stderr] 314 | /             if let &LitVal(c) = e2 {
[INFO] [stderr] 315 | |                 (c, e1.clone())
[INFO] [stderr] 316 | |             } else {
[INFO] [stderr] 317 | |                 (0.0,expr.clone())
[INFO] [stderr] 318 | |             }
[INFO] [stderr]     | |_____________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]     |
[INFO] [stderr] 314 |             if let LitVal(c) = *e2 {
[INFO] [stderr]     |                    ^^^^^^^^^   ^^^
[INFO] [stderr] 
[INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead
[INFO] [stderr]    --> src/variables.rs:321:17
[INFO] [stderr]     |
[INFO] [stderr] 321 |             let ref e1 = **rc_e1;
[INFO] [stderr]     |             ----^^^^^^----------- help: try: `let e1 = &(**rc_e1);`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg
[INFO] [stderr] 
[INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead
[INFO] [stderr]    --> src/variables.rs:322:17
[INFO] [stderr]     |
[INFO] [stderr] 322 |             let ref e2 = **rc_e2;
[INFO] [stderr]     |             ----^^^^^^----------- help: try: `let e2 = &(**rc_e2);`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]    --> src/variables.rs:323:13
[INFO] [stderr]     |
[INFO] [stderr] 323 | /             if let &LitVal(c) = e2 {
[INFO] [stderr] 324 | |                 (-c, e1.clone())
[INFO] [stderr] 325 | |             } else {
[INFO] [stderr] 326 | |                 (0.0,expr.clone())
[INFO] [stderr] 327 | |             }
[INFO] [stderr]     | |_____________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]     |
[INFO] [stderr] 323 |             if let LitVal(c) = *e2 {
[INFO] [stderr]     |                    ^^^^^^^^^   ^^^
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]    --> src/variables.rs:336:9
[INFO] [stderr]     |
[INFO] [stderr] 336 | /         match expr {
[INFO] [stderr] 337 | |             &MulExpr(ref ref_left_expr, ref ref_right_expr) => {
[INFO] [stderr] 338 | |                 let ref left_expr = **ref_left_expr;
[INFO] [stderr] 339 | |                 let ref right_expr = **ref_right_expr;
[INFO] [stderr] ...   |
[INFO] [stderr] 548 | |             _ => expr.clone()
[INFO] [stderr] 549 | |         }
[INFO] [stderr]     | |_________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]     |
[INFO] [stderr] 336 |         match *expr {
[INFO] [stderr] 337 |             MulExpr(ref ref_left_expr, ref ref_right_expr) => {
[INFO] [stderr] 338 |                 let ref left_expr = **ref_left_expr;
[INFO] [stderr] 339 |                 let ref right_expr = **ref_right_expr;
[INFO] [stderr] 340 | 
[INFO] [stderr] 341 |                 match (left_expr, right_expr) {
[INFO] [stderr]   ...
[INFO] [stderr] 
[INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead
[INFO] [stderr]    --> src/variables.rs:338:21
[INFO] [stderr]     |
[INFO] [stderr] 338 |                 let ref left_expr = **ref_left_expr;
[INFO] [stderr]     |                 ----^^^^^^^^^^^^^------------------- help: try: `let left_expr = &(**ref_left_expr);`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg
[INFO] [stderr] 
[INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead
[INFO] [stderr]    --> src/variables.rs:339:21
[INFO] [stderr]     |
[INFO] [stderr] 339 |                 let ref right_expr = **ref_right_expr;
[INFO] [stderr]     |                 ----^^^^^^^^^^^^^^-------------------- help: try: `let right_expr = &(**ref_right_expr);`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg
[INFO] [stderr] 
[INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead
[INFO] [stderr]    --> src/variables.rs:359:29
[INFO] [stderr]     |
[INFO] [stderr] 359 |                         let ref cc2 = **ref_c2;
[INFO] [stderr]     |                         ----^^^^^^^------------ help: try: `let cc2 = &(**ref_c2);`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]    --> src/variables.rs:360:25
[INFO] [stderr]     |
[INFO] [stderr] 360 | /                         if let &LitVal(c2) = cc2 {
[INFO] [stderr] 361 | |                             return simplify(&MulExpr(Rc::new(LitVal(c1 * c2)), expr.clone()))
[INFO] [stderr] 362 | |                         } else {
[INFO] [stderr] 363 | |                             //MulExpr(Rc::new(LitVal(c1)), Rc::new(simplify(ref_right_expr)))
[INFO] [stderr] 364 | |                             MulExpr(Rc::new(MulExpr(Rc::new(LitVal(c1)), Rc::new(cc2.clone()))), expr.clone())
[INFO] [stderr] 365 | |                         }
[INFO] [stderr]     | |_________________________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]     |
[INFO] [stderr] 360 |                         if let LitVal(c2) = *cc2 {
[INFO] [stderr]     |                                ^^^^^^^^^^   ^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead
[INFO] [stderr]    --> src/variables.rs:396:21
[INFO] [stderr]     |
[INFO] [stderr] 396 |                 let ref left_expr = **ref_left_expr;
[INFO] [stderr]     |                 ----^^^^^^^^^^^^^------------------- help: try: `let left_expr = &(**ref_left_expr);`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg
[INFO] [stderr] 
[INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead
[INFO] [stderr]    --> src/variables.rs:397:21
[INFO] [stderr]     |
[INFO] [stderr] 397 |                 let ref right_expr = **ref_right_expr;
[INFO] [stderr]     |                 ----^^^^^^^^^^^^^^-------------------- help: try: `let right_expr = &(**ref_right_expr);`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg
[INFO] [stderr] 
[INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead
[INFO] [stderr]    --> src/variables.rs:431:29
[INFO] [stderr]     |
[INFO] [stderr] 431 |                         let ref cc1 = **rc1;
[INFO] [stderr]     |                         ----^^^^^^^--------- help: try: `let cc1 = &(**rc1);`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg
[INFO] [stderr] 
[INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead
[INFO] [stderr]    --> src/variables.rs:432:29
[INFO] [stderr]     |
[INFO] [stderr] 432 |                         let ref cc2 = **rc2;
[INFO] [stderr]     |                         ----^^^^^^^--------- help: try: `let cc2 = &(**rc2);`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg
[INFO] [stderr] 
[INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead
[INFO] [stderr]    --> src/variables.rs:476:21
[INFO] [stderr]     |
[INFO] [stderr] 476 |                 let ref left_expr = **ref_left_expr;
[INFO] [stderr]     |                 ----^^^^^^^^^^^^^------------------- help: try: `let left_expr = &(**ref_left_expr);`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg
[INFO] [stderr] 
[INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead
[INFO] [stderr]    --> src/variables.rs:477:21
[INFO] [stderr]     |
[INFO] [stderr] 477 |                 let ref right_expr = **ref_right_expr;
[INFO] [stderr]     |                 ----^^^^^^^^^^^^^^-------------------- help: try: `let right_expr = &(**ref_right_expr);`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg
[INFO] [stderr] 
[INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead
[INFO] [stderr]    --> src/variables.rs:498:29
[INFO] [stderr]     |
[INFO] [stderr] 498 |                         let ref cc1 = **rc1;
[INFO] [stderr]     |                         ----^^^^^^^--------- help: try: `let cc1 = &(**rc1);`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg
[INFO] [stderr] 
[INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead
[INFO] [stderr]    --> src/variables.rs:499:29
[INFO] [stderr]     |
[INFO] [stderr] 499 |                         let ref cc2 = **rc2;
[INFO] [stderr]     |                         ----^^^^^^^--------- help: try: `let cc2 = &(**rc2);`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]    --> src/variables.rs:594:24
[INFO] [stderr]     |
[INFO] [stderr] 594 | pub fn lp_sum<T>(expr: &Vec<T>) -> LpExpression where T : Into<LpExpression> + Clone {
[INFO] [stderr]     |                        ^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] help: change this to
[INFO] [stderr]     |
[INFO] [stderr] 594 | pub fn lp_sum<T>(expr: &[T]) -> LpExpression where T : Into<LpExpression> + Clone {
[INFO] [stderr]     |                        ^^^^
[INFO] [stderr] help: change `expr.clone()` to
[INFO] [stderr]     |
[INFO] [stderr] 596 |     let mut expr = expr.to_owned();
[INFO] [stderr]     |                    ^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] error: aborting due to 3 previous errors
[INFO] [stderr] 
[INFO] [stderr] error: Could not compile `lp-modeler`.
[INFO] [stderr] warning: build failed, waiting for other jobs to finish...
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]    --> src/problem.rs:92:13
[INFO] [stderr]     |
[INFO] [stderr] 92  | /             match expr {
[INFO] [stderr] 93  | |                 &ConsBin(LpBinary { ref name, .. }) |
[INFO] [stderr] 94  | |                 &ConsInt(LpInteger { ref name, .. }) |
[INFO] [stderr] 95  | |                 &ConsCont(LpContinuous { ref name, .. })
[INFO] [stderr] ...   |
[INFO] [stderr] 103 | |                 _ => ()
[INFO] [stderr] 104 | |             }
[INFO] [stderr]     | |_____________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::match_ref_pats)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]     |
[INFO] [stderr] 92  |             match *expr {
[INFO] [stderr] 93  |                 ConsBin(LpBinary { ref name, .. }) |
[INFO] [stderr] 94  |                 ConsInt(LpInteger { ref name, .. }) |
[INFO] [stderr] 95  |                 ConsCont(LpContinuous { ref name, .. })
[INFO] [stderr] 96  |                 => { lst.push((name.clone(), expr)); },
[INFO] [stderr] 97  | 
[INFO] [stderr]   ...
[INFO] [stderr] 
[INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead
[INFO] [stderr]    --> src/problem.rs:120:9
[INFO] [stderr]     |
[INFO] [stderr] 120 |         try!(buffer.write(self.to_lp_file_format().as_bytes()));
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[deny(clippy::unused_io_amount)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount
[INFO] [stderr]     = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info)
[INFO] [stderr] 
[INFO] [stderr] warning: this loop could be written as a `for` loop
[INFO] [stderr]    --> src/problem.rs:140:46
[INFO] [stderr]     |
[INFO] [stderr] 140 |             while let Some(ref constraint) = cstrs.next() {
[INFO] [stderr]     |                                              ^^^^^^^^^^^^ help: try: `for ref constraint in cstrs { .. }`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::while_let_on_iterator)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_on_iterator
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]    --> src/problem.rs:156:17
[INFO] [stderr]     |
[INFO] [stderr] 156 | /                 match v {
[INFO] [stderr] 157 | |                     &ConsInt(LpInteger { ref name, lower_bound, upper_bound })
[INFO] [stderr] 158 | |                     | &ConsCont(LpContinuous { ref name, lower_bound, upper_bound }) => {
[INFO] [stderr] 159 | |                         if let Some(l) = lower_bound {
[INFO] [stderr] ...   |
[INFO] [stderr] 186 | |                     _ => (),
[INFO] [stderr] 187 | |                 }
[INFO] [stderr]     | |_________________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]     |
[INFO] [stderr] 156 |                 match *v {
[INFO] [stderr] 157 |                     ConsInt(LpInteger { ref name, lower_bound, upper_bound })
[INFO] [stderr] 158 |                     | ConsCont(LpContinuous { ref name, lower_bound, upper_bound }) => {
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]    --> src/problem.rs:176:29
[INFO] [stderr]     |
[INFO] [stderr] 176 | /                             match v {
[INFO] [stderr] 177 | |                                 &ConsCont(LpContinuous { .. }) => {
[INFO] [stderr] 178 | |                                     res.push_str("  ");
[INFO] [stderr] 179 | |                                     res.push_str(&name);
[INFO] [stderr] ...   |
[INFO] [stderr] 182 | |                                 _ => ()
[INFO] [stderr] 183 | |                             }
[INFO] [stderr]     | |_____________________________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::single_match)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] help: try this
[INFO] [stderr]     |
[INFO] [stderr] 176 |                             if let &ConsCont(LpContinuous { .. }) = v {
[INFO] [stderr] 177 |     res.push_str("  ");
[INFO] [stderr] 178 |     res.push_str(&name);
[INFO] [stderr] 179 |     res.push_str(" free\n");
[INFO] [stderr] 180 | }
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]    --> src/problem.rs:176:29
[INFO] [stderr]     |
[INFO] [stderr] 176 | /                             match v {
[INFO] [stderr] 177 | |                                 &ConsCont(LpContinuous { .. }) => {
[INFO] [stderr] 178 | |                                     res.push_str("  ");
[INFO] [stderr] 179 | |                                     res.push_str(&name);
[INFO] [stderr] ...   |
[INFO] [stderr] 182 | |                                 _ => ()
[INFO] [stderr] 183 | |                             }
[INFO] [stderr]     | |_____________________________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]     |
[INFO] [stderr] 176 |                             match *v {
[INFO] [stderr] 177 |                                 ConsCont(LpContinuous { .. }) => {
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]    --> src/problem.rs:195:17
[INFO] [stderr]     |
[INFO] [stderr] 195 | /                 match v {
[INFO] [stderr] 196 | |                     &ConsInt(LpInteger { ref name, .. }) => {
[INFO] [stderr] 197 | |                         res.push_str(name);
[INFO] [stderr] 198 | |                         res.push_str(" ");
[INFO] [stderr] 199 | |                     },
[INFO] [stderr] 200 | |                     _ => (),
[INFO] [stderr] 201 | |                 }
[INFO] [stderr]     | |_________________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] help: try this
[INFO] [stderr]     |
[INFO] [stderr] 195 |                 if let &ConsInt(LpInteger { ref name, .. }) = v {
[INFO] [stderr] 196 |     res.push_str(name);
[INFO] [stderr] 197 |     res.push_str(" ");
[INFO] [stderr] 198 | }
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]    --> src/problem.rs:195:17
[INFO] [stderr]     |
[INFO] [stderr] 195 | /                 match v {
[INFO] [stderr] 196 | |                     &ConsInt(LpInteger { ref name, .. }) => {
[INFO] [stderr] 197 | |                         res.push_str(name);
[INFO] [stderr] 198 | |                         res.push_str(" ");
[INFO] [stderr] 199 | |                     },
[INFO] [stderr] 200 | |                     _ => (),
[INFO] [stderr] 201 | |                 }
[INFO] [stderr]     | |_________________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]     |
[INFO] [stderr] 195 |                 match *v {
[INFO] [stderr] 196 |                     ConsInt(LpInteger { ref name, .. }) => {
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]    --> src/problem.rs:209:17
[INFO] [stderr]     |
[INFO] [stderr] 209 | /                 match v {
[INFO] [stderr] 210 | |                     &ConsBin(LpBinary { ref name }) => {
[INFO] [stderr] 211 | |                         res.push_str(name);
[INFO] [stderr] 212 | |                         res.push_str(" ");
[INFO] [stderr] 213 | |                     },
[INFO] [stderr] 214 | |                     _ => (),
[INFO] [stderr] 215 | |                 }
[INFO] [stderr]     | |_________________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] help: try this
[INFO] [stderr]     |
[INFO] [stderr] 209 |                 if let &ConsBin(LpBinary { ref name }) = v {
[INFO] [stderr] 210 |     res.push_str(name);
[INFO] [stderr] 211 |     res.push_str(" ");
[INFO] [stderr] 212 | }
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]    --> src/problem.rs:209:17
[INFO] [stderr]     |
[INFO] [stderr] 209 | /                 match v {
[INFO] [stderr] 210 | |                     &ConsBin(LpBinary { ref name }) => {
[INFO] [stderr] 211 | |                         res.push_str(name);
[INFO] [stderr] 212 | |                         res.push_str(" ");
[INFO] [stderr] 213 | |                     },
[INFO] [stderr] 214 | |                     _ => (),
[INFO] [stderr] 215 | |                 }
[INFO] [stderr]     | |_________________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]     |
[INFO] [stderr] 209 |                 match *v {
[INFO] [stderr] 210 |                     ConsBin(LpBinary { ref name }) => {
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/problem.rs:237:12
[INFO] [stderr]     |
[INFO] [stderr] 237 |         if cstr_str.len() > 0 {
[INFO] [stderr]     |            ^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!cstr_str.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/problem.rs:244:12
[INFO] [stderr]     |
[INFO] [stderr] 244 |         if bound_str.len() > 0 {
[INFO] [stderr]     |            ^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!bound_str.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/problem.rs:251:12
[INFO] [stderr]     |
[INFO] [stderr] 251 |         if generals_str.len() > 0 {
[INFO] [stderr]     |            ^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!generals_str.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/problem.rs:259:12
[INFO] [stderr]     |
[INFO] [stderr] 259 |         if binaries_str.len() > 0 {
[INFO] [stderr]     |            ^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!binaries_str.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: you should consider deriving a `Default` implementation for `solvers::GurobiSolver`
[INFO] [stderr]   --> src/solvers.rs:45:5
[INFO] [stderr]    |
[INFO] [stderr] 45 | /     pub fn new() -> GurobiSolver {
[INFO] [stderr] 46 | |         GurobiSolver { name: "Gurobi".to_string(), command_name: "gurobi_cl".to_string(), temp_solution_file: format!("{}.sol", Uuid::new_v4().to_string()) }
[INFO] [stderr] 47 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::new_without_default_derive)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 28 | #[derive(Default)]
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: redundant pattern matching, consider using `is_some()`
[INFO] [stderr]   --> src/solvers.rs:59:20
[INFO] [stderr]    |
[INFO] [stderr] 59 |               if let Some(_) = buffer.split(" ").next() {
[INFO] [stderr]    |  _____________-      ^^^^^^^
[INFO] [stderr] 60 | |                 for line in file.lines() {
[INFO] [stderr] 61 | |                     let l = line.unwrap();
[INFO] [stderr] 62 | |
[INFO] [stderr] ...  |
[INFO] [stderr] 79 | |                 return Err("Incorrect solution format".to_string())
[INFO] [stderr] 80 | |             }
[INFO] [stderr]    | |_____________- help: try this: `if buffer.split(" ").next().is_some()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_pattern_matching)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]   --> src/solvers.rs:59:43
[INFO] [stderr]    |
[INFO] [stderr] 59 |             if let Some(_) = buffer.split(" ").next() {
[INFO] [stderr]    |                                           ^^^ help: try using a char instead: `' '`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::single_char_pattern)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: useless use of `format!`
[INFO] [stderr]   --> src/solvers.rs:72:50
[INFO] [stderr]    |
[INFO] [stderr] 72 |                             Err(e) => return Err(format!("{}", e.to_string()))
[INFO] [stderr]    |                                                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: `to_string()` is enough: `e.to_string()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::useless_format)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
[INFO] [stderr]    = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info)
[INFO] [stderr] 
[INFO] [stderr] warning: you should consider deriving a `Default` implementation for `solvers::CbcSolver`
[INFO] [stderr]   --> src/solvers.rs:95:5
[INFO] [stderr]    |
[INFO] [stderr] 95 | /     pub fn new() -> CbcSolver {
[INFO] [stderr] 96 | |         CbcSolver { name: "Cbc".to_string(), command_name: "cbc".to_string(), temp_solution_file: format!("{}.sol", Uuid::new_v4().to_string()) }
[INFO] [stderr] 97 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 33 | #[derive(Default)]
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: you should consider deriving a `Default` implementation for `solvers::GlpkSolver`
[INFO] [stderr]    --> src/solvers.rs:153:5
[INFO] [stderr]     |
[INFO] [stderr] 153 | /     pub fn new() -> GlpkSolver {
[INFO] [stderr] 154 | |         GlpkSolver { name: "Glpk".to_string(), command_name: "glpsol".to_string(), temp_solution_file: format!("{}.sol", Uuid::new_v4().to_string()) }
[INFO] [stderr] 155 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive
[INFO] [stderr] help: try this
[INFO] [stderr]     |
[INFO] [stderr] 38  | #[derive(Default)]
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression
[INFO] [stderr]    --> src/solvers.rs:246:25
[INFO] [stderr]     |
[INFO] [stderr] 246 | /                         let mut status = Status::SubOptimal;
[INFO] [stderr] 247 | |                         if String::from_utf8(r.stdout).expect("").contains("Optimal solution found") {
[INFO] [stderr] 248 | |                             status = Status::Optimal;
[INFO] [stderr] 249 | |                         }
[INFO] [stderr]     | |_________________________^ help: it is more idiomatic to write: `let <mut> status = if String::from_utf8(r.stdout).expect("").contains("Optimal solution found") { Status::Optimal } else { Status::SubOptimal };`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::useless_let_if_seq)] on by default
[INFO] [stderr]     = note: you might not need `mut` at all
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]    --> src/variables.rs:150:9
[INFO] [stderr]     |
[INFO] [stderr] 150 | /         if let &MulExpr(ref rc_e1, ref rc_e2) = self {
[INFO] [stderr] 151 | |             let ref e1 = **rc_e1;
[INFO] [stderr] 152 | |             let ref e2 = **rc_e2;
[INFO] [stderr] 153 | |             if let &LitVal(..) = e1 {
[INFO] [stderr] ...   |
[INFO] [stderr] 161 | |             }
[INFO] [stderr] 162 | |         }
[INFO] [stderr]     | |_________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]     |
[INFO] [stderr] 150 |         if let MulExpr(ref rc_e1, ref rc_e2) = *self {
[INFO] [stderr]     |                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^   ^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead
[INFO] [stderr]    --> src/variables.rs:151:17
[INFO] [stderr]     |
[INFO] [stderr] 151 |             let ref e1 = **rc_e1;
[INFO] [stderr]     |             ----^^^^^^----------- help: try: `let e1 = &(**rc_e1);`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::toplevel_ref_arg)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg
[INFO] [stderr] 
[INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead
[INFO] [stderr]    --> src/variables.rs:152:17
[INFO] [stderr]     |
[INFO] [stderr] 152 |             let ref e2 = **rc_e2;
[INFO] [stderr]     |             ----^^^^^^----------- help: try: `let e2 = &(**rc_e2);`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]    --> src/variables.rs:153:13
[INFO] [stderr]     |
[INFO] [stderr] 153 | /             if let &LitVal(..) = e1 {
[INFO] [stderr] 154 | |                 return self.clone();
[INFO] [stderr] 155 | |             }else{
[INFO] [stderr] 156 | |                 if let &LitVal(..) = e2 {
[INFO] [stderr] ...   |
[INFO] [stderr] 160 | |                 }
[INFO] [stderr] 161 | |             }
[INFO] [stderr]     | |_____________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]     |
[INFO] [stderr] 153 |             if let LitVal(..) = *e1 {
[INFO] [stderr]     |                    ^^^^^^^^^^   ^^^
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]    --> src/variables.rs:156:17
[INFO] [stderr]     |
[INFO] [stderr] 156 | /                 if let &LitVal(..) = e2 {
[INFO] [stderr] 157 | |                     return MulExpr(rc_e2.clone(), rc_e1.clone());
[INFO] [stderr] 158 | |                 }else {
[INFO] [stderr] 159 | |                     return MulExpr(rc_e1.clone(), rc_e2.clone());
[INFO] [stderr] 160 | |                 }
[INFO] [stderr]     | |_________________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]     |
[INFO] [stderr] 156 |                 if let LitVal(..) = *e2 {
[INFO] [stderr]     |                        ^^^^^^^^^^   ^^^
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]    --> src/variables.rs:171:5
[INFO] [stderr]     |
[INFO] [stderr] 171 | /     match e {
[INFO] [stderr] 172 | |         &LitVal(n) => n.to_string(),
[INFO] [stderr] 173 | |         &AddExpr(ref e1, ref e2) => str_left_mult.to_string() + &show(e1, with_parenthesis) + " + " + &show(e2, with_parenthesis) + str_right_mult,
[INFO] [stderr] 174 | |         &SubExpr(ref e1, ref e2) => str_left_mult.to_string() + &show(e1, with_parenthesis) + " - " + &show(e2, with_parenthesis) + str_right_mult,
[INFO] [stderr] ...   |
[INFO] [stderr] 200 | |         _ => "EmptyExpr!!".to_string()
[INFO] [stderr] 201 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]     |
[INFO] [stderr] 171 |     match *e {
[INFO] [stderr] 172 |         LitVal(n) => n.to_string(),
[INFO] [stderr] 173 |         AddExpr(ref e1, ref e2) => str_left_mult.to_string() + &show(e1, with_parenthesis) + " + " + &show(e2, with_parenthesis) + str_right_mult,
[INFO] [stderr] 174 |         SubExpr(ref e1, ref e2) => str_left_mult.to_string() + &show(e1, with_parenthesis) + " - " + &show(e2, with_parenthesis) + str_right_mult,
[INFO] [stderr] 175 |         MulExpr(ref e1, ref e2) => {
[INFO] [stderr] 176 |             let ref deref_e1 = **e1;
[INFO] [stderr]   ...
[INFO] [stderr] 
[INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead
[INFO] [stderr]    --> src/variables.rs:176:17
[INFO] [stderr]     |
[INFO] [stderr] 176 |             let ref deref_e1 = **e1;
[INFO] [stderr]     |             ----^^^^^^^^^^^^-------- help: try: `let deref_e1 = &(**e1);`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]    --> src/variables.rs:178:13
[INFO] [stderr]     |
[INFO] [stderr] 178 | /             match deref_e1 {
[INFO] [stderr] 179 | |                 &LitVal(v) if v == 1.0 => {
[INFO] [stderr] 180 | |                     //e2.to_lp_file_format()
[INFO] [stderr] 181 | |                     str_left_mult.to_string() + &" ".to_string() + &show(e2, with_parenthesis) + str_right_mult
[INFO] [stderr] ...   |
[INFO] [stderr] 187 | |                 _ => str_left_mult.to_string() +  &show(e1, with_parenthesis) + str_op_mult + &show(e2, with_parenthesis) + str_right_mult
[INFO] [stderr] 188 | |             }
[INFO] [stderr]     | |_____________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]     |
[INFO] [stderr] 178 |             match *deref_e1 {
[INFO] [stderr] 179 |                 LitVal(v) if v == 1.0 => {
[INFO] [stderr] 180 |                     //e2.to_lp_file_format()
[INFO] [stderr] 181 |                     str_left_mult.to_string() + &" ".to_string() + &show(e2, with_parenthesis) + str_right_mult
[INFO] [stderr] 182 |                 },
[INFO] [stderr] 183 |                 LitVal(v) if v == -1.0 => {
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] error: strict comparison of f32 or f64
[INFO] [stderr]    --> src/variables.rs:179:31
[INFO] [stderr]     |
[INFO] [stderr] 179 |                 &LitVal(v) if v == 1.0 => {
[INFO] [stderr]     |                               ^^^^^^^^ help: consider comparing them within some error: `(v - 1.0).abs() < error`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[deny(clippy::float_cmp)] on by default
[INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available.
[INFO] [stderr]    --> src/variables.rs:179:31
[INFO] [stderr]     |
[INFO] [stderr] 179 |                 &LitVal(v) if v == 1.0 => {
[INFO] [stderr]     |                               ^^^^^^^^
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp
[INFO] [stderr] 
[INFO] [stderr] error: strict comparison of f32 or f64
[INFO] [stderr]    --> src/variables.rs:183:31
[INFO] [stderr]     |
[INFO] [stderr] 183 |                 &LitVal(v) if v == -1.0 => {
[INFO] [stderr]     |                               ^^^^^^^^^ help: consider comparing them within some error: `(v - -1.0).abs() < error`
[INFO] [stderr]     |
[INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available.
[INFO] [stderr]    --> src/variables.rs:183:31
[INFO] [stderr]     |
[INFO] [stderr] 183 |                 &LitVal(v) if v == -1.0 => {
[INFO] [stderr]     |                               ^^^^^^^^^
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp
[INFO] [stderr] 
[INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead
[INFO] [stderr]    --> src/variables.rs:303:13
[INFO] [stderr]     |
[INFO] [stderr] 303 |         let ref lhs_expr = simplify(&(lhs - rhs));
[INFO] [stderr]     |         ----^^^^^^^^^^^^-------------------------- help: try: `let lhs_expr = &simplify(&(lhs - rhs));`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]    --> src/variables.rs:310:5
[INFO] [stderr]     |
[INFO] [stderr] 310 | /     match expr {
[INFO] [stderr] 311 | |         &AddExpr(ref rc_e1, ref rc_e2) => {
[INFO] [stderr] 312 | |             let ref e1 = **rc_e1;
[INFO] [stderr] 313 | |             let ref e2 = **rc_e2;
[INFO] [stderr] ...   |
[INFO] [stderr] 329 | |         _ => (0.0,expr.clone())
[INFO] [stderr] 330 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]     |
[INFO] [stderr] 310 |     match *expr {
[INFO] [stderr] 311 |         AddExpr(ref rc_e1, ref rc_e2) => {
[INFO] [stderr] 312 |             let ref e1 = **rc_e1;
[INFO] [stderr] 313 |             let ref e2 = **rc_e2;
[INFO] [stderr] 314 |             if let &LitVal(c) = e2 {
[INFO] [stderr] 315 |                 (c, e1.clone())
[INFO] [stderr]   ...
[INFO] [stderr] 
[INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead
[INFO] [stderr]    --> src/variables.rs:312:17
[INFO] [stderr]     |
[INFO] [stderr] 312 |             let ref e1 = **rc_e1;
[INFO] [stderr]     |             ----^^^^^^----------- help: try: `let e1 = &(**rc_e1);`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg
[INFO] [stderr] 
[INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead
[INFO] [stderr]    --> src/variables.rs:313:17
[INFO] [stderr]     |
[INFO] [stderr] 313 |             let ref e2 = **rc_e2;
[INFO] [stderr]     |             ----^^^^^^----------- help: try: `let e2 = &(**rc_e2);`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]    --> src/variables.rs:314:13
[INFO] [stderr]     |
[INFO] [stderr] 314 | /             if let &LitVal(c) = e2 {
[INFO] [stderr] 315 | |                 (c, e1.clone())
[INFO] [stderr] 316 | |             } else {
[INFO] [stderr] 317 | |                 (0.0,expr.clone())
[INFO] [stderr] 318 | |             }
[INFO] [stderr]     | |_____________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]     |
[INFO] [stderr] 314 |             if let LitVal(c) = *e2 {
[INFO] [stderr]     |                    ^^^^^^^^^   ^^^
[INFO] [stderr] 
[INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead
[INFO] [stderr]    --> src/variables.rs:321:17
[INFO] [stderr]     |
[INFO] [stderr] 321 |             let ref e1 = **rc_e1;
[INFO] [stderr]     |             ----^^^^^^----------- help: try: `let e1 = &(**rc_e1);`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg
[INFO] [stderr] 
[INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead
[INFO] [stderr]    --> src/variables.rs:322:17
[INFO] [stderr]     |
[INFO] [stderr] 322 |             let ref e2 = **rc_e2;
[INFO] [stderr]     |             ----^^^^^^----------- help: try: `let e2 = &(**rc_e2);`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]    --> src/variables.rs:323:13
[INFO] [stderr]     |
[INFO] [stderr] 323 | /             if let &LitVal(c) = e2 {
[INFO] [stderr] 324 | |                 (-c, e1.clone())
[INFO] [stderr] 325 | |             } else {
[INFO] [stderr] 326 | |                 (0.0,expr.clone())
[INFO] [stderr] 327 | |             }
[INFO] [stderr]     | |_____________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]     |
[INFO] [stderr] 323 |             if let LitVal(c) = *e2 {
[INFO] [stderr]     |                    ^^^^^^^^^   ^^^
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]    --> src/variables.rs:336:9
[INFO] [stderr]     |
[INFO] [stderr] 336 | /         match expr {
[INFO] [stderr] 337 | |             &MulExpr(ref ref_left_expr, ref ref_right_expr) => {
[INFO] [stderr] 338 | |                 let ref left_expr = **ref_left_expr;
[INFO] [stderr] 339 | |                 let ref right_expr = **ref_right_expr;
[INFO] [stderr] ...   |
[INFO] [stderr] 548 | |             _ => expr.clone()
[INFO] [stderr] 549 | |         }
[INFO] [stderr]     | |_________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]     |
[INFO] [stderr] 336 |         match *expr {
[INFO] [stderr] 337 |             MulExpr(ref ref_left_expr, ref ref_right_expr) => {
[INFO] [stderr] 338 |                 let ref left_expr = **ref_left_expr;
[INFO] [stderr] 339 |                 let ref right_expr = **ref_right_expr;
[INFO] [stderr] 340 | 
[INFO] [stderr] 341 |                 match (left_expr, right_expr) {
[INFO] [stderr]   ...
[INFO] [stderr] 
[INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead
[INFO] [stderr]    --> src/variables.rs:338:21
[INFO] [stderr]     |
[INFO] [stderr] 338 |                 let ref left_expr = **ref_left_expr;
[INFO] [stderr]     |                 ----^^^^^^^^^^^^^------------------- help: try: `let left_expr = &(**ref_left_expr);`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg
[INFO] [stderr] 
[INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead
[INFO] [stderr]    --> src/variables.rs:339:21
[INFO] [stderr]     |
[INFO] [stderr] 339 |                 let ref right_expr = **ref_right_expr;
[INFO] [stderr]     |                 ----^^^^^^^^^^^^^^-------------------- help: try: `let right_expr = &(**ref_right_expr);`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg
[INFO] [stderr] 
[INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead
[INFO] [stderr]    --> src/variables.rs:359:29
[INFO] [stderr]     |
[INFO] [stderr] 359 |                         let ref cc2 = **ref_c2;
[INFO] [stderr]     |                         ----^^^^^^^------------ help: try: `let cc2 = &(**ref_c2);`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]    --> src/variables.rs:360:25
[INFO] [stderr]     |
[INFO] [stderr] 360 | /                         if let &LitVal(c2) = cc2 {
[INFO] [stderr] 361 | |                             return simplify(&MulExpr(Rc::new(LitVal(c1 * c2)), expr.clone()))
[INFO] [stderr] 362 | |                         } else {
[INFO] [stderr] 363 | |                             //MulExpr(Rc::new(LitVal(c1)), Rc::new(simplify(ref_right_expr)))
[INFO] [stderr] 364 | |                             MulExpr(Rc::new(MulExpr(Rc::new(LitVal(c1)), Rc::new(cc2.clone()))), expr.clone())
[INFO] [stderr] 365 | |                         }
[INFO] [stderr]     | |_________________________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]     |
[INFO] [stderr] 360 |                         if let LitVal(c2) = *cc2 {
[INFO] [stderr]     |                                ^^^^^^^^^^   ^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead
[INFO] [stderr]    --> src/variables.rs:396:21
[INFO] [stderr]     |
[INFO] [stderr] 396 |                 let ref left_expr = **ref_left_expr;
[INFO] [stderr]     |                 ----^^^^^^^^^^^^^------------------- help: try: `let left_expr = &(**ref_left_expr);`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg
[INFO] [stderr] 
[INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead
[INFO] [stderr]    --> src/variables.rs:397:21
[INFO] [stderr]     |
[INFO] [stderr] 397 |                 let ref right_expr = **ref_right_expr;
[INFO] [stderr]     |                 ----^^^^^^^^^^^^^^-------------------- help: try: `let right_expr = &(**ref_right_expr);`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg
[INFO] [stderr] 
[INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead
[INFO] [stderr]    --> src/variables.rs:431:29
[INFO] [stderr]     |
[INFO] [stderr] 431 |                         let ref cc1 = **rc1;
[INFO] [stderr]     |                         ----^^^^^^^--------- help: try: `let cc1 = &(**rc1);`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg
[INFO] [stderr] 
[INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead
[INFO] [stderr]    --> src/variables.rs:432:29
[INFO] [stderr]     |
[INFO] [stderr] 432 |                         let ref cc2 = **rc2;
[INFO] [stderr]     |                         ----^^^^^^^--------- help: try: `let cc2 = &(**rc2);`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg
[INFO] [stderr] 
[INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead
[INFO] [stderr]    --> src/variables.rs:476:21
[INFO] [stderr]     |
[INFO] [stderr] 476 |                 let ref left_expr = **ref_left_expr;
[INFO] [stderr]     |                 ----^^^^^^^^^^^^^------------------- help: try: `let left_expr = &(**ref_left_expr);`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg
[INFO] [stderr] 
[INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead
[INFO] [stderr]    --> src/variables.rs:477:21
[INFO] [stderr]     |
[INFO] [stderr] 477 |                 let ref right_expr = **ref_right_expr;
[INFO] [stderr]     |                 ----^^^^^^^^^^^^^^-------------------- help: try: `let right_expr = &(**ref_right_expr);`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg
[INFO] [stderr] 
[INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead
[INFO] [stderr]    --> src/variables.rs:498:29
[INFO] [stderr]     |
[INFO] [stderr] 498 |                         let ref cc1 = **rc1;
[INFO] [stderr]     |                         ----^^^^^^^--------- help: try: `let cc1 = &(**rc1);`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg
[INFO] [stderr] 
[INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead
[INFO] [stderr]    --> src/variables.rs:499:29
[INFO] [stderr]     |
[INFO] [stderr] 499 |                         let ref cc2 = **rc2;
[INFO] [stderr]     |                         ----^^^^^^^--------- help: try: `let cc2 = &(**rc2);`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]    --> src/variables.rs:594:24
[INFO] [stderr]     |
[INFO] [stderr] 594 | pub fn lp_sum<T>(expr: &Vec<T>) -> LpExpression where T : Into<LpExpression> + Clone {
[INFO] [stderr]     |                        ^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] help: change this to
[INFO] [stderr]     |
[INFO] [stderr] 594 | pub fn lp_sum<T>(expr: &[T]) -> LpExpression where T : Into<LpExpression> + Clone {
[INFO] [stderr]     |                        ^^^^
[INFO] [stderr] help: change `expr.clone()` to
[INFO] [stderr]     |
[INFO] [stderr] 596 |     let mut expr = expr.to_owned();
[INFO] [stderr]     |                    ^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] error: aborting due to 3 previous errors
[INFO] [stderr] 
[INFO] [stderr] error: Could not compile `lp-modeler`.
[INFO] [stderr] 
[INFO] [stderr] To learn more, run the command again with --verbose.
[INFO] running `"docker" "inspect" "58d43dd99984a5b52e71baface1ebf9c1020365e98151e04e0f5a87ee1250655"`
[INFO] running `"docker" "rm" "-f" "58d43dd99984a5b52e71baface1ebf9c1020365e98151e04e0f5a87ee1250655"`
[INFO] [stdout] 58d43dd99984a5b52e71baface1ebf9c1020365e98151e04e0f5a87ee1250655