[INFO] crate lorawan 0.3.0 is already in cache [INFO] extracting crate lorawan 0.3.0 into work/ex/clippy-test-run/sources/stable/reg/lorawan/0.3.0 [INFO] extracting crate lorawan 0.3.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/lorawan/0.3.0 [INFO] validating manifest of lorawan-0.3.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of lorawan-0.3.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing lorawan-0.3.0 [INFO] finished frobbing lorawan-0.3.0 [INFO] frobbed toml for lorawan-0.3.0 written to work/ex/clippy-test-run/sources/stable/reg/lorawan/0.3.0/Cargo.toml [INFO] started frobbing lorawan-0.3.0 [INFO] finished frobbing lorawan-0.3.0 [INFO] frobbed toml for lorawan-0.3.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/lorawan/0.3.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting lorawan-0.3.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/lorawan/0.3.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 064213641c4a9ca0f98babf8fcee702c24e6daa28c7124fc515eadff3479c158 [INFO] running `"docker" "start" "-a" "064213641c4a9ca0f98babf8fcee702c24e6daa28c7124fc515eadff3479c158"` [INFO] [stderr] Checking lorawan v0.3.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cmac.rs:154:13 [INFO] [stderr] | [INFO] [stderr] 154 | cipher: cipher, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `cipher` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cmac.rs:155:13 [INFO] [stderr] | [INFO] [stderr] 155 | key_one: key_one, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `key_one` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cmac.rs:156:13 [INFO] [stderr] | [INFO] [stderr] 156 | key_two: key_two, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `key_two` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/creator.rs:49:13 [INFO] [stderr] | [INFO] [stderr] 49 | data: data, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `data` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cmac.rs:154:13 [INFO] [stderr] | [INFO] [stderr] 154 | cipher: cipher, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `cipher` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cmac.rs:155:13 [INFO] [stderr] | [INFO] [stderr] 155 | key_one: key_one, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `key_one` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cmac.rs:156:13 [INFO] [stderr] | [INFO] [stderr] 156 | key_two: key_two, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `key_two` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/creator.rs:49:13 [INFO] [stderr] | [INFO] [stderr] 49 | data: data, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `data` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/creator.rs:213:30 [INFO] [stderr] | [INFO] [stderr] 213 | JoinRequestCreator { data: data } [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `data` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/creator.rs:213:30 [INFO] [stderr] | [INFO] [stderr] 213 | JoinRequestCreator { data: data } [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `data` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/creator.rs:310:13 [INFO] [stderr] | [INFO] [stderr] 310 | data: data, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `data` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/creator.rs:310:13 [INFO] [stderr] | [INFO] [stderr] 310 | data: data, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `data` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around method argument [INFO] [stderr] --> src/cmac.rs:108:23 [INFO] [stderr] | [INFO] [stderr] 108 | data.split_at((block_size * n_blocks)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_parens)] on by default [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> src/cmac.rs:108:23 [INFO] [stderr] | [INFO] [stderr] 108 | data.split_at((block_size * n_blocks)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::double_parens)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/parser.rs:607:9 [INFO] [stderr] | [INFO] [stderr] 607 | res [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/parser.rs:606:19 [INFO] [stderr] | [INFO] [stderr] 606 | let res = ((self.0[6] as u16) << 8) | (self.0[5] as u16); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around method argument [INFO] [stderr] --> src/cmac.rs:108:23 [INFO] [stderr] | [INFO] [stderr] 108 | data.split_at((block_size * n_blocks)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_parens)] on by default [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> src/cmac.rs:108:23 [INFO] [stderr] | [INFO] [stderr] 108 | data.split_at((block_size * n_blocks)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::double_parens)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/parser.rs:607:9 [INFO] [stderr] | [INFO] [stderr] 607 | res [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/parser.rs:606:19 [INFO] [stderr] | [INFO] [stderr] 606 | let res = ((self.0[6] as u16) << 8) | (self.0[5] as u16); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `data`. [INFO] [stderr] --> src/cmac.rs:83:14 [INFO] [stderr] | [INFO] [stderr] 83 | for i in (len + 1)..block_size { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 83 | for in data.iter_mut().take(block_size).skip((len + 1)) { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/cmac.rs:97:23 [INFO] [stderr] | [INFO] [stderr] 97 | let n_blocks = if data.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `data.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/cmac.rs:123:12 [INFO] [stderr] | [INFO] [stderr] 123 | if data.len() != 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!data.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `creator::JoinAcceptCreator` [INFO] [stderr] --> src/creator.rs:45:5 [INFO] [stderr] | [INFO] [stderr] 45 | / pub fn new() -> JoinAcceptCreator { [INFO] [stderr] 46 | | let mut data = vec![0; 17]; [INFO] [stderr] 47 | | data[0] = 0x20; [INFO] [stderr] 48 | | JoinAcceptCreator { [INFO] [stderr] ... | [INFO] [stderr] 51 | | } [INFO] [stderr] 52 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 22 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: the loop variable `j` is used to index `tmp` [INFO] [stderr] --> src/creator.rs:176:22 [INFO] [stderr] | [INFO] [stderr] 176 | for j in 0..16 { [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 176 | for (j, ) in tmp.iter().enumerate().take(16) { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: it looks like you're manually copying between slices [INFO] [stderr] --> src/creator.rs:176:22 [INFO] [stderr] | [INFO] [stderr] 176 | for j in 0..16 { [INFO] [stderr] | ^^^^^ help: try replacing the loop by: `self.data[start..(16 + start)].clone_from_slice(&tmp[..16])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::manual_memcpy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_memcpy [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `creator::JoinRequestCreator` [INFO] [stderr] --> src/creator.rs:210:5 [INFO] [stderr] | [INFO] [stderr] 210 | / pub fn new() -> JoinRequestCreator { [INFO] [stderr] 211 | | let mut data = vec![0; 23]; [INFO] [stderr] 212 | | data[0] = 0x00; [INFO] [stderr] 213 | | JoinRequestCreator { data: data } [INFO] [stderr] 214 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 193 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `creator::DataPayloadCreator` [INFO] [stderr] --> src/creator.rs:306:5 [INFO] [stderr] | [INFO] [stderr] 306 | / pub fn new() -> DataPayloadCreator { [INFO] [stderr] 307 | | let mut data = vec![0; 12]; [INFO] [stderr] 308 | | data[0] = 0x40; [INFO] [stderr] 309 | | DataPayloadCreator { [INFO] [stderr] ... | [INFO] [stderr] 315 | | } [INFO] [stderr] 316 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 278 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this lifetime isn't used in the function definition [INFO] [stderr] --> src/creator.rs:428:33 [INFO] [stderr] | [INFO] [stderr] 428 | pub fn set_mac_commands<'a, 'b>( [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::extra_unused_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stderr] [INFO] [stderr] warning: this lifetime isn't used in the function definition [INFO] [stderr] --> src/creator.rs:447:26 [INFO] [stderr] | [INFO] [stderr] 447 | pub fn can_piggyback<'a>(cmds: Vec<&maccommands::SerializableMacCommand>) -> bool { [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/creator.rs:506:9 [INFO] [stderr] | [INFO] [stderr] 506 | / let encrypted_payload; [INFO] [stderr] 507 | | if has_fport_zero { [INFO] [stderr] 508 | | payload_len = self.mac_commands_bytes.len(); [INFO] [stderr] 509 | | encrypted_payload = securityhelpers::encrypt_frm_data_payload( [INFO] [stderr] ... | [INFO] [stderr] 521 | | )?; [INFO] [stderr] 522 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] help: it is more idiomatic to write [INFO] [stderr] | [INFO] [stderr] 506 | let encrypted_payload = if has_fport_zero { ..; securityhelpers::encrypt_frm_data_payload( [INFO] [stderr] 507 | &self.data[..], [INFO] [stderr] 508 | &self.mac_commands_bytes[..], [INFO] [stderr] 509 | self.fcnt, [INFO] [stderr] 510 | nwk_skey, [INFO] [stderr] 511 | )? } else { securityhelpers::encrypt_frm_data_payload( [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/creator.rs:493:42 [INFO] [stderr] | [INFO] [stderr] 493 | if !self.encrypt_mac_commands && self.mac_commands_bytes.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!self.mac_commands_bytes.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `maccommandcreator::LinkCheckReqCreator` [INFO] [stderr] --> src/maccommandcreator.rs:15:13 [INFO] [stderr] | [INFO] [stderr] 15 | / pub fn new() -> Self { [INFO] [stderr] 16 | | Self {} [INFO] [stderr] 17 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] ... [INFO] [stderr] 78 | impl_mac_cmd_creator_boilerplate!(LinkCheckReqCreator, 0x02); [INFO] [stderr] | ------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 76 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `maccommandcreator::LinkCheckAnsCreator` [INFO] [stderr] --> src/maccommandcreator.rs:31:13 [INFO] [stderr] | [INFO] [stderr] 31 | / pub fn new() -> Self { [INFO] [stderr] 32 | | let mut data = [0; $len]; [INFO] [stderr] 33 | | data[0] = $cid; [INFO] [stderr] 34 | | Self { data: data } [INFO] [stderr] 35 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] ... [INFO] [stderr] 92 | impl_mac_cmd_creator_boilerplate!(LinkCheckAnsCreator, 0x02, 3); [INFO] [stderr] | ---------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 88 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `maccommandcreator::LinkADRReqCreator` [INFO] [stderr] --> src/maccommandcreator.rs:31:13 [INFO] [stderr] | [INFO] [stderr] 31 | / pub fn new() -> Self { [INFO] [stderr] 32 | | let mut data = [0; $len]; [INFO] [stderr] 33 | | data[0] = $cid; [INFO] [stderr] 34 | | Self { data: data } [INFO] [stderr] 35 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] ... [INFO] [stderr] 139 | impl_mac_cmd_creator_boilerplate!(LinkADRReqCreator, 0x03, 5); [INFO] [stderr] | -------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 135 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `maccommandcreator::LinkADRAnsCreator` [INFO] [stderr] --> src/maccommandcreator.rs:31:13 [INFO] [stderr] | [INFO] [stderr] 31 | / pub fn new() -> Self { [INFO] [stderr] 32 | | let mut data = [0; $len]; [INFO] [stderr] 33 | | data[0] = $cid; [INFO] [stderr] 34 | | Self { data: data } [INFO] [stderr] 35 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] ... [INFO] [stderr] 219 | impl_mac_cmd_creator_boilerplate!(LinkADRAnsCreator, 0x03, 2); [INFO] [stderr] | -------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 215 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `maccommandcreator::DutyCycleReqCreator` [INFO] [stderr] --> src/maccommandcreator.rs:31:13 [INFO] [stderr] | [INFO] [stderr] 31 | / pub fn new() -> Self { [INFO] [stderr] 32 | | let mut data = [0; $len]; [INFO] [stderr] 33 | | data[0] = $cid; [INFO] [stderr] 34 | | Self { data: data } [INFO] [stderr] 35 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] ... [INFO] [stderr] 271 | impl_mac_cmd_creator_boilerplate!(DutyCycleReqCreator, 0x04, 2); [INFO] [stderr] | ---------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 267 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `maccommandcreator::DutyCycleAnsCreator` [INFO] [stderr] --> src/maccommandcreator.rs:15:13 [INFO] [stderr] | [INFO] [stderr] 15 | / pub fn new() -> Self { [INFO] [stderr] 16 | | Self {} [INFO] [stderr] 17 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] ... [INFO] [stderr] 297 | impl_mac_cmd_creator_boilerplate!(DutyCycleAnsCreator, 0x04); [INFO] [stderr] | ------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 295 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `maccommandcreator::RXParamSetupReqCreator` [INFO] [stderr] --> src/maccommandcreator.rs:31:13 [INFO] [stderr] | [INFO] [stderr] 31 | / pub fn new() -> Self { [INFO] [stderr] 32 | | let mut data = [0; $len]; [INFO] [stderr] 33 | | data[0] = $cid; [INFO] [stderr] 34 | | Self { data: data } [INFO] [stderr] 35 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] ... [INFO] [stderr] 314 | impl_mac_cmd_creator_boilerplate!(RXParamSetupReqCreator, 0x05, 5); [INFO] [stderr] | ------------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 310 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `maccommandcreator::RXParamSetupAnsCreator` [INFO] [stderr] --> src/maccommandcreator.rs:31:13 [INFO] [stderr] | [INFO] [stderr] 31 | / pub fn new() -> Self { [INFO] [stderr] 32 | | let mut data = [0; $len]; [INFO] [stderr] 33 | | data[0] = $cid; [INFO] [stderr] 34 | | Self { data: data } [INFO] [stderr] 35 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] ... [INFO] [stderr] 366 | impl_mac_cmd_creator_boilerplate!(RXParamSetupAnsCreator, 0x05, 2); [INFO] [stderr] | ------------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 362 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `maccommandcreator::DevStatusReqCreator` [INFO] [stderr] --> src/maccommandcreator.rs:15:13 [INFO] [stderr] | [INFO] [stderr] 15 | / pub fn new() -> Self { [INFO] [stderr] 16 | | Self {} [INFO] [stderr] 17 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] ... [INFO] [stderr] 416 | impl_mac_cmd_creator_boilerplate!(DevStatusReqCreator, 0x06); [INFO] [stderr] | ------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 414 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `maccommandcreator::DevStatusAnsCreator` [INFO] [stderr] --> src/maccommandcreator.rs:31:13 [INFO] [stderr] | [INFO] [stderr] 31 | / pub fn new() -> Self { [INFO] [stderr] 32 | | let mut data = [0; $len]; [INFO] [stderr] 33 | | data[0] = $cid; [INFO] [stderr] 34 | | Self { data: data } [INFO] [stderr] 35 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] ... [INFO] [stderr] 430 | impl_mac_cmd_creator_boilerplate!(DevStatusAnsCreator, 0x06, 3); [INFO] [stderr] | ---------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 426 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `maccommandcreator::NewChannelReqCreator` [INFO] [stderr] --> src/maccommandcreator.rs:31:13 [INFO] [stderr] | [INFO] [stderr] 31 | / pub fn new() -> Self { [INFO] [stderr] 32 | | let mut data = [0; $len]; [INFO] [stderr] 33 | | data[0] = $cid; [INFO] [stderr] 34 | | Self { data: data } [INFO] [stderr] 35 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] ... [INFO] [stderr] 477 | impl_mac_cmd_creator_boilerplate!(NewChannelReqCreator, 0x07, 6); [INFO] [stderr] | ----------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 473 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `maccommandcreator::NewChannelAnsCreator` [INFO] [stderr] --> src/maccommandcreator.rs:31:13 [INFO] [stderr] | [INFO] [stderr] 31 | / pub fn new() -> Self { [INFO] [stderr] 32 | | let mut data = [0; $len]; [INFO] [stderr] 33 | | data[0] = $cid; [INFO] [stderr] 34 | | Self { data: data } [INFO] [stderr] 35 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] ... [INFO] [stderr] 538 | impl_mac_cmd_creator_boilerplate!(NewChannelAnsCreator, 0x07, 2); [INFO] [stderr] | ----------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 534 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `maccommandcreator::RXTimingSetupReqCreator` [INFO] [stderr] --> src/maccommandcreator.rs:31:13 [INFO] [stderr] | [INFO] [stderr] 31 | / pub fn new() -> Self { [INFO] [stderr] 32 | | let mut data = [0; $len]; [INFO] [stderr] 33 | | data[0] = $cid; [INFO] [stderr] 34 | | Self { data: data } [INFO] [stderr] 35 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] ... [INFO] [stderr] 578 | impl_mac_cmd_creator_boilerplate!(RXTimingSetupReqCreator, 0x08, 2); [INFO] [stderr] | -------------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 574 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `maccommandcreator::RXTimingSetupAnsCreator` [INFO] [stderr] --> src/maccommandcreator.rs:15:13 [INFO] [stderr] | [INFO] [stderr] 15 | / pub fn new() -> Self { [INFO] [stderr] 16 | | Self {} [INFO] [stderr] 17 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] ... [INFO] [stderr] 607 | impl_mac_cmd_creator_boilerplate!(RXTimingSetupAnsCreator, 0x08); [INFO] [stderr] | ----------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 605 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: item `maccommands::MacCommand<'a>` has a public `len` method but no corresponding `is_empty` method [INFO] [stderr] --> src/maccommands.rs:30:1 [INFO] [stderr] | [INFO] [stderr] 30 | / impl<'a> MacCommand<'a> { [INFO] [stderr] 31 | | pub fn len(&self) -> usize { [INFO] [stderr] 32 | | match *self { [INFO] [stderr] 33 | | MacCommand::LinkCheckReq(_) => LinkCheckReqPayload::len(), [INFO] [stderr] ... | [INFO] [stderr] 67 | | } [INFO] [stderr] 68 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_without_is_empty)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stderr] [INFO] [stderr] warning: methods called `new` usually return `Self` [INFO] [stderr] --> src/maccommands.rs:136:9 [INFO] [stderr] | [INFO] [stderr] 136 | / pub fn new<'a>(_: &'a [u8]) -> Result<(MacCommand<'a>, usize), String> { [INFO] [stderr] 137 | | Ok((MacCommand::$name($type()), 0)) [INFO] [stderr] 138 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] ... [INFO] [stderr] 252 | new_mac_cmd_helper!(LinkCheckReq, LinkCheckReqPayload, 0); [INFO] [stderr] | ---------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_ret_no_self)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_ret_no_self [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/maccommands.rs:136:9 [INFO] [stderr] | [INFO] [stderr] 136 | / pub fn new<'a>(_: &'a [u8]) -> Result<(MacCommand<'a>, usize), String> { [INFO] [stderr] 137 | | Ok((MacCommand::$name($type()), 0)) [INFO] [stderr] 138 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] ... [INFO] [stderr] 252 | new_mac_cmd_helper!(LinkCheckReq, LinkCheckReqPayload, 0); [INFO] [stderr] | ---------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: methods called `new` usually return `Self` [INFO] [stderr] --> src/maccommands.rs:141:9 [INFO] [stderr] | [INFO] [stderr] 141 | / pub fn new<'b>(data: &'b [u8]) -> Result<(MacCommand<'b>, usize), String> { [INFO] [stderr] 142 | | if let Err(err) = Self::can_build_from(data) { [INFO] [stderr] 143 | | return Err(err); [INFO] [stderr] 144 | | } [INFO] [stderr] 145 | | let payload = array_ref![&data[..$len], 0, $len]; [INFO] [stderr] 146 | | Ok((MacCommand::$name($type(payload)), $len)) [INFO] [stderr] 147 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] ... [INFO] [stderr] 273 | new_mac_cmd_helper!(LinkCheckAns, LinkCheckAnsPayload, 2); [INFO] [stderr] | ---------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_ret_no_self [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/maccommands.rs:141:9 [INFO] [stderr] | [INFO] [stderr] 141 | / pub fn new<'b>(data: &'b [u8]) -> Result<(MacCommand<'b>, usize), String> { [INFO] [stderr] 142 | | if let Err(err) = Self::can_build_from(data) { [INFO] [stderr] 143 | | return Err(err); [INFO] [stderr] 144 | | } [INFO] [stderr] 145 | | let payload = array_ref![&data[..$len], 0, $len]; [INFO] [stderr] 146 | | Ok((MacCommand::$name($type(payload)), $len)) [INFO] [stderr] 147 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] ... [INFO] [stderr] 273 | new_mac_cmd_helper!(LinkCheckAns, LinkCheckAnsPayload, 2); [INFO] [stderr] | ---------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: methods called `new` usually return `Self` [INFO] [stderr] --> src/maccommands.rs:141:9 [INFO] [stderr] | [INFO] [stderr] 141 | / pub fn new<'b>(data: &'b [u8]) -> Result<(MacCommand<'b>, usize), String> { [INFO] [stderr] 142 | | if let Err(err) = Self::can_build_from(data) { [INFO] [stderr] 143 | | return Err(err); [INFO] [stderr] 144 | | } [INFO] [stderr] 145 | | let payload = array_ref![&data[..$len], 0, $len]; [INFO] [stderr] 146 | | Ok((MacCommand::$name($type(payload)), $len)) [INFO] [stderr] 147 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] ... [INFO] [stderr] 306 | new_mac_cmd_helper!(LinkADRReq, LinkADRReqPayload, 4); [INFO] [stderr] | ------------------------------------------------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_ret_no_self [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/maccommands.rs:141:9 [INFO] [stderr] | [INFO] [stderr] 141 | / pub fn new<'b>(data: &'b [u8]) -> Result<(MacCommand<'b>, usize), String> { [INFO] [stderr] 142 | | if let Err(err) = Self::can_build_from(data) { [INFO] [stderr] 143 | | return Err(err); [INFO] [stderr] 144 | | } [INFO] [stderr] 145 | | let payload = array_ref![&data[..$len], 0, $len]; [INFO] [stderr] 146 | | Ok((MacCommand::$name($type(payload)), $len)) [INFO] [stderr] 147 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] ... [INFO] [stderr] 306 | new_mac_cmd_helper!(LinkADRReq, LinkADRReqPayload, 4); [INFO] [stderr] | ------------------------------------------------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: methods called `new` usually return `Self` [INFO] [stderr] --> src/maccommands.rs:141:9 [INFO] [stderr] | [INFO] [stderr] 141 | / pub fn new<'b>(data: &'b [u8]) -> Result<(MacCommand<'b>, usize), String> { [INFO] [stderr] 142 | | if let Err(err) = Self::can_build_from(data) { [INFO] [stderr] 143 | | return Err(err); [INFO] [stderr] 144 | | } [INFO] [stderr] 145 | | let payload = array_ref![&data[..$len], 0, $len]; [INFO] [stderr] 146 | | Ok((MacCommand::$name($type(payload)), $len)) [INFO] [stderr] 147 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] ... [INFO] [stderr] 432 | new_mac_cmd_helper!(LinkADRAns, LinkADRAnsPayload, 1); [INFO] [stderr] | ------------------------------------------------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_ret_no_self [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/maccommands.rs:141:9 [INFO] [stderr] | [INFO] [stderr] 141 | / pub fn new<'b>(data: &'b [u8]) -> Result<(MacCommand<'b>, usize), String> { [INFO] [stderr] 142 | | if let Err(err) = Self::can_build_from(data) { [INFO] [stderr] 143 | | return Err(err); [INFO] [stderr] 144 | | } [INFO] [stderr] 145 | | let payload = array_ref![&data[..$len], 0, $len]; [INFO] [stderr] 146 | | Ok((MacCommand::$name($type(payload)), $len)) [INFO] [stderr] 147 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] ... [INFO] [stderr] 432 | new_mac_cmd_helper!(LinkADRAns, LinkADRAnsPayload, 1); [INFO] [stderr] | ------------------------------------------------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/maccommands.rs:432:5 [INFO] [stderr] | [INFO] [stderr] 432 | new_mac_cmd_helper!(LinkADRAns, LinkADRAnsPayload, 1); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: methods called `new` usually return `Self` [INFO] [stderr] --> src/maccommands.rs:141:9 [INFO] [stderr] | [INFO] [stderr] 141 | / pub fn new<'b>(data: &'b [u8]) -> Result<(MacCommand<'b>, usize), String> { [INFO] [stderr] 142 | | if let Err(err) = Self::can_build_from(data) { [INFO] [stderr] 143 | | return Err(err); [INFO] [stderr] 144 | | } [INFO] [stderr] 145 | | let payload = array_ref![&data[..$len], 0, $len]; [INFO] [stderr] 146 | | Ok((MacCommand::$name($type(payload)), $len)) [INFO] [stderr] 147 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] ... [INFO] [stderr] 467 | new_mac_cmd_helper!(DutyCycleReq, DutyCycleReqPayload, 1); [INFO] [stderr] | ---------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_ret_no_self [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/maccommands.rs:141:9 [INFO] [stderr] | [INFO] [stderr] 141 | / pub fn new<'b>(data: &'b [u8]) -> Result<(MacCommand<'b>, usize), String> { [INFO] [stderr] 142 | | if let Err(err) = Self::can_build_from(data) { [INFO] [stderr] 143 | | return Err(err); [INFO] [stderr] 144 | | } [INFO] [stderr] 145 | | let payload = array_ref![&data[..$len], 0, $len]; [INFO] [stderr] 146 | | Ok((MacCommand::$name($type(payload)), $len)) [INFO] [stderr] 147 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] ... [INFO] [stderr] 467 | new_mac_cmd_helper!(DutyCycleReq, DutyCycleReqPayload, 1); [INFO] [stderr] | ---------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/maccommands.rs:467:5 [INFO] [stderr] | [INFO] [stderr] 467 | new_mac_cmd_helper!(DutyCycleReq, DutyCycleReqPayload, 1); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: methods called `new` usually return `Self` [INFO] [stderr] --> src/maccommands.rs:136:9 [INFO] [stderr] | [INFO] [stderr] 136 | / pub fn new<'a>(_: &'a [u8]) -> Result<(MacCommand<'a>, usize), String> { [INFO] [stderr] 137 | | Ok((MacCommand::$name($type()), 0)) [INFO] [stderr] 138 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] ... [INFO] [stderr] 499 | new_mac_cmd_helper!(DutyCycleAns, DutyCycleAnsPayload, 0); [INFO] [stderr] | ---------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_ret_no_self [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/maccommands.rs:136:9 [INFO] [stderr] | [INFO] [stderr] 136 | / pub fn new<'a>(_: &'a [u8]) -> Result<(MacCommand<'a>, usize), String> { [INFO] [stderr] 137 | | Ok((MacCommand::$name($type()), 0)) [INFO] [stderr] 138 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] ... [INFO] [stderr] 499 | new_mac_cmd_helper!(DutyCycleAns, DutyCycleAnsPayload, 0); [INFO] [stderr] | ---------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: methods called `new` usually return `Self` [INFO] [stderr] --> src/maccommands.rs:141:9 [INFO] [stderr] | [INFO] [stderr] 141 | / pub fn new<'b>(data: &'b [u8]) -> Result<(MacCommand<'b>, usize), String> { [INFO] [stderr] 142 | | if let Err(err) = Self::can_build_from(data) { [INFO] [stderr] 143 | | return Err(err); [INFO] [stderr] 144 | | } [INFO] [stderr] 145 | | let payload = array_ref![&data[..$len], 0, $len]; [INFO] [stderr] 146 | | Ok((MacCommand::$name($type(payload)), $len)) [INFO] [stderr] 147 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] ... [INFO] [stderr] 520 | new_mac_cmd_helper!(RXParamSetupReq, RXParamSetupReqPayload, 4); [INFO] [stderr] | ---------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_ret_no_self [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/maccommands.rs:141:9 [INFO] [stderr] | [INFO] [stderr] 141 | / pub fn new<'b>(data: &'b [u8]) -> Result<(MacCommand<'b>, usize), String> { [INFO] [stderr] 142 | | if let Err(err) = Self::can_build_from(data) { [INFO] [stderr] 143 | | return Err(err); [INFO] [stderr] 144 | | } [INFO] [stderr] 145 | | let payload = array_ref![&data[..$len], 0, $len]; [INFO] [stderr] 146 | | Ok((MacCommand::$name($type(payload)), $len)) [INFO] [stderr] 147 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] ... [INFO] [stderr] 520 | new_mac_cmd_helper!(RXParamSetupReq, RXParamSetupReqPayload, 4); [INFO] [stderr] | ---------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/maccommands.rs:590:11 [INFO] [stderr] | [INFO] [stderr] 590 | (((self.0[2] as u32) << 16) + ((self.0[1] as u32) << 8) + (self.0[0] as u32)) * 100 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `u32::from(self.0[2])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/maccommands.rs:590:40 [INFO] [stderr] | [INFO] [stderr] 590 | (((self.0[2] as u32) << 16) + ((self.0[1] as u32) << 8) + (self.0[0] as u32)) * 100 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `u32::from(self.0[1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/maccommands.rs:590:67 [INFO] [stderr] | [INFO] [stderr] 590 | (((self.0[2] as u32) << 16) + ((self.0[1] as u32) << 8) + (self.0[0] as u32)) * 100 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `u32::from(self.0[0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: methods called `new` usually return `Self` [INFO] [stderr] --> src/maccommands.rs:141:9 [INFO] [stderr] | [INFO] [stderr] 141 | / pub fn new<'b>(data: &'b [u8]) -> Result<(MacCommand<'b>, usize), String> { [INFO] [stderr] 142 | | if let Err(err) = Self::can_build_from(data) { [INFO] [stderr] 143 | | return Err(err); [INFO] [stderr] 144 | | } [INFO] [stderr] 145 | | let payload = array_ref![&data[..$len], 0, $len]; [INFO] [stderr] 146 | | Ok((MacCommand::$name($type(payload)), $len)) [INFO] [stderr] 147 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] ... [INFO] [stderr] 624 | new_mac_cmd_helper!(RXParamSetupAns, RXParamSetupAnsPayload, 1); [INFO] [stderr] | ---------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_ret_no_self [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/maccommands.rs:141:9 [INFO] [stderr] | [INFO] [stderr] 141 | / pub fn new<'b>(data: &'b [u8]) -> Result<(MacCommand<'b>, usize), String> { [INFO] [stderr] 142 | | if let Err(err) = Self::can_build_from(data) { [INFO] [stderr] 143 | | return Err(err); [INFO] [stderr] 144 | | } [INFO] [stderr] 145 | | let payload = array_ref![&data[..$len], 0, $len]; [INFO] [stderr] 146 | | Ok((MacCommand::$name($type(payload)), $len)) [INFO] [stderr] 147 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] ... [INFO] [stderr] 624 | new_mac_cmd_helper!(RXParamSetupAns, RXParamSetupAnsPayload, 1); [INFO] [stderr] | ---------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/maccommands.rs:624:5 [INFO] [stderr] | [INFO] [stderr] 624 | new_mac_cmd_helper!(RXParamSetupAns, RXParamSetupAnsPayload, 1); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: methods called `new` usually return `Self` [INFO] [stderr] --> src/maccommands.rs:136:9 [INFO] [stderr] | [INFO] [stderr] 136 | / pub fn new<'a>(_: &'a [u8]) -> Result<(MacCommand<'a>, usize), String> { [INFO] [stderr] 137 | | Ok((MacCommand::$name($type()), 0)) [INFO] [stderr] 138 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] ... [INFO] [stderr] 659 | new_mac_cmd_helper!(DevStatusReq, DevStatusReqPayload, 0); [INFO] [stderr] | ---------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_ret_no_self [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/maccommands.rs:136:9 [INFO] [stderr] | [INFO] [stderr] 136 | / pub fn new<'a>(_: &'a [u8]) -> Result<(MacCommand<'a>, usize), String> { [INFO] [stderr] 137 | | Ok((MacCommand::$name($type()), 0)) [INFO] [stderr] 138 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] ... [INFO] [stderr] 659 | new_mac_cmd_helper!(DevStatusReq, DevStatusReqPayload, 0); [INFO] [stderr] | ---------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: methods called `new` usually return `Self` [INFO] [stderr] --> src/maccommands.rs:141:9 [INFO] [stderr] | [INFO] [stderr] 141 | / pub fn new<'b>(data: &'b [u8]) -> Result<(MacCommand<'b>, usize), String> { [INFO] [stderr] 142 | | if let Err(err) = Self::can_build_from(data) { [INFO] [stderr] 143 | | return Err(err); [INFO] [stderr] 144 | | } [INFO] [stderr] 145 | | let payload = array_ref![&data[..$len], 0, $len]; [INFO] [stderr] 146 | | Ok((MacCommand::$name($type(payload)), $len)) [INFO] [stderr] 147 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] ... [INFO] [stderr] 680 | new_mac_cmd_helper!(DevStatusAns, DevStatusAnsPayload, 2); [INFO] [stderr] | ---------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_ret_no_self [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/maccommands.rs:141:9 [INFO] [stderr] | [INFO] [stderr] 141 | / pub fn new<'b>(data: &'b [u8]) -> Result<(MacCommand<'b>, usize), String> { [INFO] [stderr] 142 | | if let Err(err) = Self::can_build_from(data) { [INFO] [stderr] 143 | | return Err(err); [INFO] [stderr] 144 | | } [INFO] [stderr] 145 | | let payload = array_ref![&data[..$len], 0, $len]; [INFO] [stderr] 146 | | Ok((MacCommand::$name($type(payload)), $len)) [INFO] [stderr] 147 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] ... [INFO] [stderr] 680 | new_mac_cmd_helper!(DevStatusAns, DevStatusAnsPayload, 2); [INFO] [stderr] | ---------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: methods called `new` usually return `Self` [INFO] [stderr] --> src/maccommands.rs:141:9 [INFO] [stderr] | [INFO] [stderr] 141 | / pub fn new<'b>(data: &'b [u8]) -> Result<(MacCommand<'b>, usize), String> { [INFO] [stderr] 142 | | if let Err(err) = Self::can_build_from(data) { [INFO] [stderr] 143 | | return Err(err); [INFO] [stderr] 144 | | } [INFO] [stderr] 145 | | let payload = array_ref![&data[..$len], 0, $len]; [INFO] [stderr] 146 | | Ok((MacCommand::$name($type(payload)), $len)) [INFO] [stderr] 147 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] ... [INFO] [stderr] 720 | new_mac_cmd_helper!(NewChannelReq, NewChannelReqPayload, 5); [INFO] [stderr] | ------------------------------------------------------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_ret_no_self [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/maccommands.rs:141:9 [INFO] [stderr] | [INFO] [stderr] 141 | / pub fn new<'b>(data: &'b [u8]) -> Result<(MacCommand<'b>, usize), String> { [INFO] [stderr] 142 | | if let Err(err) = Self::can_build_from(data) { [INFO] [stderr] 143 | | return Err(err); [INFO] [stderr] 144 | | } [INFO] [stderr] 145 | | let payload = array_ref![&data[..$len], 0, $len]; [INFO] [stderr] 146 | | Ok((MacCommand::$name($type(payload)), $len)) [INFO] [stderr] 147 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] ... [INFO] [stderr] 720 | new_mac_cmd_helper!(NewChannelReq, NewChannelReqPayload, 5); [INFO] [stderr] | ------------------------------------------------------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: methods called `new` usually return `Self` [INFO] [stderr] --> src/maccommands.rs:141:9 [INFO] [stderr] | [INFO] [stderr] 141 | / pub fn new<'b>(data: &'b [u8]) -> Result<(MacCommand<'b>, usize), String> { [INFO] [stderr] 142 | | if let Err(err) = Self::can_build_from(data) { [INFO] [stderr] 143 | | return Err(err); [INFO] [stderr] 144 | | } [INFO] [stderr] 145 | | let payload = array_ref![&data[..$len], 0, $len]; [INFO] [stderr] 146 | | Ok((MacCommand::$name($type(payload)), $len)) [INFO] [stderr] 147 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] ... [INFO] [stderr] 805 | new_mac_cmd_helper!(NewChannelAns, NewChannelAnsPayload, 1); [INFO] [stderr] | ------------------------------------------------------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_ret_no_self [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/maccommands.rs:141:9 [INFO] [stderr] | [INFO] [stderr] 141 | / pub fn new<'b>(data: &'b [u8]) -> Result<(MacCommand<'b>, usize), String> { [INFO] [stderr] 142 | | if let Err(err) = Self::can_build_from(data) { [INFO] [stderr] 143 | | return Err(err); [INFO] [stderr] 144 | | } [INFO] [stderr] 145 | | let payload = array_ref![&data[..$len], 0, $len]; [INFO] [stderr] 146 | | Ok((MacCommand::$name($type(payload)), $len)) [INFO] [stderr] 147 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] ... [INFO] [stderr] 805 | new_mac_cmd_helper!(NewChannelAns, NewChannelAnsPayload, 1); [INFO] [stderr] | ------------------------------------------------------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/maccommands.rs:805:5 [INFO] [stderr] | [INFO] [stderr] 805 | new_mac_cmd_helper!(NewChannelAns, NewChannelAnsPayload, 1); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: methods called `new` usually return `Self` [INFO] [stderr] --> src/maccommands.rs:141:9 [INFO] [stderr] | [INFO] [stderr] 141 | / pub fn new<'b>(data: &'b [u8]) -> Result<(MacCommand<'b>, usize), String> { [INFO] [stderr] 142 | | if let Err(err) = Self::can_build_from(data) { [INFO] [stderr] 143 | | return Err(err); [INFO] [stderr] 144 | | } [INFO] [stderr] 145 | | let payload = array_ref![&data[..$len], 0, $len]; [INFO] [stderr] 146 | | Ok((MacCommand::$name($type(payload)), $len)) [INFO] [stderr] 147 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] ... [INFO] [stderr] 837 | new_mac_cmd_helper!(RXTimingSetupReq, RXTimingSetupReqPayload, 1); [INFO] [stderr] | ------------------------------------------------------------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_ret_no_self [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/maccommands.rs:141:9 [INFO] [stderr] | [INFO] [stderr] 141 | / pub fn new<'b>(data: &'b [u8]) -> Result<(MacCommand<'b>, usize), String> { [INFO] [stderr] 142 | | if let Err(err) = Self::can_build_from(data) { [INFO] [stderr] 143 | | return Err(err); [INFO] [stderr] 144 | | } [INFO] [stderr] 145 | | let payload = array_ref![&data[..$len], 0, $len]; [INFO] [stderr] 146 | | Ok((MacCommand::$name($type(payload)), $len)) [INFO] [stderr] 147 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] ... [INFO] [stderr] 837 | new_mac_cmd_helper!(RXTimingSetupReq, RXTimingSetupReqPayload, 1); [INFO] [stderr] | ------------------------------------------------------------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/maccommands.rs:837:5 [INFO] [stderr] | [INFO] [stderr] 837 | new_mac_cmd_helper!(RXTimingSetupReq, RXTimingSetupReqPayload, 1); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: methods called `new` usually return `Self` [INFO] [stderr] --> src/maccommands.rs:136:9 [INFO] [stderr] | [INFO] [stderr] 136 | / pub fn new<'a>(_: &'a [u8]) -> Result<(MacCommand<'a>, usize), String> { [INFO] [stderr] 137 | | Ok((MacCommand::$name($type()), 0)) [INFO] [stderr] 138 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] ... [INFO] [stderr] 863 | new_mac_cmd_helper!(RXTimingSetupAns, RXTimingSetupAnsPayload, 0); [INFO] [stderr] | ------------------------------------------------------------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_ret_no_self [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/maccommands.rs:136:9 [INFO] [stderr] | [INFO] [stderr] 136 | / pub fn new<'a>(_: &'a [u8]) -> Result<(MacCommand<'a>, usize), String> { [INFO] [stderr] 137 | | Ok((MacCommand::$name($type()), 0)) [INFO] [stderr] 138 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] ... [INFO] [stderr] 863 | new_mac_cmd_helper!(RXTimingSetupAns, RXTimingSetupAnsPayload, 0); [INFO] [stderr] | ------------------------------------------------------------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: it looks like you're manually copying between slices [INFO] [stderr] --> src/parser.rs:100:22 [INFO] [stderr] | [INFO] [stderr] 100 | for j in 0..16 { [INFO] [stderr] | ^^^^^ help: try replacing the loop by: `bytes[start..(16 + start)].clone_from_slice(&tmp[..16])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_memcpy [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/parser.rs:226:32 [INFO] [stderr] | [INFO] [stderr] 226 | ((old_fcnt >> 16) << 16) ^ (fcnt as u32) [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u32::from(fcnt)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: bit mask could be simplified with a call to `trailing_zeros` [INFO] [stderr] --> src/parser.rs:254:12 [INFO] [stderr] | [INFO] [stderr] 254 | if self.0 & 3 == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `self.0.trailing_zeros() >= 2` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::verbose_bit_mask)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#verbose_bit_mask [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/parser.rs:297:1 [INFO] [stderr] | [INFO] [stderr] 297 | / fn fhdr_length<'a>(bytes: &'a [u8], uplink: bool) -> usize { [INFO] [stderr] 298 | | 7 + FCtrl(bytes[4], uplink).f_opts_len() as usize [INFO] [stderr] 299 | | } [INFO] [stderr] | |_^ [INFO] [stderr] warning: the loop variable `i` is only used to index `data`. [INFO] [stderr] --> src/cmac.rs:83:14 [INFO] [stderr] | [INFO] [stderr] 83 | for i in (len + 1)..block_size { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 83 | for in data.iter_mut().take(block_size).skip((len + 1)) { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/cmac.rs:97:23 [INFO] [stderr] | [INFO] [stderr] 97 | let n_blocks = if data.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `data.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/cmac.rs:123:12 [INFO] [stderr] | [INFO] [stderr] 123 | if data.len() != 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!data.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `creator::JoinAcceptCreator` [INFO] [stderr] --> src/creator.rs:45:5 [INFO] [stderr] | [INFO] [stderr] 45 | / pub fn new() -> JoinAcceptCreator { [INFO] [stderr] 46 | | let mut data = vec![0; 17]; [INFO] [stderr] 47 | | data[0] = 0x20; [INFO] [stderr] 48 | | JoinAcceptCreator { [INFO] [stderr] ... | [INFO] [stderr] 51 | | } [INFO] [stderr] 52 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 22 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: the loop variable `j` is used to index `tmp` [INFO] [stderr] --> src/creator.rs:176:22 [INFO] [stderr] | [INFO] [stderr] 176 | for j in 0..16 { [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 176 | for (j, ) in tmp.iter().enumerate().take(16) { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: it looks like you're manually copying between slices [INFO] [stderr] --> src/creator.rs:176:22 [INFO] [stderr] | [INFO] [stderr] 176 | for j in 0..16 { [INFO] [stderr] | ^^^^^ help: try replacing the loop by: `self.data[start..(16 + start)].clone_from_slice(&tmp[..16])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::manual_memcpy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_memcpy [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `creator::JoinRequestCreator` [INFO] [stderr] --> src/creator.rs:210:5 [INFO] [stderr] | [INFO] [stderr] 210 | / pub fn new() -> JoinRequestCreator { [INFO] [stderr] 211 | | let mut data = vec![0; 23]; [INFO] [stderr] 212 | | data[0] = 0x00; [INFO] [stderr] 213 | | JoinRequestCreator { data: data } [INFO] [stderr] 214 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 193 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `creator::DataPayloadCreator` [INFO] [stderr] --> src/creator.rs:306:5 [INFO] [stderr] | [INFO] [stderr] 306 | / pub fn new() -> DataPayloadCreator { [INFO] [stderr] 307 | | let mut data = vec![0; 12]; [INFO] [stderr] 308 | | data[0] = 0x40; [INFO] [stderr] 309 | | DataPayloadCreator { [INFO] [stderr] ... | [INFO] [stderr] 315 | | } [INFO] [stderr] 316 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 278 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this lifetime isn't used in the function definition [INFO] [stderr] --> src/creator.rs:428:33 [INFO] [stderr] | [INFO] [stderr] 428 | pub fn set_mac_commands<'a, 'b>( [INFO] [stderr] | ^^ [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/parser.rs:540:23 [INFO] [stderr] | [INFO] [stderr] 540 | pub fn new(bytes: &[u8; 4]) -> DevAddr { [INFO] [stderr] | ^^^^^^^^ help: consider passing by value instead: `[u8; 4]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::extra_unused_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stderr] [INFO] [stderr] warning: this lifetime isn't used in the function definition [INFO] [stderr] --> src/creator.rs:447:26 [INFO] [stderr] | [INFO] [stderr] 447 | pub fn can_piggyback<'a>(cmds: Vec<&maccommands::SerializableMacCommand>) -> bool { [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/creator.rs:506:9 [INFO] [stderr] | [INFO] [stderr] 506 | / let encrypted_payload; [INFO] [stderr] 507 | | if has_fport_zero { [INFO] [stderr] 508 | | payload_len = self.mac_commands_bytes.len(); [INFO] [stderr] 509 | | encrypted_payload = securityhelpers::encrypt_frm_data_payload( [INFO] [stderr] ... | [INFO] [stderr] 521 | | )?; [INFO] [stderr] 522 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/parser.rs:606:20 [INFO] [stderr] | [INFO] [stderr] 606 | let res = ((self.0[6] as u16) << 8) | (self.0[5] as u16); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `u16::from(self.0[6])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/parser.rs:606:47 [INFO] [stderr] | [INFO] [stderr] 606 | let res = ((self.0[6] as u16) << 8) | (self.0[5] as u16); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `u16::from(self.0[5])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] help: it is more idiomatic to write [INFO] [stderr] | [INFO] [stderr] 506 | let encrypted_payload = if has_fport_zero { ..; securityhelpers::encrypt_frm_data_payload( [INFO] [stderr] 507 | &self.data[..], [INFO] [stderr] 508 | &self.mac_commands_bytes[..], [INFO] [stderr] 509 | self.fcnt, [INFO] [stderr] 510 | nwk_skey, [INFO] [stderr] 511 | )? } else { securityhelpers::encrypt_frm_data_payload( [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/creator.rs:493:42 [INFO] [stderr] | [INFO] [stderr] 493 | if !self.encrypt_mac_commands && self.mac_commands_bytes.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!self.mac_commands_bytes.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] error: incompatible bit mask: `_ & 64` can never be equal to `1` [INFO] [stderr] --> src/parser.rs:630:19 [INFO] [stderr] | [INFO] [stderr] 630 | self.1 && self.0 & (1 << 6) == 1 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `maccommandcreator::LinkCheckReqCreator` [INFO] [stderr] --> src/maccommandcreator.rs:15:13 [INFO] [stderr] | [INFO] [stderr] 15 | / pub fn new() -> Self { [INFO] [stderr] 16 | | Self {} [INFO] [stderr] 17 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] ... [INFO] [stderr] 78 | impl_mac_cmd_creator_boilerplate!(LinkCheckReqCreator, 0x02); [INFO] [stderr] | ------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::bad_bit_mask)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bad_bit_mask [INFO] [stderr] [INFO] [stderr] error: incompatible bit mask: `_ & 32` can never be equal to `1` [INFO] [stderr] --> src/parser.rs:634:9 [INFO] [stderr] | [INFO] [stderr] 634 | self.0 & (1 << 5) == 1 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bad_bit_mask [INFO] [stderr] [INFO] [stderr] error: incompatible bit mask: `_ & 16` can never be equal to `1` [INFO] [stderr] --> src/parser.rs:638:20 [INFO] [stderr] | [INFO] [stderr] 638 | !self.1 && self.0 & (1 << 4) == 1 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bad_bit_mask [INFO] [stderr] [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 76 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `maccommandcreator::LinkCheckAnsCreator` [INFO] [stderr] --> src/maccommandcreator.rs:31:13 [INFO] [stderr] | [INFO] [stderr] 31 | / pub fn new() -> Self { [INFO] [stderr] 32 | | let mut data = [0; $len]; [INFO] [stderr] 33 | | data[0] = $cid; [INFO] [stderr] 34 | | Self { data: data } [INFO] [stderr] 35 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] ... [INFO] [stderr] 92 | impl_mac_cmd_creator_boilerplate!(LinkCheckAnsCreator, 0x02, 3); [INFO] [stderr] | ---------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 88 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `maccommandcreator::LinkADRReqCreator` [INFO] [stderr] --> src/maccommandcreator.rs:31:13 [INFO] [stderr] | [INFO] [stderr] 31 | / pub fn new() -> Self { [INFO] [stderr] 32 | | let mut data = [0; $len]; [INFO] [stderr] 33 | | data[0] = $cid; [INFO] [stderr] 34 | | Self { data: data } [INFO] [stderr] 35 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] ... [INFO] [stderr] 139 | impl_mac_cmd_creator_boilerplate!(LinkADRReqCreator, 0x03, 5); [INFO] [stderr] | -------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 135 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `maccommandcreator::LinkADRAnsCreator` [INFO] [stderr] --> src/maccommandcreator.rs:31:13 [INFO] [stderr] | [INFO] [stderr] 31 | / pub fn new() -> Self { [INFO] [stderr] 32 | | let mut data = [0; $len]; [INFO] [stderr] 33 | | data[0] = $cid; [INFO] [stderr] 34 | | Self { data: data } [INFO] [stderr] 35 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] ... [INFO] [stderr] 219 | impl_mac_cmd_creator_boilerplate!(LinkADRAnsCreator, 0x03, 2); [INFO] [stderr] | -------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 215 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `maccommandcreator::DutyCycleReqCreator` [INFO] [stderr] --> src/maccommandcreator.rs:31:13 [INFO] [stderr] | [INFO] [stderr] 31 | / pub fn new() -> Self { [INFO] [stderr] 32 | | let mut data = [0; $len]; [INFO] [stderr] 33 | | data[0] = $cid; [INFO] [stderr] 34 | | Self { data: data } [INFO] [stderr] 35 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] ... [INFO] [stderr] 271 | impl_mac_cmd_creator_boilerplate!(DutyCycleReqCreator, 0x04, 2); [INFO] [stderr] | ---------------------------------------------------------------- in this macro invocation [INFO] [stderr] error: aborting due to 3 previous errors [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 267 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `maccommandcreator::DutyCycleAnsCreator` [INFO] [stderr] --> src/maccommandcreator.rs:15:13 [INFO] [stderr] | [INFO] [stderr] 15 | / pub fn new() -> Self { [INFO] [stderr] 16 | | Self {} [INFO] [stderr] 17 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] ... [INFO] [stderr] 297 | impl_mac_cmd_creator_boilerplate!(DutyCycleAnsCreator, 0x04); [INFO] [stderr] | ------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 295 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `maccommandcreator::RXParamSetupReqCreator` [INFO] [stderr] --> src/maccommandcreator.rs:31:13 [INFO] [stderr] | [INFO] [stderr] 31 | / pub fn new() -> Self { [INFO] [stderr] 32 | | let mut data = [0; $len]; [INFO] [stderr] 33 | | data[0] = $cid; [INFO] [stderr] 34 | | Self { data: data } [INFO] [stderr] 35 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] ... [INFO] [stderr] 314 | impl_mac_cmd_creator_boilerplate!(RXParamSetupReqCreator, 0x05, 5); [INFO] [stderr] | ------------------------------------------------------------------- in this macro invocation [INFO] [stderr] [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 310 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `maccommandcreator::RXParamSetupAnsCreator` [INFO] [stderr] --> src/maccommandcreator.rs:31:13 [INFO] [stderr] | [INFO] [stderr] 31 | / pub fn new() -> Self { [INFO] [stderr] 32 | | let mut data = [0; $len]; [INFO] [stderr] 33 | | data[0] = $cid; [INFO] [stderr] 34 | | Self { data: data } [INFO] [stderr] 35 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] ... [INFO] [stderr] 366 | impl_mac_cmd_creator_boilerplate!(RXParamSetupAnsCreator, 0x05, 2); [INFO] [stderr] | ------------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 362 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `maccommandcreator::DevStatusReqCreator` [INFO] [stderr] --> src/maccommandcreator.rs:15:13 [INFO] [stderr] | [INFO] [stderr] 15 | / pub fn new() -> Self { [INFO] [stderr] 16 | | Self {} [INFO] [stderr] 17 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] ... [INFO] [stderr] 416 | impl_mac_cmd_creator_boilerplate!(DevStatusReqCreator, 0x06); [INFO] [stderr] | ------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 414 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `maccommandcreator::DevStatusAnsCreator` [INFO] [stderr] --> src/maccommandcreator.rs:31:13 [INFO] [stderr] | [INFO] [stderr] 31 | / pub fn new() -> Self { [INFO] [stderr] 32 | | let mut data = [0; $len]; [INFO] [stderr] 33 | | data[0] = $cid; [INFO] [stderr] 34 | | Self { data: data } [INFO] [stderr] 35 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] ... [INFO] [stderr] 430 | impl_mac_cmd_creator_boilerplate!(DevStatusAnsCreator, 0x06, 3); [INFO] [stderr] | ---------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 426 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `maccommandcreator::NewChannelReqCreator` [INFO] [stderr] --> src/maccommandcreator.rs:31:13 [INFO] [stderr] | [INFO] [stderr] 31 | / pub fn new() -> Self { [INFO] [stderr] 32 | | let mut data = [0; $len]; [INFO] [stderr] 33 | | data[0] = $cid; [INFO] [stderr] 34 | | Self { data: data } [INFO] [stderr] 35 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] ... [INFO] [stderr] 477 | impl_mac_cmd_creator_boilerplate!(NewChannelReqCreator, 0x07, 6); [INFO] [stderr] | ----------------------------------------------------------------- in this macro invocation [INFO] [stderr] error: Could not compile `lorawan`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 473 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `maccommandcreator::NewChannelAnsCreator` [INFO] [stderr] --> src/maccommandcreator.rs:31:13 [INFO] [stderr] | [INFO] [stderr] 31 | / pub fn new() -> Self { [INFO] [stderr] 32 | | let mut data = [0; $len]; [INFO] [stderr] 33 | | data[0] = $cid; [INFO] [stderr] 34 | | Self { data: data } [INFO] [stderr] 35 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] ... [INFO] [stderr] 538 | impl_mac_cmd_creator_boilerplate!(NewChannelAnsCreator, 0x07, 2); [INFO] [stderr] | ----------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 534 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `maccommandcreator::RXTimingSetupReqCreator` [INFO] [stderr] --> src/maccommandcreator.rs:31:13 [INFO] [stderr] | [INFO] [stderr] 31 | / pub fn new() -> Self { [INFO] [stderr] 32 | | let mut data = [0; $len]; [INFO] [stderr] 33 | | data[0] = $cid; [INFO] [stderr] 34 | | Self { data: data } [INFO] [stderr] 35 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] ... [INFO] [stderr] 578 | impl_mac_cmd_creator_boilerplate!(RXTimingSetupReqCreator, 0x08, 2); [INFO] [stderr] | -------------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 574 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `maccommandcreator::RXTimingSetupAnsCreator` [INFO] [stderr] --> src/maccommandcreator.rs:15:13 [INFO] [stderr] | [INFO] [stderr] 15 | / pub fn new() -> Self { [INFO] [stderr] 16 | | Self {} [INFO] [stderr] 17 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] ... [INFO] [stderr] 607 | impl_mac_cmd_creator_boilerplate!(RXTimingSetupAnsCreator, 0x08); [INFO] [stderr] | ----------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 605 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: item `maccommands::MacCommand<'a>` has a public `len` method but no corresponding `is_empty` method [INFO] [stderr] --> src/maccommands.rs:30:1 [INFO] [stderr] | [INFO] [stderr] 30 | / impl<'a> MacCommand<'a> { [INFO] [stderr] 31 | | pub fn len(&self) -> usize { [INFO] [stderr] 32 | | match *self { [INFO] [stderr] 33 | | MacCommand::LinkCheckReq(_) => LinkCheckReqPayload::len(), [INFO] [stderr] ... | [INFO] [stderr] 67 | | } [INFO] [stderr] 68 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_without_is_empty)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stderr] [INFO] [stderr] warning: methods called `new` usually return `Self` [INFO] [stderr] --> src/maccommands.rs:136:9 [INFO] [stderr] | [INFO] [stderr] 136 | / pub fn new<'a>(_: &'a [u8]) -> Result<(MacCommand<'a>, usize), String> { [INFO] [stderr] 137 | | Ok((MacCommand::$name($type()), 0)) [INFO] [stderr] 138 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] ... [INFO] [stderr] 252 | new_mac_cmd_helper!(LinkCheckReq, LinkCheckReqPayload, 0); [INFO] [stderr] | ---------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_ret_no_self)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_ret_no_self [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/maccommands.rs:136:9 [INFO] [stderr] | [INFO] [stderr] 136 | / pub fn new<'a>(_: &'a [u8]) -> Result<(MacCommand<'a>, usize), String> { [INFO] [stderr] 137 | | Ok((MacCommand::$name($type()), 0)) [INFO] [stderr] 138 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] ... [INFO] [stderr] 252 | new_mac_cmd_helper!(LinkCheckReq, LinkCheckReqPayload, 0); [INFO] [stderr] | ---------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: methods called `new` usually return `Self` [INFO] [stderr] --> src/maccommands.rs:141:9 [INFO] [stderr] | [INFO] [stderr] 141 | / pub fn new<'b>(data: &'b [u8]) -> Result<(MacCommand<'b>, usize), String> { [INFO] [stderr] 142 | | if let Err(err) = Self::can_build_from(data) { [INFO] [stderr] 143 | | return Err(err); [INFO] [stderr] 144 | | } [INFO] [stderr] 145 | | let payload = array_ref![&data[..$len], 0, $len]; [INFO] [stderr] 146 | | Ok((MacCommand::$name($type(payload)), $len)) [INFO] [stderr] 147 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] ... [INFO] [stderr] 273 | new_mac_cmd_helper!(LinkCheckAns, LinkCheckAnsPayload, 2); [INFO] [stderr] | ---------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_ret_no_self [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/maccommands.rs:141:9 [INFO] [stderr] | [INFO] [stderr] 141 | / pub fn new<'b>(data: &'b [u8]) -> Result<(MacCommand<'b>, usize), String> { [INFO] [stderr] 142 | | if let Err(err) = Self::can_build_from(data) { [INFO] [stderr] 143 | | return Err(err); [INFO] [stderr] 144 | | } [INFO] [stderr] 145 | | let payload = array_ref![&data[..$len], 0, $len]; [INFO] [stderr] 146 | | Ok((MacCommand::$name($type(payload)), $len)) [INFO] [stderr] 147 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] ... [INFO] [stderr] 273 | new_mac_cmd_helper!(LinkCheckAns, LinkCheckAnsPayload, 2); [INFO] [stderr] | ---------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: methods called `new` usually return `Self` [INFO] [stderr] --> src/maccommands.rs:141:9 [INFO] [stderr] | [INFO] [stderr] 141 | / pub fn new<'b>(data: &'b [u8]) -> Result<(MacCommand<'b>, usize), String> { [INFO] [stderr] 142 | | if let Err(err) = Self::can_build_from(data) { [INFO] [stderr] 143 | | return Err(err); [INFO] [stderr] 144 | | } [INFO] [stderr] 145 | | let payload = array_ref![&data[..$len], 0, $len]; [INFO] [stderr] 146 | | Ok((MacCommand::$name($type(payload)), $len)) [INFO] [stderr] 147 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] ... [INFO] [stderr] 306 | new_mac_cmd_helper!(LinkADRReq, LinkADRReqPayload, 4); [INFO] [stderr] | ------------------------------------------------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_ret_no_self [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/maccommands.rs:141:9 [INFO] [stderr] | [INFO] [stderr] 141 | / pub fn new<'b>(data: &'b [u8]) -> Result<(MacCommand<'b>, usize), String> { [INFO] [stderr] 142 | | if let Err(err) = Self::can_build_from(data) { [INFO] [stderr] 143 | | return Err(err); [INFO] [stderr] 144 | | } [INFO] [stderr] 145 | | let payload = array_ref![&data[..$len], 0, $len]; [INFO] [stderr] 146 | | Ok((MacCommand::$name($type(payload)), $len)) [INFO] [stderr] 147 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] ... [INFO] [stderr] 306 | new_mac_cmd_helper!(LinkADRReq, LinkADRReqPayload, 4); [INFO] [stderr] | ------------------------------------------------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: methods called `new` usually return `Self` [INFO] [stderr] --> src/maccommands.rs:141:9 [INFO] [stderr] | [INFO] [stderr] 141 | / pub fn new<'b>(data: &'b [u8]) -> Result<(MacCommand<'b>, usize), String> { [INFO] [stderr] 142 | | if let Err(err) = Self::can_build_from(data) { [INFO] [stderr] 143 | | return Err(err); [INFO] [stderr] 144 | | } [INFO] [stderr] 145 | | let payload = array_ref![&data[..$len], 0, $len]; [INFO] [stderr] 146 | | Ok((MacCommand::$name($type(payload)), $len)) [INFO] [stderr] 147 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] ... [INFO] [stderr] 432 | new_mac_cmd_helper!(LinkADRAns, LinkADRAnsPayload, 1); [INFO] [stderr] | ------------------------------------------------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_ret_no_self [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/maccommands.rs:141:9 [INFO] [stderr] | [INFO] [stderr] 141 | / pub fn new<'b>(data: &'b [u8]) -> Result<(MacCommand<'b>, usize), String> { [INFO] [stderr] 142 | | if let Err(err) = Self::can_build_from(data) { [INFO] [stderr] 143 | | return Err(err); [INFO] [stderr] 144 | | } [INFO] [stderr] 145 | | let payload = array_ref![&data[..$len], 0, $len]; [INFO] [stderr] 146 | | Ok((MacCommand::$name($type(payload)), $len)) [INFO] [stderr] 147 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] ... [INFO] [stderr] 432 | new_mac_cmd_helper!(LinkADRAns, LinkADRAnsPayload, 1); [INFO] [stderr] | ------------------------------------------------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/maccommands.rs:432:5 [INFO] [stderr] | [INFO] [stderr] 432 | new_mac_cmd_helper!(LinkADRAns, LinkADRAnsPayload, 1); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: methods called `new` usually return `Self` [INFO] [stderr] --> src/maccommands.rs:141:9 [INFO] [stderr] | [INFO] [stderr] 141 | / pub fn new<'b>(data: &'b [u8]) -> Result<(MacCommand<'b>, usize), String> { [INFO] [stderr] 142 | | if let Err(err) = Self::can_build_from(data) { [INFO] [stderr] 143 | | return Err(err); [INFO] [stderr] 144 | | } [INFO] [stderr] 145 | | let payload = array_ref![&data[..$len], 0, $len]; [INFO] [stderr] 146 | | Ok((MacCommand::$name($type(payload)), $len)) [INFO] [stderr] 147 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] ... [INFO] [stderr] 467 | new_mac_cmd_helper!(DutyCycleReq, DutyCycleReqPayload, 1); [INFO] [stderr] | ---------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_ret_no_self [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/maccommands.rs:141:9 [INFO] [stderr] | [INFO] [stderr] 141 | / pub fn new<'b>(data: &'b [u8]) -> Result<(MacCommand<'b>, usize), String> { [INFO] [stderr] 142 | | if let Err(err) = Self::can_build_from(data) { [INFO] [stderr] 143 | | return Err(err); [INFO] [stderr] 144 | | } [INFO] [stderr] 145 | | let payload = array_ref![&data[..$len], 0, $len]; [INFO] [stderr] 146 | | Ok((MacCommand::$name($type(payload)), $len)) [INFO] [stderr] 147 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] ... [INFO] [stderr] 467 | new_mac_cmd_helper!(DutyCycleReq, DutyCycleReqPayload, 1); [INFO] [stderr] | ---------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/maccommands.rs:467:5 [INFO] [stderr] | [INFO] [stderr] 467 | new_mac_cmd_helper!(DutyCycleReq, DutyCycleReqPayload, 1); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: methods called `new` usually return `Self` [INFO] [stderr] --> src/maccommands.rs:136:9 [INFO] [stderr] | [INFO] [stderr] 136 | / pub fn new<'a>(_: &'a [u8]) -> Result<(MacCommand<'a>, usize), String> { [INFO] [stderr] 137 | | Ok((MacCommand::$name($type()), 0)) [INFO] [stderr] 138 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] ... [INFO] [stderr] 499 | new_mac_cmd_helper!(DutyCycleAns, DutyCycleAnsPayload, 0); [INFO] [stderr] | ---------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_ret_no_self [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/maccommands.rs:136:9 [INFO] [stderr] | [INFO] [stderr] 136 | / pub fn new<'a>(_: &'a [u8]) -> Result<(MacCommand<'a>, usize), String> { [INFO] [stderr] 137 | | Ok((MacCommand::$name($type()), 0)) [INFO] [stderr] 138 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] ... [INFO] [stderr] 499 | new_mac_cmd_helper!(DutyCycleAns, DutyCycleAnsPayload, 0); [INFO] [stderr] | ---------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: methods called `new` usually return `Self` [INFO] [stderr] --> src/maccommands.rs:141:9 [INFO] [stderr] | [INFO] [stderr] 141 | / pub fn new<'b>(data: &'b [u8]) -> Result<(MacCommand<'b>, usize), String> { [INFO] [stderr] 142 | | if let Err(err) = Self::can_build_from(data) { [INFO] [stderr] 143 | | return Err(err); [INFO] [stderr] 144 | | } [INFO] [stderr] 145 | | let payload = array_ref![&data[..$len], 0, $len]; [INFO] [stderr] 146 | | Ok((MacCommand::$name($type(payload)), $len)) [INFO] [stderr] 147 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] ... [INFO] [stderr] 520 | new_mac_cmd_helper!(RXParamSetupReq, RXParamSetupReqPayload, 4); [INFO] [stderr] | ---------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_ret_no_self [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/maccommands.rs:141:9 [INFO] [stderr] | [INFO] [stderr] 141 | / pub fn new<'b>(data: &'b [u8]) -> Result<(MacCommand<'b>, usize), String> { [INFO] [stderr] 142 | | if let Err(err) = Self::can_build_from(data) { [INFO] [stderr] 143 | | return Err(err); [INFO] [stderr] 144 | | } [INFO] [stderr] 145 | | let payload = array_ref![&data[..$len], 0, $len]; [INFO] [stderr] 146 | | Ok((MacCommand::$name($type(payload)), $len)) [INFO] [stderr] 147 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] ... [INFO] [stderr] 520 | new_mac_cmd_helper!(RXParamSetupReq, RXParamSetupReqPayload, 4); [INFO] [stderr] | ---------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/maccommands.rs:590:11 [INFO] [stderr] | [INFO] [stderr] 590 | (((self.0[2] as u32) << 16) + ((self.0[1] as u32) << 8) + (self.0[0] as u32)) * 100 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `u32::from(self.0[2])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/maccommands.rs:590:40 [INFO] [stderr] | [INFO] [stderr] 590 | (((self.0[2] as u32) << 16) + ((self.0[1] as u32) << 8) + (self.0[0] as u32)) * 100 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `u32::from(self.0[1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/maccommands.rs:590:67 [INFO] [stderr] | [INFO] [stderr] 590 | (((self.0[2] as u32) << 16) + ((self.0[1] as u32) << 8) + (self.0[0] as u32)) * 100 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `u32::from(self.0[0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: methods called `new` usually return `Self` [INFO] [stderr] --> src/maccommands.rs:141:9 [INFO] [stderr] | [INFO] [stderr] 141 | / pub fn new<'b>(data: &'b [u8]) -> Result<(MacCommand<'b>, usize), String> { [INFO] [stderr] 142 | | if let Err(err) = Self::can_build_from(data) { [INFO] [stderr] 143 | | return Err(err); [INFO] [stderr] 144 | | } [INFO] [stderr] 145 | | let payload = array_ref![&data[..$len], 0, $len]; [INFO] [stderr] 146 | | Ok((MacCommand::$name($type(payload)), $len)) [INFO] [stderr] 147 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] ... [INFO] [stderr] 624 | new_mac_cmd_helper!(RXParamSetupAns, RXParamSetupAnsPayload, 1); [INFO] [stderr] | ---------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_ret_no_self [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/maccommands.rs:141:9 [INFO] [stderr] | [INFO] [stderr] 141 | / pub fn new<'b>(data: &'b [u8]) -> Result<(MacCommand<'b>, usize), String> { [INFO] [stderr] 142 | | if let Err(err) = Self::can_build_from(data) { [INFO] [stderr] 143 | | return Err(err); [INFO] [stderr] 144 | | } [INFO] [stderr] 145 | | let payload = array_ref![&data[..$len], 0, $len]; [INFO] [stderr] 146 | | Ok((MacCommand::$name($type(payload)), $len)) [INFO] [stderr] 147 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] ... [INFO] [stderr] 624 | new_mac_cmd_helper!(RXParamSetupAns, RXParamSetupAnsPayload, 1); [INFO] [stderr] | ---------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/maccommands.rs:624:5 [INFO] [stderr] | [INFO] [stderr] 624 | new_mac_cmd_helper!(RXParamSetupAns, RXParamSetupAnsPayload, 1); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: methods called `new` usually return `Self` [INFO] [stderr] --> src/maccommands.rs:136:9 [INFO] [stderr] | [INFO] [stderr] 136 | / pub fn new<'a>(_: &'a [u8]) -> Result<(MacCommand<'a>, usize), String> { [INFO] [stderr] 137 | | Ok((MacCommand::$name($type()), 0)) [INFO] [stderr] 138 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] ... [INFO] [stderr] 659 | new_mac_cmd_helper!(DevStatusReq, DevStatusReqPayload, 0); [INFO] [stderr] | ---------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_ret_no_self [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/maccommands.rs:136:9 [INFO] [stderr] | [INFO] [stderr] 136 | / pub fn new<'a>(_: &'a [u8]) -> Result<(MacCommand<'a>, usize), String> { [INFO] [stderr] 137 | | Ok((MacCommand::$name($type()), 0)) [INFO] [stderr] 138 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] ... [INFO] [stderr] 659 | new_mac_cmd_helper!(DevStatusReq, DevStatusReqPayload, 0); [INFO] [stderr] | ---------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: methods called `new` usually return `Self` [INFO] [stderr] --> src/maccommands.rs:141:9 [INFO] [stderr] | [INFO] [stderr] 141 | / pub fn new<'b>(data: &'b [u8]) -> Result<(MacCommand<'b>, usize), String> { [INFO] [stderr] 142 | | if let Err(err) = Self::can_build_from(data) { [INFO] [stderr] 143 | | return Err(err); [INFO] [stderr] 144 | | } [INFO] [stderr] 145 | | let payload = array_ref![&data[..$len], 0, $len]; [INFO] [stderr] 146 | | Ok((MacCommand::$name($type(payload)), $len)) [INFO] [stderr] 147 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] ... [INFO] [stderr] 680 | new_mac_cmd_helper!(DevStatusAns, DevStatusAnsPayload, 2); [INFO] [stderr] | ---------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_ret_no_self [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/maccommands.rs:141:9 [INFO] [stderr] | [INFO] [stderr] 141 | / pub fn new<'b>(data: &'b [u8]) -> Result<(MacCommand<'b>, usize), String> { [INFO] [stderr] 142 | | if let Err(err) = Self::can_build_from(data) { [INFO] [stderr] 143 | | return Err(err); [INFO] [stderr] 144 | | } [INFO] [stderr] 145 | | let payload = array_ref![&data[..$len], 0, $len]; [INFO] [stderr] 146 | | Ok((MacCommand::$name($type(payload)), $len)) [INFO] [stderr] 147 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] ... [INFO] [stderr] 680 | new_mac_cmd_helper!(DevStatusAns, DevStatusAnsPayload, 2); [INFO] [stderr] | ---------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: methods called `new` usually return `Self` [INFO] [stderr] --> src/maccommands.rs:141:9 [INFO] [stderr] | [INFO] [stderr] 141 | / pub fn new<'b>(data: &'b [u8]) -> Result<(MacCommand<'b>, usize), String> { [INFO] [stderr] 142 | | if let Err(err) = Self::can_build_from(data) { [INFO] [stderr] 143 | | return Err(err); [INFO] [stderr] 144 | | } [INFO] [stderr] 145 | | let payload = array_ref![&data[..$len], 0, $len]; [INFO] [stderr] 146 | | Ok((MacCommand::$name($type(payload)), $len)) [INFO] [stderr] 147 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] ... [INFO] [stderr] 720 | new_mac_cmd_helper!(NewChannelReq, NewChannelReqPayload, 5); [INFO] [stderr] | ------------------------------------------------------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_ret_no_self [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/maccommands.rs:141:9 [INFO] [stderr] | [INFO] [stderr] 141 | / pub fn new<'b>(data: &'b [u8]) -> Result<(MacCommand<'b>, usize), String> { [INFO] [stderr] 142 | | if let Err(err) = Self::can_build_from(data) { [INFO] [stderr] 143 | | return Err(err); [INFO] [stderr] 144 | | } [INFO] [stderr] 145 | | let payload = array_ref![&data[..$len], 0, $len]; [INFO] [stderr] 146 | | Ok((MacCommand::$name($type(payload)), $len)) [INFO] [stderr] 147 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] ... [INFO] [stderr] 720 | new_mac_cmd_helper!(NewChannelReq, NewChannelReqPayload, 5); [INFO] [stderr] | ------------------------------------------------------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: methods called `new` usually return `Self` [INFO] [stderr] --> src/maccommands.rs:141:9 [INFO] [stderr] | [INFO] [stderr] 141 | / pub fn new<'b>(data: &'b [u8]) -> Result<(MacCommand<'b>, usize), String> { [INFO] [stderr] 142 | | if let Err(err) = Self::can_build_from(data) { [INFO] [stderr] 143 | | return Err(err); [INFO] [stderr] 144 | | } [INFO] [stderr] 145 | | let payload = array_ref![&data[..$len], 0, $len]; [INFO] [stderr] 146 | | Ok((MacCommand::$name($type(payload)), $len)) [INFO] [stderr] 147 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] ... [INFO] [stderr] 805 | new_mac_cmd_helper!(NewChannelAns, NewChannelAnsPayload, 1); [INFO] [stderr] | ------------------------------------------------------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_ret_no_self [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/maccommands.rs:141:9 [INFO] [stderr] | [INFO] [stderr] 141 | / pub fn new<'b>(data: &'b [u8]) -> Result<(MacCommand<'b>, usize), String> { [INFO] [stderr] 142 | | if let Err(err) = Self::can_build_from(data) { [INFO] [stderr] 143 | | return Err(err); [INFO] [stderr] 144 | | } [INFO] [stderr] 145 | | let payload = array_ref![&data[..$len], 0, $len]; [INFO] [stderr] 146 | | Ok((MacCommand::$name($type(payload)), $len)) [INFO] [stderr] 147 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] ... [INFO] [stderr] 805 | new_mac_cmd_helper!(NewChannelAns, NewChannelAnsPayload, 1); [INFO] [stderr] | ------------------------------------------------------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/maccommands.rs:805:5 [INFO] [stderr] | [INFO] [stderr] 805 | new_mac_cmd_helper!(NewChannelAns, NewChannelAnsPayload, 1); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: methods called `new` usually return `Self` [INFO] [stderr] --> src/maccommands.rs:141:9 [INFO] [stderr] | [INFO] [stderr] 141 | / pub fn new<'b>(data: &'b [u8]) -> Result<(MacCommand<'b>, usize), String> { [INFO] [stderr] 142 | | if let Err(err) = Self::can_build_from(data) { [INFO] [stderr] 143 | | return Err(err); [INFO] [stderr] 144 | | } [INFO] [stderr] 145 | | let payload = array_ref![&data[..$len], 0, $len]; [INFO] [stderr] 146 | | Ok((MacCommand::$name($type(payload)), $len)) [INFO] [stderr] 147 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] ... [INFO] [stderr] 837 | new_mac_cmd_helper!(RXTimingSetupReq, RXTimingSetupReqPayload, 1); [INFO] [stderr] | ------------------------------------------------------------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_ret_no_self [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/maccommands.rs:141:9 [INFO] [stderr] | [INFO] [stderr] 141 | / pub fn new<'b>(data: &'b [u8]) -> Result<(MacCommand<'b>, usize), String> { [INFO] [stderr] 142 | | if let Err(err) = Self::can_build_from(data) { [INFO] [stderr] 143 | | return Err(err); [INFO] [stderr] 144 | | } [INFO] [stderr] 145 | | let payload = array_ref![&data[..$len], 0, $len]; [INFO] [stderr] 146 | | Ok((MacCommand::$name($type(payload)), $len)) [INFO] [stderr] 147 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] ... [INFO] [stderr] 837 | new_mac_cmd_helper!(RXTimingSetupReq, RXTimingSetupReqPayload, 1); [INFO] [stderr] | ------------------------------------------------------------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/maccommands.rs:837:5 [INFO] [stderr] | [INFO] [stderr] 837 | new_mac_cmd_helper!(RXTimingSetupReq, RXTimingSetupReqPayload, 1); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: methods called `new` usually return `Self` [INFO] [stderr] --> src/maccommands.rs:136:9 [INFO] [stderr] | [INFO] [stderr] 136 | / pub fn new<'a>(_: &'a [u8]) -> Result<(MacCommand<'a>, usize), String> { [INFO] [stderr] 137 | | Ok((MacCommand::$name($type()), 0)) [INFO] [stderr] 138 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] ... [INFO] [stderr] 863 | new_mac_cmd_helper!(RXTimingSetupAns, RXTimingSetupAnsPayload, 0); [INFO] [stderr] | ------------------------------------------------------------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_ret_no_self [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/maccommands.rs:136:9 [INFO] [stderr] | [INFO] [stderr] 136 | / pub fn new<'a>(_: &'a [u8]) -> Result<(MacCommand<'a>, usize), String> { [INFO] [stderr] 137 | | Ok((MacCommand::$name($type()), 0)) [INFO] [stderr] 138 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] ... [INFO] [stderr] 863 | new_mac_cmd_helper!(RXTimingSetupAns, RXTimingSetupAnsPayload, 0); [INFO] [stderr] | ------------------------------------------------------------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: it looks like you're manually copying between slices [INFO] [stderr] --> src/parser.rs:100:22 [INFO] [stderr] | [INFO] [stderr] 100 | for j in 0..16 { [INFO] [stderr] | ^^^^^ help: try replacing the loop by: `bytes[start..(16 + start)].clone_from_slice(&tmp[..16])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_memcpy [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/parser.rs:226:32 [INFO] [stderr] | [INFO] [stderr] 226 | ((old_fcnt >> 16) << 16) ^ (fcnt as u32) [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u32::from(fcnt)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: bit mask could be simplified with a call to `trailing_zeros` [INFO] [stderr] --> src/parser.rs:254:12 [INFO] [stderr] | [INFO] [stderr] 254 | if self.0 & 3 == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `self.0.trailing_zeros() >= 2` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::verbose_bit_mask)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#verbose_bit_mask [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/parser.rs:297:1 [INFO] [stderr] | [INFO] [stderr] 297 | / fn fhdr_length<'a>(bytes: &'a [u8], uplink: bool) -> usize { [INFO] [stderr] 298 | | 7 + FCtrl(bytes[4], uplink).f_opts_len() as usize [INFO] [stderr] 299 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/parser.rs:540:23 [INFO] [stderr] | [INFO] [stderr] 540 | pub fn new(bytes: &[u8; 4]) -> DevAddr { [INFO] [stderr] | ^^^^^^^^ help: consider passing by value instead: `[u8; 4]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/parser.rs:606:20 [INFO] [stderr] | [INFO] [stderr] 606 | let res = ((self.0[6] as u16) << 8) | (self.0[5] as u16); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `u16::from(self.0[6])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/parser.rs:606:47 [INFO] [stderr] | [INFO] [stderr] 606 | let res = ((self.0[6] as u16) << 8) | (self.0[5] as u16); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `u16::from(self.0[5])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: incompatible bit mask: `_ & 64` can never be equal to `1` [INFO] [stderr] --> src/parser.rs:630:19 [INFO] [stderr] | [INFO] [stderr] 630 | self.1 && self.0 & (1 << 6) == 1 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::bad_bit_mask)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bad_bit_mask [INFO] [stderr] [INFO] [stderr] error: incompatible bit mask: `_ & 32` can never be equal to `1` [INFO] [stderr] --> src/parser.rs:634:9 [INFO] [stderr] | [INFO] [stderr] 634 | self.0 & (1 << 5) == 1 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bad_bit_mask [INFO] [stderr] [INFO] [stderr] error: incompatible bit mask: `_ & 16` can never be equal to `1` [INFO] [stderr] --> src/parser.rs:638:20 [INFO] [stderr] | [INFO] [stderr] 638 | !self.1 && self.0 & (1 << 4) == 1 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bad_bit_mask [INFO] [stderr] [INFO] [stderr] error: aborting due to 3 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `lorawan`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "064213641c4a9ca0f98babf8fcee702c24e6daa28c7124fc515eadff3479c158"` [INFO] running `"docker" "rm" "-f" "064213641c4a9ca0f98babf8fcee702c24e6daa28c7124fc515eadff3479c158"` [INFO] [stdout] 064213641c4a9ca0f98babf8fcee702c24e6daa28c7124fc515eadff3479c158