[INFO] crate lol_api_rs 0.2.0 is already in cache [INFO] extracting crate lol_api_rs 0.2.0 into work/ex/clippy-test-run/sources/stable/reg/lol_api_rs/0.2.0 [INFO] extracting crate lol_api_rs 0.2.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/lol_api_rs/0.2.0 [INFO] validating manifest of lol_api_rs-0.2.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of lol_api_rs-0.2.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing lol_api_rs-0.2.0 [INFO] finished frobbing lol_api_rs-0.2.0 [INFO] frobbed toml for lol_api_rs-0.2.0 written to work/ex/clippy-test-run/sources/stable/reg/lol_api_rs/0.2.0/Cargo.toml [INFO] started frobbing lol_api_rs-0.2.0 [INFO] finished frobbing lol_api_rs-0.2.0 [INFO] frobbed toml for lol_api_rs-0.2.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/lol_api_rs/0.2.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting lol_api_rs-0.2.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/lol_api_rs/0.2.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] abe1579d89421f89df6af66b426d2e316907eacc1cf02813f5e6eed1c61420b3 [INFO] running `"docker" "start" "-a" "abe1579d89421f89df6af66b426d2e316907eacc1cf02813f5e6eed1c61420b3"` [INFO] [stderr] Checking reqwest v0.6.2 [INFO] [stderr] Checking lol_api_rs v0.2.0 (/opt/crater/workdir) [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/client/mod.rs:64:22 [INFO] [stderr] | [INFO] [stderr] 64 | .unwrap_or(slog::Logger::root(slog_term::FullFormat::new(slog_term::PlainSyncDecorator::new(std::io::stdout())) [INFO] [stderr] | ______________________^ [INFO] [stderr] 65 | | .build().fuse(), o!("lol_api_version" => "0.2.0", "riot_api_version" => "v3"))) [INFO] [stderr] | |___________________________________________________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 64 | .unwrap_or_else(|| slog::Logger::root(slog_term::FullFormat::new(slog_term::PlainSyncDecorator::new(std::io::stdout())) [INFO] [stderr] 65 | .build().fuse(), o!("lol_api_version" => "0.2.0", "riot_api_version" => "v3"))) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/client/mod.rs:72:95 [INFO] [stderr] | [INFO] [stderr] 72 | let parsed_url = Url::parse_with_params(&format!("{}{}", self.base_url, url), ¶ms.unwrap_or(vec![])) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| vec![])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/client/mod.rs:78:72 [INFO] [stderr] | [INFO] [stderr] 78 | RM::Put => self.client.put::<&str>(&parsed_url).form(&body.unwrap_or(vec![])), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| vec![])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/client/mod.rs:79:74 [INFO] [stderr] | [INFO] [stderr] 79 | RM::Post => self.client.post::<&str>(&parsed_url).form(&body.unwrap_or(vec![])) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| vec![])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/client/mod.rs:97:11 [INFO] [stderr] | [INFO] [stderr] 97 | / match res.status().is_success() { [INFO] [stderr] 98 | | true => Ok(res.json().expect("Cannot parse returned JSON")), [INFO] [stderr] 99 | | false => Err(format!("{}", res.status())) [INFO] [stderr] 100 | | } [INFO] [stderr] | |___________^ help: consider using an if/else expression: `if res.status().is_success() { Ok(res.json().expect("Cannot parse returned JSON")) } else { Err(format!("{}", res.status())) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/client/mod.rs:116:19 [INFO] [stderr] | [INFO] [stderr] 116 | let url = format!("/lol/platform/v3/champions"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"/lol/platform/v3/champions".to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/client/mod.rs:221:19 [INFO] [stderr] | [INFO] [stderr] 221 | let url = format!("/lol/static-data/v3/champions"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"/lol/static-data/v3/champions".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/client/mod.rs:252:19 [INFO] [stderr] | [INFO] [stderr] 252 | let url = format!("/lol/static-data/v3/items"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"/lol/static-data/v3/items".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/client/mod.rs:260:19 [INFO] [stderr] | [INFO] [stderr] 260 | let url = format!("/lol/static-data/v3/languages"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"/lol/static-data/v3/languages".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/client/mod.rs:273:19 [INFO] [stderr] | [INFO] [stderr] 273 | let url = format!("/lol/static-data/v3/language-strings"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"/lol/static-data/v3/language-strings".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/client/mod.rs:287:19 [INFO] [stderr] | [INFO] [stderr] 287 | let url = format!("/lol/static-data/v3/maps"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"/lol/static-data/v3/maps".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/client/mod.rs:318:19 [INFO] [stderr] | [INFO] [stderr] 318 | let url = format!("/lol/static-data/v3/masteries"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"/lol/static-data/v3/masteries".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/client/mod.rs:332:19 [INFO] [stderr] | [INFO] [stderr] 332 | let url = format!("/lol/static-data/v3/profile-icons"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"/lol/static-data/v3/profile-icons".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/client/mod.rs:340:19 [INFO] [stderr] | [INFO] [stderr] 340 | let url = format!("/lol/static-data/v3/realms"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"/lol/static-data/v3/realms".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/client/mod.rs:355:19 [INFO] [stderr] | [INFO] [stderr] 355 | let url = format!("/lol/static-data/v3/runes"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"/lol/static-data/v3/runes".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/client/mod.rs:403:19 [INFO] [stderr] | [INFO] [stderr] 403 | let url = format!("/lol/static-data/v3/summoner-spells"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"/lol/static-data/v3/summoner-spells".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/client/mod.rs:411:19 [INFO] [stderr] | [INFO] [stderr] 411 | let url = format!("/lol/static-data/v3/versions"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"/lol/static-data/v3/versions".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/client/mod.rs:419:19 [INFO] [stderr] | [INFO] [stderr] 419 | let url = format!("/lol/status/v3/shard-data"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"/lol/status/v3/shard-data".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/client/mod.rs:519:19 [INFO] [stderr] | [INFO] [stderr] 519 | let url = format!("/lol/spectator/v3/featured-games"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"/lol/spectator/v3/featured-games".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/client/mod.rs:570:19 [INFO] [stderr] | [INFO] [stderr] 570 | let url = format!("/lol/tournament-stub/v3/codes"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"/lol/tournament-stub/v3/codes".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/client/mod.rs:593:19 [INFO] [stderr] | [INFO] [stderr] 593 | let url = format!("/lol/tournament-stub/v3/providers"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"/lol/tournament-stub/v3/providers".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/client/mod.rs:607:19 [INFO] [stderr] | [INFO] [stderr] 607 | let url = format!("/lol/tournament-stub/v3/tournaments"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"/lol/tournament-stub/v3/tournaments".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/client/mod.rs:631:19 [INFO] [stderr] | [INFO] [stderr] 631 | let url = format!("/lol/tournament/v3/codes"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"/lol/tournament/v3/codes".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/client/mod.rs:685:19 [INFO] [stderr] | [INFO] [stderr] 685 | let url = format!("/lol/tournament/v3/providers"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"/lol/tournament/v3/providers".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/client/mod.rs:699:19 [INFO] [stderr] | [INFO] [stderr] 699 | let url = format!("/lol/tournament/v3/tournaments"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"/lol/tournament/v3/tournaments".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/structs/generic.rs:9:9 [INFO] [stderr] | [INFO] [stderr] 9 | / match self { [INFO] [stderr] 10 | | &RiotQueue::RankedSolo5x5 => "RANKED_SOLO_5x5", [INFO] [stderr] 11 | | &RiotQueue::RankedFlexSr => "RANKED_FLEX_SR", [INFO] [stderr] 12 | | &RiotQueue::RankedFlexTt => "RANKED_FLEX_TT" [INFO] [stderr] 13 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 9 | match *self { [INFO] [stderr] 10 | RiotQueue::RankedSolo5x5 => "RANKED_SOLO_5x5", [INFO] [stderr] 11 | RiotQueue::RankedFlexSr => "RANKED_FLEX_SR", [INFO] [stderr] 12 | RiotQueue::RankedFlexTt => "RANKED_FLEX_TT" [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/client/mod.rs:64:22 [INFO] [stderr] | [INFO] [stderr] 64 | .unwrap_or(slog::Logger::root(slog_term::FullFormat::new(slog_term::PlainSyncDecorator::new(std::io::stdout())) [INFO] [stderr] | ______________________^ [INFO] [stderr] 65 | | .build().fuse(), o!("lol_api_version" => "0.2.0", "riot_api_version" => "v3"))) [INFO] [stderr] | |___________________________________________________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 64 | .unwrap_or_else(|| slog::Logger::root(slog_term::FullFormat::new(slog_term::PlainSyncDecorator::new(std::io::stdout())) [INFO] [stderr] 65 | .build().fuse(), o!("lol_api_version" => "0.2.0", "riot_api_version" => "v3"))) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/client/mod.rs:72:95 [INFO] [stderr] | [INFO] [stderr] 72 | let parsed_url = Url::parse_with_params(&format!("{}{}", self.base_url, url), ¶ms.unwrap_or(vec![])) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| vec![])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/client/mod.rs:78:72 [INFO] [stderr] | [INFO] [stderr] 78 | RM::Put => self.client.put::<&str>(&parsed_url).form(&body.unwrap_or(vec![])), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| vec![])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/client/mod.rs:79:74 [INFO] [stderr] | [INFO] [stderr] 79 | RM::Post => self.client.post::<&str>(&parsed_url).form(&body.unwrap_or(vec![])) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| vec![])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/client/mod.rs:97:11 [INFO] [stderr] | [INFO] [stderr] 97 | / match res.status().is_success() { [INFO] [stderr] 98 | | true => Ok(res.json().expect("Cannot parse returned JSON")), [INFO] [stderr] 99 | | false => Err(format!("{}", res.status())) [INFO] [stderr] 100 | | } [INFO] [stderr] | |___________^ help: consider using an if/else expression: `if res.status().is_success() { Ok(res.json().expect("Cannot parse returned JSON")) } else { Err(format!("{}", res.status())) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/client/mod.rs:116:19 [INFO] [stderr] | [INFO] [stderr] 116 | let url = format!("/lol/platform/v3/champions"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"/lol/platform/v3/champions".to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/client/mod.rs:221:19 [INFO] [stderr] | [INFO] [stderr] 221 | let url = format!("/lol/static-data/v3/champions"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"/lol/static-data/v3/champions".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/client/mod.rs:252:19 [INFO] [stderr] | [INFO] [stderr] 252 | let url = format!("/lol/static-data/v3/items"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"/lol/static-data/v3/items".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/client/mod.rs:260:19 [INFO] [stderr] | [INFO] [stderr] 260 | let url = format!("/lol/static-data/v3/languages"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"/lol/static-data/v3/languages".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/client/mod.rs:273:19 [INFO] [stderr] | [INFO] [stderr] 273 | let url = format!("/lol/static-data/v3/language-strings"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"/lol/static-data/v3/language-strings".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/client/mod.rs:287:19 [INFO] [stderr] | [INFO] [stderr] 287 | let url = format!("/lol/static-data/v3/maps"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"/lol/static-data/v3/maps".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/client/mod.rs:318:19 [INFO] [stderr] | [INFO] [stderr] 318 | let url = format!("/lol/static-data/v3/masteries"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"/lol/static-data/v3/masteries".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/client/mod.rs:332:19 [INFO] [stderr] | [INFO] [stderr] 332 | let url = format!("/lol/static-data/v3/profile-icons"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"/lol/static-data/v3/profile-icons".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/client/mod.rs:340:19 [INFO] [stderr] | [INFO] [stderr] 340 | let url = format!("/lol/static-data/v3/realms"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"/lol/static-data/v3/realms".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/client/mod.rs:355:19 [INFO] [stderr] | [INFO] [stderr] 355 | let url = format!("/lol/static-data/v3/runes"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"/lol/static-data/v3/runes".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/client/mod.rs:403:19 [INFO] [stderr] | [INFO] [stderr] 403 | let url = format!("/lol/static-data/v3/summoner-spells"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"/lol/static-data/v3/summoner-spells".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/client/mod.rs:411:19 [INFO] [stderr] | [INFO] [stderr] 411 | let url = format!("/lol/static-data/v3/versions"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"/lol/static-data/v3/versions".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/client/mod.rs:419:19 [INFO] [stderr] | [INFO] [stderr] 419 | let url = format!("/lol/status/v3/shard-data"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"/lol/status/v3/shard-data".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/client/mod.rs:519:19 [INFO] [stderr] | [INFO] [stderr] 519 | let url = format!("/lol/spectator/v3/featured-games"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"/lol/spectator/v3/featured-games".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/client/mod.rs:570:19 [INFO] [stderr] | [INFO] [stderr] 570 | let url = format!("/lol/tournament-stub/v3/codes"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"/lol/tournament-stub/v3/codes".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/client/mod.rs:593:19 [INFO] [stderr] | [INFO] [stderr] 593 | let url = format!("/lol/tournament-stub/v3/providers"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"/lol/tournament-stub/v3/providers".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/client/mod.rs:607:19 [INFO] [stderr] | [INFO] [stderr] 607 | let url = format!("/lol/tournament-stub/v3/tournaments"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"/lol/tournament-stub/v3/tournaments".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/client/mod.rs:631:19 [INFO] [stderr] | [INFO] [stderr] 631 | let url = format!("/lol/tournament/v3/codes"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"/lol/tournament/v3/codes".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/client/mod.rs:685:19 [INFO] [stderr] | [INFO] [stderr] 685 | let url = format!("/lol/tournament/v3/providers"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"/lol/tournament/v3/providers".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/client/mod.rs:699:19 [INFO] [stderr] | [INFO] [stderr] 699 | let url = format!("/lol/tournament/v3/tournaments"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"/lol/tournament/v3/tournaments".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/structs/generic.rs:9:9 [INFO] [stderr] | [INFO] [stderr] 9 | / match self { [INFO] [stderr] 10 | | &RiotQueue::RankedSolo5x5 => "RANKED_SOLO_5x5", [INFO] [stderr] 11 | | &RiotQueue::RankedFlexSr => "RANKED_FLEX_SR", [INFO] [stderr] 12 | | &RiotQueue::RankedFlexTt => "RANKED_FLEX_TT" [INFO] [stderr] 13 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 9 | match *self { [INFO] [stderr] 10 | RiotQueue::RankedSolo5x5 => "RANKED_SOLO_5x5", [INFO] [stderr] 11 | RiotQueue::RankedFlexSr => "RANKED_FLEX_SR", [INFO] [stderr] 12 | RiotQueue::RankedFlexTt => "RANKED_FLEX_TT" [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 20.02s [INFO] running `"docker" "inspect" "abe1579d89421f89df6af66b426d2e316907eacc1cf02813f5e6eed1c61420b3"` [INFO] running `"docker" "rm" "-f" "abe1579d89421f89df6af66b426d2e316907eacc1cf02813f5e6eed1c61420b3"` [INFO] [stdout] abe1579d89421f89df6af66b426d2e316907eacc1cf02813f5e6eed1c61420b3