[INFO] crate logrustate 0.1.0 is already in cache [INFO] extracting crate logrustate 0.1.0 into work/ex/clippy-test-run/sources/stable/reg/logrustate/0.1.0 [INFO] extracting crate logrustate 0.1.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/logrustate/0.1.0 [INFO] validating manifest of logrustate-0.1.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of logrustate-0.1.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing logrustate-0.1.0 [INFO] finished frobbing logrustate-0.1.0 [INFO] frobbed toml for logrustate-0.1.0 written to work/ex/clippy-test-run/sources/stable/reg/logrustate/0.1.0/Cargo.toml [INFO] started frobbing logrustate-0.1.0 [INFO] finished frobbing logrustate-0.1.0 [INFO] frobbed toml for logrustate-0.1.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/logrustate/0.1.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting logrustate-0.1.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/logrustate/0.1.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 56e9e9fe702f21df452bbf7804dbb5ff3c60b1d56299c6d0b85eec6d20ba7dcc [INFO] running `"docker" "start" "-a" "56e9e9fe702f21df452bbf7804dbb5ff3c60b1d56299c6d0b85eec6d20ba7dcc"` [INFO] [stderr] Checking logrustate v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: You matched a field with a wildcard pattern. Consider using `..` instead [INFO] [stderr] --> src/inotify.rs:27:57 [INFO] [stderr] | [INFO] [stderr] 27 | Ok(RawEvent { path: Some(path), op: Ok(op), cookie: _ }) => { [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unneeded_field_pattern)] on by default [INFO] [stderr] = help: Try with `RawEvent { path: Some(path), op: Ok(op), .. }` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/logrotate.rs:148:13 [INFO] [stderr] | [INFO] [stderr] 148 | / if num_drop > 0 { [INFO] [stderr] 149 | | if unsafe { libc::fallocate(fd as libc::c_int, libc::FALLOC_FL_COLLAPSE_RANGE, [INFO] [stderr] 150 | | 0, (self.buf_size * num_drop) as libc::c_long) } < 0 { [INFO] [stderr] 151 | | return Err(LogHandleError::from_errno()); [INFO] [stderr] 152 | | } [INFO] [stderr] 153 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 148 | if num_drop > 0 && unsafe { libc::fallocate(fd as libc::c_int, libc::FALLOC_FL_COLLAPSE_RANGE, [INFO] [stderr] 149 | 0, (self.buf_size * num_drop) as libc::c_long) } < 0 { [INFO] [stderr] 150 | return Err(LogHandleError::from_errno()); [INFO] [stderr] 151 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/inotify.rs:33:21 [INFO] [stderr] | [INFO] [stderr] 33 | / match logstate.handle_log(path_str) { [INFO] [stderr] 34 | | Err(e) => { println!("Error handling log: {}", e) }, [INFO] [stderr] 35 | | _ => (), [INFO] [stderr] 36 | | }; [INFO] [stderr] | |_____________________^ help: try this: `if let Err(e) = logstate.handle_log(path_str) { println!("Error handling log: {}", e) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/logrotate.rs:24:41 [INFO] [stderr] | [INFO] [stderr] 24 | let string = cstr.into_string().unwrap_or("Error parsing errno string".to_string()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| "Error parsing errno string".to_string())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: You matched a field with a wildcard pattern. Consider using `..` instead [INFO] [stderr] --> src/inotify.rs:27:57 [INFO] [stderr] | [INFO] [stderr] 27 | Ok(RawEvent { path: Some(path), op: Ok(op), cookie: _ }) => { [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unneeded_field_pattern)] on by default [INFO] [stderr] = help: Try with `RawEvent { path: Some(path), op: Ok(op), .. }` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/logrotate.rs:148:13 [INFO] [stderr] | [INFO] [stderr] 148 | / if num_drop > 0 { [INFO] [stderr] 149 | | if unsafe { libc::fallocate(fd as libc::c_int, libc::FALLOC_FL_COLLAPSE_RANGE, [INFO] [stderr] 150 | | 0, (self.buf_size * num_drop) as libc::c_long) } < 0 { [INFO] [stderr] 151 | | return Err(LogHandleError::from_errno()); [INFO] [stderr] 152 | | } [INFO] [stderr] 153 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 148 | if num_drop > 0 && unsafe { libc::fallocate(fd as libc::c_int, libc::FALLOC_FL_COLLAPSE_RANGE, [INFO] [stderr] 149 | 0, (self.buf_size * num_drop) as libc::c_long) } < 0 { [INFO] [stderr] 150 | return Err(LogHandleError::from_errno()); [INFO] [stderr] 151 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:80:5 [INFO] [stderr] | [INFO] [stderr] 80 | / match watch_files(&args.files, args.num_old_logs, args.log_size) { [INFO] [stderr] 81 | | Err(e) => { [INFO] [stderr] 82 | | println!("Error watching files: {}", e); [INFO] [stderr] 83 | | process::exit(1); [INFO] [stderr] 84 | | }, [INFO] [stderr] 85 | | _ => (), [INFO] [stderr] 86 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 80 | if let Err(e) = watch_files(&args.files, args.num_old_logs, args.log_size) { [INFO] [stderr] 81 | println!("Error watching files: {}", e); [INFO] [stderr] 82 | process::exit(1); [INFO] [stderr] 83 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/inotify.rs:33:21 [INFO] [stderr] | [INFO] [stderr] 33 | / match logstate.handle_log(path_str) { [INFO] [stderr] 34 | | Err(e) => { println!("Error handling log: {}", e) }, [INFO] [stderr] 35 | | _ => (), [INFO] [stderr] 36 | | }; [INFO] [stderr] | |_____________________^ help: try this: `if let Err(e) = logstate.handle_log(path_str) { println!("Error handling log: {}", e) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/logrotate.rs:24:41 [INFO] [stderr] | [INFO] [stderr] 24 | let string = cstr.into_string().unwrap_or("Error parsing errno string".to_string()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| "Error parsing errno string".to_string())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:80:5 [INFO] [stderr] | [INFO] [stderr] 80 | / match watch_files(&args.files, args.num_old_logs, args.log_size) { [INFO] [stderr] 81 | | Err(e) => { [INFO] [stderr] 82 | | println!("Error watching files: {}", e); [INFO] [stderr] 83 | | process::exit(1); [INFO] [stderr] 84 | | }, [INFO] [stderr] 85 | | _ => (), [INFO] [stderr] 86 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 80 | if let Err(e) = watch_files(&args.files, args.num_old_logs, args.log_size) { [INFO] [stderr] 81 | println!("Error watching files: {}", e); [INFO] [stderr] 82 | process::exit(1); [INFO] [stderr] 83 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 4.37s [INFO] running `"docker" "inspect" "56e9e9fe702f21df452bbf7804dbb5ff3c60b1d56299c6d0b85eec6d20ba7dcc"` [INFO] running `"docker" "rm" "-f" "56e9e9fe702f21df452bbf7804dbb5ff3c60b1d56299c6d0b85eec6d20ba7dcc"` [INFO] [stdout] 56e9e9fe702f21df452bbf7804dbb5ff3c60b1d56299c6d0b85eec6d20ba7dcc