[INFO] crate logitech-lcd 2.0.0 is already in cache [INFO] extracting crate logitech-lcd 2.0.0 into work/ex/clippy-test-run/sources/stable/reg/logitech-lcd/2.0.0 [INFO] extracting crate logitech-lcd 2.0.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/logitech-lcd/2.0.0 [INFO] validating manifest of logitech-lcd-2.0.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of logitech-lcd-2.0.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing logitech-lcd-2.0.0 [INFO] finished frobbing logitech-lcd-2.0.0 [INFO] frobbed toml for logitech-lcd-2.0.0 written to work/ex/clippy-test-run/sources/stable/reg/logitech-lcd/2.0.0/Cargo.toml [INFO] started frobbing logitech-lcd-2.0.0 [INFO] finished frobbing logitech-lcd-2.0.0 [INFO] frobbed toml for logitech-lcd-2.0.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/logitech-lcd/2.0.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting logitech-lcd-2.0.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/logitech-lcd/2.0.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 73930c482418b2811d7c08ee28b63d6695b23084c1b7abe7c3b137f1693e6f06 [INFO] running `"docker" "start" "-a" "73930c482418b2811d7c08ee28b63d6695b23084c1b7abe7c3b137f1693e6f06"` [INFO] [stderr] Checking logitech-lcd-sys v2.0.0 [INFO] [stderr] Checking logitech-lcd v2.0.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:194:29 [INFO] [stderr] | [INFO] [stderr] 194 | type_flags: type_flags, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `type_flags` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:195:29 [INFO] [stderr] | [INFO] [stderr] 195 | lib: lib, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `lib` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:194:29 [INFO] [stderr] | [INFO] [stderr] 194 | type_flags: type_flags, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `type_flags` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:195:29 [INFO] [stderr] | [INFO] [stderr] 195 | lib: lib, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `lib` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/lib.rs:185:52 [INFO] [stderr] | [INFO] [stderr] 185 | let lib = sys::LogitechLcd::load().map_err(|e| Error::LoadLibrary(e))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Error::LoadLibrary` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/lib.rs:190:13 [INFO] [stderr] | [INFO] [stderr] 190 | / match (lib.LogiLcdInit)(ws.as_ptr(), type_flags.bits()) { [INFO] [stderr] 191 | | true => { [INFO] [stderr] 192 | | match (lib.LogiLcdIsConnected)(type_flags.bits()) { [INFO] [stderr] 193 | | true => Ok(Lcd { [INFO] [stderr] ... | [INFO] [stderr] 200 | | false => Err(Error::Initialization), [INFO] [stderr] 201 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] help: consider using an if/else expression [INFO] [stderr] | [INFO] [stderr] 190 | if (lib.LogiLcdInit)(ws.as_ptr(), type_flags.bits()) { [INFO] [stderr] 191 | match (lib.LogiLcdIsConnected)(type_flags.bits()) { [INFO] [stderr] 192 | true => Ok(Lcd { [INFO] [stderr] 193 | type_flags: type_flags, [INFO] [stderr] 194 | lib: lib, [INFO] [stderr] 195 | }), [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/lib.rs:192:21 [INFO] [stderr] | [INFO] [stderr] 192 | / match (lib.LogiLcdIsConnected)(type_flags.bits()) { [INFO] [stderr] 193 | | true => Ok(Lcd { [INFO] [stderr] 194 | | type_flags: type_flags, [INFO] [stderr] 195 | | lib: lib, [INFO] [stderr] 196 | | }), [INFO] [stderr] 197 | | false => Err(Error::NotConnected), [INFO] [stderr] 198 | | } [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] help: consider using an if/else expression [INFO] [stderr] | [INFO] [stderr] 192 | if (lib.LogiLcdIsConnected)(type_flags.bits()) { Ok(Lcd { [INFO] [stderr] 193 | type_flags: type_flags, [INFO] [stderr] 194 | lib: lib, [INFO] [stderr] 195 | }) } else { Err(Error::NotConnected) } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/lib.rs:296:13 [INFO] [stderr] | [INFO] [stderr] 296 | / match (self.lib.LogiLcdMonoSetBackground)(mono_bitmap.as_ptr()) { [INFO] [stderr] 297 | | true => Ok(()), [INFO] [stderr] 298 | | false => Err(Error::MonoBackground), [INFO] [stderr] 299 | | } [INFO] [stderr] | |_____________^ help: consider using an if/else expression: `if (self.lib.LogiLcdMonoSetBackground)(mono_bitmap.as_ptr()) { Ok(()) } else { Err(Error::MonoBackground) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/lib.rs:321:13 [INFO] [stderr] | [INFO] [stderr] 321 | / match (self.lib.LogiLcdMonoSetText)(line_number as c_int, ws.as_ptr()) { [INFO] [stderr] 322 | | true => Ok(()), [INFO] [stderr] 323 | | false => Err(Error::MonoText), [INFO] [stderr] 324 | | } [INFO] [stderr] | |_____________^ help: consider using an if/else expression: `if (self.lib.LogiLcdMonoSetText)(line_number as c_int, ws.as_ptr()) { Ok(()) } else { Err(Error::MonoText) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/lib.rs:343:13 [INFO] [stderr] | [INFO] [stderr] 343 | / match (self.lib.LogiLcdColorSetBackground)(color_bitmap.as_ptr()) { [INFO] [stderr] 344 | | true => Ok(()), [INFO] [stderr] 345 | | false => Err(Error::ColorBackground), [INFO] [stderr] 346 | | } [INFO] [stderr] | |_____________^ help: consider using an if/else expression: `if (self.lib.LogiLcdColorSetBackground)(color_bitmap.as_ptr()) { Ok(()) } else { Err(Error::ColorBackground) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/lib.rs:369:13 [INFO] [stderr] | [INFO] [stderr] 369 | / match (self.lib.LogiLcdColorSetTitle)(ws.as_ptr(), red as c_int, [INFO] [stderr] 370 | | green as c_int, blue as c_int) [INFO] [stderr] 371 | | { [INFO] [stderr] 372 | | true => Ok(()), [INFO] [stderr] 373 | | false => Err(Error::ColorTitle), [INFO] [stderr] 374 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] help: consider using an if/else expression [INFO] [stderr] | [INFO] [stderr] 369 | if (self.lib.LogiLcdColorSetTitle)(ws.as_ptr(), red as c_int, [INFO] [stderr] 370 | green as c_int, blue as c_int) { Ok(()) } else { Err(Error::ColorTitle) } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:369:64 [INFO] [stderr] | [INFO] [stderr] 369 | match (self.lib.LogiLcdColorSetTitle)(ws.as_ptr(), red as c_int, [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `i32::from(red)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:370:17 [INFO] [stderr] | [INFO] [stderr] 370 | green as c_int, blue as c_int) [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `i32::from(green)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:370:33 [INFO] [stderr] | [INFO] [stderr] 370 | green as c_int, blue as c_int) [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `i32::from(blue)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/lib.rs:400:13 [INFO] [stderr] | [INFO] [stderr] 400 | / match (self.lib.LogiLcdColorSetText)(line_number as c_int, [INFO] [stderr] 401 | | ws.as_ptr(), red as c_int, green as c_int, blue as c_int) [INFO] [stderr] 402 | | { [INFO] [stderr] 403 | | true => Ok(()), [INFO] [stderr] 404 | | false => Err(Error::ColorText), [INFO] [stderr] 405 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] help: consider using an if/else expression [INFO] [stderr] | [INFO] [stderr] 400 | if (self.lib.LogiLcdColorSetText)(line_number as c_int, [INFO] [stderr] 401 | ws.as_ptr(), red as c_int, green as c_int, blue as c_int) { Ok(()) } else { Err(Error::ColorText) } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:401:30 [INFO] [stderr] | [INFO] [stderr] 401 | ws.as_ptr(), red as c_int, green as c_int, blue as c_int) [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `i32::from(red)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:401:44 [INFO] [stderr] | [INFO] [stderr] 401 | ws.as_ptr(), red as c_int, green as c_int, blue as c_int) [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `i32::from(green)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:401:60 [INFO] [stderr] | [INFO] [stderr] 401 | ws.as_ptr(), red as c_int, green as c_int, blue as c_int) [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `i32::from(blue)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/lib.rs:185:52 [INFO] [stderr] | [INFO] [stderr] 185 | let lib = sys::LogitechLcd::load().map_err(|e| Error::LoadLibrary(e))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Error::LoadLibrary` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/lib.rs:190:13 [INFO] [stderr] | [INFO] [stderr] 190 | / match (lib.LogiLcdInit)(ws.as_ptr(), type_flags.bits()) { [INFO] [stderr] 191 | | true => { [INFO] [stderr] 192 | | match (lib.LogiLcdIsConnected)(type_flags.bits()) { [INFO] [stderr] 193 | | true => Ok(Lcd { [INFO] [stderr] ... | [INFO] [stderr] 200 | | false => Err(Error::Initialization), [INFO] [stderr] 201 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] help: consider using an if/else expression [INFO] [stderr] | [INFO] [stderr] 190 | if (lib.LogiLcdInit)(ws.as_ptr(), type_flags.bits()) { [INFO] [stderr] 191 | match (lib.LogiLcdIsConnected)(type_flags.bits()) { [INFO] [stderr] 192 | true => Ok(Lcd { [INFO] [stderr] 193 | type_flags: type_flags, [INFO] [stderr] 194 | lib: lib, [INFO] [stderr] 195 | }), [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/lib.rs:192:21 [INFO] [stderr] | [INFO] [stderr] 192 | / match (lib.LogiLcdIsConnected)(type_flags.bits()) { [INFO] [stderr] 193 | | true => Ok(Lcd { [INFO] [stderr] 194 | | type_flags: type_flags, [INFO] [stderr] 195 | | lib: lib, [INFO] [stderr] 196 | | }), [INFO] [stderr] 197 | | false => Err(Error::NotConnected), [INFO] [stderr] 198 | | } [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] help: consider using an if/else expression [INFO] [stderr] | [INFO] [stderr] 192 | if (lib.LogiLcdIsConnected)(type_flags.bits()) { Ok(Lcd { [INFO] [stderr] 193 | type_flags: type_flags, [INFO] [stderr] 194 | lib: lib, [INFO] [stderr] 195 | }) } else { Err(Error::NotConnected) } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/lib.rs:296:13 [INFO] [stderr] | [INFO] [stderr] 296 | / match (self.lib.LogiLcdMonoSetBackground)(mono_bitmap.as_ptr()) { [INFO] [stderr] 297 | | true => Ok(()), [INFO] [stderr] 298 | | false => Err(Error::MonoBackground), [INFO] [stderr] 299 | | } [INFO] [stderr] | |_____________^ help: consider using an if/else expression: `if (self.lib.LogiLcdMonoSetBackground)(mono_bitmap.as_ptr()) { Ok(()) } else { Err(Error::MonoBackground) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/lib.rs:321:13 [INFO] [stderr] | [INFO] [stderr] 321 | / match (self.lib.LogiLcdMonoSetText)(line_number as c_int, ws.as_ptr()) { [INFO] [stderr] 322 | | true => Ok(()), [INFO] [stderr] 323 | | false => Err(Error::MonoText), [INFO] [stderr] 324 | | } [INFO] [stderr] | |_____________^ help: consider using an if/else expression: `if (self.lib.LogiLcdMonoSetText)(line_number as c_int, ws.as_ptr()) { Ok(()) } else { Err(Error::MonoText) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/lib.rs:343:13 [INFO] [stderr] | [INFO] [stderr] 343 | / match (self.lib.LogiLcdColorSetBackground)(color_bitmap.as_ptr()) { [INFO] [stderr] 344 | | true => Ok(()), [INFO] [stderr] 345 | | false => Err(Error::ColorBackground), [INFO] [stderr] 346 | | } [INFO] [stderr] | |_____________^ help: consider using an if/else expression: `if (self.lib.LogiLcdColorSetBackground)(color_bitmap.as_ptr()) { Ok(()) } else { Err(Error::ColorBackground) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/lib.rs:369:13 [INFO] [stderr] | [INFO] [stderr] 369 | / match (self.lib.LogiLcdColorSetTitle)(ws.as_ptr(), red as c_int, [INFO] [stderr] 370 | | green as c_int, blue as c_int) [INFO] [stderr] 371 | | { [INFO] [stderr] 372 | | true => Ok(()), [INFO] [stderr] 373 | | false => Err(Error::ColorTitle), [INFO] [stderr] 374 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] help: consider using an if/else expression [INFO] [stderr] | [INFO] [stderr] 369 | if (self.lib.LogiLcdColorSetTitle)(ws.as_ptr(), red as c_int, [INFO] [stderr] 370 | green as c_int, blue as c_int) { Ok(()) } else { Err(Error::ColorTitle) } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:369:64 [INFO] [stderr] | [INFO] [stderr] 369 | match (self.lib.LogiLcdColorSetTitle)(ws.as_ptr(), red as c_int, [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `i32::from(red)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:370:17 [INFO] [stderr] | [INFO] [stderr] 370 | green as c_int, blue as c_int) [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `i32::from(green)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:370:33 [INFO] [stderr] | [INFO] [stderr] 370 | green as c_int, blue as c_int) [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `i32::from(blue)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/lib.rs:400:13 [INFO] [stderr] | [INFO] [stderr] 400 | / match (self.lib.LogiLcdColorSetText)(line_number as c_int, [INFO] [stderr] 401 | | ws.as_ptr(), red as c_int, green as c_int, blue as c_int) [INFO] [stderr] 402 | | { [INFO] [stderr] 403 | | true => Ok(()), [INFO] [stderr] 404 | | false => Err(Error::ColorText), [INFO] [stderr] 405 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] help: consider using an if/else expression [INFO] [stderr] | [INFO] [stderr] 400 | if (self.lib.LogiLcdColorSetText)(line_number as c_int, [INFO] [stderr] 401 | ws.as_ptr(), red as c_int, green as c_int, blue as c_int) { Ok(()) } else { Err(Error::ColorText) } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:401:30 [INFO] [stderr] | [INFO] [stderr] 401 | ws.as_ptr(), red as c_int, green as c_int, blue as c_int) [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `i32::from(red)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:401:44 [INFO] [stderr] | [INFO] [stderr] 401 | ws.as_ptr(), red as c_int, green as c_int, blue as c_int) [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `i32::from(green)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:401:60 [INFO] [stderr] | [INFO] [stderr] 401 | ws.as_ptr(), red as c_int, green as c_int, blue as c_int) [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `i32::from(blue)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> examples/mono-threaded.rs:12:9 [INFO] [stderr] | [INFO] [stderr] 12 | / match i % 2 == 0 { [INFO] [stderr] 13 | | true => lcd.set_mono_background(blank).unwrap(), [INFO] [stderr] 14 | | false => lcd.set_mono_background(filled).unwrap(), [INFO] [stderr] 15 | | } [INFO] [stderr] | |_________^ help: consider using an if/else expression: `if i % 2 == 0 { lcd.set_mono_background(blank).unwrap() } else { lcd.set_mono_background(filled).unwrap() }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> examples/mono-blink.rs:16:9 [INFO] [stderr] | [INFO] [stderr] 16 | / match lcd.is_button_pressed(LcdButton::MONO_BUTTON) { [INFO] [stderr] 17 | | true => lcd.set_mono_background(&filled_screen[..]).unwrap(), [INFO] [stderr] 18 | | false => lcd.set_mono_background(&blank_screen[..]).unwrap(), [INFO] [stderr] 19 | | } [INFO] [stderr] | |_________^ help: consider using an if/else expression: `if lcd.is_button_pressed(LcdButton::MONO_BUTTON) { lcd.set_mono_background(&filled_screen[..]).unwrap() } else { lcd.set_mono_background(&blank_screen[..]).unwrap() }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `i` [INFO] [stderr] --> examples/color-image.rs:25:65 [INFO] [stderr] | [INFO] [stderr] 25 | let mut b = Rgba::from_channels(buf[i+2], buf[i+1], buf[i+0], buf[i+3]); [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_op)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 4.94s [INFO] running `"docker" "inspect" "73930c482418b2811d7c08ee28b63d6695b23084c1b7abe7c3b137f1693e6f06"` [INFO] running `"docker" "rm" "-f" "73930c482418b2811d7c08ee28b63d6695b23084c1b7abe7c3b137f1693e6f06"` [INFO] [stdout] 73930c482418b2811d7c08ee28b63d6695b23084c1b7abe7c3b137f1693e6f06