[INFO] crate log 0.4.6 is already in cache [INFO] extracting crate log 0.4.6 into work/ex/clippy-test-run/sources/stable/reg/log/0.4.6 [INFO] extracting crate log 0.4.6 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/log/0.4.6 [INFO] validating manifest of log-0.4.6 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of log-0.4.6 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing log-0.4.6 [INFO] removed 1 missing tests [INFO] finished frobbing log-0.4.6 [INFO] frobbed toml for log-0.4.6 written to work/ex/clippy-test-run/sources/stable/reg/log/0.4.6/Cargo.toml [INFO] started frobbing log-0.4.6 [INFO] removed 1 missing tests [INFO] finished frobbing log-0.4.6 [INFO] frobbed toml for log-0.4.6 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/log/0.4.6/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting log-0.4.6 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/log/0.4.6:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 9a95a060e57211e83d1233e852e13e26a0f32c302841cf027cd77213621bfc95 [INFO] running `"docker" "start" "-a" "9a95a060e57211e83d1233e852e13e26a0f32c302841cf027cd77213621bfc95"` [INFO] [stderr] warning: An explicit [[test]] section is specified in Cargo.toml which currently [INFO] [stderr] disables Cargo from automatically inferring other test targets. [INFO] [stderr] This inference behavior will change in the Rust 2018 edition and the following [INFO] [stderr] files will be included as a test target: [INFO] [stderr] [INFO] [stderr] * /opt/crater/workdir/tests/filters.rs [INFO] [stderr] [INFO] [stderr] This is likely to break cargo build or cargo test as these files may not be [INFO] [stderr] ready to be compiled as a test target today. You can future-proof yourself [INFO] [stderr] and disable this warning by adding `autotests = false` to your [package] [INFO] [stderr] section. You may also move the files to a location where Cargo would not [INFO] [stderr] automatically infer them to be a target, such as in subfolders. [INFO] [stderr] [INFO] [stderr] For more information on this warning you can consult [INFO] [stderr] https://github.com/rust-lang/cargo/issues/5330 [INFO] [stderr] Checking log v0.4.6 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/serde.rs:192:13 [INFO] [stderr] | [INFO] [stderr] 192 | variant: variant, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `variant` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/serde.rs:207:13 [INFO] [stderr] | [INFO] [stderr] 207 | variant: variant, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `variant` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/serde.rs:192:13 [INFO] [stderr] | [INFO] [stderr] 192 | variant: variant, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `variant` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/serde.rs:207:13 [INFO] [stderr] | [INFO] [stderr] 207 | variant: variant, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `variant` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] error: you are deriving `Hash` but have implemented `PartialEq` explicitly [INFO] [stderr] --> src/lib.rs:329:27 [INFO] [stderr] | [INFO] [stderr] 329 | #[derive(Copy, Eq, Debug, Hash)] [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::derive_hash_xor_eq)] on by default [INFO] [stderr] note: `PartialEq` implemented here [INFO] [stderr] --> src/lib.rs:360:1 [INFO] [stderr] | [INFO] [stderr] 360 | / impl PartialEq for Level { [INFO] [stderr] 361 | | #[inline] [INFO] [stderr] 362 | | fn eq(&self, other: &Level) -> bool { [INFO] [stderr] 363 | | *self as usize == *other as usize [INFO] [stderr] 364 | | } [INFO] [stderr] 365 | | } [INFO] [stderr] | |_^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derive_hash_xor_eq [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/lib.rs:503:28 [INFO] [stderr] | [INFO] [stderr] 503 | pub fn to_level_filter(&self) -> LevelFilter { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] error: you are deriving `Hash` but have implemented `PartialEq` explicitly [INFO] [stderr] --> src/lib.rs:517:27 [INFO] [stderr] | [INFO] [stderr] 517 | #[derive(Copy, Eq, Debug, Hash)] [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] note: `PartialEq` implemented here [INFO] [stderr] --> src/lib.rs:542:1 [INFO] [stderr] | [INFO] [stderr] 542 | / impl PartialEq for LevelFilter { [INFO] [stderr] 543 | | #[inline] [INFO] [stderr] 544 | | fn eq(&self, other: &LevelFilter) -> bool { [INFO] [stderr] 545 | | *self as usize == *other as usize [INFO] [stderr] 546 | | } [INFO] [stderr] 547 | | } [INFO] [stderr] | |_^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derive_hash_xor_eq [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/lib.rs:658:21 [INFO] [stderr] | [INFO] [stderr] 658 | pub fn to_level(&self) -> Option { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `RecordBuilder<'a>` [INFO] [stderr] --> src/lib.rs:827:5 [INFO] [stderr] | [INFO] [stderr] 827 | / pub fn new() -> RecordBuilder<'a> { [INFO] [stderr] 828 | | RecordBuilder { [INFO] [stderr] 829 | | record: Record { [INFO] [stderr] 830 | | args: format_args!(""), [INFO] [stderr] ... | [INFO] [stderr] 836 | | } [INFO] [stderr] 837 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 813 | impl Default for RecordBuilder<'a> { [INFO] [stderr] 814 | fn default() -> Self { [INFO] [stderr] 815 | Self::new() [INFO] [stderr] 816 | } [INFO] [stderr] 817 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `MetadataBuilder<'a>` [INFO] [stderr] --> src/lib.rs:991:5 [INFO] [stderr] | [INFO] [stderr] 991 | / pub fn new() -> MetadataBuilder<'a> { [INFO] [stderr] 992 | | MetadataBuilder { [INFO] [stderr] 993 | | metadata: Metadata { [INFO] [stderr] 994 | | level: Level::Info, [INFO] [stderr] ... | [INFO] [stderr] 997 | | } [INFO] [stderr] 998 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 983 | impl Default for MetadataBuilder<'a> { [INFO] [stderr] 984 | fn default() -> Self { [INFO] [stderr] 985 | Self::new() [INFO] [stderr] 986 | } [INFO] [stderr] 987 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] error: aborting due to 2 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `log`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: you are deriving `Hash` but have implemented `PartialEq` explicitly [INFO] [stderr] --> src/lib.rs:329:27 [INFO] [stderr] | [INFO] [stderr] 329 | #[derive(Copy, Eq, Debug, Hash)] [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::derive_hash_xor_eq)] on by default [INFO] [stderr] note: `PartialEq` implemented here [INFO] [stderr] --> src/lib.rs:360:1 [INFO] [stderr] | [INFO] [stderr] 360 | / impl PartialEq for Level { [INFO] [stderr] 361 | | #[inline] [INFO] [stderr] 362 | | fn eq(&self, other: &Level) -> bool { [INFO] [stderr] 363 | | *self as usize == *other as usize [INFO] [stderr] 364 | | } [INFO] [stderr] 365 | | } [INFO] [stderr] | |_^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derive_hash_xor_eq [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/lib.rs:503:28 [INFO] [stderr] | [INFO] [stderr] 503 | pub fn to_level_filter(&self) -> LevelFilter { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] error: you are deriving `Hash` but have implemented `PartialEq` explicitly [INFO] [stderr] --> src/lib.rs:517:27 [INFO] [stderr] | [INFO] [stderr] 517 | #[derive(Copy, Eq, Debug, Hash)] [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] note: `PartialEq` implemented here [INFO] [stderr] --> src/lib.rs:542:1 [INFO] [stderr] | [INFO] [stderr] 542 | / impl PartialEq for LevelFilter { [INFO] [stderr] 543 | | #[inline] [INFO] [stderr] 544 | | fn eq(&self, other: &LevelFilter) -> bool { [INFO] [stderr] 545 | | *self as usize == *other as usize [INFO] [stderr] 546 | | } [INFO] [stderr] 547 | | } [INFO] [stderr] | |_^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derive_hash_xor_eq [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/lib.rs:658:21 [INFO] [stderr] | [INFO] [stderr] 658 | pub fn to_level(&self) -> Option { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `RecordBuilder<'a>` [INFO] [stderr] --> src/lib.rs:827:5 [INFO] [stderr] | [INFO] [stderr] 827 | / pub fn new() -> RecordBuilder<'a> { [INFO] [stderr] 828 | | RecordBuilder { [INFO] [stderr] 829 | | record: Record { [INFO] [stderr] 830 | | args: format_args!(""), [INFO] [stderr] ... | [INFO] [stderr] 836 | | } [INFO] [stderr] 837 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 813 | impl Default for RecordBuilder<'a> { [INFO] [stderr] 814 | fn default() -> Self { [INFO] [stderr] 815 | Self::new() [INFO] [stderr] 816 | } [INFO] [stderr] 817 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `MetadataBuilder<'a>` [INFO] [stderr] --> src/lib.rs:991:5 [INFO] [stderr] | [INFO] [stderr] 991 | / pub fn new() -> MetadataBuilder<'a> { [INFO] [stderr] 992 | | MetadataBuilder { [INFO] [stderr] 993 | | metadata: Metadata { [INFO] [stderr] 994 | | level: Level::Info, [INFO] [stderr] ... | [INFO] [stderr] 997 | | } [INFO] [stderr] 998 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 983 | impl Default for MetadataBuilder<'a> { [INFO] [stderr] 984 | fn default() -> Self { [INFO] [stderr] 985 | Self::new() [INFO] [stderr] 986 | } [INFO] [stderr] 987 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] error: aborting due to 2 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `log`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "9a95a060e57211e83d1233e852e13e26a0f32c302841cf027cd77213621bfc95"` [INFO] running `"docker" "rm" "-f" "9a95a060e57211e83d1233e852e13e26a0f32c302841cf027cd77213621bfc95"` [INFO] [stdout] 9a95a060e57211e83d1233e852e13e26a0f32c302841cf027cd77213621bfc95