[INFO] crate lockfree 0.5.1 is already in cache [INFO] extracting crate lockfree 0.5.1 into work/ex/clippy-test-run/sources/stable/reg/lockfree/0.5.1 [INFO] extracting crate lockfree 0.5.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/lockfree/0.5.1 [INFO] validating manifest of lockfree-0.5.1 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of lockfree-0.5.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing lockfree-0.5.1 [INFO] finished frobbing lockfree-0.5.1 [INFO] frobbed toml for lockfree-0.5.1 written to work/ex/clippy-test-run/sources/stable/reg/lockfree/0.5.1/Cargo.toml [INFO] started frobbing lockfree-0.5.1 [INFO] finished frobbing lockfree-0.5.1 [INFO] frobbed toml for lockfree-0.5.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/lockfree/0.5.1/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting lockfree-0.5.1 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/lockfree/0.5.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] f93b053495fdf71738e9d76a60478ff4847300e74f9cfd400c7889c0138bf0d2 [INFO] running `"docker" "start" "-a" "f93b053495fdf71738e9d76a60478ff4847300e74f9cfd400c7889c0138bf0d2"` [INFO] [stderr] Checking owned-alloc v0.2.0 [INFO] [stderr] Checking lockfree v0.5.1 (/opt/crater/workdir) [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/tls/mod.rs:378:50 [INFO] [stderr] | [INFO] [stderr] 378 | write!(fmtr, "ThreadLocal {} storage: ", '{')?; [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::write_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_literal [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/tls/mod.rs:383:28 [INFO] [stderr] | [INFO] [stderr] 383 | write!(fmtr, "{}", '}') [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_literal [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/tls/mod.rs:557:13 [INFO] [stderr] | [INFO] [stderr] 557 | '{', self.tables, self.curr_table, '}' [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_literal [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/tls/mod.rs:557:48 [INFO] [stderr] | [INFO] [stderr] 557 | '{', self.tables, self.curr_table, '}' [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_literal [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/tls/mod.rs:623:13 [INFO] [stderr] | [INFO] [stderr] 623 | '{', self.tables, self.curr_table, '}' [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_literal [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/tls/mod.rs:623:48 [INFO] [stderr] | [INFO] [stderr] 623 | '{', self.tables, self.curr_table, '}' [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_literal [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/tls/mod.rs:659:50 [INFO] [stderr] | [INFO] [stderr] 659 | write!(fmtr, "Node {} pointer: {:?} {}", '{', self.atomic, '}') [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_literal [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/tls/mod.rs:659:68 [INFO] [stderr] | [INFO] [stderr] 659 | write!(fmtr, "Node {} pointer: {:?} {}", '{', self.atomic, '}') [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_literal [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/tls/mod.rs:713:13 [INFO] [stderr] | [INFO] [stderr] 713 | '{', &self.nodes as &[Node], '}' [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_literal [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/tls/mod.rs:713:45 [INFO] [stderr] | [INFO] [stderr] 713 | '{', &self.nodes as &[Node], '}' [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_literal [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/queue.rs:231:13 [INFO] [stderr] | [INFO] [stderr] 231 | '{', self.front, self.back, self.incin, '}' [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_literal [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/queue.rs:231:53 [INFO] [stderr] | [INFO] [stderr] 231 | '{', self.front, self.back, self.incin, '}' [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_literal [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/queue.rs:257:51 [INFO] [stderr] | [INFO] [stderr] 257 | write!(fmtr, "PopIter {} queue: {:?} {}", '{', self.queue, '}') [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_literal [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/queue.rs:257:68 [INFO] [stderr] | [INFO] [stderr] 257 | write!(fmtr, "PopIter {} queue: {:?} {}", '{', self.queue, '}') [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_literal [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/queue.rs:268:55 [INFO] [stderr] | [INFO] [stderr] 268 | write!(fmtr, "SharedIncin {} inner: {:?} {}", '{', self.inner, '}') [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_literal [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/queue.rs:268:72 [INFO] [stderr] | [INFO] [stderr] 268 | write!(fmtr, "SharedIncin {} inner: {:?} {}", '{', self.inner, '}') [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_literal [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/stack.rs:174:13 [INFO] [stderr] | [INFO] [stderr] 174 | '{', self.top, self.incin, '}' [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_literal [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/stack.rs:174:40 [INFO] [stderr] | [INFO] [stderr] 174 | '{', self.top, self.incin, '}' [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_literal [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/stack.rs:200:51 [INFO] [stderr] | [INFO] [stderr] 200 | write!(fmtr, "PopIter {} stack: {:?} {}", '{', self.stack, '}') [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_literal [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/stack.rs:200:68 [INFO] [stderr] | [INFO] [stderr] 200 | write!(fmtr, "PopIter {} stack: {:?} {}", '{', self.stack, '}') [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_literal [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/stack.rs:211:55 [INFO] [stderr] | [INFO] [stderr] 211 | write!(fmtr, "SharedIncin {} inner: {:?} {}", '{', self.inner, '}') [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_literal [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/stack.rs:211:72 [INFO] [stderr] | [INFO] [stderr] 211 | write!(fmtr, "SharedIncin {} inner: {:?} {}", '{', self.inner, '}') [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_literal [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/map/table.rs:493:13 [INFO] [stderr] | [INFO] [stderr] 493 | '{', &self.nodes as &[Node], '}' [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_literal [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/map/table.rs:493:48 [INFO] [stderr] | [INFO] [stderr] 493 | '{', &self.nodes as &[Node], '}' [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_literal [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/map/table.rs:537:50 [INFO] [stderr] | [INFO] [stderr] 537 | write!(fmtr, "Node {} pointer: {:?} {}", '{', self.atomic, '}') [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_literal [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/map/table.rs:537:68 [INFO] [stderr] | [INFO] [stderr] 537 | write!(fmtr, "Node {} pointer: {:?} {}", '{', self.atomic, '}') [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_literal [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/map/iter.rs:209:13 [INFO] [stderr] | [INFO] [stderr] 209 | '{', self.tables, self.curr_table, self.entries, '}' [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_literal [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/map/iter.rs:209:62 [INFO] [stderr] | [INFO] [stderr] 209 | '{', self.tables, self.curr_table, self.entries, '}' [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_literal [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/map/iter.rs:327:13 [INFO] [stderr] | [INFO] [stderr] 327 | '{', self.tables, self.curr_table, self.entries, '}' [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_literal [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/map/iter.rs:327:62 [INFO] [stderr] | [INFO] [stderr] 327 | '{', self.tables, self.curr_table, self.entries, '}' [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_literal [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/map/mod.rs:398:13 [INFO] [stderr] | [INFO] [stderr] 398 | '{', self.top, self.incin.inner, self.builder, '}' [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_literal [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/map/mod.rs:398:60 [INFO] [stderr] | [INFO] [stderr] 398 | '{', self.top, self.incin.inner, self.builder, '}' [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_literal [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/map/mod.rs:508:55 [INFO] [stderr] | [INFO] [stderr] 508 | write!(fmtr, "SharedIncin {} inner: {:?} {}", '{', self.inner, '}') [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_literal [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/map/mod.rs:508:72 [INFO] [stderr] | [INFO] [stderr] 508 | write!(fmtr, "SharedIncin {} inner: {:?} {}", '{', self.inner, '}') [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_literal [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/set.rs:271:51 [INFO] [stderr] | [INFO] [stderr] 271 | write!(fmtr, "Set {} inner_map: {:?} {}", '{', self.inner, '}') [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_literal [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/set.rs:271:68 [INFO] [stderr] | [INFO] [stderr] 271 | write!(fmtr, "Set {} inner_map: {:?} {}", '{', self.inner, '}') [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_literal [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/set.rs:574:52 [INFO] [stderr] | [INFO] [stderr] 574 | write!(fmtr, "IntoIter {} inner: {:?} {}", '{', self.inner, '}') [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_literal [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/set.rs:574:69 [INFO] [stderr] | [INFO] [stderr] 574 | write!(fmtr, "IntoIter {} inner: {:?} {}", '{', self.inner, '}') [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_literal [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/channel/mpsc.rs:156:54 [INFO] [stderr] | [INFO] [stderr] 156 | write!(fmtr, "spmc::Sender {} ptr: {:p} {}", '{', self.inner, '}') [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_literal [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/channel/mpsc.rs:156:71 [INFO] [stderr] | [INFO] [stderr] 156 | write!(fmtr, "spmc::Sender {} ptr: {:p} {}", '{', self.inner, '}') [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_literal [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/channel/spmc.rs:261:56 [INFO] [stderr] | [INFO] [stderr] 261 | write!(fmtr, "spmc::Receiver {} ptr: {:p} {}", '{', self.inner, '}') [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_literal [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/channel/spmc.rs:261:73 [INFO] [stderr] | [INFO] [stderr] 261 | write!(fmtr, "spmc::Receiver {} ptr: {:p} {}", '{', self.inner, '}') [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_literal [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/channel/mpmc.rs:170:54 [INFO] [stderr] | [INFO] [stderr] 170 | write!(fmtr, "spmc::Sender {} ptr: {:p} {}", '{', self.inner, '}') [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_literal [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/channel/mpmc.rs:170:71 [INFO] [stderr] | [INFO] [stderr] 170 | write!(fmtr, "spmc::Sender {} ptr: {:p} {}", '{', self.inner, '}') [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_literal [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/channel/mpmc.rs:298:56 [INFO] [stderr] | [INFO] [stderr] 298 | write!(fmtr, "spmc::Receiver {} ptr: {:p} {}", '{', self.inner, '}') [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_literal [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/channel/mpmc.rs:298:73 [INFO] [stderr] | [INFO] [stderr] 298 | write!(fmtr, "spmc::Receiver {} ptr: {:p} {}", '{', self.inner, '}') [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_literal [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/removable.rs:99:13 [INFO] [stderr] | [INFO] [stderr] 99 | '{', [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_literal [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/removable.rs:101:13 [INFO] [stderr] | [INFO] [stderr] 101 | '}' [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_literal [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/tls/mod.rs:378:50 [INFO] [stderr] | [INFO] [stderr] 378 | write!(fmtr, "ThreadLocal {} storage: ", '{')?; [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::write_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_literal [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/tls/mod.rs:383:28 [INFO] [stderr] | [INFO] [stderr] 383 | write!(fmtr, "{}", '}') [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_literal [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/tls/mod.rs:557:13 [INFO] [stderr] | [INFO] [stderr] 557 | '{', self.tables, self.curr_table, '}' [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_literal [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/tls/mod.rs:557:48 [INFO] [stderr] | [INFO] [stderr] 557 | '{', self.tables, self.curr_table, '}' [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_literal [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/tls/mod.rs:623:13 [INFO] [stderr] | [INFO] [stderr] 623 | '{', self.tables, self.curr_table, '}' [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_literal [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/tls/mod.rs:623:48 [INFO] [stderr] | [INFO] [stderr] 623 | '{', self.tables, self.curr_table, '}' [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_literal [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/tls/mod.rs:659:50 [INFO] [stderr] | [INFO] [stderr] 659 | write!(fmtr, "Node {} pointer: {:?} {}", '{', self.atomic, '}') [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_literal [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/tls/mod.rs:659:68 [INFO] [stderr] | [INFO] [stderr] 659 | write!(fmtr, "Node {} pointer: {:?} {}", '{', self.atomic, '}') [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_literal [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/tls/mod.rs:713:13 [INFO] [stderr] | [INFO] [stderr] 713 | '{', &self.nodes as &[Node], '}' [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_literal [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/tls/mod.rs:713:45 [INFO] [stderr] | [INFO] [stderr] 713 | '{', &self.nodes as &[Node], '}' [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_literal [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/queue.rs:231:13 [INFO] [stderr] | [INFO] [stderr] 231 | '{', self.front, self.back, self.incin, '}' [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_literal [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/queue.rs:231:53 [INFO] [stderr] | [INFO] [stderr] 231 | '{', self.front, self.back, self.incin, '}' [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_literal [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/queue.rs:257:51 [INFO] [stderr] | [INFO] [stderr] 257 | write!(fmtr, "PopIter {} queue: {:?} {}", '{', self.queue, '}') [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_literal [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/queue.rs:257:68 [INFO] [stderr] | [INFO] [stderr] 257 | write!(fmtr, "PopIter {} queue: {:?} {}", '{', self.queue, '}') [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_literal [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/queue.rs:268:55 [INFO] [stderr] | [INFO] [stderr] 268 | write!(fmtr, "SharedIncin {} inner: {:?} {}", '{', self.inner, '}') [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_literal [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/queue.rs:268:72 [INFO] [stderr] | [INFO] [stderr] 268 | write!(fmtr, "SharedIncin {} inner: {:?} {}", '{', self.inner, '}') [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_literal [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/stack.rs:174:13 [INFO] [stderr] | [INFO] [stderr] 174 | '{', self.top, self.incin, '}' [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_literal [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/stack.rs:174:40 [INFO] [stderr] | [INFO] [stderr] 174 | '{', self.top, self.incin, '}' [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_literal [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/stack.rs:200:51 [INFO] [stderr] | [INFO] [stderr] 200 | write!(fmtr, "PopIter {} stack: {:?} {}", '{', self.stack, '}') [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_literal [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/stack.rs:200:68 [INFO] [stderr] | [INFO] [stderr] 200 | write!(fmtr, "PopIter {} stack: {:?} {}", '{', self.stack, '}') [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_literal [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/stack.rs:211:55 [INFO] [stderr] | [INFO] [stderr] 211 | write!(fmtr, "SharedIncin {} inner: {:?} {}", '{', self.inner, '}') [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_literal [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/stack.rs:211:72 [INFO] [stderr] | [INFO] [stderr] 211 | write!(fmtr, "SharedIncin {} inner: {:?} {}", '{', self.inner, '}') [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_literal [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/map/table.rs:493:13 [INFO] [stderr] | [INFO] [stderr] 493 | '{', &self.nodes as &[Node], '}' [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_literal [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/map/table.rs:493:48 [INFO] [stderr] | [INFO] [stderr] 493 | '{', &self.nodes as &[Node], '}' [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_literal [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/map/table.rs:537:50 [INFO] [stderr] | [INFO] [stderr] 537 | write!(fmtr, "Node {} pointer: {:?} {}", '{', self.atomic, '}') [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_literal [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/map/table.rs:537:68 [INFO] [stderr] | [INFO] [stderr] 537 | write!(fmtr, "Node {} pointer: {:?} {}", '{', self.atomic, '}') [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_literal [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/map/iter.rs:209:13 [INFO] [stderr] | [INFO] [stderr] 209 | '{', self.tables, self.curr_table, self.entries, '}' [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_literal [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/map/iter.rs:209:62 [INFO] [stderr] | [INFO] [stderr] 209 | '{', self.tables, self.curr_table, self.entries, '}' [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_literal [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/map/iter.rs:327:13 [INFO] [stderr] | [INFO] [stderr] 327 | '{', self.tables, self.curr_table, self.entries, '}' [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_literal [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/map/iter.rs:327:62 [INFO] [stderr] | [INFO] [stderr] 327 | '{', self.tables, self.curr_table, self.entries, '}' [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_literal [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/map/mod.rs:398:13 [INFO] [stderr] | [INFO] [stderr] 398 | '{', self.top, self.incin.inner, self.builder, '}' [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_literal [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/map/mod.rs:398:60 [INFO] [stderr] | [INFO] [stderr] 398 | '{', self.top, self.incin.inner, self.builder, '}' [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_literal [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/map/mod.rs:508:55 [INFO] [stderr] | [INFO] [stderr] 508 | write!(fmtr, "SharedIncin {} inner: {:?} {}", '{', self.inner, '}') [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_literal [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/map/mod.rs:508:72 [INFO] [stderr] | [INFO] [stderr] 508 | write!(fmtr, "SharedIncin {} inner: {:?} {}", '{', self.inner, '}') [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_literal [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/set.rs:271:51 [INFO] [stderr] | [INFO] [stderr] 271 | write!(fmtr, "Set {} inner_map: {:?} {}", '{', self.inner, '}') [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_literal [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/set.rs:271:68 [INFO] [stderr] | [INFO] [stderr] 271 | write!(fmtr, "Set {} inner_map: {:?} {}", '{', self.inner, '}') [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_literal [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/set.rs:574:52 [INFO] [stderr] | [INFO] [stderr] 574 | write!(fmtr, "IntoIter {} inner: {:?} {}", '{', self.inner, '}') [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_literal [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/set.rs:574:69 [INFO] [stderr] | [INFO] [stderr] 574 | write!(fmtr, "IntoIter {} inner: {:?} {}", '{', self.inner, '}') [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_literal [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/channel/mpsc.rs:156:54 [INFO] [stderr] | [INFO] [stderr] 156 | write!(fmtr, "spmc::Sender {} ptr: {:p} {}", '{', self.inner, '}') [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_literal [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/channel/mpsc.rs:156:71 [INFO] [stderr] | [INFO] [stderr] 156 | write!(fmtr, "spmc::Sender {} ptr: {:p} {}", '{', self.inner, '}') [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_literal [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/channel/spmc.rs:261:56 [INFO] [stderr] | [INFO] [stderr] 261 | write!(fmtr, "spmc::Receiver {} ptr: {:p} {}", '{', self.inner, '}') [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_literal [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/channel/spmc.rs:261:73 [INFO] [stderr] | [INFO] [stderr] 261 | write!(fmtr, "spmc::Receiver {} ptr: {:p} {}", '{', self.inner, '}') [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_literal [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/channel/mpmc.rs:170:54 [INFO] [stderr] | [INFO] [stderr] 170 | write!(fmtr, "spmc::Sender {} ptr: {:p} {}", '{', self.inner, '}') [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_literal [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/channel/mpmc.rs:170:71 [INFO] [stderr] | [INFO] [stderr] 170 | write!(fmtr, "spmc::Sender {} ptr: {:p} {}", '{', self.inner, '}') [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_literal [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/channel/mpmc.rs:298:56 [INFO] [stderr] | [INFO] [stderr] 298 | write!(fmtr, "spmc::Receiver {} ptr: {:p} {}", '{', self.inner, '}') [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_literal [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/channel/mpmc.rs:298:73 [INFO] [stderr] | [INFO] [stderr] 298 | write!(fmtr, "spmc::Receiver {} ptr: {:p} {}", '{', self.inner, '}') [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_literal [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/removable.rs:99:13 [INFO] [stderr] | [INFO] [stderr] 99 | '{', [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_literal [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/removable.rs:101:13 [INFO] [stderr] | [INFO] [stderr] 101 | '}' [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_literal [INFO] [stderr] [INFO] [stderr] warning: operator precedence can trip the unwary [INFO] [stderr] --> src/tls/mod.rs:113:25 [INFO] [stderr] | [INFO] [stderr] 113 | let index = shifted & (1 << BITS) - 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider parenthesizing your expression: `shifted & ((1 << BITS) - 1)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::precedence)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence [INFO] [stderr] [INFO] [stderr] warning: operator precedence can trip the unwary [INFO] [stderr] --> src/tls/mod.rs:187:25 [INFO] [stderr] | [INFO] [stderr] 187 | let mut index = shifted & (1 << BITS) - 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider parenthesizing your expression: `shifted & ((1 << BITS) - 1)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence [INFO] [stderr] [INFO] [stderr] warning: operator precedence can trip the unwary [INFO] [stderr] --> src/tls/mod.rs:250:37 [INFO] [stderr] | [INFO] [stderr] 250 | let other_shifted = entry.id.bits() >> depth * BITS; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider parenthesizing your expression: `entry.id.bits() >> (depth * BITS)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence [INFO] [stderr] [INFO] [stderr] warning: operator precedence can trip the unwary [INFO] [stderr] --> src/tls/mod.rs:251:35 [INFO] [stderr] | [INFO] [stderr] 251 | let other_index = other_shifted & (1 << BITS) - 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider parenthesizing your expression: `other_shifted & ((1 << BITS) - 1)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence [INFO] [stderr] [INFO] [stderr] warning: operator precedence can trip the unwary [INFO] [stderr] --> src/tls/mod.rs:283:33 [INFO] [stderr] | [INFO] [stderr] 283 | index = shifted & (1 << BITS) - 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider parenthesizing your expression: `shifted & ((1 << BITS) - 1)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence [INFO] [stderr] [INFO] [stderr] warning: operator precedence can trip the unwary [INFO] [stderr] --> src/tls/mod.rs:326:25 [INFO] [stderr] | [INFO] [stderr] 326 | index = shifted & (1 << BITS) - 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider parenthesizing your expression: `shifted & ((1 << BITS) - 1)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence [INFO] [stderr] [INFO] [stderr] warning: operator precedence can trip the unwary [INFO] [stderr] --> src/map/table.rs:65:25 [INFO] [stderr] | [INFO] [stderr] 65 | let index = shifted as usize & (1 << BITS) - 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider parenthesizing your expression: `shifted as usize & ((1 << BITS) - 1)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence [INFO] [stderr] [INFO] [stderr] warning: operator precedence can trip the unwary [INFO] [stderr] --> src/map/table.rs:141:25 [INFO] [stderr] | [INFO] [stderr] 141 | let mut index = shifted as usize & (1 << BITS) - 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider parenthesizing your expression: `shifted as usize & ((1 << BITS) - 1)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence [INFO] [stderr] [INFO] [stderr] warning: operator precedence can trip the unwary [INFO] [stderr] --> src/map/table.rs:236:39 [INFO] [stderr] | [INFO] [stderr] 236 | let other_index = other_shifted as usize & (1 << BITS) - 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider parenthesizing your expression: `other_shifted as usize & ((1 << BITS) - 1)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence [INFO] [stderr] [INFO] [stderr] warning: operator precedence can trip the unwary [INFO] [stderr] --> src/map/table.rs:259:37 [INFO] [stderr] | [INFO] [stderr] 259 | index = shifted as usize & (1 << BITS) - 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider parenthesizing your expression: `shifted as usize & ((1 << BITS) - 1)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence [INFO] [stderr] [INFO] [stderr] warning: operator precedence can trip the unwary [INFO] [stderr] --> src/map/table.rs:291:25 [INFO] [stderr] | [INFO] [stderr] 291 | index = shifted as usize & (1 << BITS) - 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider parenthesizing your expression: `shifted as usize & ((1 << BITS) - 1)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence [INFO] [stderr] [INFO] [stderr] warning: operator precedence can trip the unwary [INFO] [stderr] --> src/map/table.rs:320:25 [INFO] [stderr] | [INFO] [stderr] 320 | let index = shifted as usize & (1 << BITS) - 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider parenthesizing your expression: `shifted as usize & ((1 << BITS) - 1)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence [INFO] [stderr] [INFO] [stderr] warning: operator precedence can trip the unwary [INFO] [stderr] --> src/tls/mod.rs:113:25 [INFO] [stderr] | [INFO] [stderr] 113 | let index = shifted & (1 << BITS) - 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider parenthesizing your expression: `shifted & ((1 << BITS) - 1)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::precedence)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence [INFO] [stderr] [INFO] [stderr] warning: operator precedence can trip the unwary [INFO] [stderr] --> src/tls/mod.rs:187:25 [INFO] [stderr] | [INFO] [stderr] 187 | let mut index = shifted & (1 << BITS) - 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider parenthesizing your expression: `shifted & ((1 << BITS) - 1)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence [INFO] [stderr] [INFO] [stderr] warning: operator precedence can trip the unwary [INFO] [stderr] --> src/tls/mod.rs:250:37 [INFO] [stderr] | [INFO] [stderr] 250 | let other_shifted = entry.id.bits() >> depth * BITS; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider parenthesizing your expression: `entry.id.bits() >> (depth * BITS)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence [INFO] [stderr] [INFO] [stderr] warning: operator precedence can trip the unwary [INFO] [stderr] --> src/tls/mod.rs:251:35 [INFO] [stderr] | [INFO] [stderr] 251 | let other_index = other_shifted & (1 << BITS) - 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider parenthesizing your expression: `other_shifted & ((1 << BITS) - 1)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence [INFO] [stderr] [INFO] [stderr] warning: operator precedence can trip the unwary [INFO] [stderr] --> src/tls/mod.rs:283:33 [INFO] [stderr] | [INFO] [stderr] 283 | index = shifted & (1 << BITS) - 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider parenthesizing your expression: `shifted & ((1 << BITS) - 1)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence [INFO] [stderr] [INFO] [stderr] warning: operator precedence can trip the unwary [INFO] [stderr] --> src/tls/mod.rs:326:25 [INFO] [stderr] | [INFO] [stderr] 326 | index = shifted & (1 << BITS) - 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider parenthesizing your expression: `shifted & ((1 << BITS) - 1)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence [INFO] [stderr] [INFO] [stderr] warning: operator precedence can trip the unwary [INFO] [stderr] --> src/map/table.rs:65:25 [INFO] [stderr] | [INFO] [stderr] 65 | let index = shifted as usize & (1 << BITS) - 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider parenthesizing your expression: `shifted as usize & ((1 << BITS) - 1)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence [INFO] [stderr] [INFO] [stderr] warning: operator precedence can trip the unwary [INFO] [stderr] --> src/map/table.rs:141:25 [INFO] [stderr] | [INFO] [stderr] 141 | let mut index = shifted as usize & (1 << BITS) - 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider parenthesizing your expression: `shifted as usize & ((1 << BITS) - 1)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence [INFO] [stderr] [INFO] [stderr] warning: operator precedence can trip the unwary [INFO] [stderr] --> src/map/table.rs:236:39 [INFO] [stderr] | [INFO] [stderr] 236 | let other_index = other_shifted as usize & (1 << BITS) - 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider parenthesizing your expression: `other_shifted as usize & ((1 << BITS) - 1)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence [INFO] [stderr] [INFO] [stderr] warning: operator precedence can trip the unwary [INFO] [stderr] --> src/map/table.rs:259:37 [INFO] [stderr] | [INFO] [stderr] 259 | index = shifted as usize & (1 << BITS) - 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider parenthesizing your expression: `shifted as usize & ((1 << BITS) - 1)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence [INFO] [stderr] [INFO] [stderr] warning: operator precedence can trip the unwary [INFO] [stderr] --> src/map/table.rs:291:25 [INFO] [stderr] | [INFO] [stderr] 291 | index = shifted as usize & (1 << BITS) - 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider parenthesizing your expression: `shifted as usize & ((1 << BITS) - 1)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence [INFO] [stderr] [INFO] [stderr] warning: operator precedence can trip the unwary [INFO] [stderr] --> src/map/table.rs:320:25 [INFO] [stderr] | [INFO] [stderr] 320 | let index = shifted as usize & (1 << BITS) - 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider parenthesizing your expression: `shifted as usize & ((1 << BITS) - 1)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/incin.rs:272:12 [INFO] [stderr] | [INFO] [stderr] 272 | if tmp.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!tmp.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/queue.rs:45:5 [INFO] [stderr] | [INFO] [stderr] 45 | / pub fn pop_iter<'queue>(&'queue self) -> PopIter<'queue, T> { [INFO] [stderr] 46 | | PopIter { queue: self } [INFO] [stderr] 47 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/stack.rs:34:5 [INFO] [stderr] | [INFO] [stderr] 34 | / pub fn pop_iter<'stack>(&'stack self) -> PopIter<'stack, T> { [INFO] [stderr] 35 | | PopIter { stack: self } [INFO] [stderr] 36 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: this loop could be written as a `for` loop [INFO] [stderr] --> src/stack.rs:127:29 [INFO] [stderr] | [INFO] [stderr] 127 | while let Some(_) = self.next() {} [INFO] [stderr] | ^^^^^^^^^^^ help: try: `for _ in self { .. }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::while_let_on_iterator)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_on_iterator [INFO] [stderr] [INFO] [stderr] error: casting from `*mut ()` to a more-strictly-aligned pointer (`*mut map::bucket::Bucket`) [INFO] [stderr] --> src/map/table.rs:75:32 [INFO] [stderr] | [INFO] [stderr] 75 | let bucket = &*(loaded as *mut Bucket); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::cast_ptr_alignment)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_ptr_alignment [INFO] [stderr] [INFO] [stderr] error: casting from `*mut ()` to a more-strictly-aligned pointer (`*mut map::bucket::Bucket`) [INFO] [stderr] --> src/map/table.rs:100:56 [INFO] [stderr] | [INFO] [stderr] 100 | NonNull::new_unchecked(loaded as *mut _), [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_ptr_alignment [INFO] [stderr] [INFO] [stderr] error: casting from `*mut ()` to a more-strictly-aligned pointer (`*mut map::bucket::Bucket`) [INFO] [stderr] --> src/map/table.rs:185:32 [INFO] [stderr] | [INFO] [stderr] 185 | let bucket = &*(loaded as *mut Bucket); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_ptr_alignment [INFO] [stderr] [INFO] [stderr] error: casting from `*mut ()` to a more-strictly-aligned pointer (`*mut map::bucket::Bucket`) [INFO] [stderr] --> src/map/table.rs:217:45 [INFO] [stderr] | [INFO] [stderr] 217 | loaded as *mut _, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_ptr_alignment [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/map/table.rs:234:55 [INFO] [stderr] | [INFO] [stderr] 234 | let new_table = tbl_cache.take_or(|| Self::new_alloc()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Self::new_alloc` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] error: casting from `*mut ()` to a more-strictly-aligned pointer (`*mut map::bucket::Bucket`) [INFO] [stderr] --> src/map/table.rs:331:32 [INFO] [stderr] | [INFO] [stderr] 331 | let bucket = &*(loaded as *mut Bucket); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_ptr_alignment [INFO] [stderr] [INFO] [stderr] error: casting from `*mut ()` to a more-strictly-aligned pointer (`*mut map::bucket::Bucket`) [INFO] [stderr] --> src/map/table.rs:352:52 [INFO] [stderr] | [INFO] [stderr] 352 | NonNull::new_unchecked(loaded as *mut _), [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_ptr_alignment [INFO] [stderr] [INFO] [stderr] error: casting from `*mut ()` to a more-strictly-aligned pointer (`*mut map::bucket::Bucket`) [INFO] [stderr] --> src/map/table.rs:403:34 [INFO] [stderr] | [INFO] [stderr] 403 | let bucket_ptr = loaded as *mut Bucket; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_ptr_alignment [INFO] [stderr] [INFO] [stderr] error: casting from `*mut ()` to a more-strictly-aligned pointer (`*mut map::bucket::Bucket`) [INFO] [stderr] --> src/map/table.rs:517:17 [INFO] [stderr] | [INFO] [stderr] 517 | ptr as *mut Bucket, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_ptr_alignment [INFO] [stderr] [INFO] [stderr] warning: Comparing with null is better expressed by the .is_null() method [INFO] [stderr] --> src/map/bucket.rs:464:27 [INFO] [stderr] | [INFO] [stderr] 464 | self.is_root() && self.next == null_mut() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cmp_null)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_null [INFO] [stderr] [INFO] [stderr] warning: this loop could be written as a `for` loop [INFO] [stderr] --> src/map/bucket.rs:671:29 [INFO] [stderr] | [INFO] [stderr] 671 | while let Some(_) = self.next() {} [INFO] [stderr] | ^^^^^^^^^^^ help: try: `for _ in self { .. }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_on_iterator [INFO] [stderr] [INFO] [stderr] warning: methods called `into_*` usually take self by value; consider choosing a less ambiguous name [INFO] [stderr] --> src/map/guard.rs:161:30 [INFO] [stderr] | [INFO] [stderr] 161 | pub(super) fn into_alloc(mut this: Self) -> OwnedAlloc<(K, V)> { [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::wrong_self_convention)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/map/guard.rs:256:9 [INFO] [stderr] | [INFO] [stderr] 256 | self.origin.upgrade().map(|incin| incin.add(Garbage::Pair(alloc))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^- [INFO] [stderr] | | [INFO] [stderr] | help: try this: `if let Some(incin) = self.origin.upgrade() { incin.add(Garbage::Pair(alloc)) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::option_map_unit_fn)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] [INFO] [stderr] error: casting from `*mut ()` to a more-strictly-aligned pointer (`*mut map::bucket::Bucket`) [INFO] [stderr] --> src/map/iter.rs:62:31 [INFO] [stderr] | [INFO] [stderr] 62 | let ptr = ptr as *mut Bucket; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_ptr_alignment [INFO] [stderr] [INFO] [stderr] error: casting from `*mut ()` to a more-strictly-aligned pointer (`*mut map::bucket::Bucket`) [INFO] [stderr] --> src/map/iter.rs:154:31 [INFO] [stderr] | [INFO] [stderr] 154 | let ptr = ptr as *mut Bucket; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_ptr_alignment [INFO] [stderr] [INFO] [stderr] warning: this loop could be written as a `for` loop [INFO] [stderr] --> src/map/iter.rs:200:29 [INFO] [stderr] | [INFO] [stderr] 200 | while let Some(_) = self.next() {} [INFO] [stderr] | ^^^^^^^^^^^ help: try: `for _ in self { .. }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_on_iterator [INFO] [stderr] [INFO] [stderr] error: casting from `*mut ()` to a more-strictly-aligned pointer (`*mut map::bucket::Bucket`) [INFO] [stderr] --> src/map/iter.rs:270:31 [INFO] [stderr] | [INFO] [stderr] 270 | let ptr = ptr as *mut Bucket; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_ptr_alignment [INFO] [stderr] [INFO] [stderr] error: aborting due to 11 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `lockfree`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/incin.rs:272:12 [INFO] [stderr] | [INFO] [stderr] 272 | if tmp.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!tmp.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/queue.rs:45:5 [INFO] [stderr] | [INFO] [stderr] 45 | / pub fn pop_iter<'queue>(&'queue self) -> PopIter<'queue, T> { [INFO] [stderr] 46 | | PopIter { queue: self } [INFO] [stderr] 47 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/stack.rs:34:5 [INFO] [stderr] | [INFO] [stderr] 34 | / pub fn pop_iter<'stack>(&'stack self) -> PopIter<'stack, T> { [INFO] [stderr] 35 | | PopIter { stack: self } [INFO] [stderr] 36 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: this loop could be written as a `for` loop [INFO] [stderr] --> src/stack.rs:127:29 [INFO] [stderr] | [INFO] [stderr] 127 | while let Some(_) = self.next() {} [INFO] [stderr] | ^^^^^^^^^^^ help: try: `for _ in self { .. }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::while_let_on_iterator)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_on_iterator [INFO] [stderr] [INFO] [stderr] error: casting from `*mut ()` to a more-strictly-aligned pointer (`*mut map::bucket::Bucket`) [INFO] [stderr] --> src/map/table.rs:75:32 [INFO] [stderr] | [INFO] [stderr] 75 | let bucket = &*(loaded as *mut Bucket); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::cast_ptr_alignment)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_ptr_alignment [INFO] [stderr] [INFO] [stderr] error: casting from `*mut ()` to a more-strictly-aligned pointer (`*mut map::bucket::Bucket`) [INFO] [stderr] --> src/map/table.rs:100:56 [INFO] [stderr] | [INFO] [stderr] 100 | NonNull::new_unchecked(loaded as *mut _), [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_ptr_alignment [INFO] [stderr] [INFO] [stderr] error: casting from `*mut ()` to a more-strictly-aligned pointer (`*mut map::bucket::Bucket`) [INFO] [stderr] --> src/map/table.rs:185:32 [INFO] [stderr] | [INFO] [stderr] 185 | let bucket = &*(loaded as *mut Bucket); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_ptr_alignment [INFO] [stderr] [INFO] [stderr] error: casting from `*mut ()` to a more-strictly-aligned pointer (`*mut map::bucket::Bucket`) [INFO] [stderr] --> src/map/table.rs:217:45 [INFO] [stderr] | [INFO] [stderr] 217 | loaded as *mut _, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_ptr_alignment [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/map/table.rs:234:55 [INFO] [stderr] | [INFO] [stderr] 234 | let new_table = tbl_cache.take_or(|| Self::new_alloc()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Self::new_alloc` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] error: casting from `*mut ()` to a more-strictly-aligned pointer (`*mut map::bucket::Bucket`) [INFO] [stderr] --> src/map/table.rs:331:32 [INFO] [stderr] | [INFO] [stderr] 331 | let bucket = &*(loaded as *mut Bucket); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_ptr_alignment [INFO] [stderr] [INFO] [stderr] error: casting from `*mut ()` to a more-strictly-aligned pointer (`*mut map::bucket::Bucket`) [INFO] [stderr] --> src/map/table.rs:352:52 [INFO] [stderr] | [INFO] [stderr] 352 | NonNull::new_unchecked(loaded as *mut _), [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_ptr_alignment [INFO] [stderr] [INFO] [stderr] error: casting from `*mut ()` to a more-strictly-aligned pointer (`*mut map::bucket::Bucket`) [INFO] [stderr] --> src/map/table.rs:403:34 [INFO] [stderr] | [INFO] [stderr] 403 | let bucket_ptr = loaded as *mut Bucket; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_ptr_alignment [INFO] [stderr] [INFO] [stderr] error: casting from `*mut ()` to a more-strictly-aligned pointer (`*mut map::bucket::Bucket`) [INFO] [stderr] --> src/map/table.rs:517:17 [INFO] [stderr] | [INFO] [stderr] 517 | ptr as *mut Bucket, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_ptr_alignment [INFO] [stderr] [INFO] [stderr] warning: Comparing with null is better expressed by the .is_null() method [INFO] [stderr] --> src/map/bucket.rs:464:27 [INFO] [stderr] | [INFO] [stderr] 464 | self.is_root() && self.next == null_mut() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cmp_null)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_null [INFO] [stderr] [INFO] [stderr] warning: this loop could be written as a `for` loop [INFO] [stderr] --> src/map/bucket.rs:671:29 [INFO] [stderr] | [INFO] [stderr] 671 | while let Some(_) = self.next() {} [INFO] [stderr] | ^^^^^^^^^^^ help: try: `for _ in self { .. }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_on_iterator [INFO] [stderr] [INFO] [stderr] warning: methods called `into_*` usually take self by value; consider choosing a less ambiguous name [INFO] [stderr] --> src/map/guard.rs:161:30 [INFO] [stderr] | [INFO] [stderr] 161 | pub(super) fn into_alloc(mut this: Self) -> OwnedAlloc<(K, V)> { [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::wrong_self_convention)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/map/guard.rs:256:9 [INFO] [stderr] | [INFO] [stderr] 256 | self.origin.upgrade().map(|incin| incin.add(Garbage::Pair(alloc))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^- [INFO] [stderr] | | [INFO] [stderr] | help: try this: `if let Some(incin) = self.origin.upgrade() { incin.add(Garbage::Pair(alloc)) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::option_map_unit_fn)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] [INFO] [stderr] error: casting from `*mut ()` to a more-strictly-aligned pointer (`*mut map::bucket::Bucket`) [INFO] [stderr] --> src/map/iter.rs:62:31 [INFO] [stderr] | [INFO] [stderr] 62 | let ptr = ptr as *mut Bucket; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_ptr_alignment [INFO] [stderr] [INFO] [stderr] error: casting from `*mut ()` to a more-strictly-aligned pointer (`*mut map::bucket::Bucket`) [INFO] [stderr] --> src/map/iter.rs:154:31 [INFO] [stderr] | [INFO] [stderr] 154 | let ptr = ptr as *mut Bucket; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_ptr_alignment [INFO] [stderr] [INFO] [stderr] warning: this loop could be written as a `for` loop [INFO] [stderr] --> src/map/iter.rs:200:29 [INFO] [stderr] | [INFO] [stderr] 200 | while let Some(_) = self.next() {} [INFO] [stderr] | ^^^^^^^^^^^ help: try: `for _ in self { .. }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_on_iterator [INFO] [stderr] [INFO] [stderr] error: casting from `*mut ()` to a more-strictly-aligned pointer (`*mut map::bucket::Bucket`) [INFO] [stderr] --> src/map/iter.rs:270:31 [INFO] [stderr] | [INFO] [stderr] 270 | let ptr = ptr as *mut Bucket; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_ptr_alignment [INFO] [stderr] [INFO] [stderr] warning: in an 'if' condition, avoid complex blocks or closures with blocks; instead, move the block or closure higher and bind it with a 'let' [INFO] [stderr] --> src/map/mod.rs:563:60 [INFO] [stderr] | [INFO] [stderr] 563 | .insert_with("five".to_owned(), |_, _, stored| { [INFO] [stderr] | ____________________________________________________________^ [INFO] [stderr] 564 | | if let Some((_, n)) = stored { [INFO] [stderr] 565 | | Preview::New(*n + 6) [INFO] [stderr] 566 | | } else { [INFO] [stderr] 567 | | Preview::Discard [INFO] [stderr] 568 | | } [INFO] [stderr] 569 | | }) [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::block_in_if_condition_stmt)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#block_in_if_condition_stmt [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/map/mod.rs:719:29 [INFO] [stderr] | [INFO] [stderr] 719 | assert_eq!(*result.get(&pair).unwrap(), 1); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&result[&pair]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/map/mod.rs:751:29 [INFO] [stderr] | [INFO] [stderr] 751 | assert_eq!(*result.get(&pair).unwrap(), 1); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&result[&pair]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/map/mod.rs:775:29 [INFO] [stderr] | [INFO] [stderr] 775 | assert_eq!(*result.get(&pair).unwrap(), 1); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&result[&pair]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/map/mod.rs:789:29 [INFO] [stderr] | [INFO] [stderr] 789 | assert_eq!(*result.get(&pair).unwrap(), 1); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&result[&pair]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] error: aborting due to 11 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `lockfree`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "f93b053495fdf71738e9d76a60478ff4847300e74f9cfd400c7889c0138bf0d2"` [INFO] running `"docker" "rm" "-f" "f93b053495fdf71738e9d76a60478ff4847300e74f9cfd400c7889c0138bf0d2"` [INFO] [stdout] f93b053495fdf71738e9d76a60478ff4847300e74f9cfd400c7889c0138bf0d2