[INFO] crate locale_config 0.2.2 is already in cache
[INFO] extracting crate locale_config 0.2.2 into work/ex/clippy-test-run/sources/stable/reg/locale_config/0.2.2
[INFO] extracting crate locale_config 0.2.2 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/locale_config/0.2.2
[INFO] validating manifest of locale_config-0.2.2 on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of locale_config-0.2.2 on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing locale_config-0.2.2
[INFO] finished frobbing locale_config-0.2.2
[INFO] frobbed toml for locale_config-0.2.2 written to work/ex/clippy-test-run/sources/stable/reg/locale_config/0.2.2/Cargo.toml
[INFO] started frobbing locale_config-0.2.2
[INFO] finished frobbing locale_config-0.2.2
[INFO] frobbed toml for locale_config-0.2.2 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/locale_config/0.2.2/Cargo.toml
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting locale_config-0.2.2 against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/locale_config/0.2.2:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] aa0213b6fd789eccb5c41fb6e8bdfcc1dfd2750fa861b3e1b9603a6df4e51bb8
[INFO] running `"docker" "start" "-a" "aa0213b6fd789eccb5c41fb6e8bdfcc1dfd2750fa861b3e1b9603a6df4e51bb8"`
[INFO] [stderr]     Checking locale_config v0.2.2 (/opt/crater/workdir)
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/lib.rs:579:21
[INFO] [stderr]     |
[INFO] [stderr] 579 |                     tags: tags,
[INFO] [stderr]     |                     ^^^^^^^^^^ help: replace it with: `tags`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/lib.rs:579:21
[INFO] [stderr]     |
[INFO] [stderr] 579 |                     tags: tags,
[INFO] [stderr]     |                     ^^^^^^^^^^ help: replace it with: `tags`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/lib.rs:240:13
[INFO] [stderr]     |
[INFO] [stderr] 240 | /             return Ok(LanguageRange {
[INFO] [stderr] 241 | |                 language: Cow::Borrowed(lt),
[INFO] [stderr] 242 | |             });
[INFO] [stderr]     | |_______________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] help: remove `return` as shown
[INFO] [stderr]     |
[INFO] [stderr] 240 |             Ok(LanguageRange {
[INFO] [stderr] 241 |                 language: Cow::Borrowed(lt),
[INFO] [stderr] 242 |             })
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/lib.rs:512:9
[INFO] [stderr]     |
[INFO] [stderr] 512 |         return Ok(res);
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(res)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/lib.rs:585:9
[INFO] [stderr]     |
[INFO] [stderr] 585 | /         return TagsFor {
[INFO] [stderr] 586 | |             src: self.inner.as_ref(),
[INFO] [stderr] 587 | |             tags: self.inner.split(","),
[INFO] [stderr] 588 | |             category: None,
[INFO] [stderr] 589 | |         };
[INFO] [stderr]     | |__________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] help: remove `return` as shown
[INFO] [stderr]     |
[INFO] [stderr] 585 |         TagsFor {
[INFO] [stderr] 586 |             src: self.inner.as_ref(),
[INFO] [stderr] 587 |             tags: self.inner.split(","),
[INFO] [stderr] 588 |             category: None,
[INFO] [stderr] 589 |         }
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/lib.rs:677:9
[INFO] [stderr]     |
[INFO] [stderr] 677 |         return None;
[INFO] [stderr]     |         ^^^^^^^^^^^^ help: remove `return` as shown: `None`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/unix.rs:61:9
[INFO] [stderr]    |
[INFO] [stderr] 61 |         return Some(loc);
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(loc)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/unix.rs:63:9
[INFO] [stderr]    |
[INFO] [stderr] 63 |         return None;
[INFO] [stderr]    |         ^^^^^^^^^^^^ help: remove `return` as shown: `None`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/lib.rs:725:5
[INFO] [stderr]     |
[INFO] [stderr] 725 |     return Locale::invariant();
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Locale::invariant()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: use of deprecated item 'std::ascii::AsciiExt': use inherent methods instead
[INFO] [stderr]   --> src/lib.rs:21:5
[INFO] [stderr]    |
[INFO] [stderr] 21 | use std::ascii::AsciiExt;
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(deprecated)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/lib.rs:240:13
[INFO] [stderr]     |
[INFO] [stderr] 240 | /             return Ok(LanguageRange {
[INFO] [stderr] 241 | |                 language: Cow::Borrowed(lt),
[INFO] [stderr] 242 | |             });
[INFO] [stderr]     | |_______________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] help: remove `return` as shown
[INFO] [stderr]     |
[INFO] [stderr] 240 |             Ok(LanguageRange {
[INFO] [stderr] 241 |                 language: Cow::Borrowed(lt),
[INFO] [stderr] 242 |             })
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/lib.rs:512:9
[INFO] [stderr]     |
[INFO] [stderr] 512 |         return Ok(res);
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(res)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/lib.rs:585:9
[INFO] [stderr]     |
[INFO] [stderr] 585 | /         return TagsFor {
[INFO] [stderr] 586 | |             src: self.inner.as_ref(),
[INFO] [stderr] 587 | |             tags: self.inner.split(","),
[INFO] [stderr] 588 | |             category: None,
[INFO] [stderr] 589 | |         };
[INFO] [stderr]     | |__________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] help: remove `return` as shown
[INFO] [stderr]     |
[INFO] [stderr] 585 |         TagsFor {
[INFO] [stderr] 586 |             src: self.inner.as_ref(),
[INFO] [stderr] 587 |             tags: self.inner.split(","),
[INFO] [stderr] 588 |             category: None,
[INFO] [stderr] 589 |         }
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/lib.rs:677:9
[INFO] [stderr]     |
[INFO] [stderr] 677 |         return None;
[INFO] [stderr]     |         ^^^^^^^^^^^^ help: remove `return` as shown: `None`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/unix.rs:61:9
[INFO] [stderr]    |
[INFO] [stderr] 61 |         return Some(loc);
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(loc)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/unix.rs:63:9
[INFO] [stderr]    |
[INFO] [stderr] 63 |         return None;
[INFO] [stderr]    |         ^^^^^^^^^^^^ help: remove `return` as shown: `None`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/lib.rs:725:5
[INFO] [stderr]     |
[INFO] [stderr] 725 |     return Locale::invariant();
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Locale::invariant()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unused import: `std::ascii::AsciiExt`
[INFO] [stderr]   --> src/lib.rs:21:5
[INFO] [stderr]    |
[INFO] [stderr] 21 | use std::ascii::AsciiExt;
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(unused_imports)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: use of deprecated item 'std::ascii::AsciiExt': use inherent methods instead
[INFO] [stderr]   --> src/lib.rs:21:5
[INFO] [stderr]    |
[INFO] [stderr] 21 | use std::ascii::AsciiExt;
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(deprecated)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: using a reference to `Cow` is not recommended.
[INFO] [stderr]    --> src/lib.rs:177:41
[INFO] [stderr]     |
[INFO] [stderr] 177 | fn is_owned<'a, T: ToOwned + ?Sized>(c: &Cow<'a, T>) -> bool {
[INFO] [stderr]     |                                         ^^^^^^^^^^^ help: change this to: `&T`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration)
[INFO] [stderr]    --> src/lib.rs:184:1
[INFO] [stderr]     |
[INFO] [stderr] 184 | / fn canon_lower<'a>(o: Option<&'a str>) -> Cow<'a, str> {
[INFO] [stderr] 185 | |     match o {
[INFO] [stderr] 186 | |         None => Cow::Borrowed(""),
[INFO] [stderr] 187 | |         Some(s) =>
[INFO] [stderr] ...   |
[INFO] [stderr] 193 | |     }
[INFO] [stderr] 194 | | }
[INFO] [stderr]     | |_^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_lifetimes)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
[INFO] [stderr] 
[INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration)
[INFO] [stderr]    --> src/lib.rs:196:1
[INFO] [stderr]     |
[INFO] [stderr] 196 | / fn canon_script<'a>(o: Option<&'a str>) -> Cow<'a, str> {
[INFO] [stderr] 197 | |     assert!(o.map_or(true, |s| s.len() >= 2 && &s[0..1] == "-"));
[INFO] [stderr] 198 | |     match o {
[INFO] [stderr] 199 | |         None => Cow::Borrowed(""),
[INFO] [stderr] ...   |
[INFO] [stderr] 209 | |     }
[INFO] [stderr] 210 | | }
[INFO] [stderr]     | |_^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
[INFO] [stderr] 
[INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration)
[INFO] [stderr]    --> src/lib.rs:212:1
[INFO] [stderr]     |
[INFO] [stderr] 212 | / fn canon_upper<'a>(o: Option<&'a str>) -> Cow<'a, str> {
[INFO] [stderr] 213 | |     assert!(o.map_or(true, |s| s.len() > 1 && &s[0..1] == "-"));
[INFO] [stderr] 214 | |     match o {
[INFO] [stderr] 215 | |         None => Cow::Borrowed(""),
[INFO] [stderr] ...   |
[INFO] [stderr] 222 | |     }
[INFO] [stderr] 223 | | }
[INFO] [stderr]     | |_^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]    --> src/lib.rs:545:53
[INFO] [stderr]     |
[INFO] [stderr] 545 |                     i[category.len()..].starts_with("=") &&
[INFO] [stderr]     |                                                     ^^^ help: try using a char instead: `'='`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::single_char_pattern)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration)
[INFO] [stderr]    --> src/lib.rs:562:5
[INFO] [stderr]     |
[INFO] [stderr] 562 | /     pub fn tags<'a>(&'a self) -> Tags<'a> {
[INFO] [stderr] 563 | |         Tags { tags: self.inner.split(","), }
[INFO] [stderr] 564 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]    --> src/lib.rs:563:39
[INFO] [stderr]     |
[INFO] [stderr] 563 |         Tags { tags: self.inner.split(","), }
[INFO] [stderr]     |                                       ^^^ help: try using a char instead: `','`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]    --> src/lib.rs:574:41
[INFO] [stderr]     |
[INFO] [stderr] 574 |         let mut tags = self.inner.split(",");
[INFO] [stderr]     |                                         ^^^ help: try using a char instead: `','`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]    --> src/lib.rs:576:75
[INFO] [stderr]     |
[INFO] [stderr] 576 |             if s.starts_with(category) && s[category.len()..].starts_with("=") {
[INFO] [stderr]     |                                                                           ^^^ help: try using a char instead: `'='`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]    --> src/lib.rs:587:36
[INFO] [stderr]     |
[INFO] [stderr] 587 |             tags: self.inner.split(","),
[INFO] [stderr]     |                                    ^^^ help: try using a char instead: `','`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]    --> src/lib.rs:663:69
[INFO] [stderr]     |
[INFO] [stderr] 663 |                 if s.starts_with(cat) && s[cat.len()..].starts_with("=") {
[INFO] [stderr]     |                                                                     ^^^ help: try using a char instead: `'='`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]    --> src/lib.rs:669:40
[INFO] [stderr]     |
[INFO] [stderr] 669 |             self.tags = self.src.split(",");
[INFO] [stderr]     |                                        ^^^ help: try using a char instead: `','`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a function call
[INFO] [stderr]   --> src/unix.rs:12:12
[INFO] [stderr]    |
[INFO] [stderr] 12 |     tag(s).unwrap_or(LanguageRange::invariant())
[INFO] [stderr]    |            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| LanguageRange::invariant())`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::or_fun_call)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]    --> src/lib.rs:753:9
[INFO] [stderr]     |
[INFO] [stderr] 753 | /         match self {
[INFO] [stderr] 754 | |             &Error::NotWellFormed => "Language tag is not well-formed.",
[INFO] [stderr] 755 | |             // this is exception: here we do want exhaustive match so we don't publish version with
[INFO] [stderr] 756 | |             // missing descriptions by mistake.
[INFO] [stderr] 757 | |             &Error::__NonExhaustive => panic!("Placeholder error must not be instantiated!"),
[INFO] [stderr] 758 | |         }
[INFO] [stderr]     | |_________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::match_ref_pats)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]     |
[INFO] [stderr] 753 |         match *self {
[INFO] [stderr] 754 |             Error::NotWellFormed => "Language tag is not well-formed.",
[INFO] [stderr] 755 |             // this is exception: here we do want exhaustive match so we don't publish version with
[INFO] [stderr] 756 |             // missing descriptions by mistake.
[INFO] [stderr] 757 |             Error::__NonExhaustive => panic!("Placeholder error must not be instantiated!"),
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: unused import: `std::ascii::AsciiExt`
[INFO] [stderr]   --> src/lib.rs:21:5
[INFO] [stderr]    |
[INFO] [stderr] 21 | use std::ascii::AsciiExt;
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(unused_imports)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: using a reference to `Cow` is not recommended.
[INFO] [stderr]    --> src/lib.rs:177:41
[INFO] [stderr]     |
[INFO] [stderr] 177 | fn is_owned<'a, T: ToOwned + ?Sized>(c: &Cow<'a, T>) -> bool {
[INFO] [stderr]     |                                         ^^^^^^^^^^^ help: change this to: `&T`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration)
[INFO] [stderr]    --> src/lib.rs:184:1
[INFO] [stderr]     |
[INFO] [stderr] 184 | / fn canon_lower<'a>(o: Option<&'a str>) -> Cow<'a, str> {
[INFO] [stderr] 185 | |     match o {
[INFO] [stderr] 186 | |         None => Cow::Borrowed(""),
[INFO] [stderr] 187 | |         Some(s) =>
[INFO] [stderr] ...   |
[INFO] [stderr] 193 | |     }
[INFO] [stderr] 194 | | }
[INFO] [stderr]     | |_^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_lifetimes)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
[INFO] [stderr] 
[INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration)
[INFO] [stderr]    --> src/lib.rs:196:1
[INFO] [stderr]     |
[INFO] [stderr] 196 | / fn canon_script<'a>(o: Option<&'a str>) -> Cow<'a, str> {
[INFO] [stderr] 197 | |     assert!(o.map_or(true, |s| s.len() >= 2 && &s[0..1] == "-"));
[INFO] [stderr] 198 | |     match o {
[INFO] [stderr] 199 | |         None => Cow::Borrowed(""),
[INFO] [stderr] ...   |
[INFO] [stderr] 209 | |     }
[INFO] [stderr] 210 | | }
[INFO] [stderr]     | |_^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
[INFO] [stderr] 
[INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration)
[INFO] [stderr]    --> src/lib.rs:212:1
[INFO] [stderr]     |
[INFO] [stderr] 212 | / fn canon_upper<'a>(o: Option<&'a str>) -> Cow<'a, str> {
[INFO] [stderr] 213 | |     assert!(o.map_or(true, |s| s.len() > 1 && &s[0..1] == "-"));
[INFO] [stderr] 214 | |     match o {
[INFO] [stderr] 215 | |         None => Cow::Borrowed(""),
[INFO] [stderr] ...   |
[INFO] [stderr] 222 | |     }
[INFO] [stderr] 223 | | }
[INFO] [stderr]     | |_^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]    --> src/lib.rs:545:53
[INFO] [stderr]     |
[INFO] [stderr] 545 |                     i[category.len()..].starts_with("=") &&
[INFO] [stderr]     |                                                     ^^^ help: try using a char instead: `'='`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::single_char_pattern)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration)
[INFO] [stderr]    --> src/lib.rs:562:5
[INFO] [stderr]     |
[INFO] [stderr] 562 | /     pub fn tags<'a>(&'a self) -> Tags<'a> {
[INFO] [stderr] 563 | |         Tags { tags: self.inner.split(","), }
[INFO] [stderr] 564 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]    --> src/lib.rs:563:39
[INFO] [stderr]     |
[INFO] [stderr] 563 |         Tags { tags: self.inner.split(","), }
[INFO] [stderr]     |                                       ^^^ help: try using a char instead: `','`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]    --> src/lib.rs:574:41
[INFO] [stderr]     |
[INFO] [stderr] 574 |         let mut tags = self.inner.split(",");
[INFO] [stderr]     |                                         ^^^ help: try using a char instead: `','`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]    --> src/lib.rs:576:75
[INFO] [stderr]     |
[INFO] [stderr] 576 |             if s.starts_with(category) && s[category.len()..].starts_with("=") {
[INFO] [stderr]     |                                                                           ^^^ help: try using a char instead: `'='`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]    --> src/lib.rs:587:36
[INFO] [stderr]     |
[INFO] [stderr] 587 |             tags: self.inner.split(","),
[INFO] [stderr]     |                                    ^^^ help: try using a char instead: `','`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]    --> src/lib.rs:663:69
[INFO] [stderr]     |
[INFO] [stderr] 663 |                 if s.starts_with(cat) && s[cat.len()..].starts_with("=") {
[INFO] [stderr]     |                                                                     ^^^ help: try using a char instead: `'='`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]    --> src/lib.rs:669:40
[INFO] [stderr]     |
[INFO] [stderr] 669 |             self.tags = self.src.split(",");
[INFO] [stderr]     |                                        ^^^ help: try using a char instead: `','`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a function call
[INFO] [stderr]   --> src/unix.rs:12:12
[INFO] [stderr]    |
[INFO] [stderr] 12 |     tag(s).unwrap_or(LanguageRange::invariant())
[INFO] [stderr]    |            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| LanguageRange::invariant())`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::or_fun_call)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]    --> src/lib.rs:753:9
[INFO] [stderr]     |
[INFO] [stderr] 753 | /         match self {
[INFO] [stderr] 754 | |             &Error::NotWellFormed => "Language tag is not well-formed.",
[INFO] [stderr] 755 | |             // this is exception: here we do want exhaustive match so we don't publish version with
[INFO] [stderr] 756 | |             // missing descriptions by mistake.
[INFO] [stderr] 757 | |             &Error::__NonExhaustive => panic!("Placeholder error must not be instantiated!"),
[INFO] [stderr] 758 | |         }
[INFO] [stderr]     | |_________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::match_ref_pats)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]     |
[INFO] [stderr] 753 |         match *self {
[INFO] [stderr] 754 |             Error::NotWellFormed => "Language tag is not well-formed.",
[INFO] [stderr] 755 |             // this is exception: here we do want exhaustive match so we don't publish version with
[INFO] [stderr] 756 |             // missing descriptions by mistake.
[INFO] [stderr] 757 |             Error::__NonExhaustive => panic!("Placeholder error must not be instantiated!"),
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 2.62s
[INFO] running `"docker" "inspect" "aa0213b6fd789eccb5c41fb6e8bdfcc1dfd2750fa861b3e1b9603a6df4e51bb8"`
[INFO] running `"docker" "rm" "-f" "aa0213b6fd789eccb5c41fb6e8bdfcc1dfd2750fa861b3e1b9603a6df4e51bb8"`
[INFO] [stdout] aa0213b6fd789eccb5c41fb6e8bdfcc1dfd2750fa861b3e1b9603a6df4e51bb8