[INFO] crate lmdb-rkv 0.10.0 is already in cache [INFO] extracting crate lmdb-rkv 0.10.0 into work/ex/clippy-test-run/sources/stable/reg/lmdb-rkv/0.10.0 [INFO] extracting crate lmdb-rkv 0.10.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/lmdb-rkv/0.10.0 [INFO] validating manifest of lmdb-rkv-0.10.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of lmdb-rkv-0.10.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing lmdb-rkv-0.10.0 [INFO] finished frobbing lmdb-rkv-0.10.0 [INFO] frobbed toml for lmdb-rkv-0.10.0 written to work/ex/clippy-test-run/sources/stable/reg/lmdb-rkv/0.10.0/Cargo.toml [INFO] started frobbing lmdb-rkv-0.10.0 [INFO] finished frobbing lmdb-rkv-0.10.0 [INFO] frobbed toml for lmdb-rkv-0.10.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/lmdb-rkv/0.10.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting lmdb-rkv-0.10.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/lmdb-rkv/0.10.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 4134daa7758dcaa1d6367a8e55906ea4bfccb99c3ceaa7360092add205bb71e3 [INFO] running `"docker" "start" "-a" "4134daa7758dcaa1d6367a8e55906ea4bfccb99c3ceaa7360092add205bb71e3"` [INFO] [stderr] Compiling lmdb-sys v0.8.0 [INFO] [stderr] Checking lmdb-rkv v0.10.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cursor.rs:133:13 [INFO] [stderr] | [INFO] [stderr] 133 | cursor: cursor, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `cursor` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cursor.rs:170:23 [INFO] [stderr] | [INFO] [stderr] 170 | Ok(RwCursor { cursor: cursor, _marker: PhantomData }) [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `cursor` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cursor.rs:229:16 [INFO] [stderr] | [INFO] [stderr] 229 | Iter { cursor: cursor, op: op, next_op: next_op, _marker: PhantomData } [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `cursor` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cursor.rs:229:32 [INFO] [stderr] | [INFO] [stderr] 229 | Iter { cursor: cursor, op: op, next_op: next_op, _marker: PhantomData } [INFO] [stderr] | ^^^^^^ help: replace it with: `op` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cursor.rs:229:40 [INFO] [stderr] | [INFO] [stderr] 229 | Iter { cursor: cursor, op: op, next_op: next_op, _marker: PhantomData } [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `next_op` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cursor.rs:273:19 [INFO] [stderr] | [INFO] [stderr] 273 | IterDup { cursor: cursor, op: op, _marker: PhantomData } [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `cursor` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cursor.rs:273:35 [INFO] [stderr] | [INFO] [stderr] 273 | IterDup { cursor: cursor, op: op, _marker: PhantomData } [INFO] [stderr] | ^^^^^^ help: replace it with: `op` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/database.rs:31:23 [INFO] [stderr] | [INFO] [stderr] 31 | Ok(Database { dbi: dbi }) [INFO] [stderr] | ^^^^^^^^ help: replace it with: `dbi` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/environment.rs:280:26 [INFO] [stderr] | [INFO] [stderr] 280 | Ok(Environment { env: env, dbi_open_mutex: Mutex::new(()) }) [INFO] [stderr] | ^^^^^^^^ help: replace it with: `env` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/transaction.rs:133:32 [INFO] [stderr] | [INFO] [stderr] 133 | Ok(RoTransaction { txn: txn, _marker: PhantomData }) [INFO] [stderr] | ^^^^^^^^ help: replace it with: `txn` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/transaction.rs:155:31 [INFO] [stderr] | [INFO] [stderr] 155 | InactiveTransaction { txn: txn, _marker: PhantomData } [INFO] [stderr] | ^^^^^^^^ help: replace it with: `txn` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/transaction.rs:196:28 [INFO] [stderr] | [INFO] [stderr] 196 | Ok(RoTransaction { txn: txn, _marker: PhantomData }) [INFO] [stderr] | ^^^^^^^^ help: replace it with: `txn` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/transaction.rs:229:32 [INFO] [stderr] | [INFO] [stderr] 229 | Ok(RwTransaction { txn: txn, _marker: PhantomData }) [INFO] [stderr] | ^^^^^^^^ help: replace it with: `txn` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cursor.rs:133:13 [INFO] [stderr] | [INFO] [stderr] 133 | cursor: cursor, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `cursor` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cursor.rs:170:23 [INFO] [stderr] | [INFO] [stderr] 170 | Ok(RwCursor { cursor: cursor, _marker: PhantomData }) [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `cursor` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cursor.rs:229:16 [INFO] [stderr] | [INFO] [stderr] 229 | Iter { cursor: cursor, op: op, next_op: next_op, _marker: PhantomData } [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `cursor` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cursor.rs:229:32 [INFO] [stderr] | [INFO] [stderr] 229 | Iter { cursor: cursor, op: op, next_op: next_op, _marker: PhantomData } [INFO] [stderr] | ^^^^^^ help: replace it with: `op` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cursor.rs:229:40 [INFO] [stderr] | [INFO] [stderr] 229 | Iter { cursor: cursor, op: op, next_op: next_op, _marker: PhantomData } [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `next_op` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cursor.rs:273:19 [INFO] [stderr] | [INFO] [stderr] 273 | IterDup { cursor: cursor, op: op, _marker: PhantomData } [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `cursor` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/cursor.rs:273:35 [INFO] [stderr] | [INFO] [stderr] 273 | IterDup { cursor: cursor, op: op, _marker: PhantomData } [INFO] [stderr] | ^^^^^^ help: replace it with: `op` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/database.rs:31:23 [INFO] [stderr] | [INFO] [stderr] 31 | Ok(Database { dbi: dbi }) [INFO] [stderr] | ^^^^^^^^ help: replace it with: `dbi` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/environment.rs:280:26 [INFO] [stderr] | [INFO] [stderr] 280 | Ok(Environment { env: env, dbi_open_mutex: Mutex::new(()) }) [INFO] [stderr] | ^^^^^^^^ help: replace it with: `env` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/transaction.rs:133:32 [INFO] [stderr] | [INFO] [stderr] 133 | Ok(RoTransaction { txn: txn, _marker: PhantomData }) [INFO] [stderr] | ^^^^^^^^ help: replace it with: `txn` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/transaction.rs:155:31 [INFO] [stderr] | [INFO] [stderr] 155 | InactiveTransaction { txn: txn, _marker: PhantomData } [INFO] [stderr] | ^^^^^^^^ help: replace it with: `txn` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/transaction.rs:196:28 [INFO] [stderr] | [INFO] [stderr] 196 | Ok(RoTransaction { txn: txn, _marker: PhantomData }) [INFO] [stderr] | ^^^^^^^^ help: replace it with: `txn` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/transaction.rs:229:32 [INFO] [stderr] | [INFO] [stderr] 229 | Ok(RwTransaction { txn: txn, _marker: PhantomData }) [INFO] [stderr] | ^^^^^^^^ help: replace it with: `txn` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] error[E0554]: #![feature] may not be used on the stable release channel [INFO] [stderr] --> src/lib.rs:4:19 [INFO] [stderr] | [INFO] [stderr] 4 | #![cfg_attr(test, feature(test))] [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] For more information about this error, try `rustc --explain E0554`. [INFO] [stderr] error: Could not compile `lmdb-rkv`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/database.rs:38:16 [INFO] [stderr] | [INFO] [stderr] 38 | pub fn dbi(&self) -> ffi::MDB_dbi { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: methods called `new` usually return `Self` [INFO] [stderr] --> src/environment.rs:41:5 [INFO] [stderr] | [INFO] [stderr] 41 | / pub fn new() -> EnvironmentBuilder { [INFO] [stderr] 42 | | EnvironmentBuilder { [INFO] [stderr] 43 | | flags: EnvironmentFlags::empty(), [INFO] [stderr] 44 | | max_readers: None, [INFO] [stderr] ... | [INFO] [stderr] 47 | | } [INFO] [stderr] 48 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_ret_no_self)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_ret_no_self [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/environment.rs:110:5 [INFO] [stderr] | [INFO] [stderr] 110 | / pub fn get_db_flags<'env>(&'env self, db: Database) -> Result { [INFO] [stderr] 111 | | let txn = self.begin_ro_txn()?; [INFO] [stderr] 112 | | let mut flags: c_uint = 0; [INFO] [stderr] 113 | | unsafe { [INFO] [stderr] ... | [INFO] [stderr] 116 | | Ok(DatabaseFlags::from_bits(flags).unwrap()) [INFO] [stderr] 117 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/error.rs:86:24 [INFO] [stderr] | [INFO] [stderr] 86 | pub fn to_err_code(&self) -> c_int { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] error: build failed [INFO] running `"docker" "inspect" "4134daa7758dcaa1d6367a8e55906ea4bfccb99c3ceaa7360092add205bb71e3"` [INFO] running `"docker" "rm" "-f" "4134daa7758dcaa1d6367a8e55906ea4bfccb99c3ceaa7360092add205bb71e3"` [INFO] [stdout] 4134daa7758dcaa1d6367a8e55906ea4bfccb99c3ceaa7360092add205bb71e3