[INFO] crate llrb 0.0.1 is already in cache
[INFO] extracting crate llrb 0.0.1 into work/ex/clippy-test-run/sources/stable/reg/llrb/0.0.1
[INFO] extracting crate llrb 0.0.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/llrb/0.0.1
[INFO] validating manifest of llrb-0.0.1 on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of llrb-0.0.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing llrb-0.0.1
[INFO] finished frobbing llrb-0.0.1
[INFO] frobbed toml for llrb-0.0.1 written to work/ex/clippy-test-run/sources/stable/reg/llrb/0.0.1/Cargo.toml
[INFO] started frobbing llrb-0.0.1
[INFO] finished frobbing llrb-0.0.1
[INFO] frobbed toml for llrb-0.0.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/llrb/0.0.1/Cargo.toml
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting llrb-0.0.1 against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/llrb/0.0.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 3b3dd39a3e51dc2be7ddaaa6dba0b5d6d482e83e9981bb2f47bbd9d2170f7a13
[INFO] running `"docker" "start" "-a" "3b3dd39a3e51dc2be7ddaaa6dba0b5d6d482e83e9981bb2f47bbd9d2170f7a13"`
[INFO] [stderr]     Checking llrb v0.0.1 (/opt/crater/workdir)
[INFO] [stderr] warning: this `else { if .. }` block can be collapsed
[INFO] [stderr]    --> src/lib.rs:134:20
[INFO] [stderr]     |
[INFO] [stderr] 134 |               } else {
[INFO] [stderr]     |  ____________________^
[INFO] [stderr] 135 | |                 if let Some(ref left) = self.left {
[INFO] [stderr] 136 | |                     left.get(k)
[INFO] [stderr] 137 | |                 } else {
[INFO] [stderr] 138 | |                     None
[INFO] [stderr] 139 | |                 }
[INFO] [stderr] 140 | |             }
[INFO] [stderr]     | |_____________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::collapsible_if)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stderr] help: try
[INFO] [stderr]     |
[INFO] [stderr] 134 |             } else if let Some(ref left) = self.left {
[INFO] [stderr] 135 |     left.get(k)
[INFO] [stderr] 136 | } else {
[INFO] [stderr] 137 |     None
[INFO] [stderr] 138 | }
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: this `else { if .. }` block can be collapsed
[INFO] [stderr]    --> src/lib.rs:196:20
[INFO] [stderr]     |
[INFO] [stderr] 196 |               } else {
[INFO] [stderr]     |  ____________________^
[INFO] [stderr] 197 | |                 if let Some(ref mut left) = self.left {
[INFO] [stderr] 198 | |                     left.get_mut(k)
[INFO] [stderr] 199 | |                 } else {
[INFO] [stderr] 200 | |                     None
[INFO] [stderr] 201 | |                 }
[INFO] [stderr] 202 | |             }
[INFO] [stderr]     | |_____________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stderr] help: try
[INFO] [stderr]     |
[INFO] [stderr] 196 |             } else if let Some(ref mut left) = self.left {
[INFO] [stderr] 197 |     left.get_mut(k)
[INFO] [stderr] 198 | } else {
[INFO] [stderr] 199 |     None
[INFO] [stderr] 200 | }
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: unused variable: `right_is_red`
[INFO] [stderr]    --> src/lib.rs:288:13
[INFO] [stderr]     |
[INFO] [stderr] 288 |         let right_is_red = is_red(&self.left);
[INFO] [stderr]     |             ^^^^^^^^^^^^ help: consider using `_right_is_red` instead
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(unused_variables)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: unused variable: `val`
[INFO] [stderr]    --> src/lib.rs:289:43
[INFO] [stderr]     |
[INFO] [stderr] 289 |         if let Some((ref mut key, ref mut val)) = self.kv {
[INFO] [stderr]     |                                           ^^^ help: consider using `_val` instead
[INFO] [stderr] 
[INFO] [stderr] warning: unused variable: `other`
[INFO] [stderr]    --> src/lib.rs:335:30
[INFO] [stderr]     |
[INFO] [stderr] 335 |     pub fn append(&mut self, other: &mut Self) {}
[INFO] [stderr]     |                              ^^^^^ help: consider using `_other` instead
[INFO] [stderr] 
[INFO] [stderr] warning: this `else { if .. }` block can be collapsed
[INFO] [stderr]    --> src/lib.rs:134:20
[INFO] [stderr]     |
[INFO] [stderr] 134 |               } else {
[INFO] [stderr]     |  ____________________^
[INFO] [stderr] 135 | |                 if let Some(ref left) = self.left {
[INFO] [stderr] 136 | |                     left.get(k)
[INFO] [stderr] 137 | |                 } else {
[INFO] [stderr] 138 | |                     None
[INFO] [stderr] 139 | |                 }
[INFO] [stderr] 140 | |             }
[INFO] [stderr]     | |_____________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::collapsible_if)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stderr] warning: method is never used: `move_red_right`
[INFO] [stderr]   --> src/lib.rs:92:5
[INFO] [stderr]    |
[INFO] [stderr] 92 |     fn move_red_right(&mut self) {}
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(dead_code)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: method is never used: `move_red_left`
[INFO] [stderr]   --> src/lib.rs:94:5
[INFO] [stderr]    |
[INFO] [stderr] 94 |     fn move_red_left(&mut self) {}
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: method is never used: `min`
[INFO] [stderr]    --> src/lib.rs:303:5
[INFO] [stderr]     |
[INFO] [stderr] 303 |     fn min(&self) -> &LLRB<K, V> {
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] help: try
[INFO] [stderr]     |
[INFO] [stderr] 134 |             } else if let Some(ref left) = self.left {
[INFO] [stderr] 135 |     left.get(k)
[INFO] [stderr] 136 | } else {
[INFO] [stderr] 137 |     None
[INFO] [stderr] 138 | }
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: this `else { if .. }` block can be collapsed
[INFO] [stderr]    --> src/lib.rs:196:20
[INFO] [stderr]     |
[INFO] [stderr] 196 |               } else {
[INFO] [stderr]     |  ____________________^
[INFO] [stderr] 197 | |                 if let Some(ref mut left) = self.left {
[INFO] [stderr] 198 | |                     left.get_mut(k)
[INFO] [stderr] 199 | |                 } else {
[INFO] [stderr] 200 | |                     None
[INFO] [stderr] 201 | |                 }
[INFO] [stderr] 202 | |             }
[INFO] [stderr]     | |_____________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stderr] help: try
[INFO] [stderr]     |
[INFO] [stderr] 196 |             } else if let Some(ref mut left) = self.left {
[INFO] [stderr] 197 |     left.get_mut(k)
[INFO] [stderr] 198 | } else {
[INFO] [stderr] 199 |     None
[INFO] [stderr] 200 | }
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: taken reference of right operand
[INFO] [stderr]    --> src/lib.rs:128:23
[INFO] [stderr]     |
[INFO] [stderr] 128 |             } else if k < &kv.0 {
[INFO] [stderr]     |                       ^^^^-----
[INFO] [stderr]     |                           |
[INFO] [stderr]     |                           help: use the right value directly: `kv.0`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::op_ref)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref
[INFO] [stderr] 
[INFO] [stderr] warning: taken reference of right operand
[INFO] [stderr]    --> src/lib.rs:190:23
[INFO] [stderr]     |
[INFO] [stderr] 190 |             } else if k < &kv.0 {
[INFO] [stderr]     |                       ^^^^-----
[INFO] [stderr]     |                           |
[INFO] [stderr]     |                           help: use the right value directly: `kv.0`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref
[INFO] [stderr] 
[INFO] [stderr] warning: needlessly taken reference of left operand
[INFO] [stderr]    --> src/lib.rs:246:23
[INFO] [stderr]     |
[INFO] [stderr] 246 |             } else if &k < key {
[INFO] [stderr]     |                       --^^^^^^
[INFO] [stderr]     |                       |
[INFO] [stderr]     |                       help: use the left value directly: `k`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]    --> src/lib.rs:390:5
[INFO] [stderr]     |
[INFO] [stderr] 390 | /     if let &Some(ref n) = node {
[INFO] [stderr] 391 | |         if n.color == Color::Red {
[INFO] [stderr] 392 | |             return true;
[INFO] [stderr] 393 | |         }
[INFO] [stderr] 394 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::match_ref_pats)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]     |
[INFO] [stderr] 390 |     if let Some(ref n) = *node {
[INFO] [stderr]     |            ^^^^^^^^^^^   ^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: unused variable: `right_is_red`
[INFO] [stderr]    --> src/lib.rs:288:13
[INFO] [stderr]     |
[INFO] [stderr] 288 |         let right_is_red = is_red(&self.left);
[INFO] [stderr]     |             ^^^^^^^^^^^^ help: consider using `_right_is_red` instead
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(unused_variables)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: unused variable: `val`
[INFO] [stderr]    --> src/lib.rs:289:43
[INFO] [stderr]     |
[INFO] [stderr] 289 |         if let Some((ref mut key, ref mut val)) = self.kv {
[INFO] [stderr]     |                                           ^^^ help: consider using `_val` instead
[INFO] [stderr] 
[INFO] [stderr] warning: unused variable: `other`
[INFO] [stderr]    --> src/lib.rs:335:30
[INFO] [stderr]     |
[INFO] [stderr] 335 |     pub fn append(&mut self, other: &mut Self) {}
[INFO] [stderr]     |                              ^^^^^ help: consider using `_other` instead
[INFO] [stderr] 
[INFO] [stderr] warning: method is never used: `move_red_right`
[INFO] [stderr]   --> src/lib.rs:92:5
[INFO] [stderr]    |
[INFO] [stderr] 92 |     fn move_red_right(&mut self) {}
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(dead_code)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: method is never used: `move_red_left`
[INFO] [stderr]   --> src/lib.rs:94:5
[INFO] [stderr]    |
[INFO] [stderr] 94 |     fn move_red_left(&mut self) {}
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: method is never used: `min`
[INFO] [stderr]    --> src/lib.rs:303:5
[INFO] [stderr]     |
[INFO] [stderr] 303 |     fn min(&self) -> &LLRB<K, V> {
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: taken reference of right operand
[INFO] [stderr]    --> src/lib.rs:128:23
[INFO] [stderr]     |
[INFO] [stderr] 128 |             } else if k < &kv.0 {
[INFO] [stderr]     |                       ^^^^-----
[INFO] [stderr]     |                           |
[INFO] [stderr]     |                           help: use the right value directly: `kv.0`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::op_ref)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref
[INFO] [stderr] 
[INFO] [stderr] warning: taken reference of right operand
[INFO] [stderr]    --> src/lib.rs:190:23
[INFO] [stderr]     |
[INFO] [stderr] 190 |             } else if k < &kv.0 {
[INFO] [stderr]     |                       ^^^^-----
[INFO] [stderr]     |                           |
[INFO] [stderr]     |                           help: use the right value directly: `kv.0`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref
[INFO] [stderr] 
[INFO] [stderr] warning: needlessly taken reference of left operand
[INFO] [stderr]    --> src/lib.rs:246:23
[INFO] [stderr]     |
[INFO] [stderr] 246 |             } else if &k < key {
[INFO] [stderr]     |                       --^^^^^^
[INFO] [stderr]     |                       |
[INFO] [stderr]     |                       help: use the left value directly: `k`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]    --> src/lib.rs:390:5
[INFO] [stderr]     |
[INFO] [stderr] 390 | /     if let &Some(ref n) = node {
[INFO] [stderr] 391 | |         if n.color == Color::Red {
[INFO] [stderr] 392 | |             return true;
[INFO] [stderr] 393 | |         }
[INFO] [stderr] 394 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::match_ref_pats)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]     |
[INFO] [stderr] 390 |     if let Some(ref n) = *node {
[INFO] [stderr]     |            ^^^^^^^^^^^   ^^^^^
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 0.87s
[INFO] running `"docker" "inspect" "3b3dd39a3e51dc2be7ddaaa6dba0b5d6d482e83e9981bb2f47bbd9d2170f7a13"`
[INFO] running `"docker" "rm" "-f" "3b3dd39a3e51dc2be7ddaaa6dba0b5d6d482e83e9981bb2f47bbd9d2170f7a13"`
[INFO] [stdout] 3b3dd39a3e51dc2be7ddaaa6dba0b5d6d482e83e9981bb2f47bbd9d2170f7a13