[INFO] crate livy_manager 0.2.0 is already in cache [INFO] extracting crate livy_manager 0.2.0 into work/ex/clippy-test-run/sources/stable/reg/livy_manager/0.2.0 [INFO] extracting crate livy_manager 0.2.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/livy_manager/0.2.0 [INFO] validating manifest of livy_manager-0.2.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of livy_manager-0.2.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing livy_manager-0.2.0 [INFO] finished frobbing livy_manager-0.2.0 [INFO] frobbed toml for livy_manager-0.2.0 written to work/ex/clippy-test-run/sources/stable/reg/livy_manager/0.2.0/Cargo.toml [INFO] started frobbing livy_manager-0.2.0 [INFO] finished frobbing livy_manager-0.2.0 [INFO] frobbed toml for livy_manager-0.2.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/livy_manager/0.2.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting livy_manager-0.2.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/livy_manager/0.2.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] b0362885cfb4db2d63834493f4c123fa0e78bad644f997f9d6eb2b792315a869 [INFO] running `"docker" "start" "-a" "b0362885cfb4db2d63834493f4c123fa0e78bad644f997f9d6eb2b792315a869"` [INFO] [stderr] Checking lber v0.1.6 [INFO] [stderr] Checking livy v0.5.0 [INFO] [stderr] Checking tokio-tls v0.1.4 [INFO] [stderr] Checking tokio-uds-proto v0.1.1 [INFO] [stderr] Checking ldap3 v0.5.1 [INFO] [stderr] Checking livy_manager v0.2.0 (/opt/crater/workdir) [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/frontend/html/index.rs:1:19 [INFO] [stderr] | [INFO] [stderr] 1 | pub const INDEX: &'static str = r##" [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/frontend/html/login.rs:1:19 [INFO] [stderr] | [INFO] [stderr] 1 | pub const LOGIN: &'static str = r##" [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/server.rs:29:21 [INFO] [stderr] | [INFO] [stderr] 29 | const COOKIE_NAME: &'static str = "_lmsid"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/server.rs:119:21 [INFO] [stderr] | [INFO] [stderr] 119 | return Ok(redirect(status::SeeOther, "/", Some(&uuid))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(redirect(status::SeeOther, "/", Some(&uuid)))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/server.rs:226:21 [INFO] [stderr] | [INFO] [stderr] 226 | Err(err) => return Err(IronError::new(StringError(format!("{}", err)), status::InternalServerError)), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(IronError::new(StringError(format!("{}", err)), status::InternalServerError))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/frontend/html/index.rs:1:19 [INFO] [stderr] | [INFO] [stderr] 1 | pub const INDEX: &'static str = r##" [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/frontend/html/login.rs:1:19 [INFO] [stderr] | [INFO] [stderr] 1 | pub const LOGIN: &'static str = r##" [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/server.rs:29:21 [INFO] [stderr] | [INFO] [stderr] 29 | const COOKIE_NAME: &'static str = "_lmsid"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/server.rs:119:21 [INFO] [stderr] | [INFO] [stderr] 119 | return Ok(redirect(status::SeeOther, "/", Some(&uuid))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(redirect(status::SeeOther, "/", Some(&uuid)))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/server.rs:226:21 [INFO] [stderr] | [INFO] [stderr] 226 | Err(err) => return Err(IronError::new(StringError(format!("{}", err)), status::InternalServerError)), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(IronError::new(StringError(format!("{}", err)), status::InternalServerError))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `cmd_args::CmdArgs` [INFO] [stderr] --> src/cmd_args.rs:12:5 [INFO] [stderr] | [INFO] [stderr] 12 | / pub fn new() -> CmdArgs { [INFO] [stderr] 13 | | let mut conf_path = String::new(); [INFO] [stderr] 14 | | let mut print_version = false; [INFO] [stderr] 15 | | [INFO] [stderr] ... | [INFO] [stderr] 33 | | } [INFO] [stderr] 34 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 5 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/server.rs:168:51 [INFO] [stderr] | [INFO] [stderr] 168 | return Err(IronError::new(StringError(format!("{}", err)), status::InternalServerError)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `err.to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/server.rs:226:59 [INFO] [stderr] | [INFO] [stderr] 226 | Err(err) => return Err(IronError::new(StringError(format!("{}", err)), status::InternalServerError)), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `err.to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/server.rs:334:13 [INFO] [stderr] | [INFO] [stderr] 334 | / match get_uuid(&req.headers) { [INFO] [stderr] 335 | | Some(uuid) => { [INFO] [stderr] 336 | | let arc = req.get::>().unwrap(); [INFO] [stderr] 337 | | let lock = arc.as_ref(); [INFO] [stderr] ... | [INFO] [stderr] 346 | | None => (), [INFO] [stderr] 347 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 334 | if let Some(uuid) = get_uuid(&req.headers) { [INFO] [stderr] 335 | let arc = req.get::>().unwrap(); [INFO] [stderr] 336 | let lock = arc.as_ref(); [INFO] [stderr] 337 | let user_sessions = lock.read().unwrap(); [INFO] [stderr] 338 | match user_sessions.map.get(&uuid) { [INFO] [stderr] 339 | Some(user_session) => { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/server.rs:339:21 [INFO] [stderr] | [INFO] [stderr] 339 | / match user_sessions.map.get(&uuid) { [INFO] [stderr] 340 | | Some(user_session) => { [INFO] [stderr] 341 | | req.extensions.insert::(user_session.clone()); [INFO] [stderr] 342 | | }, [INFO] [stderr] 343 | | None => (), [INFO] [stderr] 344 | | } [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 339 | if let Some(user_session) = user_sessions.map.get(&uuid) { [INFO] [stderr] 340 | req.extensions.insert::(user_session.clone()); [INFO] [stderr] 341 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/server.rs:361:51 [INFO] [stderr] | [INFO] [stderr] 361 | for kv in header.value_string().split(";") { [INFO] [stderr] | ^^^ help: try using a char instead: `';'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/server.rs:362:42 [INFO] [stderr] | [INFO] [stderr] 362 | let kv = kv.trim().split("=").collect::>(); [INFO] [stderr] | ^^^ help: try using a char instead: `'='` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `server::UserSessions` [INFO] [stderr] --> src/server.rs:378:5 [INFO] [stderr] | [INFO] [stderr] 378 | / pub fn new() -> UserSessions { [INFO] [stderr] 379 | | UserSessions { [INFO] [stderr] 380 | | map: HashMap::new(), [INFO] [stderr] 381 | | } [INFO] [stderr] 382 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 373 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `cmd_args::CmdArgs` [INFO] [stderr] --> src/cmd_args.rs:12:5 [INFO] [stderr] | [INFO] [stderr] 12 | / pub fn new() -> CmdArgs { [INFO] [stderr] 13 | | let mut conf_path = String::new(); [INFO] [stderr] 14 | | let mut print_version = false; [INFO] [stderr] 15 | | [INFO] [stderr] ... | [INFO] [stderr] 33 | | } [INFO] [stderr] 34 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 5 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/server.rs:168:51 [INFO] [stderr] | [INFO] [stderr] 168 | return Err(IronError::new(StringError(format!("{}", err)), status::InternalServerError)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `err.to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/server.rs:226:59 [INFO] [stderr] | [INFO] [stderr] 226 | Err(err) => return Err(IronError::new(StringError(format!("{}", err)), status::InternalServerError)), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `err.to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/server.rs:334:13 [INFO] [stderr] | [INFO] [stderr] 334 | / match get_uuid(&req.headers) { [INFO] [stderr] 335 | | Some(uuid) => { [INFO] [stderr] 336 | | let arc = req.get::>().unwrap(); [INFO] [stderr] 337 | | let lock = arc.as_ref(); [INFO] [stderr] ... | [INFO] [stderr] 346 | | None => (), [INFO] [stderr] 347 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 334 | if let Some(uuid) = get_uuid(&req.headers) { [INFO] [stderr] 335 | let arc = req.get::>().unwrap(); [INFO] [stderr] 336 | let lock = arc.as_ref(); [INFO] [stderr] 337 | let user_sessions = lock.read().unwrap(); [INFO] [stderr] 338 | match user_sessions.map.get(&uuid) { [INFO] [stderr] 339 | Some(user_session) => { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/server.rs:339:21 [INFO] [stderr] | [INFO] [stderr] 339 | / match user_sessions.map.get(&uuid) { [INFO] [stderr] 340 | | Some(user_session) => { [INFO] [stderr] 341 | | req.extensions.insert::(user_session.clone()); [INFO] [stderr] 342 | | }, [INFO] [stderr] 343 | | None => (), [INFO] [stderr] 344 | | } [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 339 | if let Some(user_session) = user_sessions.map.get(&uuid) { [INFO] [stderr] 340 | req.extensions.insert::(user_session.clone()); [INFO] [stderr] 341 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/server.rs:361:51 [INFO] [stderr] | [INFO] [stderr] 361 | for kv in header.value_string().split(";") { [INFO] [stderr] | ^^^ help: try using a char instead: `';'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/server.rs:362:42 [INFO] [stderr] | [INFO] [stderr] 362 | let kv = kv.trim().split("=").collect::>(); [INFO] [stderr] | ^^^ help: try using a char instead: `'='` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `server::UserSessions` [INFO] [stderr] --> src/server.rs:378:5 [INFO] [stderr] | [INFO] [stderr] 378 | / pub fn new() -> UserSessions { [INFO] [stderr] 379 | | UserSessions { [INFO] [stderr] 380 | | map: HashMap::new(), [INFO] [stderr] 381 | | } [INFO] [stderr] 382 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 373 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 35.17s [INFO] running `"docker" "inspect" "b0362885cfb4db2d63834493f4c123fa0e78bad644f997f9d6eb2b792315a869"` [INFO] running `"docker" "rm" "-f" "b0362885cfb4db2d63834493f4c123fa0e78bad644f997f9d6eb2b792315a869"` [INFO] [stdout] b0362885cfb4db2d63834493f4c123fa0e78bad644f997f9d6eb2b792315a869