[INFO] crate livy 0.5.0 is already in cache [INFO] extracting crate livy 0.5.0 into work/ex/clippy-test-run/sources/stable/reg/livy/0.5.0 [INFO] extracting crate livy 0.5.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/livy/0.5.0 [INFO] validating manifest of livy-0.5.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of livy-0.5.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing livy-0.5.0 [INFO] finished frobbing livy-0.5.0 [INFO] frobbed toml for livy-0.5.0 written to work/ex/clippy-test-run/sources/stable/reg/livy/0.5.0/Cargo.toml [INFO] started frobbing livy-0.5.0 [INFO] finished frobbing livy-0.5.0 [INFO] frobbed toml for livy-0.5.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/livy/0.5.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting livy-0.5.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/livy/0.5.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 6971b7af303dcbfa46a709d1cfca5c94449de81d2309c46e2541c67d4c0ca8f6 [INFO] running `"docker" "start" "-a" "6971b7af303dcbfa46a709d1cfca5c94449de81d2309c46e2541c67d4c0ca8f6"` [INFO] [stderr] Checking livy v0.5.0 (/opt/crater/workdir) [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/http.rs:75:9 [INFO] [stderr] | [INFO] [stderr] 75 | / match param { [INFO] [stderr] 76 | | Some(param) => { [INFO] [stderr] 77 | | if s.is_empty() { [INFO] [stderr] 78 | | s.push('?'); [INFO] [stderr] ... | [INFO] [stderr] 85 | | None => (), [INFO] [stderr] 86 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 75 | if let Some(param) = param { [INFO] [stderr] 76 | if s.is_empty() { [INFO] [stderr] 77 | s.push('?'); [INFO] [stderr] 78 | } else { [INFO] [stderr] 79 | s.push('&'); [INFO] [stderr] 80 | } [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/http.rs:104:20 [INFO] [stderr] | [INFO] [stderr] 104 | if s.ends_with("/") { [INFO] [stderr] | ^^^ help: try using a char instead: `'/'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/http.rs:75:9 [INFO] [stderr] | [INFO] [stderr] 75 | / match param { [INFO] [stderr] 76 | | Some(param) => { [INFO] [stderr] 77 | | if s.is_empty() { [INFO] [stderr] 78 | | s.push('?'); [INFO] [stderr] ... | [INFO] [stderr] 85 | | None => (), [INFO] [stderr] 86 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 75 | if let Some(param) = param { [INFO] [stderr] 76 | if s.is_empty() { [INFO] [stderr] 77 | s.push('?'); [INFO] [stderr] 78 | } else { [INFO] [stderr] 79 | s.push('&'); [INFO] [stderr] 80 | } [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/http.rs:104:20 [INFO] [stderr] | [INFO] [stderr] 104 | if s.ends_with("/") { [INFO] [stderr] | ^^^ help: try using a char instead: `'/'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/client.rs:477:53 [INFO] [stderr] | [INFO] [stderr] 477 | let client = Client::new(test_case.url, test_case.gssnegotiate.clone(), test_case.username.clone()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `test_case.gssnegotiate` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 3.84s [INFO] running `"docker" "inspect" "6971b7af303dcbfa46a709d1cfca5c94449de81d2309c46e2541c67d4c0ca8f6"` [INFO] running `"docker" "rm" "-f" "6971b7af303dcbfa46a709d1cfca5c94449de81d2309c46e2541c67d4c0ca8f6"` [INFO] [stdout] 6971b7af303dcbfa46a709d1cfca5c94449de81d2309c46e2541c67d4c0ca8f6