[INFO] crate livesplit-core 0.10.0 is already in cache [INFO] extracting crate livesplit-core 0.10.0 into work/ex/clippy-test-run/sources/stable/reg/livesplit-core/0.10.0 [INFO] extracting crate livesplit-core 0.10.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/livesplit-core/0.10.0 [INFO] validating manifest of livesplit-core-0.10.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of livesplit-core-0.10.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing livesplit-core-0.10.0 [INFO] finished frobbing livesplit-core-0.10.0 [INFO] frobbed toml for livesplit-core-0.10.0 written to work/ex/clippy-test-run/sources/stable/reg/livesplit-core/0.10.0/Cargo.toml [INFO] started frobbing livesplit-core-0.10.0 [INFO] finished frobbing livesplit-core-0.10.0 [INFO] frobbed toml for livesplit-core-0.10.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/livesplit-core/0.10.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting livesplit-core-0.10.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/livesplit-core/0.10.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 3fd2997514e39e164ae7b2176d3b1a2b09f008e32a17b367916ada235b0c778e [INFO] running `"docker" "start" "-a" "3fd2997514e39e164ae7b2176d3b1a2b09f008e32a17b367916ada235b0c778e"` [INFO] [stderr] Compiling palette v0.4.1 [INFO] [stderr] Checking unchecked-index v0.2.2 [INFO] [stderr] Checking rawslice v0.1.0 [INFO] [stderr] Checking indexmap v1.0.2 [INFO] [stderr] Checking chrono v0.4.6 [INFO] [stderr] Compiling derive_more v0.12.0 [INFO] [stderr] Checking promising-future v0.2.4 [INFO] [stderr] Checking image v0.20.1 [INFO] [stderr] Checking odds v0.3.1 [INFO] [stderr] Checking livesplit-hotkey v0.4.0 [INFO] [stderr] Checking livesplit-core v0.10.0 (/opt/crater/workdir) [INFO] [stderr] warning: lint name `clippy` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/lib.rs:2:23 [INFO] [stderr] | [INFO] [stderr] 2 | #![warn(missing_docs, clippy)] [INFO] [stderr] | ^^^^^^ help: change it to: `clippy::all` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(renamed_and_removed_lints)] on by default [INFO] [stderr] [INFO] [stderr] warning: lint name `block_in_if_condition_stmt` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/lib.rs:6:10 [INFO] [stderr] | [INFO] [stderr] 6 | #![allow(block_in_if_condition_stmt, redundant_closure_call)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::block_in_if_condition_stmt` [INFO] [stderr] [INFO] [stderr] warning: lint name `redundant_closure_call` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/lib.rs:6:38 [INFO] [stderr] | [INFO] [stderr] 6 | #![allow(block_in_if_condition_stmt, redundant_closure_call)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::redundant_closure_call` [INFO] [stderr] [INFO] [stderr] warning: lint name `needless_range_loop` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/analysis/sum_of_segments/best.rs:92:9 [INFO] [stderr] | [INFO] [stderr] 92 | #[allow(needless_range_loop)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::needless_range_loop` [INFO] [stderr] [INFO] [stderr] warning: lint name `needless_range_loop` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/analysis/sum_of_segments/worst.rs:77:9 [INFO] [stderr] | [INFO] [stderr] 77 | #[allow(needless_range_loop)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::needless_range_loop` [INFO] [stderr] [INFO] [stderr] warning: lint name `needless_range_loop` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/comparison/average_segments.rs:30:13 [INFO] [stderr] | [INFO] [stderr] 30 | #[allow(needless_range_loop)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::needless_range_loop` [INFO] [stderr] [INFO] [stderr] warning: lint name `needless_range_loop` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/comparison/median_segments.rs:30:13 [INFO] [stderr] | [INFO] [stderr] 30 | #[allow(needless_range_loop)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::needless_range_loop` [INFO] [stderr] [INFO] [stderr] warning: lint name `needless_pass_by_value` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/component/separator.rs:59:13 [INFO] [stderr] | [INFO] [stderr] 59 | #[allow(needless_pass_by_value)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::needless_pass_by_value` [INFO] [stderr] [INFO] [stderr] warning: lint name `needless_pass_by_value` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/run/editor/cleaning.rs:132:13 [INFO] [stderr] | [INFO] [stderr] 132 | #[allow(needless_pass_by_value)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::needless_pass_by_value` [INFO] [stderr] [INFO] [stderr] warning: lint name `new_ret_no_self` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/timing/formatter/none_wrapper.rs:39:13 [INFO] [stderr] | [INFO] [stderr] 39 | #[allow(new_ret_no_self)] [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: change it to: `clippy::new_ret_no_self` [INFO] [stderr] [INFO] [stderr] warning: lint name `new_ret_no_self` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/timing/formatter/none_wrapper.rs:47:13 [INFO] [stderr] | [INFO] [stderr] 47 | #[allow(new_ret_no_self)] [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: change it to: `clippy::new_ret_no_self` [INFO] [stderr] [INFO] [stderr] warning: lint name `clippy` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/lib.rs:2:23 [INFO] [stderr] | [INFO] [stderr] 2 | #![warn(missing_docs, clippy)] [INFO] [stderr] | ^^^^^^ help: change it to: `clippy::all` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(renamed_and_removed_lints)] on by default [INFO] [stderr] [INFO] [stderr] warning: lint name `block_in_if_condition_stmt` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/lib.rs:6:10 [INFO] [stderr] | [INFO] [stderr] 6 | #![allow(block_in_if_condition_stmt, redundant_closure_call)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::block_in_if_condition_stmt` [INFO] [stderr] [INFO] [stderr] warning: lint name `redundant_closure_call` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/lib.rs:6:38 [INFO] [stderr] | [INFO] [stderr] 6 | #![allow(block_in_if_condition_stmt, redundant_closure_call)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::redundant_closure_call` [INFO] [stderr] [INFO] [stderr] warning: lint name `needless_range_loop` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/analysis/sum_of_segments/best.rs:92:9 [INFO] [stderr] | [INFO] [stderr] 92 | #[allow(needless_range_loop)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::needless_range_loop` [INFO] [stderr] [INFO] [stderr] warning: lint name `needless_range_loop` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/analysis/sum_of_segments/worst.rs:77:9 [INFO] [stderr] | [INFO] [stderr] 77 | #[allow(needless_range_loop)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::needless_range_loop` [INFO] [stderr] [INFO] [stderr] warning: lint name `needless_range_loop` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/comparison/average_segments.rs:30:13 [INFO] [stderr] | [INFO] [stderr] 30 | #[allow(needless_range_loop)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::needless_range_loop` [INFO] [stderr] [INFO] [stderr] warning: lint name `needless_range_loop` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/comparison/median_segments.rs:30:13 [INFO] [stderr] | [INFO] [stderr] 30 | #[allow(needless_range_loop)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::needless_range_loop` [INFO] [stderr] [INFO] [stderr] warning: lint name `needless_pass_by_value` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/component/separator.rs:59:13 [INFO] [stderr] | [INFO] [stderr] 59 | #[allow(needless_pass_by_value)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::needless_pass_by_value` [INFO] [stderr] [INFO] [stderr] warning: lint name `needless_pass_by_value` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/run/editor/cleaning.rs:132:13 [INFO] [stderr] | [INFO] [stderr] 132 | #[allow(needless_pass_by_value)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::needless_pass_by_value` [INFO] [stderr] [INFO] [stderr] warning: lint name `new_ret_no_self` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/timing/formatter/none_wrapper.rs:39:13 [INFO] [stderr] | [INFO] [stderr] 39 | #[allow(new_ret_no_self)] [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: change it to: `clippy::new_ret_no_self` [INFO] [stderr] [INFO] [stderr] warning: lint name `new_ret_no_self` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/timing/formatter/none_wrapper.rs:47:13 [INFO] [stderr] | [INFO] [stderr] 47 | #[allow(new_ret_no_self)] [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: change it to: `clippy::new_ret_no_self` [INFO] [stderr] [INFO] [stderr] warning: lint name `clippy` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/lib.rs:2:23 [INFO] [stderr] | [INFO] [stderr] 2 | #![warn(missing_docs, clippy)] [INFO] [stderr] | ^^^^^^ help: change it to: `clippy::all` [INFO] [stderr] [INFO] [stderr] warning: lint name `clippy` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/lib.rs:2:23 [INFO] [stderr] | [INFO] [stderr] 2 | #![warn(missing_docs, clippy)] [INFO] [stderr] | ^^^^^^ help: change it to: `clippy::all` [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/analysis/state_helper.rs:21:35 [INFO] [stderr] | [INFO] [stderr] 21 | for segment in run.segments()[..split_number + 1].iter().rev() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: use: `..=split_number` [INFO] [stderr] | [INFO] [stderr] note: lint level defined here [INFO] [stderr] --> src/lib.rs:2:23 [INFO] [stderr] | [INFO] [stderr] 2 | #![warn(missing_docs, clippy)] [INFO] [stderr] | ^^^^^^ [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] implied by #[warn(clippy::all)] [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (10/7) [INFO] [stderr] --> src/component/graph.rs:435:5 [INFO] [stderr] | [INFO] [stderr] 435 | / fn calculate_left_side_coordinates( [INFO] [stderr] 436 | | &self, [INFO] [stderr] 437 | | draw_info: &DrawInfo, [INFO] [stderr] 438 | | timer: &Timer, [INFO] [stderr] ... | [INFO] [stderr] 464 | | } [INFO] [stderr] 465 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] note: lint level defined here [INFO] [stderr] --> src/lib.rs:2:23 [INFO] [stderr] | [INFO] [stderr] 2 | #![warn(missing_docs, clippy)] [INFO] [stderr] | ^^^^^^ [INFO] [stderr] = note: #[warn(clippy::too_many_arguments)] implied by #[warn(clippy::all)] [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (10/7) [INFO] [stderr] --> src/component/graph.rs:467:5 [INFO] [stderr] | [INFO] [stderr] 467 | / fn calculate_right_side_coordinates( [INFO] [stderr] 468 | | &self, [INFO] [stderr] 469 | | draw_info: &DrawInfo, [INFO] [stderr] 470 | | timer: &Timer, [INFO] [stderr] ... | [INFO] [stderr] 496 | | } [INFO] [stderr] 497 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/analysis/state_helper.rs:21:35 [INFO] [stderr] | [INFO] [stderr] 21 | for segment in run.segments()[..split_number + 1].iter().rev() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: use: `..=split_number` [INFO] [stderr] | [INFO] [stderr] note: lint level defined here [INFO] [stderr] --> src/lib.rs:2:23 [INFO] [stderr] | [INFO] [stderr] 2 | #![warn(missing_docs, clippy)] [INFO] [stderr] | ^^^^^^ [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] implied by #[warn(clippy::all)] [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/run/editor/mod.rs:418:18 [INFO] [stderr] | [INFO] [stderr] 418 | for x in min_index..max_index + 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `min_index..=max_index` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/run/editor/mod.rs:443:18 [INFO] [stderr] | [INFO] [stderr] 443 | for x in min_index..max_index + 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `min_index..=max_index` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/run/editor/mod.rs:468:26 [INFO] [stderr] | [INFO] [stderr] 468 | for run_index in min_index..max_index + 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `min_index..=max_index` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/run/editor/mod.rs:575:26 [INFO] [stderr] | [INFO] [stderr] 575 | for run_index in min_index..max_index + 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `min_index..=max_index` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/run/editor/mod.rs:792:38 [INFO] [stderr] | [INFO] [stderr] 792 | &mut comparisons[dst_index..src_index + 1], [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `dst_index..=src_index` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/run/editor/mod.rs:796:46 [INFO] [stderr] | [INFO] [stderr] 796 | rotate_left(&mut comparisons[src_index..dst_index + 1], 1); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `src_index..=dst_index` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (10/7) [INFO] [stderr] --> src/component/graph.rs:435:5 [INFO] [stderr] | [INFO] [stderr] 435 | / fn calculate_left_side_coordinates( [INFO] [stderr] 436 | | &self, [INFO] [stderr] 437 | | draw_info: &DrawInfo, [INFO] [stderr] 438 | | timer: &Timer, [INFO] [stderr] ... | [INFO] [stderr] 464 | | } [INFO] [stderr] 465 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] note: lint level defined here [INFO] [stderr] --> src/lib.rs:2:23 [INFO] [stderr] | [INFO] [stderr] 2 | #![warn(missing_docs, clippy)] [INFO] [stderr] | ^^^^^^ [INFO] [stderr] = note: #[warn(clippy::too_many_arguments)] implied by #[warn(clippy::all)] [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (10/7) [INFO] [stderr] --> src/component/graph.rs:467:5 [INFO] [stderr] | [INFO] [stderr] 467 | / fn calculate_right_side_coordinates( [INFO] [stderr] 468 | | &self, [INFO] [stderr] 469 | | draw_info: &DrawInfo, [INFO] [stderr] 470 | | timer: &Timer, [INFO] [stderr] ... | [INFO] [stderr] 496 | | } [INFO] [stderr] 497 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/run/editor/mod.rs:418:18 [INFO] [stderr] | [INFO] [stderr] 418 | for x in min_index..max_index + 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `min_index..=max_index` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/run/editor/mod.rs:443:18 [INFO] [stderr] | [INFO] [stderr] 443 | for x in min_index..max_index + 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `min_index..=max_index` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/run/editor/mod.rs:468:26 [INFO] [stderr] | [INFO] [stderr] 468 | for run_index in min_index..max_index + 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `min_index..=max_index` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/run/editor/mod.rs:575:26 [INFO] [stderr] | [INFO] [stderr] 575 | for run_index in min_index..max_index + 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `min_index..=max_index` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/run/editor/mod.rs:792:38 [INFO] [stderr] | [INFO] [stderr] 792 | &mut comparisons[dst_index..src_index + 1], [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `dst_index..=src_index` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/run/editor/mod.rs:796:46 [INFO] [stderr] | [INFO] [stderr] 796 | rotate_left(&mut comparisons[src_index..dst_index + 1], 1); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `src_index..=dst_index` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 30 [INFO] [stderr] --> src/timing/timer/tests/mod.rs:494:1 [INFO] [stderr] | [INFO] [stderr] 494 | / fn reset_and_set_attempt_as_pb() { [INFO] [stderr] 495 | | let mut timer = timer(); [INFO] [stderr] 496 | | [INFO] [stderr] 497 | | // Call it for the phase NotRunning [INFO] [stderr] ... | [INFO] [stderr] 617 | | assert!(attempt.ended().unwrap().time >= attempt.started().unwrap().time); [INFO] [stderr] 618 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] note: lint level defined here [INFO] [stderr] --> src/lib.rs:2:23 [INFO] [stderr] | [INFO] [stderr] 2 | #![warn(missing_docs, clippy)] [INFO] [stderr] | ^^^^^^ [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] implied by #[warn(clippy::all)] [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 30.72s [INFO] running `"docker" "inspect" "3fd2997514e39e164ae7b2176d3b1a2b09f008e32a17b367916ada235b0c778e"` [INFO] running `"docker" "rm" "-f" "3fd2997514e39e164ae7b2176d3b1a2b09f008e32a17b367916ada235b0c778e"` [INFO] [stdout] 3fd2997514e39e164ae7b2176d3b1a2b09f008e32a17b367916ada235b0c778e