[INFO] crate littletest 0.2.2 is already in cache [INFO] extracting crate littletest 0.2.2 into work/ex/clippy-test-run/sources/stable/reg/littletest/0.2.2 [INFO] extracting crate littletest 0.2.2 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/littletest/0.2.2 [INFO] validating manifest of littletest-0.2.2 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of littletest-0.2.2 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing littletest-0.2.2 [INFO] finished frobbing littletest-0.2.2 [INFO] frobbed toml for littletest-0.2.2 written to work/ex/clippy-test-run/sources/stable/reg/littletest/0.2.2/Cargo.toml [INFO] started frobbing littletest-0.2.2 [INFO] finished frobbing littletest-0.2.2 [INFO] frobbed toml for littletest-0.2.2 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/littletest/0.2.2/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting littletest-0.2.2 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/littletest/0.2.2:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 77f95873374001de16283a1e5ff5180740419c5e4a358b082cf2f1b53fc35b63 [INFO] running `"docker" "start" "-a" "77f95873374001de16283a1e5ff5180740419c5e4a358b082cf2f1b53fc35b63"` [INFO] [stderr] Checking rayon v0.5.0 [INFO] [stderr] Checking littletest v0.2.2 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/reporters.rs:18:29 [INFO] [stderr] | [INFO] [stderr] 18 | CompositeReporter { reporters: reporters } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `reporters` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/reporters.rs:94:13 [INFO] [stderr] | [INFO] [stderr] 94 | time_s: time_s, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `time_s` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:22:22 [INFO] [stderr] | [INFO] [stderr] 22 | TestRunner { parallelism: parallelism } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `parallelism` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/reporters.rs:18:29 [INFO] [stderr] | [INFO] [stderr] 18 | CompositeReporter { reporters: reporters } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `reporters` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/reporters.rs:94:13 [INFO] [stderr] | [INFO] [stderr] 94 | time_s: time_s, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `time_s` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:22:22 [INFO] [stderr] | [INFO] [stderr] 22 | TestRunner { parallelism: parallelism } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `parallelism` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: digits grouped inconsistently by underscores [INFO] [stderr] --> src/reporters.rs:92:81 [INFO] [stderr] | [INFO] [stderr] 92 | let time_s = elapsed.as_secs() as f64 + elapsed.subsec_nanos() as f64 / 1000_000_000f64; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider: `1_000_000_000f64` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::inconsistent_digit_grouping)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#inconsistent_digit_grouping [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/reporters.rs:92:49 [INFO] [stderr] | [INFO] [stderr] 92 | let time_s = elapsed.as_secs() as f64 + elapsed.subsec_nanos() as f64 / 1000_000_000f64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(elapsed.subsec_nanos())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/lib.rs:25:36 [INFO] [stderr] | [INFO] [stderr] 25 | pub fn run<'run>(&self, tests: &Vec>) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `&[Box]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the Vec [INFO] [stderr] --> src/lib.rs:41:33 [INFO] [stderr] | [INFO] [stderr] 41 | for result in tests.into_iter().map(|test| test.run()) { [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::into_iter_on_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: digits grouped inconsistently by underscores [INFO] [stderr] --> src/reporters.rs:92:81 [INFO] [stderr] | [INFO] [stderr] 92 | let time_s = elapsed.as_secs() as f64 + elapsed.subsec_nanos() as f64 / 1000_000_000f64; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider: `1_000_000_000f64` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::inconsistent_digit_grouping)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#inconsistent_digit_grouping [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/reporters.rs:92:49 [INFO] [stderr] | [INFO] [stderr] 92 | let time_s = elapsed.as_secs() as f64 + elapsed.subsec_nanos() as f64 / 1000_000_000f64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(elapsed.subsec_nanos())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/lib.rs:25:36 [INFO] [stderr] | [INFO] [stderr] 25 | pub fn run<'run>(&self, tests: &Vec>) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `&[Box]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the Vec [INFO] [stderr] --> src/lib.rs:41:33 [INFO] [stderr] | [INFO] [stderr] 41 | for result in tests.into_iter().map(|test| test.run()) { [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::into_iter_on_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> tests/lib.rs:11:20 [INFO] [stderr] | [INFO] [stderr] 11 | TestCase { result: result } [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `result` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 4.88s [INFO] running `"docker" "inspect" "77f95873374001de16283a1e5ff5180740419c5e4a358b082cf2f1b53fc35b63"` [INFO] running `"docker" "rm" "-f" "77f95873374001de16283a1e5ff5180740419c5e4a358b082cf2f1b53fc35b63"` [INFO] [stdout] 77f95873374001de16283a1e5ff5180740419c5e4a358b082cf2f1b53fc35b63