[INFO] crate little_boxes 1.6.0 is already in cache [INFO] extracting crate little_boxes 1.6.0 into work/ex/clippy-test-run/sources/stable/reg/little_boxes/1.6.0 [INFO] extracting crate little_boxes 1.6.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/little_boxes/1.6.0 [INFO] validating manifest of little_boxes-1.6.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of little_boxes-1.6.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing little_boxes-1.6.0 [INFO] finished frobbing little_boxes-1.6.0 [INFO] frobbed toml for little_boxes-1.6.0 written to work/ex/clippy-test-run/sources/stable/reg/little_boxes/1.6.0/Cargo.toml [INFO] started frobbing little_boxes-1.6.0 [INFO] finished frobbing little_boxes-1.6.0 [INFO] frobbed toml for little_boxes-1.6.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/little_boxes/1.6.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting little_boxes-1.6.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/little_boxes/1.6.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] da3c09b1d884fa72fe0f50c12a430753145709ae5959a53de3dd8c96ec58506b [INFO] running `"docker" "start" "-a" "da3c09b1d884fa72fe0f50c12a430753145709ae5959a53de3dd8c96ec58506b"` [INFO] [stderr] Checking docopt v0.8.3 [INFO] [stderr] Checking little_boxes v1.6.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/draw_box.rs:41:13 [INFO] [stderr] | [INFO] [stderr] 41 | content: content, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `content` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/draw_box.rs:42:13 [INFO] [stderr] | [INFO] [stderr] 42 | charset: charset, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `charset` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/draw_box.rs:43:13 [INFO] [stderr] | [INFO] [stderr] 43 | max_length: max_length, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `max_length` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/draw_box.rs:101:13 [INFO] [stderr] | [INFO] [stderr] 101 | content: content, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `content` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/draw_box.rs:102:13 [INFO] [stderr] | [INFO] [stderr] 102 | charset: charset, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `charset` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/draw_box.rs:103:13 [INFO] [stderr] | [INFO] [stderr] 103 | max_length: max_length, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `max_length` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/draw_box.rs:41:13 [INFO] [stderr] | [INFO] [stderr] 41 | content: content, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `content` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/draw_box.rs:42:13 [INFO] [stderr] | [INFO] [stderr] 42 | charset: charset, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `charset` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/draw_box.rs:43:13 [INFO] [stderr] | [INFO] [stderr] 43 | max_length: max_length, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `max_length` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/draw_box.rs:101:13 [INFO] [stderr] | [INFO] [stderr] 101 | content: content, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `content` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/draw_box.rs:102:13 [INFO] [stderr] | [INFO] [stderr] 102 | charset: charset, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `charset` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/draw_box.rs:103:13 [INFO] [stderr] | [INFO] [stderr] 103 | max_length: max_length, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `max_length` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/draw_box.rs:18:31 [INFO] [stderr] | [INFO] [stderr] 18 | fn count_visible_chars(input: &String) -> usize { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:71:13 [INFO] [stderr] | [INFO] [stderr] 71 | / match get_charset(charset_name) { [INFO] [stderr] 72 | | Some(charset) => { [INFO] [stderr] 73 | | println!("{}:", charset_name); [INFO] [stderr] 74 | | print_box(input.clone(), args.flag_title.clone(), charset); [INFO] [stderr] 75 | | } [INFO] [stderr] 76 | | None => {} [INFO] [stderr] 77 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 71 | if let Some(charset) = get_charset(charset_name) { [INFO] [stderr] 72 | println!("{}:", charset_name); [INFO] [stderr] 73 | print_box(input.clone(), args.flag_title.clone(), charset); [INFO] [stderr] 74 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/draw_box.rs:18:31 [INFO] [stderr] | [INFO] [stderr] 18 | fn count_visible_chars(input: &String) -> usize { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:71:13 [INFO] [stderr] | [INFO] [stderr] 71 | / match get_charset(charset_name) { [INFO] [stderr] 72 | | Some(charset) => { [INFO] [stderr] 73 | | println!("{}:", charset_name); [INFO] [stderr] 74 | | print_box(input.clone(), args.flag_title.clone(), charset); [INFO] [stderr] 75 | | } [INFO] [stderr] 76 | | None => {} [INFO] [stderr] 77 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 71 | if let Some(charset) = get_charset(charset_name) { [INFO] [stderr] 72 | println!("{}:", charset_name); [INFO] [stderr] 73 | print_box(input.clone(), args.flag_title.clone(), charset); [INFO] [stderr] 74 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 4.72s [INFO] running `"docker" "inspect" "da3c09b1d884fa72fe0f50c12a430753145709ae5959a53de3dd8c96ec58506b"` [INFO] running `"docker" "rm" "-f" "da3c09b1d884fa72fe0f50c12a430753145709ae5959a53de3dd8c96ec58506b"` [INFO] [stdout] da3c09b1d884fa72fe0f50c12a430753145709ae5959a53de3dd8c96ec58506b