[INFO] crate little-skeptic 0.15.0 is already in cache [INFO] extracting crate little-skeptic 0.15.0 into work/ex/clippy-test-run/sources/stable/reg/little-skeptic/0.15.0 [INFO] extracting crate little-skeptic 0.15.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/little-skeptic/0.15.0 [INFO] validating manifest of little-skeptic-0.15.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of little-skeptic-0.15.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing little-skeptic-0.15.0 [INFO] finished frobbing little-skeptic-0.15.0 [INFO] frobbed toml for little-skeptic-0.15.0 written to work/ex/clippy-test-run/sources/stable/reg/little-skeptic/0.15.0/Cargo.toml [INFO] started frobbing little-skeptic-0.15.0 [INFO] finished frobbing little-skeptic-0.15.0 [INFO] frobbed toml for little-skeptic-0.15.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/little-skeptic/0.15.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting little-skeptic-0.15.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/little-skeptic/0.15.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 6410cc2551030cc6c3bdf96cff2176ae5e598b56801e88c4f99093e80592a44c [INFO] running `"docker" "start" "-a" "6410cc2551030cc6c3bdf96cff2176ae5e598b56801e88c4f99093e80592a44c"` [INFO] [stderr] Checking unindent v0.1.3 [INFO] [stderr] Checking cargo_metadata v0.3.3 [INFO] [stderr] Checking handlebars v1.1.0 [INFO] [stderr] Checking little-skeptic v0.15.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> lib.rs:120:9 [INFO] [stderr] | [INFO] [stderr] 120 | out_file: out_file, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `out_file` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> lib.rs:121:9 [INFO] [stderr] | [INFO] [stderr] 121 | docs: docs, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `docs` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> lib.rs:168:9 [INFO] [stderr] | [INFO] [stderr] 168 | doc_tests: doc_tests, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `doc_tests` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> lib.rs:261:29 [INFO] [stderr] | [INFO] [stderr] 261 | name: name, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: using `writeln!(s, "")` [INFO] [stderr] --> lib.rs:496:5 [INFO] [stderr] | [INFO] [stderr] 496 | writeln!(s, "")?; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: replace it with: `writeln!(s)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::writeln_empty_string)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#writeln_empty_string [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> lib.rs:652:17 [INFO] [stderr] | [INFO] [stderr] 652 | rlib: rlib, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `rlib` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> lib.rs:653:17 [INFO] [stderr] | [INFO] [stderr] 653 | mtime: mtime, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `mtime` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> lib.rs:120:9 [INFO] [stderr] | [INFO] [stderr] 120 | out_file: out_file, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `out_file` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> lib.rs:121:9 [INFO] [stderr] | [INFO] [stderr] 121 | docs: docs, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `docs` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> lib.rs:168:9 [INFO] [stderr] | [INFO] [stderr] 168 | doc_tests: doc_tests, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `doc_tests` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> lib.rs:261:29 [INFO] [stderr] | [INFO] [stderr] 261 | name: name, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: using `writeln!(s, "")` [INFO] [stderr] --> lib.rs:496:5 [INFO] [stderr] | [INFO] [stderr] 496 | writeln!(s, "")?; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: replace it with: `writeln!(s)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::writeln_empty_string)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#writeln_empty_string [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> lib.rs:652:17 [INFO] [stderr] | [INFO] [stderr] 652 | rlib: rlib, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `rlib` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> lib.rs:653:17 [INFO] [stderr] | [INFO] [stderr] 653 | mtime: mtime, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `mtime` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::ascii::AsciiExt': use inherent methods instead [INFO] [stderr] --> lib.rs:329:9 [INFO] [stderr] | [INFO] [stderr] 329 | use std::ascii::AsciiExt; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::ascii::AsciiExt': use inherent methods instead [INFO] [stderr] --> lib.rs:329:9 [INFO] [stderr] | [INFO] [stderr] 329 | use std::ascii::AsciiExt; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] [INFO] [stderr] error: useless lint attribute [INFO] [stderr] --> lib.rs:328:1 [INFO] [stderr] | [INFO] [stderr] 328 | #[allow(unused)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: if you just forgot a `!`, use: `#![allow(unused)]` [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::useless_attribute)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_attribute [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> lib.rs:422:62 [INFO] [stderr] | [INFO] [stderr] 422 | let template = doc_test.templates.get(t).expect(&format!( [INFO] [stderr] | ______________________________________________________________^ [INFO] [stderr] 423 | | "template {} not found for {}", [INFO] [stderr] 424 | | t, [INFO] [stderr] 425 | | doc_test.path.display() [INFO] [stderr] 426 | | )); [INFO] [stderr] | |______________________^ help: try this: `unwrap_or_else(|| panic!("template {} not found for {}", t))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::expect_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> lib.rs:435:8 [INFO] [stderr] | [INFO] [stderr] 435 | Ok(write_if_contents_changed(&config.out_file, &out)?) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unit_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead [INFO] [stderr] | [INFO] [stderr] 435 | Ok(()) [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] warning: use of `write!(stdout(), ...).unwrap()`. Consider using `print!` instead [INFO] [stderr] --> lib.rs:826:9 [INFO] [stderr] | [INFO] [stderr] 826 | / write!( [INFO] [stderr] 827 | | io::stdout(), [INFO] [stderr] 828 | | "{}", [INFO] [stderr] 829 | | String::from_utf8(output.stdout).unwrap() [INFO] [stderr] 830 | | ).unwrap(); [INFO] [stderr] | |__________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::explicit_write)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_write [INFO] [stderr] [INFO] [stderr] warning: use of `write!(stderr(), ...).unwrap()`. Consider using `eprint!` instead [INFO] [stderr] --> lib.rs:831:9 [INFO] [stderr] | [INFO] [stderr] 831 | / write!( [INFO] [stderr] 832 | | io::stderr(), [INFO] [stderr] 833 | | "{}", [INFO] [stderr] 834 | | String::from_utf8(output.stderr).unwrap() [INFO] [stderr] 835 | | ).unwrap(); [INFO] [stderr] | |__________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_write [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `little-skeptic`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: useless lint attribute [INFO] [stderr] --> lib.rs:328:1 [INFO] [stderr] | [INFO] [stderr] 328 | #[allow(unused)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: if you just forgot a `!`, use: `#![allow(unused)]` [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::useless_attribute)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_attribute [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> lib.rs:422:62 [INFO] [stderr] | [INFO] [stderr] 422 | let template = doc_test.templates.get(t).expect(&format!( [INFO] [stderr] | ______________________________________________________________^ [INFO] [stderr] 423 | | "template {} not found for {}", [INFO] [stderr] 424 | | t, [INFO] [stderr] 425 | | doc_test.path.display() [INFO] [stderr] 426 | | )); [INFO] [stderr] | |______________________^ help: try this: `unwrap_or_else(|| panic!("template {} not found for {}", t))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::expect_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> lib.rs:435:8 [INFO] [stderr] | [INFO] [stderr] 435 | Ok(write_if_contents_changed(&config.out_file, &out)?) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unit_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead [INFO] [stderr] | [INFO] [stderr] 435 | Ok(()) [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] warning: use of `write!(stdout(), ...).unwrap()`. Consider using `print!` instead [INFO] [stderr] --> lib.rs:826:9 [INFO] [stderr] | [INFO] [stderr] 826 | / write!( [INFO] [stderr] 827 | | io::stdout(), [INFO] [stderr] 828 | | "{}", [INFO] [stderr] 829 | | String::from_utf8(output.stdout).unwrap() [INFO] [stderr] 830 | | ).unwrap(); [INFO] [stderr] | |__________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::explicit_write)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_write [INFO] [stderr] [INFO] [stderr] warning: use of `write!(stderr(), ...).unwrap()`. Consider using `eprint!` instead [INFO] [stderr] --> lib.rs:831:9 [INFO] [stderr] | [INFO] [stderr] 831 | / write!( [INFO] [stderr] 832 | | io::stderr(), [INFO] [stderr] 833 | | "{}", [INFO] [stderr] 834 | | String::from_utf8(output.stderr).unwrap() [INFO] [stderr] 835 | | ).unwrap(); [INFO] [stderr] | |__________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_write [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> lib.rs:934:18 [INFO] [stderr] | [INFO] [stderr] 934 | .map(|test| get_line_number_from_test_name(test)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `get_line_number_from_test_name` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> lib.rs:976:18 [INFO] [stderr] | [INFO] [stderr] 976 | .map(|test| get_line_number_from_test_name(test)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `get_line_number_from_test_name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `little-skeptic`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "6410cc2551030cc6c3bdf96cff2176ae5e598b56801e88c4f99093e80592a44c"` [INFO] running `"docker" "rm" "-f" "6410cc2551030cc6c3bdf96cff2176ae5e598b56801e88c4f99093e80592a44c"` [INFO] [stdout] 6410cc2551030cc6c3bdf96cff2176ae5e598b56801e88c4f99093e80592a44c