[INFO] crate lit 0.3.3 is already in cache
[INFO] extracting crate lit 0.3.3 into work/ex/clippy-test-run/sources/stable/reg/lit/0.3.3
[INFO] extracting crate lit 0.3.3 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/lit/0.3.3
[INFO] validating manifest of lit-0.3.3 on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of lit-0.3.3 on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing lit-0.3.3
[INFO] finished frobbing lit-0.3.3
[INFO] frobbed toml for lit-0.3.3 written to work/ex/clippy-test-run/sources/stable/reg/lit/0.3.3/Cargo.toml
[INFO] started frobbing lit-0.3.3
[INFO] finished frobbing lit-0.3.3
[INFO] frobbed toml for lit-0.3.3 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/lit/0.3.3/Cargo.toml
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting lit-0.3.3 against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/lit/0.3.3:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 2ff4b98e7ae05bbc4cf55cd55dcd850cf5fd6562b71fdb03d19c064ff8b3f9c7
[INFO] running `"docker" "start" "-a" "2ff4b98e7ae05bbc4cf55cd55dcd850cf5fd6562b71fdb03d19c064ff8b3f9c7"`
[INFO] [stderr]     Checking lit v0.3.3 (/opt/crater/workdir)
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/model.rs:116:13
[INFO] [stderr]     |
[INFO] [stderr] 116 |             command: command,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^ help: replace it with: `command`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/model.rs:117:13
[INFO] [stderr]     |
[INFO] [stderr] 117 |             line: line,
[INFO] [stderr]     |             ^^^^^^^^^^ help: replace it with: `line`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/parse.rs:36:9
[INFO] [stderr]    |
[INFO] [stderr] 36 |         directives: directives,
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `directives`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/parse.rs:141:19
[INFO] [stderr]     |
[INFO] [stderr] 141 |     TextPattern { components: components }
[INFO] [stderr]     |                   ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `components`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/run/test_evaluator.rs:33:25
[INFO] [stderr]    |
[INFO] [stderr] 33 |         TestEvaluator { invocation: invocation }
[INFO] [stderr]    |                         ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `invocation`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/run/test_evaluator.rs:205:17
[INFO] [stderr]     |
[INFO] [stderr] 205 |         Lines { lines: lines, current: 0 }
[INFO] [stderr]     |                 ^^^^^^^^^^^^ help: replace it with: `lines`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/vars/resolve.rs:49:13
[INFO] [stderr]    |
[INFO] [stderr] 49 |             name: name,
[INFO] [stderr]    |             ^^^^^^^^^^ help: replace it with: `name`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/model.rs:116:13
[INFO] [stderr]     |
[INFO] [stderr] 116 |             command: command,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^ help: replace it with: `command`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/model.rs:117:13
[INFO] [stderr]     |
[INFO] [stderr] 117 |             line: line,
[INFO] [stderr]     |             ^^^^^^^^^^ help: replace it with: `line`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/parse.rs:36:9
[INFO] [stderr]    |
[INFO] [stderr] 36 |         directives: directives,
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `directives`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/parse.rs:141:19
[INFO] [stderr]     |
[INFO] [stderr] 141 |     TextPattern { components: components }
[INFO] [stderr]     |                   ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `components`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/run/test_evaluator.rs:33:25
[INFO] [stderr]    |
[INFO] [stderr] 33 |         TestEvaluator { invocation: invocation }
[INFO] [stderr]    |                         ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `invocation`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/run/test_evaluator.rs:205:17
[INFO] [stderr]     |
[INFO] [stderr] 205 |         Lines { lines: lines, current: 0 }
[INFO] [stderr]     |                 ^^^^^^^^^^^^ help: replace it with: `lines`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/vars/resolve.rs:49:13
[INFO] [stderr]    |
[INFO] [stderr] 49 |             name: name,
[INFO] [stderr]    |             ^^^^^^^^^^ help: replace it with: `name`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]   --> src/run/test_evaluator.rs:11:15
[INFO] [stderr]    |
[INFO] [stderr] 11 | const SHELL: &'static str = "bash";
[INFO] [stderr]    |              -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::const_static_lifetime)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]   --> src/run/test_evaluator.rs:11:15
[INFO] [stderr]    |
[INFO] [stderr] 11 | const SHELL: &'static str = "bash";
[INFO] [stderr]    |              -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::const_static_lifetime)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]  --> src/lit_unit_tests.rs:3:20
[INFO] [stderr]   |
[INFO] [stderr] 3 | const CRATE_PATH: &'static str = env!("CARGO_MANIFEST_DIR");
[INFO] [stderr]   |                   -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stderr]   |
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: called `is_some()` after searching an `Iterator` with find. This is more succinctly expressed by calling `any()`.
[INFO] [stderr]   --> src/config.rs:71:9
[INFO] [stderr]    |
[INFO] [stderr] 71 | /         self.supported_file_extensions.iter().
[INFO] [stderr] 72 | |             find(|ext| &ext[..] == extension).is_some()
[INFO] [stderr]    | |_______________________________________________________^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::search_is_some)] on by default
[INFO] [stderr]    = note: replace `find(|ext| &ext[..] == extension).is_some()` with `any(|ext| &ext[..] == extension)`
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#search_is_some
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]   --> src/config.rs:81:13
[INFO] [stderr]    |
[INFO] [stderr] 81 | /             match self.variable_lookup.0(name) {
[INFO] [stderr] 82 | |                 Some(initial_value) => {
[INFO] [stderr] 83 | |                     variables.insert(name.to_owned(), initial_value.clone());
[INFO] [stderr] 84 | |                 },
[INFO] [stderr] 85 | |                 None => (),
[INFO] [stderr] 86 | |             }
[INFO] [stderr]    | |_____________^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::single_match)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 81 |             if let Some(initial_value) = self.variable_lookup.0(name) {
[INFO] [stderr] 82 |     variables.insert(name.to_owned(), initial_value.clone());
[INFO] [stderr] 83 | }
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: use of `write!(stdout(), ...).unwrap()`. Consider using `print!` instead
[INFO] [stderr]    --> src/run/print.rs:118:17
[INFO] [stderr]     |
[INFO] [stderr] 118 |                 write!(io::stdout(), "{}", msg.into()).unwrap();
[INFO] [stderr]     |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::explicit_write)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_write
[INFO] [stderr] 
[INFO] [stderr] warning: use of `write!(stderr(), ...).unwrap()`. Consider using `eprint!` instead
[INFO] [stderr]    --> src/run/print.rs:126:17
[INFO] [stderr]     |
[INFO] [stderr] 126 |                 write!(io::stderr(), "{}", msg.into()).unwrap();
[INFO] [stderr]     |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_write
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a call to `new`
[INFO] [stderr]   --> src/run/test_evaluator.rs:82:36
[INFO] [stderr]    |
[INFO] [stderr] 82 |                 let current_path = env::var("PATH").unwrap_or(String::new());
[INFO] [stderr]    |                                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `env::var("PATH").unwrap_or_default()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::or_fun_call)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: useless use of `format!`
[INFO] [stderr]    --> src/run/test_evaluator.rs:159:38
[INFO] [stderr]     |
[INFO] [stderr] 159 |                             message: format!("check-next reached the end of file"),
[INFO] [stderr]     |                                      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"check-next reached the end of file".to_string()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::useless_format)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]    --> src/run/test_evaluator.rs:238:28
[INFO] [stderr]     |
[INFO] [stderr] 238 |         Lines::new(s.split("\n").map(ToOwned::to_owned).collect())
[INFO] [stderr]     |                            ^^^^ help: try using a char instead: `'\n'`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::single_char_pattern)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: called `is_some()` after searching an `Iterator` with find. This is more succinctly expressed by calling `any()`.
[INFO] [stderr]   --> src/config.rs:71:9
[INFO] [stderr]    |
[INFO] [stderr] 71 | /         self.supported_file_extensions.iter().
[INFO] [stderr] 72 | |             find(|ext| &ext[..] == extension).is_some()
[INFO] [stderr]    | |_______________________________________________________^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::search_is_some)] on by default
[INFO] [stderr]    = note: replace `find(|ext| &ext[..] == extension).is_some()` with `any(|ext| &ext[..] == extension)`
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#search_is_some
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]   --> src/config.rs:81:13
[INFO] [stderr]    |
[INFO] [stderr] 81 | /             match self.variable_lookup.0(name) {
[INFO] [stderr] 82 | |                 Some(initial_value) => {
[INFO] [stderr] 83 | |                     variables.insert(name.to_owned(), initial_value.clone());
[INFO] [stderr] 84 | |                 },
[INFO] [stderr] 85 | |                 None => (),
[INFO] [stderr] 86 | |             }
[INFO] [stderr]    | |_____________^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::single_match)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 81 |             if let Some(initial_value) = self.variable_lookup.0(name) {
[INFO] [stderr] 82 |     variables.insert(name.to_owned(), initial_value.clone());
[INFO] [stderr] 83 | }
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: use of `write!(stdout(), ...).unwrap()`. Consider using `print!` instead
[INFO] [stderr]    --> src/run/print.rs:118:17
[INFO] [stderr]     |
[INFO] [stderr] 118 |                 write!(io::stdout(), "{}", msg.into()).unwrap();
[INFO] [stderr]     |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::explicit_write)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_write
[INFO] [stderr] 
[INFO] [stderr] warning: use of `write!(stderr(), ...).unwrap()`. Consider using `eprint!` instead
[INFO] [stderr]    --> src/run/print.rs:126:17
[INFO] [stderr]     |
[INFO] [stderr] 126 |                 write!(io::stderr(), "{}", msg.into()).unwrap();
[INFO] [stderr]     |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_write
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a call to `new`
[INFO] [stderr]   --> src/run/test_evaluator.rs:82:36
[INFO] [stderr]    |
[INFO] [stderr] 82 |                 let current_path = env::var("PATH").unwrap_or(String::new());
[INFO] [stderr]    |                                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `env::var("PATH").unwrap_or_default()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::or_fun_call)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: useless use of `format!`
[INFO] [stderr]    --> src/run/test_evaluator.rs:159:38
[INFO] [stderr]     |
[INFO] [stderr] 159 |                             message: format!("check-next reached the end of file"),
[INFO] [stderr]     |                                      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"check-next reached the end of file".to_string()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::useless_format)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]    --> src/run/test_evaluator.rs:238:28
[INFO] [stderr]     |
[INFO] [stderr] 238 |         Lines::new(s.split("\n").map(ToOwned::to_owned).collect())
[INFO] [stderr]     |                            ^^^^ help: try using a char instead: `'\n'`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::single_char_pattern)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 5.29s
[INFO] running `"docker" "inspect" "2ff4b98e7ae05bbc4cf55cd55dcd850cf5fd6562b71fdb03d19c064ff8b3f9c7"`
[INFO] running `"docker" "rm" "-f" "2ff4b98e7ae05bbc4cf55cd55dcd850cf5fd6562b71fdb03d19c064ff8b3f9c7"`
[INFO] [stdout] 2ff4b98e7ae05bbc4cf55cd55dcd850cf5fd6562b71fdb03d19c064ff8b3f9c7