[INFO] crate liquid 0.17.1 is already in cache [INFO] extracting crate liquid 0.17.1 into work/ex/clippy-test-run/sources/stable/reg/liquid/0.17.1 [INFO] extracting crate liquid 0.17.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/liquid/0.17.1 [INFO] validating manifest of liquid-0.17.1 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of liquid-0.17.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing liquid-0.17.1 [INFO] finished frobbing liquid-0.17.1 [INFO] frobbed toml for liquid-0.17.1 written to work/ex/clippy-test-run/sources/stable/reg/liquid/0.17.1/Cargo.toml [INFO] started frobbing liquid-0.17.1 [INFO] finished frobbing liquid-0.17.1 [INFO] frobbed toml for liquid-0.17.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/liquid/0.17.1/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting liquid-0.17.1 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/liquid/0.17.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] c75ae35ae07f8d3cc8f22900903346b8059add78e485b2dc29075be6e243bb80 [INFO] running `"docker" "start" "-a" "c75ae35ae07f8d3cc8f22900903346b8059add78e485b2dc29075be6e243bb80"` [INFO] [stderr] Checking liquid-error v0.16.1 [INFO] [stderr] Checking serde_yaml v0.8.8 [INFO] [stderr] Checking docmatic v0.1.2 [INFO] [stderr] Checking liquid-value v0.17.1 [INFO] [stderr] Checking liquid-interpreter v0.17.1 [INFO] [stderr] Checking liquid-compiler v0.17.1 [INFO] [stderr] Checking liquid v0.17.1 (/opt/crater/workdir) [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/filters/math.rs:340:27 [INFO] [stderr] | [INFO] [stderr] 340 | Value::scalar(3.3569999999999993) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `3.356_999_999_999_999_3` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/filters/mod.rs:1382:36 [INFO] [stderr] | [INFO] [stderr] 1382 | let input = &Value::scalar(10000000f64); [INFO] [stderr] | ^^^^^^^^^^^ help: consider: `10_000_000f64` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] error: zero-width space detected [INFO] [stderr] --> src/filters/mod.rs:741:5 [INFO] [stderr] | [INFO] [stderr] 741 | / fn unit_capitalize() { [INFO] [stderr] 742 | | assert_eq!(unit!(capitalize, tos!("abc")), tos!("Abc")); [INFO] [stderr] 743 | | assert_eq!( [INFO] [stderr] 744 | | unit!(capitalize, tos!("hello world 21")), [INFO] [stderr] ... | [INFO] [stderr] 761 | | assert_eq!(unit!(capitalize, tos!("ßß")), tos!("SSß")); [INFO] [stderr] 762 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::zero_width_space)] on by default [INFO] [stderr] = help: Consider replacing the string with: [INFO] [stderr] "fn unit_capitalize() { [INFO] [stderr] assert_eq!(unit!(capitalize, tos!("abc")), tos!("Abc")); [INFO] [stderr] assert_eq!( [INFO] [stderr] unit!(capitalize, tos!("hello world 21")), [INFO] [stderr] tos!("Hello world 21") [INFO] [stderr] ); [INFO] [stderr] [INFO] [stderr] // sure that Umlauts work [INFO] [stderr] assert_eq!( [INFO] [stderr] unit!(capitalize, tos!("über ètat, y̆es?")), [INFO] [stderr] tos!("Über ètat, y̆es?") [INFO] [stderr] ); [INFO] [stderr] [INFO] [stderr] // Weird UTF-8 White space is kept – this is a no-break whitespace! [INFO] [stderr] assert_eq!( [INFO] [stderr] unit!(capitalize, tos!("hello world\u{200B}")), [INFO] [stderr] tos!("Hello world\u{200B}") [INFO] [stderr] ); [INFO] [stderr] [INFO] [stderr] // The uppercase version of some character are more than one character long [INFO] [stderr] assert_eq!(unit!(capitalize, tos!("ßß")), tos!("SSß")); [INFO] [stderr] }" [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zero_width_space [INFO] [stderr] [INFO] [stderr] error: zero-width space detected [INFO] [stderr] --> src/filters/mod.rs:756:36 [INFO] [stderr] | [INFO] [stderr] 756 | unit!(capitalize, tos!("hello world​")), [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Consider replacing the string with: [INFO] [stderr] ""hello world\u{200B}"" [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zero_width_space [INFO] [stderr] [INFO] [stderr] error: zero-width space detected [INFO] [stderr] --> src/filters/mod.rs:757:18 [INFO] [stderr] | [INFO] [stderr] 757 | tos!("Hello world​") [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Consider replacing the string with: [INFO] [stderr] ""Hello world\u{200B}"" [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zero_width_space [INFO] [stderr] [INFO] [stderr] error: zero-width space detected [INFO] [stderr] --> src/filters/mod.rs:755:9 [INFO] [stderr] | [INFO] [stderr] 755 | / assert_eq!( [INFO] [stderr] 756 | | unit!(capitalize, tos!("hello world​")), [INFO] [stderr] 757 | | tos!("Hello world​") [INFO] [stderr] 758 | | ); [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = help: Consider replacing the string with: [INFO] [stderr] "assert_eq!( [INFO] [stderr] unit!(capitalize, tos!("hello world\u{200B}")), [INFO] [stderr] tos!("Hello world\u{200B}") [INFO] [stderr] );" [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zero_width_space [INFO] [stderr] [INFO] [stderr] error: approximate value of `f64::consts::PI` found. Consider using it directly [INFO] [stderr] --> src/filters/mod.rs:1205:40 [INFO] [stderr] | [INFO] [stderr] 1205 | unit!(round, Value::scalar(3.14159f64), &[Value::scalar(3i32)]), [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::approx_constant)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#approx_constant [INFO] [stderr] [INFO] [stderr] error: approximate value of `f64::consts::PI` found. Consider using it directly [INFO] [stderr] --> src/filters/mod.rs:1206:27 [INFO] [stderr] | [INFO] [stderr] 1206 | Value::scalar(3.142f64) [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#approx_constant [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> src/tags/comment_block.rs:48:13 [INFO] [stderr] | [INFO] [stderr] 48 | &vec![Element::Expression(vec![], "This is a test".to_string())], [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can use a slice directly: `&[Element::Expression(vec![], "This is a test".to_string())]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_vec)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> src/tags/raw_block.rs:58:13 [INFO] [stderr] | [INFO] [stderr] 58 | &vec![Element::Expression(vec![], "This is a test".to_owned())], [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can use a slice directly: `&[Element::Expression(vec![], "This is a test".to_owned())]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] error: aborting due to 6 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `liquid`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error[E0554]: #![feature] may not be used on the stable release channel [INFO] [stderr] --> benches/liquid.rs:1:1 [INFO] [stderr] | [INFO] [stderr] 1 | #![feature(test)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] For more information about this error, try `rustc --explain E0554`. [INFO] [stderr] error: Could not compile `liquid`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> tests/multithreading.rs:43:18 [INFO] [stderr] | [INFO] [stderr] 43 | .expect(&format!("Failed to read file: {}", output_file)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("Failed to read file: {}", output_file))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::expect_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> tests/multithreading.rs:39:18 [INFO] [stderr] | [INFO] [stderr] 39 | .expect(&format!( [INFO] [stderr] | __________________^ [INFO] [stderr] 40 | | "Expected output file does not exist: {}", [INFO] [stderr] 41 | | output_file [INFO] [stderr] 42 | | )).read_to_string(&mut comp) [INFO] [stderr] | |__________________^ help: try this: `unwrap_or_else(|_| panic!("Expected output file does not exist: {}", output_file))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] error: build failed [INFO] running `"docker" "inspect" "c75ae35ae07f8d3cc8f22900903346b8059add78e485b2dc29075be6e243bb80"` [INFO] running `"docker" "rm" "-f" "c75ae35ae07f8d3cc8f22900903346b8059add78e485b2dc29075be6e243bb80"` [INFO] [stdout] c75ae35ae07f8d3cc8f22900903346b8059add78e485b2dc29075be6e243bb80