[INFO] crate linux_proc 0.1.0 is already in cache [INFO] extracting crate linux_proc 0.1.0 into work/ex/clippy-test-run/sources/stable/reg/linux_proc/0.1.0 [INFO] extracting crate linux_proc 0.1.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/linux_proc/0.1.0 [INFO] validating manifest of linux_proc-0.1.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of linux_proc-0.1.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing linux_proc-0.1.0 [INFO] finished frobbing linux_proc-0.1.0 [INFO] frobbed toml for linux_proc-0.1.0 written to work/ex/clippy-test-run/sources/stable/reg/linux_proc/0.1.0/Cargo.toml [INFO] started frobbing linux_proc-0.1.0 [INFO] finished frobbing linux_proc-0.1.0 [INFO] frobbed toml for linux_proc-0.1.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/linux_proc/0.1.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting linux_proc-0.1.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/linux_proc/0.1.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 37e4078697d7d47d878330b0d07e08a41ad56f6b47a3f4c805186624992eda2f [INFO] running `"docker" "start" "-a" "37e4078697d7d47d878330b0d07e08a41ad56f6b47a3f4c805186624992eda2f"` [INFO] [stderr] Checking linux_proc v0.1.0 (/opt/crater/workdir) [INFO] [stderr] Checking clap-verbosity-flag v0.1.0 [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/util.rs:79:5 [INFO] [stderr] | [INFO] [stderr] 79 | return &input[input.len()..]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `&input[input.len()..]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/util.rs:45:42 [INFO] [stderr] | [INFO] [stderr] 45 | Some(val) => (ch.len_utf8(), val as u64), [INFO] [stderr] | ^^^^^^^^^^ help: try: `u64::from(val)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/util.rs:53:34 [INFO] [stderr] | [INFO] [stderr] 53 | acc = acc * 10 + val as u64; [INFO] [stderr] | ^^^^^^^^^^ help: try: `u64::from(val)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this loop could be written as a `while let` loop [INFO] [stderr] --> src/stat.rs:60:9 [INFO] [stderr] | [INFO] [stderr] 60 | / loop { [INFO] [stderr] 61 | | if let Ok(cpu_info) = reader.parse_line(StatCpu::from_str) { [INFO] [stderr] 62 | | cpus.push(cpu_info); [INFO] [stderr] 63 | | } else { [INFO] [stderr] 64 | | break; [INFO] [stderr] 65 | | } [INFO] [stderr] 66 | | } [INFO] [stderr] | |_________^ help: try: `while let Ok(cpu_info) = reader.parse_line(StatCpu::from_str) { .. }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::while_let_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop [INFO] [stderr] [INFO] [stderr] Checking quicli v0.3.1 [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/util.rs:79:5 [INFO] [stderr] | [INFO] [stderr] 79 | return &input[input.len()..]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `&input[input.len()..]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/util.rs:45:42 [INFO] [stderr] | [INFO] [stderr] 45 | Some(val) => (ch.len_utf8(), val as u64), [INFO] [stderr] | ^^^^^^^^^^ help: try: `u64::from(val)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/util.rs:53:34 [INFO] [stderr] | [INFO] [stderr] 53 | acc = acc * 10 + val as u64; [INFO] [stderr] | ^^^^^^^^^^ help: try: `u64::from(val)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this loop could be written as a `while let` loop [INFO] [stderr] --> src/stat.rs:60:9 [INFO] [stderr] | [INFO] [stderr] 60 | / loop { [INFO] [stderr] 61 | | if let Ok(cpu_info) = reader.parse_line(StatCpu::from_str) { [INFO] [stderr] 62 | | cpus.push(cpu_info); [INFO] [stderr] 63 | | } else { [INFO] [stderr] 64 | | break; [INFO] [stderr] 65 | | } [INFO] [stderr] 66 | | } [INFO] [stderr] | |_________^ help: try: `while let Ok(cpu_info) = reader.parse_line(StatCpu::from_str) { .. }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::while_let_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 7.55s [INFO] running `"docker" "inspect" "37e4078697d7d47d878330b0d07e08a41ad56f6b47a3f4c805186624992eda2f"` [INFO] running `"docker" "rm" "-f" "37e4078697d7d47d878330b0d07e08a41ad56f6b47a3f4c805186624992eda2f"` [INFO] [stdout] 37e4078697d7d47d878330b0d07e08a41ad56f6b47a3f4c805186624992eda2f