[INFO] crate linux-stats 0.2.0 is already in cache [INFO] extracting crate linux-stats 0.2.0 into work/ex/clippy-test-run/sources/stable/reg/linux-stats/0.2.0 [INFO] extracting crate linux-stats 0.2.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/linux-stats/0.2.0 [INFO] validating manifest of linux-stats-0.2.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of linux-stats-0.2.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing linux-stats-0.2.0 [INFO] finished frobbing linux-stats-0.2.0 [INFO] frobbed toml for linux-stats-0.2.0 written to work/ex/clippy-test-run/sources/stable/reg/linux-stats/0.2.0/Cargo.toml [INFO] started frobbing linux-stats-0.2.0 [INFO] finished frobbing linux-stats-0.2.0 [INFO] frobbed toml for linux-stats-0.2.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/linux-stats/0.2.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting linux-stats-0.2.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/linux-stats/0.2.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 811a8117537a9b4c0b4f49696f255d7dc5ce468ae0dc3a8ce9b89928a16da2c2 [INFO] running `"docker" "start" "-a" "811a8117537a9b4c0b4f49696f255d7dc5ce468ae0dc3a8ce9b89928a16da2c2"` [INFO] [stderr] Checking linux-stats v0.2.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:524:9 [INFO] [stderr] | [INFO] [stderr] 524 | sl: sl, [INFO] [stderr] | ^^^^^^ help: replace it with: `sl` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:536:9 [INFO] [stderr] | [INFO] [stderr] 536 | uid: uid, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `uid` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:537:9 [INFO] [stderr] | [INFO] [stderr] 537 | inode: inode [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `inode` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:524:9 [INFO] [stderr] | [INFO] [stderr] 524 | sl: sl, [INFO] [stderr] | ^^^^^^ help: replace it with: `sl` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:536:9 [INFO] [stderr] | [INFO] [stderr] 536 | uid: uid, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `uid` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:537:9 [INFO] [stderr] | [INFO] [stderr] 537 | inode: inode [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `inode` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:213:5 [INFO] [stderr] | [INFO] [stderr] 213 | return Ok(stat); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(stat)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:495:5 [INFO] [stderr] | [INFO] [stderr] 495 | return buf; [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `buf` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:502:5 [INFO] [stderr] | [INFO] [stderr] 502 | return chunks.next().unwrap().parse::().unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `chunks.next().unwrap().parse::().unwrap()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:213:5 [INFO] [stderr] | [INFO] [stderr] 213 | return Ok(stat); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(stat)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:495:5 [INFO] [stderr] | [INFO] [stderr] 495 | return buf; [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `buf` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:502:5 [INFO] [stderr] | [INFO] [stderr] 502 | return chunks.next().unwrap().parse::().unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `chunks.next().unwrap().parse::().unwrap()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:632:28 [INFO] [stderr] | [INFO] [stderr] 632 | assert_eq!(sock.inode, 2796814); [INFO] [stderr] | ^^^^^^^ help: consider: `2_796_814` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: the variable `line_num` is used as a loop counter. Consider using `for (line_num, item) in lines.enumerate()` or similar iterators [INFO] [stderr] --> src/lib.rs:157:21 [INFO] [stderr] | [INFO] [stderr] 157 | for ref line in lines { [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::explicit_counter_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/lib.rs:157:9 [INFO] [stderr] | [INFO] [stderr] 157 | for ref line in lines { [INFO] [stderr] | ^^^^^^^^ ----- help: try: `let line = &lines;` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 47 [INFO] [stderr] --> src/lib.rs:216:1 [INFO] [stderr] | [INFO] [stderr] 216 | / pub fn meminfo() -> io::Result { [INFO] [stderr] 217 | | let content = read_file("/proc/meminfo"); [INFO] [stderr] 218 | | [INFO] [stderr] 219 | | if content.is_err() { [INFO] [stderr] ... | [INFO] [stderr] 456 | | Ok(meminfo) [INFO] [stderr] 457 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/lib.rs:273:9 [INFO] [stderr] | [INFO] [stderr] 273 | for ref line in lines { [INFO] [stderr] | ^^^^^^^^ ----- help: try: `let line = &lines;` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: this loop could be written as a `for` loop [INFO] [stderr] --> src/lib.rs:491:29 [INFO] [stderr] | [INFO] [stderr] 491 | while let Some(chunk) = chunks.next() { [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `for chunk in chunks { .. }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::while_let_on_iterator)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_on_iterator [INFO] [stderr] [INFO] [stderr] warning: the variable `line_num` is used as a loop counter. Consider using `for (line_num, item) in lines.enumerate()` or similar iterators [INFO] [stderr] --> src/lib.rs:157:21 [INFO] [stderr] | [INFO] [stderr] 157 | for ref line in lines { [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::explicit_counter_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/lib.rs:157:9 [INFO] [stderr] | [INFO] [stderr] 157 | for ref line in lines { [INFO] [stderr] | ^^^^^^^^ ----- help: try: `let line = &lines;` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 47 [INFO] [stderr] --> src/lib.rs:216:1 [INFO] [stderr] | [INFO] [stderr] 216 | / pub fn meminfo() -> io::Result { [INFO] [stderr] 217 | | let content = read_file("/proc/meminfo"); [INFO] [stderr] 218 | | [INFO] [stderr] 219 | | if content.is_err() { [INFO] [stderr] ... | [INFO] [stderr] 456 | | Ok(meminfo) [INFO] [stderr] 457 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/lib.rs:273:9 [INFO] [stderr] | [INFO] [stderr] 273 | for ref line in lines { [INFO] [stderr] | ^^^^^^^^ ----- help: try: `let line = &lines;` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: this loop could be written as a `for` loop [INFO] [stderr] --> src/lib.rs:491:29 [INFO] [stderr] | [INFO] [stderr] 491 | while let Some(chunk) = chunks.next() { [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `for chunk in chunks { .. }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::while_let_on_iterator)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_on_iterator [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 2.31s [INFO] running `"docker" "inspect" "811a8117537a9b4c0b4f49696f255d7dc5ce468ae0dc3a8ce9b89928a16da2c2"` [INFO] running `"docker" "rm" "-f" "811a8117537a9b4c0b4f49696f255d7dc5ce468ae0dc3a8ce9b89928a16da2c2"` [INFO] [stdout] 811a8117537a9b4c0b4f49696f255d7dc5ce468ae0dc3a8ce9b89928a16da2c2