[INFO] crate linux-perf-file-reader 0.1.0 is already in cache [INFO] extracting crate linux-perf-file-reader 0.1.0 into work/ex/clippy-test-run/sources/stable/reg/linux-perf-file-reader/0.1.0 [INFO] extracting crate linux-perf-file-reader 0.1.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/linux-perf-file-reader/0.1.0 [INFO] validating manifest of linux-perf-file-reader-0.1.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of linux-perf-file-reader-0.1.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing linux-perf-file-reader-0.1.0 [INFO] finished frobbing linux-perf-file-reader-0.1.0 [INFO] frobbed toml for linux-perf-file-reader-0.1.0 written to work/ex/clippy-test-run/sources/stable/reg/linux-perf-file-reader/0.1.0/Cargo.toml [INFO] started frobbing linux-perf-file-reader-0.1.0 [INFO] finished frobbing linux-perf-file-reader-0.1.0 [INFO] frobbed toml for linux-perf-file-reader-0.1.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/linux-perf-file-reader/0.1.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting linux-perf-file-reader-0.1.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/linux-perf-file-reader/0.1.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 5a2488e73644e5b093d95911ae34a79805e69923be888397b2b82f004ff9b7e7 [INFO] running `"docker" "start" "-a" "5a2488e73644e5b093d95911ae34a79805e69923be888397b2b82f004ff9b7e7"` [INFO] [stderr] Checking linux-perf-file-reader v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:429:19 [INFO] [stderr] | [INFO] [stderr] 429 | Ok(SampleId { pid: pid, tid: tid, time:time, id: id, stream_id: stream_id, cpu: cpu, res: res, identifier: identifier}) [INFO] [stderr] | ^^^^^^^^ help: replace it with: `pid` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:429:29 [INFO] [stderr] | [INFO] [stderr] 429 | Ok(SampleId { pid: pid, tid: tid, time:time, id: id, stream_id: stream_id, cpu: cpu, res: res, identifier: identifier}) [INFO] [stderr] | ^^^^^^^^ help: replace it with: `tid` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:429:39 [INFO] [stderr] | [INFO] [stderr] 429 | Ok(SampleId { pid: pid, tid: tid, time:time, id: id, stream_id: stream_id, cpu: cpu, res: res, identifier: identifier}) [INFO] [stderr] | ^^^^^^^^^ help: replace it with: `time` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:429:50 [INFO] [stderr] | [INFO] [stderr] 429 | Ok(SampleId { pid: pid, tid: tid, time:time, id: id, stream_id: stream_id, cpu: cpu, res: res, identifier: identifier}) [INFO] [stderr] | ^^^^^^ help: replace it with: `id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:429:58 [INFO] [stderr] | [INFO] [stderr] 429 | Ok(SampleId { pid: pid, tid: tid, time:time, id: id, stream_id: stream_id, cpu: cpu, res: res, identifier: identifier}) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `stream_id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:429:80 [INFO] [stderr] | [INFO] [stderr] 429 | Ok(SampleId { pid: pid, tid: tid, time:time, id: id, stream_id: stream_id, cpu: cpu, res: res, identifier: identifier}) [INFO] [stderr] | ^^^^^^^^ help: replace it with: `cpu` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:429:90 [INFO] [stderr] | [INFO] [stderr] 429 | Ok(SampleId { pid: pid, tid: tid, time:time, id: id, stream_id: stream_id, cpu: cpu, res: res, identifier: identifier}) [INFO] [stderr] | ^^^^^^^^ help: replace it with: `res` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:429:100 [INFO] [stderr] | [INFO] [stderr] 429 | Ok(SampleId { pid: pid, tid: tid, time:time, id: id, stream_id: stream_id, cpu: cpu, res: res, identifier: identifier}) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `identifier` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:445:24 [INFO] [stderr] | [INFO] [stderr] 445 | Ok(Event::Sample { identifier: identifier, ip: ip, pid: pid, tid: tid, time:time, addr: addr, id: id, stream_id: stream_id, cpu: cpu, res: res, period: period, call_chain: vec![]}) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `identifier` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:445:48 [INFO] [stderr] | [INFO] [stderr] 445 | Ok(Event::Sample { identifier: identifier, ip: ip, pid: pid, tid: tid, time:time, addr: addr, id: id, stream_id: stream_id, cpu: cpu, res: res, period: period, call_chain: vec![]}) [INFO] [stderr] | ^^^^^^ help: replace it with: `ip` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:445:56 [INFO] [stderr] | [INFO] [stderr] 445 | Ok(Event::Sample { identifier: identifier, ip: ip, pid: pid, tid: tid, time:time, addr: addr, id: id, stream_id: stream_id, cpu: cpu, res: res, period: period, call_chain: vec![]}) [INFO] [stderr] | ^^^^^^^^ help: replace it with: `pid` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:445:66 [INFO] [stderr] | [INFO] [stderr] 445 | Ok(Event::Sample { identifier: identifier, ip: ip, pid: pid, tid: tid, time:time, addr: addr, id: id, stream_id: stream_id, cpu: cpu, res: res, period: period, call_chain: vec![]}) [INFO] [stderr] | ^^^^^^^^ help: replace it with: `tid` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:445:77 [INFO] [stderr] | [INFO] [stderr] 445 | Ok(Event::Sample { identifier: identifier, ip: ip, pid: pid, tid: tid, time:time, addr: addr, id: id, stream_id: stream_id, cpu: cpu, res: res, period: period, call_chain: vec![]}) [INFO] [stderr] | ^^^^^^^^^ help: replace it with: `time` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:445:88 [INFO] [stderr] | [INFO] [stderr] 445 | Ok(Event::Sample { identifier: identifier, ip: ip, pid: pid, tid: tid, time:time, addr: addr, id: id, stream_id: stream_id, cpu: cpu, res: res, period: period, call_chain: vec![]}) [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `addr` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:445:100 [INFO] [stderr] | [INFO] [stderr] 445 | Ok(Event::Sample { identifier: identifier, ip: ip, pid: pid, tid: tid, time:time, addr: addr, id: id, stream_id: stream_id, cpu: cpu, res: res, period: period, call_chain: vec![]}) [INFO] [stderr] | ^^^^^^ help: replace it with: `id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:445:108 [INFO] [stderr] | [INFO] [stderr] 445 | Ok(Event::Sample { identifier: identifier, ip: ip, pid: pid, tid: tid, time:time, addr: addr, id: id, stream_id: stream_id, cpu: cpu, res: res, period: period, call_chain: vec![]}) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `stream_id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:445:130 [INFO] [stderr] | [INFO] [stderr] 445 | Ok(Event::Sample { identifier: identifier, ip: ip, pid: pid, tid: tid, time:time, addr: addr, id: id, stream_id: stream_id, cpu: cpu, res: res, period: period, call_chain: vec![]}) [INFO] [stderr] | ^^^^^^^^ help: replace it with: `cpu` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:445:140 [INFO] [stderr] | [INFO] [stderr] 445 | Ok(Event::Sample { identifier: identifier, ip: ip, pid: pid, tid: tid, time:time, addr: addr, id: id, stream_id: stream_id, cpu: cpu, res: res, period: period, call_chain: vec![]}) [INFO] [stderr] | ^^^^^^^^ help: replace it with: `res` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:445:150 [INFO] [stderr] | [INFO] [stderr] 445 | Ok(Event::Sample { identifier: identifier, ip: ip, pid: pid, tid: tid, time:time, addr: addr, id: id, stream_id: stream_id, cpu: cpu, res: res, period: period, call_chain: vec![]}) [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `period` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:467:30 [INFO] [stderr] | [INFO] [stderr] 467 | Ok(HeaderInfoReader{ file: file, sections: sections, current: 0, flags: header.flags }) [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `file` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:467:42 [INFO] [stderr] | [INFO] [stderr] 467 | Ok(HeaderInfoReader{ file: file, sections: sections, current: 0, flags: header.flags }) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `sections` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:547:21 [INFO] [stderr] | [INFO] [stderr] 547 | return Ok((Info{hostname: hostname, os_release: os_release, tools_version: tools_version, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `hostname` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:547:41 [INFO] [stderr] | [INFO] [stderr] 547 | return Ok((Info{hostname: hostname, os_release: os_release, tools_version: tools_version, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `os_release` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:547:65 [INFO] [stderr] | [INFO] [stderr] 547 | return Ok((Info{hostname: hostname, os_release: os_release, tools_version: tools_version, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `tools_version` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:548:9 [INFO] [stderr] | [INFO] [stderr] 548 | arch: arch, cpu_id: cpu_id, cpu_description: cpu_description, total_memory: total_memory, command_line: command_line, cpu_topology: cpu_topology})); [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `arch` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:548:21 [INFO] [stderr] | [INFO] [stderr] 548 | arch: arch, cpu_id: cpu_id, cpu_description: cpu_description, total_memory: total_memory, command_line: command_line, cpu_topology: cpu_topology})); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `cpu_id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:548:37 [INFO] [stderr] | [INFO] [stderr] 548 | arch: arch, cpu_id: cpu_id, cpu_description: cpu_description, total_memory: total_memory, command_line: command_line, cpu_topology: cpu_topology})); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `cpu_description` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:548:71 [INFO] [stderr] | [INFO] [stderr] 548 | arch: arch, cpu_id: cpu_id, cpu_description: cpu_description, total_memory: total_memory, command_line: command_line, cpu_topology: cpu_topology})); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `total_memory` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:548:99 [INFO] [stderr] | [INFO] [stderr] 548 | arch: arch, cpu_id: cpu_id, cpu_description: cpu_description, total_memory: total_memory, command_line: command_line, cpu_topology: cpu_topology})); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `command_line` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:548:127 [INFO] [stderr] | [INFO] [stderr] 548 | arch: arch, cpu_id: cpu_id, cpu_description: cpu_description, total_memory: total_memory, command_line: command_line, cpu_topology: cpu_topology})); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `cpu_topology` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:579:121 [INFO] [stderr] | [INFO] [stderr] 579 | events.push(Event::MMap{pid: part.pid, tid: part.tid, addr:part.addr, pgoff: part.pgoff, len: part.len, filename: filename, sample_id: s}); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `filename` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:592:139 [INFO] [stderr] | [INFO] [stderr] 592 | maj: part.maj, min: part.min, ino: part.ino, ino_generation: part.ino_generation, prot: part.prot, flags: part.flags, filename: filename, sample_id: s}); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `filename` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:606:71 [INFO] [stderr] | [INFO] [stderr] 606 | events.push(Event::Comm{pid: part.pid, tid: part.tid, comm: comm, sample_id: s}); [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `comm` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:614:13 [INFO] [stderr] | [INFO] [stderr] 614 | Ok(Perf{info: info, event_attributes: attrs, events: events}) [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `info` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:614:50 [INFO] [stderr] | [INFO] [stderr] 614 | Ok(Perf{info: info, event_attributes: attrs, events: events}) [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `events` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:429:19 [INFO] [stderr] | [INFO] [stderr] 429 | Ok(SampleId { pid: pid, tid: tid, time:time, id: id, stream_id: stream_id, cpu: cpu, res: res, identifier: identifier}) [INFO] [stderr] | ^^^^^^^^ help: replace it with: `pid` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:429:29 [INFO] [stderr] | [INFO] [stderr] 429 | Ok(SampleId { pid: pid, tid: tid, time:time, id: id, stream_id: stream_id, cpu: cpu, res: res, identifier: identifier}) [INFO] [stderr] | ^^^^^^^^ help: replace it with: `tid` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:429:39 [INFO] [stderr] | [INFO] [stderr] 429 | Ok(SampleId { pid: pid, tid: tid, time:time, id: id, stream_id: stream_id, cpu: cpu, res: res, identifier: identifier}) [INFO] [stderr] | ^^^^^^^^^ help: replace it with: `time` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:429:50 [INFO] [stderr] | [INFO] [stderr] 429 | Ok(SampleId { pid: pid, tid: tid, time:time, id: id, stream_id: stream_id, cpu: cpu, res: res, identifier: identifier}) [INFO] [stderr] | ^^^^^^ help: replace it with: `id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:429:58 [INFO] [stderr] | [INFO] [stderr] 429 | Ok(SampleId { pid: pid, tid: tid, time:time, id: id, stream_id: stream_id, cpu: cpu, res: res, identifier: identifier}) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `stream_id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:429:80 [INFO] [stderr] | [INFO] [stderr] 429 | Ok(SampleId { pid: pid, tid: tid, time:time, id: id, stream_id: stream_id, cpu: cpu, res: res, identifier: identifier}) [INFO] [stderr] | ^^^^^^^^ help: replace it with: `cpu` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:429:90 [INFO] [stderr] | [INFO] [stderr] 429 | Ok(SampleId { pid: pid, tid: tid, time:time, id: id, stream_id: stream_id, cpu: cpu, res: res, identifier: identifier}) [INFO] [stderr] | ^^^^^^^^ help: replace it with: `res` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:429:100 [INFO] [stderr] | [INFO] [stderr] 429 | Ok(SampleId { pid: pid, tid: tid, time:time, id: id, stream_id: stream_id, cpu: cpu, res: res, identifier: identifier}) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `identifier` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:445:24 [INFO] [stderr] | [INFO] [stderr] 445 | Ok(Event::Sample { identifier: identifier, ip: ip, pid: pid, tid: tid, time:time, addr: addr, id: id, stream_id: stream_id, cpu: cpu, res: res, period: period, call_chain: vec![]}) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `identifier` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:445:48 [INFO] [stderr] | [INFO] [stderr] 445 | Ok(Event::Sample { identifier: identifier, ip: ip, pid: pid, tid: tid, time:time, addr: addr, id: id, stream_id: stream_id, cpu: cpu, res: res, period: period, call_chain: vec![]}) [INFO] [stderr] | ^^^^^^ help: replace it with: `ip` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:445:56 [INFO] [stderr] | [INFO] [stderr] 445 | Ok(Event::Sample { identifier: identifier, ip: ip, pid: pid, tid: tid, time:time, addr: addr, id: id, stream_id: stream_id, cpu: cpu, res: res, period: period, call_chain: vec![]}) [INFO] [stderr] | ^^^^^^^^ help: replace it with: `pid` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:445:66 [INFO] [stderr] | [INFO] [stderr] 445 | Ok(Event::Sample { identifier: identifier, ip: ip, pid: pid, tid: tid, time:time, addr: addr, id: id, stream_id: stream_id, cpu: cpu, res: res, period: period, call_chain: vec![]}) [INFO] [stderr] | ^^^^^^^^ help: replace it with: `tid` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:445:77 [INFO] [stderr] | [INFO] [stderr] 445 | Ok(Event::Sample { identifier: identifier, ip: ip, pid: pid, tid: tid, time:time, addr: addr, id: id, stream_id: stream_id, cpu: cpu, res: res, period: period, call_chain: vec![]}) [INFO] [stderr] | ^^^^^^^^^ help: replace it with: `time` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:445:88 [INFO] [stderr] | [INFO] [stderr] 445 | Ok(Event::Sample { identifier: identifier, ip: ip, pid: pid, tid: tid, time:time, addr: addr, id: id, stream_id: stream_id, cpu: cpu, res: res, period: period, call_chain: vec![]}) [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `addr` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:445:100 [INFO] [stderr] | [INFO] [stderr] 445 | Ok(Event::Sample { identifier: identifier, ip: ip, pid: pid, tid: tid, time:time, addr: addr, id: id, stream_id: stream_id, cpu: cpu, res: res, period: period, call_chain: vec![]}) [INFO] [stderr] | ^^^^^^ help: replace it with: `id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:445:108 [INFO] [stderr] | [INFO] [stderr] 445 | Ok(Event::Sample { identifier: identifier, ip: ip, pid: pid, tid: tid, time:time, addr: addr, id: id, stream_id: stream_id, cpu: cpu, res: res, period: period, call_chain: vec![]}) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `stream_id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:445:130 [INFO] [stderr] | [INFO] [stderr] 445 | Ok(Event::Sample { identifier: identifier, ip: ip, pid: pid, tid: tid, time:time, addr: addr, id: id, stream_id: stream_id, cpu: cpu, res: res, period: period, call_chain: vec![]}) [INFO] [stderr] | ^^^^^^^^ help: replace it with: `cpu` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:445:140 [INFO] [stderr] | [INFO] [stderr] 445 | Ok(Event::Sample { identifier: identifier, ip: ip, pid: pid, tid: tid, time:time, addr: addr, id: id, stream_id: stream_id, cpu: cpu, res: res, period: period, call_chain: vec![]}) [INFO] [stderr] | ^^^^^^^^ help: replace it with: `res` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:445:150 [INFO] [stderr] | [INFO] [stderr] 445 | Ok(Event::Sample { identifier: identifier, ip: ip, pid: pid, tid: tid, time:time, addr: addr, id: id, stream_id: stream_id, cpu: cpu, res: res, period: period, call_chain: vec![]}) [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `period` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:467:30 [INFO] [stderr] | [INFO] [stderr] 467 | Ok(HeaderInfoReader{ file: file, sections: sections, current: 0, flags: header.flags }) [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `file` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:467:42 [INFO] [stderr] | [INFO] [stderr] 467 | Ok(HeaderInfoReader{ file: file, sections: sections, current: 0, flags: header.flags }) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `sections` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:547:21 [INFO] [stderr] | [INFO] [stderr] 547 | return Ok((Info{hostname: hostname, os_release: os_release, tools_version: tools_version, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `hostname` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:547:41 [INFO] [stderr] | [INFO] [stderr] 547 | return Ok((Info{hostname: hostname, os_release: os_release, tools_version: tools_version, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `os_release` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:547:65 [INFO] [stderr] | [INFO] [stderr] 547 | return Ok((Info{hostname: hostname, os_release: os_release, tools_version: tools_version, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `tools_version` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:548:9 [INFO] [stderr] | [INFO] [stderr] 548 | arch: arch, cpu_id: cpu_id, cpu_description: cpu_description, total_memory: total_memory, command_line: command_line, cpu_topology: cpu_topology})); [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `arch` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:548:21 [INFO] [stderr] | [INFO] [stderr] 548 | arch: arch, cpu_id: cpu_id, cpu_description: cpu_description, total_memory: total_memory, command_line: command_line, cpu_topology: cpu_topology})); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `cpu_id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:548:37 [INFO] [stderr] | [INFO] [stderr] 548 | arch: arch, cpu_id: cpu_id, cpu_description: cpu_description, total_memory: total_memory, command_line: command_line, cpu_topology: cpu_topology})); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `cpu_description` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:548:71 [INFO] [stderr] | [INFO] [stderr] 548 | arch: arch, cpu_id: cpu_id, cpu_description: cpu_description, total_memory: total_memory, command_line: command_line, cpu_topology: cpu_topology})); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `total_memory` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:548:99 [INFO] [stderr] | [INFO] [stderr] 548 | arch: arch, cpu_id: cpu_id, cpu_description: cpu_description, total_memory: total_memory, command_line: command_line, cpu_topology: cpu_topology})); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `command_line` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:548:127 [INFO] [stderr] | [INFO] [stderr] 548 | arch: arch, cpu_id: cpu_id, cpu_description: cpu_description, total_memory: total_memory, command_line: command_line, cpu_topology: cpu_topology})); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `cpu_topology` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:579:121 [INFO] [stderr] | [INFO] [stderr] 579 | events.push(Event::MMap{pid: part.pid, tid: part.tid, addr:part.addr, pgoff: part.pgoff, len: part.len, filename: filename, sample_id: s}); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `filename` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:592:139 [INFO] [stderr] | [INFO] [stderr] 592 | maj: part.maj, min: part.min, ino: part.ino, ino_generation: part.ino_generation, prot: part.prot, flags: part.flags, filename: filename, sample_id: s}); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `filename` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:606:71 [INFO] [stderr] | [INFO] [stderr] 606 | events.push(Event::Comm{pid: part.pid, tid: part.tid, comm: comm, sample_id: s}); [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `comm` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:614:13 [INFO] [stderr] | [INFO] [stderr] 614 | Ok(Perf{info: info, event_attributes: attrs, events: events}) [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `info` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:614:50 [INFO] [stderr] | [INFO] [stderr] 614 | Ok(Perf{info: info, event_attributes: attrs, events: events}) [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `events` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:547:5 [INFO] [stderr] | [INFO] [stderr] 547 | / return Ok((Info{hostname: hostname, os_release: os_release, tools_version: tools_version, [INFO] [stderr] 548 | | arch: arch, cpu_id: cpu_id, cpu_description: cpu_description, total_memory: total_memory, command_line: command_line, cpu_topology: cpu_topology})); [INFO] [stderr] | |____________________________________________________________________________________________________________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 547 | Ok((Info{hostname: hostname, os_release: os_release, tools_version: tools_version, [INFO] [stderr] 548 | arch: arch, cpu_id: cpu_id, cpu_description: cpu_description, total_memory: total_memory, command_line: command_line, cpu_topology: cpu_topology})) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around function argument [INFO] [stderr] --> src/lib.rs:547:15 [INFO] [stderr] | [INFO] [stderr] 547 | return Ok((Info{hostname: hostname, os_release: os_release, tools_version: tools_version, [INFO] [stderr] | _______________^ [INFO] [stderr] 548 | | arch: arch, cpu_id: cpu_id, cpu_description: cpu_description, total_memory: total_memory, command_line: command_line, cpu_topology: cpu_topology})); [INFO] [stderr] | |__________________________________________________________________________________________________________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_parens)] on by default [INFO] [stderr] help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] 547 | return Ok(Info{hostname: hostname, os_release: os_release, tools_version: tools_version, [INFO] [stderr] 548 | arch: arch, cpu_id: cpu_id, cpu_description: cpu_description, total_memory: total_memory, command_line: command_line, cpu_topology: cpu_topology}); [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> src/lib.rs:547:15 [INFO] [stderr] | [INFO] [stderr] 547 | return Ok((Info{hostname: hostname, os_release: os_release, tools_version: tools_version, [INFO] [stderr] | _______________^ [INFO] [stderr] 548 | | arch: arch, cpu_id: cpu_id, cpu_description: cpu_description, total_memory: total_memory, command_line: command_line, cpu_topology: cpu_topology})); [INFO] [stderr] | |__________________________________________________________________________________________________________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::double_parens)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:547:5 [INFO] [stderr] | [INFO] [stderr] 547 | / return Ok((Info{hostname: hostname, os_release: os_release, tools_version: tools_version, [INFO] [stderr] 548 | | arch: arch, cpu_id: cpu_id, cpu_description: cpu_description, total_memory: total_memory, command_line: command_line, cpu_topology: cpu_topology})); [INFO] [stderr] | |____________________________________________________________________________________________________________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 547 | Ok((Info{hostname: hostname, os_release: os_release, tools_version: tools_version, [INFO] [stderr] 548 | arch: arch, cpu_id: cpu_id, cpu_description: cpu_description, total_memory: total_memory, command_line: command_line, cpu_topology: cpu_topology})) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around function argument [INFO] [stderr] --> src/lib.rs:547:15 [INFO] [stderr] | [INFO] [stderr] 547 | return Ok((Info{hostname: hostname, os_release: os_release, tools_version: tools_version, [INFO] [stderr] | _______________^ [INFO] [stderr] 548 | | arch: arch, cpu_id: cpu_id, cpu_description: cpu_description, total_memory: total_memory, command_line: command_line, cpu_topology: cpu_topology})); [INFO] [stderr] | |__________________________________________________________________________________________________________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_parens)] on by default [INFO] [stderr] help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] 547 | return Ok(Info{hostname: hostname, os_release: os_release, tools_version: tools_version, [INFO] [stderr] 548 | arch: arch, cpu_id: cpu_id, cpu_description: cpu_description, total_memory: total_memory, command_line: command_line, cpu_topology: cpu_topology}); [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> src/lib.rs:547:15 [INFO] [stderr] | [INFO] [stderr] 547 | return Ok((Info{hostname: hostname, os_release: os_release, tools_version: tools_version, [INFO] [stderr] | _______________^ [INFO] [stderr] 548 | | arch: arch, cpu_id: cpu_id, cpu_description: cpu_description, total_memory: total_memory, command_line: command_line, cpu_topology: cpu_topology})); [INFO] [stderr] | |__________________________________________________________________________________________________________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::double_parens)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/lib.rs:386:13 [INFO] [stderr] | [INFO] [stderr] 386 | let mut slice = slice::from_raw_parts_mut(mem::transmute(&mut t), size); [INFO] [stderr] | ----^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/lib.rs:386:13 [INFO] [stderr] | [INFO] [stderr] 386 | let mut slice = slice::from_raw_parts_mut(mem::transmute(&mut t), size); [INFO] [stderr] | ----^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `1` [INFO] [stderr] --> src/lib.rs:145:29 [INFO] [stderr] | [INFO] [stderr] 145 | const IP = 1 << 0, [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_op)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `1` [INFO] [stderr] --> src/lib.rs:145:29 [INFO] [stderr] | [INFO] [stderr] 145 | const IP = 1 << 0, [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_op)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `1` [INFO] [stderr] --> src/lib.rs:171:43 [INFO] [stderr] | [INFO] [stderr] 171 | const TOTAL_TIME_ENABLED = 1 << 0, [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `1` [INFO] [stderr] --> src/lib.rs:171:43 [INFO] [stderr] | [INFO] [stderr] 171 | const TOTAL_TIME_ENABLED = 1 << 0, [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: transmute from a reference to a pointer [INFO] [stderr] --> src/lib.rs:386:51 [INFO] [stderr] | [INFO] [stderr] 386 | let mut slice = slice::from_raw_parts_mut(mem::transmute(&mut t), size); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `&mut t as *mut T as *mut u8` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_transmute)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/lib.rs:395:49 [INFO] [stderr] | [INFO] [stderr] 395 | let end = buff.iter().position(|x| *x == 0).unwrap_or(buff.len()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| buff.len())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: transmute from a reference to a pointer [INFO] [stderr] --> src/lib.rs:386:51 [INFO] [stderr] | [INFO] [stderr] 386 | let mut slice = slice::from_raw_parts_mut(mem::transmute(&mut t), size); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `&mut t as *mut T as *mut u8` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_transmute)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_transmute [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/lib.rs:409:22 [INFO] [stderr] | [INFO] [stderr] 409 | fn sample_id_size(s: &sample_format::SampleFormat) -> usize { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider passing by value instead: `sample_format::SampleFormat` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/lib.rs:395:49 [INFO] [stderr] | [INFO] [stderr] 395 | let end = buff.iter().position(|x| *x == 0).unwrap_or(buff.len()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| buff.len())` [INFO] [stderr] | [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/lib.rs:420:39 [INFO] [stderr] | [INFO] [stderr] 420 | fn read_sample_id(file: &mut Read, s: &sample_format::SampleFormat) -> io::Result { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider passing by value instead: `sample_format::SampleFormat` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/lib.rs:409:22 [INFO] [stderr] | [INFO] [stderr] 409 | fn sample_id_size(s: &sample_format::SampleFormat) -> usize { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider passing by value instead: `sample_format::SampleFormat` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/lib.rs:420:39 [INFO] [stderr] | [INFO] [stderr] 420 | fn read_sample_id(file: &mut Read, s: &sample_format::SampleFormat) -> io::Result { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider passing by value instead: `sample_format::SampleFormat` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/lib.rs:432:36 [INFO] [stderr] | [INFO] [stderr] 432 | fn read_sample(file: &mut Read, s: &sample_format::SampleFormat) -> io::Result { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider passing by value instead: `sample_format::SampleFormat` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/lib.rs:432:36 [INFO] [stderr] | [INFO] [stderr] 432 | fn read_sample(file: &mut Read, s: &sample_format::SampleFormat) -> io::Result { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider passing by value instead: `sample_format::SampleFormat` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u64 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:611:17 [INFO] [stderr] | [INFO] [stderr] 611 | size += event_header.size as u64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(event_header.size)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u64 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:611:17 [INFO] [stderr] | [INFO] [stderr] 611 | size += event_header.size as u64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(event_header.size)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> examples/dump.rs:68:25 [INFO] [stderr] | [INFO] [stderr] 68 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::println_empty_string)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> examples/dump.rs:84:5 [INFO] [stderr] | [INFO] [stderr] 84 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 29 [INFO] [stderr] --> examples/dump.rs:23:1 [INFO] [stderr] | [INFO] [stderr] 23 | / fn main() { [INFO] [stderr] 24 | | env_logger::init().unwrap(); [INFO] [stderr] 25 | | use linux_perf_file_reader::Event; [INFO] [stderr] 26 | | let args: Vec = std::env::args().collect(); [INFO] [stderr] ... | [INFO] [stderr] 78 | | } [INFO] [stderr] 79 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> examples/dump.rs:46:17 [INFO] [stderr] | [INFO] [stderr] 46 | / match event { [INFO] [stderr] 47 | | &Event::MMap{pid, tid, addr, len, pgoff, ref filename, ref sample_id} => { [INFO] [stderr] 48 | | println!(" Mmap: pid: {}, tid: {}, addr: {:x}, len: {}, pgoff: {:x} - {}", pid, tid, addr, len, pgoff, filename); [INFO] [stderr] 49 | | print_sample_id(sample_id); [INFO] [stderr] ... | [INFO] [stderr] 74 | | &Event::Unsupported => {} [INFO] [stderr] 75 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 46 | match *event { [INFO] [stderr] 47 | Event::MMap{pid, tid, addr, len, pgoff, ref filename, ref sample_id} => { [INFO] [stderr] 48 | println!(" Mmap: pid: {}, tid: {}, addr: {:x}, len: {}, pgoff: {:x} - {}", pid, tid, addr, len, pgoff, filename); [INFO] [stderr] 49 | print_sample_id(sample_id); [INFO] [stderr] 50 | }, [INFO] [stderr] 51 | Event::MMap2{pid, tid, addr, len, pgoff, maj, min, ino, ino_generation, prot, flags, ref filename, ref sample_id} => { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 3.49s [INFO] running `"docker" "inspect" "5a2488e73644e5b093d95911ae34a79805e69923be888397b2b82f004ff9b7e7"` [INFO] running `"docker" "rm" "-f" "5a2488e73644e5b093d95911ae34a79805e69923be888397b2b82f004ff9b7e7"` [INFO] [stdout] 5a2488e73644e5b093d95911ae34a79805e69923be888397b2b82f004ff9b7e7