[INFO] crate linkify 0.3.1 is already in cache [INFO] extracting crate linkify 0.3.1 into work/ex/clippy-test-run/sources/stable/reg/linkify/0.3.1 [INFO] extracting crate linkify 0.3.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/linkify/0.3.1 [INFO] validating manifest of linkify-0.3.1 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of linkify-0.3.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing linkify-0.3.1 [INFO] finished frobbing linkify-0.3.1 [INFO] frobbed toml for linkify-0.3.1 written to work/ex/clippy-test-run/sources/stable/reg/linkify/0.3.1/Cargo.toml [INFO] started frobbing linkify-0.3.1 [INFO] finished frobbing linkify-0.3.1 [INFO] frobbed toml for linkify-0.3.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/linkify/0.3.1/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting linkify-0.3.1 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/linkify/0.3.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 8b5ac3ff19f145b5b476827a86b0b03e22a85f868b53068aa7bfbc94f4003dc0 [INFO] running `"docker" "start" "-a" "8b5ac3ff19f145b5b476827a86b0b03e22a85f868b53068aa7bfbc94f4003dc0"` [INFO] [stderr] Checking linkify v0.3.1 (/opt/crater/workdir) [INFO] [stderr] error: redundant field names in struct initialization [INFO] [stderr] --> src/email.rs:19:21 [INFO] [stderr] | [INFO] [stderr] 19 | start: start, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `start` [INFO] [stderr] | [INFO] [stderr] note: lint level defined here [INFO] [stderr] --> src/lib.rs:104:9 [INFO] [stderr] | [INFO] [stderr] 104| #![deny(warnings)] [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] = note: #[deny(clippy::redundant_field_names)] implied by #[deny(warnings)] [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] error: redundant field names in struct initialization [INFO] [stderr] --> src/finder.rs:176:13 [INFO] [stderr] | [INFO] [stderr] 176 | text: text, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `text` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] error: redundant field names in struct initialization [INFO] [stderr] --> src/finder.rs:194:13 [INFO] [stderr] | [INFO] [stderr] 194 | text: text, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `text` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] error: redundant field names in struct initialization [INFO] [stderr] --> src/finder.rs:196:13 [INFO] [stderr] | [INFO] [stderr] 196 | trigger_finder: trigger_finder, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `trigger_finder` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] error: redundant field names in struct initialization [INFO] [stderr] --> src/finder.rs:197:13 [INFO] [stderr] | [INFO] [stderr] 197 | email_scanner: email_scanner, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `email_scanner` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] error: redundant field names in struct initialization [INFO] [stderr] --> src/finder.rs:198:13 [INFO] [stderr] | [INFO] [stderr] 198 | url_scanner: url_scanner, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `url_scanner` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] error: redundant field names in struct initialization [INFO] [stderr] --> src/finder.rs:223:21 [INFO] [stderr] | [INFO] [stderr] 223 | start: start, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `start` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] error: redundant field names in struct initialization [INFO] [stderr] --> src/finder.rs:224:21 [INFO] [stderr] | [INFO] [stderr] 224 | end: end, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `end` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] error: redundant field names in struct initialization [INFO] [stderr] --> src/finder.rs:225:21 [INFO] [stderr] | [INFO] [stderr] 225 | kind: kind, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `kind` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] error: redundant field names in struct initialization [INFO] [stderr] --> src/url.rs:19:29 [INFO] [stderr] | [INFO] [stderr] 19 | start: start, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `start` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] error: redundant field names in struct initialization [INFO] [stderr] --> src/email.rs:19:21 [INFO] [stderr] | [INFO] [stderr] 19 | start: start, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `start` [INFO] [stderr] | [INFO] [stderr] note: lint level defined here [INFO] [stderr] --> src/lib.rs:104:9 [INFO] [stderr] | [INFO] [stderr] 104| #![deny(warnings)] [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] = note: #[deny(clippy::redundant_field_names)] implied by #[deny(warnings)] [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] error: redundant field names in struct initialization [INFO] [stderr] --> src/finder.rs:176:13 [INFO] [stderr] | [INFO] [stderr] 176 | text: text, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `text` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] error: redundant field names in struct initialization [INFO] [stderr] --> src/finder.rs:194:13 [INFO] [stderr] | [INFO] [stderr] 194 | text: text, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `text` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] error: redundant field names in struct initialization [INFO] [stderr] --> src/finder.rs:196:13 [INFO] [stderr] | [INFO] [stderr] 196 | trigger_finder: trigger_finder, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `trigger_finder` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] error: redundant field names in struct initialization [INFO] [stderr] --> src/finder.rs:197:13 [INFO] [stderr] | [INFO] [stderr] 197 | email_scanner: email_scanner, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `email_scanner` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] error: redundant field names in struct initialization [INFO] [stderr] --> src/finder.rs:198:13 [INFO] [stderr] | [INFO] [stderr] 198 | url_scanner: url_scanner, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `url_scanner` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] error: redundant field names in struct initialization [INFO] [stderr] --> src/finder.rs:223:21 [INFO] [stderr] | [INFO] [stderr] 223 | start: start, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `start` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] error: redundant field names in struct initialization [INFO] [stderr] --> src/finder.rs:224:21 [INFO] [stderr] | [INFO] [stderr] 224 | end: end, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `end` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] error: redundant field names in struct initialization [INFO] [stderr] --> src/finder.rs:225:21 [INFO] [stderr] | [INFO] [stderr] 225 | kind: kind, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `kind` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] error: redundant field names in struct initialization [INFO] [stderr] --> src/url.rs:19:29 [INFO] [stderr] | [INFO] [stderr] 19 | start: start, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `start` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] error: unneeded return statement [INFO] [stderr] --> src/email.rs:25:9 [INFO] [stderr] | [INFO] [stderr] 25 | return None; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `None` [INFO] [stderr] | [INFO] [stderr] note: lint level defined here [INFO] [stderr] --> src/lib.rs:104:9 [INFO] [stderr] | [INFO] [stderr] 104| #![deny(warnings)] [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] = note: #[deny(clippy::needless_return)] implied by #[deny(warnings)] [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] error: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/email.rs:66:20 [INFO] [stderr] | [INFO] [stderr] 66 | } else { [INFO] [stderr] | ____________________^ [INFO] [stderr] 67 | | if c == '.' { [INFO] [stderr] 68 | | if !can_end_sub_domain { [INFO] [stderr] 69 | | break; [INFO] [stderr] ... | [INFO] [stderr] 82 | | } [INFO] [stderr] 83 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] note: lint level defined here [INFO] [stderr] --> src/lib.rs:104:9 [INFO] [stderr] | [INFO] [stderr] 104| #![deny(warnings)] [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] = note: #[deny(clippy::collapsible_if)] implied by #[deny(warnings)] [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 66 | } else if c == '.' { [INFO] [stderr] 67 | if !can_end_sub_domain { [INFO] [stderr] 68 | break; [INFO] [stderr] 69 | } [INFO] [stderr] 70 | first_in_sub_domain = true; [INFO] [stderr] 71 | if first_dot.is_none() { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] error: unneeded return statement [INFO] [stderr] --> src/finder.rs:235:9 [INFO] [stderr] | [INFO] [stderr] 235 | return None; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `None` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] error: unneeded return statement [INFO] [stderr] --> src/url.rs:27:9 [INFO] [stderr] | [INFO] [stderr] 27 | return None; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `None` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] error: this if statement can be collapsed [INFO] [stderr] --> src/url.rs:14:9 [INFO] [stderr] | [INFO] [stderr] 14 | / if colon > 0 && after_slash_slash < s.len() { [INFO] [stderr] 15 | | if s[colon..].starts_with("://") { [INFO] [stderr] 16 | | if let Some(start) = self.find_start(&s[0..colon]) { [INFO] [stderr] 17 | | if let Some(end) = self.find_end(&s[after_slash_slash..]) { [INFO] [stderr] ... | [INFO] [stderr] 25 | | } [INFO] [stderr] 26 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 14 | if colon > 0 && after_slash_slash < s.len() && s[colon..].starts_with("://") { [INFO] [stderr] 15 | if let Some(start) = self.find_start(&s[0..colon]) { [INFO] [stderr] 16 | if let Some(end) = self.find_end(&s[after_slash_slash..]) { [INFO] [stderr] 17 | let range = Range { [INFO] [stderr] 18 | start: start, [INFO] [stderr] 19 | end: after_slash_slash + end, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] error: unneeded return statement [INFO] [stderr] --> src/url.rs:58:9 [INFO] [stderr] | [INFO] [stderr] 58 | return first; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `first` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] error: unneeded return statement [INFO] [stderr] --> src/email.rs:25:9 [INFO] [stderr] | [INFO] [stderr] 25 | return None; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `None` [INFO] [stderr] | [INFO] [stderr] note: lint level defined here [INFO] [stderr] --> src/lib.rs:104:9 [INFO] [stderr] | [INFO] [stderr] 104| #![deny(warnings)] [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] = note: #[deny(clippy::needless_return)] implied by #[deny(warnings)] [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] error: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/email.rs:66:20 [INFO] [stderr] | [INFO] [stderr] 66 | } else { [INFO] [stderr] | ____________________^ [INFO] [stderr] 67 | | if c == '.' { [INFO] [stderr] 68 | | if !can_end_sub_domain { [INFO] [stderr] 69 | | break; [INFO] [stderr] ... | [INFO] [stderr] 82 | | } [INFO] [stderr] 83 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] note: lint level defined here [INFO] [stderr] --> src/lib.rs:104:9 [INFO] [stderr] | [INFO] [stderr] 104| #![deny(warnings)] [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] = note: #[deny(clippy::collapsible_if)] implied by #[deny(warnings)] [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 66 | } else if c == '.' { [INFO] [stderr] 67 | if !can_end_sub_domain { [INFO] [stderr] 68 | break; [INFO] [stderr] 69 | } [INFO] [stderr] 70 | first_in_sub_domain = true; [INFO] [stderr] 71 | if first_dot.is_none() { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] error: unneeded return statement [INFO] [stderr] --> src/finder.rs:235:9 [INFO] [stderr] | [INFO] [stderr] 235 | return None; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `None` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] error: unneeded return statement [INFO] [stderr] --> src/url.rs:27:9 [INFO] [stderr] | [INFO] [stderr] 27 | return None; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `None` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] error: this if statement can be collapsed [INFO] [stderr] --> src/url.rs:14:9 [INFO] [stderr] | [INFO] [stderr] 14 | / if colon > 0 && after_slash_slash < s.len() { [INFO] [stderr] 15 | | if s[colon..].starts_with("://") { [INFO] [stderr] 16 | | if let Some(start) = self.find_start(&s[0..colon]) { [INFO] [stderr] 17 | | if let Some(end) = self.find_end(&s[after_slash_slash..]) { [INFO] [stderr] ... | [INFO] [stderr] 25 | | } [INFO] [stderr] 26 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 14 | if colon > 0 && after_slash_slash < s.len() && s[colon..].starts_with("://") { [INFO] [stderr] 15 | if let Some(start) = self.find_start(&s[0..colon]) { [INFO] [stderr] 16 | if let Some(end) = self.find_end(&s[after_slash_slash..]) { [INFO] [stderr] 17 | let range = Range { [INFO] [stderr] 18 | start: start, [INFO] [stderr] 19 | end: after_slash_slash + end, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] error: unneeded return statement [INFO] [stderr] --> src/url.rs:58:9 [INFO] [stderr] | [INFO] [stderr] 58 | return first; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `first` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] error: aborting due to 16 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `linkify`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: aborting due to 16 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `linkify`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "8b5ac3ff19f145b5b476827a86b0b03e22a85f868b53068aa7bfbc94f4003dc0"` [INFO] running `"docker" "rm" "-f" "8b5ac3ff19f145b5b476827a86b0b03e22a85f868b53068aa7bfbc94f4003dc0"` [INFO] [stdout] 8b5ac3ff19f145b5b476827a86b0b03e22a85f868b53068aa7bfbc94f4003dc0