[INFO] crate linked-tail-list 0.0.1 is already in cache [INFO] extracting crate linked-tail-list 0.0.1 into work/ex/clippy-test-run/sources/stable/reg/linked-tail-list/0.0.1 [INFO] extracting crate linked-tail-list 0.0.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/linked-tail-list/0.0.1 [INFO] validating manifest of linked-tail-list-0.0.1 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of linked-tail-list-0.0.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing linked-tail-list-0.0.1 [INFO] finished frobbing linked-tail-list-0.0.1 [INFO] frobbed toml for linked-tail-list-0.0.1 written to work/ex/clippy-test-run/sources/stable/reg/linked-tail-list/0.0.1/Cargo.toml [INFO] started frobbing linked-tail-list-0.0.1 [INFO] finished frobbing linked-tail-list-0.0.1 [INFO] frobbed toml for linked-tail-list-0.0.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/linked-tail-list/0.0.1/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting linked-tail-list-0.0.1 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/linked-tail-list/0.0.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 542342297a629f97d07086b0d3307fa5a271c55355dbb7fabdbeef796a33a05a [INFO] running `"docker" "start" "-a" "542342297a629f97d07086b0d3307fa5a271c55355dbb7fabdbeef796a33a05a"` [INFO] [stderr] Checking linked-tail-list v0.0.1 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:124:13 [INFO] [stderr] | [INFO] [stderr] 124 | owning_link: owning_link, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `owning_link` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:125:13 [INFO] [stderr] | [INFO] [stderr] 125 | val: val, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `val` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:196:13 [INFO] [stderr] | [INFO] [stderr] 196 | node: node, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `node` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:124:13 [INFO] [stderr] | [INFO] [stderr] 124 | owning_link: owning_link, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `owning_link` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:125:13 [INFO] [stderr] | [INFO] [stderr] 125 | val: val, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `val` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:196:13 [INFO] [stderr] | [INFO] [stderr] 196 | node: node, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `node` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unnecessary `unsafe` block [INFO] [stderr] --> src/lib.rs:358:5 [INFO] [stderr] | [INFO] [stderr] 358 | unsafe { [INFO] [stderr] | ^^^^^^ unnecessary `unsafe` block [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_unsafe)] on by default [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `TailList` [INFO] [stderr] --> src/lib.rs:132:5 [INFO] [stderr] | [INFO] [stderr] 132 | / pub fn new() -> TailList { [INFO] [stderr] 133 | | TailList { [INFO] [stderr] 134 | | head: Own::new(Link::new()), [INFO] [stderr] 135 | | } [INFO] [stderr] 136 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 130 | impl Default for TailList { [INFO] [stderr] 131 | fn default() -> Self { [INFO] [stderr] 132 | Self::new() [INFO] [stderr] 133 | } [INFO] [stderr] 134 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/lib.rs:144:5 [INFO] [stderr] | [INFO] [stderr] 144 | / pub fn cursor<'node>(&'node mut self) -> Cursor<'node, T> { [INFO] [stderr] 145 | | Cursor::new(&self.head.new_ref()) [INFO] [stderr] 146 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: defining a method called `next` on this type; consider implementing the `std::iter::Iterator` trait or choosing a less ambiguous name [INFO] [stderr] --> src/lib.rs:162:5 [INFO] [stderr] | [INFO] [stderr] 162 | / pub fn next<'tail>(&'tail mut self) -> Option> { [INFO] [stderr] 163 | | // Get a reference to the next node, if there is any [INFO] [stderr] 164 | | let next_ref_opt: Option> = self.dummy.borrow_inner().next [INFO] [stderr] 165 | | .borrow_inner().opt_node_ref(); [INFO] [stderr] ... | [INFO] [stderr] 188 | | }) [INFO] [stderr] 189 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::should_implement_trait)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait [INFO] [stderr] [INFO] [stderr] error: mutable borrow from immutable input(s) [INFO] [stderr] --> src/lib.rs:400:35 [INFO] [stderr] | [INFO] [stderr] 400 | fn borrow_inner_mut(&self) -> &mut Self::Inner { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::mut_from_ref)] on by default [INFO] [stderr] note: immutable borrow here [INFO] [stderr] --> src/lib.rs:400:25 [INFO] [stderr] | [INFO] [stderr] 400 | fn borrow_inner_mut(&self) -> &mut Self::Inner { [INFO] [stderr] | ^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mut_from_ref [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `linked-tail-list`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: unnecessary `unsafe` block [INFO] [stderr] --> src/lib.rs:358:5 [INFO] [stderr] | [INFO] [stderr] 358 | unsafe { [INFO] [stderr] | ^^^^^^ unnecessary `unsafe` block [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_unsafe)] on by default [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `TailList` [INFO] [stderr] --> src/lib.rs:132:5 [INFO] [stderr] | [INFO] [stderr] 132 | / pub fn new() -> TailList { [INFO] [stderr] 133 | | TailList { [INFO] [stderr] 134 | | head: Own::new(Link::new()), [INFO] [stderr] 135 | | } [INFO] [stderr] 136 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 130 | impl Default for TailList { [INFO] [stderr] 131 | fn default() -> Self { [INFO] [stderr] 132 | Self::new() [INFO] [stderr] 133 | } [INFO] [stderr] 134 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/lib.rs:144:5 [INFO] [stderr] | [INFO] [stderr] 144 | / pub fn cursor<'node>(&'node mut self) -> Cursor<'node, T> { [INFO] [stderr] 145 | | Cursor::new(&self.head.new_ref()) [INFO] [stderr] 146 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: defining a method called `next` on this type; consider implementing the `std::iter::Iterator` trait or choosing a less ambiguous name [INFO] [stderr] --> src/lib.rs:162:5 [INFO] [stderr] | [INFO] [stderr] 162 | / pub fn next<'tail>(&'tail mut self) -> Option> { [INFO] [stderr] 163 | | // Get a reference to the next node, if there is any [INFO] [stderr] 164 | | let next_ref_opt: Option> = self.dummy.borrow_inner().next [INFO] [stderr] 165 | | .borrow_inner().opt_node_ref(); [INFO] [stderr] ... | [INFO] [stderr] 188 | | }) [INFO] [stderr] 189 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::should_implement_trait)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait [INFO] [stderr] [INFO] [stderr] error: mutable borrow from immutable input(s) [INFO] [stderr] --> src/lib.rs:400:35 [INFO] [stderr] | [INFO] [stderr] 400 | fn borrow_inner_mut(&self) -> &mut Self::Inner { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::mut_from_ref)] on by default [INFO] [stderr] note: immutable borrow here [INFO] [stderr] --> src/lib.rs:400:25 [INFO] [stderr] | [INFO] [stderr] 400 | fn borrow_inner_mut(&self) -> &mut Self::Inner { [INFO] [stderr] | ^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mut_from_ref [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/./lib_tests.rs:120:20 [INFO] [stderr] | [INFO] [stderr] 120 | assert_eq!(cursor.next().map(|i| *i), Some(i)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `cursor.next().cloned()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_clone)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/./lib_tests.rs:157:20 [INFO] [stderr] | [INFO] [stderr] 157 | assert_eq!(cursor.next().map(|i| *i), Some(i)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `cursor.next().cloned()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/./lib_tests.rs:158:20 [INFO] [stderr] | [INFO] [stderr] 158 | assert_eq!(cursor.next().map(|i| *i), Some(i)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `cursor.next().cloned()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/./lib_tests.rs:185:24 [INFO] [stderr] | [INFO] [stderr] 185 | assert_eq!(tail.next().map(|j| *j), Some(511 - j)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `tail.next().cloned()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/./lib_tests.rs:216:24 [INFO] [stderr] | [INFO] [stderr] 216 | assert_eq!(tail.next().map(|j| *j), Some(511 - j)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `tail.next().cloned()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `linked-tail-list`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "542342297a629f97d07086b0d3307fa5a271c55355dbb7fabdbeef796a33a05a"` [INFO] running `"docker" "rm" "-f" "542342297a629f97d07086b0d3307fa5a271c55355dbb7fabdbeef796a33a05a"` [INFO] [stdout] 542342297a629f97d07086b0d3307fa5a271c55355dbb7fabdbeef796a33a05a