[INFO] crate lines 0.0.6 is already in cache [INFO] extracting crate lines 0.0.6 into work/ex/clippy-test-run/sources/stable/reg/lines/0.0.6 [INFO] extracting crate lines 0.0.6 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/lines/0.0.6 [INFO] validating manifest of lines-0.0.6 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of lines-0.0.6 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing lines-0.0.6 [INFO] finished frobbing lines-0.0.6 [INFO] frobbed toml for lines-0.0.6 written to work/ex/clippy-test-run/sources/stable/reg/lines/0.0.6/Cargo.toml [INFO] started frobbing lines-0.0.6 [INFO] finished frobbing lines-0.0.6 [INFO] frobbed toml for lines-0.0.6 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/lines/0.0.6/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting lines-0.0.6 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/lines/0.0.6:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 78fa8ac7def3c9c2fb28365fa26cc8c606beefe61342a720ebb41e89f2e8ecae [INFO] running `"docker" "start" "-a" "78fa8ac7def3c9c2fb28365fa26cc8c606beefe61342a720ebb41e89f2e8ecae"` [INFO] [stderr] Checking lines v0.0.6 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/linereader.rs:79:13 [INFO] [stderr] | [INFO] [stderr] 79 | inner: inner, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `inner` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/linereader.rs:80:13 [INFO] [stderr] | [INFO] [stderr] 80 | buf: buf, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `buf` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/linereader.rs:79:13 [INFO] [stderr] | [INFO] [stderr] 79 | inner: inner, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `inner` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/linereader.rs:80:13 [INFO] [stderr] | [INFO] [stderr] 80 | buf: buf, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `buf` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around method argument [INFO] [stderr] --> src/linemapper.rs:57:54 [INFO] [stderr] | [INFO] [stderr] 57 | line_start.extend_from_slice((&b[..i+1])); [INFO] [stderr] | ^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_parens)] on by default [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> src/linemapper.rs:57:54 [INFO] [stderr] | [INFO] [stderr] 57 | line_start.extend_from_slice((&b[..i+1])); [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::double_parens)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/linemapper.rs:43:20 [INFO] [stderr] | [INFO] [stderr] 43 | if b.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `b.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/linemapper.rs:55:28 [INFO] [stderr] | [INFO] [stderr] 55 | &b[..i+1] [INFO] [stderr] | ^^^^^ help: use: `..=i` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/linemapper.rs:57:58 [INFO] [stderr] | [INFO] [stderr] 57 | line_start.extend_from_slice((&b[..i+1])); [INFO] [stderr] | ^^^^^ help: use: `..=i` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/linereader.rs:93:5 [INFO] [stderr] | [INFO] [stderr] 93 | / fn fill_buf<'a>(&'a mut self) -> Result { [INFO] [stderr] 94 | | if self.pos == self.cap { [INFO] [stderr] 95 | | self.cap = try!(self.inner.read(&mut self.buf[..])); [INFO] [stderr] 96 | | self.pos = 0; [INFO] [stderr] 97 | | } [INFO] [stderr] 98 | | Ok(self.cap-self.pos) [INFO] [stderr] 99 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/linereader.rs:177:15 [INFO] [stderr] | [INFO] [stderr] 177 | { let ref mut r = &mut $expr; [INFO] [stderr] | ----^^^^^^^^^-------------- help: try: `let r = &mut (&mut $expr);` [INFO] [stderr] ... [INFO] [stderr] 192 | / try_read_lines!(line in r, { [INFO] [stderr] 193 | | lines += 1; [INFO] [stderr] 194 | | }); [INFO] [stderr] | |_______- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around method argument [INFO] [stderr] --> src/linemapper.rs:57:54 [INFO] [stderr] | [INFO] [stderr] 57 | line_start.extend_from_slice((&b[..i+1])); [INFO] [stderr] | ^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_parens)] on by default [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> src/linemapper.rs:57:54 [INFO] [stderr] | [INFO] [stderr] 57 | line_start.extend_from_slice((&b[..i+1])); [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::double_parens)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/linemapper.rs:43:20 [INFO] [stderr] | [INFO] [stderr] 43 | if b.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `b.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/linemapper.rs:55:28 [INFO] [stderr] | [INFO] [stderr] 55 | &b[..i+1] [INFO] [stderr] | ^^^^^ help: use: `..=i` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> src/linemapper.rs:57:58 [INFO] [stderr] | [INFO] [stderr] 57 | line_start.extend_from_slice((&b[..i+1])); [INFO] [stderr] | ^^^^^ help: use: `..=i` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/linereader.rs:93:5 [INFO] [stderr] | [INFO] [stderr] 93 | / fn fill_buf<'a>(&'a mut self) -> Result { [INFO] [stderr] 94 | | if self.pos == self.cap { [INFO] [stderr] 95 | | self.cap = try!(self.inner.read(&mut self.buf[..])); [INFO] [stderr] 96 | | self.pos = 0; [INFO] [stderr] 97 | | } [INFO] [stderr] 98 | | Ok(self.cap-self.pos) [INFO] [stderr] 99 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/linereader.rs:177:15 [INFO] [stderr] | [INFO] [stderr] 177 | { let ref mut r = &mut $expr; [INFO] [stderr] | ----^^^^^^^^^-------------- help: try: `let r = &mut (&mut $expr);` [INFO] [stderr] ... [INFO] [stderr] 192 | / try_read_lines!(line in r, { [INFO] [stderr] 193 | | lines += 1; [INFO] [stderr] 194 | | }); [INFO] [stderr] | |_______- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] error[E0554]: #![feature] may not be used on the stable release channel [INFO] [stderr] --> benches/lib.rs:1:1 [INFO] [stderr] | [INFO] [stderr] 1 | #![feature(test)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] For more information about this error, try `rustc --explain E0554`. [INFO] [stderr] error: Could not compile `lines`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> tests/lib.rs:37:5 [INFO] [stderr] | [INFO] [stderr] 37 | / read_lines!(line in r, { [INFO] [stderr] 38 | | let line = line.unwrap(); [INFO] [stderr] 39 | | assert_eq!(expected[i], &String::from_utf8_lossy(line)[..]); [INFO] [stderr] 40 | | i += 1; [INFO] [stderr] 41 | | }); [INFO] [stderr] | |_______^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: build failed [INFO] running `"docker" "inspect" "78fa8ac7def3c9c2fb28365fa26cc8c606beefe61342a720ebb41e89f2e8ecae"` [INFO] running `"docker" "rm" "-f" "78fa8ac7def3c9c2fb28365fa26cc8c606beefe61342a720ebb41e89f2e8ecae"` [INFO] [stdout] 78fa8ac7def3c9c2fb28365fa26cc8c606beefe61342a720ebb41e89f2e8ecae