[INFO] crate linenoise-rust 0.2.1 is already in cache [INFO] extracting crate linenoise-rust 0.2.1 into work/ex/clippy-test-run/sources/stable/reg/linenoise-rust/0.2.1 [INFO] extracting crate linenoise-rust 0.2.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/linenoise-rust/0.2.1 [INFO] validating manifest of linenoise-rust-0.2.1 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of linenoise-rust-0.2.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing linenoise-rust-0.2.1 [INFO] finished frobbing linenoise-rust-0.2.1 [INFO] frobbed toml for linenoise-rust-0.2.1 written to work/ex/clippy-test-run/sources/stable/reg/linenoise-rust/0.2.1/Cargo.toml [INFO] started frobbing linenoise-rust-0.2.1 [INFO] finished frobbing linenoise-rust-0.2.1 [INFO] frobbed toml for linenoise-rust-0.2.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/linenoise-rust/0.2.1/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting linenoise-rust-0.2.1 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/linenoise-rust/0.2.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 154d1bc189a4b2fd6ef8b5cb53c4e673589ee2240c410849ce5459c1f6dd1691 [INFO] running `"docker" "start" "-a" "154d1bc189a4b2fd6ef8b5cb53c4e673589ee2240c410849ce5459c1f6dd1691"` [INFO] [stderr] warning: file found to be present in multiple build targets: /opt/crater/workdir/examples/linenoise_example.rs [INFO] [stderr] Compiling linenoise-rust v0.2.1 (/opt/crater/workdir) [INFO] [stderr] warning: use of deprecated item 'gcc::Build': crate has been renamed to `cc`, the `gcc` name is not maintained [INFO] [stderr] --> build.rs:4:3 [INFO] [stderr] | [INFO] [stderr] 4 | gcc::Build::new() [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'gcc::Build::new': crate has been renamed to `cc`, the `gcc` name is not maintained [INFO] [stderr] --> build.rs:4:3 [INFO] [stderr] | [INFO] [stderr] 4 | gcc::Build::new() [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:84:9 [INFO] [stderr] | [INFO] [stderr] 84 | return rval; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `rval` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:139:9 [INFO] [stderr] | [INFO] [stderr] 139 | return rval; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `rval` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: `0 as *mut _` detected. Consider using `ptr::null_mut()` [INFO] [stderr] --> src/lib.rs:76:31 [INFO] [stderr] | [INFO] [stderr] 76 | let rval = if rret != 0 as *mut i8 { [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::zero_ptr)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zero_ptr [INFO] [stderr] [INFO] [stderr] error: you are getting the inner pointer of a temporary `CString` [INFO] [stderr] --> src/lib.rs:90:14 [INFO] [stderr] | [INFO] [stderr] 90 | let cs = CString::new(line).unwrap().as_ptr(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::temporary_cstring_as_ptr)] on by default [INFO] [stderr] = note: that pointer will be invalid outside this expression [INFO] [stderr] help: assign the `CString` to a variable to extend its lifetime [INFO] [stderr] --> src/lib.rs:90:14 [INFO] [stderr] | [INFO] [stderr] 90 | let cs = CString::new(line).unwrap().as_ptr(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#temporary_cstring_as_ptr [INFO] [stderr] [INFO] [stderr] error: you are getting the inner pointer of a temporary `CString` [INFO] [stderr] --> src/lib.rs:109:17 [INFO] [stderr] | [INFO] [stderr] 109 | let fname = CString::new(file).unwrap().as_ptr(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: that pointer will be invalid outside this expression [INFO] [stderr] help: assign the `CString` to a variable to extend its lifetime [INFO] [stderr] --> src/lib.rs:109:17 [INFO] [stderr] | [INFO] [stderr] 109 | let fname = CString::new(file).unwrap().as_ptr(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#temporary_cstring_as_ptr [INFO] [stderr] [INFO] [stderr] error: you are getting the inner pointer of a temporary `CString` [INFO] [stderr] --> src/lib.rs:119:17 [INFO] [stderr] | [INFO] [stderr] 119 | let fname = CString::new(file).unwrap().as_ptr(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: that pointer will be invalid outside this expression [INFO] [stderr] help: assign the `CString` to a variable to extend its lifetime [INFO] [stderr] --> src/lib.rs:119:17 [INFO] [stderr] | [INFO] [stderr] 119 | let fname = CString::new(file).unwrap().as_ptr(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#temporary_cstring_as_ptr [INFO] [stderr] [INFO] [stderr] warning: `0 as *mut _` detected. Consider using `ptr::null_mut()` [INFO] [stderr] --> src/lib.rs:131:30 [INFO] [stderr] | [INFO] [stderr] 131 | let rval = if ret != 0 as *mut i8 { [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zero_ptr [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/lib.rs:166:37 [INFO] [stderr] | [INFO] [stderr] 166 | ffi::linenoiseAddCompletion(c, CString::new(s).unwrap().as_ptr()); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::not_unsafe_ptr_arg_deref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: you are getting the inner pointer of a temporary `CString` [INFO] [stderr] --> src/lib.rs:166:40 [INFO] [stderr] | [INFO] [stderr] 166 | ffi::linenoiseAddCompletion(c, CString::new(s).unwrap().as_ptr()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: that pointer will be invalid outside this expression [INFO] [stderr] help: assign the `CString` to a variable to extend its lifetime [INFO] [stderr] --> src/lib.rs:166:40 [INFO] [stderr] | [INFO] [stderr] 166 | ffi::linenoiseAddCompletion(c, CString::new(s).unwrap().as_ptr()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#temporary_cstring_as_ptr [INFO] [stderr] [INFO] [stderr] error: aborting due to 5 previous errors [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:84:9 [INFO] [stderr] | [INFO] [stderr] 84 | return rval; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `rval` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:139:9 [INFO] [stderr] | [INFO] [stderr] 139 | return rval; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `rval` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] error: Could not compile `linenoise-rust`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: `0 as *mut _` detected. Consider using `ptr::null_mut()` [INFO] [stderr] --> src/lib.rs:76:31 [INFO] [stderr] | [INFO] [stderr] 76 | let rval = if rret != 0 as *mut i8 { [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::zero_ptr)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zero_ptr [INFO] [stderr] [INFO] [stderr] error: you are getting the inner pointer of a temporary `CString` [INFO] [stderr] --> src/lib.rs:90:14 [INFO] [stderr] | [INFO] [stderr] 90 | let cs = CString::new(line).unwrap().as_ptr(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::temporary_cstring_as_ptr)] on by default [INFO] [stderr] = note: that pointer will be invalid outside this expression [INFO] [stderr] help: assign the `CString` to a variable to extend its lifetime [INFO] [stderr] --> src/lib.rs:90:14 [INFO] [stderr] | [INFO] [stderr] 90 | let cs = CString::new(line).unwrap().as_ptr(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#temporary_cstring_as_ptr [INFO] [stderr] [INFO] [stderr] error: you are getting the inner pointer of a temporary `CString` [INFO] [stderr] --> src/lib.rs:109:17 [INFO] [stderr] | [INFO] [stderr] 109 | let fname = CString::new(file).unwrap().as_ptr(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: that pointer will be invalid outside this expression [INFO] [stderr] help: assign the `CString` to a variable to extend its lifetime [INFO] [stderr] --> src/lib.rs:109:17 [INFO] [stderr] | [INFO] [stderr] 109 | let fname = CString::new(file).unwrap().as_ptr(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#temporary_cstring_as_ptr [INFO] [stderr] [INFO] [stderr] error: you are getting the inner pointer of a temporary `CString` [INFO] [stderr] --> src/lib.rs:119:17 [INFO] [stderr] | [INFO] [stderr] 119 | let fname = CString::new(file).unwrap().as_ptr(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: that pointer will be invalid outside this expression [INFO] [stderr] help: assign the `CString` to a variable to extend its lifetime [INFO] [stderr] --> src/lib.rs:119:17 [INFO] [stderr] | [INFO] [stderr] 119 | let fname = CString::new(file).unwrap().as_ptr(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#temporary_cstring_as_ptr [INFO] [stderr] [INFO] [stderr] warning: `0 as *mut _` detected. Consider using `ptr::null_mut()` [INFO] [stderr] --> src/lib.rs:131:30 [INFO] [stderr] | [INFO] [stderr] 131 | let rval = if ret != 0 as *mut i8 { [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zero_ptr [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/lib.rs:166:37 [INFO] [stderr] | [INFO] [stderr] 166 | ffi::linenoiseAddCompletion(c, CString::new(s).unwrap().as_ptr()); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::not_unsafe_ptr_arg_deref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: you are getting the inner pointer of a temporary `CString` [INFO] [stderr] --> src/lib.rs:166:40 [INFO] [stderr] | [INFO] [stderr] 166 | ffi::linenoiseAddCompletion(c, CString::new(s).unwrap().as_ptr()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: that pointer will be invalid outside this expression [INFO] [stderr] help: assign the `CString` to a variable to extend its lifetime [INFO] [stderr] --> src/lib.rs:166:40 [INFO] [stderr] | [INFO] [stderr] 166 | ffi::linenoiseAddCompletion(c, CString::new(s).unwrap().as_ptr()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#temporary_cstring_as_ptr [INFO] [stderr] [INFO] [stderr] error: aborting due to 5 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `linenoise-rust`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "154d1bc189a4b2fd6ef8b5cb53c4e673589ee2240c410849ce5459c1f6dd1691"` [INFO] running `"docker" "rm" "-f" "154d1bc189a4b2fd6ef8b5cb53c4e673589ee2240c410849ce5459c1f6dd1691"` [INFO] [stdout] 154d1bc189a4b2fd6ef8b5cb53c4e673589ee2240c410849ce5459c1f6dd1691