[INFO] crate linebreak-convert-writer 0.1.0 is already in cache [INFO] extracting crate linebreak-convert-writer 0.1.0 into work/ex/clippy-test-run/sources/stable/reg/linebreak-convert-writer/0.1.0 [INFO] extracting crate linebreak-convert-writer 0.1.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/linebreak-convert-writer/0.1.0 [INFO] validating manifest of linebreak-convert-writer-0.1.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of linebreak-convert-writer-0.1.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing linebreak-convert-writer-0.1.0 [INFO] finished frobbing linebreak-convert-writer-0.1.0 [INFO] frobbed toml for linebreak-convert-writer-0.1.0 written to work/ex/clippy-test-run/sources/stable/reg/linebreak-convert-writer/0.1.0/Cargo.toml [INFO] started frobbing linebreak-convert-writer-0.1.0 [INFO] finished frobbing linebreak-convert-writer-0.1.0 [INFO] frobbed toml for linebreak-convert-writer-0.1.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/linebreak-convert-writer/0.1.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting linebreak-convert-writer-0.1.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/linebreak-convert-writer/0.1.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 216884c9076acf212b8d5d20eb0a122fd56b98e377331777ca3a1199c16f2a94 [INFO] running `"docker" "start" "-a" "216884c9076acf212b8d5d20eb0a122fd56b98e377331777ca3a1199c16f2a94"` [INFO] [stderr] Checking memstream v0.0.1 [INFO] [stderr] Checking linebreak-convert-writer v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:31:13 [INFO] [stderr] | [INFO] [stderr] 31 | inner: inner, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `inner` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:31:13 [INFO] [stderr] | [INFO] [stderr] 31 | inner: inner, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `inner` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/lib.rs:44:9 [INFO] [stderr] | [INFO] [stderr] 44 | / fn remove_cr<'a>(buf: &'a [u8]) -> &'a [u8] { [INFO] [stderr] 45 | | if let Some((last, other)) = buf.split_last() { [INFO] [stderr] 46 | | // CR present, ignore it. [INFO] [stderr] 47 | | if *last == 0x0D { print!("{:?}",std::str::from_utf8(other).unwrap());other } else { buf } [INFO] [stderr] ... | [INFO] [stderr] 50 | | } [INFO] [stderr] 51 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/lib.rs:44:9 [INFO] [stderr] | [INFO] [stderr] 44 | / fn remove_cr<'a>(buf: &'a [u8]) -> &'a [u8] { [INFO] [stderr] 45 | | if let Some((last, other)) = buf.split_last() { [INFO] [stderr] 46 | | // CR present, ignore it. [INFO] [stderr] 47 | | if *last == 0x0D { print!("{:?}",std::str::from_utf8(other).unwrap());other } else { buf } [INFO] [stderr] ... | [INFO] [stderr] 50 | | } [INFO] [stderr] 51 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.24s [INFO] running `"docker" "inspect" "216884c9076acf212b8d5d20eb0a122fd56b98e377331777ca3a1199c16f2a94"` [INFO] running `"docker" "rm" "-f" "216884c9076acf212b8d5d20eb0a122fd56b98e377331777ca3a1199c16f2a94"` [INFO] [stdout] 216884c9076acf212b8d5d20eb0a122fd56b98e377331777ca3a1199c16f2a94