[INFO] crate linebased 0.3.1 is already in cache
[INFO] extracting crate linebased 0.3.1 into work/ex/clippy-test-run/sources/stable/reg/linebased/0.3.1
[INFO] extracting crate linebased 0.3.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/linebased/0.3.1
[INFO] validating manifest of linebased-0.3.1 on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of linebased-0.3.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing linebased-0.3.1
[INFO] finished frobbing linebased-0.3.1
[INFO] frobbed toml for linebased-0.3.1 written to work/ex/clippy-test-run/sources/stable/reg/linebased/0.3.1/Cargo.toml
[INFO] started frobbing linebased-0.3.1
[INFO] finished frobbing linebased-0.3.1
[INFO] frobbed toml for linebased-0.3.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/linebased/0.3.1/Cargo.toml
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting linebased-0.3.1 against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/linebased/0.3.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] dd4a703644a1e036ec48ec6bf19af41347cc2d0a52e61c6c73081b164fc2bbe4
[INFO] running `"docker" "start" "-a" "dd4a703644a1e036ec48ec6bf19af41347cc2d0a52e61c6c73081b164fc2bbe4"`
[INFO] [stderr]     Checking linebased v0.3.1 (/opt/crater/workdir)
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/lib.rs:109:13
[INFO] [stderr]     |
[INFO] [stderr] 109 |             token: token,
[INFO] [stderr]     |             ^^^^^^^^^^^^ help: replace it with: `token`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/lib.rs:385:13
[INFO] [stderr]     |
[INFO] [stderr] 385 |             inner: inner,
[INFO] [stderr]     |             ^^^^^^^^^^^^ help: replace it with: `inner`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/lib.rs:386:13
[INFO] [stderr]     |
[INFO] [stderr] 386 |             event_loop: event_loop
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `event_loop`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/lib.rs:437:13
[INFO] [stderr]     |
[INFO] [stderr] 437 |             server: server,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^ help: replace it with: `server`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/lib.rs:440:13
[INFO] [stderr]     |
[INFO] [stderr] 440 |             config: config,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^ help: replace it with: `config`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/lib.rs:575:17
[INFO] [stderr]     |
[INFO] [stderr] 575 |                 stream: stream,
[INFO] [stderr]     |                 ^^^^^^^^^^^^^^ help: replace it with: `stream`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/lib.rs:109:13
[INFO] [stderr]     |
[INFO] [stderr] 109 |             token: token,
[INFO] [stderr]     |             ^^^^^^^^^^^^ help: replace it with: `token`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/lib.rs:385:13
[INFO] [stderr]     |
[INFO] [stderr] 385 |             inner: inner,
[INFO] [stderr]     |             ^^^^^^^^^^^^ help: replace it with: `inner`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/lib.rs:386:13
[INFO] [stderr]     |
[INFO] [stderr] 386 |             event_loop: event_loop
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `event_loop`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/lib.rs:437:13
[INFO] [stderr]     |
[INFO] [stderr] 437 |             server: server,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^ help: replace it with: `server`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/lib.rs:440:13
[INFO] [stderr]     |
[INFO] [stderr] 440 |             config: config,
[INFO] [stderr]     |             ^^^^^^^^^^^^^^ help: replace it with: `config`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/lib.rs:575:17
[INFO] [stderr]     |
[INFO] [stderr] 575 |                 stream: stream,
[INFO] [stderr]     |                 ^^^^^^^^^^^^^^ help: replace it with: `stream`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/lib.rs:225:17
[INFO] [stderr]     |
[INFO] [stderr] 225 |                 return Status::Disconnected;
[INFO] [stderr]     |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Status::Disconnected`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/lib.rs:257:17
[INFO] [stderr]     |
[INFO] [stderr] 257 |                 return Status::Disconnected
[INFO] [stderr]     |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Status::Disconnected`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/lib.rs:225:17
[INFO] [stderr]     |
[INFO] [stderr] 225 |                 return Status::Disconnected;
[INFO] [stderr]     |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Status::Disconnected`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/lib.rs:257:17
[INFO] [stderr]     |
[INFO] [stderr] 257 |                 return Status::Disconnected
[INFO] [stderr]     |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Status::Disconnected`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]    --> src/lib.rs:132:9
[INFO] [stderr]     |
[INFO] [stderr] 132 | /         match self.state {
[INFO] [stderr] 133 | |             ClientState::Responding(ref mut buf) => {
[INFO] [stderr] 134 | |                 match self.socket.try_write_buf(buf) {
[INFO] [stderr] 135 | |                     Ok(_) => {
[INFO] [stderr] ...   |
[INFO] [stderr] 149 | |             _ => ()
[INFO] [stderr] 150 | |         }
[INFO] [stderr]     | |_________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::single_match)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] help: try this
[INFO] [stderr]     |
[INFO] [stderr] 132 |         if let ClientState::Responding(ref mut buf) = self.state {
[INFO] [stderr] 133 |     match self.socket.try_write_buf(buf) {
[INFO] [stderr] 134 |         Ok(_) => {
[INFO] [stderr] 135 |             // Done writing if the cursor position is at end of buf
[INFO] [stderr] 136 |             if buf.get_ref().len() as u64 == buf.position() {
[INFO] [stderr] 137 |                 // Transition to base state. We use the done flag since state is
[INFO] [stderr]   ...
[INFO] [stderr] 
[INFO] [stderr] warning: this loop could be written as a `while let` loop
[INFO] [stderr]    --> src/lib.rs:182:9
[INFO] [stderr]     |
[INFO] [stderr] 182 | /         loop {
[INFO] [stderr] 183 | |             // Got some bytes. Check if there's a newline in the new
[INFO] [stderr] 184 | |             // output.  If there is, process it.
[INFO] [stderr] 185 | |             if let Some(pos) = find_in_slice(&self.buf[..self.pos], NEWLINE) {
[INFO] [stderr] ...   |
[INFO] [stderr] 208 | |             }
[INFO] [stderr] 209 | |         }
[INFO] [stderr]     | |_________^ help: try: `while let Some(pos) = find_in_slice(&self.buf[..self.pos], NEWLINE) { .. }`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::while_let_loop)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]    --> src/lib.rs:132:9
[INFO] [stderr]     |
[INFO] [stderr] 132 | /         match self.state {
[INFO] [stderr] 133 | |             ClientState::Responding(ref mut buf) => {
[INFO] [stderr] 134 | |                 match self.socket.try_write_buf(buf) {
[INFO] [stderr] 135 | |                     Ok(_) => {
[INFO] [stderr] ...   |
[INFO] [stderr] 149 | |             _ => ()
[INFO] [stderr] 150 | |         }
[INFO] [stderr]     | |_________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::single_match)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] help: try this
[INFO] [stderr]     |
[INFO] [stderr] 132 |         if let ClientState::Responding(ref mut buf) = self.state {
[INFO] [stderr] 133 |     match self.socket.try_write_buf(buf) {
[INFO] [stderr] 134 |         Ok(_) => {
[INFO] [stderr] 135 |             // Done writing if the cursor position is at end of buf
[INFO] [stderr] 136 |             if buf.get_ref().len() as u64 == buf.position() {
[INFO] [stderr] 137 |                 // Transition to base state. We use the done flag since state is
[INFO] [stderr]   ...
[INFO] [stderr] 
[INFO] [stderr] warning: this loop could be written as a `while let` loop
[INFO] [stderr]    --> src/lib.rs:182:9
[INFO] [stderr]     |
[INFO] [stderr] 182 | /         loop {
[INFO] [stderr] 183 | |             // Got some bytes. Check if there's a newline in the new
[INFO] [stderr] 184 | |             // output.  If there is, process it.
[INFO] [stderr] 185 | |             if let Some(pos) = find_in_slice(&self.buf[..self.pos], NEWLINE) {
[INFO] [stderr] ...   |
[INFO] [stderr] 208 | |             }
[INFO] [stderr] 209 | |         }
[INFO] [stderr]     | |_________^ help: try: `while let Some(pos) = find_in_slice(&self.buf[..self.pos], NEWLINE) { .. }`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::while_let_loop)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 2.77s
[INFO] running `"docker" "inspect" "dd4a703644a1e036ec48ec6bf19af41347cc2d0a52e61c6c73081b164fc2bbe4"`
[INFO] running `"docker" "rm" "-f" "dd4a703644a1e036ec48ec6bf19af41347cc2d0a52e61c6c73081b164fc2bbe4"`
[INFO] [stdout] dd4a703644a1e036ec48ec6bf19af41347cc2d0a52e61c6c73081b164fc2bbe4