[INFO] crate lightning 0.0.7 is already in cache [INFO] extracting crate lightning 0.0.7 into work/ex/clippy-test-run/sources/stable/reg/lightning/0.0.7 [INFO] extracting crate lightning 0.0.7 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/lightning/0.0.7 [INFO] validating manifest of lightning-0.0.7 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of lightning-0.0.7 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing lightning-0.0.7 [INFO] finished frobbing lightning-0.0.7 [INFO] frobbed toml for lightning-0.0.7 written to work/ex/clippy-test-run/sources/stable/reg/lightning/0.0.7/Cargo.toml [INFO] started frobbing lightning-0.0.7 [INFO] finished frobbing lightning-0.0.7 [INFO] frobbed toml for lightning-0.0.7 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/lightning/0.0.7/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting lightning-0.0.7 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/lightning/0.0.7:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 61468a3559895e15b713c8e8c0a18eb9fa85c3ac62eab3d334ccdf2293754552 [INFO] running `"docker" "start" "-a" "61468a3559895e15b713c8e8c0a18eb9fa85c3ac62eab3d334ccdf2293754552"` [INFO] [stderr] Compiling libc v0.2.48 [INFO] [stderr] Compiling cc v1.0.26 [INFO] [stderr] Compiling gcc v0.3.55 [INFO] [stderr] Compiling byteorder v1.3.1 [INFO] [stderr] Checking bech32 v0.5.0 [INFO] [stderr] Checking rustc-serialize v0.3.24 [INFO] [stderr] Checking hex v0.3.2 [INFO] [stderr] Checking bitcoin-bech32 v0.8.1 [INFO] [stderr] Checking rand v0.4.6 [INFO] [stderr] Checking time v0.1.42 [INFO] [stderr] Compiling rust-crypto v0.2.36 [INFO] [stderr] Compiling bitcoinconsensus v0.16.4 [INFO] [stderr] Compiling secp256k1 v0.11.6 [INFO] [stderr] Compiling lightning v0.0.7 (/opt/crater/workdir) [INFO] [stderr] Checking rand v0.3.23 [INFO] [stderr] Checking bitcoin v0.15.1 [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/util/chacha20poly1305rfc.rs:58:5 [INFO] [stderr] | [INFO] [stderr] 58 | cipher: cipher, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `cipher` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/util/chacha20poly1305rfc.rs:59:5 [INFO] [stderr] | [INFO] [stderr] 59 | mac: mac, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `mac` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/util/macro_logger.rs:74:4 [INFO] [stderr] | [INFO] [stderr] 74 | write!(f, "node_id: {}, short_channel_id: {}, fee_msat: {}, cltv_expiry_delta: {}\n", log_pubkey!(h.pubkey), h.short_channel_id, h.fee_msat, h.cltv_expiry_delta)?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::write_with_newline)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/chain/chaininterface.rs:250:4 [INFO] [stderr] | [INFO] [stderr] 250 | network: network, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `network` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/chain/chaininterface.rs:254:4 [INFO] [stderr] | [INFO] [stderr] 254 | logger: logger, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `logger` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/chain/keysinterface.rs:137:4 [INFO] [stderr] | [INFO] [stderr] 137 | funding_key: funding_key, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `funding_key` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/chain/keysinterface.rs:138:4 [INFO] [stderr] | [INFO] [stderr] 138 | revocation_base_key: revocation_base_key, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `revocation_base_key` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/chain/keysinterface.rs:139:4 [INFO] [stderr] | [INFO] [stderr] 139 | payment_base_key: payment_base_key, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `payment_base_key` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/chain/keysinterface.rs:140:4 [INFO] [stderr] | [INFO] [stderr] 140 | delayed_payment_base_key: delayed_payment_base_key, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `delayed_payment_base_key` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/chain/keysinterface.rs:141:4 [INFO] [stderr] | [INFO] [stderr] 141 | htlc_base_key: htlc_base_key, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `htlc_base_key` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ln/channelmanager.rs:917:4 [INFO] [stderr] | [INFO] [stderr] 917 | failuremsg: failuremsg, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `failuremsg` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ln/channelmanager.rs:918:4 [INFO] [stderr] | [INFO] [stderr] 918 | pad: pad, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `pad` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ln/channelmanager.rs:1156:4 [INFO] [stderr] | [INFO] [stderr] 1156 | short_channel_id: short_channel_id, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `short_channel_id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ln/channelmanager.rs:1323:4 [INFO] [stderr] | [INFO] [stderr] 1323 | msg: msg, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `msg` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ln/channelmanager.rs:1774:4 [INFO] [stderr] | [INFO] [stderr] 1774 | output_script: output_script, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `output_script` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ln/channelmanager.rs:1843:4 [INFO] [stderr] | [INFO] [stderr] 1843 | funding_txo: funding_txo, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `funding_txo` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ln/channelmanager.rs:3799:16 [INFO] [stderr] | [INFO] [stderr] 3799 | SendEvent { node_id: node_id, msgs: updates.update_add_htlcs, commitment_msg: updates.commitment_signed } [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `node_id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ln/channelmonitor.rs:370:4 [INFO] [stderr] | [INFO] [stderr] 370 | our_to_self_delay: our_to_self_delay, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `our_to_self_delay` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ln/channelmonitor.rs:383:4 [INFO] [stderr] | [INFO] [stderr] 383 | destination_script: destination_script, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `destination_script` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ln/msgs.rs:1296:4 [INFO] [stderr] | [INFO] [stderr] 1296 | features: features, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `features` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ln/msgs.rs:1297:4 [INFO] [stderr] | [INFO] [stderr] 1297 | timestamp: timestamp, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `timestamp` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ln/msgs.rs:1298:4 [INFO] [stderr] | [INFO] [stderr] 1298 | node_id: node_id, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `node_id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ln/msgs.rs:1299:4 [INFO] [stderr] | [INFO] [stderr] 1299 | rgb: rgb, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `rgb` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ln/msgs.rs:1300:4 [INFO] [stderr] | [INFO] [stderr] 1300 | alias: alias, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `alias` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ln/msgs.rs:1301:4 [INFO] [stderr] | [INFO] [stderr] 1301 | addresses: addresses, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `addresses` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ln/msgs.rs:1302:4 [INFO] [stderr] | [INFO] [stderr] 1302 | excess_address_data: excess_address_data, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `excess_address_data` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/ln/router.rs:169:4 [INFO] [stderr] | [INFO] [stderr] 169 | write!(f, " {}: {}\n", key, val)?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/ln/router.rs:171:3 [INFO] [stderr] | [INFO] [stderr] 171 | write!(f, "[Nodes]\n")?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/ln/router.rs:173:4 [INFO] [stderr] | [INFO] [stderr] 173 | write!(f, " {}: {}\n", log_pubkey!(key), val)?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ln/router.rs:590:5 [INFO] [stderr] | [INFO] [stderr] 590 | nodes: nodes, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `nodes` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ln/peer_handler.rs:193:4 [INFO] [stderr] | [INFO] [stderr] 193 | message_handler: message_handler, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `message_handler` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ln/peer_handler.rs:199:4 [INFO] [stderr] | [INFO] [stderr] 199 | our_node_secret: our_node_secret, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `our_node_secret` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ln/peer_handler.rs:245:4 [INFO] [stderr] | [INFO] [stderr] 245 | pending_read_buffer: pending_read_buffer, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `pending_read_buffer` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ln/peer_handler.rs:281:4 [INFO] [stderr] | [INFO] [stderr] 281 | pending_read_buffer: pending_read_buffer, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `pending_read_buffer` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ln/peer_channel_encryptor.rs:91:4 [INFO] [stderr] | [INFO] [stderr] 91 | secp_ctx: secp_ctx, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `secp_ctx` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ln/peer_channel_encryptor.rs:98:6 [INFO] [stderr] | [INFO] [stderr] 98 | h: h, [INFO] [stderr] | ^^^^ help: replace it with: `h` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ln/peer_channel_encryptor.rs:117:4 [INFO] [stderr] | [INFO] [stderr] 117 | secp_ctx: secp_ctx, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `secp_ctx` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ln/peer_channel_encryptor.rs:126:6 [INFO] [stderr] | [INFO] [stderr] 126 | h: h, [INFO] [stderr] | ^^^^ help: replace it with: `h` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ln/peer_channel_encryptor.rs:329:4 [INFO] [stderr] | [INFO] [stderr] 329 | sk: sk, [INFO] [stderr] | ^^^^^^ help: replace it with: `sk` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ln/peer_channel_encryptor.rs:332:4 [INFO] [stderr] | [INFO] [stderr] 332 | rk: rk, [INFO] [stderr] | ^^^^^^ help: replace it with: `rk` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ln/peer_channel_encryptor.rs:389:4 [INFO] [stderr] | [INFO] [stderr] 389 | sk: sk, [INFO] [stderr] | ^^^^^^ help: replace it with: `sk` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ln/peer_channel_encryptor.rs:392:4 [INFO] [stderr] | [INFO] [stderr] 392 | rk: rk, [INFO] [stderr] | ^^^^^^ help: replace it with: `rk` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ln/channel.rs:449:4 [INFO] [stderr] | [INFO] [stderr] 449 | user_id: user_id, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `user_id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ln/channel.rs:455:4 [INFO] [stderr] | [INFO] [stderr] 455 | secp_ctx: secp_ctx, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `secp_ctx` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ln/channel.rs:456:4 [INFO] [stderr] | [INFO] [stderr] 456 | channel_value_satoshis: channel_value_satoshis, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `channel_value_satoshis` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ln/channel.rs:513:4 [INFO] [stderr] | [INFO] [stderr] 513 | their_node_id: their_node_id, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `their_node_id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ln/channel.rs:517:4 [INFO] [stderr] | [INFO] [stderr] 517 | channel_monitor: channel_monitor, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `channel_monitor` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ln/channel.rs:639:4 [INFO] [stderr] | [INFO] [stderr] 639 | user_id: user_id, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `user_id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ln/channel.rs:645:4 [INFO] [stderr] | [INFO] [stderr] 645 | secp_ctx: secp_ctx, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `secp_ctx` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ln/channel.rs:686:4 [INFO] [stderr] | [INFO] [stderr] 686 | our_dust_limit_satoshis: our_dust_limit_satoshis, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `our_dust_limit_satoshis` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ln/channel.rs:703:4 [INFO] [stderr] | [INFO] [stderr] 703 | their_node_id: their_node_id, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `their_node_id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ln/channel.rs:707:4 [INFO] [stderr] | [INFO] [stderr] 707 | channel_monitor: channel_monitor, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `channel_monitor` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ln/channel.rs:1780:4 [INFO] [stderr] | [INFO] [stderr] 1780 | per_commitment_secret: per_commitment_secret, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `per_commitment_secret` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ln/channel.rs:1781:4 [INFO] [stderr] | [INFO] [stderr] 1781 | next_per_commitment_point: next_per_commitment_point, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `next_per_commitment_point` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ln/channel.rs:1867:7 [INFO] [stderr] | [INFO] [stderr] 1867 | update_fee: update_fee, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `update_fee` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ln/channel.rs:2327:5 [INFO] [stderr] | [INFO] [stderr] 2327 | next_per_commitment_point: next_per_commitment_point, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `next_per_commitment_point` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ln/channel.rs:2358:5 [INFO] [stderr] | [INFO] [stderr] 2358 | next_per_commitment_point: next_per_commitment_point, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `next_per_commitment_point` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ln/channel.rs:2820:8 [INFO] [stderr] | [INFO] [stderr] 2820 | next_per_commitment_point: next_per_commitment_point, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `next_per_commitment_point` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ln/channel.rs:2902:4 [INFO] [stderr] | [INFO] [stderr] 2902 | chain_hash: chain_hash, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `chain_hash` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ln/channel.rs:3007:4 [INFO] [stderr] | [INFO] [stderr] 3007 | temporary_channel_id: temporary_channel_id, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `temporary_channel_id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ln/channel.rs:3038:4 [INFO] [stderr] | [INFO] [stderr] 3038 | chain_hash: chain_hash, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `chain_hash` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ln/channel.rs:3129:5 [INFO] [stderr] | [INFO] [stderr] 3129 | amount_msat: amount_msat, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `amount_msat` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ln/channel.rs:3130:5 [INFO] [stderr] | [INFO] [stderr] 3130 | payment_hash: payment_hash, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `payment_hash` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ln/channel.rs:3131:5 [INFO] [stderr] | [INFO] [stderr] 3131 | cltv_expiry: cltv_expiry, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `cltv_expiry` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ln/channel.rs:3133:5 [INFO] [stderr] | [INFO] [stderr] 3133 | onion_routing_packet: onion_routing_packet, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `onion_routing_packet` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ln/channel.rs:3141:4 [INFO] [stderr] | [INFO] [stderr] 3141 | amount_msat: amount_msat, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `amount_msat` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ln/channel.rs:3143:4 [INFO] [stderr] | [INFO] [stderr] 3143 | cltv_expiry: cltv_expiry, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `cltv_expiry` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ln/channel.rs:3152:4 [INFO] [stderr] | [INFO] [stderr] 3152 | amount_msat: amount_msat, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `amount_msat` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ln/channel.rs:3153:4 [INFO] [stderr] | [INFO] [stderr] 3153 | payment_hash: payment_hash, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `payment_hash` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ln/channel.rs:3154:4 [INFO] [stderr] | [INFO] [stderr] 3154 | cltv_expiry: cltv_expiry, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `cltv_expiry` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ln/channel.rs:3155:4 [INFO] [stderr] | [INFO] [stderr] 3155 | onion_routing_packet: onion_routing_packet, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `onion_routing_packet` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/util/chacha20poly1305rfc.rs:58:5 [INFO] [stderr] | [INFO] [stderr] 58 | cipher: cipher, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `cipher` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/util/chacha20poly1305rfc.rs:59:5 [INFO] [stderr] | [INFO] [stderr] 59 | mac: mac, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `mac` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/util/macro_logger.rs:74:4 [INFO] [stderr] | [INFO] [stderr] 74 | write!(f, "node_id: {}, short_channel_id: {}, fee_msat: {}, cltv_expiry_delta: {}\n", log_pubkey!(h.pubkey), h.short_channel_id, h.fee_msat, h.cltv_expiry_delta)?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::write_with_newline)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/chain/chaininterface.rs:250:4 [INFO] [stderr] | [INFO] [stderr] 250 | network: network, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `network` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/chain/chaininterface.rs:254:4 [INFO] [stderr] | [INFO] [stderr] 254 | logger: logger, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `logger` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/chain/keysinterface.rs:137:4 [INFO] [stderr] | [INFO] [stderr] 137 | funding_key: funding_key, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `funding_key` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/chain/keysinterface.rs:138:4 [INFO] [stderr] | [INFO] [stderr] 138 | revocation_base_key: revocation_base_key, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `revocation_base_key` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/chain/keysinterface.rs:139:4 [INFO] [stderr] | [INFO] [stderr] 139 | payment_base_key: payment_base_key, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `payment_base_key` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/chain/keysinterface.rs:140:4 [INFO] [stderr] | [INFO] [stderr] 140 | delayed_payment_base_key: delayed_payment_base_key, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `delayed_payment_base_key` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/chain/keysinterface.rs:141:4 [INFO] [stderr] | [INFO] [stderr] 141 | htlc_base_key: htlc_base_key, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `htlc_base_key` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ln/channelmanager.rs:917:4 [INFO] [stderr] | [INFO] [stderr] 917 | failuremsg: failuremsg, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `failuremsg` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ln/channelmanager.rs:918:4 [INFO] [stderr] | [INFO] [stderr] 918 | pad: pad, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `pad` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ln/channelmanager.rs:1156:4 [INFO] [stderr] | [INFO] [stderr] 1156 | short_channel_id: short_channel_id, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `short_channel_id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ln/channelmanager.rs:1323:4 [INFO] [stderr] | [INFO] [stderr] 1323 | msg: msg, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `msg` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ln/channelmanager.rs:1774:4 [INFO] [stderr] | [INFO] [stderr] 1774 | output_script: output_script, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `output_script` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ln/channelmanager.rs:1843:4 [INFO] [stderr] | [INFO] [stderr] 1843 | funding_txo: funding_txo, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `funding_txo` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ln/channelmanager.rs:3799:16 [INFO] [stderr] | [INFO] [stderr] 3799 | SendEvent { node_id: node_id, msgs: updates.update_add_htlcs, commitment_msg: updates.commitment_signed } [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `node_id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ln/channelmonitor.rs:370:4 [INFO] [stderr] | [INFO] [stderr] 370 | our_to_self_delay: our_to_self_delay, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `our_to_self_delay` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ln/channelmonitor.rs:383:4 [INFO] [stderr] | [INFO] [stderr] 383 | destination_script: destination_script, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `destination_script` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ln/msgs.rs:1296:4 [INFO] [stderr] | [INFO] [stderr] 1296 | features: features, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `features` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ln/msgs.rs:1297:4 [INFO] [stderr] | [INFO] [stderr] 1297 | timestamp: timestamp, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `timestamp` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ln/msgs.rs:1298:4 [INFO] [stderr] | [INFO] [stderr] 1298 | node_id: node_id, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `node_id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ln/msgs.rs:1299:4 [INFO] [stderr] | [INFO] [stderr] 1299 | rgb: rgb, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `rgb` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ln/msgs.rs:1300:4 [INFO] [stderr] | [INFO] [stderr] 1300 | alias: alias, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `alias` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ln/msgs.rs:1301:4 [INFO] [stderr] | [INFO] [stderr] 1301 | addresses: addresses, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `addresses` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ln/msgs.rs:1302:4 [INFO] [stderr] | [INFO] [stderr] 1302 | excess_address_data: excess_address_data, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `excess_address_data` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/ln/router.rs:169:4 [INFO] [stderr] | [INFO] [stderr] 169 | write!(f, " {}: {}\n", key, val)?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/ln/router.rs:171:3 [INFO] [stderr] | [INFO] [stderr] 171 | write!(f, "[Nodes]\n")?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/ln/router.rs:173:4 [INFO] [stderr] | [INFO] [stderr] 173 | write!(f, " {}: {}\n", log_pubkey!(key), val)?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ln/router.rs:590:5 [INFO] [stderr] | [INFO] [stderr] 590 | nodes: nodes, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `nodes` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ln/peer_handler.rs:193:4 [INFO] [stderr] | [INFO] [stderr] 193 | message_handler: message_handler, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `message_handler` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ln/peer_handler.rs:199:4 [INFO] [stderr] | [INFO] [stderr] 199 | our_node_secret: our_node_secret, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `our_node_secret` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ln/peer_handler.rs:245:4 [INFO] [stderr] | [INFO] [stderr] 245 | pending_read_buffer: pending_read_buffer, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `pending_read_buffer` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ln/peer_handler.rs:281:4 [INFO] [stderr] | [INFO] [stderr] 281 | pending_read_buffer: pending_read_buffer, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `pending_read_buffer` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ln/peer_channel_encryptor.rs:91:4 [INFO] [stderr] | [INFO] [stderr] 91 | secp_ctx: secp_ctx, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `secp_ctx` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ln/peer_channel_encryptor.rs:98:6 [INFO] [stderr] | [INFO] [stderr] 98 | h: h, [INFO] [stderr] | ^^^^ help: replace it with: `h` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ln/peer_channel_encryptor.rs:117:4 [INFO] [stderr] | [INFO] [stderr] 117 | secp_ctx: secp_ctx, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `secp_ctx` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ln/peer_channel_encryptor.rs:126:6 [INFO] [stderr] | [INFO] [stderr] 126 | h: h, [INFO] [stderr] | ^^^^ help: replace it with: `h` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ln/peer_channel_encryptor.rs:329:4 [INFO] [stderr] | [INFO] [stderr] 329 | sk: sk, [INFO] [stderr] | ^^^^^^ help: replace it with: `sk` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ln/peer_channel_encryptor.rs:332:4 [INFO] [stderr] | [INFO] [stderr] 332 | rk: rk, [INFO] [stderr] | ^^^^^^ help: replace it with: `rk` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ln/peer_channel_encryptor.rs:389:4 [INFO] [stderr] | [INFO] [stderr] 389 | sk: sk, [INFO] [stderr] | ^^^^^^ help: replace it with: `sk` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ln/peer_channel_encryptor.rs:392:4 [INFO] [stderr] | [INFO] [stderr] 392 | rk: rk, [INFO] [stderr] | ^^^^^^ help: replace it with: `rk` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ln/channel.rs:449:4 [INFO] [stderr] | [INFO] [stderr] 449 | user_id: user_id, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `user_id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ln/channel.rs:455:4 [INFO] [stderr] | [INFO] [stderr] 455 | secp_ctx: secp_ctx, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `secp_ctx` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ln/channel.rs:456:4 [INFO] [stderr] | [INFO] [stderr] 456 | channel_value_satoshis: channel_value_satoshis, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `channel_value_satoshis` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ln/channel.rs:513:4 [INFO] [stderr] | [INFO] [stderr] 513 | their_node_id: their_node_id, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `their_node_id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ln/channel.rs:517:4 [INFO] [stderr] | [INFO] [stderr] 517 | channel_monitor: channel_monitor, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `channel_monitor` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ln/channel.rs:639:4 [INFO] [stderr] | [INFO] [stderr] 639 | user_id: user_id, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `user_id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ln/channel.rs:645:4 [INFO] [stderr] | [INFO] [stderr] 645 | secp_ctx: secp_ctx, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `secp_ctx` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ln/channel.rs:686:4 [INFO] [stderr] | [INFO] [stderr] 686 | our_dust_limit_satoshis: our_dust_limit_satoshis, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `our_dust_limit_satoshis` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ln/channel.rs:703:4 [INFO] [stderr] | [INFO] [stderr] 703 | their_node_id: their_node_id, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `their_node_id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ln/channel.rs:707:4 [INFO] [stderr] | [INFO] [stderr] 707 | channel_monitor: channel_monitor, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `channel_monitor` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ln/channel.rs:1780:4 [INFO] [stderr] | [INFO] [stderr] 1780 | per_commitment_secret: per_commitment_secret, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `per_commitment_secret` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ln/channel.rs:1781:4 [INFO] [stderr] | [INFO] [stderr] 1781 | next_per_commitment_point: next_per_commitment_point, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `next_per_commitment_point` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ln/channel.rs:1867:7 [INFO] [stderr] | [INFO] [stderr] 1867 | update_fee: update_fee, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `update_fee` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ln/channel.rs:2327:5 [INFO] [stderr] | [INFO] [stderr] 2327 | next_per_commitment_point: next_per_commitment_point, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `next_per_commitment_point` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ln/channel.rs:2358:5 [INFO] [stderr] | [INFO] [stderr] 2358 | next_per_commitment_point: next_per_commitment_point, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `next_per_commitment_point` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ln/channel.rs:2820:8 [INFO] [stderr] | [INFO] [stderr] 2820 | next_per_commitment_point: next_per_commitment_point, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `next_per_commitment_point` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ln/channel.rs:2902:4 [INFO] [stderr] | [INFO] [stderr] 2902 | chain_hash: chain_hash, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `chain_hash` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ln/channel.rs:3007:4 [INFO] [stderr] | [INFO] [stderr] 3007 | temporary_channel_id: temporary_channel_id, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `temporary_channel_id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ln/channel.rs:3038:4 [INFO] [stderr] | [INFO] [stderr] 3038 | chain_hash: chain_hash, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `chain_hash` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ln/channel.rs:3129:5 [INFO] [stderr] | [INFO] [stderr] 3129 | amount_msat: amount_msat, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `amount_msat` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ln/channel.rs:3130:5 [INFO] [stderr] | [INFO] [stderr] 3130 | payment_hash: payment_hash, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `payment_hash` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ln/channel.rs:3131:5 [INFO] [stderr] | [INFO] [stderr] 3131 | cltv_expiry: cltv_expiry, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `cltv_expiry` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ln/channel.rs:3133:5 [INFO] [stderr] | [INFO] [stderr] 3133 | onion_routing_packet: onion_routing_packet, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `onion_routing_packet` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ln/channel.rs:3141:4 [INFO] [stderr] | [INFO] [stderr] 3141 | amount_msat: amount_msat, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `amount_msat` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ln/channel.rs:3143:4 [INFO] [stderr] | [INFO] [stderr] 3143 | cltv_expiry: cltv_expiry, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `cltv_expiry` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ln/channel.rs:3152:4 [INFO] [stderr] | [INFO] [stderr] 3152 | amount_msat: amount_msat, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `amount_msat` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ln/channel.rs:3153:4 [INFO] [stderr] | [INFO] [stderr] 3153 | payment_hash: payment_hash, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `payment_hash` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ln/channel.rs:3154:4 [INFO] [stderr] | [INFO] [stderr] 3154 | cltv_expiry: cltv_expiry, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `cltv_expiry` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ln/channel.rs:3155:4 [INFO] [stderr] | [INFO] [stderr] 3155 | onion_routing_packet: onion_routing_packet, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `onion_routing_packet` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/util/ser.rs:338:14 [INFO] [stderr] | [INFO] [stderr] 338 | Err(_) => return Err(DecodeError::InvalidValue), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(DecodeError::InvalidValue)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/util/ser.rs:356:14 [INFO] [stderr] | [INFO] [stderr] 356 | Err(_) => return Err(DecodeError::InvalidValue), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(DecodeError::InvalidValue)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/util/ser.rs:385:14 [INFO] [stderr] | [INFO] [stderr] 385 | Err(_) => return Err(DecodeError::InvalidValue), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(DecodeError::InvalidValue)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: operator precedence can trip the unwary [INFO] [stderr] --> src/util/byte_utils.rs:3:3 [INFO] [stderr] | [INFO] [stderr] 3 | ((v[0] as u16) << 8*1) | [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: consider parenthesizing your expression: `(v[0] as u16) << (8*1)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::precedence)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence [INFO] [stderr] [INFO] [stderr] warning: operator precedence can trip the unwary [INFO] [stderr] --> src/util/byte_utils.rs:4:3 [INFO] [stderr] | [INFO] [stderr] 4 | ((v[1] as u16) << 8*0) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: consider parenthesizing your expression: `(v[1] as u16) << (8*0)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence [INFO] [stderr] [INFO] [stderr] warning: operator precedence can trip the unwary [INFO] [stderr] --> src/util/byte_utils.rs:8:3 [INFO] [stderr] | [INFO] [stderr] 8 | ((v[0] as u32) << 8*3) | [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: consider parenthesizing your expression: `(v[0] as u32) << (8*3)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence [INFO] [stderr] [INFO] [stderr] warning: operator precedence can trip the unwary [INFO] [stderr] --> src/util/byte_utils.rs:9:3 [INFO] [stderr] | [INFO] [stderr] 9 | ((v[1] as u32) << 8*2) | [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: consider parenthesizing your expression: `(v[1] as u32) << (8*2)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence [INFO] [stderr] [INFO] [stderr] warning: operator precedence can trip the unwary [INFO] [stderr] --> src/util/byte_utils.rs:10:3 [INFO] [stderr] | [INFO] [stderr] 10 | ((v[2] as u32) << 8*1) | [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: consider parenthesizing your expression: `(v[2] as u32) << (8*1)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence [INFO] [stderr] [INFO] [stderr] warning: operator precedence can trip the unwary [INFO] [stderr] --> src/util/byte_utils.rs:11:3 [INFO] [stderr] | [INFO] [stderr] 11 | ((v[3] as u32) << 8*0) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: consider parenthesizing your expression: `(v[3] as u32) << (8*0)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence [INFO] [stderr] [INFO] [stderr] warning: operator precedence can trip the unwary [INFO] [stderr] --> src/util/byte_utils.rs:15:3 [INFO] [stderr] | [INFO] [stderr] 15 | ((v[0] as u64) << 8*5) | [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: consider parenthesizing your expression: `(v[0] as u64) << (8*5)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence [INFO] [stderr] [INFO] [stderr] warning: operator precedence can trip the unwary [INFO] [stderr] --> src/util/byte_utils.rs:16:3 [INFO] [stderr] | [INFO] [stderr] 16 | ((v[1] as u64) << 8*4) | [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: consider parenthesizing your expression: `(v[1] as u64) << (8*4)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence [INFO] [stderr] [INFO] [stderr] warning: operator precedence can trip the unwary [INFO] [stderr] --> src/util/byte_utils.rs:17:3 [INFO] [stderr] | [INFO] [stderr] 17 | ((v[2] as u64) << 8*3) | [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: consider parenthesizing your expression: `(v[2] as u64) << (8*3)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence [INFO] [stderr] [INFO] [stderr] warning: operator precedence can trip the unwary [INFO] [stderr] --> src/util/byte_utils.rs:18:3 [INFO] [stderr] | [INFO] [stderr] 18 | ((v[3] as u64) << 8*2) | [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: consider parenthesizing your expression: `(v[3] as u64) << (8*2)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence [INFO] [stderr] [INFO] [stderr] warning: operator precedence can trip the unwary [INFO] [stderr] --> src/util/byte_utils.rs:19:3 [INFO] [stderr] | [INFO] [stderr] 19 | ((v[4] as u64) << 8*1) | [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: consider parenthesizing your expression: `(v[4] as u64) << (8*1)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence [INFO] [stderr] [INFO] [stderr] warning: operator precedence can trip the unwary [INFO] [stderr] --> src/util/byte_utils.rs:20:3 [INFO] [stderr] | [INFO] [stderr] 20 | ((v[5] as u64) << 8*0) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: consider parenthesizing your expression: `(v[5] as u64) << (8*0)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence [INFO] [stderr] [INFO] [stderr] warning: operator precedence can trip the unwary [INFO] [stderr] --> src/util/byte_utils.rs:24:3 [INFO] [stderr] | [INFO] [stderr] 24 | ((v[0] as u64) << 8*7) | [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: consider parenthesizing your expression: `(v[0] as u64) << (8*7)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence [INFO] [stderr] [INFO] [stderr] warning: operator precedence can trip the unwary [INFO] [stderr] --> src/util/byte_utils.rs:25:3 [INFO] [stderr] | [INFO] [stderr] 25 | ((v[1] as u64) << 8*6) | [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: consider parenthesizing your expression: `(v[1] as u64) << (8*6)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence [INFO] [stderr] [INFO] [stderr] warning: operator precedence can trip the unwary [INFO] [stderr] --> src/util/byte_utils.rs:26:3 [INFO] [stderr] | [INFO] [stderr] 26 | ((v[2] as u64) << 8*5) | [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: consider parenthesizing your expression: `(v[2] as u64) << (8*5)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence [INFO] [stderr] [INFO] [stderr] warning: operator precedence can trip the unwary [INFO] [stderr] --> src/util/byte_utils.rs:27:3 [INFO] [stderr] | [INFO] [stderr] 27 | ((v[3] as u64) << 8*4) | [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: consider parenthesizing your expression: `(v[3] as u64) << (8*4)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence [INFO] [stderr] [INFO] [stderr] warning: operator precedence can trip the unwary [INFO] [stderr] --> src/util/byte_utils.rs:28:3 [INFO] [stderr] | [INFO] [stderr] 28 | ((v[4] as u64) << 8*3) | [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: consider parenthesizing your expression: `(v[4] as u64) << (8*3)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence [INFO] [stderr] [INFO] [stderr] warning: operator precedence can trip the unwary [INFO] [stderr] --> src/util/byte_utils.rs:29:3 [INFO] [stderr] | [INFO] [stderr] 29 | ((v[5] as u64) << 8*2) | [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: consider parenthesizing your expression: `(v[5] as u64) << (8*2)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence [INFO] [stderr] [INFO] [stderr] warning: operator precedence can trip the unwary [INFO] [stderr] --> src/util/byte_utils.rs:30:3 [INFO] [stderr] | [INFO] [stderr] 30 | ((v[6] as u64) << 8*1) | [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: consider parenthesizing your expression: `(v[6] as u64) << (8*1)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence [INFO] [stderr] [INFO] [stderr] warning: operator precedence can trip the unwary [INFO] [stderr] --> src/util/byte_utils.rs:31:3 [INFO] [stderr] | [INFO] [stderr] 31 | ((v[7] as u64) << 8*0) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: consider parenthesizing your expression: `(v[7] as u64) << (8*0)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence [INFO] [stderr] [INFO] [stderr] warning: operator precedence can trip the unwary [INFO] [stderr] --> src/util/byte_utils.rs:37:11 [INFO] [stderr] | [INFO] [stderr] 37 | v[0] = ((u >> 8*1) & 0xff) as u8; [INFO] [stderr] | ^^^^^^^^ help: consider parenthesizing your expression: `u >> (8*1)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence [INFO] [stderr] [INFO] [stderr] warning: operator precedence can trip the unwary [INFO] [stderr] --> src/util/byte_utils.rs:38:11 [INFO] [stderr] | [INFO] [stderr] 38 | v[1] = ((u >> 8*0) & 0xff) as u8; [INFO] [stderr] | ^^^^^^^^ help: consider parenthesizing your expression: `u >> (8*0)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence [INFO] [stderr] [INFO] [stderr] warning: operator precedence can trip the unwary [INFO] [stderr] --> src/util/byte_utils.rs:44:11 [INFO] [stderr] | [INFO] [stderr] 44 | v[0] = ((u >> 8*3) & 0xff) as u8; [INFO] [stderr] | ^^^^^^^^ help: consider parenthesizing your expression: `u >> (8*3)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence [INFO] [stderr] [INFO] [stderr] warning: operator precedence can trip the unwary [INFO] [stderr] --> src/util/byte_utils.rs:45:11 [INFO] [stderr] | [INFO] [stderr] 45 | v[1] = ((u >> 8*2) & 0xff) as u8; [INFO] [stderr] | ^^^^^^^^ help: consider parenthesizing your expression: `u >> (8*2)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence [INFO] [stderr] [INFO] [stderr] warning: operator precedence can trip the unwary [INFO] [stderr] --> src/util/byte_utils.rs:46:11 [INFO] [stderr] | [INFO] [stderr] 46 | v[2] = ((u >> 8*1) & 0xff) as u8; [INFO] [stderr] | ^^^^^^^^ help: consider parenthesizing your expression: `u >> (8*1)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence [INFO] [stderr] [INFO] [stderr] warning: operator precedence can trip the unwary [INFO] [stderr] --> src/util/byte_utils.rs:47:11 [INFO] [stderr] | [INFO] [stderr] 47 | v[3] = ((u >> 8*0) & 0xff) as u8; [INFO] [stderr] | ^^^^^^^^ help: consider parenthesizing your expression: `u >> (8*0)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence [INFO] [stderr] [INFO] [stderr] warning: operator precedence can trip the unwary [INFO] [stderr] --> src/util/byte_utils.rs:54:11 [INFO] [stderr] | [INFO] [stderr] 54 | v[0] = ((u >> 8*5) & 0xff) as u8; [INFO] [stderr] | ^^^^^^^^ help: consider parenthesizing your expression: `u >> (8*5)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence [INFO] [stderr] [INFO] [stderr] warning: operator precedence can trip the unwary [INFO] [stderr] --> src/util/byte_utils.rs:55:11 [INFO] [stderr] | [INFO] [stderr] 55 | v[1] = ((u >> 8*4) & 0xff) as u8; [INFO] [stderr] | ^^^^^^^^ help: consider parenthesizing your expression: `u >> (8*4)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence [INFO] [stderr] [INFO] [stderr] warning: operator precedence can trip the unwary [INFO] [stderr] --> src/util/byte_utils.rs:56:11 [INFO] [stderr] | [INFO] [stderr] 56 | v[2] = ((u >> 8*3) & 0xff) as u8; [INFO] [stderr] | ^^^^^^^^ help: consider parenthesizing your expression: `u >> (8*3)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence [INFO] [stderr] [INFO] [stderr] warning: operator precedence can trip the unwary [INFO] [stderr] --> src/util/byte_utils.rs:57:11 [INFO] [stderr] | [INFO] [stderr] 57 | v[3] = ((u >> 8*2) & 0xff) as u8; [INFO] [stderr] | ^^^^^^^^ help: consider parenthesizing your expression: `u >> (8*2)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence [INFO] [stderr] [INFO] [stderr] warning: operator precedence can trip the unwary [INFO] [stderr] --> src/util/byte_utils.rs:58:11 [INFO] [stderr] | [INFO] [stderr] 58 | v[4] = ((u >> 8*1) & 0xff) as u8; [INFO] [stderr] | ^^^^^^^^ help: consider parenthesizing your expression: `u >> (8*1)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence [INFO] [stderr] [INFO] [stderr] warning: operator precedence can trip the unwary [INFO] [stderr] --> src/util/byte_utils.rs:59:11 [INFO] [stderr] | [INFO] [stderr] 59 | v[5] = ((u >> 8*0) & 0xff) as u8; [INFO] [stderr] | ^^^^^^^^ help: consider parenthesizing your expression: `u >> (8*0)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence [INFO] [stderr] [INFO] [stderr] warning: operator precedence can trip the unwary [INFO] [stderr] --> src/util/byte_utils.rs:65:11 [INFO] [stderr] | [INFO] [stderr] 65 | v[0] = ((u >> 8*7) & 0xff) as u8; [INFO] [stderr] | ^^^^^^^^ help: consider parenthesizing your expression: `u >> (8*7)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence [INFO] [stderr] [INFO] [stderr] warning: operator precedence can trip the unwary [INFO] [stderr] --> src/util/byte_utils.rs:66:11 [INFO] [stderr] | [INFO] [stderr] 66 | v[1] = ((u >> 8*6) & 0xff) as u8; [INFO] [stderr] | ^^^^^^^^ help: consider parenthesizing your expression: `u >> (8*6)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence [INFO] [stderr] [INFO] [stderr] warning: operator precedence can trip the unwary [INFO] [stderr] --> src/util/byte_utils.rs:67:11 [INFO] [stderr] | [INFO] [stderr] 67 | v[2] = ((u >> 8*5) & 0xff) as u8; [INFO] [stderr] | ^^^^^^^^ help: consider parenthesizing your expression: `u >> (8*5)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence [INFO] [stderr] [INFO] [stderr] warning: operator precedence can trip the unwary [INFO] [stderr] --> src/util/byte_utils.rs:68:11 [INFO] [stderr] | [INFO] [stderr] 68 | v[3] = ((u >> 8*4) & 0xff) as u8; [INFO] [stderr] | ^^^^^^^^ help: consider parenthesizing your expression: `u >> (8*4)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence [INFO] [stderr] [INFO] [stderr] warning: operator precedence can trip the unwary [INFO] [stderr] --> src/util/byte_utils.rs:69:11 [INFO] [stderr] | [INFO] [stderr] 69 | v[4] = ((u >> 8*3) & 0xff) as u8; [INFO] [stderr] | ^^^^^^^^ help: consider parenthesizing your expression: `u >> (8*3)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence [INFO] [stderr] [INFO] [stderr] warning: operator precedence can trip the unwary [INFO] [stderr] --> src/util/byte_utils.rs:70:11 [INFO] [stderr] | [INFO] [stderr] 70 | v[5] = ((u >> 8*2) & 0xff) as u8; [INFO] [stderr] | ^^^^^^^^ help: consider parenthesizing your expression: `u >> (8*2)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence [INFO] [stderr] [INFO] [stderr] warning: operator precedence can trip the unwary [INFO] [stderr] --> src/util/byte_utils.rs:71:11 [INFO] [stderr] | [INFO] [stderr] 71 | v[6] = ((u >> 8*1) & 0xff) as u8; [INFO] [stderr] | ^^^^^^^^ help: consider parenthesizing your expression: `u >> (8*1)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence [INFO] [stderr] [INFO] [stderr] warning: operator precedence can trip the unwary [INFO] [stderr] --> src/util/byte_utils.rs:72:11 [INFO] [stderr] | [INFO] [stderr] 72 | v[7] = ((u >> 8*0) & 0xff) as u8; [INFO] [stderr] | ^^^^^^^^ help: consider parenthesizing your expression: `u >> (8*0)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence [INFO] [stderr] [INFO] [stderr] warning: operator precedence can trip the unwary [INFO] [stderr] --> src/util/byte_utils.rs:79:11 [INFO] [stderr] | [INFO] [stderr] 79 | v[0] = ((u >> 8*0) & 0xff) as u8; [INFO] [stderr] | ^^^^^^^^ help: consider parenthesizing your expression: `u >> (8*0)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence [INFO] [stderr] [INFO] [stderr] warning: operator precedence can trip the unwary [INFO] [stderr] --> src/util/byte_utils.rs:80:11 [INFO] [stderr] | [INFO] [stderr] 80 | v[1] = ((u >> 8*1) & 0xff) as u8; [INFO] [stderr] | ^^^^^^^^ help: consider parenthesizing your expression: `u >> (8*1)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence [INFO] [stderr] [INFO] [stderr] warning: operator precedence can trip the unwary [INFO] [stderr] --> src/util/byte_utils.rs:81:11 [INFO] [stderr] | [INFO] [stderr] 81 | v[2] = ((u >> 8*2) & 0xff) as u8; [INFO] [stderr] | ^^^^^^^^ help: consider parenthesizing your expression: `u >> (8*2)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence [INFO] [stderr] [INFO] [stderr] warning: operator precedence can trip the unwary [INFO] [stderr] --> src/util/byte_utils.rs:82:11 [INFO] [stderr] | [INFO] [stderr] 82 | v[3] = ((u >> 8*3) & 0xff) as u8; [INFO] [stderr] | ^^^^^^^^ help: consider parenthesizing your expression: `u >> (8*3)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence [INFO] [stderr] [INFO] [stderr] warning: operator precedence can trip the unwary [INFO] [stderr] --> src/util/byte_utils.rs:83:11 [INFO] [stderr] | [INFO] [stderr] 83 | v[4] = ((u >> 8*4) & 0xff) as u8; [INFO] [stderr] | ^^^^^^^^ help: consider parenthesizing your expression: `u >> (8*4)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence [INFO] [stderr] [INFO] [stderr] warning: operator precedence can trip the unwary [INFO] [stderr] --> src/util/byte_utils.rs:84:11 [INFO] [stderr] | [INFO] [stderr] 84 | v[5] = ((u >> 8*5) & 0xff) as u8; [INFO] [stderr] | ^^^^^^^^ help: consider parenthesizing your expression: `u >> (8*5)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence [INFO] [stderr] [INFO] [stderr] warning: operator precedence can trip the unwary [INFO] [stderr] --> src/util/byte_utils.rs:85:11 [INFO] [stderr] | [INFO] [stderr] 85 | v[6] = ((u >> 8*6) & 0xff) as u8; [INFO] [stderr] | ^^^^^^^^ help: consider parenthesizing your expression: `u >> (8*6)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence [INFO] [stderr] [INFO] [stderr] warning: operator precedence can trip the unwary [INFO] [stderr] --> src/util/byte_utils.rs:86:11 [INFO] [stderr] | [INFO] [stderr] 86 | v[7] = ((u >> 8*7) & 0xff) as u8; [INFO] [stderr] | ^^^^^^^^ help: consider parenthesizing your expression: `u >> (8*7)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence [INFO] [stderr] [INFO] [stderr] warning: unused macro definition [INFO] [stderr] --> src/util/macro_logger.rs:98:1 [INFO] [stderr] | [INFO] [stderr] 98 | / macro_rules! log_warn { [INFO] [stderr] 99 | | ($self: ident, $($arg:tt)*) => ( [INFO] [stderr] 100 | | #[cfg(not(any(feature = "max_level_off", feature = "max_level_error")))] [INFO] [stderr] 101 | | log_internal!($self, $crate::util::logger::Level::Warn, $($arg)*); [INFO] [stderr] 102 | | ) [INFO] [stderr] 103 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_macros)] on by default [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/chain/chaininterface.rs:307:3 [INFO] [stderr] | [INFO] [stderr] 307 | return last_seen != self.reentered.load(Ordering::Relaxed); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `last_seen != self.reentered.load(Ordering::Relaxed)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ln/channelmanager.rs:802:25 [INFO] [stderr] | [INFO] [stderr] 802 | if cur_value_msat >= 21000000 * 100000000 * 1000 { [INFO] [stderr] | ^^^^^^^^ help: consider: `21_000_000` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ln/channelmanager.rs:802:36 [INFO] [stderr] | [INFO] [stderr] 802 | if cur_value_msat >= 21000000 * 100000000 * 1000 { [INFO] [stderr] | ^^^^^^^^^ help: consider: `100_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ln/channelmanager.rs:806:19 [INFO] [stderr] | [INFO] [stderr] 806 | if cur_cltv >= 500000000 { [INFO] [stderr] | ^^^^^^^^^ help: consider: `500_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ln/channelmanager.rs:1108:124 [INFO] [stderr] | [INFO] [stderr] 1108 | let fee = amt_to_forward.checked_mul(chan.get_fee_proportional_millionths() as u64).and_then(|prop_fee| { (prop_fee / 1000000).checked_add(chan.get_our_fee_base_msat(&*self.fee_estimator) as u64) }); [INFO] [stderr] | ^^^^^^^ help: consider: `1_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/ln/channelmanager.rs:2010:12 [INFO] [stderr] | [INFO] [stderr] 2010 | None => return Err(MsgHandleErrInternal::send_err_msg_no_close("Failed to find corresponding channel", msg.channel_id)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(MsgHandleErrInternal::send_err_msg_no_close("Failed to find corresponding channel", msg.channel_id))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ln/channelmanager.rs:2175:148 [INFO] [stderr] | [INFO] [stderr] 2175 | let new_fee = amt_to_forward.checked_mul(chan_update.contents.fee_proportional_millionths as u64).and_then(|prop_fee| { (prop_fee / 1000000).checked_add(chan_update.contents.fee_base_msat as u64) }); [INFO] [stderr] | ^^^^^^^ help: consider: `1_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> src/ln/channelmanager.rs:2225:12 [INFO] [stderr] | [INFO] [stderr] 2225 | } else { ((None, true)) } [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::double_parens)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/ln/channelmanager.rs:2259:12 [INFO] [stderr] | [INFO] [stderr] 2259 | None => return Err(MsgHandleErrInternal::send_err_msg_no_close("Failed to find corresponding channel", msg.channel_id)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(MsgHandleErrInternal::send_err_msg_no_close("Failed to find corresponding channel", msg.channel_id))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/ln/channelmanager.rs:2389:12 [INFO] [stderr] | [INFO] [stderr] 2389 | None => return Err(MsgHandleErrInternal::send_err_msg_no_close("Failed to find corresponding channel", msg.channel_id)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(MsgHandleErrInternal::send_err_msg_no_close("Failed to find corresponding channel", msg.channel_id))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ln/channelmonitor.rs:558:33 [INFO] [stderr] | [INFO] [stderr] 558 | let our_commitment_number = 0xffffffffffff - ((((local_tx.tx.input[0].sequence as u64 & 0xffffff) << 3*8) | (local_tx.tx.lock_time as u64 & 0xffffff)) ^ self.commitment_transaction_number_obscure_factor); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: consider: `0xffff_ffff_ffff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: operator precedence can trip the unwary [INFO] [stderr] --> src/ln/channelmonitor.rs:558:53 [INFO] [stderr] | [INFO] [stderr] 558 | let our_commitment_number = 0xffffffffffff - ((((local_tx.tx.input[0].sequence as u64 & 0xffffff) << 3*8) | (local_tx.tx.lock_time as u64 & 0xffffff)) ^ self.commitment_transaction_number_obscure_factor); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider parenthesizing your expression: `(local_tx.tx.input[0].sequence as u64 & 0xffffff) << (3*8)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ln/channelmonitor.rs:558:93 [INFO] [stderr] | [INFO] [stderr] 558 | let our_commitment_number = 0xffffffffffff - ((((local_tx.tx.input[0].sequence as u64 & 0xffffff) << 3*8) | (local_tx.tx.lock_time as u64 & 0xffffff)) ^ self.commitment_transaction_number_obscure_factor); [INFO] [stderr] | ^^^^^^^^ help: consider: `0x00ff_ffff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ln/channelmonitor.rs:558:145 [INFO] [stderr] | [INFO] [stderr] 558 | let our_commitment_number = 0xffffffffffff - ((((local_tx.tx.input[0].sequence as u64 & 0xffffff) << 3*8) | (local_tx.tx.lock_time as u64 & 0xffffff)) ^ self.commitment_transaction_number_obscure_factor); [INFO] [stderr] | ^^^^^^^^ help: consider: `0x00ff_ffff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ln/channelmonitor.rs:559:35 [INFO] [stderr] | [INFO] [stderr] 559 | let other_commitment_number = 0xffffffffffff - ((((other_local_tx.tx.input[0].sequence as u64 & 0xffffff) << 3*8) | (other_local_tx.tx.lock_time as u64 & 0xffffff)) ^ other.commitment_transaction_number_obscure_factor); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: consider: `0xffff_ffff_ffff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: operator precedence can trip the unwary [INFO] [stderr] --> src/ln/channelmonitor.rs:559:55 [INFO] [stderr] | [INFO] [stderr] 559 | let other_commitment_number = 0xffffffffffff - ((((other_local_tx.tx.input[0].sequence as u64 & 0xffffff) << 3*8) | (other_local_tx.tx.lock_time as u64 & 0xffffff)) ^ other.commitment_transaction_number_obscure_factor); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider parenthesizing your expression: `(other_local_tx.tx.input[0].sequence as u64 & 0xffffff) << (3*8)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ln/channelmonitor.rs:559:101 [INFO] [stderr] | [INFO] [stderr] 559 | let other_commitment_number = 0xffffffffffff - ((((other_local_tx.tx.input[0].sequence as u64 & 0xffffff) << 3*8) | (other_local_tx.tx.lock_time as u64 & 0xffffff)) ^ other.commitment_transaction_number_obscure_factor); [INFO] [stderr] | ^^^^^^^^ help: consider: `0x00ff_ffff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ln/channelmonitor.rs:559:159 [INFO] [stderr] | [INFO] [stderr] 559 | let other_commitment_number = 0xffffffffffff - ((((other_local_tx.tx.input[0].sequence as u64 & 0xffffff) << 3*8) | (other_local_tx.tx.lock_time as u64 & 0xffffff)) ^ other.commitment_transaction_number_obscure_factor); [INFO] [stderr] | ^^^^^^^^ help: consider: `0x00ff_ffff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: operator precedence can trip the unwary [INFO] [stderr] --> src/ln/channelmonitor.rs:861:26 [INFO] [stderr] | [INFO] [stderr] 861 | 0xffff_ffff_ffff - ((((local_tx.tx.input[0].sequence as u64 & 0xffffff) << 3*8) | (local_tx.tx.lock_time as u64 & 0xffffff)) ^ self.commitment_transaction_number_obscure_factor) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider parenthesizing your expression: `(local_tx.tx.input[0].sequence as u64 & 0xffffff) << (3*8)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ln/channelmonitor.rs:861:66 [INFO] [stderr] | [INFO] [stderr] 861 | 0xffff_ffff_ffff - ((((local_tx.tx.input[0].sequence as u64 & 0xffffff) << 3*8) | (local_tx.tx.lock_time as u64 & 0xffffff)) ^ self.commitment_transaction_number_obscure_factor) [INFO] [stderr] | ^^^^^^^^ help: consider: `0x00ff_ffff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ln/channelmonitor.rs:861:118 [INFO] [stderr] | [INFO] [stderr] 861 | 0xffff_ffff_ffff - ((((local_tx.tx.input[0].sequence as u64 & 0xffffff) << 3*8) | (local_tx.tx.lock_time as u64 & 0xffffff)) ^ self.commitment_transaction_number_obscure_factor) [INFO] [stderr] | ^^^^^^^^ help: consider: `0x00ff_ffff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ln/channelmonitor.rs:888:27 [INFO] [stderr] | [INFO] [stderr] 888 | let commitment_number = 0xffffffffffff - ((((tx.input[0].sequence as u64 & 0xffffff) << 3*8) | (tx.lock_time as u64 & 0xffffff)) ^ self.commitment_transaction_number_obscure_factor); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: consider: `0xffff_ffff_ffff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: operator precedence can trip the unwary [INFO] [stderr] --> src/ln/channelmonitor.rs:888:47 [INFO] [stderr] | [INFO] [stderr] 888 | let commitment_number = 0xffffffffffff - ((((tx.input[0].sequence as u64 & 0xffffff) << 3*8) | (tx.lock_time as u64 & 0xffffff)) ^ self.commitment_transaction_number_obscure_factor); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider parenthesizing your expression: `(tx.input[0].sequence as u64 & 0xffffff) << (3*8)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ln/channelmonitor.rs:888:78 [INFO] [stderr] | [INFO] [stderr] 888 | let commitment_number = 0xffffffffffff - ((((tx.input[0].sequence as u64 & 0xffffff) << 3*8) | (tx.lock_time as u64 & 0xffffff)) ^ self.commitment_transaction_number_obscure_factor); [INFO] [stderr] | ^^^^^^^^ help: consider: `0x00ff_ffff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ln/channelmonitor.rs:888:121 [INFO] [stderr] | [INFO] [stderr] 888 | let commitment_number = 0xffffffffffff - ((((tx.input[0].sequence as u64 & 0xffffff) << 3*8) | (tx.lock_time as u64 & 0xffffff)) ^ self.commitment_transaction_number_obscure_factor); [INFO] [stderr] | ^^^^^^^^ help: consider: `0x00ff_ffff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ln/channelmonitor.rs:935:17 [INFO] [stderr] | [INFO] [stderr] 935 | sequence: 0xfffffffd, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xffff_fffd` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ln/channelmonitor.rs:995:17 [INFO] [stderr] | [INFO] [stderr] 995 | sequence: 0xfffffffd, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xffff_fffd` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ln/channelmonitor.rs:1242:15 [INFO] [stderr] | [INFO] [stderr] 1242 | sequence: 0xfffffffd, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xffff_fffd` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/ln/channelmonitor.rs:1332:11 [INFO] [stderr] | [INFO] [stderr] 1332 | } else { [INFO] [stderr] | ____________________^ [INFO] [stderr] 1333 | | if let Some(payment_preimage) = self.payment_preimages.get(&htlc.payment_hash) { [INFO] [stderr] 1334 | | let mut htlc_success_tx = chan_utils::build_htlc_transaction(&local_tx.txid, local_tx.feerate_per_kw, self.their_to_self_delay.unwrap(), htlc, &local_tx.delayed_payment_key, &local_tx.revocation_key); [INFO] [stderr] 1335 | | [INFO] [stderr] ... | [INFO] [stderr] 1348 | | } [INFO] [stderr] 1349 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 1332 | } else if let Some(payment_preimage) = self.payment_preimages.get(&htlc.payment_hash) { [INFO] [stderr] 1333 | let mut htlc_success_tx = chan_utils::build_htlc_transaction(&local_tx.txid, local_tx.feerate_per_kw, self.their_to_self_delay.unwrap(), htlc, &local_tx.delayed_payment_key, &local_tx.revocation_key); [INFO] [stderr] 1334 | [INFO] [stderr] 1335 | htlc_success_tx.input[0].witness.push(Vec::new()); // First is the multisig dummy [INFO] [stderr] 1336 | [INFO] [stderr] 1337 | htlc_success_tx.input[0].witness.push(their_sig.serialize_der(&self.secp_ctx).to_vec()); [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ln/channelmonitor.rs:1389:30 [INFO] [stderr] | [INFO] [stderr] 1389 | if tx.input[0].sequence == 0xFFFFFFFF && tx.input[0].witness.last().unwrap().len() == 71 { [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xFFFF_FFFF` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/ln/channelmonitor.rs:1457:12 [INFO] [stderr] | [INFO] [stderr] 1457 | } else { [INFO] [stderr] | ________________________^ [INFO] [stderr] 1458 | | if let Some(&(commitment_number, _)) = self.remote_commitment_txn_on_chain.get(&prevout.txid) { [INFO] [stderr] 1459 | | let (tx, spendable_output) = self.check_spend_remote_htlc(tx, commitment_number); [INFO] [stderr] 1460 | | if let Some(tx) = tx { [INFO] [stderr] ... | [INFO] [stderr] 1466 | | } [INFO] [stderr] 1467 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 1457 | } else if let Some(&(commitment_number, _)) = self.remote_commitment_txn_on_chain.get(&prevout.txid) { [INFO] [stderr] 1458 | let (tx, spendable_output) = self.check_spend_remote_htlc(tx, commitment_number); [INFO] [stderr] 1459 | if let Some(tx) = tx { [INFO] [stderr] 1460 | txn.push(tx); [INFO] [stderr] 1461 | } [INFO] [stderr] 1462 | if let Some(spendable_output) = spendable_output { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/ln/msgs.rs:100:3 [INFO] [stderr] | [INFO] [stderr] 100 | return false; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `false` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/ln/msgs.rs:111:3 [INFO] [stderr] | [INFO] [stderr] 111 | return false; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `false` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/ln/msgs.rs:134:3 [INFO] [stderr] | [INFO] [stderr] 134 | return false; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `false` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/ln/msgs.rs:143:3 [INFO] [stderr] | [INFO] [stderr] 143 | return false; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `false` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/ln/router.rs:405:12 [INFO] [stderr] | [INFO] [stderr] 405 | } else { [INFO] [stderr] | ________________________^ [INFO] [stderr] 406 | | if let Some(chan) = network.channels.get_mut(short_channel_id) { [INFO] [stderr] 407 | | chan.one_to_two.enabled = false; [INFO] [stderr] 408 | | chan.two_to_one.enabled = false; [INFO] [stderr] 409 | | } [INFO] [stderr] 410 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 405 | } else if let Some(chan) = network.channels.get_mut(short_channel_id) { [INFO] [stderr] 406 | chan.one_to_two.enabled = false; [INFO] [stderr] 407 | chan.two_to_one.enabled = false; [INFO] [stderr] 408 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ln/router.rs:714:68 [INFO] [stderr] | [INFO] [stderr] 714 | ($directional_info.fee_base_msat as u64).checked_add(part / 1000000) }) [INFO] [stderr] | ^^^^^^^ help: consider: `1_000_000` [INFO] [stderr] ... [INFO] [stderr] 792 | add_entries_to_cheapest_to_target_node!(node, target, 0); [INFO] [stderr] | --------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ln/router.rs:735:32 [INFO] [stderr] | [INFO] [stderr] 735 | total_fee += fee_inc / 1000000 + (old_entry.1 as u64); [INFO] [stderr] | ^^^^^^^ help: consider: `1_000_000` [INFO] [stderr] ... [INFO] [stderr] 792 | add_entries_to_cheapest_to_target_node!(node, target, 0); [INFO] [stderr] | --------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ln/router.rs:714:68 [INFO] [stderr] | [INFO] [stderr] 714 | ($directional_info.fee_base_msat as u64).checked_add(part / 1000000) }) [INFO] [stderr] | ^^^^^^^ help: consider: `1_000_000` [INFO] [stderr] ... [INFO] [stderr] 792 | add_entries_to_cheapest_to_target_node!(node, target, 0); [INFO] [stderr] | --------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ln/router.rs:735:32 [INFO] [stderr] | [INFO] [stderr] 735 | total_fee += fee_inc / 1000000 + (old_entry.1 as u64); [INFO] [stderr] | ^^^^^^^ help: consider: `1_000_000` [INFO] [stderr] ... [INFO] [stderr] 792 | add_entries_to_cheapest_to_target_node!(node, target, 0); [INFO] [stderr] | --------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ln/router.rs:714:68 [INFO] [stderr] | [INFO] [stderr] 714 | ($directional_info.fee_base_msat as u64).checked_add(part / 1000000) }) [INFO] [stderr] | ^^^^^^^ help: consider: `1_000_000` [INFO] [stderr] ... [INFO] [stderr] 792 | add_entries_to_cheapest_to_target_node!(node, target, 0); [INFO] [stderr] | --------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ln/router.rs:735:32 [INFO] [stderr] | [INFO] [stderr] 735 | total_fee += fee_inc / 1000000 + (old_entry.1 as u64); [INFO] [stderr] | ^^^^^^^ help: consider: `1_000_000` [INFO] [stderr] ... [INFO] [stderr] 792 | add_entries_to_cheapest_to_target_node!(node, target, 0); [INFO] [stderr] | --------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ln/router.rs:714:68 [INFO] [stderr] | [INFO] [stderr] 714 | ($directional_info.fee_base_msat as u64).checked_add(part / 1000000) }) [INFO] [stderr] | ^^^^^^^ help: consider: `1_000_000` [INFO] [stderr] ... [INFO] [stderr] 801 | add_entry!(first_hop, hop.src_node_id, dummy_directional_info, 0); [INFO] [stderr] | ------------------------------------------------------------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ln/router.rs:735:32 [INFO] [stderr] | [INFO] [stderr] 735 | total_fee += fee_inc / 1000000 + (old_entry.1 as u64); [INFO] [stderr] | ^^^^^^^ help: consider: `1_000_000` [INFO] [stderr] ... [INFO] [stderr] 801 | add_entry!(first_hop, hop.src_node_id, dummy_directional_info, 0); [INFO] [stderr] | ------------------------------------------------------------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ln/router.rs:714:68 [INFO] [stderr] | [INFO] [stderr] 714 | ($directional_info.fee_base_msat as u64).checked_add(part / 1000000) }) [INFO] [stderr] | ^^^^^^^ help: consider: `1_000_000` [INFO] [stderr] ... [INFO] [stderr] 804 | add_entry!(hop.short_channel_id, target, hop, 0); [INFO] [stderr] | ------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ln/router.rs:735:32 [INFO] [stderr] | [INFO] [stderr] 735 | total_fee += fee_inc / 1000000 + (old_entry.1 as u64); [INFO] [stderr] | ^^^^^^^ help: consider: `1_000_000` [INFO] [stderr] ... [INFO] [stderr] 804 | add_entry!(hop.short_channel_id, target, hop, 0); [INFO] [stderr] | ------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ln/router.rs:714:68 [INFO] [stderr] | [INFO] [stderr] 714 | ($directional_info.fee_base_msat as u64).checked_add(part / 1000000) }) [INFO] [stderr] | ^^^^^^^ help: consider: `1_000_000` [INFO] [stderr] ... [INFO] [stderr] 831 | add_entries_to_cheapest_to_target_node!(node, &pubkey, lowest_fee_to_node); [INFO] [stderr] | --------------------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ln/router.rs:735:32 [INFO] [stderr] | [INFO] [stderr] 735 | total_fee += fee_inc / 1000000 + (old_entry.1 as u64); [INFO] [stderr] | ^^^^^^^ help: consider: `1_000_000` [INFO] [stderr] ... [INFO] [stderr] 831 | add_entries_to_cheapest_to_target_node!(node, &pubkey, lowest_fee_to_node); [INFO] [stderr] | --------------------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: immediately dereferencing a reference [INFO] [stderr] --> src/ln/router.rs:771:40 [INFO] [stderr] | [INFO] [stderr] 771 | if chan.one_to_two.src_node_id == *$node_id { [INFO] [stderr] | ^^^^^^^^^ help: try this: `pubkey` [INFO] [stderr] ... [INFO] [stderr] 831 | add_entries_to_cheapest_to_target_node!(node, &pubkey, lowest_fee_to_node); [INFO] [stderr] | --------------------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::deref_addrof)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deref_addrof [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ln/router.rs:714:68 [INFO] [stderr] | [INFO] [stderr] 714 | ($directional_info.fee_base_msat as u64).checked_add(part / 1000000) }) [INFO] [stderr] | ^^^^^^^ help: consider: `1_000_000` [INFO] [stderr] ... [INFO] [stderr] 831 | add_entries_to_cheapest_to_target_node!(node, &pubkey, lowest_fee_to_node); [INFO] [stderr] | --------------------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ln/router.rs:735:32 [INFO] [stderr] | [INFO] [stderr] 735 | total_fee += fee_inc / 1000000 + (old_entry.1 as u64); [INFO] [stderr] | ^^^^^^^ help: consider: `1_000_000` [INFO] [stderr] ... [INFO] [stderr] 831 | add_entries_to_cheapest_to_target_node!(node, &pubkey, lowest_fee_to_node); [INFO] [stderr] | --------------------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ln/router.rs:714:68 [INFO] [stderr] | [INFO] [stderr] 714 | ($directional_info.fee_base_msat as u64).checked_add(part / 1000000) }) [INFO] [stderr] | ^^^^^^^ help: consider: `1_000_000` [INFO] [stderr] ... [INFO] [stderr] 831 | add_entries_to_cheapest_to_target_node!(node, &pubkey, lowest_fee_to_node); [INFO] [stderr] | --------------------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ln/router.rs:735:32 [INFO] [stderr] | [INFO] [stderr] 735 | total_fee += fee_inc / 1000000 + (old_entry.1 as u64); [INFO] [stderr] | ^^^^^^^ help: consider: `1_000_000` [INFO] [stderr] ... [INFO] [stderr] 831 | add_entries_to_cheapest_to_target_node!(node, &pubkey, lowest_fee_to_node); [INFO] [stderr] | --------------------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/ln/peer_handler.rs:766:4 [INFO] [stderr] | [INFO] [stderr] 766 | pause_read [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/ln/peer_handler.rs:411:21 [INFO] [stderr] | [INFO] [stderr] 411 | let pause_read = match peers.peers.get_mut(peer_descriptor) { [INFO] [stderr] | ______________________________^ [INFO] [stderr] 412 | | None => panic!("Descriptor for read_event is not already known to PeerManager"), [INFO] [stderr] 413 | | Some(peer) => { [INFO] [stderr] 414 | | assert!(peer.pending_read_buffer.len() > 0); [INFO] [stderr] ... | [INFO] [stderr] 763 | | } [INFO] [stderr] 764 | | }; [INFO] [stderr] | |_____________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: All the struct fields are matched to a wildcard pattern, consider using `..`. [INFO] [stderr] --> src/ln/peer_handler.rs:446:14 [INFO] [stderr] | [INFO] [stderr] 446 | msgs::ErrorAction::DisconnectPeer { msg: _ } => { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 514 | let act_two = try_potential_handleerror!(peer.channel_encryptor.process_act_one_with_key(&peer.pending_read_buffer[..], &self.our_node_secret)).to_vec(); [INFO] [stderr] | --------------------------------------------------------------------------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unneeded_field_pattern)] on by default [INFO] [stderr] = help: Try with `DisconnectPeer { .. }` instead [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern [INFO] [stderr] [INFO] [stderr] warning: All the struct fields are matched to a wildcard pattern, consider using `..`. [INFO] [stderr] --> src/ln/peer_handler.rs:446:14 [INFO] [stderr] | [INFO] [stderr] 446 | msgs::ErrorAction::DisconnectPeer { msg: _ } => { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 519 | let (act_three, their_node_id) = try_potential_handleerror!(peer.channel_encryptor.process_act_two(&peer.pending_read_buffer[..], &self.our_node_secret)); [INFO] [stderr] | ------------------------------------------------------------------------------------------------------------------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: Try with `DisconnectPeer { .. }` instead [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern [INFO] [stderr] [INFO] [stderr] warning: All the struct fields are matched to a wildcard pattern, consider using `..`. [INFO] [stderr] --> src/ln/peer_handler.rs:446:14 [INFO] [stderr] | [INFO] [stderr] 446 | msgs::ErrorAction::DisconnectPeer { msg: _ } => { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 537 | let their_node_id = try_potential_handleerror!(peer.channel_encryptor.process_act_three(&peer.pending_read_buffer[..])); [INFO] [stderr] | --------------------------------------------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: Try with `DisconnectPeer { .. }` instead [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern [INFO] [stderr] [INFO] [stderr] warning: All the struct fields are matched to a wildcard pattern, consider using `..`. [INFO] [stderr] --> src/ln/peer_handler.rs:446:14 [INFO] [stderr] | [INFO] [stderr] 446 | msgs::ErrorAction::DisconnectPeer { msg: _ } => { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 545 | let msg_len = try_potential_handleerror!(peer.channel_encryptor.decrypt_length_header(&peer.pending_read_buffer[..])); [INFO] [stderr] | ------------------------------------------------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: Try with `DisconnectPeer { .. }` instead [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern [INFO] [stderr] [INFO] [stderr] warning: All the struct fields are matched to a wildcard pattern, consider using `..`. [INFO] [stderr] --> src/ln/peer_handler.rs:446:14 [INFO] [stderr] | [INFO] [stderr] 446 | msgs::ErrorAction::DisconnectPeer { msg: _ } => { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 553 | let msg_data = try_potential_handleerror!(peer.channel_encryptor.decrypt_message(&peer.pending_read_buffer[..])); [INFO] [stderr] | ------------------------------------------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: Try with `DisconnectPeer { .. }` instead [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern [INFO] [stderr] [INFO] [stderr] warning: All the struct fields are matched to a wildcard pattern, consider using `..`. [INFO] [stderr] --> src/ln/peer_handler.rs:446:14 [INFO] [stderr] | [INFO] [stderr] 446 | msgs::ErrorAction::DisconnectPeer { msg: _ } => { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 656 | try_potential_handleerror!(self.message_handler.chan_handler.handle_open_channel(&peer.their_node_id.unwrap(), &msg)); [INFO] [stderr] | ---------------------------------------------------------------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: Try with `DisconnectPeer { .. }` instead [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern [INFO] [stderr] [INFO] [stderr] warning: All the struct fields are matched to a wildcard pattern, consider using `..`. [INFO] [stderr] --> src/ln/peer_handler.rs:446:14 [INFO] [stderr] | [INFO] [stderr] 446 | msgs::ErrorAction::DisconnectPeer { msg: _ } => { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 660 | try_potential_handleerror!(self.message_handler.chan_handler.handle_accept_channel(&peer.their_node_id.unwrap(), &msg)); [INFO] [stderr] | ------------------------------------------------------------------------------------------------------------------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: Try with `DisconnectPeer { .. }` instead [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern [INFO] [stderr] [INFO] [stderr] warning: All the struct fields are matched to a wildcard pattern, consider using `..`. [INFO] [stderr] --> src/ln/peer_handler.rs:446:14 [INFO] [stderr] | [INFO] [stderr] 446 | msgs::ErrorAction::DisconnectPeer { msg: _ } => { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 665 | try_potential_handleerror!(self.message_handler.chan_handler.handle_funding_created(&peer.their_node_id.unwrap(), &msg)); [INFO] [stderr] | ------------------------------------------------------------------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: Try with `DisconnectPeer { .. }` instead [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern [INFO] [stderr] [INFO] [stderr] warning: All the struct fields are matched to a wildcard pattern, consider using `..`. [INFO] [stderr] --> src/ln/peer_handler.rs:446:14 [INFO] [stderr] | [INFO] [stderr] 446 | msgs::ErrorAction::DisconnectPeer { msg: _ } => { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 669 | try_potential_handleerror!(self.message_handler.chan_handler.handle_funding_signed(&peer.their_node_id.unwrap(), &msg)); [INFO] [stderr] | ------------------------------------------------------------------------------------------------------------------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: Try with `DisconnectPeer { .. }` instead [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern [INFO] [stderr] [INFO] [stderr] warning: All the struct fields are matched to a wildcard pattern, consider using `..`. [INFO] [stderr] --> src/ln/peer_handler.rs:446:14 [INFO] [stderr] | [INFO] [stderr] 446 | msgs::ErrorAction::DisconnectPeer { msg: _ } => { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 673 | try_potential_handleerror!(self.message_handler.chan_handler.handle_funding_locked(&peer.their_node_id.unwrap(), &msg)); [INFO] [stderr] | ------------------------------------------------------------------------------------------------------------------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: Try with `DisconnectPeer { .. }` instead [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern [INFO] [stderr] [INFO] [stderr] warning: All the struct fields are matched to a wildcard pattern, consider using `..`. [INFO] [stderr] --> src/ln/peer_handler.rs:446:14 [INFO] [stderr] | [INFO] [stderr] 446 | msgs::ErrorAction::DisconnectPeer { msg: _ } => { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 678 | try_potential_handleerror!(self.message_handler.chan_handler.handle_shutdown(&peer.their_node_id.unwrap(), &msg)); [INFO] [stderr] | ------------------------------------------------------------------------------------------------------------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: Try with `DisconnectPeer { .. }` instead [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern [INFO] [stderr] [INFO] [stderr] warning: All the struct fields are matched to a wildcard pattern, consider using `..`. [INFO] [stderr] --> src/ln/peer_handler.rs:446:14 [INFO] [stderr] | [INFO] [stderr] 446 | msgs::ErrorAction::DisconnectPeer { msg: _ } => { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 682 | try_potential_handleerror!(self.message_handler.chan_handler.handle_closing_signed(&peer.their_node_id.unwrap(), &msg)); [INFO] [stderr] | ------------------------------------------------------------------------------------------------------------------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: Try with `DisconnectPeer { .. }` instead [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern [INFO] [stderr] [INFO] [stderr] warning: All the struct fields are matched to a wildcard pattern, consider using `..`. [INFO] [stderr] --> src/ln/peer_handler.rs:446:14 [INFO] [stderr] | [INFO] [stderr] 446 | msgs::ErrorAction::DisconnectPeer { msg: _ } => { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 687 | try_potential_handleerror!(self.message_handler.chan_handler.handle_update_add_htlc(&peer.their_node_id.unwrap(), &msg)); [INFO] [stderr] | ------------------------------------------------------------------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: Try with `DisconnectPeer { .. }` instead [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern [INFO] [stderr] [INFO] [stderr] warning: All the struct fields are matched to a wildcard pattern, consider using `..`. [INFO] [stderr] --> src/ln/peer_handler.rs:446:14 [INFO] [stderr] | [INFO] [stderr] 446 | msgs::ErrorAction::DisconnectPeer { msg: _ } => { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 691 | try_potential_handleerror!(self.message_handler.chan_handler.handle_update_fulfill_htlc(&peer.their_node_id.unwrap(), &msg)); [INFO] [stderr] | ----------------------------------------------------------------------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: Try with `DisconnectPeer { .. }` instead [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern [INFO] [stderr] [INFO] [stderr] warning: All the struct fields are matched to a wildcard pattern, consider using `..`. [INFO] [stderr] --> src/ln/peer_handler.rs:446:14 [INFO] [stderr] | [INFO] [stderr] 446 | msgs::ErrorAction::DisconnectPeer { msg: _ } => { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 695 | try_potential_handleerror!(self.message_handler.chan_handler.handle_update_fail_htlc(&peer.their_node_id.unwrap(), &msg)); [INFO] [stderr] | -------------------------------------------------------------------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: Try with `DisconnectPeer { .. }` instead [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern [INFO] [stderr] [INFO] [stderr] warning: All the struct fields are matched to a wildcard pattern, consider using `..`. [INFO] [stderr] --> src/ln/peer_handler.rs:446:14 [INFO] [stderr] | [INFO] [stderr] 446 | msgs::ErrorAction::DisconnectPeer { msg: _ } => { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 699 | try_potential_handleerror!(self.message_handler.chan_handler.handle_update_fail_malformed_htlc(&peer.their_node_id.unwrap(), &msg)); [INFO] [stderr] | ------------------------------------------------------------------------------------------------------------------------------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: Try with `DisconnectPeer { .. }` instead [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern [INFO] [stderr] [INFO] [stderr] warning: All the struct fields are matched to a wildcard pattern, consider using `..`. [INFO] [stderr] --> src/ln/peer_handler.rs:446:14 [INFO] [stderr] | [INFO] [stderr] 446 | msgs::ErrorAction::DisconnectPeer { msg: _ } => { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 704 | try_potential_handleerror!(self.message_handler.chan_handler.handle_commitment_signed(&peer.their_node_id.unwrap(), &msg)); [INFO] [stderr] | --------------------------------------------------------------------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: Try with `DisconnectPeer { .. }` instead [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern [INFO] [stderr] [INFO] [stderr] warning: All the struct fields are matched to a wildcard pattern, consider using `..`. [INFO] [stderr] --> src/ln/peer_handler.rs:446:14 [INFO] [stderr] | [INFO] [stderr] 446 | msgs::ErrorAction::DisconnectPeer { msg: _ } => { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 708 | try_potential_handleerror!(self.message_handler.chan_handler.handle_revoke_and_ack(&peer.their_node_id.unwrap(), &msg)); [INFO] [stderr] | ------------------------------------------------------------------------------------------------------------------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: Try with `DisconnectPeer { .. }` instead [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern [INFO] [stderr] [INFO] [stderr] warning: All the struct fields are matched to a wildcard pattern, consider using `..`. [INFO] [stderr] --> src/ln/peer_handler.rs:446:14 [INFO] [stderr] | [INFO] [stderr] 446 | msgs::ErrorAction::DisconnectPeer { msg: _ } => { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 712 | try_potential_handleerror!(self.message_handler.chan_handler.handle_update_fee(&peer.their_node_id.unwrap(), &msg)); [INFO] [stderr] | -------------------------------------------------------------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: Try with `DisconnectPeer { .. }` instead [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern [INFO] [stderr] [INFO] [stderr] warning: All the struct fields are matched to a wildcard pattern, consider using `..`. [INFO] [stderr] --> src/ln/peer_handler.rs:446:14 [INFO] [stderr] | [INFO] [stderr] 446 | msgs::ErrorAction::DisconnectPeer { msg: _ } => { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 716 | try_potential_handleerror!(self.message_handler.chan_handler.handle_channel_reestablish(&peer.their_node_id.unwrap(), &msg)); [INFO] [stderr] | ----------------------------------------------------------------------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: Try with `DisconnectPeer { .. }` instead [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern [INFO] [stderr] [INFO] [stderr] warning: All the struct fields are matched to a wildcard pattern, consider using `..`. [INFO] [stderr] --> src/ln/peer_handler.rs:446:14 [INFO] [stderr] | [INFO] [stderr] 446 | msgs::ErrorAction::DisconnectPeer { msg: _ } => { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 722 | try_potential_handleerror!(self.message_handler.chan_handler.handle_announcement_signatures(&peer.their_node_id.unwrap(), &msg)); [INFO] [stderr] | --------------------------------------------------------------------------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: Try with `DisconnectPeer { .. }` instead [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern [INFO] [stderr] [INFO] [stderr] warning: All the struct fields are matched to a wildcard pattern, consider using `..`. [INFO] [stderr] --> src/ln/peer_handler.rs:446:14 [INFO] [stderr] | [INFO] [stderr] 446 | msgs::ErrorAction::DisconnectPeer { msg: _ } => { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 726 | let should_forward = try_potential_handleerror!(self.message_handler.route_handler.handle_channel_announcement(&msg)); [INFO] [stderr] | ------------------------------------------------------------------------------------------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: Try with `DisconnectPeer { .. }` instead [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern [INFO] [stderr] [INFO] [stderr] warning: All the struct fields are matched to a wildcard pattern, consider using `..`. [INFO] [stderr] --> src/ln/peer_handler.rs:446:14 [INFO] [stderr] | [INFO] [stderr] 446 | msgs::ErrorAction::DisconnectPeer { msg: _ } => { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 734 | let should_forward = try_potential_handleerror!(self.message_handler.route_handler.handle_node_announcement(&msg)); [INFO] [stderr] | --------------------------------------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: Try with `DisconnectPeer { .. }` instead [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern [INFO] [stderr] [INFO] [stderr] warning: All the struct fields are matched to a wildcard pattern, consider using `..`. [INFO] [stderr] --> src/ln/peer_handler.rs:446:14 [INFO] [stderr] | [INFO] [stderr] 446 | msgs::ErrorAction::DisconnectPeer { msg: _ } => { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 742 | let should_forward = try_potential_handleerror!(self.message_handler.route_handler.handle_channel_update(&msg)); [INFO] [stderr] | ------------------------------------------------------------------------------------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: Try with `DisconnectPeer { .. }` instead [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern [INFO] [stderr] [INFO] [stderr] warning: You matched a field with a wildcard pattern. Consider using `..` instead [INFO] [stderr] --> src/ln/peer_channel_encryptor.rs:348:40 [INFO] [stderr] | [INFO] [stderr] 348 | &DirectionalNoiseState::Inbound { ie: _, ref re, ref temp_k2 } => { [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Try with `Inbound { ref re, ref temp_k2, .. }` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern [INFO] [stderr] [INFO] [stderr] warning: You matched a field with a wildcard pattern. Consider using `..` instead [INFO] [stderr] --> src/ln/peer_channel_encryptor.rs:411:64 [INFO] [stderr] | [INFO] [stderr] 411 | NoiseState::Finished { ref mut sk, ref mut sn, ref mut sck, rk: _, rn: _, rck: _ } => { [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern [INFO] [stderr] [INFO] [stderr] warning: You matched a field with a wildcard pattern. Consider using `..` instead [INFO] [stderr] --> src/ln/peer_channel_encryptor.rs:411:71 [INFO] [stderr] | [INFO] [stderr] 411 | NoiseState::Finished { ref mut sk, ref mut sn, ref mut sck, rk: _, rn: _, rck: _ } => { [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern [INFO] [stderr] [INFO] [stderr] warning: You matched a field with a wildcard pattern. Consider using `..` instead [INFO] [stderr] --> src/ln/peer_channel_encryptor.rs:411:78 [INFO] [stderr] | [INFO] [stderr] 411 | NoiseState::Finished { ref mut sk, ref mut sn, ref mut sck, rk: _, rn: _, rck: _ } => { [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Try with `Finished { ref mut sk, ref mut sn, ref mut sck, .. }` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern [INFO] [stderr] [INFO] [stderr] warning: You matched a field with a wildcard pattern. Consider using `..` instead [INFO] [stderr] --> src/ln/peer_channel_encryptor.rs:441:27 [INFO] [stderr] | [INFO] [stderr] 441 | NoiseState::Finished { sk: _, sn: _, sck: _, ref mut rk, ref mut rn, ref mut rck } => { [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern [INFO] [stderr] [INFO] [stderr] warning: You matched a field with a wildcard pattern. Consider using `..` instead [INFO] [stderr] --> src/ln/peer_channel_encryptor.rs:441:34 [INFO] [stderr] | [INFO] [stderr] 441 | NoiseState::Finished { sk: _, sn: _, sck: _, ref mut rk, ref mut rn, ref mut rck } => { [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern [INFO] [stderr] [INFO] [stderr] warning: You matched a field with a wildcard pattern. Consider using `..` instead [INFO] [stderr] --> src/ln/peer_channel_encryptor.rs:441:41 [INFO] [stderr] | [INFO] [stderr] 441 | NoiseState::Finished { sk: _, sn: _, sck: _, ref mut rk, ref mut rn, ref mut rck } => { [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Try with `Finished { ref mut rk, ref mut rn, ref mut rck, .. }` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern [INFO] [stderr] [INFO] [stderr] warning: You matched a field with a wildcard pattern. Consider using `..` instead [INFO] [stderr] --> src/ln/peer_channel_encryptor.rs:470:27 [INFO] [stderr] | [INFO] [stderr] 470 | NoiseState::Finished { sk: _, sn: _, sck: _, ref rk, ref mut rn, rck: _ } => { [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern [INFO] [stderr] [INFO] [stderr] warning: You matched a field with a wildcard pattern. Consider using `..` instead [INFO] [stderr] --> src/ln/peer_channel_encryptor.rs:470:34 [INFO] [stderr] | [INFO] [stderr] 470 | NoiseState::Finished { sk: _, sn: _, sck: _, ref rk, ref mut rn, rck: _ } => { [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern [INFO] [stderr] [INFO] [stderr] warning: You matched a field with a wildcard pattern. Consider using `..` instead [INFO] [stderr] --> src/ln/peer_channel_encryptor.rs:470:41 [INFO] [stderr] | [INFO] [stderr] 470 | NoiseState::Finished { sk: _, sn: _, sck: _, ref rk, ref mut rn, rck: _ } => { [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern [INFO] [stderr] [INFO] [stderr] warning: You matched a field with a wildcard pattern. Consider using `..` instead [INFO] [stderr] --> src/ln/peer_channel_encryptor.rs:470:69 [INFO] [stderr] | [INFO] [stderr] 470 | NoiseState::Finished { sk: _, sn: _, sck: _, ref rk, ref mut rn, rck: _ } => { [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Try with `Finished { ref rk, ref mut rn, .. }` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/ln/channel.rs:596:3 [INFO] [stderr] | [INFO] [stderr] 596 | if config.channel_limits.force_announced_channel_preference { [INFO] [stderr] | _________^ [INFO] [stderr] 597 | | if local_config.announced_channel != their_announce { [INFO] [stderr] 598 | | return Err(ChannelError::Close("Peer tried to open channel but their announcement preference is different from ours")); [INFO] [stderr] 599 | | } [INFO] [stderr] 600 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 596 | if config.channel_limits.force_announced_channel_preference && local_config.announced_channel != their_announce { [INFO] [stderr] 597 | return Err(ChannelError::Close("Peer tried to open channel but their announcement preference is different from ours")); [INFO] [stderr] 598 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: operator precedence can trip the unwary [INFO] [stderr] --> src/ln/channel.rs:741:4 [INFO] [stderr] | [INFO] [stderr] 741 | ((res[26] as u64) << 5*8) | [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: consider parenthesizing your expression: `(res[26] as u64) << (5*8)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence [INFO] [stderr] [INFO] [stderr] warning: operator precedence can trip the unwary [INFO] [stderr] --> src/ln/channel.rs:742:4 [INFO] [stderr] | [INFO] [stderr] 742 | ((res[27] as u64) << 4*8) | [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: consider parenthesizing your expression: `(res[27] as u64) << (4*8)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence [INFO] [stderr] [INFO] [stderr] warning: operator precedence can trip the unwary [INFO] [stderr] --> src/ln/channel.rs:743:4 [INFO] [stderr] | [INFO] [stderr] 743 | ((res[28] as u64) << 3*8) | [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: consider parenthesizing your expression: `(res[28] as u64) << (3*8)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence [INFO] [stderr] [INFO] [stderr] warning: operator precedence can trip the unwary [INFO] [stderr] --> src/ln/channel.rs:744:4 [INFO] [stderr] | [INFO] [stderr] 744 | ((res[29] as u64) << 2*8) | [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: consider parenthesizing your expression: `(res[29] as u64) << (2*8)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence [INFO] [stderr] [INFO] [stderr] warning: operator precedence can trip the unwary [INFO] [stderr] --> src/ln/channel.rs:745:4 [INFO] [stderr] | [INFO] [stderr] 745 | ((res[30] as u64) << 1*8) | [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: consider parenthesizing your expression: `(res[30] as u64) << (1*8)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence [INFO] [stderr] [INFO] [stderr] warning: operator precedence can trip the unwary [INFO] [stderr] --> src/ln/channel.rs:746:4 [INFO] [stderr] | [INFO] [stderr] 746 | ((res[31] as u64) << 0*8) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: consider parenthesizing your expression: `(res[31] as u64) << (0*8)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence [INFO] [stderr] [INFO] [stderr] warning: operator precedence can trip the unwary [INFO] [stderr] --> src/ln/channel.rs:771:16 [INFO] [stderr] | [INFO] [stderr] 771 | sequence: ((0x80 as u32) << 8*3) | ((obscured_commitment_transaction_number >> 3*8) as u32), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: consider parenthesizing your expression: `(0x80 as u32) << (8*3)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence [INFO] [stderr] [INFO] [stderr] warning: operator precedence can trip the unwary [INFO] [stderr] --> src/ln/channel.rs:771:42 [INFO] [stderr] | [INFO] [stderr] 771 | sequence: ((0x80 as u32) << 8*3) | ((obscured_commitment_transaction_number >> 3*8) as u32), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider parenthesizing your expression: `obscured_commitment_transaction_number >> (3*8)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence [INFO] [stderr] [INFO] [stderr] warning: operator precedence can trip the unwary [INFO] [stderr] --> src/ln/channel.rs:924:16 [INFO] [stderr] | [INFO] [stderr] 924 | lock_time: ((0x20 as u32) << 8*3) | ((obscured_commitment_transaction_number & 0xffffffu64) as u32), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: consider parenthesizing your expression: `(0x20 as u32) << (8*3)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ln/channel.rs:924:83 [INFO] [stderr] | [INFO] [stderr] 924 | lock_time: ((0x20 as u32) << 8*3) | ((obscured_commitment_transaction_number & 0xffffffu64) as u32), [INFO] [stderr] | ^^^^^^^^^^^ help: consider: `0x00ff_ffffu64` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ln/channel.rs:948:15 [INFO] [stderr] | [INFO] [stderr] 948 | sequence: 0xffffffff, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xffff_ffff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ln/channel.rs:1308:32 [INFO] [stderr] | [INFO] [stderr] 1308 | if msg.dust_limit_satoshis > 21000000 * 100000000 { [INFO] [stderr] | ^^^^^^^^ help: consider: `21_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ln/channel.rs:1308:43 [INFO] [stderr] | [INFO] [stderr] 1308 | if msg.dust_limit_satoshis > 21000000 * 100000000 { [INFO] [stderr] | ^^^^^^^^^ help: consider: `100_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ln/channel.rs:1563:25 [INFO] [stderr] | [INFO] [stderr] 1563 | if msg.cltv_expiry >= 500000000 { [INFO] [stderr] | ^^^^^^^^^ help: consider: `500_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/ln/channel.rs:1993:10 [INFO] [stderr] | [INFO] [stderr] 1993 | } else { [INFO] [stderr] | ________________^ [INFO] [stderr] 1994 | | if let Some(feerate) = self.pending_update_fee { [INFO] [stderr] 1995 | | // Because a node cannot send two commitment_signed's in a row without getting a [INFO] [stderr] 1996 | | // revoke_and_ack from us (as it would otherwise not know the per_commitment_point [INFO] [stderr] ... | [INFO] [stderr] 2004 | | } [INFO] [stderr] 2005 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 1993 | } else if let Some(feerate) = self.pending_update_fee { [INFO] [stderr] 1994 | // Because a node cannot send two commitment_signed's in a row without getting a [INFO] [stderr] 1995 | // revoke_and_ack from us (as it would otherwise not know the per_commitment_point [INFO] [stderr] 1996 | // it should use to create keys with) and because a node can't send a [INFO] [stderr] 1997 | // commitment_signed without changes, checking if the feerate is equal to the [INFO] [stderr] 1998 | // pending feerate update is sufficient to detect require_commitment. [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/ln/channel.rs:2382:39 [INFO] [stderr] | [INFO] [stderr] 2382 | Err(ChannelError::Close(msg)) => return Err(ChannelError::Close(msg)), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(ChannelError::Close(msg))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/ln/channel.rs:2384:56 [INFO] [stderr] | [INFO] [stderr] 2384 | Ok(Some((commitment_update, channel_monitor))) => return Ok((resend_funding_locked, required_revoke, Some(commitment_update), Some(channel_monitor), order, shutdown_msg)), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok((resend_funding_locked, required_revoke, Some(commitment_update), Some(channel_monitor), order, shutdown_msg))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/ln/channel.rs:2385:18 [INFO] [stderr] | [INFO] [stderr] 2385 | Ok(None) => return Ok((resend_funding_locked, required_revoke, None, None, order, shutdown_msg)), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok((resend_funding_locked, required_revoke, None, None, order, shutdown_msg))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/ln/channel.rs:2388:5 [INFO] [stderr] | [INFO] [stderr] 2388 | return Ok((resend_funding_locked, required_revoke, None, None, order, shutdown_msg)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok((resend_funding_locked, required_revoke, None, None, order, shutdown_msg))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/ln/channel.rs:2405:4 [INFO] [stderr] | [INFO] [stderr] 2405 | return Ok((resend_funding_locked, required_revoke, Some(self.get_last_commitment_update()), None, order, shutdown_msg)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok((resend_funding_locked, required_revoke, Some(self.get_last_commitment_update()), None, order, shutdown_msg))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/ln/channel.rs:2407:4 [INFO] [stderr] | [INFO] [stderr] 2407 | return Err(ChannelError::Close("Peer attempted to reestablish channel with a very old remote commitment transaction")); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(ChannelError::Close("Peer attempted to reestablish channel with a very old remote commitment transaction"))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ln/channel.rs:2521:25 [INFO] [stderr] | [INFO] [stderr] 2521 | if msg.fee_satoshis > 21000000 * 10000000 { //this is required to stop potential overflow in build_closing_transaction [INFO] [stderr] | ^^^^^^^^ help: consider: `21_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ln/channel.rs:2521:36 [INFO] [stderr] | [INFO] [stderr] 2521 | if msg.fee_satoshis > 21000000 * 10000000 { //this is required to stop potential overflow in build_closing_transaction [INFO] [stderr] | ^^^^^^^^ help: consider: `10_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: You matched a field with a wildcard pattern. Consider using `..` instead [INFO] [stderr] --> src/ln/channel.rs:3490:129 [INFO] [stderr] | [INFO] [stderr] 3490 | &HTLCUpdateAwaitingACK::AddHTLC { ref amount_msat, ref cltv_expiry, ref payment_hash, ref source, ref onion_routing_packet, time_created: _ } => { [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Try with `AddHTLC { ref amount_msat, ref cltv_expiry, ref payment_hash, ref source, ref onion_routing_packet, .. }` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/util/ser.rs:338:14 [INFO] [stderr] | [INFO] [stderr] 338 | Err(_) => return Err(DecodeError::InvalidValue), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(DecodeError::InvalidValue)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/util/ser.rs:356:14 [INFO] [stderr] | [INFO] [stderr] 356 | Err(_) => return Err(DecodeError::InvalidValue), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(DecodeError::InvalidValue)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/util/ser.rs:385:14 [INFO] [stderr] | [INFO] [stderr] 385 | Err(_) => return Err(DecodeError::InvalidValue), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(DecodeError::InvalidValue)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: operator precedence can trip the unwary [INFO] [stderr] --> src/util/byte_utils.rs:3:3 [INFO] [stderr] | [INFO] [stderr] 3 | ((v[0] as u16) << 8*1) | [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: consider parenthesizing your expression: `(v[0] as u16) << (8*1)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::precedence)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence [INFO] [stderr] [INFO] [stderr] warning: operator precedence can trip the unwary [INFO] [stderr] --> src/util/byte_utils.rs:4:3 [INFO] [stderr] | [INFO] [stderr] 4 | ((v[1] as u16) << 8*0) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: consider parenthesizing your expression: `(v[1] as u16) << (8*0)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence [INFO] [stderr] [INFO] [stderr] warning: operator precedence can trip the unwary [INFO] [stderr] --> src/util/byte_utils.rs:8:3 [INFO] [stderr] | [INFO] [stderr] 8 | ((v[0] as u32) << 8*3) | [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: consider parenthesizing your expression: `(v[0] as u32) << (8*3)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence [INFO] [stderr] [INFO] [stderr] warning: operator precedence can trip the unwary [INFO] [stderr] --> src/util/byte_utils.rs:9:3 [INFO] [stderr] | [INFO] [stderr] 9 | ((v[1] as u32) << 8*2) | [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: consider parenthesizing your expression: `(v[1] as u32) << (8*2)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence [INFO] [stderr] [INFO] [stderr] warning: operator precedence can trip the unwary [INFO] [stderr] --> src/util/byte_utils.rs:10:3 [INFO] [stderr] | [INFO] [stderr] 10 | ((v[2] as u32) << 8*1) | [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: consider parenthesizing your expression: `(v[2] as u32) << (8*1)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence [INFO] [stderr] [INFO] [stderr] warning: operator precedence can trip the unwary [INFO] [stderr] --> src/util/byte_utils.rs:11:3 [INFO] [stderr] | [INFO] [stderr] 11 | ((v[3] as u32) << 8*0) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: consider parenthesizing your expression: `(v[3] as u32) << (8*0)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence [INFO] [stderr] [INFO] [stderr] warning: operator precedence can trip the unwary [INFO] [stderr] --> src/util/byte_utils.rs:15:3 [INFO] [stderr] | [INFO] [stderr] 15 | ((v[0] as u64) << 8*5) | [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: consider parenthesizing your expression: `(v[0] as u64) << (8*5)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence [INFO] [stderr] [INFO] [stderr] warning: operator precedence can trip the unwary [INFO] [stderr] --> src/util/byte_utils.rs:16:3 [INFO] [stderr] | [INFO] [stderr] 16 | ((v[1] as u64) << 8*4) | [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: consider parenthesizing your expression: `(v[1] as u64) << (8*4)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence [INFO] [stderr] [INFO] [stderr] warning: operator precedence can trip the unwary [INFO] [stderr] --> src/util/byte_utils.rs:17:3 [INFO] [stderr] | [INFO] [stderr] 17 | ((v[2] as u64) << 8*3) | [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: consider parenthesizing your expression: `(v[2] as u64) << (8*3)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence [INFO] [stderr] [INFO] [stderr] warning: operator precedence can trip the unwary [INFO] [stderr] --> src/util/byte_utils.rs:18:3 [INFO] [stderr] | [INFO] [stderr] 18 | ((v[3] as u64) << 8*2) | [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: consider parenthesizing your expression: `(v[3] as u64) << (8*2)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence [INFO] [stderr] [INFO] [stderr] warning: operator precedence can trip the unwary [INFO] [stderr] --> src/util/byte_utils.rs:19:3 [INFO] [stderr] | [INFO] [stderr] 19 | ((v[4] as u64) << 8*1) | [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: consider parenthesizing your expression: `(v[4] as u64) << (8*1)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence [INFO] [stderr] [INFO] [stderr] warning: operator precedence can trip the unwary [INFO] [stderr] --> src/util/byte_utils.rs:20:3 [INFO] [stderr] | [INFO] [stderr] 20 | ((v[5] as u64) << 8*0) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: consider parenthesizing your expression: `(v[5] as u64) << (8*0)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence [INFO] [stderr] [INFO] [stderr] warning: operator precedence can trip the unwary [INFO] [stderr] --> src/util/byte_utils.rs:24:3 [INFO] [stderr] | [INFO] [stderr] 24 | ((v[0] as u64) << 8*7) | [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: consider parenthesizing your expression: `(v[0] as u64) << (8*7)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence [INFO] [stderr] [INFO] [stderr] warning: operator precedence can trip the unwary [INFO] [stderr] --> src/util/byte_utils.rs:25:3 [INFO] [stderr] | [INFO] [stderr] 25 | ((v[1] as u64) << 8*6) | [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: consider parenthesizing your expression: `(v[1] as u64) << (8*6)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence [INFO] [stderr] [INFO] [stderr] warning: operator precedence can trip the unwary [INFO] [stderr] --> src/util/byte_utils.rs:26:3 [INFO] [stderr] | [INFO] [stderr] 26 | ((v[2] as u64) << 8*5) | [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: consider parenthesizing your expression: `(v[2] as u64) << (8*5)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence [INFO] [stderr] [INFO] [stderr] warning: operator precedence can trip the unwary [INFO] [stderr] --> src/util/byte_utils.rs:27:3 [INFO] [stderr] | [INFO] [stderr] 27 | ((v[3] as u64) << 8*4) | [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: consider parenthesizing your expression: `(v[3] as u64) << (8*4)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence [INFO] [stderr] [INFO] [stderr] warning: operator precedence can trip the unwary [INFO] [stderr] --> src/util/byte_utils.rs:28:3 [INFO] [stderr] | [INFO] [stderr] 28 | ((v[4] as u64) << 8*3) | [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: consider parenthesizing your expression: `(v[4] as u64) << (8*3)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence [INFO] [stderr] [INFO] [stderr] warning: operator precedence can trip the unwary [INFO] [stderr] --> src/util/byte_utils.rs:29:3 [INFO] [stderr] | [INFO] [stderr] 29 | ((v[5] as u64) << 8*2) | [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: consider parenthesizing your expression: `(v[5] as u64) << (8*2)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence [INFO] [stderr] [INFO] [stderr] warning: operator precedence can trip the unwary [INFO] [stderr] --> src/util/byte_utils.rs:30:3 [INFO] [stderr] | [INFO] [stderr] 30 | ((v[6] as u64) << 8*1) | [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: consider parenthesizing your expression: `(v[6] as u64) << (8*1)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence [INFO] [stderr] [INFO] [stderr] warning: operator precedence can trip the unwary [INFO] [stderr] --> src/util/byte_utils.rs:31:3 [INFO] [stderr] | [INFO] [stderr] 31 | ((v[7] as u64) << 8*0) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: consider parenthesizing your expression: `(v[7] as u64) << (8*0)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence [INFO] [stderr] [INFO] [stderr] warning: operator precedence can trip the unwary [INFO] [stderr] --> src/util/byte_utils.rs:37:11 [INFO] [stderr] | [INFO] [stderr] 37 | v[0] = ((u >> 8*1) & 0xff) as u8; [INFO] [stderr] | ^^^^^^^^ help: consider parenthesizing your expression: `u >> (8*1)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence [INFO] [stderr] [INFO] [stderr] warning: operator precedence can trip the unwary [INFO] [stderr] --> src/util/byte_utils.rs:38:11 [INFO] [stderr] | [INFO] [stderr] 38 | v[1] = ((u >> 8*0) & 0xff) as u8; [INFO] [stderr] | ^^^^^^^^ help: consider parenthesizing your expression: `u >> (8*0)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence [INFO] [stderr] [INFO] [stderr] warning: operator precedence can trip the unwary [INFO] [stderr] --> src/util/byte_utils.rs:44:11 [INFO] [stderr] | [INFO] [stderr] 44 | v[0] = ((u >> 8*3) & 0xff) as u8; [INFO] [stderr] | ^^^^^^^^ help: consider parenthesizing your expression: `u >> (8*3)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence [INFO] [stderr] [INFO] [stderr] warning: operator precedence can trip the unwary [INFO] [stderr] --> src/util/byte_utils.rs:45:11 [INFO] [stderr] | [INFO] [stderr] 45 | v[1] = ((u >> 8*2) & 0xff) as u8; [INFO] [stderr] | ^^^^^^^^ help: consider parenthesizing your expression: `u >> (8*2)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence [INFO] [stderr] [INFO] [stderr] warning: operator precedence can trip the unwary [INFO] [stderr] --> src/util/byte_utils.rs:46:11 [INFO] [stderr] | [INFO] [stderr] 46 | v[2] = ((u >> 8*1) & 0xff) as u8; [INFO] [stderr] | ^^^^^^^^ help: consider parenthesizing your expression: `u >> (8*1)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence [INFO] [stderr] [INFO] [stderr] warning: operator precedence can trip the unwary [INFO] [stderr] --> src/util/byte_utils.rs:47:11 [INFO] [stderr] | [INFO] [stderr] 47 | v[3] = ((u >> 8*0) & 0xff) as u8; [INFO] [stderr] | ^^^^^^^^ help: consider parenthesizing your expression: `u >> (8*0)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence [INFO] [stderr] [INFO] [stderr] warning: operator precedence can trip the unwary [INFO] [stderr] --> src/util/byte_utils.rs:54:11 [INFO] [stderr] | [INFO] [stderr] 54 | v[0] = ((u >> 8*5) & 0xff) as u8; [INFO] [stderr] | ^^^^^^^^ help: consider parenthesizing your expression: `u >> (8*5)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence [INFO] [stderr] [INFO] [stderr] warning: operator precedence can trip the unwary [INFO] [stderr] --> src/util/byte_utils.rs:55:11 [INFO] [stderr] | [INFO] [stderr] 55 | v[1] = ((u >> 8*4) & 0xff) as u8; [INFO] [stderr] | ^^^^^^^^ help: consider parenthesizing your expression: `u >> (8*4)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence [INFO] [stderr] [INFO] [stderr] warning: operator precedence can trip the unwary [INFO] [stderr] --> src/util/byte_utils.rs:56:11 [INFO] [stderr] | [INFO] [stderr] 56 | v[2] = ((u >> 8*3) & 0xff) as u8; [INFO] [stderr] | ^^^^^^^^ help: consider parenthesizing your expression: `u >> (8*3)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence [INFO] [stderr] [INFO] [stderr] warning: operator precedence can trip the unwary [INFO] [stderr] --> src/util/byte_utils.rs:57:11 [INFO] [stderr] | [INFO] [stderr] 57 | v[3] = ((u >> 8*2) & 0xff) as u8; [INFO] [stderr] | ^^^^^^^^ help: consider parenthesizing your expression: `u >> (8*2)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence [INFO] [stderr] [INFO] [stderr] warning: operator precedence can trip the unwary [INFO] [stderr] --> src/util/byte_utils.rs:58:11 [INFO] [stderr] | [INFO] [stderr] 58 | v[4] = ((u >> 8*1) & 0xff) as u8; [INFO] [stderr] | ^^^^^^^^ help: consider parenthesizing your expression: `u >> (8*1)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence [INFO] [stderr] [INFO] [stderr] warning: operator precedence can trip the unwary [INFO] [stderr] --> src/util/byte_utils.rs:59:11 [INFO] [stderr] | [INFO] [stderr] 59 | v[5] = ((u >> 8*0) & 0xff) as u8; [INFO] [stderr] | ^^^^^^^^ help: consider parenthesizing your expression: `u >> (8*0)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence [INFO] [stderr] [INFO] [stderr] warning: operator precedence can trip the unwary [INFO] [stderr] --> src/util/byte_utils.rs:65:11 [INFO] [stderr] | [INFO] [stderr] 65 | v[0] = ((u >> 8*7) & 0xff) as u8; [INFO] [stderr] | ^^^^^^^^ help: consider parenthesizing your expression: `u >> (8*7)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence [INFO] [stderr] [INFO] [stderr] warning: operator precedence can trip the unwary [INFO] [stderr] --> src/util/byte_utils.rs:66:11 [INFO] [stderr] | [INFO] [stderr] 66 | v[1] = ((u >> 8*6) & 0xff) as u8; [INFO] [stderr] | ^^^^^^^^ help: consider parenthesizing your expression: `u >> (8*6)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence [INFO] [stderr] [INFO] [stderr] warning: operator precedence can trip the unwary [INFO] [stderr] --> src/util/byte_utils.rs:67:11 [INFO] [stderr] | [INFO] [stderr] 67 | v[2] = ((u >> 8*5) & 0xff) as u8; [INFO] [stderr] | ^^^^^^^^ help: consider parenthesizing your expression: `u >> (8*5)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence [INFO] [stderr] [INFO] [stderr] warning: operator precedence can trip the unwary [INFO] [stderr] --> src/util/byte_utils.rs:68:11 [INFO] [stderr] | [INFO] [stderr] 68 | v[3] = ((u >> 8*4) & 0xff) as u8; [INFO] [stderr] | ^^^^^^^^ help: consider parenthesizing your expression: `u >> (8*4)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence [INFO] [stderr] [INFO] [stderr] warning: operator precedence can trip the unwary [INFO] [stderr] --> src/util/byte_utils.rs:69:11 [INFO] [stderr] | [INFO] [stderr] 69 | v[4] = ((u >> 8*3) & 0xff) as u8; [INFO] [stderr] | ^^^^^^^^ help: consider parenthesizing your expression: `u >> (8*3)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence [INFO] [stderr] [INFO] [stderr] warning: operator precedence can trip the unwary [INFO] [stderr] --> src/util/byte_utils.rs:70:11 [INFO] [stderr] | [INFO] [stderr] 70 | v[5] = ((u >> 8*2) & 0xff) as u8; [INFO] [stderr] | ^^^^^^^^ help: consider parenthesizing your expression: `u >> (8*2)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence [INFO] [stderr] [INFO] [stderr] warning: operator precedence can trip the unwary [INFO] [stderr] --> src/util/byte_utils.rs:71:11 [INFO] [stderr] | [INFO] [stderr] 71 | v[6] = ((u >> 8*1) & 0xff) as u8; [INFO] [stderr] | ^^^^^^^^ help: consider parenthesizing your expression: `u >> (8*1)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence [INFO] [stderr] [INFO] [stderr] warning: operator precedence can trip the unwary [INFO] [stderr] --> src/util/byte_utils.rs:72:11 [INFO] [stderr] | [INFO] [stderr] 72 | v[7] = ((u >> 8*0) & 0xff) as u8; [INFO] [stderr] | ^^^^^^^^ help: consider parenthesizing your expression: `u >> (8*0)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence [INFO] [stderr] [INFO] [stderr] warning: operator precedence can trip the unwary [INFO] [stderr] --> src/util/byte_utils.rs:79:11 [INFO] [stderr] | [INFO] [stderr] 79 | v[0] = ((u >> 8*0) & 0xff) as u8; [INFO] [stderr] | ^^^^^^^^ help: consider parenthesizing your expression: `u >> (8*0)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence [INFO] [stderr] [INFO] [stderr] warning: operator precedence can trip the unwary [INFO] [stderr] --> src/util/byte_utils.rs:80:11 [INFO] [stderr] | [INFO] [stderr] 80 | v[1] = ((u >> 8*1) & 0xff) as u8; [INFO] [stderr] | ^^^^^^^^ help: consider parenthesizing your expression: `u >> (8*1)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence [INFO] [stderr] [INFO] [stderr] warning: operator precedence can trip the unwary [INFO] [stderr] --> src/util/byte_utils.rs:81:11 [INFO] [stderr] | [INFO] [stderr] 81 | v[2] = ((u >> 8*2) & 0xff) as u8; [INFO] [stderr] | ^^^^^^^^ help: consider parenthesizing your expression: `u >> (8*2)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence [INFO] [stderr] [INFO] [stderr] warning: operator precedence can trip the unwary [INFO] [stderr] --> src/util/byte_utils.rs:82:11 [INFO] [stderr] | [INFO] [stderr] 82 | v[3] = ((u >> 8*3) & 0xff) as u8; [INFO] [stderr] | ^^^^^^^^ help: consider parenthesizing your expression: `u >> (8*3)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence [INFO] [stderr] [INFO] [stderr] warning: operator precedence can trip the unwary [INFO] [stderr] --> src/util/byte_utils.rs:83:11 [INFO] [stderr] | [INFO] [stderr] 83 | v[4] = ((u >> 8*4) & 0xff) as u8; [INFO] [stderr] | ^^^^^^^^ help: consider parenthesizing your expression: `u >> (8*4)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence [INFO] [stderr] [INFO] [stderr] warning: operator precedence can trip the unwary [INFO] [stderr] --> src/util/byte_utils.rs:84:11 [INFO] [stderr] | [INFO] [stderr] 84 | v[5] = ((u >> 8*5) & 0xff) as u8; [INFO] [stderr] | ^^^^^^^^ help: consider parenthesizing your expression: `u >> (8*5)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence [INFO] [stderr] [INFO] [stderr] warning: operator precedence can trip the unwary [INFO] [stderr] --> src/util/byte_utils.rs:85:11 [INFO] [stderr] | [INFO] [stderr] 85 | v[6] = ((u >> 8*6) & 0xff) as u8; [INFO] [stderr] | ^^^^^^^^ help: consider parenthesizing your expression: `u >> (8*6)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence [INFO] [stderr] [INFO] [stderr] warning: operator precedence can trip the unwary [INFO] [stderr] --> src/util/byte_utils.rs:86:11 [INFO] [stderr] | [INFO] [stderr] 86 | v[7] = ((u >> 8*7) & 0xff) as u8; [INFO] [stderr] | ^^^^^^^^ help: consider parenthesizing your expression: `u >> (8*7)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/util/transaction_utils.rs:96:11 [INFO] [stderr] | [INFO] [stderr] 96 | value: 100000000, [INFO] [stderr] | ^^^^^^^^^ help: consider: `100_000_000` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/util/transaction_utils.rs:103:11 [INFO] [stderr] | [INFO] [stderr] 103 | value: 2400000000, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `2_400_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/util/transaction_utils.rs:144:4 [INFO] [stderr] | [INFO] [stderr] 144 | (400057456, "76a9144a5fba237213a062f6f57978f796390bdcf8d01588ac"), [INFO] [stderr] | ^^^^^^^^^ help: consider: `400_057_456` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/util/transaction_utils.rs:145:4 [INFO] [stderr] | [INFO] [stderr] 145 | (40000000000, "76a9145be32612930b8323add2212a4ec03c1562084f8488ac"), [INFO] [stderr] | ^^^^^^^^^^^ help: consider: `40_000_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/util/transaction_utils.rs:148:4 [INFO] [stderr] | [INFO] [stderr] 148 | (100000000, "41046a0765b5865641ce08dd39690aade26dfbf5511430ca428a3089261361cef170e3929a68aee3d8d4848b0c5111b0a37b82b86ad559fd2a745b44d8e8d9dfdc0cac"), [INFO] [stderr] | ^^^^^^^^^ help: consider: `100_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/util/transaction_utils.rs:149:4 [INFO] [stderr] | [INFO] [stderr] 149 | (2400000000, "41044a656f065871a353f216ca26cef8dde2f03e8c16202d2e8ad769f02032cb86a5eb5e56842e92e19141d60a01928f8dd2c875a390f67c1f6c94cfc617c0ea45afac"), [INFO] [stderr] | ^^^^^^^^^^ help: consider: `2_400_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/chain/chaininterface.rs:174:5 [INFO] [stderr] | [INFO] [stderr] 174 | if *script == out.script_pubkey { [INFO] [stderr] | _________________^ [INFO] [stderr] 175 | | if tx.txid() == *txid { [INFO] [stderr] 176 | | return true; [INFO] [stderr] 177 | | } [INFO] [stderr] 178 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 174 | if *script == out.script_pubkey && tx.txid() == *txid { [INFO] [stderr] 175 | return true; [INFO] [stderr] 176 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/chain/chaininterface.rs:307:3 [INFO] [stderr] | [INFO] [stderr] 307 | return last_seen != self.reentered.load(Ordering::Relaxed); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `last_seen != self.reentered.load(Ordering::Relaxed)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ln/channelmanager.rs:802:25 [INFO] [stderr] | [INFO] [stderr] 802 | if cur_value_msat >= 21000000 * 100000000 * 1000 { [INFO] [stderr] | ^^^^^^^^ help: consider: `21_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ln/channelmanager.rs:802:36 [INFO] [stderr] | [INFO] [stderr] 802 | if cur_value_msat >= 21000000 * 100000000 * 1000 { [INFO] [stderr] | ^^^^^^^^^ help: consider: `100_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ln/channelmanager.rs:806:19 [INFO] [stderr] | [INFO] [stderr] 806 | if cur_cltv >= 500000000 { [INFO] [stderr] | ^^^^^^^^^ help: consider: `500_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ln/channelmanager.rs:1108:124 [INFO] [stderr] | [INFO] [stderr] 1108 | let fee = amt_to_forward.checked_mul(chan.get_fee_proportional_millionths() as u64).and_then(|prop_fee| { (prop_fee / 1000000).checked_add(chan.get_our_fee_base_msat(&*self.fee_estimator) as u64) }); [INFO] [stderr] | ^^^^^^^ help: consider: `1_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/ln/channelmanager.rs:2010:12 [INFO] [stderr] | [INFO] [stderr] 2010 | None => return Err(MsgHandleErrInternal::send_err_msg_no_close("Failed to find corresponding channel", msg.channel_id)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(MsgHandleErrInternal::send_err_msg_no_close("Failed to find corresponding channel", msg.channel_id))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ln/channelmanager.rs:2175:148 [INFO] [stderr] | [INFO] [stderr] 2175 | let new_fee = amt_to_forward.checked_mul(chan_update.contents.fee_proportional_millionths as u64).and_then(|prop_fee| { (prop_fee / 1000000).checked_add(chan_update.contents.fee_base_msat as u64) }); [INFO] [stderr] | ^^^^^^^ help: consider: `1_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> src/ln/channelmanager.rs:2225:12 [INFO] [stderr] | [INFO] [stderr] 2225 | } else { ((None, true)) } [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::double_parens)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/ln/channelmanager.rs:2259:12 [INFO] [stderr] | [INFO] [stderr] 2259 | None => return Err(MsgHandleErrInternal::send_err_msg_no_close("Failed to find corresponding channel", msg.channel_id)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(MsgHandleErrInternal::send_err_msg_no_close("Failed to find corresponding channel", msg.channel_id))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/ln/channelmanager.rs:2389:12 [INFO] [stderr] | [INFO] [stderr] 2389 | None => return Err(MsgHandleErrInternal::send_err_msg_no_close("Failed to find corresponding channel", msg.channel_id)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(MsgHandleErrInternal::send_err_msg_no_close("Failed to find corresponding channel", msg.channel_id))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ln/channelmanager.rs:3377:24 [INFO] [stderr] | [INFO] [stderr] 3377 | short_channel_id: 0x0101010101010101, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0x0101_0101_0101_0101` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ln/channelmanager.rs:3378:22 [INFO] [stderr] | [INFO] [stderr] 3378 | amt_to_forward: 0x0100000001, [INFO] [stderr] | ^^^^^^^^^^^^ help: consider: `0x0001_0000_0001` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ln/channelmanager.rs:3386:24 [INFO] [stderr] | [INFO] [stderr] 3386 | short_channel_id: 0x0202020202020202, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0x0202_0202_0202_0202` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ln/channelmanager.rs:3387:22 [INFO] [stderr] | [INFO] [stderr] 3387 | amt_to_forward: 0x0200000002, [INFO] [stderr] | ^^^^^^^^^^^^ help: consider: `0x0002_0000_0002` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ln/channelmanager.rs:3395:24 [INFO] [stderr] | [INFO] [stderr] 3395 | short_channel_id: 0x0303030303030303, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0x0303_0303_0303_0303` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ln/channelmanager.rs:3396:22 [INFO] [stderr] | [INFO] [stderr] 3396 | amt_to_forward: 0x0300000003, [INFO] [stderr] | ^^^^^^^^^^^^ help: consider: `0x0003_0000_0003` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ln/channelmanager.rs:3404:24 [INFO] [stderr] | [INFO] [stderr] 3404 | short_channel_id: 0x0404040404040404, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0x0404_0404_0404_0404` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ln/channelmanager.rs:3405:22 [INFO] [stderr] | [INFO] [stderr] 3405 | amt_to_forward: 0x0400000004, [INFO] [stderr] | ^^^^^^^^^^^^ help: consider: `0x0004_0000_0004` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ln/channelmanager.rs:3444:43 [INFO] [stderr] | [INFO] [stderr] 3444 | let mut header = BlockHeader { version: 0x20000000, prev_blockhash: Default::default(), merkle_root: Default::default(), time: 42, bits: 42, nonce: 42 }; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x2000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ln/channelmanager.rs:3447:36 [INFO] [stderr] | [INFO] [stderr] 3447 | header = BlockHeader { version: 0x20000000, prev_blockhash: header.bitcoin_hash(), merkle_root: Default::default(), time: 42, bits: 42, nonce: 42 }; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x2000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ln/channelmanager.rs:3474:56 [INFO] [stderr] | [INFO] [stderr] 3474 | create_chan_between_nodes_with_value(node_a, node_b, 100000, 10001) [INFO] [stderr] | ^^^^^^ help: consider: `100_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ln/channelmanager.rs:3674:63 [INFO] [stderr] | [INFO] [stderr] 3674 | create_announced_chan_between_nodes_with_value(nodes, a, b, 100000, 10001) [INFO] [stderr] | ^^^^^^ help: consider: `100_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ln/channelmanager.rs:4187:49 [INFO] [stderr] | [INFO] [stderr] 4187 | send_payment(&nodes[0], &vec!(&nodes[1])[..], 8000000); [INFO] [stderr] | ^^^^^^^ help: consider: `8_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ln/channelmanager.rs:4297:49 [INFO] [stderr] | [INFO] [stderr] 4297 | send_payment(&nodes[0], &vec!(&nodes[1])[..], 8000000); [INFO] [stderr] | ^^^^^^^ help: consider: `8_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: You matched a field with a wildcard pattern. Consider using `..` instead [INFO] [stderr] --> src/ln/channelmanager.rs:4457:37 [INFO] [stderr] | [INFO] [stderr] 4457 | MessageSendEvent::UpdateHTLCs { node_id:_, updates: msgs::CommitmentUpdate { update_add_htlcs:_, update_fulfill_htlcs:_, update_fail_htlcs:_, update_fail_malformed_htlcs:_, ref update_fee, ref commitment_signed } } => { [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unneeded_field_pattern)] on by default [INFO] [stderr] = help: Try with `UpdateHTLCs { updates: msgs::CommitmentUpdate { update_add_htlcs:_, update_fulfill_htlcs:_, update_fail_htlcs:_, update_fail_malformed_htlcs:_, ref update_fee, ref commitment_signed }, .. }` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern [INFO] [stderr] [INFO] [stderr] warning: You matched a field with a wildcard pattern. Consider using `..` instead [INFO] [stderr] --> src/ln/channelmanager.rs:4457:82 [INFO] [stderr] | [INFO] [stderr] 4457 | MessageSendEvent::UpdateHTLCs { node_id:_, updates: msgs::CommitmentUpdate { update_add_htlcs:_, update_fulfill_htlcs:_, update_fail_htlcs:_, update_fail_malformed_htlcs:_, ref update_fee, ref commitment_signed } } => { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern [INFO] [stderr] [INFO] [stderr] warning: You matched a field with a wildcard pattern. Consider using `..` instead [INFO] [stderr] --> src/ln/channelmanager.rs:4457:102 [INFO] [stderr] | [INFO] [stderr] 4457 | MessageSendEvent::UpdateHTLCs { node_id:_, updates: msgs::CommitmentUpdate { update_add_htlcs:_, update_fulfill_htlcs:_, update_fail_htlcs:_, update_fail_malformed_htlcs:_, ref update_fee, ref commitment_signed } } => { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern [INFO] [stderr] [INFO] [stderr] warning: You matched a field with a wildcard pattern. Consider using `..` instead [INFO] [stderr] --> src/ln/channelmanager.rs:4457:126 [INFO] [stderr] | [INFO] [stderr] 4457 | MessageSendEvent::UpdateHTLCs { node_id:_, updates: msgs::CommitmentUpdate { update_add_htlcs:_, update_fulfill_htlcs:_, update_fail_htlcs:_, update_fail_malformed_htlcs:_, ref update_fee, ref commitment_signed } } => { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern [INFO] [stderr] [INFO] [stderr] warning: You matched a field with a wildcard pattern. Consider using `..` instead [INFO] [stderr] --> src/ln/channelmanager.rs:4457:147 [INFO] [stderr] | [INFO] [stderr] 4457 | MessageSendEvent::UpdateHTLCs { node_id:_, updates: msgs::CommitmentUpdate { update_add_htlcs:_, update_fulfill_htlcs:_, update_fail_htlcs:_, update_fail_malformed_htlcs:_, ref update_fee, ref commitment_signed } } => { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Try with `CommitmentUpdate { ref update_fee, ref commitment_signed, .. }` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ln/channelmanager.rs:4486:90 [INFO] [stderr] | [INFO] [stderr] 4486 | let chan = create_announced_chan_between_nodes_with_value(&nodes, 0, 1, channel_value, 700000); [INFO] [stderr] | ^^^^^^ help: consider: `700_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ln/channelmanager.rs:4542:49 [INFO] [stderr] | [INFO] [stderr] 4542 | send_payment(&nodes[0], &vec!(&nodes[1])[..], 8000000); [INFO] [stderr] | ^^^^^^^ help: consider: `8_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: You matched a field with a wildcard pattern. Consider using `..` instead [INFO] [stderr] --> src/ln/channelmanager.rs:4551:37 [INFO] [stderr] | [INFO] [stderr] 4551 | MessageSendEvent::UpdateHTLCs { node_id:_, updates: msgs::CommitmentUpdate { update_add_htlcs:_, update_fulfill_htlcs:_, update_fail_htlcs:_, update_fail_malformed_htlcs:_, ref update_fee, ref commitment_signed } } => { [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Try with `UpdateHTLCs { updates: msgs::CommitmentUpdate { update_add_htlcs:_, update_fulfill_htlcs:_, update_fail_htlcs:_, update_fail_malformed_htlcs:_, ref update_fee, ref commitment_signed }, .. }` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern [INFO] [stderr] [INFO] [stderr] warning: You matched a field with a wildcard pattern. Consider using `..` instead [INFO] [stderr] --> src/ln/channelmanager.rs:4551:82 [INFO] [stderr] | [INFO] [stderr] 4551 | MessageSendEvent::UpdateHTLCs { node_id:_, updates: msgs::CommitmentUpdate { update_add_htlcs:_, update_fulfill_htlcs:_, update_fail_htlcs:_, update_fail_malformed_htlcs:_, ref update_fee, ref commitment_signed } } => { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern [INFO] [stderr] [INFO] [stderr] warning: You matched a field with a wildcard pattern. Consider using `..` instead [INFO] [stderr] --> src/ln/channelmanager.rs:4551:102 [INFO] [stderr] | [INFO] [stderr] 4551 | MessageSendEvent::UpdateHTLCs { node_id:_, updates: msgs::CommitmentUpdate { update_add_htlcs:_, update_fulfill_htlcs:_, update_fail_htlcs:_, update_fail_malformed_htlcs:_, ref update_fee, ref commitment_signed } } => { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern [INFO] [stderr] [INFO] [stderr] warning: You matched a field with a wildcard pattern. Consider using `..` instead [INFO] [stderr] --> src/ln/channelmanager.rs:4551:126 [INFO] [stderr] | [INFO] [stderr] 4551 | MessageSendEvent::UpdateHTLCs { node_id:_, updates: msgs::CommitmentUpdate { update_add_htlcs:_, update_fulfill_htlcs:_, update_fail_htlcs:_, update_fail_malformed_htlcs:_, ref update_fee, ref commitment_signed } } => { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern [INFO] [stderr] [INFO] [stderr] warning: You matched a field with a wildcard pattern. Consider using `..` instead [INFO] [stderr] --> src/ln/channelmanager.rs:4551:147 [INFO] [stderr] | [INFO] [stderr] 4551 | MessageSendEvent::UpdateHTLCs { node_id:_, updates: msgs::CommitmentUpdate { update_add_htlcs:_, update_fulfill_htlcs:_, update_fail_htlcs:_, update_fail_malformed_htlcs:_, ref update_fee, ref commitment_signed } } => { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Try with `CommitmentUpdate { ref update_fee, ref commitment_signed, .. }` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ln/channelmanager.rs:4561:94 [INFO] [stderr] | [INFO] [stderr] 4561 | let route = nodes[1].router.get_route(&nodes[0].node.get_our_node_id(), None, &Vec::new(), 800000, TEST_FINAL_CLTV).unwrap(); [INFO] [stderr] | ^^^^^^ help: consider: `800_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ln/channelmanager.rs:4631:49 [INFO] [stderr] | [INFO] [stderr] 4631 | send_payment(&nodes[1], &vec!(&nodes[0])[..], 800000); [INFO] [stderr] | ^^^^^^ help: consider: `800_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ln/channelmanager.rs:4632:49 [INFO] [stderr] | [INFO] [stderr] 4632 | send_payment(&nodes[0], &vec!(&nodes[1])[..], 800000); [INFO] [stderr] | ^^^^^^ help: consider: `800_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: You matched a field with a wildcard pattern. Consider using `..` instead [INFO] [stderr] --> src/ln/channelmanager.rs:4664:37 [INFO] [stderr] | [INFO] [stderr] 4664 | MessageSendEvent::UpdateHTLCs { node_id:_, updates: msgs::CommitmentUpdate { update_add_htlcs:_, update_fulfill_htlcs:_, update_fail_htlcs:_, update_fail_malformed_htlcs:_, ref update_fee, ref commitment_signed } } => { [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Try with `UpdateHTLCs { updates: msgs::CommitmentUpdate { update_add_htlcs:_, update_fulfill_htlcs:_, update_fail_htlcs:_, update_fail_malformed_htlcs:_, ref update_fee, ref commitment_signed }, .. }` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern [INFO] [stderr] [INFO] [stderr] warning: You matched a field with a wildcard pattern. Consider using `..` instead [INFO] [stderr] --> src/ln/channelmanager.rs:4664:82 [INFO] [stderr] | [INFO] [stderr] 4664 | MessageSendEvent::UpdateHTLCs { node_id:_, updates: msgs::CommitmentUpdate { update_add_htlcs:_, update_fulfill_htlcs:_, update_fail_htlcs:_, update_fail_malformed_htlcs:_, ref update_fee, ref commitment_signed } } => { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern [INFO] [stderr] [INFO] [stderr] warning: You matched a field with a wildcard pattern. Consider using `..` instead [INFO] [stderr] --> src/ln/channelmanager.rs:4664:102 [INFO] [stderr] | [INFO] [stderr] 4664 | MessageSendEvent::UpdateHTLCs { node_id:_, updates: msgs::CommitmentUpdate { update_add_htlcs:_, update_fulfill_htlcs:_, update_fail_htlcs:_, update_fail_malformed_htlcs:_, ref update_fee, ref commitment_signed } } => { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern [INFO] [stderr] [INFO] [stderr] warning: You matched a field with a wildcard pattern. Consider using `..` instead [INFO] [stderr] --> src/ln/channelmanager.rs:4664:126 [INFO] [stderr] | [INFO] [stderr] 4664 | MessageSendEvent::UpdateHTLCs { node_id:_, updates: msgs::CommitmentUpdate { update_add_htlcs:_, update_fulfill_htlcs:_, update_fail_htlcs:_, update_fail_malformed_htlcs:_, ref update_fee, ref commitment_signed } } => { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern [INFO] [stderr] [INFO] [stderr] warning: You matched a field with a wildcard pattern. Consider using `..` instead [INFO] [stderr] --> src/ln/channelmanager.rs:4664:147 [INFO] [stderr] | [INFO] [stderr] 4664 | MessageSendEvent::UpdateHTLCs { node_id:_, updates: msgs::CommitmentUpdate { update_add_htlcs:_, update_fulfill_htlcs:_, update_fail_htlcs:_, update_fail_malformed_htlcs:_, ref update_fee, ref commitment_signed } } => { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Try with `CommitmentUpdate { ref update_fee, ref commitment_signed, .. }` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern [INFO] [stderr] [INFO] [stderr] warning: You matched a field with a wildcard pattern. Consider using `..` instead [INFO] [stderr] --> src/ln/channelmanager.rs:4687:37 [INFO] [stderr] | [INFO] [stderr] 4687 | MessageSendEvent::UpdateHTLCs { node_id:_, updates: msgs::CommitmentUpdate { update_add_htlcs:_, update_fulfill_htlcs:_, update_fail_htlcs:_, update_fail_malformed_htlcs:_, ref update_fee, ref commitment_signed } } => { [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Try with `UpdateHTLCs { updates: msgs::CommitmentUpdate { update_add_htlcs:_, update_fulfill_htlcs:_, update_fail_htlcs:_, update_fail_malformed_htlcs:_, ref update_fee, ref commitment_signed }, .. }` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern [INFO] [stderr] [INFO] [stderr] warning: You matched a field with a wildcard pattern. Consider using `..` instead [INFO] [stderr] --> src/ln/channelmanager.rs:4687:82 [INFO] [stderr] | [INFO] [stderr] 4687 | MessageSendEvent::UpdateHTLCs { node_id:_, updates: msgs::CommitmentUpdate { update_add_htlcs:_, update_fulfill_htlcs:_, update_fail_htlcs:_, update_fail_malformed_htlcs:_, ref update_fee, ref commitment_signed } } => { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern [INFO] [stderr] [INFO] [stderr] warning: You matched a field with a wildcard pattern. Consider using `..` instead [INFO] [stderr] --> src/ln/channelmanager.rs:4687:102 [INFO] [stderr] | [INFO] [stderr] 4687 | MessageSendEvent::UpdateHTLCs { node_id:_, updates: msgs::CommitmentUpdate { update_add_htlcs:_, update_fulfill_htlcs:_, update_fail_htlcs:_, update_fail_malformed_htlcs:_, ref update_fee, ref commitment_signed } } => { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern [INFO] [stderr] [INFO] [stderr] warning: You matched a field with a wildcard pattern. Consider using `..` instead [INFO] [stderr] --> src/ln/channelmanager.rs:4687:126 [INFO] [stderr] | [INFO] [stderr] 4687 | MessageSendEvent::UpdateHTLCs { node_id:_, updates: msgs::CommitmentUpdate { update_add_htlcs:_, update_fulfill_htlcs:_, update_fail_htlcs:_, update_fail_malformed_htlcs:_, ref update_fee, ref commitment_signed } } => { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern [INFO] [stderr] [INFO] [stderr] warning: You matched a field with a wildcard pattern. Consider using `..` instead [INFO] [stderr] --> src/ln/channelmanager.rs:4687:147 [INFO] [stderr] | [INFO] [stderr] 4687 | MessageSendEvent::UpdateHTLCs { node_id:_, updates: msgs::CommitmentUpdate { update_add_htlcs:_, update_fulfill_htlcs:_, update_fail_htlcs:_, update_fail_malformed_htlcs:_, ref update_fee, ref commitment_signed } } => { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Try with `CommitmentUpdate { ref update_fee, ref commitment_signed, .. }` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ln/channelmanager.rs:4740:76 [INFO] [stderr] | [INFO] [stderr] 4740 | let tx = create_chan_between_nodes_with_value_init(&nodes[0], &nodes[1], 8000000, 0); [INFO] [stderr] | ^^^^^^^ help: consider: `8_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ln/channelmanager.rs:4741:39 [INFO] [stderr] | [INFO] [stderr] 4741 | let header = BlockHeader { version: 0x20000000, prev_blockhash: Default::default(), merkle_root: Default::default(), time: 42, bits: 42, nonce: 42 }; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x2000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ln/channelmanager.rs:4768:88 [INFO] [stderr] | [INFO] [stderr] 4768 | let route_1 = nodes[0].router.get_route(&nodes[1].node.get_our_node_id(), None, &[], 100000, TEST_FINAL_CLTV).unwrap(); [INFO] [stderr] | ^^^^^^ help: consider: `100_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ln/channelmanager.rs:4769:88 [INFO] [stderr] | [INFO] [stderr] 4769 | let route_2 = nodes[1].router.get_route(&nodes[0].node.get_our_node_id(), None, &[], 100000, TEST_FINAL_CLTV).unwrap(); [INFO] [stderr] | ^^^^^^ help: consider: `100_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ln/channelmanager.rs:4771:85 [INFO] [stderr] | [INFO] [stderr] 4771 | let (our_payment_preimage, _) = route_payment(&nodes[0], &[&nodes[1], &nodes[2]], 100000); [INFO] [stderr] | ^^^^^^ help: consider: `100_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ln/channelmanager.rs:4841:86 [INFO] [stderr] | [INFO] [stderr] 4841 | let route = nodes[0].router.get_route(&nodes[2].node.get_our_node_id(), None, &[], 100000, TEST_FINAL_CLTV).unwrap(); [INFO] [stderr] | ^^^^^^ help: consider: `100_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ln/channelmanager.rs:4953:85 [INFO] [stderr] | [INFO] [stderr] 4953 | let (our_payment_preimage, _) = route_payment(&nodes[0], &[&nodes[1], &nodes[2]], 100000); [INFO] [stderr] | ^^^^^^ help: consider: `100_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ln/channelmanager.rs:5117:71 [INFO] [stderr] | [INFO] [stderr] 5117 | send_payment(&nodes[0], &vec!(&nodes[1], &nodes[2], &nodes[3])[..], 8000000); [INFO] [stderr] | ^^^^^^^ help: consider: `8_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ln/channelmanager.rs:5118:71 [INFO] [stderr] | [INFO] [stderr] 5118 | send_payment(&nodes[0], &vec!(&nodes[1], &nodes[2], &nodes[3])[..], 8000000); [INFO] [stderr] | ^^^^^^^ help: consider: `8_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ln/channelmanager.rs:5119:71 [INFO] [stderr] | [INFO] [stderr] 5119 | send_payment(&nodes[0], &vec!(&nodes[1], &nodes[2], &nodes[3])[..], 8000000); [INFO] [stderr] | ^^^^^^^ help: consider: `8_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ln/channelmanager.rs:5120:71 [INFO] [stderr] | [INFO] [stderr] 5120 | send_payment(&nodes[0], &vec!(&nodes[1], &nodes[2], &nodes[3])[..], 8000000); [INFO] [stderr] | ^^^^^^^ help: consider: `8_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ln/channelmanager.rs:5123:60 [INFO] [stderr] | [INFO] [stderr] 5123 | send_payment(&nodes[1], &vec!(&nodes[2], &nodes[3])[..], 1000000); [INFO] [stderr] | ^^^^^^^ help: consider: `1_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ln/channelmanager.rs:5124:71 [INFO] [stderr] | [INFO] [stderr] 5124 | send_payment(&nodes[3], &vec!(&nodes[2], &nodes[1], &nodes[0])[..], 1000000); [INFO] [stderr] | ^^^^^^^ help: consider: `1_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ln/channelmanager.rs:5125:60 [INFO] [stderr] | [INFO] [stderr] 5125 | send_payment(&nodes[3], &vec!(&nodes[2], &nodes[1])[..], 1000000); [INFO] [stderr] | ^^^^^^^ help: consider: `1_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ln/channelmanager.rs:5128:93 [INFO] [stderr] | [INFO] [stderr] 5128 | let payment_hash_1 = route_payment(&nodes[0], &vec!(&nodes[1], &nodes[2], &nodes[3])[..], 1000000).1; [INFO] [stderr] | ^^^^^^^ help: consider: `1_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ln/channelmanager.rs:5134:60 [INFO] [stderr] | [INFO] [stderr] 5134 | send_payment(&nodes[0], &vec!(&nodes[1], &nodes[3])[..], 1000000); [INFO] [stderr] | ^^^^^^^ help: consider: `1_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ln/channelmanager.rs:5135:49 [INFO] [stderr] | [INFO] [stderr] 5135 | send_payment(&nodes[2], &vec!(&nodes[3])[..], 1000000); [INFO] [stderr] | ^^^^^^^ help: consider: `1_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ln/channelmanager.rs:5136:49 [INFO] [stderr] | [INFO] [stderr] 5136 | send_payment(&nodes[1], &vec!(&nodes[3])[..], 8000000); [INFO] [stderr] | ^^^^^^^ help: consider: `8_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ln/channelmanager.rs:5137:49 [INFO] [stderr] | [INFO] [stderr] 5137 | send_payment(&nodes[1], &vec!(&nodes[3])[..], 8000000); [INFO] [stderr] | ^^^^^^^ help: consider: `8_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ln/channelmanager.rs:5138:49 [INFO] [stderr] | [INFO] [stderr] 5138 | send_payment(&nodes[1], &vec!(&nodes[3])[..], 8000000); [INFO] [stderr] | ^^^^^^^ help: consider: `8_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ln/channelmanager.rs:5139:49 [INFO] [stderr] | [INFO] [stderr] 5139 | send_payment(&nodes[1], &vec!(&nodes[3])[..], 8000000); [INFO] [stderr] | ^^^^^^^ help: consider: `8_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ln/channelmanager.rs:5140:49 [INFO] [stderr] | [INFO] [stderr] 5140 | send_payment(&nodes[1], &vec!(&nodes[3])[..], 8000000); [INFO] [stderr] | ^^^^^^^ help: consider: `8_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ln/channelmanager.rs:5159:14 [INFO] [stderr] | [INFO] [stderr] 5159 | fee_msat: 1000000, [INFO] [stderr] | ^^^^^^^ help: consider: `1_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ln/channelmanager.rs:5162:144 [INFO] [stderr] | [INFO] [stderr] 5162 | hops[1].fee_msat = chan_4.1.contents.fee_base_msat as u64 + chan_4.1.contents.fee_proportional_millionths as u64 * hops[2].fee_msat as u64 / 1000000; [INFO] [stderr] | ^^^^^^^ help: consider: `1_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ln/channelmanager.rs:5163:144 [INFO] [stderr] | [INFO] [stderr] 5163 | hops[0].fee_msat = chan_3.0.contents.fee_base_msat as u64 + chan_3.0.contents.fee_proportional_millionths as u64 * hops[1].fee_msat as u64 / 1000000; [INFO] [stderr] | ^^^^^^^ help: consider: `1_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ln/channelmanager.rs:5164:116 [INFO] [stderr] | [INFO] [stderr] 5164 | let payment_preimage_1 = send_along_route(&nodes[1], Route { hops }, &vec!(&nodes[2], &nodes[3], &nodes[1])[..], 1000000).0; [INFO] [stderr] | ^^^^^^^ help: consider: `1_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ln/channelmanager.rs:5182:14 [INFO] [stderr] | [INFO] [stderr] 5182 | fee_msat: 1000000, [INFO] [stderr] | ^^^^^^^ help: consider: `1_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ln/channelmanager.rs:5185:144 [INFO] [stderr] | [INFO] [stderr] 5185 | hops[1].fee_msat = chan_2.1.contents.fee_base_msat as u64 + chan_2.1.contents.fee_proportional_millionths as u64 * hops[2].fee_msat as u64 / 1000000; [INFO] [stderr] | ^^^^^^^ help: consider: `1_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ln/channelmanager.rs:5186:144 [INFO] [stderr] | [INFO] [stderr] 5186 | hops[0].fee_msat = chan_3.1.contents.fee_base_msat as u64 + chan_3.1.contents.fee_proportional_millionths as u64 * hops[1].fee_msat as u64 / 1000000; [INFO] [stderr] | ^^^^^^^ help: consider: `1_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ln/channelmanager.rs:5187:112 [INFO] [stderr] | [INFO] [stderr] 5187 | let payment_hash_2 = send_along_route(&nodes[1], Route { hops }, &vec!(&nodes[3], &nodes[2], &nodes[1])[..], 1000000).1; [INFO] [stderr] | ^^^^^^^ help: consider: `1_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ln/channelmanager.rs:5197:86 [INFO] [stderr] | [INFO] [stderr] 5197 | let payment_preimage_3 = route_payment(&nodes[0], &vec!(&nodes[1], &nodes[3])[..], 3000000).0; [INFO] [stderr] | ^^^^^^^ help: consider: `3_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ln/channelmanager.rs:5198:86 [INFO] [stderr] | [INFO] [stderr] 5198 | let payment_preimage_4 = route_payment(&nodes[0], &vec!(&nodes[1], &nodes[3])[..], 3000000).0; [INFO] [stderr] | ^^^^^^^ help: consider: `3_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ln/channelmanager.rs:5199:86 [INFO] [stderr] | [INFO] [stderr] 5199 | let payment_preimage_5 = route_payment(&nodes[0], &vec!(&nodes[1], &nodes[3])[..], 3000000).0; [INFO] [stderr] | ^^^^^^^ help: consider: `3_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ln/channelmanager.rs:5201:64 [INFO] [stderr] | [INFO] [stderr] 5201 | route_over_limit(&nodes[0], &vec!(&nodes[1], &nodes[3])[..], 3000000); [INFO] [stderr] | ^^^^^^^ help: consider: `3_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ln/channelmanager.rs:5230:100 [INFO] [stderr] | [INFO] [stderr] 5230 | let (payment_preimage, payment_hash) = route_payment(&nodes[0], &vec!(&nodes[3], &nodes[4])[..], 1000000); [INFO] [stderr] | ^^^^^^^ help: consider: `1_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ln/channelmanager.rs:5233:61 [INFO] [stderr] | [INFO] [stderr] 5233 | assert_eq!(route_payment(&nodes[1], &vec!(&nodes[3])[..], 1000000).0, payment_preimage); [INFO] [stderr] | ^^^^^^^ help: consider: `1_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ln/channelmanager.rs:5236:72 [INFO] [stderr] | [INFO] [stderr] 5236 | assert_eq!(route_payment(&nodes[2], &vec!(&nodes[3], &nodes[5])[..], 1000000).0, payment_preimage); [INFO] [stderr] | ^^^^^^^ help: consider: `1_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/ln/channelmanager.rs:5410:5 [INFO] [stderr] | [INFO] [stderr] 5410 | payment_event [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 5588 | let ref payment_event_11 = expect_forward!(nodes[1]); [INFO] [stderr] | ------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/ln/channelmanager.rs:5409:25 [INFO] [stderr] | [INFO] [stderr] 5409 | let payment_event = SendEvent::from_event(events.remove(0)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 5588 | let ref payment_event_11 = expect_forward!(nodes[1]); [INFO] [stderr] | ------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/ln/channelmanager.rs:5410:5 [INFO] [stderr] | [INFO] [stderr] 5410 | payment_event [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 5602 | let ref payment_event_3 = expect_forward!(nodes[1]); [INFO] [stderr] | ------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/ln/channelmanager.rs:5409:25 [INFO] [stderr] | [INFO] [stderr] 5409 | let payment_event = SendEvent::from_event(events.remove(0)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 5602 | let ref payment_event_3 = expect_forward!(nodes[1]); [INFO] [stderr] | ------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ln/channelmanager.rs:5653:82 [INFO] [stderr] | [INFO] [stderr] 5653 | send_payment(&nodes[0], &vec!(&nodes[1], &nodes[2], &nodes[3], &nodes[4])[..], 8000000); [INFO] [stderr] | ^^^^^^^ help: consider: `8_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ln/channelmanager.rs:5654:82 [INFO] [stderr] | [INFO] [stderr] 5654 | send_payment(&nodes[0], &vec!(&nodes[1], &nodes[2], &nodes[3], &nodes[4])[..], 8000000); [INFO] [stderr] | ^^^^^^^ help: consider: `8_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ln/channelmanager.rs:5655:82 [INFO] [stderr] | [INFO] [stderr] 5655 | send_payment(&nodes[0], &vec!(&nodes[1], &nodes[2], &nodes[3], &nodes[4])[..], 8000000); [INFO] [stderr] | ^^^^^^^ help: consider: `8_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ln/channelmanager.rs:5656:82 [INFO] [stderr] | [INFO] [stderr] 5656 | send_payment(&nodes[0], &vec!(&nodes[1], &nodes[2], &nodes[3], &nodes[4])[..], 8000000); [INFO] [stderr] | ^^^^^^^ help: consider: `8_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ln/channelmanager.rs:5662:40 [INFO] [stderr] | [INFO] [stderr] 5662 | let header = BlockHeader { version: 0x20000000, prev_blockhash: Default::default(), merkle_root: Default::default(), time: 42, bits: 42, nonce: 42 }; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x2000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ln/channelmanager.rs:5671:86 [INFO] [stderr] | [INFO] [stderr] 5671 | let payment_preimage_1 = route_payment(&nodes[1], &vec!(&nodes[2], &nodes[3])[..], 3000000).0; [INFO] [stderr] | ^^^^^^^ help: consider: `3_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ln/channelmanager.rs:5677:40 [INFO] [stderr] | [INFO] [stderr] 5677 | let header = BlockHeader { version: 0x20000000, prev_blockhash: Default::default(), merkle_root: Default::default(), time: 42, bits: 42, nonce: 42 }; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x2000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ln/channelmanager.rs:5714:40 [INFO] [stderr] | [INFO] [stderr] 5714 | let header = BlockHeader { version: 0x20000000, prev_blockhash: Default::default(), merkle_root: Default::default(), time: 42, bits: 42, nonce: 42 }; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x2000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ln/channelmanager.rs:5724:40 [INFO] [stderr] | [INFO] [stderr] 5724 | let header = BlockHeader { version: 0x20000000, prev_blockhash: Default::default(), merkle_root: Default::default(), time: 42, bits: 42, nonce: 42 }; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x2000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ln/channelmanager.rs:5731:75 [INFO] [stderr] | [INFO] [stderr] 5731 | let payment_preimage_2 = route_payment(&nodes[3], &vec!(&nodes[4])[..], 3000000).0; [INFO] [stderr] | ^^^^^^^ help: consider: `3_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ln/channelmanager.rs:5736:44 [INFO] [stderr] | [INFO] [stderr] 5736 | let mut header = BlockHeader { version: 0x20000000, prev_blockhash: Default::default(), merkle_root: Default::default(), time: 42, bits: 42, nonce: 42 }; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x2000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ln/channelmanager.rs:5739:37 [INFO] [stderr] | [INFO] [stderr] 5739 | header = BlockHeader { version: 0x20000000, prev_blockhash: header.bitcoin_hash(), merkle_root: Default::default(), time: 42, bits: 42, nonce: 42 }; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x2000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ln/channelmanager.rs:5748:36 [INFO] [stderr] | [INFO] [stderr] 5748 | header = BlockHeader { version: 0x20000000, prev_blockhash: Default::default(), merkle_root: Default::default(), time: 42, bits: 42, nonce: 42 }; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x2000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ln/channelmanager.rs:5751:37 [INFO] [stderr] | [INFO] [stderr] 5751 | header = BlockHeader { version: 0x20000000, prev_blockhash: header.bitcoin_hash(), merkle_root: Default::default(), time: 42, bits: 42, nonce: 42 }; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x2000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ln/channelmanager.rs:5757:36 [INFO] [stderr] | [INFO] [stderr] 5757 | header = BlockHeader { version: 0x20000000, prev_blockhash: header.bitcoin_hash(), merkle_root: Default::default(), time: 42, bits: 42, nonce: 42 }; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x2000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ln/channelmanager.rs:5776:75 [INFO] [stderr] | [INFO] [stderr] 5776 | let payment_preimage_3 = route_payment(&nodes[0], &vec!(&nodes[1])[..], 3000000).0; [INFO] [stderr] | ^^^^^^^ help: consider: `3_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ln/channelmanager.rs:5790:44 [INFO] [stderr] | [INFO] [stderr] 5790 | let mut header = BlockHeader { version: 0x20000000, prev_blockhash: Default::default(), merkle_root: Default::default(), time: 42, bits: 42, nonce: 42 }; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x2000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ln/channelmanager.rs:5805:36 [INFO] [stderr] | [INFO] [stderr] 5805 | header = BlockHeader { version: 0x20000000, prev_blockhash: header.bitcoin_hash(), merkle_root: Default::default(), time: 42, bits: 42, nonce: 42 }; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x2000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ln/channelmanager.rs:5819:75 [INFO] [stderr] | [INFO] [stderr] 5819 | let payment_preimage_4 = route_payment(&nodes[0], &vec!(&nodes[1])[..], 3000000).0; [INFO] [stderr] | ^^^^^^^ help: consider: `3_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ln/channelmanager.rs:5829:44 [INFO] [stderr] | [INFO] [stderr] 5829 | let mut header = BlockHeader { version: 0x20000000, prev_blockhash: Default::default(), merkle_root: Default::default(), time: 42, bits: 42, nonce: 42 }; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x2000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ln/channelmanager.rs:5844:36 [INFO] [stderr] | [INFO] [stderr] 5844 | header = BlockHeader { version: 0x20000000, prev_blockhash: header.bitcoin_hash(), merkle_root: Default::default(), time: 42, bits: 42, nonce: 42 }; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x2000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ln/channelmanager.rs:5865:49 [INFO] [stderr] | [INFO] [stderr] 5865 | send_payment(&nodes[0], &vec!(&nodes[1])[..], 5000000); [INFO] [stderr] | ^^^^^^^ help: consider: `5_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ln/channelmanager.rs:5868:39 [INFO] [stderr] | [INFO] [stderr] 5868 | let header = BlockHeader { version: 0x20000000, prev_blockhash: Default::default(), merkle_root: Default::default(), time: 42, bits: 42, nonce: 42 }; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x2000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ln/channelmanager.rs:5892:49 [INFO] [stderr] | [INFO] [stderr] 5892 | send_payment(&nodes[0], &vec!(&nodes[1])[..], 8000000); [INFO] [stderr] | ^^^^^^^ help: consider: `8_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ln/channelmanager.rs:5894:75 [INFO] [stderr] | [INFO] [stderr] 5894 | let payment_preimage_1 = route_payment(&nodes[0], &vec!(&nodes[1])[..], 3000000).0; [INFO] [stderr] | ^^^^^^^ help: consider: `3_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ln/channelmanager.rs:5895:76 [INFO] [stderr] | [INFO] [stderr] 5895 | let _payment_preimage_2 = route_payment(&nodes[1], &vec!(&nodes[0])[..], 3000000).0; [INFO] [stderr] | ^^^^^^^ help: consider: `3_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ln/channelmanager.rs:5911:40 [INFO] [stderr] | [INFO] [stderr] 5911 | let header = BlockHeader { version: 0x20000000, prev_blockhash: Default::default(), merkle_root: Default::default(), time: 42, bits: 42, nonce: 42 }; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x2000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ln/channelmanager.rs:5957:49 [INFO] [stderr] | [INFO] [stderr] 5957 | send_payment(&nodes[0], &vec!(&nodes[1])[..], 8000000); [INFO] [stderr] | ^^^^^^^ help: consider: `8_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ln/channelmanager.rs:5960:75 [INFO] [stderr] | [INFO] [stderr] 5960 | let payment_preimage_1 = route_payment(&nodes[0], &vec!(&nodes[1])[..], 3000000).0; [INFO] [stderr] | ^^^^^^^ help: consider: `3_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ln/channelmanager.rs:5961:76 [INFO] [stderr] | [INFO] [stderr] 5961 | let _payment_preimage_2 = route_payment(&nodes[1], &vec!(&nodes[0])[..], 3000000).0; [INFO] [stderr] | ^^^^^^^ help: consider: `3_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ln/channelmanager.rs:5970:40 [INFO] [stderr] | [INFO] [stderr] 5970 | let header = BlockHeader { version: 0x20000000, prev_blockhash: Default::default(), merkle_root: Default::default(), time: 42, bits: 42, nonce: 42 }; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x2000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ln/channelmanager.rs:6027:42 [INFO] [stderr] | [INFO] [stderr] 6027 | route_payment(&nodes[0], &[&nodes[1]], 10000000); [INFO] [stderr] | ^^^^^^^^ help: consider: `10_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ln/channelmanager.rs:6043:39 [INFO] [stderr] | [INFO] [stderr] 6043 | let header = BlockHeader { version: 0x20000000, prev_blockhash: Default::default(), merkle_root: Default::default(), time: 42, bits: 42, nonce: 42 }; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x2000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ln/channelmanager.rs:6069:94 [INFO] [stderr] | [INFO] [stderr] 6069 | let route = nodes[0].router.get_route(&nodes[2].node.get_our_node_id(), None, &Vec::new(), 1000000, 42).unwrap(); [INFO] [stderr] | ^^^^^^^ help: consider: `1_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ln/channelmanager.rs:6129:39 [INFO] [stderr] | [INFO] [stderr] 6129 | let header = BlockHeader { version: 0x20000000, prev_blockhash: Default::default(), merkle_root: Default::default(), time: 42, bits: 42, nonce: 42 }; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x2000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ln/channelmanager.rs:6171:43 [INFO] [stderr] | [INFO] [stderr] 6171 | let mut header = BlockHeader { version: 0x20000000, prev_blockhash: Default::default(), merkle_root: Default::default(), time: 42, bits: 42, nonce: 42 }; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x2000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ln/channelmanager.rs:6174:36 [INFO] [stderr] | [INFO] [stderr] 6174 | header = BlockHeader { version: 0x20000000, prev_blockhash: header.bitcoin_hash(), merkle_root: Default::default(), time: 42, bits: 42, nonce: 42 }; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x2000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ln/channelmanager.rs:6425:86 [INFO] [stderr] | [INFO] [stderr] 6425 | let payment_preimage_1 = route_payment(&nodes[0], &vec!(&nodes[1], &nodes[2])[..], 1000000).0; [INFO] [stderr] | ^^^^^^^ help: consider: `1_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ln/channelmanager.rs:6426:82 [INFO] [stderr] | [INFO] [stderr] 6426 | let payment_hash_2 = route_payment(&nodes[0], &vec!(&nodes[1], &nodes[2])[..], 1000000).1; [INFO] [stderr] | ^^^^^^^ help: consider: `1_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ln/channelmanager.rs:6434:86 [INFO] [stderr] | [INFO] [stderr] 6434 | let payment_preimage_3 = route_payment(&nodes[0], &vec!(&nodes[1], &nodes[2])[..], 1000000).0; [INFO] [stderr] | ^^^^^^^ help: consider: `1_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ln/channelmanager.rs:6435:86 [INFO] [stderr] | [INFO] [stderr] 6435 | let payment_preimage_4 = route_payment(&nodes[0], &vec!(&nodes[1], &nodes[2])[..], 1000000).0; [INFO] [stderr] | ^^^^^^^ help: consider: `1_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ln/channelmanager.rs:6436:82 [INFO] [stderr] | [INFO] [stderr] 6436 | let payment_hash_5 = route_payment(&nodes[0], &vec!(&nodes[1], &nodes[2])[..], 1000000).1; [INFO] [stderr] | ^^^^^^^ help: consider: `1_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ln/channelmanager.rs:6437:82 [INFO] [stderr] | [INFO] [stderr] 6437 | let payment_hash_6 = route_payment(&nodes[0], &vec!(&nodes[1], &nodes[2])[..], 1000000).1; [INFO] [stderr] | ^^^^^^^ help: consider: `1_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ln/channelmanager.rs:6472:65 [INFO] [stderr] | [INFO] [stderr] 6472 | create_chan_between_nodes_with_value_a(&nodes[0], &nodes[1], 100000, 10001); [INFO] [stderr] | ^^^^^^ help: consider: `100_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ln/channelmanager.rs:6478:133 [INFO] [stderr] | [INFO] [stderr] 6478 | let route = nodes[0].router.get_route(&nodes[1].node.get_our_node_id(), Some(&nodes[0].node.list_usable_channels()), &Vec::new(), 1000000, TEST_FINAL_CLTV).unwrap(); [INFO] [stderr] | ^^^^^^^ help: consider: `1_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ln/channelmanager.rs:6560:21 [INFO] [stderr] | [INFO] [stderr] 6560 | assert_eq!(amt, 1000000); [INFO] [stderr] | ^^^^^^^ help: consider: `1_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ln/channelmanager.rs:6655:77 [INFO] [stderr] | [INFO] [stderr] 6655 | let payment_preimage_2 = send_along_route(&nodes[0], route, &[&nodes[1]], 1000000).0; [INFO] [stderr] | ^^^^^^^ help: consider: `1_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ln/channelmanager.rs:6678:76 [INFO] [stderr] | [INFO] [stderr] 6678 | let tx = create_chan_between_nodes_with_value_init(&nodes[0], &nodes[1], 100000, 10001); [INFO] [stderr] | ^^^^^^ help: consider: `100_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: You matched a field with a wildcard pattern. Consider using `..` instead [INFO] [stderr] --> src/ln/channelmanager.rs:6687:55 [INFO] [stderr] | [INFO] [stderr] 6687 | MessageSendEvent::SendFundingLocked { ref node_id, msg: _ } => { [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Try with `SendFundingLocked { ref node_id, .. }` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern [INFO] [stderr] [INFO] [stderr] warning: You matched a field with a wildcard pattern. Consider using `..` instead [INFO] [stderr] --> src/ln/channelmanager.rs:6702:55 [INFO] [stderr] | [INFO] [stderr] 6702 | MessageSendEvent::SendFundingLocked { ref node_id, msg: _ } => { [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Try with `SendFundingLocked { ref node_id, .. }` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern [INFO] [stderr] [INFO] [stderr] warning: You matched a field with a wildcard pattern. Consider using `..` instead [INFO] [stderr] --> src/ln/channelmanager.rs:6708:64 [INFO] [stderr] | [INFO] [stderr] 6708 | MessageSendEvent::SendAnnouncementSignatures { ref node_id, msg: _ } => { [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Try with `SendAnnouncementSignatures { ref node_id, .. }` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ln/channelmanager.rs:6719:133 [INFO] [stderr] | [INFO] [stderr] 6719 | let route = nodes[0].router.get_route(&nodes[1].node.get_our_node_id(), Some(&nodes[0].node.list_usable_channels()), &Vec::new(), 1000000, TEST_FINAL_CLTV).unwrap(); [INFO] [stderr] | ^^^^^^^ help: consider: `1_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ln/channelmanager.rs:6720:80 [INFO] [stderr] | [INFO] [stderr] 6720 | let (payment_preimage, _) = send_along_route(&nodes[0], route, &[&nodes[1]], 1000000); [INFO] [stderr] | ^^^^^^^ help: consider: `1_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ln/channelmanager.rs:6731:72 [INFO] [stderr] | [INFO] [stderr] 6731 | let (payment_preimage_1, _) = route_payment(&nodes[0], &[&nodes[1]], 1000000); [INFO] [stderr] | ^^^^^^^ help: consider: `1_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ln/channelmanager.rs:6734:94 [INFO] [stderr] | [INFO] [stderr] 6734 | let route = nodes[0].router.get_route(&nodes[1].node.get_our_node_id(), None, &Vec::new(), 1000000, TEST_FINAL_CLTV).unwrap(); [INFO] [stderr] | ^^^^^^^ help: consider: `1_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: You matched a field with a wildcard pattern. Consider using `..` instead [INFO] [stderr] --> src/ln/channelmanager.rs:6858:47 [INFO] [stderr] | [INFO] [stderr] 6858 | Event::PaymentReceived { ref payment_hash, amt: _ } => { [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Try with `PaymentReceived { ref payment_hash, .. }` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ln/channelmanager.rs:6877:94 [INFO] [stderr] | [INFO] [stderr] 6877 | let route = nodes[0].router.get_route(&nodes[1].node.get_our_node_id(), None, &Vec::new(), 1000000, TEST_FINAL_CLTV).unwrap(); [INFO] [stderr] | ^^^^^^^ help: consider: `1_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ln/channelmanager.rs:6903:94 [INFO] [stderr] | [INFO] [stderr] 6903 | let route = nodes[0].router.get_route(&nodes[1].node.get_our_node_id(), None, &Vec::new(), 1000000, TEST_FINAL_CLTV).unwrap(); [INFO] [stderr] | ^^^^^^^ help: consider: `1_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ln/channelmanager.rs:6938:21 [INFO] [stderr] | [INFO] [stderr] 6938 | assert_eq!(amt, 1000000); [INFO] [stderr] | ^^^^^^^ help: consider: `1_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ln/channelmanager.rs:7008:72 [INFO] [stderr] | [INFO] [stderr] 7008 | let (payment_preimage_1, _) = route_payment(&nodes[0], &[&nodes[1]], 1000000); [INFO] [stderr] | ^^^^^^^ help: consider: `1_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ln/channelmanager.rs:7011:94 [INFO] [stderr] | [INFO] [stderr] 7011 | let route = nodes[0].router.get_route(&nodes[1].node.get_our_node_id(), None, &Vec::new(), 1000000, TEST_FINAL_CLTV).unwrap(); [INFO] [stderr] | ^^^^^^^ help: consider: `1_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ln/channelmanager.rs:7293:21 [INFO] [stderr] | [INFO] [stderr] 7293 | assert_eq!(amt, 1000000); [INFO] [stderr] | ^^^^^^^ help: consider: `1_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ln/channelmanager.rs:7417:76 [INFO] [stderr] | [INFO] [stderr] 7417 | let tx = create_chan_between_nodes_with_value_init(&nodes[0], &nodes[1], 100000, 10001); [INFO] [stderr] | ^^^^^^ help: consider: `100_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ln/channelmanager.rs:7474:41 [INFO] [stderr] | [INFO] [stderr] 7474 | send_payment(&nodes[0], &[&nodes[1]], 1000000); [INFO] [stderr] | ^^^^^^^ help: consider: `1_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ln/channelmanager.rs:7482:74 [INFO] [stderr] | [INFO] [stderr] 7482 | let (our_payment_preimage, _) = route_payment(&nodes[0], &[&nodes[1]], 1000000); [INFO] [stderr] | ^^^^^^^ help: consider: `1_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ln/channelmanager.rs:7483:70 [INFO] [stderr] | [INFO] [stderr] 7483 | let (_, our_payment_hash) = route_payment(&nodes[0], &[&nodes[1]], 1000000); [INFO] [stderr] | ^^^^^^^ help: consider: `1_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ln/channelmanager.rs:7532:85 [INFO] [stderr] | [INFO] [stderr] 7532 | let (our_payment_preimage, _) = route_payment(&nodes[2], &[&nodes[0], &nodes[1]], 1000000); [INFO] [stderr] | ^^^^^^^ help: consider: `1_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ln/channelmanager.rs:7537:42 [INFO] [stderr] | [INFO] [stderr] 7537 | route_payment(&nodes[0], &[&nodes[3]], 1000000); [INFO] [stderr] | ^^^^^^^ help: consider: `1_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ln/channelmanager.rs:7754:75 [INFO] [stderr] | [INFO] [stderr] 7754 | let chan = create_announced_chan_between_nodes_with_value(&nodes, 0, 1, 100000, 99000000); [INFO] [stderr] | ^^^^^^ help: consider: `100_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ln/channelmanager.rs:7754:83 [INFO] [stderr] | [INFO] [stderr] 7754 | let chan = create_announced_chan_between_nodes_with_value(&nodes, 0, 1, 100000, 99000000); [INFO] [stderr] | ^^^^^^^^ help: consider: `99_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ln/channelmanager.rs:7766:39 [INFO] [stderr] | [INFO] [stderr] 7766 | let header = BlockHeader { version: 0x20000000, prev_blockhash: Default::default(), merkle_root: Default::default(), time: 42, bits: 42, nonce: 42 }; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x2000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ln/channelmanager.rs:7780:75 [INFO] [stderr] | [INFO] [stderr] 7780 | let chan = create_announced_chan_between_nodes_with_value(&nodes, 0, 1, 100000, 99000000); [INFO] [stderr] | ^^^^^^ help: consider: `100_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ln/channelmanager.rs:7780:83 [INFO] [stderr] | [INFO] [stderr] 7780 | let chan = create_announced_chan_between_nodes_with_value(&nodes, 0, 1, 100000, 99000000); [INFO] [stderr] | ^^^^^^^^ help: consider: `99_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ln/channelmanager.rs:7792:39 [INFO] [stderr] | [INFO] [stderr] 7792 | let header = BlockHeader { version: 0x20000000, prev_blockhash: Default::default(), merkle_root: Default::default(), time: 42, bits: 42, nonce: 42 }; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x2000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ln/channelmanager.rs:7812:73 [INFO] [stderr] | [INFO] [stderr] 7812 | let payment_preimage = route_payment(&nodes[0], &vec!(&nodes[1])[..], 3000000).0; [INFO] [stderr] | ^^^^^^^ help: consider: `3_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ln/channelmanager.rs:7819:39 [INFO] [stderr] | [INFO] [stderr] 7819 | let header = BlockHeader { version: 0x20000000, prev_blockhash: Default::default(), merkle_root: Default::default(), time: 42, bits: 42, nonce: 42 }; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x2000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ln/channelmanager.rs:7852:73 [INFO] [stderr] | [INFO] [stderr] 7852 | let payment_preimage = route_payment(&nodes[0], &vec!(&nodes[1])[..], 3000000).0; [INFO] [stderr] | ^^^^^^^ help: consider: `3_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ln/channelmanager.rs:7859:40 [INFO] [stderr] | [INFO] [stderr] 7859 | let header = BlockHeader { version: 0x20000000, prev_blockhash: Default::default(), merkle_root: Default::default(), time: 42, bits: 42, nonce: 42 }; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x2000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ln/channelmanager.rs:7884:73 [INFO] [stderr] | [INFO] [stderr] 7884 | let payment_preimage = route_payment(&nodes[0], &vec!(&nodes[1])[..], 3000000).0; [INFO] [stderr] | ^^^^^^^ help: consider: `3_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ln/channelmanager.rs:7891:39 [INFO] [stderr] | [INFO] [stderr] 7891 | let header = BlockHeader { version: 0x20000000, prev_blockhash: Default::default(), merkle_root: Default::default(), time: 42, bits: 42, nonce: 42 }; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x2000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ln/channelmanager.rs:7931:73 [INFO] [stderr] | [INFO] [stderr] 7931 | let payment_preimage = route_payment(&nodes[0], &vec!(&nodes[1])[..], 3000000).0; [INFO] [stderr] | ^^^^^^^ help: consider: `3_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ln/channelmanager.rs:7938:39 [INFO] [stderr] | [INFO] [stderr] 7938 | let header = BlockHeader { version: 0x20000000, prev_blockhash: Default::default(), merkle_root: Default::default(), time: 42, bits: 42, nonce: 42 }; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x2000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ln/channelmanager.rs:7979:73 [INFO] [stderr] | [INFO] [stderr] 7979 | let payment_preimage = route_payment(&nodes[0], &vec!(&nodes[1])[..], 9000000).0; [INFO] [stderr] | ^^^^^^^ help: consider: `9_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ln/channelmanager.rs:7987:39 [INFO] [stderr] | [INFO] [stderr] 7987 | let header = BlockHeader { version: 0x20000000, prev_blockhash: Default::default(), merkle_root: Default::default(), time: 42, bits: 42, nonce: 42 }; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x2000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ln/channelmanager.rs:8016:50 [INFO] [stderr] | [INFO] [stderr] 8016 | route_payment(&nodes[0], &vec!(&nodes[1])[..], 9000000).0; [INFO] [stderr] | ^^^^^^^ help: consider: `9_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ln/channelmanager.rs:8022:39 [INFO] [stderr] | [INFO] [stderr] 8022 | let header = BlockHeader { version: 0x20000000, prev_blockhash: Default::default(), merkle_root: Default::default(), time: 42, bits: 42, nonce: 42 }; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x2000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ln/channelmanager.rs:8049:49 [INFO] [stderr] | [INFO] [stderr] 8049 | send_payment(&nodes[0], &vec!(&nodes[1])[..], 8000000); [INFO] [stderr] | ^^^^^^^ help: consider: `8_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ln/channelmanager.rs:8052:39 [INFO] [stderr] | [INFO] [stderr] 8052 | let header = BlockHeader { version: 0x20000000, prev_blockhash: Default::default(), merkle_root: Default::default(), time: 42, bits: 42, nonce: 42 }; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x2000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ln/channelmonitor.rs:558:33 [INFO] [stderr] | [INFO] [stderr] 558 | let our_commitment_number = 0xffffffffffff - ((((local_tx.tx.input[0].sequence as u64 & 0xffffff) << 3*8) | (local_tx.tx.lock_time as u64 & 0xffffff)) ^ self.commitment_transaction_number_obscure_factor); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: consider: `0xffff_ffff_ffff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: operator precedence can trip the unwary [INFO] [stderr] --> src/ln/channelmonitor.rs:558:53 [INFO] [stderr] | [INFO] [stderr] 558 | let our_commitment_number = 0xffffffffffff - ((((local_tx.tx.input[0].sequence as u64 & 0xffffff) << 3*8) | (local_tx.tx.lock_time as u64 & 0xffffff)) ^ self.commitment_transaction_number_obscure_factor); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider parenthesizing your expression: `(local_tx.tx.input[0].sequence as u64 & 0xffffff) << (3*8)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ln/channelmonitor.rs:558:93 [INFO] [stderr] | [INFO] [stderr] 558 | let our_commitment_number = 0xffffffffffff - ((((local_tx.tx.input[0].sequence as u64 & 0xffffff) << 3*8) | (local_tx.tx.lock_time as u64 & 0xffffff)) ^ self.commitment_transaction_number_obscure_factor); [INFO] [stderr] | ^^^^^^^^ help: consider: `0x00ff_ffff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ln/channelmonitor.rs:558:145 [INFO] [stderr] | [INFO] [stderr] 558 | let our_commitment_number = 0xffffffffffff - ((((local_tx.tx.input[0].sequence as u64 & 0xffffff) << 3*8) | (local_tx.tx.lock_time as u64 & 0xffffff)) ^ self.commitment_transaction_number_obscure_factor); [INFO] [stderr] | ^^^^^^^^ help: consider: `0x00ff_ffff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ln/channelmonitor.rs:559:35 [INFO] [stderr] | [INFO] [stderr] 559 | let other_commitment_number = 0xffffffffffff - ((((other_local_tx.tx.input[0].sequence as u64 & 0xffffff) << 3*8) | (other_local_tx.tx.lock_time as u64 & 0xffffff)) ^ other.commitment_transaction_number_obscure_factor); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: consider: `0xffff_ffff_ffff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: operator precedence can trip the unwary [INFO] [stderr] --> src/ln/channelmonitor.rs:559:55 [INFO] [stderr] | [INFO] [stderr] 559 | let other_commitment_number = 0xffffffffffff - ((((other_local_tx.tx.input[0].sequence as u64 & 0xffffff) << 3*8) | (other_local_tx.tx.lock_time as u64 & 0xffffff)) ^ other.commitment_transaction_number_obscure_factor); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider parenthesizing your expression: `(other_local_tx.tx.input[0].sequence as u64 & 0xffffff) << (3*8)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ln/channelmonitor.rs:559:101 [INFO] [stderr] | [INFO] [stderr] 559 | let other_commitment_number = 0xffffffffffff - ((((other_local_tx.tx.input[0].sequence as u64 & 0xffffff) << 3*8) | (other_local_tx.tx.lock_time as u64 & 0xffffff)) ^ other.commitment_transaction_number_obscure_factor); [INFO] [stderr] | ^^^^^^^^ help: consider: `0x00ff_ffff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ln/channelmonitor.rs:559:159 [INFO] [stderr] | [INFO] [stderr] 559 | let other_commitment_number = 0xffffffffffff - ((((other_local_tx.tx.input[0].sequence as u64 & 0xffffff) << 3*8) | (other_local_tx.tx.lock_time as u64 & 0xffffff)) ^ other.commitment_transaction_number_obscure_factor); [INFO] [stderr] | ^^^^^^^^ help: consider: `0x00ff_ffff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: operator precedence can trip the unwary [INFO] [stderr] --> src/ln/channelmonitor.rs:861:26 [INFO] [stderr] | [INFO] [stderr] 861 | 0xffff_ffff_ffff - ((((local_tx.tx.input[0].sequence as u64 & 0xffffff) << 3*8) | (local_tx.tx.lock_time as u64 & 0xffffff)) ^ self.commitment_transaction_number_obscure_factor) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider parenthesizing your expression: `(local_tx.tx.input[0].sequence as u64 & 0xffffff) << (3*8)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ln/channelmonitor.rs:861:66 [INFO] [stderr] | [INFO] [stderr] 861 | 0xffff_ffff_ffff - ((((local_tx.tx.input[0].sequence as u64 & 0xffffff) << 3*8) | (local_tx.tx.lock_time as u64 & 0xffffff)) ^ self.commitment_transaction_number_obscure_factor) [INFO] [stderr] | ^^^^^^^^ help: consider: `0x00ff_ffff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ln/channelmonitor.rs:861:118 [INFO] [stderr] | [INFO] [stderr] 861 | 0xffff_ffff_ffff - ((((local_tx.tx.input[0].sequence as u64 & 0xffffff) << 3*8) | (local_tx.tx.lock_time as u64 & 0xffffff)) ^ self.commitment_transaction_number_obscure_factor) [INFO] [stderr] | ^^^^^^^^ help: consider: `0x00ff_ffff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ln/channelmonitor.rs:888:27 [INFO] [stderr] | [INFO] [stderr] 888 | let commitment_number = 0xffffffffffff - ((((tx.input[0].sequence as u64 & 0xffffff) << 3*8) | (tx.lock_time as u64 & 0xffffff)) ^ self.commitment_transaction_number_obscure_factor); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: consider: `0xffff_ffff_ffff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: operator precedence can trip the unwary [INFO] [stderr] --> src/ln/channelmonitor.rs:888:47 [INFO] [stderr] | [INFO] [stderr] 888 | let commitment_number = 0xffffffffffff - ((((tx.input[0].sequence as u64 & 0xffffff) << 3*8) | (tx.lock_time as u64 & 0xffffff)) ^ self.commitment_transaction_number_obscure_factor); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider parenthesizing your expression: `(tx.input[0].sequence as u64 & 0xffffff) << (3*8)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ln/channelmonitor.rs:888:78 [INFO] [stderr] | [INFO] [stderr] 888 | let commitment_number = 0xffffffffffff - ((((tx.input[0].sequence as u64 & 0xffffff) << 3*8) | (tx.lock_time as u64 & 0xffffff)) ^ self.commitment_transaction_number_obscure_factor); [INFO] [stderr] | ^^^^^^^^ help: consider: `0x00ff_ffff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ln/channelmonitor.rs:888:121 [INFO] [stderr] | [INFO] [stderr] 888 | let commitment_number = 0xffffffffffff - ((((tx.input[0].sequence as u64 & 0xffffff) << 3*8) | (tx.lock_time as u64 & 0xffffff)) ^ self.commitment_transaction_number_obscure_factor); [INFO] [stderr] | ^^^^^^^^ help: consider: `0x00ff_ffff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ln/channelmonitor.rs:935:17 [INFO] [stderr] | [INFO] [stderr] 935 | sequence: 0xfffffffd, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xffff_fffd` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ln/channelmonitor.rs:995:17 [INFO] [stderr] | [INFO] [stderr] 995 | sequence: 0xfffffffd, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xffff_fffd` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ln/channelmonitor.rs:1242:15 [INFO] [stderr] | [INFO] [stderr] 1242 | sequence: 0xfffffffd, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xffff_fffd` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/ln/channelmonitor.rs:1332:11 [INFO] [stderr] | [INFO] [stderr] 1332 | } else { [INFO] [stderr] | ____________________^ [INFO] [stderr] 1333 | | if let Some(payment_preimage) = self.payment_preimages.get(&htlc.payment_hash) { [INFO] [stderr] 1334 | | let mut htlc_success_tx = chan_utils::build_htlc_transaction(&local_tx.txid, local_tx.feerate_per_kw, self.their_to_self_delay.unwrap(), htlc, &local_tx.delayed_payment_key, &local_tx.revocation_key); [INFO] [stderr] 1335 | | [INFO] [stderr] ... | [INFO] [stderr] 1348 | | } [INFO] [stderr] 1349 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 1332 | } else if let Some(payment_preimage) = self.payment_preimages.get(&htlc.payment_hash) { [INFO] [stderr] 1333 | let mut htlc_success_tx = chan_utils::build_htlc_transaction(&local_tx.txid, local_tx.feerate_per_kw, self.their_to_self_delay.unwrap(), htlc, &local_tx.delayed_payment_key, &local_tx.revocation_key); [INFO] [stderr] 1334 | [INFO] [stderr] 1335 | htlc_success_tx.input[0].witness.push(Vec::new()); // First is the multisig dummy [INFO] [stderr] 1336 | [INFO] [stderr] 1337 | htlc_success_tx.input[0].witness.push(their_sig.serialize_der(&self.secp_ctx).to_vec()); [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ln/channelmonitor.rs:1389:30 [INFO] [stderr] | [INFO] [stderr] 1389 | if tx.input[0].sequence == 0xFFFFFFFF && tx.input[0].witness.last().unwrap().len() == 71 { [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xFFFF_FFFF` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/ln/channelmonitor.rs:1457:12 [INFO] [stderr] | [INFO] [stderr] 1457 | } else { [INFO] [stderr] | ________________________^ [INFO] [stderr] 1458 | | if let Some(&(commitment_number, _)) = self.remote_commitment_txn_on_chain.get(&prevout.txid) { [INFO] [stderr] 1459 | | let (tx, spendable_output) = self.check_spend_remote_htlc(tx, commitment_number); [INFO] [stderr] 1460 | | if let Some(tx) = tx { [INFO] [stderr] ... | [INFO] [stderr] 1466 | | } [INFO] [stderr] 1467 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 1457 | } else if let Some(&(commitment_number, _)) = self.remote_commitment_txn_on_chain.get(&prevout.txid) { [INFO] [stderr] 1458 | let (tx, spendable_output) = self.check_spend_remote_htlc(tx, commitment_number); [INFO] [stderr] 1459 | if let Some(tx) = tx { [INFO] [stderr] 1460 | txn.push(tx); [INFO] [stderr] 1461 | } [INFO] [stderr] 1462 | if let Some(spendable_output) = spendable_output { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ln/channelmonitor.rs:1817:27 [INFO] [stderr] | [INFO] [stderr] 1817 | monitor.provide_secret(281474976710655, secrets.last().unwrap().clone()).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider: `281_474_976_710_655` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ln/channelmonitor.rs:1800:19 [INFO] [stderr] | [INFO] [stderr] 1800 | let mut idx = 281474976710655; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider: `281_474_976_710_655` [INFO] [stderr] ... [INFO] [stderr] 1818 | test_secrets!(); [INFO] [stderr] | ---------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ln/channelmonitor.rs:1822:27 [INFO] [stderr] | [INFO] [stderr] 1822 | monitor.provide_secret(281474976710654, secrets.last().unwrap().clone()).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider: `281_474_976_710_654` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ln/channelmonitor.rs:1800:19 [INFO] [stderr] | [INFO] [stderr] 1800 | let mut idx = 281474976710655; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider: `281_474_976_710_655` [INFO] [stderr] ... [INFO] [stderr] 1823 | test_secrets!(); [INFO] [stderr] | ---------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ln/channelmonitor.rs:1827:27 [INFO] [stderr] | [INFO] [stderr] 1827 | monitor.provide_secret(281474976710653, secrets.last().unwrap().clone()).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider: `281_474_976_710_653` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ln/channelmonitor.rs:1800:19 [INFO] [stderr] | [INFO] [stderr] 1800 | let mut idx = 281474976710655; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider: `281_474_976_710_655` [INFO] [stderr] ... [INFO] [stderr] 1828 | test_secrets!(); [INFO] [stderr] | ---------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ln/channelmonitor.rs:1832:27 [INFO] [stderr] | [INFO] [stderr] 1832 | monitor.provide_secret(281474976710652, secrets.last().unwrap().clone()).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider: `281_474_976_710_652` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ln/channelmonitor.rs:1800:19 [INFO] [stderr] | [INFO] [stderr] 1800 | let mut idx = 281474976710655; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider: `281_474_976_710_655` [INFO] [stderr] ... [INFO] [stderr] 1833 | test_secrets!(); [INFO] [stderr] | ---------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ln/channelmonitor.rs:1837:27 [INFO] [stderr] | [INFO] [stderr] 1837 | monitor.provide_secret(281474976710651, secrets.last().unwrap().clone()).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider: `281_474_976_710_651` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ln/channelmonitor.rs:1800:19 [INFO] [stderr] | [INFO] [stderr] 1800 | let mut idx = 281474976710655; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider: `281_474_976_710_655` [INFO] [stderr] ... [INFO] [stderr] 1838 | test_secrets!(); [INFO] [stderr] | ---------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ln/channelmonitor.rs:1842:27 [INFO] [stderr] | [INFO] [stderr] 1842 | monitor.provide_secret(281474976710650, secrets.last().unwrap().clone()).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider: `281_474_976_710_650` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ln/channelmonitor.rs:1800:19 [INFO] [stderr] | [INFO] [stderr] 1800 | let mut idx = 281474976710655; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider: `281_474_976_710_655` [INFO] [stderr] ... [INFO] [stderr] 1843 | test_secrets!(); [INFO] [stderr] | ---------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ln/channelmonitor.rs:1847:27 [INFO] [stderr] | [INFO] [stderr] 1847 | monitor.provide_secret(281474976710649, secrets.last().unwrap().clone()).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider: `281_474_976_710_649` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ln/channelmonitor.rs:1800:19 [INFO] [stderr] | [INFO] [stderr] 1800 | let mut idx = 281474976710655; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider: `281_474_976_710_655` [INFO] [stderr] ... [INFO] [stderr] 1848 | test_secrets!(); [INFO] [stderr] | ---------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ln/channelmonitor.rs:1852:27 [INFO] [stderr] | [INFO] [stderr] 1852 | monitor.provide_secret(281474976710648, secrets.last().unwrap().clone()).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider: `281_474_976_710_648` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ln/channelmonitor.rs:1800:19 [INFO] [stderr] | [INFO] [stderr] 1800 | let mut idx = 281474976710655; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider: `281_474_976_710_655` [INFO] [stderr] ... [INFO] [stderr] 1853 | test_secrets!(); [INFO] [stderr] | ---------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ln/channelmonitor.rs:1863:27 [INFO] [stderr] | [INFO] [stderr] 1863 | monitor.provide_secret(281474976710655, secrets.last().unwrap().clone()).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider: `281_474_976_710_655` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ln/channelmonitor.rs:1800:19 [INFO] [stderr] | [INFO] [stderr] 1800 | let mut idx = 281474976710655; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider: `281_474_976_710_655` [INFO] [stderr] ... [INFO] [stderr] 1864 | test_secrets!(); [INFO] [stderr] | ---------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ln/channelmonitor.rs:1868:38 [INFO] [stderr] | [INFO] [stderr] 1868 | assert_eq!(monitor.provide_secret(281474976710654, secrets.last().unwrap().clone()).unwrap_err().0, [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider: `281_474_976_710_654` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ln/channelmonitor.rs:1879:27 [INFO] [stderr] | [INFO] [stderr] 1879 | monitor.provide_secret(281474976710655, secrets.last().unwrap().clone()).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider: `281_474_976_710_655` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ln/channelmonitor.rs:1800:19 [INFO] [stderr] | [INFO] [stderr] 1800 | let mut idx = 281474976710655; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider: `281_474_976_710_655` [INFO] [stderr] ... [INFO] [stderr] 1880 | test_secrets!(); [INFO] [stderr] | ---------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ln/channelmonitor.rs:1884:27 [INFO] [stderr] | [INFO] [stderr] 1884 | monitor.provide_secret(281474976710654, secrets.last().unwrap().clone()).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider: `281_474_976_710_654` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ln/channelmonitor.rs:1800:19 [INFO] [stderr] | [INFO] [stderr] 1800 | let mut idx = 281474976710655; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider: `281_474_976_710_655` [INFO] [stderr] ... [INFO] [stderr] 1885 | test_secrets!(); [INFO] [stderr] | ---------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ln/channelmonitor.rs:1889:27 [INFO] [stderr] | [INFO] [stderr] 1889 | monitor.provide_secret(281474976710653, secrets.last().unwrap().clone()).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider: `281_474_976_710_653` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ln/channelmonitor.rs:1800:19 [INFO] [stderr] | [INFO] [stderr] 1800 | let mut idx = 281474976710655; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider: `281_474_976_710_655` [INFO] [stderr] ... [INFO] [stderr] 1890 | test_secrets!(); [INFO] [stderr] | ---------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ln/channelmonitor.rs:1894:38 [INFO] [stderr] | [INFO] [stderr] 1894 | assert_eq!(monitor.provide_secret(281474976710652, secrets.last().unwrap().clone()).unwrap_err().0, [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider: `281_474_976_710_652` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ln/channelmonitor.rs:1905:27 [INFO] [stderr] | [INFO] [stderr] 1905 | monitor.provide_secret(281474976710655, secrets.last().unwrap().clone()).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider: `281_474_976_710_655` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ln/channelmonitor.rs:1800:19 [INFO] [stderr] | [INFO] [stderr] 1800 | let mut idx = 281474976710655; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider: `281_474_976_710_655` [INFO] [stderr] ... [INFO] [stderr] 1906 | test_secrets!(); [INFO] [stderr] | ---------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ln/channelmonitor.rs:1910:27 [INFO] [stderr] | [INFO] [stderr] 1910 | monitor.provide_secret(281474976710654, secrets.last().unwrap().clone()).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider: `281_474_976_710_654` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ln/channelmonitor.rs:1800:19 [INFO] [stderr] | [INFO] [stderr] 1800 | let mut idx = 281474976710655; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider: `281_474_976_710_655` [INFO] [stderr] ... [INFO] [stderr] 1911 | test_secrets!(); [INFO] [stderr] | ---------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ln/channelmonitor.rs:1915:27 [INFO] [stderr] | [INFO] [stderr] 1915 | monitor.provide_secret(281474976710653, secrets.last().unwrap().clone()).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider: `281_474_976_710_653` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ln/channelmonitor.rs:1800:19 [INFO] [stderr] | [INFO] [stderr] 1800 | let mut idx = 281474976710655; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider: `281_474_976_710_655` [INFO] [stderr] ... [INFO] [stderr] 1916 | test_secrets!(); [INFO] [stderr] | ---------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ln/channelmonitor.rs:1920:38 [INFO] [stderr] | [INFO] [stderr] 1920 | assert_eq!(monitor.provide_secret(281474976710652, secrets.last().unwrap().clone()).unwrap_err().0, [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider: `281_474_976_710_652` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ln/channelmonitor.rs:1931:27 [INFO] [stderr] | [INFO] [stderr] 1931 | monitor.provide_secret(281474976710655, secrets.last().unwrap().clone()).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider: `281_474_976_710_655` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ln/channelmonitor.rs:1800:19 [INFO] [stderr] | [INFO] [stderr] 1800 | let mut idx = 281474976710655; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider: `281_474_976_710_655` [INFO] [stderr] ... [INFO] [stderr] 1932 | test_secrets!(); [INFO] [stderr] | ---------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ln/channelmonitor.rs:1936:27 [INFO] [stderr] | [INFO] [stderr] 1936 | monitor.provide_secret(281474976710654, secrets.last().unwrap().clone()).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider: `281_474_976_710_654` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ln/channelmonitor.rs:1800:19 [INFO] [stderr] | [INFO] [stderr] 1800 | let mut idx = 281474976710655; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider: `281_474_976_710_655` [INFO] [stderr] ... [INFO] [stderr] 1937 | test_secrets!(); [INFO] [stderr] | ---------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ln/channelmonitor.rs:1941:27 [INFO] [stderr] | [INFO] [stderr] 1941 | monitor.provide_secret(281474976710653, secrets.last().unwrap().clone()).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider: `281_474_976_710_653` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ln/channelmonitor.rs:1800:19 [INFO] [stderr] | [INFO] [stderr] 1800 | let mut idx = 281474976710655; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider: `281_474_976_710_655` [INFO] [stderr] ... [INFO] [stderr] 1942 | test_secrets!(); [INFO] [stderr] | ---------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ln/channelmonitor.rs:1946:27 [INFO] [stderr] | [INFO] [stderr] 1946 | monitor.provide_secret(281474976710652, secrets.last().unwrap().clone()).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider: `281_474_976_710_652` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ln/channelmonitor.rs:1800:19 [INFO] [stderr] | [INFO] [stderr] 1800 | let mut idx = 281474976710655; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider: `281_474_976_710_655` [INFO] [stderr] ... [INFO] [stderr] 1947 | test_secrets!(); [INFO] [stderr] | ---------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ln/channelmonitor.rs:1951:27 [INFO] [stderr] | [INFO] [stderr] 1951 | monitor.provide_secret(281474976710651, secrets.last().unwrap().clone()).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider: `281_474_976_710_651` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ln/channelmonitor.rs:1800:19 [INFO] [stderr] | [INFO] [stderr] 1800 | let mut idx = 281474976710655; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider: `281_474_976_710_655` [INFO] [stderr] ... [INFO] [stderr] 1952 | test_secrets!(); [INFO] [stderr] | ---------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ln/channelmonitor.rs:1956:27 [INFO] [stderr] | [INFO] [stderr] 1956 | monitor.provide_secret(281474976710650, secrets.last().unwrap().clone()).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider: `281_474_976_710_650` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ln/channelmonitor.rs:1800:19 [INFO] [stderr] | [INFO] [stderr] 1800 | let mut idx = 281474976710655; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider: `281_474_976_710_655` [INFO] [stderr] ... [INFO] [stderr] 1957 | test_secrets!(); [INFO] [stderr] | ---------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ln/channelmonitor.rs:1961:27 [INFO] [stderr] | [INFO] [stderr] 1961 | monitor.provide_secret(281474976710649, secrets.last().unwrap().clone()).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider: `281_474_976_710_649` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ln/channelmonitor.rs:1800:19 [INFO] [stderr] | [INFO] [stderr] 1800 | let mut idx = 281474976710655; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider: `281_474_976_710_655` [INFO] [stderr] ... [INFO] [stderr] 1962 | test_secrets!(); [INFO] [stderr] | ---------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ln/channelmonitor.rs:1966:38 [INFO] [stderr] | [INFO] [stderr] 1966 | assert_eq!(monitor.provide_secret(281474976710648, secrets.last().unwrap().clone()).unwrap_err().0, [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider: `281_474_976_710_648` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ln/channelmonitor.rs:1977:27 [INFO] [stderr] | [INFO] [stderr] 1977 | monitor.provide_secret(281474976710655, secrets.last().unwrap().clone()).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider: `281_474_976_710_655` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ln/channelmonitor.rs:1800:19 [INFO] [stderr] | [INFO] [stderr] 1800 | let mut idx = 281474976710655; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider: `281_474_976_710_655` [INFO] [stderr] ... [INFO] [stderr] 1978 | test_secrets!(); [INFO] [stderr] | ---------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ln/channelmonitor.rs:1982:27 [INFO] [stderr] | [INFO] [stderr] 1982 | monitor.provide_secret(281474976710654, secrets.last().unwrap().clone()).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider: `281_474_976_710_654` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ln/channelmonitor.rs:1800:19 [INFO] [stderr] | [INFO] [stderr] 1800 | let mut idx = 281474976710655; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider: `281_474_976_710_655` [INFO] [stderr] ... [INFO] [stderr] 1983 | test_secrets!(); [INFO] [stderr] | ---------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ln/channelmonitor.rs:1987:27 [INFO] [stderr] | [INFO] [stderr] 1987 | monitor.provide_secret(281474976710653, secrets.last().unwrap().clone()).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider: `281_474_976_710_653` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ln/channelmonitor.rs:1800:19 [INFO] [stderr] | [INFO] [stderr] 1800 | let mut idx = 281474976710655; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider: `281_474_976_710_655` [INFO] [stderr] ... [INFO] [stderr] 1988 | test_secrets!(); [INFO] [stderr] | ---------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ln/channelmonitor.rs:1992:27 [INFO] [stderr] | [INFO] [stderr] 1992 | monitor.provide_secret(281474976710652, secrets.last().unwrap().clone()).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider: `281_474_976_710_652` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ln/channelmonitor.rs:1800:19 [INFO] [stderr] | [INFO] [stderr] 1800 | let mut idx = 281474976710655; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider: `281_474_976_710_655` [INFO] [stderr] ... [INFO] [stderr] 1993 | test_secrets!(); [INFO] [stderr] | ---------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ln/channelmonitor.rs:1997:27 [INFO] [stderr] | [INFO] [stderr] 1997 | monitor.provide_secret(281474976710651, secrets.last().unwrap().clone()).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider: `281_474_976_710_651` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ln/channelmonitor.rs:1800:19 [INFO] [stderr] | [INFO] [stderr] 1800 | let mut idx = 281474976710655; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider: `281_474_976_710_655` [INFO] [stderr] ... [INFO] [stderr] 1998 | test_secrets!(); [INFO] [stderr] | ---------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ln/channelmonitor.rs:2002:38 [INFO] [stderr] | [INFO] [stderr] 2002 | assert_eq!(monitor.provide_secret(281474976710650, secrets.last().unwrap().clone()).unwrap_err().0, [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider: `281_474_976_710_650` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ln/channelmonitor.rs:2013:27 [INFO] [stderr] | [INFO] [stderr] 2013 | monitor.provide_secret(281474976710655, secrets.last().unwrap().clone()).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider: `281_474_976_710_655` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ln/channelmonitor.rs:1800:19 [INFO] [stderr] | [INFO] [stderr] 1800 | let mut idx = 281474976710655; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider: `281_474_976_710_655` [INFO] [stderr] ... [INFO] [stderr] 2014 | test_secrets!(); [INFO] [stderr] | ---------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ln/channelmonitor.rs:2018:27 [INFO] [stderr] | [INFO] [stderr] 2018 | monitor.provide_secret(281474976710654, secrets.last().unwrap().clone()).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider: `281_474_976_710_654` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ln/channelmonitor.rs:1800:19 [INFO] [stderr] | [INFO] [stderr] 1800 | let mut idx = 281474976710655; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider: `281_474_976_710_655` [INFO] [stderr] ... [INFO] [stderr] 2019 | test_secrets!(); [INFO] [stderr] | ---------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ln/channelmonitor.rs:2023:27 [INFO] [stderr] | [INFO] [stderr] 2023 | monitor.provide_secret(281474976710653, secrets.last().unwrap().clone()).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider: `281_474_976_710_653` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ln/channelmonitor.rs:1800:19 [INFO] [stderr] | [INFO] [stderr] 1800 | let mut idx = 281474976710655; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider: `281_474_976_710_655` [INFO] [stderr] ... [INFO] [stderr] 2024 | test_secrets!(); [INFO] [stderr] | ---------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ln/channelmonitor.rs:2028:27 [INFO] [stderr] | [INFO] [stderr] 2028 | monitor.provide_secret(281474976710652, secrets.last().unwrap().clone()).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider: `281_474_976_710_652` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ln/channelmonitor.rs:1800:19 [INFO] [stderr] | [INFO] [stderr] 1800 | let mut idx = 281474976710655; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider: `281_474_976_710_655` [INFO] [stderr] ... [INFO] [stderr] 2029 | test_secrets!(); [INFO] [stderr] | ---------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ln/channelmonitor.rs:2033:27 [INFO] [stderr] | [INFO] [stderr] 2033 | monitor.provide_secret(281474976710651, secrets.last().unwrap().clone()).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider: `281_474_976_710_651` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ln/channelmonitor.rs:1800:19 [INFO] [stderr] | [INFO] [stderr] 1800 | let mut idx = 281474976710655; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider: `281_474_976_710_655` [INFO] [stderr] ... [INFO] [stderr] 2034 | test_secrets!(); [INFO] [stderr] | ---------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ln/channelmonitor.rs:2038:27 [INFO] [stderr] | [INFO] [stderr] 2038 | monitor.provide_secret(281474976710650, secrets.last().unwrap().clone()).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider: `281_474_976_710_650` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ln/channelmonitor.rs:1800:19 [INFO] [stderr] | [INFO] [stderr] 1800 | let mut idx = 281474976710655; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider: `281_474_976_710_655` [INFO] [stderr] ... [INFO] [stderr] 2039 | test_secrets!(); [INFO] [stderr] | ---------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ln/channelmonitor.rs:2043:27 [INFO] [stderr] | [INFO] [stderr] 2043 | monitor.provide_secret(281474976710649, secrets.last().unwrap().clone()).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider: `281_474_976_710_649` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ln/channelmonitor.rs:1800:19 [INFO] [stderr] | [INFO] [stderr] 1800 | let mut idx = 281474976710655; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider: `281_474_976_710_655` [INFO] [stderr] ... [INFO] [stderr] 2044 | test_secrets!(); [INFO] [stderr] | ---------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ln/channelmonitor.rs:2048:38 [INFO] [stderr] | [INFO] [stderr] 2048 | assert_eq!(monitor.provide_secret(281474976710648, secrets.last().unwrap().clone()).unwrap_err().0, [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider: `281_474_976_710_648` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ln/channelmonitor.rs:2059:27 [INFO] [stderr] | [INFO] [stderr] 2059 | monitor.provide_secret(281474976710655, secrets.last().unwrap().clone()).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider: `281_474_976_710_655` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ln/channelmonitor.rs:1800:19 [INFO] [stderr] | [INFO] [stderr] 1800 | let mut idx = 281474976710655; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider: `281_474_976_710_655` [INFO] [stderr] ... [INFO] [stderr] 2060 | test_secrets!(); [INFO] [stderr] | ---------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ln/channelmonitor.rs:2064:27 [INFO] [stderr] | [INFO] [stderr] 2064 | monitor.provide_secret(281474976710654, secrets.last().unwrap().clone()).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider: `281_474_976_710_654` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ln/channelmonitor.rs:1800:19 [INFO] [stderr] | [INFO] [stderr] 1800 | let mut idx = 281474976710655; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider: `281_474_976_710_655` [INFO] [stderr] ... [INFO] [stderr] 2065 | test_secrets!(); [INFO] [stderr] | ---------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ln/channelmonitor.rs:2069:27 [INFO] [stderr] | [INFO] [stderr] 2069 | monitor.provide_secret(281474976710653, secrets.last().unwrap().clone()).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider: `281_474_976_710_653` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ln/channelmonitor.rs:1800:19 [INFO] [stderr] | [INFO] [stderr] 1800 | let mut idx = 281474976710655; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider: `281_474_976_710_655` [INFO] [stderr] ... [INFO] [stderr] 2070 | test_secrets!(); [INFO] [stderr] | ---------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ln/channelmonitor.rs:2074:27 [INFO] [stderr] | [INFO] [stderr] 2074 | monitor.provide_secret(281474976710652, secrets.last().unwrap().clone()).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider: `281_474_976_710_652` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ln/channelmonitor.rs:1800:19 [INFO] [stderr] | [INFO] [stderr] 1800 | let mut idx = 281474976710655; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider: `281_474_976_710_655` [INFO] [stderr] ... [INFO] [stderr] 2075 | test_secrets!(); [INFO] [stderr] | ---------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ln/channelmonitor.rs:2079:27 [INFO] [stderr] | [INFO] [stderr] 2079 | monitor.provide_secret(281474976710651, secrets.last().unwrap().clone()).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider: `281_474_976_710_651` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ln/channelmonitor.rs:1800:19 [INFO] [stderr] | [INFO] [stderr] 1800 | let mut idx = 281474976710655; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider: `281_474_976_710_655` [INFO] [stderr] ... [INFO] [stderr] 2080 | test_secrets!(); [INFO] [stderr] | ---------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ln/channelmonitor.rs:2084:27 [INFO] [stderr] | [INFO] [stderr] 2084 | monitor.provide_secret(281474976710650, secrets.last().unwrap().clone()).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider: `281_474_976_710_650` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ln/channelmonitor.rs:1800:19 [INFO] [stderr] | [INFO] [stderr] 1800 | let mut idx = 281474976710655; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider: `281_474_976_710_655` [INFO] [stderr] ... [INFO] [stderr] 2085 | test_secrets!(); [INFO] [stderr] | ---------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ln/channelmonitor.rs:2089:27 [INFO] [stderr] | [INFO] [stderr] 2089 | monitor.provide_secret(281474976710649, secrets.last().unwrap().clone()).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider: `281_474_976_710_649` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ln/channelmonitor.rs:1800:19 [INFO] [stderr] | [INFO] [stderr] 1800 | let mut idx = 281474976710655; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider: `281_474_976_710_655` [INFO] [stderr] ... [INFO] [stderr] 2090 | test_secrets!(); [INFO] [stderr] | ---------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ln/channelmonitor.rs:2094:38 [INFO] [stderr] | [INFO] [stderr] 2094 | assert_eq!(monitor.provide_secret(281474976710648, secrets.last().unwrap().clone()).unwrap_err().0, [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider: `281_474_976_710_648` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ln/channelmonitor.rs:2105:27 [INFO] [stderr] | [INFO] [stderr] 2105 | monitor.provide_secret(281474976710655, secrets.last().unwrap().clone()).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider: `281_474_976_710_655` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ln/channelmonitor.rs:1800:19 [INFO] [stderr] | [INFO] [stderr] 1800 | let mut idx = 281474976710655; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider: `281_474_976_710_655` [INFO] [stderr] ... [INFO] [stderr] 2106 | test_secrets!(); [INFO] [stderr] | ---------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ln/channelmonitor.rs:2110:27 [INFO] [stderr] | [INFO] [stderr] 2110 | monitor.provide_secret(281474976710654, secrets.last().unwrap().clone()).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider: `281_474_976_710_654` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ln/channelmonitor.rs:1800:19 [INFO] [stderr] | [INFO] [stderr] 1800 | let mut idx = 281474976710655; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider: `281_474_976_710_655` [INFO] [stderr] ... [INFO] [stderr] 2111 | test_secrets!(); [INFO] [stderr] | ---------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ln/channelmonitor.rs:2115:27 [INFO] [stderr] | [INFO] [stderr] 2115 | monitor.provide_secret(281474976710653, secrets.last().unwrap().clone()).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider: `281_474_976_710_653` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ln/channelmonitor.rs:1800:19 [INFO] [stderr] | [INFO] [stderr] 1800 | let mut idx = 281474976710655; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider: `281_474_976_710_655` [INFO] [stderr] ... [INFO] [stderr] 2116 | test_secrets!(); [INFO] [stderr] | ---------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ln/channelmonitor.rs:2120:27 [INFO] [stderr] | [INFO] [stderr] 2120 | monitor.provide_secret(281474976710652, secrets.last().unwrap().clone()).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider: `281_474_976_710_652` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ln/channelmonitor.rs:1800:19 [INFO] [stderr] | [INFO] [stderr] 1800 | let mut idx = 281474976710655; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider: `281_474_976_710_655` [INFO] [stderr] ... [INFO] [stderr] 2121 | test_secrets!(); [INFO] [stderr] | ---------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ln/channelmonitor.rs:2125:27 [INFO] [stderr] | [INFO] [stderr] 2125 | monitor.provide_secret(281474976710651, secrets.last().unwrap().clone()).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider: `281_474_976_710_651` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ln/channelmonitor.rs:1800:19 [INFO] [stderr] | [INFO] [stderr] 1800 | let mut idx = 281474976710655; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider: `281_474_976_710_655` [INFO] [stderr] ... [INFO] [stderr] 2126 | test_secrets!(); [INFO] [stderr] | ---------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ln/channelmonitor.rs:2130:27 [INFO] [stderr] | [INFO] [stderr] 2130 | monitor.provide_secret(281474976710650, secrets.last().unwrap().clone()).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider: `281_474_976_710_650` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ln/channelmonitor.rs:1800:19 [INFO] [stderr] | [INFO] [stderr] 1800 | let mut idx = 281474976710655; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider: `281_474_976_710_655` [INFO] [stderr] ... [INFO] [stderr] 2131 | test_secrets!(); [INFO] [stderr] | ---------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ln/channelmonitor.rs:2135:27 [INFO] [stderr] | [INFO] [stderr] 2135 | monitor.provide_secret(281474976710649, secrets.last().unwrap().clone()).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider: `281_474_976_710_649` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ln/channelmonitor.rs:1800:19 [INFO] [stderr] | [INFO] [stderr] 1800 | let mut idx = 281474976710655; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider: `281_474_976_710_655` [INFO] [stderr] ... [INFO] [stderr] 2136 | test_secrets!(); [INFO] [stderr] | ---------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ln/channelmonitor.rs:2140:38 [INFO] [stderr] | [INFO] [stderr] 2140 | assert_eq!(monitor.provide_secret(281474976710648, secrets.last().unwrap().clone()).unwrap_err().0, [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider: `281_474_976_710_648` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ln/channelmonitor.rs:2223:115 [INFO] [stderr] | [INFO] [stderr] 2223 | monitor.provide_latest_remote_commitment_tx_info(&dummy_tx, preimages_slice_to_htlc_outputs!(preimages[5..15]), 281474976710655, dummy_key); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider: `281_474_976_710_655` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ln/channelmonitor.rs:2224:116 [INFO] [stderr] | [INFO] [stderr] 2224 | monitor.provide_latest_remote_commitment_tx_info(&dummy_tx, preimages_slice_to_htlc_outputs!(preimages[15..20]), 281474976710654, dummy_key); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider: `281_474_976_710_654` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ln/channelmonitor.rs:2225:116 [INFO] [stderr] | [INFO] [stderr] 2225 | monitor.provide_latest_remote_commitment_tx_info(&dummy_tx, preimages_slice_to_htlc_outputs!(preimages[17..20]), 281474976710653, dummy_key); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider: `281_474_976_710_653` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ln/channelmonitor.rs:2226:116 [INFO] [stderr] | [INFO] [stderr] 2226 | monitor.provide_latest_remote_commitment_tx_info(&dummy_tx, preimages_slice_to_htlc_outputs!(preimages[18..20]), 281474976710652, dummy_key); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider: `281_474_976_710_652` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ln/channelmonitor.rs:2234:26 [INFO] [stderr] | [INFO] [stderr] 2234 | monitor.provide_secret(281474976710655, secret.clone()).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider: `281_474_976_710_655` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ln/channelmonitor.rs:2241:26 [INFO] [stderr] | [INFO] [stderr] 2241 | monitor.provide_secret(281474976710654, secret.clone()).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider: `281_474_976_710_654` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ln/channelmonitor.rs:2250:26 [INFO] [stderr] | [INFO] [stderr] 2250 | monitor.provide_secret(281474976710653, secret.clone()).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider: `281_474_976_710_653` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ln/channelmonitor.rs:2258:26 [INFO] [stderr] | [INFO] [stderr] 2258 | monitor.provide_secret(281474976710652, secret.clone()).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider: `281_474_976_710_652` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/ln/msgs.rs:100:3 [INFO] [stderr] | [INFO] [stderr] 100 | return false; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `false` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/ln/msgs.rs:111:3 [INFO] [stderr] | [INFO] [stderr] 111 | return false; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `false` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/ln/msgs.rs:134:3 [INFO] [stderr] | [INFO] [stderr] 134 | return false; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `false` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/ln/msgs.rs:143:3 [INFO] [stderr] | [INFO] [stderr] 143 | return false; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `false` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/ln/router.rs:405:12 [INFO] [stderr] | [INFO] [stderr] 405 | } else { [INFO] [stderr] | ________________________^ [INFO] [stderr] 406 | | if let Some(chan) = network.channels.get_mut(short_channel_id) { [INFO] [stderr] 407 | | chan.one_to_two.enabled = false; [INFO] [stderr] 408 | | chan.two_to_one.enabled = false; [INFO] [stderr] 409 | | } [INFO] [stderr] 410 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 405 | } else if let Some(chan) = network.channels.get_mut(short_channel_id) { [INFO] [stderr] 406 | chan.one_to_two.enabled = false; [INFO] [stderr] 407 | chan.two_to_one.enabled = false; [INFO] [stderr] 408 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ln/router.rs:714:68 [INFO] [stderr] | [INFO] [stderr] 714 | ($directional_info.fee_base_msat as u64).checked_add(part / 1000000) }) [INFO] [stderr] | ^^^^^^^ help: consider: `1_000_000` [INFO] [stderr] ... [INFO] [stderr] 792 | add_entries_to_cheapest_to_target_node!(node, target, 0); [INFO] [stderr] | --------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ln/router.rs:735:32 [INFO] [stderr] | [INFO] [stderr] 735 | total_fee += fee_inc / 1000000 + (old_entry.1 as u64); [INFO] [stderr] | ^^^^^^^ help: consider: `1_000_000` [INFO] [stderr] ... [INFO] [stderr] 792 | add_entries_to_cheapest_to_target_node!(node, target, 0); [INFO] [stderr] | --------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ln/router.rs:714:68 [INFO] [stderr] | [INFO] [stderr] 714 | ($directional_info.fee_base_msat as u64).checked_add(part / 1000000) }) [INFO] [stderr] | ^^^^^^^ help: consider: `1_000_000` [INFO] [stderr] ... [INFO] [stderr] 792 | add_entries_to_cheapest_to_target_node!(node, target, 0); [INFO] [stderr] | --------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ln/router.rs:735:32 [INFO] [stderr] | [INFO] [stderr] 735 | total_fee += fee_inc / 1000000 + (old_entry.1 as u64); [INFO] [stderr] | ^^^^^^^ help: consider: `1_000_000` [INFO] [stderr] ... [INFO] [stderr] 792 | add_entries_to_cheapest_to_target_node!(node, target, 0); [INFO] [stderr] | --------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ln/router.rs:714:68 [INFO] [stderr] | [INFO] [stderr] 714 | ($directional_info.fee_base_msat as u64).checked_add(part / 1000000) }) [INFO] [stderr] | ^^^^^^^ help: consider: `1_000_000` [INFO] [stderr] ... [INFO] [stderr] 792 | add_entries_to_cheapest_to_target_node!(node, target, 0); [INFO] [stderr] | --------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ln/router.rs:735:32 [INFO] [stderr] | [INFO] [stderr] 735 | total_fee += fee_inc / 1000000 + (old_entry.1 as u64); [INFO] [stderr] | ^^^^^^^ help: consider: `1_000_000` [INFO] [stderr] ... [INFO] [stderr] 792 | add_entries_to_cheapest_to_target_node!(node, target, 0); [INFO] [stderr] | --------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ln/router.rs:714:68 [INFO] [stderr] | [INFO] [stderr] 714 | ($directional_info.fee_base_msat as u64).checked_add(part / 1000000) }) [INFO] [stderr] | ^^^^^^^ help: consider: `1_000_000` [INFO] [stderr] ... [INFO] [stderr] 801 | add_entry!(first_hop, hop.src_node_id, dummy_directional_info, 0); [INFO] [stderr] | ------------------------------------------------------------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ln/router.rs:735:32 [INFO] [stderr] | [INFO] [stderr] 735 | total_fee += fee_inc / 1000000 + (old_entry.1 as u64); [INFO] [stderr] | ^^^^^^^ help: consider: `1_000_000` [INFO] [stderr] ... [INFO] [stderr] 801 | add_entry!(first_hop, hop.src_node_id, dummy_directional_info, 0); [INFO] [stderr] | ------------------------------------------------------------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ln/router.rs:714:68 [INFO] [stderr] | [INFO] [stderr] 714 | ($directional_info.fee_base_msat as u64).checked_add(part / 1000000) }) [INFO] [stderr] | ^^^^^^^ help: consider: `1_000_000` [INFO] [stderr] ... [INFO] [stderr] 804 | add_entry!(hop.short_channel_id, target, hop, 0); [INFO] [stderr] | ------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ln/router.rs:735:32 [INFO] [stderr] | [INFO] [stderr] 735 | total_fee += fee_inc / 1000000 + (old_entry.1 as u64); [INFO] [stderr] | ^^^^^^^ help: consider: `1_000_000` [INFO] [stderr] ... [INFO] [stderr] 804 | add_entry!(hop.short_channel_id, target, hop, 0); [INFO] [stderr] | ------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ln/router.rs:714:68 [INFO] [stderr] | [INFO] [stderr] 714 | ($directional_info.fee_base_msat as u64).checked_add(part / 1000000) }) [INFO] [stderr] | ^^^^^^^ help: consider: `1_000_000` [INFO] [stderr] ... [INFO] [stderr] 831 | add_entries_to_cheapest_to_target_node!(node, &pubkey, lowest_fee_to_node); [INFO] [stderr] | --------------------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ln/router.rs:735:32 [INFO] [stderr] | [INFO] [stderr] 735 | total_fee += fee_inc / 1000000 + (old_entry.1 as u64); [INFO] [stderr] | ^^^^^^^ help: consider: `1_000_000` [INFO] [stderr] ... [INFO] [stderr] 831 | add_entries_to_cheapest_to_target_node!(node, &pubkey, lowest_fee_to_node); [INFO] [stderr] | --------------------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: immediately dereferencing a reference [INFO] [stderr] --> src/ln/router.rs:771:40 [INFO] [stderr] | [INFO] [stderr] 771 | if chan.one_to_two.src_node_id == *$node_id { [INFO] [stderr] | ^^^^^^^^^ help: try this: `pubkey` [INFO] [stderr] ... [INFO] [stderr] 831 | add_entries_to_cheapest_to_target_node!(node, &pubkey, lowest_fee_to_node); [INFO] [stderr] | --------------------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::deref_addrof)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deref_addrof [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ln/router.rs:714:68 [INFO] [stderr] | [INFO] [stderr] 714 | ($directional_info.fee_base_msat as u64).checked_add(part / 1000000) }) [INFO] [stderr] | ^^^^^^^ help: consider: `1_000_000` [INFO] [stderr] ... [INFO] [stderr] 831 | add_entries_to_cheapest_to_target_node!(node, &pubkey, lowest_fee_to_node); [INFO] [stderr] | --------------------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ln/router.rs:735:32 [INFO] [stderr] | [INFO] [stderr] 735 | total_fee += fee_inc / 1000000 + (old_entry.1 as u64); [INFO] [stderr] | ^^^^^^^ help: consider: `1_000_000` [INFO] [stderr] ... [INFO] [stderr] 831 | add_entries_to_cheapest_to_target_node!(node, &pubkey, lowest_fee_to_node); [INFO] [stderr] | --------------------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ln/router.rs:714:68 [INFO] [stderr] | [INFO] [stderr] 714 | ($directional_info.fee_base_msat as u64).checked_add(part / 1000000) }) [INFO] [stderr] | ^^^^^^^ help: consider: `1_000_000` [INFO] [stderr] ... [INFO] [stderr] 831 | add_entries_to_cheapest_to_target_node!(node, &pubkey, lowest_fee_to_node); [INFO] [stderr] | --------------------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ln/router.rs:735:32 [INFO] [stderr] | [INFO] [stderr] 735 | total_fee += fee_inc / 1000000 + (old_entry.1 as u64); [INFO] [stderr] | ^^^^^^^ help: consider: `1_000_000` [INFO] [stderr] ... [INFO] [stderr] 831 | add_entries_to_cheapest_to_target_node!(node, &pubkey, lowest_fee_to_node); [INFO] [stderr] | --------------------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ln/router.rs:1089:35 [INFO] [stderr] | [INFO] [stderr] 1089 | fee_proportional_millionths: 1000000, [INFO] [stderr] | ^^^^^^^ help: consider: `1_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ln/router.rs:1112:35 [INFO] [stderr] | [INFO] [stderr] 1112 | fee_proportional_millionths: 2000000, [INFO] [stderr] | ^^^^^^^ help: consider: `2_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ln/router.rs:1237:35 [INFO] [stderr] | [INFO] [stderr] 1237 | fee_proportional_millionths: 1000000, [INFO] [stderr] | ^^^^^^^ help: consider: `1_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/ln/peer_handler.rs:766:4 [INFO] [stderr] | [INFO] [stderr] 766 | pause_read [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/ln/peer_handler.rs:411:21 [INFO] [stderr] | [INFO] [stderr] 411 | let pause_read = match peers.peers.get_mut(peer_descriptor) { [INFO] [stderr] | ______________________________^ [INFO] [stderr] 412 | | None => panic!("Descriptor for read_event is not already known to PeerManager"), [INFO] [stderr] 413 | | Some(peer) => { [INFO] [stderr] 414 | | assert!(peer.pending_read_buffer.len() > 0); [INFO] [stderr] ... | [INFO] [stderr] 763 | | } [INFO] [stderr] 764 | | }; [INFO] [stderr] | |_____________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: All the struct fields are matched to a wildcard pattern, consider using `..`. [INFO] [stderr] --> src/ln/peer_handler.rs:446:14 [INFO] [stderr] | [INFO] [stderr] 446 | msgs::ErrorAction::DisconnectPeer { msg: _ } => { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 514 | let act_two = try_potential_handleerror!(peer.channel_encryptor.process_act_one_with_key(&peer.pending_read_buffer[..], &self.our_node_secret)).to_vec(); [INFO] [stderr] | --------------------------------------------------------------------------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: Try with `DisconnectPeer { .. }` instead [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern [INFO] [stderr] [INFO] [stderr] warning: All the struct fields are matched to a wildcard pattern, consider using `..`. [INFO] [stderr] --> src/ln/peer_handler.rs:446:14 [INFO] [stderr] | [INFO] [stderr] 446 | msgs::ErrorAction::DisconnectPeer { msg: _ } => { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 519 | let (act_three, their_node_id) = try_potential_handleerror!(peer.channel_encryptor.process_act_two(&peer.pending_read_buffer[..], &self.our_node_secret)); [INFO] [stderr] | ------------------------------------------------------------------------------------------------------------------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: Try with `DisconnectPeer { .. }` instead [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern [INFO] [stderr] [INFO] [stderr] warning: All the struct fields are matched to a wildcard pattern, consider using `..`. [INFO] [stderr] --> src/ln/peer_handler.rs:446:14 [INFO] [stderr] | [INFO] [stderr] 446 | msgs::ErrorAction::DisconnectPeer { msg: _ } => { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 537 | let their_node_id = try_potential_handleerror!(peer.channel_encryptor.process_act_three(&peer.pending_read_buffer[..])); [INFO] [stderr] | --------------------------------------------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: Try with `DisconnectPeer { .. }` instead [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern [INFO] [stderr] [INFO] [stderr] warning: All the struct fields are matched to a wildcard pattern, consider using `..`. [INFO] [stderr] --> src/ln/peer_handler.rs:446:14 [INFO] [stderr] | [INFO] [stderr] 446 | msgs::ErrorAction::DisconnectPeer { msg: _ } => { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 545 | let msg_len = try_potential_handleerror!(peer.channel_encryptor.decrypt_length_header(&peer.pending_read_buffer[..])); [INFO] [stderr] | ------------------------------------------------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: Try with `DisconnectPeer { .. }` instead [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern [INFO] [stderr] [INFO] [stderr] warning: All the struct fields are matched to a wildcard pattern, consider using `..`. [INFO] [stderr] --> src/ln/peer_handler.rs:446:14 [INFO] [stderr] | [INFO] [stderr] 446 | msgs::ErrorAction::DisconnectPeer { msg: _ } => { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 553 | let msg_data = try_potential_handleerror!(peer.channel_encryptor.decrypt_message(&peer.pending_read_buffer[..])); [INFO] [stderr] | ------------------------------------------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: Try with `DisconnectPeer { .. }` instead [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern [INFO] [stderr] [INFO] [stderr] warning: All the struct fields are matched to a wildcard pattern, consider using `..`. [INFO] [stderr] --> src/ln/peer_handler.rs:446:14 [INFO] [stderr] | [INFO] [stderr] 446 | msgs::ErrorAction::DisconnectPeer { msg: _ } => { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 656 | try_potential_handleerror!(self.message_handler.chan_handler.handle_open_channel(&peer.their_node_id.unwrap(), &msg)); [INFO] [stderr] | ---------------------------------------------------------------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: Try with `DisconnectPeer { .. }` instead [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern [INFO] [stderr] [INFO] [stderr] warning: All the struct fields are matched to a wildcard pattern, consider using `..`. [INFO] [stderr] --> src/ln/peer_handler.rs:446:14 [INFO] [stderr] | [INFO] [stderr] 446 | msgs::ErrorAction::DisconnectPeer { msg: _ } => { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 660 | try_potential_handleerror!(self.message_handler.chan_handler.handle_accept_channel(&peer.their_node_id.unwrap(), &msg)); [INFO] [stderr] | ------------------------------------------------------------------------------------------------------------------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: Try with `DisconnectPeer { .. }` instead [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern [INFO] [stderr] [INFO] [stderr] warning: All the struct fields are matched to a wildcard pattern, consider using `..`. [INFO] [stderr] --> src/ln/peer_handler.rs:446:14 [INFO] [stderr] | [INFO] [stderr] 446 | msgs::ErrorAction::DisconnectPeer { msg: _ } => { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 665 | try_potential_handleerror!(self.message_handler.chan_handler.handle_funding_created(&peer.their_node_id.unwrap(), &msg)); [INFO] [stderr] | ------------------------------------------------------------------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: Try with `DisconnectPeer { .. }` instead [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern [INFO] [stderr] [INFO] [stderr] warning: All the struct fields are matched to a wildcard pattern, consider using `..`. [INFO] [stderr] --> src/ln/peer_handler.rs:446:14 [INFO] [stderr] | [INFO] [stderr] 446 | msgs::ErrorAction::DisconnectPeer { msg: _ } => { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 669 | try_potential_handleerror!(self.message_handler.chan_handler.handle_funding_signed(&peer.their_node_id.unwrap(), &msg)); [INFO] [stderr] | ------------------------------------------------------------------------------------------------------------------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: Try with `DisconnectPeer { .. }` instead [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern [INFO] [stderr] [INFO] [stderr] warning: All the struct fields are matched to a wildcard pattern, consider using `..`. [INFO] [stderr] --> src/ln/peer_handler.rs:446:14 [INFO] [stderr] | [INFO] [stderr] 446 | msgs::ErrorAction::DisconnectPeer { msg: _ } => { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 673 | try_potential_handleerror!(self.message_handler.chan_handler.handle_funding_locked(&peer.their_node_id.unwrap(), &msg)); [INFO] [stderr] | ------------------------------------------------------------------------------------------------------------------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: Try with `DisconnectPeer { .. }` instead [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern [INFO] [stderr] [INFO] [stderr] warning: All the struct fields are matched to a wildcard pattern, consider using `..`. [INFO] [stderr] --> src/ln/peer_handler.rs:446:14 [INFO] [stderr] | [INFO] [stderr] 446 | msgs::ErrorAction::DisconnectPeer { msg: _ } => { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 678 | try_potential_handleerror!(self.message_handler.chan_handler.handle_shutdown(&peer.their_node_id.unwrap(), &msg)); [INFO] [stderr] | ------------------------------------------------------------------------------------------------------------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: Try with `DisconnectPeer { .. }` instead [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern [INFO] [stderr] [INFO] [stderr] warning: All the struct fields are matched to a wildcard pattern, consider using `..`. [INFO] [stderr] --> src/ln/peer_handler.rs:446:14 [INFO] [stderr] | [INFO] [stderr] 446 | msgs::ErrorAction::DisconnectPeer { msg: _ } => { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 682 | try_potential_handleerror!(self.message_handler.chan_handler.handle_closing_signed(&peer.their_node_id.unwrap(), &msg)); [INFO] [stderr] | ------------------------------------------------------------------------------------------------------------------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: Try with `DisconnectPeer { .. }` instead [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern [INFO] [stderr] [INFO] [stderr] warning: All the struct fields are matched to a wildcard pattern, consider using `..`. [INFO] [stderr] --> src/ln/peer_handler.rs:446:14 [INFO] [stderr] | [INFO] [stderr] 446 | msgs::ErrorAction::DisconnectPeer { msg: _ } => { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 687 | try_potential_handleerror!(self.message_handler.chan_handler.handle_update_add_htlc(&peer.their_node_id.unwrap(), &msg)); [INFO] [stderr] | ------------------------------------------------------------------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: Try with `DisconnectPeer { .. }` instead [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern [INFO] [stderr] [INFO] [stderr] warning: All the struct fields are matched to a wildcard pattern, consider using `..`. [INFO] [stderr] --> src/ln/peer_handler.rs:446:14 [INFO] [stderr] | [INFO] [stderr] 446 | msgs::ErrorAction::DisconnectPeer { msg: _ } => { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 691 | try_potential_handleerror!(self.message_handler.chan_handler.handle_update_fulfill_htlc(&peer.their_node_id.unwrap(), &msg)); [INFO] [stderr] | ----------------------------------------------------------------------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: Try with `DisconnectPeer { .. }` instead [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern [INFO] [stderr] [INFO] [stderr] warning: All the struct fields are matched to a wildcard pattern, consider using `..`. [INFO] [stderr] --> src/ln/peer_handler.rs:446:14 [INFO] [stderr] | [INFO] [stderr] 446 | msgs::ErrorAction::DisconnectPeer { msg: _ } => { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 695 | try_potential_handleerror!(self.message_handler.chan_handler.handle_update_fail_htlc(&peer.their_node_id.unwrap(), &msg)); [INFO] [stderr] | -------------------------------------------------------------------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: Try with `DisconnectPeer { .. }` instead [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern [INFO] [stderr] [INFO] [stderr] warning: All the struct fields are matched to a wildcard pattern, consider using `..`. [INFO] [stderr] --> src/ln/peer_handler.rs:446:14 [INFO] [stderr] | [INFO] [stderr] 446 | msgs::ErrorAction::DisconnectPeer { msg: _ } => { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 699 | try_potential_handleerror!(self.message_handler.chan_handler.handle_update_fail_malformed_htlc(&peer.their_node_id.unwrap(), &msg)); [INFO] [stderr] | ------------------------------------------------------------------------------------------------------------------------------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: Try with `DisconnectPeer { .. }` instead [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern [INFO] [stderr] [INFO] [stderr] warning: All the struct fields are matched to a wildcard pattern, consider using `..`. [INFO] [stderr] --> src/ln/peer_handler.rs:446:14 [INFO] [stderr] | [INFO] [stderr] 446 | msgs::ErrorAction::DisconnectPeer { msg: _ } => { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 704 | try_potential_handleerror!(self.message_handler.chan_handler.handle_commitment_signed(&peer.their_node_id.unwrap(), &msg)); [INFO] [stderr] | --------------------------------------------------------------------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: Try with `DisconnectPeer { .. }` instead [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern [INFO] [stderr] [INFO] [stderr] warning: All the struct fields are matched to a wildcard pattern, consider using `..`. [INFO] [stderr] --> src/ln/peer_handler.rs:446:14 [INFO] [stderr] | [INFO] [stderr] 446 | msgs::ErrorAction::DisconnectPeer { msg: _ } => { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 708 | try_potential_handleerror!(self.message_handler.chan_handler.handle_revoke_and_ack(&peer.their_node_id.unwrap(), &msg)); [INFO] [stderr] | ------------------------------------------------------------------------------------------------------------------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: Try with `DisconnectPeer { .. }` instead [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern [INFO] [stderr] [INFO] [stderr] warning: All the struct fields are matched to a wildcard pattern, consider using `..`. [INFO] [stderr] --> src/ln/peer_handler.rs:446:14 [INFO] [stderr] | [INFO] [stderr] 446 | msgs::ErrorAction::DisconnectPeer { msg: _ } => { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 712 | try_potential_handleerror!(self.message_handler.chan_handler.handle_update_fee(&peer.their_node_id.unwrap(), &msg)); [INFO] [stderr] | -------------------------------------------------------------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: Try with `DisconnectPeer { .. }` instead [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern [INFO] [stderr] [INFO] [stderr] warning: All the struct fields are matched to a wildcard pattern, consider using `..`. [INFO] [stderr] --> src/ln/peer_handler.rs:446:14 [INFO] [stderr] | [INFO] [stderr] 446 | msgs::ErrorAction::DisconnectPeer { msg: _ } => { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 716 | try_potential_handleerror!(self.message_handler.chan_handler.handle_channel_reestablish(&peer.their_node_id.unwrap(), &msg)); [INFO] [stderr] | ----------------------------------------------------------------------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: Try with `DisconnectPeer { .. }` instead [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern [INFO] [stderr] [INFO] [stderr] warning: All the struct fields are matched to a wildcard pattern, consider using `..`. [INFO] [stderr] --> src/ln/peer_handler.rs:446:14 [INFO] [stderr] | [INFO] [stderr] 446 | msgs::ErrorAction::DisconnectPeer { msg: _ } => { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 722 | try_potential_handleerror!(self.message_handler.chan_handler.handle_announcement_signatures(&peer.their_node_id.unwrap(), &msg)); [INFO] [stderr] | --------------------------------------------------------------------------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: Try with `DisconnectPeer { .. }` instead [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern [INFO] [stderr] [INFO] [stderr] warning: All the struct fields are matched to a wildcard pattern, consider using `..`. [INFO] [stderr] --> src/ln/peer_handler.rs:446:14 [INFO] [stderr] | [INFO] [stderr] 446 | msgs::ErrorAction::DisconnectPeer { msg: _ } => { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 726 | let should_forward = try_potential_handleerror!(self.message_handler.route_handler.handle_channel_announcement(&msg)); [INFO] [stderr] | ------------------------------------------------------------------------------------------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: Try with `DisconnectPeer { .. }` instead [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern [INFO] [stderr] [INFO] [stderr] warning: All the struct fields are matched to a wildcard pattern, consider using `..`. [INFO] [stderr] --> src/ln/peer_handler.rs:446:14 [INFO] [stderr] | [INFO] [stderr] 446 | msgs::ErrorAction::DisconnectPeer { msg: _ } => { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 734 | let should_forward = try_potential_handleerror!(self.message_handler.route_handler.handle_node_announcement(&msg)); [INFO] [stderr] | --------------------------------------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: Try with `DisconnectPeer { .. }` instead [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern [INFO] [stderr] [INFO] [stderr] warning: All the struct fields are matched to a wildcard pattern, consider using `..`. [INFO] [stderr] --> src/ln/peer_handler.rs:446:14 [INFO] [stderr] | [INFO] [stderr] 446 | msgs::ErrorAction::DisconnectPeer { msg: _ } => { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] ... [INFO] [stderr] 742 | let should_forward = try_potential_handleerror!(self.message_handler.route_handler.handle_channel_update(&msg)); [INFO] [stderr] | ------------------------------------------------------------------------------------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: Try with `DisconnectPeer { .. }` instead [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern [INFO] [stderr] [INFO] [stderr] warning: You matched a field with a wildcard pattern. Consider using `..` instead [INFO] [stderr] --> src/ln/peer_channel_encryptor.rs:348:40 [INFO] [stderr] | [INFO] [stderr] 348 | &DirectionalNoiseState::Inbound { ie: _, ref re, ref temp_k2 } => { [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Try with `Inbound { ref re, ref temp_k2, .. }` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern [INFO] [stderr] [INFO] [stderr] warning: You matched a field with a wildcard pattern. Consider using `..` instead [INFO] [stderr] --> src/ln/peer_channel_encryptor.rs:411:64 [INFO] [stderr] | [INFO] [stderr] 411 | NoiseState::Finished { ref mut sk, ref mut sn, ref mut sck, rk: _, rn: _, rck: _ } => { [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern [INFO] [stderr] [INFO] [stderr] warning: You matched a field with a wildcard pattern. Consider using `..` instead [INFO] [stderr] --> src/ln/peer_channel_encryptor.rs:411:71 [INFO] [stderr] | [INFO] [stderr] 411 | NoiseState::Finished { ref mut sk, ref mut sn, ref mut sck, rk: _, rn: _, rck: _ } => { [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern [INFO] [stderr] [INFO] [stderr] warning: You matched a field with a wildcard pattern. Consider using `..` instead [INFO] [stderr] --> src/ln/peer_channel_encryptor.rs:411:78 [INFO] [stderr] | [INFO] [stderr] 411 | NoiseState::Finished { ref mut sk, ref mut sn, ref mut sck, rk: _, rn: _, rck: _ } => { [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Try with `Finished { ref mut sk, ref mut sn, ref mut sck, .. }` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern [INFO] [stderr] [INFO] [stderr] warning: You matched a field with a wildcard pattern. Consider using `..` instead [INFO] [stderr] --> src/ln/peer_channel_encryptor.rs:441:27 [INFO] [stderr] | [INFO] [stderr] 441 | NoiseState::Finished { sk: _, sn: _, sck: _, ref mut rk, ref mut rn, ref mut rck } => { [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern [INFO] [stderr] [INFO] [stderr] warning: You matched a field with a wildcard pattern. Consider using `..` instead [INFO] [stderr] --> src/ln/peer_channel_encryptor.rs:441:34 [INFO] [stderr] | [INFO] [stderr] 441 | NoiseState::Finished { sk: _, sn: _, sck: _, ref mut rk, ref mut rn, ref mut rck } => { [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern [INFO] [stderr] [INFO] [stderr] warning: You matched a field with a wildcard pattern. Consider using `..` instead [INFO] [stderr] --> src/ln/peer_channel_encryptor.rs:441:41 [INFO] [stderr] | [INFO] [stderr] 441 | NoiseState::Finished { sk: _, sn: _, sck: _, ref mut rk, ref mut rn, ref mut rck } => { [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Try with `Finished { ref mut rk, ref mut rn, ref mut rck, .. }` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern [INFO] [stderr] [INFO] [stderr] warning: You matched a field with a wildcard pattern. Consider using `..` instead [INFO] [stderr] --> src/ln/peer_channel_encryptor.rs:470:27 [INFO] [stderr] | [INFO] [stderr] 470 | NoiseState::Finished { sk: _, sn: _, sck: _, ref rk, ref mut rn, rck: _ } => { [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern [INFO] [stderr] [INFO] [stderr] warning: You matched a field with a wildcard pattern. Consider using `..` instead [INFO] [stderr] --> src/ln/peer_channel_encryptor.rs:470:34 [INFO] [stderr] | [INFO] [stderr] 470 | NoiseState::Finished { sk: _, sn: _, sck: _, ref rk, ref mut rn, rck: _ } => { [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern [INFO] [stderr] [INFO] [stderr] warning: You matched a field with a wildcard pattern. Consider using `..` instead [INFO] [stderr] --> src/ln/peer_channel_encryptor.rs:470:41 [INFO] [stderr] | [INFO] [stderr] 470 | NoiseState::Finished { sk: _, sn: _, sck: _, ref rk, ref mut rn, rck: _ } => { [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern [INFO] [stderr] [INFO] [stderr] warning: You matched a field with a wildcard pattern. Consider using `..` instead [INFO] [stderr] --> src/ln/peer_channel_encryptor.rs:470:69 [INFO] [stderr] | [INFO] [stderr] 470 | NoiseState::Finished { sk: _, sn: _, sck: _, ref rk, ref mut rn, rck: _ } => { [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Try with `Finished { ref rk, ref mut rn, .. }` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern [INFO] [stderr] [INFO] [stderr] warning: You matched a field with a wildcard pattern. Consider using `..` instead [INFO] [stderr] --> src/ln/peer_channel_encryptor.rs:518:29 [INFO] [stderr] | [INFO] [stderr] 518 | NoiseState::InProgress { state: _, ref mut directional_state, bidirectional_state: _ } => { [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern [INFO] [stderr] [INFO] [stderr] warning: You matched a field with a wildcard pattern. Consider using `..` instead [INFO] [stderr] --> src/ln/peer_channel_encryptor.rs:518:66 [INFO] [stderr] | [INFO] [stderr] 518 | NoiseState::InProgress { state: _, ref mut directional_state, bidirectional_state: _ } => { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Try with `InProgress { ref mut directional_state, .. }` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/ln/channel.rs:596:3 [INFO] [stderr] | [INFO] [stderr] 596 | if config.channel_limits.force_announced_channel_preference { [INFO] [stderr] | _________^ [INFO] [stderr] 597 | | if local_config.announced_channel != their_announce { [INFO] [stderr] 598 | | return Err(ChannelError::Close("Peer tried to open channel but their announcement preference is different from ours")); [INFO] [stderr] 599 | | } [INFO] [stderr] 600 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 596 | if config.channel_limits.force_announced_channel_preference && local_config.announced_channel != their_announce { [INFO] [stderr] 597 | return Err(ChannelError::Close("Peer tried to open channel but their announcement preference is different from ours")); [INFO] [stderr] 598 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: operator precedence can trip the unwary [INFO] [stderr] --> src/ln/channel.rs:741:4 [INFO] [stderr] | [INFO] [stderr] 741 | ((res[26] as u64) << 5*8) | [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: consider parenthesizing your expression: `(res[26] as u64) << (5*8)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence [INFO] [stderr] [INFO] [stderr] warning: operator precedence can trip the unwary [INFO] [stderr] --> src/ln/channel.rs:742:4 [INFO] [stderr] | [INFO] [stderr] 742 | ((res[27] as u64) << 4*8) | [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: consider parenthesizing your expression: `(res[27] as u64) << (4*8)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence [INFO] [stderr] [INFO] [stderr] warning: operator precedence can trip the unwary [INFO] [stderr] --> src/ln/channel.rs:743:4 [INFO] [stderr] | [INFO] [stderr] 743 | ((res[28] as u64) << 3*8) | [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: consider parenthesizing your expression: `(res[28] as u64) << (3*8)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence [INFO] [stderr] [INFO] [stderr] warning: operator precedence can trip the unwary [INFO] [stderr] --> src/ln/channel.rs:744:4 [INFO] [stderr] | [INFO] [stderr] 744 | ((res[29] as u64) << 2*8) | [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: consider parenthesizing your expression: `(res[29] as u64) << (2*8)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence [INFO] [stderr] [INFO] [stderr] warning: operator precedence can trip the unwary [INFO] [stderr] --> src/ln/channel.rs:745:4 [INFO] [stderr] | [INFO] [stderr] 745 | ((res[30] as u64) << 1*8) | [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: consider parenthesizing your expression: `(res[30] as u64) << (1*8)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence [INFO] [stderr] [INFO] [stderr] warning: operator precedence can trip the unwary [INFO] [stderr] --> src/ln/channel.rs:746:4 [INFO] [stderr] | [INFO] [stderr] 746 | ((res[31] as u64) << 0*8) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: consider parenthesizing your expression: `(res[31] as u64) << (0*8)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence [INFO] [stderr] [INFO] [stderr] warning: operator precedence can trip the unwary [INFO] [stderr] --> src/ln/channel.rs:771:16 [INFO] [stderr] | [INFO] [stderr] 771 | sequence: ((0x80 as u32) << 8*3) | ((obscured_commitment_transaction_number >> 3*8) as u32), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: consider parenthesizing your expression: `(0x80 as u32) << (8*3)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence [INFO] [stderr] [INFO] [stderr] warning: operator precedence can trip the unwary [INFO] [stderr] --> src/ln/channel.rs:771:42 [INFO] [stderr] | [INFO] [stderr] 771 | sequence: ((0x80 as u32) << 8*3) | ((obscured_commitment_transaction_number >> 3*8) as u32), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider parenthesizing your expression: `obscured_commitment_transaction_number >> (3*8)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence [INFO] [stderr] [INFO] [stderr] warning: operator precedence can trip the unwary [INFO] [stderr] --> src/ln/channel.rs:924:16 [INFO] [stderr] | [INFO] [stderr] 924 | lock_time: ((0x20 as u32) << 8*3) | ((obscured_commitment_transaction_number & 0xffffffu64) as u32), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: consider parenthesizing your expression: `(0x20 as u32) << (8*3)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ln/channel.rs:924:83 [INFO] [stderr] | [INFO] [stderr] 924 | lock_time: ((0x20 as u32) << 8*3) | ((obscured_commitment_transaction_number & 0xffffffu64) as u32), [INFO] [stderr] | ^^^^^^^^^^^ help: consider: `0x00ff_ffffu64` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ln/channel.rs:948:15 [INFO] [stderr] | [INFO] [stderr] 948 | sequence: 0xffffffff, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xffff_ffff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ln/channel.rs:1308:32 [INFO] [stderr] | [INFO] [stderr] 1308 | if msg.dust_limit_satoshis > 21000000 * 100000000 { [INFO] [stderr] | ^^^^^^^^ help: consider: `21_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ln/channel.rs:1308:43 [INFO] [stderr] | [INFO] [stderr] 1308 | if msg.dust_limit_satoshis > 21000000 * 100000000 { [INFO] [stderr] | ^^^^^^^^^ help: consider: `100_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ln/channel.rs:1563:25 [INFO] [stderr] | [INFO] [stderr] 1563 | if msg.cltv_expiry >= 500000000 { [INFO] [stderr] | ^^^^^^^^^ help: consider: `500_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/ln/channel.rs:1993:10 [INFO] [stderr] | [INFO] [stderr] 1993 | } else { [INFO] [stderr] | ________________^ [INFO] [stderr] 1994 | | if let Some(feerate) = self.pending_update_fee { [INFO] [stderr] 1995 | | // Because a node cannot send two commitment_signed's in a row without getting a [INFO] [stderr] 1996 | | // revoke_and_ack from us (as it would otherwise not know the per_commitment_point [INFO] [stderr] ... | [INFO] [stderr] 2004 | | } [INFO] [stderr] 2005 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 1993 | } else if let Some(feerate) = self.pending_update_fee { [INFO] [stderr] 1994 | // Because a node cannot send two commitment_signed's in a row without getting a [INFO] [stderr] 1995 | // revoke_and_ack from us (as it would otherwise not know the per_commitment_point [INFO] [stderr] 1996 | // it should use to create keys with) and because a node can't send a [INFO] [stderr] 1997 | // commitment_signed without changes, checking if the feerate is equal to the [INFO] [stderr] 1998 | // pending feerate update is sufficient to detect require_commitment. [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/ln/channel.rs:2382:39 [INFO] [stderr] | [INFO] [stderr] 2382 | Err(ChannelError::Close(msg)) => return Err(ChannelError::Close(msg)), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(ChannelError::Close(msg))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/ln/channel.rs:2384:56 [INFO] [stderr] | [INFO] [stderr] 2384 | Ok(Some((commitment_update, channel_monitor))) => return Ok((resend_funding_locked, required_revoke, Some(commitment_update), Some(channel_monitor), order, shutdown_msg)), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok((resend_funding_locked, required_revoke, Some(commitment_update), Some(channel_monitor), order, shutdown_msg))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/ln/channel.rs:2385:18 [INFO] [stderr] | [INFO] [stderr] 2385 | Ok(None) => return Ok((resend_funding_locked, required_revoke, None, None, order, shutdown_msg)), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok((resend_funding_locked, required_revoke, None, None, order, shutdown_msg))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/ln/channel.rs:2388:5 [INFO] [stderr] | [INFO] [stderr] 2388 | return Ok((resend_funding_locked, required_revoke, None, None, order, shutdown_msg)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok((resend_funding_locked, required_revoke, None, None, order, shutdown_msg))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/ln/channel.rs:2405:4 [INFO] [stderr] | [INFO] [stderr] 2405 | return Ok((resend_funding_locked, required_revoke, Some(self.get_last_commitment_update()), None, order, shutdown_msg)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok((resend_funding_locked, required_revoke, Some(self.get_last_commitment_update()), None, order, shutdown_msg))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/ln/channel.rs:2407:4 [INFO] [stderr] | [INFO] [stderr] 2407 | return Err(ChannelError::Close("Peer attempted to reestablish channel with a very old remote commitment transaction")); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(ChannelError::Close("Peer attempted to reestablish channel with a very old remote commitment transaction"))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ln/channel.rs:2521:25 [INFO] [stderr] | [INFO] [stderr] 2521 | if msg.fee_satoshis > 21000000 * 10000000 { //this is required to stop potential overflow in build_closing_transaction [INFO] [stderr] | ^^^^^^^^ help: consider: `21_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ln/channel.rs:2521:36 [INFO] [stderr] | [INFO] [stderr] 2521 | if msg.fee_satoshis > 21000000 * 10000000 { //this is required to stop potential overflow in build_closing_transaction [INFO] [stderr] | ^^^^^^^^ help: consider: `10_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: You matched a field with a wildcard pattern. Consider using `..` instead [INFO] [stderr] --> src/ln/channel.rs:3490:129 [INFO] [stderr] | [INFO] [stderr] 3490 | &HTLCUpdateAwaitingACK::AddHTLC { ref amount_msat, ref cltv_expiry, ref payment_hash, ref source, ref onion_routing_packet, time_created: _ } => { [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: Try with `AddHTLC { ref amount_msat, ref cltv_expiry, ref payment_hash, ref source, ref onion_routing_packet, .. }` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ln/channel.rs:3931:80 [INFO] [stderr] | [INFO] [stderr] 3931 | let mut chan = Channel::new_outbound(&feeest, &keys_provider, their_node_id, 10000000, 100000, 42, Arc::clone(&logger), &config).unwrap(); // Nothing uses their network key in this test [INFO] [stderr] | ^^^^^^^^ help: consider: `10_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ln/channel.rs:3931:90 [INFO] [stderr] | [INFO] [stderr] 3931 | let mut chan = Channel::new_outbound(&feeest, &keys_provider, their_node_id, 10000000, 100000, 42, Arc::clone(&logger), &config).unwrap(); // Nothing uses their network key in this test [INFO] [stderr] | ^^^^^^ help: consider: `100_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ln/channel.rs:4012:30 [INFO] [stderr] | [INFO] [stderr] 4012 | chan.value_to_self_msat = 7000000000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `7_000_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ln/channel.rs:3965:53 [INFO] [stderr] | [INFO] [stderr] 3965 | unsigned_tx = chan.build_commitment_transaction(0xffffffffffff - 42, &keys, true, false, chan.feerate_per_kw); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: consider: `0xffff_ffff_ffff` [INFO] [stderr] ... [INFO] [stderr] 4014 | test_commitment!("3045022100f51d2e566a70ba740fc5d8c0f07b9b93d2ed741c3c0860c613173de7d39e7968022041376d520e9c0e1ad52248ddf4b22e12be8763007df977253ef45a4ca3bdb7c0", [INFO] [stderr] | _____________- [INFO] [stderr] 4015 | | "3044022051b75c73198c6deee1a875871c3961832909acd297c6b908d59e3319e5185a46022055c419379c5051a78d00dbbce11b5b664a0c22815fbcc6fcef6b1937c3836939", [INFO] [stderr] 4016 | | "02000000000101bef67e4e2fb9ddeeb3461973cd4c62abb35050b1add772995b820b584a488489000000000038b02b8002c0c62d0000000000160014ccf1af2f2aabee14bb40fa3851ab2301de84311054a56a00000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e0400473044022051b75c73198c6deee1a875871c3961832909acd297c6b908d59e3319e5185a46022055c419379c5051a78d00dbbce11b5b664a0c22815fbcc6fcef6b1937c383693901483045022100f51d2e566a70ba740fc5d8c0f07b9b93d2ed741c3c0860c613173de7d39e7968022041376d520e9c0e1ad52248ddf4b22e12be8763007df977253ef45a4ca3bdb7c001475221023da092f6980e58d2c037173180e9a465476026ee50f96695963e8efe436f54eb21030e9f7b623d2ccc7c9bd44d66d5ce21ce504c0acf6385a132cec6d3c39fa711c152ae3e195220"); [INFO] [stderr] | |_____________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ln/channel.rs:4022:18 [INFO] [stderr] | [INFO] [stderr] 4022 | amount_msat: 1000000, [INFO] [stderr] | ^^^^^^^ help: consider: `1_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ln/channel.rs:4035:18 [INFO] [stderr] | [INFO] [stderr] 4035 | amount_msat: 2000000, [INFO] [stderr] | ^^^^^^^ help: consider: `2_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ln/channel.rs:4048:18 [INFO] [stderr] | [INFO] [stderr] 4048 | amount_msat: 2000000, [INFO] [stderr] | ^^^^^^^ help: consider: `2_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ln/channel.rs:4063:18 [INFO] [stderr] | [INFO] [stderr] 4063 | amount_msat: 3000000, [INFO] [stderr] | ^^^^^^^ help: consider: `3_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ln/channel.rs:4078:18 [INFO] [stderr] | [INFO] [stderr] 4078 | amount_msat: 4000000, [INFO] [stderr] | ^^^^^^^ help: consider: `4_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ln/channel.rs:4091:30 [INFO] [stderr] | [INFO] [stderr] 4091 | chan.value_to_self_msat = 6993000000; // 7000000000 - 7000000 [INFO] [stderr] | ^^^^^^^^^^ help: consider: `6_993_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ln/channel.rs:3965:53 [INFO] [stderr] | [INFO] [stderr] 3965 | unsigned_tx = chan.build_commitment_transaction(0xffffffffffff - 42, &keys, true, false, chan.feerate_per_kw); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: consider: `0xffff_ffff_ffff` [INFO] [stderr] ... [INFO] [stderr] 4094 | test_commitment!("304402204fd4928835db1ccdfc40f5c78ce9bd65249b16348df81f0c44328dcdefc97d630220194d3869c38bc732dd87d13d2958015e2fc16829e74cd4377f84d215c0b70606", [INFO] [stderr] | _____________- [INFO] [stderr] 4095 | | "30440220275b0c325a5e9355650dc30c0eccfbc7efb23987c24b556b9dfdd40effca18d202206caceb2c067836c51f296740c7ae807ffcbfbf1dd3a0d56b6de9a5b247985f06", [INFO] [stderr] 4096 | | "02000000000101bef67e4e2fb9ddeeb3461973cd4c62abb35050b1add772995b820b584a488489000000000038b02b8007e80300000000000022002052bfef0479d7b293c27e0f1eb294bea154c63a3294ef092c19af51409bce0e2ad007000000000000220020403d394747cae42e98ff01734ad5c08f82ba123d3d9a620abda88989651e2ab5d007000000000000220020748eba944fedc8827f6b06bc44678f93c0f9e6078b35c6331ed31e75f8ce0c2db80b000000000000220020c20b5d1f8584fd90443e7b7b720136174fa4b9333c261d04dbbd012635c0f419a00f0000000000002200208c48d15160397c9731df9bc3b236656efb6665fbfe92b4a6878e88a499f741c4c0c62d0000000000160014ccf1af2f2aabee14bb40fa3851ab2301de843110e0a06a00000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e04004730440220275b0c325a5e9355650dc30c0eccfbc7efb23987c24b556b9dfdd40effca18d202206caceb2c067836c51f296740c7ae807ffcbfbf1dd3a0d56b6de9a5b247985f060147304402204fd4928835db1ccdfc40f5c78ce9bd65249b16348df81f0c44328dcdefc97d630220194d3869c38bc732dd87d13d2958015e2fc16829e74cd4377f84d215c0b7060601475221023da092f6980e58d2c037173180e9a465476026ee50f96695963e8efe436f54eb21030e9f7b623d2ccc7c9bd44d66d5ce21ce504c0acf6385a132cec6d3c39fa711c152ae3e195220"); [INFO] [stderr] | |_________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ln/channel.rs:4128:30 [INFO] [stderr] | [INFO] [stderr] 4128 | chan.value_to_self_msat = 6993000000; // 7000000000 - 7000000 [INFO] [stderr] | ^^^^^^^^^^ help: consider: `6_993_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ln/channel.rs:3965:53 [INFO] [stderr] | [INFO] [stderr] 3965 | unsigned_tx = chan.build_commitment_transaction(0xffffffffffff - 42, &keys, true, false, chan.feerate_per_kw); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: consider: `0xffff_ffff_ffff` [INFO] [stderr] ... [INFO] [stderr] 4131 | test_commitment!("3045022100a5c01383d3ec646d97e40f44318d49def817fcd61a0ef18008a665b3e151785502203e648efddd5838981ef55ec954be69c4a652d021e6081a100d034de366815e9b", [INFO] [stderr] | _____________- [INFO] [stderr] 4132 | | "304502210094bfd8f5572ac0157ec76a9551b6c5216a4538c07cd13a51af4a54cb26fa14320220768efce8ce6f4a5efac875142ff19237c011343670adf9c7ac69704a120d1163", [INFO] [stderr] 4133 | | "02000000000101bef67e4e2fb9ddeeb3461973cd4c62abb35050b1add772995b820b584a488489000000000038b02b8007e80300000000000022002052bfef0479d7b293c27e0f1eb294bea154c63a3294ef092c19af51409bce0e2ad007000000000000220020403d394747cae42e98ff01734ad5c08f82ba123d3d9a620abda88989651e2ab5d007000000000000220020748eba944fedc8827f6b06bc44678f93c0f9e6078b35c6331ed31e75f8ce0c2db80b000000000000220020c20b5d1f8584fd90443e7b7b720136174fa4b9333c261d04dbbd012635c0f419a00f0000000000002200208c48d15160397c9731df9bc3b236656efb6665fbfe92b4a6878e88a499f741c4c0c62d0000000000160014ccf1af2f2aabee14bb40fa3851ab2301de843110e09c6a00000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e040048304502210094bfd8f5572ac0157ec76a9551b6c5216a4538c07cd13a51af4a54cb26fa14320220768efce8ce6f4a5efac875142ff19237c011343670adf9c7ac69704a120d116301483045022100a5c01383d3ec646d97e40f44318d49def817fcd61a0ef18008a665b3e151785502203e648efddd5838981ef55ec954be69c4a652d021e6081a100d034de366815e9b01475221023da092f6980e58d2c037173180e9a465476026ee50f96695963e8efe436f54eb21030e9f7b623d2ccc7c9bd44d66d5ce21ce504c0acf6385a132cec6d3c39fa711c152ae3e195220"); [INFO] [stderr] | |_____________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ln/channel.rs:4165:30 [INFO] [stderr] | [INFO] [stderr] 4165 | chan.value_to_self_msat = 6993000000; // 7000000000 - 7000000 [INFO] [stderr] | ^^^^^^^^^^ help: consider: `6_993_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ln/channel.rs:3965:53 [INFO] [stderr] | [INFO] [stderr] 3965 | unsigned_tx = chan.build_commitment_transaction(0xffffffffffff - 42, &keys, true, false, chan.feerate_per_kw); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: consider: `0xffff_ffff_ffff` [INFO] [stderr] ... [INFO] [stderr] 4168 | test_commitment!("3044022072714e2fbb93cdd1c42eb0828b4f2eff143f717d8f26e79d6ada4f0dcb681bbe02200911be4e5161dd6ebe59ff1c58e1997c4aea804f81db6b698821db6093d7b057", [INFO] [stderr] | _____________- [INFO] [stderr] 4169 | | "3045022100a2270d5950c89ae0841233f6efea9c951898b301b2e89e0adbd2c687b9f32efa02207943d90f95b9610458e7c65a576e149750ff3accaacad004cd85e70b235e27de", [INFO] [stderr] 4170 | | "02000000000101bef67e4e2fb9ddeeb3461973cd4c62abb35050b1add772995b820b584a488489000000000038b02b8006d007000000000000220020403d394747cae42e98ff01734ad5c08f82ba123d3d9a620abda88989651e2ab5d007000000000000220020748eba944fedc8827f6b06bc44678f93c0f9e6078b35c6331ed31e75f8ce0c2db80b000000000000220020c20b5d1f8584fd90443e7b7b720136174fa4b9333c261d04dbbd012635c0f419a00f0000000000002200208c48d15160397c9731df9bc3b236656efb6665fbfe92b4a6878e88a499f741c4c0c62d0000000000160014ccf1af2f2aabee14bb40fa3851ab2301de8431104e9d6a00000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e0400483045022100a2270d5950c89ae0841233f6efea9c951898b301b2e89e0adbd2c687b9f32efa02207943d90f95b9610458e7c65a576e149750ff3accaacad004cd85e70b235e27de01473044022072714e2fbb93cdd1c42eb0828b4f2eff143f717d8f26e79d6ada4f0dcb681bbe02200911be4e5161dd6ebe59ff1c58e1997c4aea804f81db6b698821db6093d7b05701475221023da092f6980e58d2c037173180e9a465476026ee50f96695963e8efe436f54eb21030e9f7b623d2ccc7c9bd44d66d5ce21ce504c0acf6385a132cec6d3c39fa711c152ae3e195220"); [INFO] [stderr] | |_____________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ln/channel.rs:4197:30 [INFO] [stderr] | [INFO] [stderr] 4197 | chan.value_to_self_msat = 6993000000; // 7000000000 - 7000000 [INFO] [stderr] | ^^^^^^^^^^ help: consider: `6_993_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ln/channel.rs:3965:53 [INFO] [stderr] | [INFO] [stderr] 3965 | unsigned_tx = chan.build_commitment_transaction(0xffffffffffff - 42, &keys, true, false, chan.feerate_per_kw); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: consider: `0xffff_ffff_ffff` [INFO] [stderr] ... [INFO] [stderr] 4200 | test_commitment!("3044022001d55e488b8b035b2dd29d50b65b530923a416d47f377284145bc8767b1b6a75022019bb53ddfe1cefaf156f924777eaaf8fdca1810695a7d0a247ad2afba8232eb4", [INFO] [stderr] | _____________- [INFO] [stderr] 4201 | | "304402203ca8f31c6a47519f83255dc69f1894d9a6d7476a19f498d31eaf0cd3a85eeb63022026fd92dc752b33905c4c838c528b692a8ad4ced959990b5d5ee2ff940fa90eea", [INFO] [stderr] 4202 | | "02000000000101bef67e4e2fb9ddeeb3461973cd4c62abb35050b1add772995b820b584a488489000000000038b02b8006d007000000000000220020403d394747cae42e98ff01734ad5c08f82ba123d3d9a620abda88989651e2ab5d007000000000000220020748eba944fedc8827f6b06bc44678f93c0f9e6078b35c6331ed31e75f8ce0c2db80b000000000000220020c20b5d1f8584fd90443e7b7b720136174fa4b9333c261d04dbbd012635c0f419a00f0000000000002200208c48d15160397c9731df9bc3b236656efb6665fbfe92b4a6878e88a499f741c4c0c62d0000000000160014ccf1af2f2aabee14bb40fa3851ab2301de84311077956a00000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e040047304402203ca8f31c6a47519f83255dc69f1894d9a6d7476a19f498d31eaf0cd3a85eeb63022026fd92dc752b33905c4c838c528b692a8ad4ced959990b5d5ee2ff940fa90eea01473044022001d55e488b8b035b2dd29d50b65b530923a416d47f377284145bc8767b1b6a75022019bb53ddfe1cefaf156f924777eaaf8fdca1810695a7d0a247ad2afba8232eb401475221023da092f6980e58d2c037173180e9a465476026ee50f96695963e8efe436f54eb21030e9f7b623d2ccc7c9bd44d66d5ce21ce504c0acf6385a132cec6d3c39fa711c152ae3e195220"); [INFO] [stderr] | |___________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ln/channel.rs:4229:30 [INFO] [stderr] | [INFO] [stderr] 4229 | chan.value_to_self_msat = 6993000000; // 7000000000 - 7000000 [INFO] [stderr] | ^^^^^^^^^^ help: consider: `6_993_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ln/channel.rs:3965:53 [INFO] [stderr] | [INFO] [stderr] 3965 | unsigned_tx = chan.build_commitment_transaction(0xffffffffffff - 42, &keys, true, false, chan.feerate_per_kw); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: consider: `0xffff_ffff_ffff` [INFO] [stderr] ... [INFO] [stderr] 4232 | test_commitment!("3045022100f2377f7a67b7fc7f4e2c0c9e3a7de935c32417f5668eda31ea1db401b7dc53030220415fdbc8e91d0f735e70c21952342742e25249b0d062d43efbfc564499f37526", [INFO] [stderr] | _____________- [INFO] [stderr] 4233 | | "30440220443cb07f650aebbba14b8bc8d81e096712590f524c5991ac0ed3bbc8fd3bd0c7022028a635f548e3ca64b19b69b1ea00f05b22752f91daf0b6dab78e62ba52eb7fd0", [INFO] [stderr] 4234 | | "02000000000101bef67e4e2fb9ddeeb3461973cd4c62abb35050b1add772995b820b584a488489000000000038b02b8005d007000000000000220020403d394747cae42e98ff01734ad5c08f82ba123d3d9a620abda88989651e2ab5b80b000000000000220020c20b5d1f8584fd90443e7b7b720136174fa4b9333c261d04dbbd012635c0f419a00f0000000000002200208c48d15160397c9731df9bc3b236656efb6665fbfe92b4a6878e88a499f741c4c0c62d0000000000160014ccf1af2f2aabee14bb40fa3851ab2301de843110da966a00000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e04004730440220443cb07f650aebbba14b8bc8d81e096712590f524c5991ac0ed3bbc8fd3bd0c7022028a635f548e3ca64b19b69b1ea00f05b22752f91daf0b6dab78e62ba52eb7fd001483045022100f2377f7a67b7fc7f4e2c0c9e3a7de935c32417f5668eda31ea1db401b7dc53030220415fdbc8e91d0f735e70c21952342742e25249b0d062d43efbfc564499f3752601475221023da092f6980e58d2c037173180e9a465476026ee50f96695963e8efe436f54eb21030e9f7b623d2ccc7c9bd44d66d5ce21ce504c0acf6385a132cec6d3c39fa711c152ae3e195220"); [INFO] [stderr] | |_______________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ln/channel.rs:4256:30 [INFO] [stderr] | [INFO] [stderr] 4256 | chan.value_to_self_msat = 6993000000; // 7000000000 - 7000000 [INFO] [stderr] | ^^^^^^^^^^ help: consider: `6_993_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ln/channel.rs:3965:53 [INFO] [stderr] | [INFO] [stderr] 3965 | unsigned_tx = chan.build_commitment_transaction(0xffffffffffff - 42, &keys, true, false, chan.feerate_per_kw); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: consider: `0xffff_ffff_ffff` [INFO] [stderr] ... [INFO] [stderr] 4259 | test_commitment!("3045022100d33c4e541aa1d255d41ea9a3b443b3b822ad8f7f86862638aac1f69f8f760577022007e2a18e6931ce3d3a804b1c78eda1de17dbe1fb7a95488c9a4ec86203953348", [INFO] [stderr] | _____________- [INFO] [stderr] 4260 | | "304402203b1b010c109c2ecbe7feb2d259b9c4126bd5dc99ee693c422ec0a5781fe161ba0220571fe4e2c649dea9c7aaf7e49b382962f6a3494963c97d80fef9a430ca3f7061", [INFO] [stderr] 4261 | | "02000000000101bef67e4e2fb9ddeeb3461973cd4c62abb35050b1add772995b820b584a488489000000000038b02b8005d007000000000000220020403d394747cae42e98ff01734ad5c08f82ba123d3d9a620abda88989651e2ab5b80b000000000000220020c20b5d1f8584fd90443e7b7b720136174fa4b9333c261d04dbbd012635c0f419a00f0000000000002200208c48d15160397c9731df9bc3b236656efb6665fbfe92b4a6878e88a499f741c4c0c62d0000000000160014ccf1af2f2aabee14bb40fa3851ab2301de84311040966a00000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e040047304402203b1b010c109c2ecbe7feb2d259b9c4126bd5dc99ee693c422ec0a5781fe161ba0220571fe4e2c649dea9c7aaf7e49b382962f6a3494963c97d80fef9a430ca3f706101483045022100d33c4e541aa1d255d41ea9a3b443b3b822ad8f7f86862638aac1f69f8f760577022007e2a18e6931ce3d3a804b1c78eda1de17dbe1fb7a95488c9a4ec8620395334801475221023da092f6980e58d2c037173180e9a465476026ee50f96695963e8efe436f54eb21030e9f7b623d2ccc7c9bd44d66d5ce21ce504c0acf6385a132cec6d3c39fa711c152ae3e195220"); [INFO] [stderr] | |_______________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ln/channel.rs:4283:30 [INFO] [stderr] | [INFO] [stderr] 4283 | chan.value_to_self_msat = 6993000000; // 7000000000 - 7000000 [INFO] [stderr] | ^^^^^^^^^^ help: consider: `6_993_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ln/channel.rs:3965:53 [INFO] [stderr] | [INFO] [stderr] 3965 | unsigned_tx = chan.build_commitment_transaction(0xffffffffffff - 42, &keys, true, false, chan.feerate_per_kw); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: consider: `0xffff_ffff_ffff` [INFO] [stderr] ... [INFO] [stderr] 4286 | test_commitment!("304402205e2f76d4657fb732c0dfc820a18a7301e368f5799e06b7828007633741bda6df0220458009ae59d0c6246065c419359e05eb2a4b4ef4a1b310cc912db44eb7924298", [INFO] [stderr] | _____________- [INFO] [stderr] 4287 | | "304402203b12d44254244b8ff3bb4129b0920fd45120ab42f553d9976394b099d500c99e02205e95bb7a3164852ef0c48f9e0eaf145218f8e2c41251b231f03cbdc4f29a5429", [INFO] [stderr] 4288 | | "02000000000101bef67e4e2fb9ddeeb3461973cd4c62abb35050b1add772995b820b584a488489000000000038b02b8004b80b000000000000220020c20b5d1f8584fd90443e7b7b720136174fa4b9333c261d04dbbd012635c0f419a00f0000000000002200208c48d15160397c9731df9bc3b236656efb6665fbfe92b4a6878e88a499f741c4c0c62d0000000000160014ccf1af2f2aabee14bb40fa3851ab2301de843110b8976a00000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e040047304402203b12d44254244b8ff3bb4129b0920fd45120ab42f553d9976394b099d500c99e02205e95bb7a3164852ef0c48f9e0eaf145218f8e2c41251b231f03cbdc4f29a54290147304402205e2f76d4657fb732c0dfc820a18a7301e368f5799e06b7828007633741bda6df0220458009ae59d0c6246065c419359e05eb2a4b4ef4a1b310cc912db44eb792429801475221023da092f6980e58d2c037173180e9a465476026ee50f96695963e8efe436f54eb21030e9f7b623d2ccc7c9bd44d66d5ce21ce504c0acf6385a132cec6d3c39fa711c152ae3e195220"); [INFO] [stderr] | |_______________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ln/channel.rs:4305:30 [INFO] [stderr] | [INFO] [stderr] 4305 | chan.value_to_self_msat = 6993000000; // 7000000000 - 7000000 [INFO] [stderr] | ^^^^^^^^^^ help: consider: `6_993_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ln/channel.rs:3965:53 [INFO] [stderr] | [INFO] [stderr] 3965 | unsigned_tx = chan.build_commitment_transaction(0xffffffffffff - 42, &keys, true, false, chan.feerate_per_kw); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: consider: `0xffff_ffff_ffff` [INFO] [stderr] ... [INFO] [stderr] 4308 | test_commitment!("3045022100c1a3b0b60ca092ed5080121f26a74a20cec6bdee3f8e47bae973fcdceb3eda5502207d467a9873c939bf3aa758014ae67295fedbca52412633f7e5b2670fc7c381c1", [INFO] [stderr] | _____________- [INFO] [stderr] 4309 | | "304402200e930a43c7951162dc15a2b7344f48091c74c70f7024e7116e900d8bcfba861c022066fa6cbda3929e21daa2e7e16a4b948db7e8919ef978402360d1095ffdaff7b0", [INFO] [stderr] 4310 | | "02000000000101bef67e4e2fb9ddeeb3461973cd4c62abb35050b1add772995b820b584a488489000000000038b02b8004b80b000000000000220020c20b5d1f8584fd90443e7b7b720136174fa4b9333c261d04dbbd012635c0f419a00f0000000000002200208c48d15160397c9731df9bc3b236656efb6665fbfe92b4a6878e88a499f741c4c0c62d0000000000160014ccf1af2f2aabee14bb40fa3851ab2301de8431106f916a00000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e040047304402200e930a43c7951162dc15a2b7344f48091c74c70f7024e7116e900d8bcfba861c022066fa6cbda3929e21daa2e7e16a4b948db7e8919ef978402360d1095ffdaff7b001483045022100c1a3b0b60ca092ed5080121f26a74a20cec6bdee3f8e47bae973fcdceb3eda5502207d467a9873c939bf3aa758014ae67295fedbca52412633f7e5b2670fc7c381c101475221023da092f6980e58d2c037173180e9a465476026ee50f96695963e8efe436f54eb21030e9f7b623d2ccc7c9bd44d66d5ce21ce504c0acf6385a132cec6d3c39fa711c152ae3e195220"); [INFO] [stderr] | |_________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ln/channel.rs:4327:30 [INFO] [stderr] | [INFO] [stderr] 4327 | chan.value_to_self_msat = 6993000000; // 7000000000 - 7000000 [INFO] [stderr] | ^^^^^^^^^^ help: consider: `6_993_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ln/channel.rs:3965:53 [INFO] [stderr] | [INFO] [stderr] 3965 | unsigned_tx = chan.build_commitment_transaction(0xffffffffffff - 42, &keys, true, false, chan.feerate_per_kw); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: consider: `0xffff_ffff_ffff` [INFO] [stderr] ... [INFO] [stderr] 4330 | test_commitment!("30450221008b7c191dd46893b67b628e618d2dc8e81169d38bade310181ab77d7c94c6675e02203b4dd131fd7c9deb299560983dcdc485545c98f989f7ae8180c28289f9e6bdb0", [INFO] [stderr] | _____________- [INFO] [stderr] 4331 | | "3044022047305531dd44391dce03ae20f8735005c615eb077a974edb0059ea1a311857d602202e0ed6972fbdd1e8cb542b06e0929bc41b2ddf236e04cb75edd56151f4197506", [INFO] [stderr] 4332 | | "02000000000101bef67e4e2fb9ddeeb3461973cd4c62abb35050b1add772995b820b584a488489000000000038b02b8003a00f0000000000002200208c48d15160397c9731df9bc3b236656efb6665fbfe92b4a6878e88a499f741c4c0c62d0000000000160014ccf1af2f2aabee14bb40fa3851ab2301de843110eb936a00000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e0400473044022047305531dd44391dce03ae20f8735005c615eb077a974edb0059ea1a311857d602202e0ed6972fbdd1e8cb542b06e0929bc41b2ddf236e04cb75edd56151f4197506014830450221008b7c191dd46893b67b628e618d2dc8e81169d38bade310181ab77d7c94c6675e02203b4dd131fd7c9deb299560983dcdc485545c98f989f7ae8180c28289f9e6bdb001475221023da092f6980e58d2c037173180e9a465476026ee50f96695963e8efe436f54eb21030e9f7b623d2ccc7c9bd44d66d5ce21ce504c0acf6385a132cec6d3c39fa711c152ae3e195220"); [INFO] [stderr] | |___________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ln/channel.rs:4344:30 [INFO] [stderr] | [INFO] [stderr] 4344 | chan.value_to_self_msat = 6993000000; // 7000000000 - 7000000 [INFO] [stderr] | ^^^^^^^^^^ help: consider: `6_993_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ln/channel.rs:3965:53 [INFO] [stderr] | [INFO] [stderr] 3965 | unsigned_tx = chan.build_commitment_transaction(0xffffffffffff - 42, &keys, true, false, chan.feerate_per_kw); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: consider: `0xffff_ffff_ffff` [INFO] [stderr] ... [INFO] [stderr] 4347 | test_commitment!("304402206d6cb93969d39177a09d5d45b583f34966195b77c7e585cf47ac5cce0c90cefb022031d71ae4e33a4e80df7f981d696fbdee517337806a3c7138b7491e2cbb077a0e", [INFO] [stderr] | _____________- [INFO] [stderr] 4348 | | "304402206a2679efa3c7aaffd2a447fd0df7aba8792858b589750f6a1203f9259173198a022008d52a0e77a99ab533c36206cb15ad7aeb2aa72b93d4b571e728cb5ec2f6fe26", [INFO] [stderr] 4349 | | "02000000000101bef67e4e2fb9ddeeb3461973cd4c62abb35050b1add772995b820b584a488489000000000038b02b8003a00f0000000000002200208c48d15160397c9731df9bc3b236656efb6665fbfe92b4a6878e88a499f741c4c0c62d0000000000160014ccf1af2f2aabee14bb40fa3851ab2301de843110ae8f6a00000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e040047304402206a2679efa3c7aaffd2a447fd0df7aba8792858b589750f6a1203f9259173198a022008d52a0e77a99ab533c36206cb15ad7aeb2aa72b93d4b571e728cb5ec2f6fe260147304402206d6cb93969d39177a09d5d45b583f34966195b77c7e585cf47ac5cce0c90cefb022031d71ae4e33a4e80df7f981d696fbdee517337806a3c7138b7491e2cbb077a0e01475221023da092f6980e58d2c037173180e9a465476026ee50f96695963e8efe436f54eb21030e9f7b623d2ccc7c9bd44d66d5ce21ce504c0acf6385a132cec6d3c39fa711c152ae3e195220"); [INFO] [stderr] | |_________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ln/channel.rs:4361:30 [INFO] [stderr] | [INFO] [stderr] 4361 | chan.value_to_self_msat = 6993000000; // 7000000000 - 7000000 [INFO] [stderr] | ^^^^^^^^^^ help: consider: `6_993_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ln/channel.rs:3965:53 [INFO] [stderr] | [INFO] [stderr] 3965 | unsigned_tx = chan.build_commitment_transaction(0xffffffffffff - 42, &keys, true, false, chan.feerate_per_kw); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: consider: `0xffff_ffff_ffff` [INFO] [stderr] ... [INFO] [stderr] 4364 | test_commitment!("304402200769ba89c7330dfa4feba447b6e322305f12ac7dac70ec6ba997ed7c1b598d0802204fe8d337e7fee781f9b7b1a06e580b22f4f79d740059560191d7db53f8765552", [INFO] [stderr] | _____________- [INFO] [stderr] 4365 | | "3045022100a012691ba6cea2f73fa8bac37750477e66363c6d28813b0bb6da77c8eb3fb0270220365e99c51304b0b1a6ab9ea1c8500db186693e39ec1ad5743ee231b0138384b9", [INFO] [stderr] 4366 | | "02000000000101bef67e4e2fb9ddeeb3461973cd4c62abb35050b1add772995b820b584a488489000000000038b02b8002c0c62d0000000000160014ccf1af2f2aabee14bb40fa3851ab2301de843110fa926a00000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80e0400483045022100a012691ba6cea2f73fa8bac37750477e66363c6d28813b0bb6da77c8eb3fb0270220365e99c51304b0b1a6ab9ea1c8500db186693e39ec1ad5743ee231b0138384b90147304402200769ba89c7330dfa4feba447b6e322305f12ac7dac70ec6ba997ed7c1b598d0802204fe8d337e7fee781f9b7b1a06e580b22f4f79d740059560191d7db53f876555201475221023da092f6980e58d2c037173180e9a465476026ee50f96695963e8efe436f54eb21030e9f7b623d2ccc7c9bd44d66d5ce21ce504c0acf6385a132cec6d3c39fa711c152ae3e195220"); [INFO] [stderr] | |_____________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ln/channel.rs:4373:30 [INFO] [stderr] | [INFO] [stderr] 4373 | chan.value_to_self_msat = 6993000000; // 7000000000 - 7000000 [INFO] [stderr] | ^^^^^^^^^^ help: consider: `6_993_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ln/channel.rs:4374:26 [INFO] [stderr] | [INFO] [stderr] 4374 | chan.feerate_per_kw = 9651180; [INFO] [stderr] | ^^^^^^^ help: consider: `9_651_180` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ln/channel.rs:3965:53 [INFO] [stderr] | [INFO] [stderr] 3965 | unsigned_tx = chan.build_commitment_transaction(0xffffffffffff - 42, &keys, true, false, chan.feerate_per_kw); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: consider: `0xffff_ffff_ffff` [INFO] [stderr] ... [INFO] [stderr] 4376 | test_commitment!("3044022037f83ff00c8e5fb18ae1f918ffc24e54581775a20ff1ae719297ef066c71caa9022039c529cccd89ff6c5ed1db799614533844bd6d101da503761c45c713996e3bbd", [INFO] [stderr] | _____________- [INFO] [stderr] 4377 | | "30440220514f977bf7edc442de8ce43ace9686e5ebdc0f893033f13e40fb46c8b8c6e1f90220188006227d175f5c35da0b092c57bea82537aed89f7778204dc5bacf4f29f2b9", [INFO] [stderr] 4378 | | "02000000000101bef67e4e2fb9ddeeb3461973cd4c62abb35050b1add772995b820b584a488489000000000038b02b800222020000000000002200204adb4e2f00643db396dd120d4e7dc17625f5f2c11a40d857accc862d6b7dd80ec0c62d0000000000160014ccf1af2f2aabee14bb40fa3851ab2301de84311004004730440220514f977bf7edc442de8ce43ace9686e5ebdc0f893033f13e40fb46c8b8c6e1f90220188006227d175f5c35da0b092c57bea82537aed89f7778204dc5bacf4f29f2b901473044022037f83ff00c8e5fb18ae1f918ffc24e54581775a20ff1ae719297ef066c71caa9022039c529cccd89ff6c5ed1db799614533844bd6d101da503761c45c713996e3bbd01475221023da092f6980e58d2c037173180e9a465476026ee50f96695963e8efe436f54eb21030e9f7b623d2ccc7c9bd44d66d5ce21ce504c0acf6385a132cec6d3c39fa711c152ae3e195220"); [INFO] [stderr] | |___________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ln/channel.rs:4385:30 [INFO] [stderr] | [INFO] [stderr] 4385 | chan.value_to_self_msat = 6993000000; // 7000000000 - 7000000 [INFO] [stderr] | ^^^^^^^^^^ help: consider: `6_993_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ln/channel.rs:4386:26 [INFO] [stderr] | [INFO] [stderr] 4386 | chan.feerate_per_kw = 9651181; [INFO] [stderr] | ^^^^^^^ help: consider: `9_651_181` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ln/channel.rs:3965:53 [INFO] [stderr] | [INFO] [stderr] 3965 | unsigned_tx = chan.build_commitment_transaction(0xffffffffffff - 42, &keys, true, false, chan.feerate_per_kw); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: consider: `0xffff_ffff_ffff` [INFO] [stderr] ... [INFO] [stderr] 4388 | test_commitment!("3044022064901950be922e62cbe3f2ab93de2b99f37cff9fc473e73e394b27f88ef0731d02206d1dfa227527b4df44a07599289e207d6fd9cca60c0365682dcd3deaf739567e", [INFO] [stderr] | _____________- [INFO] [stderr] 4389 | | "3044022031a82b51bd014915fe68928d1abf4b9885353fb896cac10c3fdd88d7f9c7f2e00220716bda819641d2c63e65d3549b6120112e1aeaf1742eed94a471488e79e206b1", [INFO] [stderr] 4390 | | "02000000000101bef67e4e2fb9ddeeb3461973cd4c62abb35050b1add772995b820b584a488489000000000038b02b8001c0c62d0000000000160014ccf1af2f2aabee14bb40fa3851ab2301de8431100400473044022031a82b51bd014915fe68928d1abf4b9885353fb896cac10c3fdd88d7f9c7f2e00220716bda819641d2c63e65d3549b6120112e1aeaf1742eed94a471488e79e206b101473044022064901950be922e62cbe3f2ab93de2b99f37cff9fc473e73e394b27f88ef0731d02206d1dfa227527b4df44a07599289e207d6fd9cca60c0365682dcd3deaf739567e01475221023da092f6980e58d2c037173180e9a465476026ee50f96695963e8efe436f54eb21030e9f7b623d2ccc7c9bd44d66d5ce21ce504c0acf6385a132cec6d3c39fa711c152ae3e195220"); [INFO] [stderr] | |_____________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ln/channel.rs:4397:30 [INFO] [stderr] | [INFO] [stderr] 4397 | chan.value_to_self_msat = 6993000000; // 7000000000 - 7000000 [INFO] [stderr] | ^^^^^^^^^^ help: consider: `6_993_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ln/channel.rs:4398:26 [INFO] [stderr] | [INFO] [stderr] 4398 | chan.feerate_per_kw = 9651936; [INFO] [stderr] | ^^^^^^^ help: consider: `9_651_936` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ln/channel.rs:3965:53 [INFO] [stderr] | [INFO] [stderr] 3965 | unsigned_tx = chan.build_commitment_transaction(0xffffffffffff - 42, &keys, true, false, chan.feerate_per_kw); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: consider: `0xffff_ffff_ffff` [INFO] [stderr] ... [INFO] [stderr] 4400 | test_commitment!("3044022064901950be922e62cbe3f2ab93de2b99f37cff9fc473e73e394b27f88ef0731d02206d1dfa227527b4df44a07599289e207d6fd9cca60c0365682dcd3deaf739567e", [INFO] [stderr] | _____________- [INFO] [stderr] 4401 | | "3044022031a82b51bd014915fe68928d1abf4b9885353fb896cac10c3fdd88d7f9c7f2e00220716bda819641d2c63e65d3549b6120112e1aeaf1742eed94a471488e79e206b1", [INFO] [stderr] 4402 | | "02000000000101bef67e4e2fb9ddeeb3461973cd4c62abb35050b1add772995b820b584a488489000000000038b02b8001c0c62d0000000000160014ccf1af2f2aabee14bb40fa3851ab2301de8431100400473044022031a82b51bd014915fe68928d1abf4b9885353fb896cac10c3fdd88d7f9c7f2e00220716bda819641d2c63e65d3549b6120112e1aeaf1742eed94a471488e79e206b101473044022064901950be922e62cbe3f2ab93de2b99f37cff9fc473e73e394b27f88ef0731d02206d1dfa227527b4df44a07599289e207d6fd9cca60c0365682dcd3deaf739567e01475221023da092f6980e58d2c037173180e9a465476026ee50f96695963e8efe436f54eb21030e9f7b623d2ccc7c9bd44d66d5ce21ce504c0acf6385a132cec6d3c39fa711c152ae3e195220"); [INFO] [stderr] | |_____________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________________- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ln/channel.rs:4414:56 [INFO] [stderr] | [INFO] [stderr] 4414 | assert_eq!(chan_utils::build_commitment_secret(seed, 281474976710655), [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider: `281_474_976_710_655` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ln/channel.rs:4418:56 [INFO] [stderr] | [INFO] [stderr] 4418 | assert_eq!(chan_utils::build_commitment_secret(seed, 281474976710655), [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: consider: `281_474_976_710_655` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ln/channel.rs:4421:56 [INFO] [stderr] | [INFO] [stderr] 4421 | assert_eq!(chan_utils::build_commitment_secret(seed, 0xaaaaaaaaaaa), [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider: `0x0aaa_aaaa_aaaa` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/ln/channel.rs:4424:56 [INFO] [stderr] | [INFO] [stderr] 4424 | assert_eq!(chan_utils::build_commitment_secret(seed, 0x555555555555), [INFO] [stderr] | ^^^^^^^^^^^^^^ help: consider: `0x5555_5555_5555` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: function is never used: `sort_inputs` [INFO] [stderr] --> src/util/transaction_utils.rs:21:1 [INFO] [stderr] | [INFO] [stderr] 21 | pub fn sort_inputs(inputs: &mut Vec<(TxIn, T)>) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: field is never used: `logger` [INFO] [stderr] --> src/chain/chaininterface.rs:207:2 [INFO] [stderr] | [INFO] [stderr] 207 | logger: Arc, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: field is never used: `logger` [INFO] [stderr] --> src/chain/keysinterface.rs:162:2 [INFO] [stderr] | [INFO] [stderr] 162 | logger: Arc, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `SigsMode` [INFO] [stderr] --> src/ln/channelmonitor.rs:236:2 [INFO] [stderr] | [INFO] [stderr] 236 | SigsMode { [INFO] [stderr] | _____^ [INFO] [stderr] 237 | | revocation_base_key: PublicKey, [INFO] [stderr] 238 | | htlc_base_key: PublicKey, [INFO] [stderr] 239 | | sigs: HashMap, [INFO] [stderr] 240 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] [INFO] [stderr] warning: field is never used: `time_created` [INFO] [stderr] --> src/ln/channel.rs:155:3 [INFO] [stderr] | [INFO] [stderr] 155 | time_created: Instant, //TODO: Some kind of timeout thing-a-majig [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: large size difference between variants [INFO] [stderr] --> src/util/events.rs:190:2 [INFO] [stderr] | [INFO] [stderr] 190 | BroadcastChannelAnnouncement { [INFO] [stderr] | _____^ [INFO] [stderr] 191 | | /// The channel_announcement which should be sent. [INFO] [stderr] 192 | | msg: msgs::ChannelAnnouncement, [INFO] [stderr] 193 | | /// The followup channel_update which should be sent. [INFO] [stderr] 194 | | update_msg: msgs::ChannelUpdate, [INFO] [stderr] 195 | | }, [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::large_enum_variant)] on by default [INFO] [stderr] help: consider boxing the large fields to reduce the total size of the enum [INFO] [stderr] --> src/util/events.rs:190:2 [INFO] [stderr] | [INFO] [stderr] 190 | BroadcastChannelAnnouncement { [INFO] [stderr] | _____^ [INFO] [stderr] 191 | | /// The channel_announcement which should be sent. [INFO] [stderr] 192 | | msg: msgs::ChannelAnnouncement, [INFO] [stderr] 193 | | /// The followup channel_update which should be sent. [INFO] [stderr] 194 | | update_msg: msgs::ChannelUpdate, [INFO] [stderr] 195 | | }, [INFO] [stderr] | |_____^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_enum_variant [INFO] [stderr] [INFO] [stderr] warning: impl for `HashMap` should be generalized over different hashers [INFO] [stderr] --> src/util/ser.rs:211:26 [INFO] [stderr] | [INFO] [stderr] 211 | impl Writeable for HashMap [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::implicit_hasher)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#implicit_hasher [INFO] [stderr] help: consider adding a type parameter [INFO] [stderr] | [INFO] [stderr] 211 | impl Writeable for HashMap [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: impl for `HashMap` should be generalized over different hashers [INFO] [stderr] --> src/util/ser.rs:226:31 [INFO] [stderr] | [INFO] [stderr] 226 | impl Readable for HashMap [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#implicit_hasher [INFO] [stderr] help: consider adding a type parameter [INFO] [stderr] | [INFO] [stderr] 226 | impl Readable for HashMap [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^ [INFO] [stderr] help: ...and use generic constructor [INFO] [stderr] | [INFO] [stderr] 234 | let mut ret = HashMap::with_capacity_and_hasher(len as usize, Default::default()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: slow zero-filling initialization [INFO] [stderr] --> src/util/ser.rs:256:3 [INFO] [stderr] | [INFO] [stderr] 255 | let mut ret = Vec::with_capacity(len as usize); [INFO] [stderr] | -------------------------------- help: consider replace allocation with: `vec![0; len as usize]` [INFO] [stderr] 256 | ret.resize(len as usize, 0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::slow_vector_initialization)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#slow_vector_initialization [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/util/ser.rs:306:3 [INFO] [stderr] | [INFO] [stderr] 306 | if let &Some(ref script) = self { [INFO] [stderr] | _________^ [INFO] [stderr] 307 | | script.write(w)?; [INFO] [stderr] 308 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 306 | if let Some(ref script) = *self { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ ^^^^^ [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/util/byte_utils.rs:3:3 [INFO] [stderr] | [INFO] [stderr] 3 | ((v[0] as u16) << 8*1) | [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u16::from(v[0])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `8` [INFO] [stderr] --> src/util/byte_utils.rs:3:20 [INFO] [stderr] | [INFO] [stderr] 3 | ((v[0] as u16) << 8*1) | [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_op)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `(v[1] as u16)` [INFO] [stderr] --> src/util/byte_utils.rs:4:2 [INFO] [stderr] | [INFO] [stderr] 4 | ((v[1] as u16) << 8*0) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/util/byte_utils.rs:4:3 [INFO] [stderr] | [INFO] [stderr] 4 | ((v[1] as u16) << 8*0) [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u16::from(v[1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: this operation will always return zero. This is likely not the intended outcome [INFO] [stderr] --> src/util/byte_utils.rs:4:20 [INFO] [stderr] | [INFO] [stderr] 4 | ((v[1] as u16) << 8*0) [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::erasing_op)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#erasing_op [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/util/byte_utils.rs:8:3 [INFO] [stderr] | [INFO] [stderr] 8 | ((v[0] as u32) << 8*3) | [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u32::from(v[0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/util/byte_utils.rs:9:3 [INFO] [stderr] | [INFO] [stderr] 9 | ((v[1] as u32) << 8*2) | [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u32::from(v[1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/util/byte_utils.rs:10:3 [INFO] [stderr] | [INFO] [stderr] 10 | ((v[2] as u32) << 8*1) | [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u32::from(v[2])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `8` [INFO] [stderr] --> src/util/byte_utils.rs:10:20 [INFO] [stderr] | [INFO] [stderr] 10 | ((v[2] as u32) << 8*1) | [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `(v[3] as u32)` [INFO] [stderr] --> src/util/byte_utils.rs:11:2 [INFO] [stderr] | [INFO] [stderr] 11 | ((v[3] as u32) << 8*0) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/util/byte_utils.rs:11:3 [INFO] [stderr] | [INFO] [stderr] 11 | ((v[3] as u32) << 8*0) [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u32::from(v[3])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: this operation will always return zero. This is likely not the intended outcome [INFO] [stderr] --> src/util/byte_utils.rs:11:20 [INFO] [stderr] | [INFO] [stderr] 11 | ((v[3] as u32) << 8*0) [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#erasing_op [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/util/byte_utils.rs:15:3 [INFO] [stderr] | [INFO] [stderr] 15 | ((v[0] as u64) << 8*5) | [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u64::from(v[0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/util/byte_utils.rs:16:3 [INFO] [stderr] | [INFO] [stderr] 16 | ((v[1] as u64) << 8*4) | [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u64::from(v[1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/util/byte_utils.rs:17:3 [INFO] [stderr] | [INFO] [stderr] 17 | ((v[2] as u64) << 8*3) | [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u64::from(v[2])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/util/byte_utils.rs:18:3 [INFO] [stderr] | [INFO] [stderr] 18 | ((v[3] as u64) << 8*2) | [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u64::from(v[3])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/util/byte_utils.rs:19:3 [INFO] [stderr] | [INFO] [stderr] 19 | ((v[4] as u64) << 8*1) | [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u64::from(v[4])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `8` [INFO] [stderr] --> src/util/byte_utils.rs:19:20 [INFO] [stderr] | [INFO] [stderr] 19 | ((v[4] as u64) << 8*1) | [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `(v[5] as u64)` [INFO] [stderr] --> src/util/byte_utils.rs:20:2 [INFO] [stderr] | [INFO] [stderr] 20 | ((v[5] as u64) << 8*0) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/util/byte_utils.rs:20:3 [INFO] [stderr] | [INFO] [stderr] 20 | ((v[5] as u64) << 8*0) [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u64::from(v[5])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: this operation will always return zero. This is likely not the intended outcome [INFO] [stderr] --> src/util/byte_utils.rs:20:20 [INFO] [stderr] | [INFO] [stderr] 20 | ((v[5] as u64) << 8*0) [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#erasing_op [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/util/byte_utils.rs:24:3 [INFO] [stderr] | [INFO] [stderr] 24 | ((v[0] as u64) << 8*7) | [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u64::from(v[0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/util/byte_utils.rs:25:3 [INFO] [stderr] | [INFO] [stderr] 25 | ((v[1] as u64) << 8*6) | [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u64::from(v[1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/util/byte_utils.rs:26:3 [INFO] [stderr] | [INFO] [stderr] 26 | ((v[2] as u64) << 8*5) | [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u64::from(v[2])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/util/byte_utils.rs:27:3 [INFO] [stderr] | [INFO] [stderr] 27 | ((v[3] as u64) << 8*4) | [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u64::from(v[3])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/util/byte_utils.rs:28:3 [INFO] [stderr] | [INFO] [stderr] 28 | ((v[4] as u64) << 8*3) | [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u64::from(v[4])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/util/byte_utils.rs:29:3 [INFO] [stderr] | [INFO] [stderr] 29 | ((v[5] as u64) << 8*2) | [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u64::from(v[5])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/util/byte_utils.rs:30:3 [INFO] [stderr] | [INFO] [stderr] 30 | ((v[6] as u64) << 8*1) | [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u64::from(v[6])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `8` [INFO] [stderr] --> src/util/byte_utils.rs:30:20 [INFO] [stderr] | [INFO] [stderr] 30 | ((v[6] as u64) << 8*1) | [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `(v[7] as u64)` [INFO] [stderr] --> src/util/byte_utils.rs:31:2 [INFO] [stderr] | [INFO] [stderr] 31 | ((v[7] as u64) << 8*0) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/util/byte_utils.rs:31:3 [INFO] [stderr] | [INFO] [stderr] 31 | ((v[7] as u64) << 8*0) [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `u64::from(v[7])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: this operation will always return zero. This is likely not the intended outcome [INFO] [stderr] --> src/util/byte_utils.rs:31:20 [INFO] [stderr] | [INFO] [stderr] 31 | ((v[7] as u64) << 8*0) [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#erasing_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `8` [INFO] [stderr] --> src/util/byte_utils.rs:37:16 [INFO] [stderr] | [INFO] [stderr] 37 | v[0] = ((u >> 8*1) & 0xff) as u8; [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `u` [INFO] [stderr] --> src/util/byte_utils.rs:38:10 [INFO] [stderr] | [INFO] [stderr] 38 | v[1] = ((u >> 8*0) & 0xff) as u8; [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] error: this operation will always return zero. This is likely not the intended outcome [INFO] [stderr] --> src/util/byte_utils.rs:38:16 [INFO] [stderr] | [INFO] [stderr] 38 | v[1] = ((u >> 8*0) & 0xff) as u8; [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#erasing_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `8` [INFO] [stderr] --> src/util/byte_utils.rs:46:16 [INFO] [stderr] | [INFO] [stderr] 46 | v[2] = ((u >> 8*1) & 0xff) as u8; [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `u` [INFO] [stderr] --> src/util/byte_utils.rs:47:10 [INFO] [stderr] | [INFO] [stderr] 47 | v[3] = ((u >> 8*0) & 0xff) as u8; [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] error: this operation will always return zero. This is likely not the intended outcome [INFO] [stderr] --> src/util/byte_utils.rs:47:16 [INFO] [stderr] | [INFO] [stderr] 47 | v[3] = ((u >> 8*0) & 0xff) as u8; [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#erasing_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `8` [INFO] [stderr] --> src/util/byte_utils.rs:58:16 [INFO] [stderr] | [INFO] [stderr] 58 | v[4] = ((u >> 8*1) & 0xff) as u8; [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `u` [INFO] [stderr] --> src/util/byte_utils.rs:59:10 [INFO] [stderr] | [INFO] [stderr] 59 | v[5] = ((u >> 8*0) & 0xff) as u8; [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] error: this operation will always return zero. This is likely not the intended outcome [INFO] [stderr] --> src/util/byte_utils.rs:59:16 [INFO] [stderr] | [INFO] [stderr] 59 | v[5] = ((u >> 8*0) & 0xff) as u8; [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#erasing_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `8` [INFO] [stderr] --> src/util/byte_utils.rs:71:16 [INFO] [stderr] | [INFO] [stderr] 71 | v[6] = ((u >> 8*1) & 0xff) as u8; [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `u` [INFO] [stderr] --> src/util/byte_utils.rs:72:10 [INFO] [stderr] | [INFO] [stderr] 72 | v[7] = ((u >> 8*0) & 0xff) as u8; [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] error: this operation will always return zero. This is likely not the intended outcome [INFO] [stderr] --> src/util/byte_utils.rs:72:16 [INFO] [stderr] | [INFO] [stderr] 72 | v[7] = ((u >> 8*0) & 0xff) as u8; [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#erasing_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `u` [INFO] [stderr] --> src/util/byte_utils.rs:79:10 [INFO] [stderr] | [INFO] [stderr] 79 | v[0] = ((u >> 8*0) & 0xff) as u8; [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] error: this operation will always return zero. This is likely not the intended outcome [INFO] [stderr] --> src/util/byte_utils.rs:79:16 [INFO] [stderr] | [INFO] [stderr] 79 | v[0] = ((u >> 8*0) & 0xff) as u8; [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#erasing_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `8` [INFO] [stderr] --> src/util/byte_utils.rs:80:16 [INFO] [stderr] | [INFO] [stderr] 80 | v[1] = ((u >> 8*1) & 0xff) as u8; [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: equality checks against false can be replaced by a negation [INFO] [stderr] --> src/util/chacha20poly1305rfc.rs:70:12 [INFO] [stderr] | [INFO] [stderr] 70 | assert!(self.finished == false); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `!self.finished` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::bool_comparison)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: equality checks against false can be replaced by a negation [INFO] [stderr] --> src/util/chacha20poly1305rfc.rs:85:12 [INFO] [stderr] | [INFO] [stderr] 85 | assert!(self.finished == false); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `!self.finished` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/util/macro_logger.rs:43:26 [INFO] [stderr] | [INFO] [stderr] 43 | for i in OutPoint::new(self.0.clone(), self.1).to_channel_id().iter() { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try dereferencing it: `*self.0` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] error: you are deriving `Hash` but have implemented `PartialEq` explicitly [INFO] [stderr] --> src/util/logger.rs:23:34 [INFO] [stderr] | [INFO] [stderr] 23 | #[derive(Copy, Clone, Eq, Debug, Hash)] [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::derive_hash_xor_eq)] on by default [INFO] [stderr] note: `PartialEq` implemented here [INFO] [stderr] --> src/util/logger.rs:39:1 [INFO] [stderr] | [INFO] [stderr] 39 | / impl PartialEq for Level { [INFO] [stderr] 40 | | #[inline] [INFO] [stderr] 41 | | fn eq(&self, other: &Level) -> bool { [INFO] [stderr] 42 | | *self as usize == *other as usize [INFO] [stderr] 43 | | } [INFO] [stderr] 44 | | } [INFO] [stderr] | |_^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derive_hash_xor_eq [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `util::config::UserConfig` [INFO] [stderr] --> src/util/config.rs:15:2 [INFO] [stderr] | [INFO] [stderr] 15 | pub fn new() -> Self{ [INFO] [stderr] | _____^ [INFO] [stderr] 16 | | UserConfig { [INFO] [stderr] 17 | | channel_limits: ChannelHandshakeLimits::new(), [INFO] [stderr] 18 | | channel_options: ChannelConfig::new(), [INFO] [stderr] 19 | | } [INFO] [stderr] 20 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 13 | impl Default for util::config::UserConfig { [INFO] [stderr] 14 | fn default() -> Self { [INFO] [stderr] 15 | Self::new() [INFO] [stderr] 16 | } [INFO] [stderr] 17 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `util::config::ChannelHandshakeLimits` [INFO] [stderr] --> src/util/config.rs:78:2 [INFO] [stderr] | [INFO] [stderr] 78 | pub fn new() -> Self { [INFO] [stderr] | _____^ [INFO] [stderr] 79 | | ChannelHandshakeLimits { [INFO] [stderr] 80 | | min_funding_satoshis: 0, [INFO] [stderr] 81 | | max_htlc_minimum_msat: ::max_value(), [INFO] [stderr] ... | [INFO] [stderr] 89 | | } [INFO] [stderr] 90 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 29 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `util::config::ChannelConfig` [INFO] [stderr] --> src/util/config.rs:115:2 [INFO] [stderr] | [INFO] [stderr] 115 | pub fn new() -> Self { [INFO] [stderr] | _____^ [INFO] [stderr] 116 | | ChannelConfig { [INFO] [stderr] 117 | | fee_proportional_millionths: 0, [INFO] [stderr] 118 | | announced_channel: false, [INFO] [stderr] 119 | | } [INFO] [stderr] 120 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 96 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `chain::chaininterface::ChainWatchedUtil` [INFO] [stderr] --> src/chain/chaininterface.rs:128:2 [INFO] [stderr] | [INFO] [stderr] 128 | pub fn new() -> Self { [INFO] [stderr] | _____^ [INFO] [stderr] 129 | | Self { [INFO] [stderr] 130 | | watch_all: false, [INFO] [stderr] 131 | | watched_txn: HashSet::new(), [INFO] [stderr] 132 | | watched_outpoints: HashSet::new(), [INFO] [stderr] 133 | | } [INFO] [stderr] 134 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 113 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/chain/chaininterface.rs:284:4 [INFO] [stderr] | [INFO] [stderr] 284 | match listener.upgrade() { [INFO] [stderr] | _____________^ [INFO] [stderr] 285 | | Some(arc) => arc.block_disconnected(header), [INFO] [stderr] 286 | | None => () [INFO] [stderr] 287 | | } [INFO] [stderr] | |_____________^ help: try this: `if let Some(arc) = listener.upgrade() { arc.block_disconnected(header) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/chain/chaininterface.rs:302:4 [INFO] [stderr] | [INFO] [stderr] 302 | match listener.upgrade() { [INFO] [stderr] | _____________^ [INFO] [stderr] 303 | | Some(arc) => arc.block_connected(header, height, txn_matched, indexes_of_txn_matched), [INFO] [stderr] 304 | | None => () [INFO] [stderr] 305 | | } [INFO] [stderr] | |_____________^ help: try this: `if let Some(arc) = listener.upgrade() { arc.block_connected(header, height, txn_matched, indexes_of_txn_matched) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `self.index` [INFO] [stderr] --> src/chain/transaction.rs:29:15 [INFO] [stderr] | [INFO] [stderr] 29 | res[31] ^= ((self.index >> 0) & 0xff) as u8; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/chain/transaction.rs:37:10 [INFO] [stderr] | [INFO] [stderr] 37 | vout: self.index as u32, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `u32::from(self.index)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: Err(_) will match all errors, maybe not a good idea [INFO] [stderr] --> src/chain/keysinterface.rs:198:4 [INFO] [stderr] | [INFO] [stderr] 198 | Err(_) => panic!("Your rng is busted"), [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_wild_err_arm)] on by default [INFO] [stderr] = note: to remove this warning, match each error separately or use unreachable macro [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_wild_err_arm [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/chain/keysinterface.rs:170:48 [INFO] [stderr] | [INFO] [stderr] 170 | match ExtendedPrivKey::new_master(&secp_ctx, network.clone(), seed) { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try removing the `clone` call: `network` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: Err(_) will match all errors, maybe not a good idea [INFO] [stderr] --> src/chain/keysinterface.rs:180:6 [INFO] [stderr] | [INFO] [stderr] 180 | Err(_) => panic!("Your RNG is busted"), [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: to remove this warning, match each error separately or use unreachable macro [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_wild_err_arm [INFO] [stderr] [INFO] [stderr] warning: Err(_) will match all errors, maybe not a good idea [INFO] [stderr] --> src/chain/keysinterface.rs:184:6 [INFO] [stderr] | [INFO] [stderr] 184 | Err(_) => panic!("Your RNG is busted"), [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: to remove this warning, match each error separately or use unreachable macro [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_wild_err_arm [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/chain/keysinterface.rs:205:3 [INFO] [stderr] | [INFO] [stderr] 205 | self.node_secret.clone() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.node_secret` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/chain/keysinterface.rs:213:3 [INFO] [stderr] | [INFO] [stderr] 213 | self.shutdown_pubkey.clone() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.shutdown_pubkey` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: large size difference between variants [INFO] [stderr] --> src/ln/channelmanager.rs:88:3 [INFO] [stderr] | [INFO] [stderr] 88 | Forward(PendingForwardHTLCInfo), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_enum_variant [INFO] [stderr] help: consider boxing the large fields to reduce the total size of the enum [INFO] [stderr] | [INFO] [stderr] 88 | Forward(Box), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (8/7) [INFO] [stderr] --> src/ln/channelmanager.rs:448:2 [INFO] [stderr] | [INFO] [stderr] 448 | pub fn new(network: Network, feeest: Arc, monitor: Arc, chain_monitor: Arc, tx_broadcaster: Arc, logger: Arc,keys_manager: Arc, config: UserConfig) -> Result, secp256k1::Error> { [INFO] [stderr] | _____^ [INFO] [stderr] 449 | | let secp_ctx = Secp256k1::new(); [INFO] [stderr] 450 | | [INFO] [stderr] 451 | | let res = Arc::new(ChannelManager { [INFO] [stderr] ... | [INFO] [stderr] 482 | | Ok(res) [INFO] [stderr] 483 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::too_many_arguments)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/ln/channelmanager.rs:503:38 [INFO] [stderr] | [INFO] [stderr] 503 | let res = channel.get_open_channel(self.genesis_hash.clone(), &*self.fee_estimator); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.genesis_hash` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/ln/channelmanager.rs:531:17 [INFO] [stderr] | [INFO] [stderr] 531 | channel_id: (*channel_id).clone(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `(*channel_id)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/ln/channelmanager.rs:552:18 [INFO] [stderr] | [INFO] [stderr] 552 | channel_id: (*channel_id).clone(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `(*channel_id)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/ln/channelmanager.rs:733:26 [INFO] [stderr] | [INFO] [stderr] 733 | let mut blinded_priv = session_priv.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*session_priv` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `arr`. [INFO] [stderr] --> src/ln/channelmanager.rs:819:12 [INFO] [stderr] | [INFO] [stderr] 819 | for i in 0..65 { [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 819 | for in arr.iter_mut().take(65) { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: slow zero-filling initialization [INFO] [stderr] --> src/ln/channelmanager.rs:836:3 [INFO] [stderr] | [INFO] [stderr] 835 | let mut buf = Vec::with_capacity(21*65); [INFO] [stderr] | ------------------------- help: consider replace allocation with: `vec![0; 21*65]` [INFO] [stderr] 836 | buf.resize(21*65, 0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#slow_vector_initialization [INFO] [stderr] [INFO] [stderr] warning: slow zero-filling initialization [INFO] [stderr] --> src/ln/channelmanager.rs:842:4 [INFO] [stderr] | [INFO] [stderr] 841 | let mut res = Vec::with_capacity(end_len); [INFO] [stderr] | --------------------------- help: consider replace allocation with: `vec![0; end_len]` [INFO] [stderr] 842 | res.resize(end_len, 0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#slow_vector_initialization [INFO] [stderr] [INFO] [stderr] warning: slow zero-filling initialization [INFO] [stderr] --> src/ln/channelmanager.rs:889:3 [INFO] [stderr] | [INFO] [stderr] 888 | let mut packet_crypted = Vec::with_capacity(raw_packet.len()); [INFO] [stderr] | ------------------------------------ help: consider replace allocation with: `vec![0; raw_packet.len()]` [INFO] [stderr] 889 | packet_crypted.resize(raw_packet.len(), 0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#slow_vector_initialization [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `failure_type` [INFO] [stderr] --> src/ln/channelmanager.rs:906:14 [INFO] [stderr] | [INFO] [stderr] 906 | res.push(((failure_type >> 0) & 0xff) as u8); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: slow zero-filling initialization [INFO] [stderr] --> src/ln/channelmanager.rs:912:4 [INFO] [stderr] | [INFO] [stderr] 911 | let mut res = Vec::with_capacity(256 - 2 - failure_data.len()); [INFO] [stderr] | ------------------------------------------------ help: consider replace allocation with: `vec![0; 256 - 2 - failure_data.len()]` [INFO] [stderr] 912 | res.resize(256 - 2 - failure_data.len(), 0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#slow_vector_initialization [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 30 [INFO] [stderr] --> src/ln/channelmanager.rs:934:2 [INFO] [stderr] | [INFO] [stderr] 934 | fn decode_update_add_htlc_onion(&self, msg: &msgs::UpdateAddHTLC) -> (PendingHTLCStatus, MutexGuard) { [INFO] [stderr] | _____^ [INFO] [stderr] 935 | | macro_rules! get_onion_hash { [INFO] [stderr] 936 | | () => { [INFO] [stderr] 937 | | { [INFO] [stderr] ... | [INFO] [stderr] 1141 | | (pending_forward_info, channel_state.unwrap()) [INFO] [stderr] 1142 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_err()` [INFO] [stderr] --> src/ln/channelmanager.rs:947:10 [INFO] [stderr] | [INFO] [stderr] 947 | if let Err(_) = msg.onion_routing_packet.public_key { [INFO] [stderr] | _________- ^^^^^^ [INFO] [stderr] 948 | | log_info!(self, "Failed to accept/forward incoming HTLC with invalid ephemeral pubkey"); [INFO] [stderr] 949 | | return (PendingHTLCStatus::Fail(HTLCFailureMsg::Malformed(msgs::UpdateFailMalformedHTLC { [INFO] [stderr] 950 | | channel_id: msg.channel_id, [INFO] [stderr] ... | [INFO] [stderr] 954 | | })), self.channel_state.lock().unwrap()); [INFO] [stderr] 955 | | } [INFO] [stderr] | |_________- help: try this: `if msg.onion_routing_packet.public_key.is_err()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/ln/channelmanager.rs:1017:8 [INFO] [stderr] | [INFO] [stderr] 1017 | if (msg.cltv_expiry as u64) < self.latest_block_height.load(Ordering::Acquire) as u64 + (CLTV_CLAIM_BUFFER + HTLC_FAIL_TIMEOUT_BLOCKS) as u64 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(msg.cltv_expiry)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/ln/channelmanager.rs:1017:93 [INFO] [stderr] | [INFO] [stderr] 1017 | if (msg.cltv_expiry as u64) < self.latest_block_height.load(Ordering::Acquire) as u64 + (CLTV_CLAIM_BUFFER + HTLC_FAIL_TIMEOUT_BLOCKS) as u64 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(CLTV_CLAIM_BUFFER + HTLC_FAIL_TIMEOUT_BLOCKS)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/ln/channelmanager.rs:1036:20 [INFO] [stderr] | [INFO] [stderr] 1036 | payment_hash: msg.payment_hash.clone(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `msg.payment_hash` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_err()` [INFO] [stderr] --> src/ln/channelmanager.rs:1063:12 [INFO] [stderr] | [INFO] [stderr] 1063 | if let Err(_) = new_pubkey.mul_assign(&self.secp_ctx, &blinding_factor) { [INFO] [stderr] | _________________- ^^^^^^ [INFO] [stderr] 1064 | | return_err!("New blinding factor is an invalid private key", 0x8000 | 0x4000 | 6, &get_onion_hash!()); [INFO] [stderr] 1065 | | } [INFO] [stderr] | |_________________- help: try this: `if new_pubkey.mul_assign(&self.secp_ctx, &blinding_factor).is_err()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/ln/channelmanager.rs:1071:12 [INFO] [stderr] | [INFO] [stderr] 1071 | hmac: next_hop_data.hmac.clone(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `next_hop_data.hmac` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/ln/channelmanager.rs:1076:20 [INFO] [stderr] | [INFO] [stderr] 1076 | payment_hash: msg.payment_hash.clone(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `msg.payment_hash` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/ln/channelmanager.rs:1085:3 [INFO] [stderr] | [INFO] [stderr] 1085 | if let &PendingHTLCStatus::Forward(PendingForwardHTLCInfo { ref onion_packet, ref short_channel_id, ref amt_to_forward, ref outgoing_cltv_value, .. }) = &pending_forward_info { [INFO] [stderr] | _________^ [INFO] [stderr] 1086 | | if onion_packet.is_some() { // If short_channel_id is 0 here, we'll reject them in the body here [INFO] [stderr] 1087 | | let id_option = channel_state.as_ref().unwrap().short_to_id.get(&short_channel_id).cloned(); [INFO] [stderr] 1088 | | let forwarding_id = match id_option { [INFO] [stderr] ... | [INFO] [stderr] 1138 | | } [INFO] [stderr] 1139 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 1085 | if let PendingHTLCStatus::Forward(PendingForwardHTLCInfo { ref onion_packet, ref short_channel_id, ref amt_to_forward, ref outgoing_cltv_value, .. }) = pending_forward_info { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/ln/channelmanager.rs:1092:18 [INFO] [stderr] | [INFO] [stderr] 1092 | Some(id) => id.clone(), [INFO] [stderr] | ^^^^^^^^^^ help: try removing the `clone` call: `id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] error: this loop never actually loops [INFO] [stderr] --> src/ln/channelmanager.rs:1094:45 [INFO] [stderr] | [INFO] [stderr] 1094 | if let Some((err, code, chan_update)) = loop { [INFO] [stderr] | _________________________________________________________^ [INFO] [stderr] 1095 | | let chan = channel_state.as_mut().unwrap().by_id.get_mut(&forwarding_id).unwrap(); [INFO] [stderr] 1096 | | [INFO] [stderr] 1097 | | // Note that we could technically not return an error yet here and just hope [INFO] [stderr] ... | [INFO] [stderr] 1123 | | break None; [INFO] [stderr] 1124 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::never_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#never_loop [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/ln/channelmanager.rs:1108:43 [INFO] [stderr] | [INFO] [stderr] 1108 | let fee = amt_to_forward.checked_mul(chan.get_fee_proportional_millionths() as u64).and_then(|prop_fee| { (prop_fee / 1000000).checked_add(chan.get_our_fee_base_msat(&*self.fee_estimator) as u64) }); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(chan.get_fee_proportional_millionths())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/ln/channelmanager.rs:1108:145 [INFO] [stderr] | [INFO] [stderr] 1108 | let fee = amt_to_forward.checked_mul(chan.get_fee_proportional_millionths() as u64).and_then(|prop_fee| { (prop_fee / 1000000).checked_add(chan.get_our_fee_base_msat(&*self.fee_estimator) as u64) }); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(chan.get_our_fee_base_msat(&*self.fee_estimator))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/ln/channelmanager.rs:1112:9 [INFO] [stderr] | [INFO] [stderr] 1112 | if (msg.cltv_expiry as u64) < (*outgoing_cltv_value) as u64 + CLTV_EXPIRY_DELTA as u64 { // incorrect_cltv_expiry [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(msg.cltv_expiry)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/ln/channelmanager.rs:1112:36 [INFO] [stderr] | [INFO] [stderr] 1112 | if (msg.cltv_expiry as u64) < (*outgoing_cltv_value) as u64 + CLTV_EXPIRY_DELTA as u64 { // incorrect_cltv_expiry [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from((*outgoing_cltv_value))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u64 may become silently lossy if types change [INFO] [stderr] --> src/ln/channelmanager.rs:1112:68 [INFO] [stderr] | [INFO] [stderr] 1112 | if (msg.cltv_expiry as u64) < (*outgoing_cltv_value) as u64 + CLTV_EXPIRY_DELTA as u64 { // incorrect_cltv_expiry [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(CLTV_EXPIRY_DELTA)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: length comparison to one [INFO] [stderr] --> src/ln/channelmanager.rs:1192:6 [INFO] [stderr] | [INFO] [stderr] 1192 | if route.hops.len() < 1 || route.hops.len() > 20 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `route.hops.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/ln/channelmanager.rs:1220:16 [INFO] [stderr] | [INFO] [stderr] 1220 | Some(id) => id.clone(), [INFO] [stderr] | ^^^^^^^^^^ help: try dereferencing it: `*id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/ln/channelmanager.rs:1234:41 [INFO] [stderr] | [INFO] [stderr] 1234 | chan.send_htlc_and_commit(htlc_msat, payment_hash.clone(), htlc_cltv, HTLCSource::OutboundRoute { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `payment_hash` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/ln/channelmanager.rs:1236:19 [INFO] [stderr] | [INFO] [stderr] 1236 | session_priv: session_priv.clone(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `session_priv` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/ln/channelmanager.rs:1250:3 [INFO] [stderr] | [INFO] [stderr] 1250 | match res { [INFO] [stderr] | _________^ [INFO] [stderr] 1251 | | Some((update_add, commitment_signed, chan_monitor)) => { [INFO] [stderr] 1252 | | if let Err(e) = self.monitor.add_update_monitor(chan_monitor.get_funding_txo().unwrap(), chan_monitor) { [INFO] [stderr] 1253 | | self.handle_monitor_update_fail(channel_state, &id, e, RAACommitmentOrder::CommitmentFirst); [INFO] [stderr] ... | [INFO] [stderr] 1269 | | None => {}, [INFO] [stderr] 1270 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 1250 | if let Some((update_add, commitment_signed, chan_monitor)) = res { [INFO] [stderr] 1251 | if let Err(e) = self.monitor.add_update_monitor(chan_monitor.get_funding_txo().unwrap(), chan_monitor) { [INFO] [stderr] 1252 | self.handle_monitor_update_fail(channel_state, &id, e, RAACommitmentOrder::CommitmentFirst); [INFO] [stderr] 1253 | return Err(APIError::MonitorUpdateFailed); [INFO] [stderr] 1254 | } [INFO] [stderr] 1255 | [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/ln/channelmanager.rs:413:6 [INFO] [stderr] | [INFO] [stderr] 413 | match &err.action { [INFO] [stderr] | _____________________^ [INFO] [stderr] 414 | | &Some(msgs::ErrorAction::DisconnectPeer { msg: Some(ref msg) }) => { [INFO] [stderr] 415 | | if msg.channel_id == [0; 32] { [INFO] [stderr] 416 | | $self.peer_disconnected(&$their_node_id, true); [INFO] [stderr] ... | [INFO] [stderr] 430 | | &None => {}, [INFO] [stderr] 431 | | } [INFO] [stderr] | |_____________________^ [INFO] [stderr] ... [INFO] [stderr] 1299 | match handle_error!(self, res, chan.get_their_node_id()) { [INFO] [stderr] | -------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/ln/channelmanager.rs:1338:101 [INFO] [stderr] | [INFO] [stderr] 1338 | let (announcement, our_bitcoin_sig) = match chan.get_channel_announcement(self.get_our_node_id(), self.genesis_hash.clone()) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.genesis_hash` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/ln/channelmanager.rs:1373:24 [INFO] [stderr] | [INFO] [stderr] 1373 | Some(chan_id) => chan_id.clone(), [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try dereferencing it: `*chan_id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/ln/channelmanager.rs:1403:9 [INFO] [stderr] | [INFO] [stderr] 1403 | match update_add { [INFO] [stderr] | _________________________________^ [INFO] [stderr] 1404 | | Some(msg) => { add_htlc_msgs.push(msg); }, [INFO] [stderr] 1405 | | None => { [INFO] [stderr] 1406 | | // Nothing to do here...we're waiting on a remote [INFO] [stderr] ... | [INFO] [stderr] 1413 | | } [INFO] [stderr] 1414 | | } [INFO] [stderr] | |_________________________________^ help: try this: `if let Some(msg) = update_add { add_htlc_msgs.push(msg); }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/ln/channelmanager.rs:1502:5 [INFO] [stderr] | [INFO] [stderr] 1502 | if let &HTLCFailReason::ErrorPacket { ref err } = &onion_error { [INFO] [stderr] | _________________^ [INFO] [stderr] 1503 | | let (channel_update, payment_retryable) = self.process_onion_failure(&source, err.data.clone()); [INFO] [stderr] 1504 | | if let Some(update) = channel_update { [INFO] [stderr] 1505 | | self.channel_state.lock().unwrap().pending_msg_events.push( [INFO] [stderr] ... | [INFO] [stderr] 1516 | | panic!("should have onion error packet here"); [INFO] [stderr] 1517 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 1502 | if let HTLCFailReason::ErrorPacket { ref err } = onion_error { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/ln/channelmanager.rs:1512:21 [INFO] [stderr] | [INFO] [stderr] 1512 | payment_hash: payment_hash.clone(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*payment_hash` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/ln/channelmanager.rs:1533:23 [INFO] [stderr] | [INFO] [stderr] 1533 | Some(chan_id) => chan_id.clone(), [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try dereferencing it: `*chan_id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/ln/channelmanager.rs:1602:23 [INFO] [stderr] | [INFO] [stderr] 1602 | Some(chan_id) => chan_id.clone(), [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try dereferencing it: `*chan_id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/ln/channelmanager.rs:1733:89 [INFO] [stderr] | [INFO] [stderr] 1733 | return Err(MsgHandleErrInternal::send_err_msg_no_close("Unknown genesis block hash", msg.temporary_channel_id.clone())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `msg.temporary_channel_id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/ln/channelmanager.rs:1736:81 [INFO] [stderr] | [INFO] [stderr] 1736 | let channel = Channel::new_from_req(&*self.fee_estimator, &self.keys_manager, their_node_id.clone(), msg, 0, Arc::clone(&self.logger), &self.default_configuration) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*their_node_id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/ln/channelmanager.rs:1741:126 [INFO] [stderr] | [INFO] [stderr] 1741 | hash_map::Entry::Occupied(_) => return Err(MsgHandleErrInternal::send_err_msg_no_close("temporary_channel_id collision!", msg.temporary_channel_id.clone())), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `msg.temporary_channel_id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/ln/channelmanager.rs:1744:15 [INFO] [stderr] | [INFO] [stderr] 1744 | node_id: their_node_id.clone(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*their_node_id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/ln/channelmanager.rs:1783:36 [INFO] [stderr] | [INFO] [stderr] 1783 | match channel_state.by_id.entry(msg.temporary_channel_id.clone()) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `msg.temporary_channel_id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/ln/channelmanager.rs:1814:15 [INFO] [stderr] | [INFO] [stderr] 1814 | node_id: their_node_id.clone(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*their_node_id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/ln/channelmanager.rs:1862:16 [INFO] [stderr] | [INFO] [stderr] 1862 | node_id: their_node_id.clone(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*their_node_id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/ln/channelmanager.rs:1877:36 [INFO] [stderr] | [INFO] [stderr] 1877 | match channel_state.by_id.entry(msg.channel_id.clone()) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `msg.channel_id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/ln/channelmanager.rs:1886:17 [INFO] [stderr] | [INFO] [stderr] 1886 | node_id: their_node_id.clone(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*their_node_id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/ln/channelmanager.rs:1892:17 [INFO] [stderr] | [INFO] [stderr] 1892 | node_id: their_node_id.clone(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*their_node_id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/ln/channelmanager.rs:1925:36 [INFO] [stderr] | [INFO] [stderr] 1925 | match channel_state.by_id.entry(msg.channel_id.clone()) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `msg.channel_id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/ln/channelmanager.rs:1931:105 [INFO] [stderr] | [INFO] [stderr] 1931 | let (closing_signed, tx) = chan_entry.get_mut().closing_signed(&*self.fee_estimator, &msg).map_err(|e| MsgHandleErrInternal::from_maybe_close(e))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `MsgHandleErrInternal::from_maybe_close` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/ln/channelmanager.rs:1934:17 [INFO] [stderr] | [INFO] [stderr] 1934 | node_id: their_node_id.clone(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*their_node_id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/ln/channelmanager.rs:2008:62 [INFO] [stderr] | [INFO] [stderr] 2008 | chan.update_add_htlc(&msg, pending_forward_info).map_err(|e| MsgHandleErrInternal::from_maybe_close(e)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `MsgHandleErrInternal::from_maybe_close` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/ln/channelmanager.rs:2027:57 [INFO] [stderr] | [INFO] [stderr] 2027 | self.claim_funds_internal(channel_state, htlc_source, msg.payment_preimage.clone()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `msg.payment_preimage` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/ln/channelmanager.rs:2034:3 [INFO] [stderr] | [INFO] [stderr] 2034 | if let &HTLCSource::OutboundRoute { ref route, ref session_priv, ref first_hop_htlc_msat } = htlc_source { [INFO] [stderr] | _________^ [INFO] [stderr] 2035 | | macro_rules! onion_failure_log { [INFO] [stderr] 2036 | | ( $error_code_textual: expr, $error_code: expr, $reported_name: expr, $reported_value: expr ) => { [INFO] [stderr] 2037 | | log_trace!(self, "{}({:#x}) {}({})", $error_code_textual, $error_code, $reported_name, $reported_value); [INFO] [stderr] ... | [INFO] [stderr] 2224 | | res.unwrap_or((None, true)) [INFO] [stderr] 2225 | | } else { ((None, true)) } [INFO] [stderr] | |_________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 2034 | if let HTLCSource::OutboundRoute { ref route, ref session_priv, ref first_hop_htlc_msat } = *htlc_source { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 26 [INFO] [stderr] --> src/ln/channelmanager.rs:2052:77 [INFO] [stderr] | [INFO] [stderr] 2052 | Self::construct_onion_keys_callback(&self.secp_ctx, route, session_priv, |shared_secret, _, _, route_hop| { [INFO] [stderr] | ______________________________________________________________________________________^ [INFO] [stderr] 2053 | | if res.is_some() { return; } [INFO] [stderr] 2054 | | [INFO] [stderr] 2055 | | let incoming_htlc_msat = htlc_msat; [INFO] [stderr] ... | [INFO] [stderr] 2222 | | } [INFO] [stderr] 2223 | | }).expect("Route that we sent via spontaneously grew invalid keys in the middle of it?"); [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: slow zero-filling initialization [INFO] [stderr] --> src/ln/channelmanager.rs:2062:5 [INFO] [stderr] | [INFO] [stderr] 2061 | let mut decryption_tmp = Vec::with_capacity(packet_decrypted.len()); [INFO] [stderr] | ------------------------------------------ help: consider replace allocation with: `vec![0; packet_decrypted.len()]` [INFO] [stderr] 2062 | decryption_tmp.resize(packet_decrypted.len(), 0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#slow_vector_initialization [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/ln/channelmanager.rs:2175:57 [INFO] [stderr] | [INFO] [stderr] 2175 | let new_fee = amt_to_forward.checked_mul(chan_update.contents.fee_proportional_millionths as u64).and_then(|prop_fee| { (prop_fee / 1000000).checked_add(chan_update.contents.fee_base_msat as u64) }); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(chan_update.contents.fee_proportional_millionths)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/ln/channelmanager.rs:2175:169 [INFO] [stderr] | [INFO] [stderr] 2175 | let new_fee = amt_to_forward.checked_mul(chan_update.contents.fee_proportional_millionths as u64).and_then(|prop_fee| { (prop_fee / 1000000).checked_add(chan_update.contents.fee_base_msat as u64) }); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(chan_update.contents.fee_base_msat)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/ln/channelmanager.rs:2278:15 [INFO] [stderr] | [INFO] [stderr] 2278 | node_id: their_node_id.clone(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*their_node_id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/ln/channelmanager.rs:2283:16 [INFO] [stderr] | [INFO] [stderr] 2283 | node_id: their_node_id.clone(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*their_node_id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/ln/channelmanager.rs:2296:16 [INFO] [stderr] | [INFO] [stderr] 2296 | node_id: their_node_id.clone(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*their_node_id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/ln/channelmanager.rs:2327:4 [INFO] [stderr] | [INFO] [stderr] 2327 | match forward_event { [INFO] [stderr] | _____________^ [INFO] [stderr] 2328 | | Some(time) => { [INFO] [stderr] 2329 | | let mut pending_events = self.pending_events.lock().unwrap(); [INFO] [stderr] 2330 | | pending_events.push(events::Event::PendingHTLCsForwardable { [INFO] [stderr] ... | [INFO] [stderr] 2334 | | None => {}, [INFO] [stderr] 2335 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 2327 | if let Some(time) = forward_event { [INFO] [stderr] 2328 | let mut pending_events = self.pending_events.lock().unwrap(); [INFO] [stderr] 2329 | pending_events.push(events::Event::PendingHTLCsForwardable { [INFO] [stderr] 2330 | time_forwardable: time [INFO] [stderr] 2331 | }); [INFO] [stderr] 2332 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/ln/channelmanager.rs:2356:17 [INFO] [stderr] | [INFO] [stderr] 2356 | node_id: their_node_id.clone(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*their_node_id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/ln/channelmanager.rs:2362:17 [INFO] [stderr] | [INFO] [stderr] 2362 | node_id: their_node_id.clone(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*their_node_id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/ln/channelmanager.rs:2407:73 [INFO] [stderr] | [INFO] [stderr] 2407 | let (announcement, our_bitcoin_sig) = chan.get_channel_announcement(our_node_id.clone(), self.genesis_hash.clone()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `our_node_id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/ln/channelmanager.rs:2407:94 [INFO] [stderr] | [INFO] [stderr] 2407 | let (announcement, our_bitcoin_sig) = chan.get_channel_announcement(our_node_id.clone(), self.genesis_hash.clone()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.genesis_hash` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/ln/channelmanager.rs:2452:16 [INFO] [stderr] | [INFO] [stderr] 2452 | node_id: their_node_id.clone(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*their_node_id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/ln/channelmanager.rs:2484:16 [INFO] [stderr] | [INFO] [stderr] 2484 | node_id: their_node_id.clone(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*their_node_id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/ln/channelmanager.rs:413:6 [INFO] [stderr] | [INFO] [stderr] 413 | match &err.action { [INFO] [stderr] | _____________________^ [INFO] [stderr] 414 | | &Some(msgs::ErrorAction::DisconnectPeer { msg: Some(ref msg) }) => { [INFO] [stderr] 415 | | if msg.channel_id == [0; 32] { [INFO] [stderr] 416 | | $self.peer_disconnected(&$their_node_id, true); [INFO] [stderr] ... | [INFO] [stderr] 430 | | &None => {}, [INFO] [stderr] 431 | | } [INFO] [stderr] | |_____________________^ [INFO] [stderr] ... [INFO] [stderr] 2682 | handle_error!(self, self.internal_open_channel(their_node_id, msg), their_node_id) [INFO] [stderr] | ---------------------------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/ln/channelmanager.rs:413:6 [INFO] [stderr] | [INFO] [stderr] 413 | match &err.action { [INFO] [stderr] | _____________________^ [INFO] [stderr] 414 | | &Some(msgs::ErrorAction::DisconnectPeer { msg: Some(ref msg) }) => { [INFO] [stderr] 415 | | if msg.channel_id == [0; 32] { [INFO] [stderr] 416 | | $self.peer_disconnected(&$their_node_id, true); [INFO] [stderr] ... | [INFO] [stderr] 430 | | &None => {}, [INFO] [stderr] 431 | | } [INFO] [stderr] | |_____________________^ [INFO] [stderr] ... [INFO] [stderr] 2687 | handle_error!(self, self.internal_accept_channel(their_node_id, msg), their_node_id) [INFO] [stderr] | ------------------------------------------------------------------------------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/ln/channelmanager.rs:413:6 [INFO] [stderr] | [INFO] [stderr] 413 | match &err.action { [INFO] [stderr] | _____________________^ [INFO] [stderr] 414 | | &Some(msgs::ErrorAction::DisconnectPeer { msg: Some(ref msg) }) => { [INFO] [stderr] 415 | | if msg.channel_id == [0; 32] { [INFO] [stderr] 416 | | $self.peer_disconnected(&$their_node_id, true); [INFO] [stderr] ... | [INFO] [stderr] 430 | | &None => {}, [INFO] [stderr] 431 | | } [INFO] [stderr] | |_____________________^ [INFO] [stderr] ... [INFO] [stderr] 2692 | handle_error!(self, self.internal_funding_created(their_node_id, msg), their_node_id) [INFO] [stderr] | ------------------------------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/ln/channelmanager.rs:413:6 [INFO] [stderr] | [INFO] [stderr] 413 | match &err.action { [INFO] [stderr] | _____________________^ [INFO] [stderr] 414 | | &Some(msgs::ErrorAction::DisconnectPeer { msg: Some(ref msg) }) => { [INFO] [stderr] 415 | | if msg.channel_id == [0; 32] { [INFO] [stderr] 416 | | $self.peer_disconnected(&$their_node_id, true); [INFO] [stderr] ... | [INFO] [stderr] 430 | | &None => {}, [INFO] [stderr] 431 | | } [INFO] [stderr] | |_____________________^ [INFO] [stderr] ... [INFO] [stderr] 2697 | handle_error!(self, self.internal_funding_signed(their_node_id, msg), their_node_id) [INFO] [stderr] | ------------------------------------------------------------------------------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/ln/channelmanager.rs:413:6 [INFO] [stderr] | [INFO] [stderr] 413 | match &err.action { [INFO] [stderr] | _____________________^ [INFO] [stderr] 414 | | &Some(msgs::ErrorAction::DisconnectPeer { msg: Some(ref msg) }) => { [INFO] [stderr] 415 | | if msg.channel_id == [0; 32] { [INFO] [stderr] 416 | | $self.peer_disconnected(&$their_node_id, true); [INFO] [stderr] ... | [INFO] [stderr] 430 | | &None => {}, [INFO] [stderr] 431 | | } [INFO] [stderr] | |_____________________^ [INFO] [stderr] ... [INFO] [stderr] 2702 | handle_error!(self, self.internal_funding_locked(their_node_id, msg), their_node_id) [INFO] [stderr] | ------------------------------------------------------------------------------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/ln/channelmanager.rs:413:6 [INFO] [stderr] | [INFO] [stderr] 413 | match &err.action { [INFO] [stderr] | _____________________^ [INFO] [stderr] 414 | | &Some(msgs::ErrorAction::DisconnectPeer { msg: Some(ref msg) }) => { [INFO] [stderr] 415 | | if msg.channel_id == [0; 32] { [INFO] [stderr] 416 | | $self.peer_disconnected(&$their_node_id, true); [INFO] [stderr] ... | [INFO] [stderr] 430 | | &None => {}, [INFO] [stderr] 431 | | } [INFO] [stderr] | |_____________________^ [INFO] [stderr] ... [INFO] [stderr] 2707 | handle_error!(self, self.internal_shutdown(their_node_id, msg), their_node_id) [INFO] [stderr] | ------------------------------------------------------------------------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/ln/channelmanager.rs:413:6 [INFO] [stderr] | [INFO] [stderr] 413 | match &err.action { [INFO] [stderr] | _____________________^ [INFO] [stderr] 414 | | &Some(msgs::ErrorAction::DisconnectPeer { msg: Some(ref msg) }) => { [INFO] [stderr] 415 | | if msg.channel_id == [0; 32] { [INFO] [stderr] 416 | | $self.peer_disconnected(&$their_node_id, true); [INFO] [stderr] ... | [INFO] [stderr] 430 | | &None => {}, [INFO] [stderr] 431 | | } [INFO] [stderr] | |_____________________^ [INFO] [stderr] ... [INFO] [stderr] 2712 | handle_error!(self, self.internal_closing_signed(their_node_id, msg), their_node_id) [INFO] [stderr] | ------------------------------------------------------------------------------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/ln/channelmanager.rs:413:6 [INFO] [stderr] | [INFO] [stderr] 413 | match &err.action { [INFO] [stderr] | _____________________^ [INFO] [stderr] 414 | | &Some(msgs::ErrorAction::DisconnectPeer { msg: Some(ref msg) }) => { [INFO] [stderr] 415 | | if msg.channel_id == [0; 32] { [INFO] [stderr] 416 | | $self.peer_disconnected(&$their_node_id, true); [INFO] [stderr] ... | [INFO] [stderr] 430 | | &None => {}, [INFO] [stderr] 431 | | } [INFO] [stderr] | |_____________________^ [INFO] [stderr] ... [INFO] [stderr] 2717 | handle_error!(self, self.internal_update_add_htlc(their_node_id, msg), their_node_id) [INFO] [stderr] | ------------------------------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/ln/channelmanager.rs:413:6 [INFO] [stderr] | [INFO] [stderr] 413 | match &err.action { [INFO] [stderr] | _____________________^ [INFO] [stderr] 414 | | &Some(msgs::ErrorAction::DisconnectPeer { msg: Some(ref msg) }) => { [INFO] [stderr] 415 | | if msg.channel_id == [0; 32] { [INFO] [stderr] 416 | | $self.peer_disconnected(&$their_node_id, true); [INFO] [stderr] ... | [INFO] [stderr] 430 | | &None => {}, [INFO] [stderr] 431 | | } [INFO] [stderr] | |_____________________^ [INFO] [stderr] ... [INFO] [stderr] 2722 | handle_error!(self, self.internal_update_fulfill_htlc(their_node_id, msg), their_node_id) [INFO] [stderr] | ----------------------------------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/ln/channelmanager.rs:413:6 [INFO] [stderr] | [INFO] [stderr] 413 | match &err.action { [INFO] [stderr] | _____________________^ [INFO] [stderr] 414 | | &Some(msgs::ErrorAction::DisconnectPeer { msg: Some(ref msg) }) => { [INFO] [stderr] 415 | | if msg.channel_id == [0; 32] { [INFO] [stderr] 416 | | $self.peer_disconnected(&$their_node_id, true); [INFO] [stderr] ... | [INFO] [stderr] 430 | | &None => {}, [INFO] [stderr] 431 | | } [INFO] [stderr] | |_____________________^ [INFO] [stderr] ... [INFO] [stderr] 2727 | handle_error!(self, self.internal_update_fail_htlc(their_node_id, msg), their_node_id) [INFO] [stderr] | -------------------------------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/ln/channelmanager.rs:413:6 [INFO] [stderr] | [INFO] [stderr] 413 | match &err.action { [INFO] [stderr] | _____________________^ [INFO] [stderr] 414 | | &Some(msgs::ErrorAction::DisconnectPeer { msg: Some(ref msg) }) => { [INFO] [stderr] 415 | | if msg.channel_id == [0; 32] { [INFO] [stderr] 416 | | $self.peer_disconnected(&$their_node_id, true); [INFO] [stderr] ... | [INFO] [stderr] 430 | | &None => {}, [INFO] [stderr] 431 | | } [INFO] [stderr] | |_____________________^ [INFO] [stderr] ... [INFO] [stderr] 2732 | handle_error!(self, self.internal_update_fail_malformed_htlc(their_node_id, msg), their_node_id) [INFO] [stderr] | ------------------------------------------------------------------------------------------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/ln/channelmanager.rs:413:6 [INFO] [stderr] | [INFO] [stderr] 413 | match &err.action { [INFO] [stderr] | _____________________^ [INFO] [stderr] 414 | | &Some(msgs::ErrorAction::DisconnectPeer { msg: Some(ref msg) }) => { [INFO] [stderr] 415 | | if msg.channel_id == [0; 32] { [INFO] [stderr] 416 | | $self.peer_disconnected(&$their_node_id, true); [INFO] [stderr] ... | [INFO] [stderr] 430 | | &None => {}, [INFO] [stderr] 431 | | } [INFO] [stderr] | |_____________________^ [INFO] [stderr] ... [INFO] [stderr] 2737 | handle_error!(self, self.internal_commitment_signed(their_node_id, msg), their_node_id) [INFO] [stderr] | --------------------------------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/ln/channelmanager.rs:413:6 [INFO] [stderr] | [INFO] [stderr] 413 | match &err.action { [INFO] [stderr] | _____________________^ [INFO] [stderr] 414 | | &Some(msgs::ErrorAction::DisconnectPeer { msg: Some(ref msg) }) => { [INFO] [stderr] 415 | | if msg.channel_id == [0; 32] { [INFO] [stderr] 416 | | $self.peer_disconnected(&$their_node_id, true); [INFO] [stderr] ... | [INFO] [stderr] 430 | | &None => {}, [INFO] [stderr] 431 | | } [INFO] [stderr] | |_____________________^ [INFO] [stderr] ... [INFO] [stderr] 2742 | handle_error!(self, self.internal_revoke_and_ack(their_node_id, msg), their_node_id) [INFO] [stderr] | ------------------------------------------------------------------------------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/ln/channelmanager.rs:413:6 [INFO] [stderr] | [INFO] [stderr] 413 | match &err.action { [INFO] [stderr] | _____________________^ [INFO] [stderr] 414 | | &Some(msgs::ErrorAction::DisconnectPeer { msg: Some(ref msg) }) => { [INFO] [stderr] 415 | | if msg.channel_id == [0; 32] { [INFO] [stderr] 416 | | $self.peer_disconnected(&$their_node_id, true); [INFO] [stderr] ... | [INFO] [stderr] 430 | | &None => {}, [INFO] [stderr] 431 | | } [INFO] [stderr] | |_____________________^ [INFO] [stderr] ... [INFO] [stderr] 2747 | handle_error!(self, self.internal_update_fee(their_node_id, msg), their_node_id) [INFO] [stderr] | -------------------------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/ln/channelmanager.rs:413:6 [INFO] [stderr] | [INFO] [stderr] 413 | match &err.action { [INFO] [stderr] | _____________________^ [INFO] [stderr] 414 | | &Some(msgs::ErrorAction::DisconnectPeer { msg: Some(ref msg) }) => { [INFO] [stderr] 415 | | if msg.channel_id == [0; 32] { [INFO] [stderr] 416 | | $self.peer_disconnected(&$their_node_id, true); [INFO] [stderr] ... | [INFO] [stderr] 430 | | &None => {}, [INFO] [stderr] 431 | | } [INFO] [stderr] | |_____________________^ [INFO] [stderr] ... [INFO] [stderr] 2752 | handle_error!(self, self.internal_announcement_signatures(their_node_id, msg), their_node_id) [INFO] [stderr] | --------------------------------------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/ln/channelmanager.rs:413:6 [INFO] [stderr] | [INFO] [stderr] 413 | match &err.action { [INFO] [stderr] | _____________________^ [INFO] [stderr] 414 | | &Some(msgs::ErrorAction::DisconnectPeer { msg: Some(ref msg) }) => { [INFO] [stderr] 415 | | if msg.channel_id == [0; 32] { [INFO] [stderr] 416 | | $self.peer_disconnected(&$their_node_id, true); [INFO] [stderr] ... | [INFO] [stderr] 430 | | &None => {}, [INFO] [stderr] 431 | | } [INFO] [stderr] | |_____________________^ [INFO] [stderr] ... [INFO] [stderr] 2757 | handle_error!(self, self.internal_channel_reestablish(their_node_id, msg), their_node_id) [INFO] [stderr] | ----------------------------------------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/ln/channelmanager.rs:2865:3 [INFO] [stderr] | [INFO] [stderr] 2865 | if let &Some(ref onion) = &self.onion_packet { [INFO] [stderr] | _________^ [INFO] [stderr] 2866 | | 1u8.write(writer)?; [INFO] [stderr] 2867 | | onion.write(writer)?; [INFO] [stderr] 2868 | | } else { [INFO] [stderr] 2869 | | 0u8.write(writer)?; [INFO] [stderr] 2870 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 2865 | if let Some(ref onion) = self.onion_packet { [INFO] [stderr] | ^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/ln/channelmanager.rs:2900:3 [INFO] [stderr] | [INFO] [stderr] 2900 | match self { [INFO] [stderr] | _________^ [INFO] [stderr] 2901 | | &HTLCFailureMsg::Relay(ref fail_msg) => { [INFO] [stderr] 2902 | | 0u8.write(writer)?; [INFO] [stderr] 2903 | | fail_msg.write(writer)?; [INFO] [stderr] ... | [INFO] [stderr] 2908 | | } [INFO] [stderr] 2909 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 2900 | match *self { [INFO] [stderr] 2901 | HTLCFailureMsg::Relay(ref fail_msg) => { [INFO] [stderr] 2902 | 0u8.write(writer)?; [INFO] [stderr] 2903 | fail_msg.write(writer)?; [INFO] [stderr] 2904 | }, [INFO] [stderr] 2905 | HTLCFailureMsg::Malformed(ref fail_msg) => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/ln/channelmanager.rs:2926:3 [INFO] [stderr] | [INFO] [stderr] 2926 | match self { [INFO] [stderr] | _________^ [INFO] [stderr] 2927 | | &PendingHTLCStatus::Forward(ref forward_info) => { [INFO] [stderr] 2928 | | 0u8.write(writer)?; [INFO] [stderr] 2929 | | forward_info.write(writer)?; [INFO] [stderr] ... | [INFO] [stderr] 2934 | | } [INFO] [stderr] 2935 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 2926 | match *self { [INFO] [stderr] 2927 | PendingHTLCStatus::Forward(ref forward_info) => { [INFO] [stderr] 2928 | 0u8.write(writer)?; [INFO] [stderr] 2929 | forward_info.write(writer)?; [INFO] [stderr] 2930 | }, [INFO] [stderr] 2931 | PendingHTLCStatus::Fail(ref fail_msg) => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/ln/channelmanager.rs:2958:3 [INFO] [stderr] | [INFO] [stderr] 2958 | match self { [INFO] [stderr] | _________^ [INFO] [stderr] 2959 | | &HTLCSource::PreviousHopData(ref hop_data) => { [INFO] [stderr] 2960 | | 0u8.write(writer)?; [INFO] [stderr] 2961 | | hop_data.write(writer)?; [INFO] [stderr] ... | [INFO] [stderr] 2968 | | } [INFO] [stderr] 2969 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 2958 | match *self { [INFO] [stderr] 2959 | HTLCSource::PreviousHopData(ref hop_data) => { [INFO] [stderr] 2960 | 0u8.write(writer)?; [INFO] [stderr] 2961 | hop_data.write(writer)?; [INFO] [stderr] 2962 | }, [INFO] [stderr] 2963 | HTLCSource::OutboundRoute { ref route, ref session_priv, ref first_hop_htlc_msat } => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/ln/channelmanager.rs:2990:3 [INFO] [stderr] | [INFO] [stderr] 2990 | match self { [INFO] [stderr] | _________^ [INFO] [stderr] 2991 | | &HTLCFailReason::ErrorPacket { ref err } => { [INFO] [stderr] 2992 | | 0u8.write(writer)?; [INFO] [stderr] 2993 | | err.write(writer)?; [INFO] [stderr] ... | [INFO] [stderr] 2999 | | } [INFO] [stderr] 3000 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 2990 | match *self { [INFO] [stderr] 2991 | HTLCFailReason::ErrorPacket { ref err } => { [INFO] [stderr] 2992 | 0u8.write(writer)?; [INFO] [stderr] 2993 | err.write(writer)?; [INFO] [stderr] 2994 | }, [INFO] [stderr] 2995 | HTLCFailReason::Reason { ref failure_code, ref data } => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/ln/channelmanager.rs:3155:27 [INFO] [stderr] | [INFO] [stderr] 3155 | funding_txo_set.insert(funding_txo.clone()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `funding_txo` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/ln/channelmanager.rs:3238:7 [INFO] [stderr] | [INFO] [stderr] 3238 | Ok((last_block_hash.clone(), channel_manager)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `last_block_hash` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/ln/channelmonitor.rs:133:8 [INFO] [stderr] | [INFO] [stderr] 133 | if spendable_outputs.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!spendable_outputs.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/ln/channelmonitor.rs:140:50 [INFO] [stderr] | [INFO] [stderr] 140 | self.chain_monitor.install_watch_outpoint((txid.clone(), idx as u32), &output.script_pubkey); [INFO] [stderr] | ^^^^^^^^^^^^ help: try dereferencing it: `*txid` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/ln/channelmonitor.rs:171:3 [INFO] [stderr] | [INFO] [stderr] 171 | match monitors.get_mut(&key) { [INFO] [stderr] | _________^ [INFO] [stderr] 172 | | Some(orig_monitor) => { [INFO] [stderr] 173 | | log_trace!(self, "Updating Channel Monitor for channel {}", log_funding_option!(monitor.funding_txo)); [INFO] [stderr] 174 | | return orig_monitor.insert_combine(monitor); [INFO] [stderr] 175 | | }, [INFO] [stderr] 176 | | None => {} [INFO] [stderr] 177 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 171 | if let Some(orig_monitor) = monitors.get_mut(&key) { [INFO] [stderr] 172 | log_trace!(self, "Updating Channel Monitor for channel {}", log_funding_option!(monitor.funding_txo)); [INFO] [stderr] 173 | return orig_monitor.insert_combine(monitor); [INFO] [stderr] 174 | }; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/ln/channelmonitor.rs:178:3 [INFO] [stderr] | [INFO] [stderr] 178 | match &monitor.funding_txo { [INFO] [stderr] | _________^ [INFO] [stderr] 179 | | &None => { [INFO] [stderr] 180 | | log_trace!(self, "Got new Channel Monitor for no-funding-set channel (monitoring all txn!)"); [INFO] [stderr] 181 | | self.chain_monitor.watch_all_txn() [INFO] [stderr] ... | [INFO] [stderr] 187 | | }, [INFO] [stderr] 188 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 178 | match monitor.funding_txo { [INFO] [stderr] 179 | None => { [INFO] [stderr] 180 | log_trace!(self, "Got new Channel Monitor for no-funding-set channel (monitoring all txn!)"); [INFO] [stderr] 181 | self.chain_monitor.watch_all_txn() [INFO] [stderr] 182 | }, [INFO] [stderr] 183 | Some((ref outpoint, ref script)) => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/ln/channelmonitor.rs:186:63 [INFO] [stderr] | [INFO] [stderr] 186 | self.chain_monitor.install_watch_outpoint((outpoint.txid, outpoint.index as u32), script); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(outpoint.index)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (8/7) [INFO] [stderr] --> src/ln/channelmonitor.rs:352:2 [INFO] [stderr] | [INFO] [stderr] 352 | pub(super) fn new(revocation_base_key: &SecretKey, delayed_payment_base_key: &SecretKey, htlc_base_key: &SecretKey, payment_base_key: &SecretKey, shutdown_pubkey: &PublicKey, our_to_self_delay: u16, destination_script: Script, logger: Arc) -> ChannelMonitor { [INFO] [stderr] | _____^ [INFO] [stderr] 353 | | ChannelMonitor { [INFO] [stderr] 354 | | funding_txo: None, [INFO] [stderr] 355 | | commitment_transaction_number_obscure_factor: 0, [INFO] [stderr] ... | [INFO] [stderr] 388 | | } [INFO] [stderr] 389 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/ln/channelmonitor.rs:358:26 [INFO] [stderr] | [INFO] [stderr] 358 | revocation_base_key: revocation_base_key.clone(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*revocation_base_key` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/ln/channelmonitor.rs:359:20 [INFO] [stderr] | [INFO] [stderr] 359 | htlc_base_key: htlc_base_key.clone(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*htlc_base_key` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/ln/channelmonitor.rs:360:31 [INFO] [stderr] | [INFO] [stderr] 360 | delayed_payment_base_key: delayed_payment_base_key.clone(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*delayed_payment_base_key` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/ln/channelmonitor.rs:361:23 [INFO] [stderr] | [INFO] [stderr] 361 | payment_base_key: payment_base_key.clone(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*payment_base_key` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/ln/channelmonitor.rs:362:22 [INFO] [stderr] | [INFO] [stderr] 362 | shutdown_pubkey: shutdown_pubkey.clone(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*shutdown_pubkey` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/ln/channelmonitor.rs:558:54 [INFO] [stderr] | [INFO] [stderr] 558 | let our_commitment_number = 0xffffffffffff - ((((local_tx.tx.input[0].sequence as u64 & 0xffffff) << 3*8) | (local_tx.tx.lock_time as u64 & 0xffffff)) ^ self.commitment_transaction_number_obscure_factor); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(local_tx.tx.input[0].sequence)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/ln/channelmonitor.rs:558:114 [INFO] [stderr] | [INFO] [stderr] 558 | let our_commitment_number = 0xffffffffffff - ((((local_tx.tx.input[0].sequence as u64 & 0xffffff) << 3*8) | (local_tx.tx.lock_time as u64 & 0xffffff)) ^ self.commitment_transaction_number_obscure_factor); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(local_tx.tx.lock_time)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/ln/channelmonitor.rs:559:56 [INFO] [stderr] | [INFO] [stderr] 559 | let other_commitment_number = 0xffffffffffff - ((((other_local_tx.tx.input[0].sequence as u64 & 0xffffff) << 3*8) | (other_local_tx.tx.lock_time as u64 & 0xffffff)) ^ other.commitment_transaction_number_obscure_factor); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(other_local_tx.tx.input[0].sequence)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/ln/channelmonitor.rs:559:122 [INFO] [stderr] | [INFO] [stderr] 559 | let other_commitment_number = 0xffffffffffff - ((((other_local_tx.tx.input[0].sequence as u64 & 0xffffff) << 3*8) | (other_local_tx.tx.lock_time as u64 & 0xffffff)) ^ other.commitment_transaction_number_obscure_factor); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(other_local_tx.tx.lock_time)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/ln/channelmonitor.rs:603:35 [INFO] [stderr] | [INFO] [stderr] 603 | self.their_htlc_base_key = Some(their_htlc_base_key.clone()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*their_htlc_base_key` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/ln/channelmonitor.rs:604:46 [INFO] [stderr] | [INFO] [stderr] 604 | self.their_delayed_payment_base_key = Some(their_delayed_payment_base_key.clone()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*their_delayed_payment_base_key` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/ln/channelmonitor.rs:631:15 [INFO] [stderr] | [INFO] [stderr] 631 | res.push(((*txid).clone(), idx as u32, output)); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try dereferencing it: `*(*txid)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/ln/channelmonitor.rs:644:3 [INFO] [stderr] | [INFO] [stderr] 644 | match &self.funding_txo { [INFO] [stderr] | _________^ [INFO] [stderr] 645 | | &Some((ref outpoint, ref script)) => { [INFO] [stderr] 646 | | writer.write_all(&outpoint.txid[..])?; [INFO] [stderr] 647 | | writer.write_all(&byte_utils::be16_to_array(outpoint.index))?; [INFO] [stderr] ... | [INFO] [stderr] 654 | | }, [INFO] [stderr] 655 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 644 | match self.funding_txo { [INFO] [stderr] 645 | Some((ref outpoint, ref script)) => { [INFO] [stderr] 646 | writer.write_all(&outpoint.txid[..])?; [INFO] [stderr] 647 | writer.write_all(&byte_utils::be16_to_array(outpoint.index))?; [INFO] [stderr] 648 | script.write(writer)?; [INFO] [stderr] 649 | }, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/ln/channelmonitor.rs:860:3 [INFO] [stderr] | [INFO] [stderr] 860 | if let &Some(ref local_tx) = &self.current_local_signed_commitment_tx { [INFO] [stderr] | _________^ [INFO] [stderr] 861 | | 0xffff_ffff_ffff - ((((local_tx.tx.input[0].sequence as u64 & 0xffffff) << 3*8) | (local_tx.tx.lock_time as u64 & 0xffffff)) ^ self.commitment_transaction_number_obscure_factor) [INFO] [stderr] 862 | | } else { 0xffff_ffff_ffff } [INFO] [stderr] | |___________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 860 | if let Some(ref local_tx) = self.current_local_signed_commitment_tx { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/ln/channelmonitor.rs:861:27 [INFO] [stderr] | [INFO] [stderr] 861 | 0xffff_ffff_ffff - ((((local_tx.tx.input[0].sequence as u64 & 0xffffff) << 3*8) | (local_tx.tx.lock_time as u64 & 0xffffff)) ^ self.commitment_transaction_number_obscure_factor) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(local_tx.tx.input[0].sequence)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/ln/channelmonitor.rs:861:87 [INFO] [stderr] | [INFO] [stderr] 861 | 0xffff_ffff_ffff - ((((local_tx.tx.input[0].sequence as u64 & 0xffffff) << 3*8) | (local_tx.tx.lock_time as u64 & 0xffffff)) ^ self.commitment_transaction_number_obscure_factor) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(local_tx.tx.lock_time)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 48 [INFO] [stderr] --> src/ln/channelmonitor.rs:869:2 [INFO] [stderr] | [INFO] [stderr] 869 | fn check_spend_remote_transaction(&mut self, tx: &Transaction, height: u32) -> (Vec, (Sha256dHash, Vec), Vec) { [INFO] [stderr] | _____^ [INFO] [stderr] 870 | | // Most secp and related errors trying to create keys means we have no hope of constructing [INFO] [stderr] 871 | | // a spend transaction...so we return no transactions to broadcast [INFO] [stderr] 872 | | let mut txn_to_broadcast = Vec::new(); [INFO] [stderr] ... | [INFO] [stderr] 1195 | | (txn_to_broadcast, (commitment_txid, watch_outputs), spendable_outputs) [INFO] [stderr] 1196 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/ln/channelmonitor.rs:888:48 [INFO] [stderr] | [INFO] [stderr] 888 | let commitment_number = 0xffffffffffff - ((((tx.input[0].sequence as u64 & 0xffffff) << 3*8) | (tx.lock_time as u64 & 0xffffff)) ^ self.commitment_transaction_number_obscure_factor); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(tx.input[0].sequence)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/ln/channelmonitor.rs:888:99 [INFO] [stderr] | [INFO] [stderr] 888 | let commitment_number = 0xffffffffffff - ((((tx.input[0].sequence as u64 & 0xffffff) << 3*8) | (tx.lock_time as u64 & 0xffffff)) ^ self.commitment_transaction_number_obscure_factor); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(tx.lock_time)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/ln/channelmonitor.rs:1233:3 [INFO] [stderr] | [INFO] [stderr] 1233 | let mut amount = 0; [INFO] [stderr] | _________^ [INFO] [stderr] 1234 | | [INFO] [stderr] 1235 | | if tx.output[0].script_pubkey == revokeable_p2wsh { //HTLC transactions have one txin, one txout [INFO] [stderr] 1236 | | inputs.push(TxIn { [INFO] [stderr] ... | [INFO] [stderr] 1245 | | amount = tx.output[0].value; [INFO] [stderr] 1246 | | } [INFO] [stderr] | |_________^ help: it is more idiomatic to write: `let amount = if tx.output[0].script_pubkey == revokeable_p2wsh { ..; tx.output[0].value } else { 0 };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/ln/channelmonitor.rs:1360:3 [INFO] [stderr] | [INFO] [stderr] 1360 | if let &Some(ref local_tx) = &self.current_local_signed_commitment_tx { [INFO] [stderr] | _________^ [INFO] [stderr] 1361 | | if local_tx.txid == commitment_txid { [INFO] [stderr] 1362 | | match self.key_storage { [INFO] [stderr] 1363 | | KeyStorage::PrivMode { ref delayed_payment_base_key, ref latest_per_commitment_point, .. } => { [INFO] [stderr] ... | [INFO] [stderr] 1370 | | } [INFO] [stderr] 1371 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 1360 | if let Some(ref local_tx) = self.current_local_signed_commitment_tx { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/ln/channelmonitor.rs:1372:3 [INFO] [stderr] | [INFO] [stderr] 1372 | if let &Some(ref local_tx) = &self.prev_local_signed_commitment_tx { [INFO] [stderr] | _________^ [INFO] [stderr] 1373 | | if local_tx.txid == commitment_txid { [INFO] [stderr] 1374 | | match self.key_storage { [INFO] [stderr] 1375 | | KeyStorage::PrivMode { ref delayed_payment_base_key, ref prev_latest_per_commitment_point, .. } => { [INFO] [stderr] ... | [INFO] [stderr] 1382 | | } [INFO] [stderr] 1383 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 1372 | if let Some(ref local_tx) = self.prev_local_signed_commitment_tx { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/ln/channelmonitor.rs:1415:3 [INFO] [stderr] | [INFO] [stderr] 1415 | if let &Some(ref local_tx) = &self.current_local_signed_commitment_tx { [INFO] [stderr] | _________^ [INFO] [stderr] 1416 | | let mut res = vec![local_tx.tx.clone()]; [INFO] [stderr] 1417 | | match self.key_storage { [INFO] [stderr] 1418 | | KeyStorage::PrivMode { ref delayed_payment_base_key, ref prev_latest_per_commitment_point, .. } => { [INFO] [stderr] ... | [INFO] [stderr] 1425 | | Vec::new() [INFO] [stderr] 1426 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 1415 | if let Some(ref local_tx) = self.current_local_signed_commitment_tx { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/ln/channelmonitor.rs:1452:9 [INFO] [stderr] | [INFO] [stderr] 1452 | if !self.funding_txo.is_none() && txn.is_empty() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.funding_txo.is_some() && txn.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::nonminimal_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/ln/channelmonitor.rs:1440:116 [INFO] [stderr] | [INFO] [stderr] 1440 | if self.funding_txo.is_none() || (prevout.txid == self.funding_txo.as_ref().unwrap().0.txid && prevout.vout == self.funding_txo.as_ref().unwrap().0.index as u32) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(self.funding_txo.as_ref().unwrap().0.index)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/ln/channelmonitor.rs:1494:26 [INFO] [stderr] | [INFO] [stderr] 1494 | self.last_block_hash = block_hash.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try dereferencing it: `*block_hash` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_some()` [INFO] [stderr] --> src/ln/channelmonitor.rs:1642:11 [INFO] [stderr] | [INFO] [stderr] 1642 | if let Some(_) = remote_claimable_outpoints.insert(txid, outputs) { [INFO] [stderr] | _____________- ^^^^^^^ [INFO] [stderr] 1643 | | return Err(DecodeError::InvalidValue); [INFO] [stderr] 1644 | | } [INFO] [stderr] | |_____________- help: try this: `if remote_claimable_outpoints.insert(txid, outputs).is_some()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_some()` [INFO] [stderr] --> src/ln/channelmonitor.rs:1657:11 [INFO] [stderr] | [INFO] [stderr] 1657 | if let Some(_) = remote_commitment_txn_on_chain.insert(txid, (commitment_number, outputs)) { [INFO] [stderr] | _____________- ^^^^^^^ [INFO] [stderr] 1658 | | return Err(DecodeError::InvalidValue); [INFO] [stderr] 1659 | | } [INFO] [stderr] | |_____________- help: try this: `if remote_commitment_txn_on_chain.insert(txid, (commitment_number, outputs)).is_some()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_some()` [INFO] [stderr] --> src/ln/channelmonitor.rs:1667:11 [INFO] [stderr] | [INFO] [stderr] 1667 | if let Some(_) = remote_hash_commitment_number.insert(txid, commitment_number) { [INFO] [stderr] | _____________- ^^^^^^^ [INFO] [stderr] 1668 | | return Err(DecodeError::InvalidValue); [INFO] [stderr] 1669 | | } [INFO] [stderr] | |_____________- help: try this: `if remote_hash_commitment_number.insert(txid, commitment_number).is_some()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_some()` [INFO] [stderr] --> src/ln/channelmonitor.rs:1735:11 [INFO] [stderr] | [INFO] [stderr] 1735 | if let Some(_) = payment_preimages.insert(hash, preimage) { [INFO] [stderr] | _____________- ^^^^^^^ [INFO] [stderr] 1736 | | return Err(DecodeError::InvalidValue); [INFO] [stderr] 1737 | | } [INFO] [stderr] | |_____________- help: try this: `if payment_preimages.insert(hash, preimage).is_some()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/ln/channelmonitor.rs:1743:7 [INFO] [stderr] | [INFO] [stderr] 1743 | Ok((last_block_hash.clone(), ChannelMonitor { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `last_block_hash` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/ln/msgs.rs:68:3 [INFO] [stderr] | [INFO] [stderr] 68 | self.flags.len() > 0 && (self.flags[0] & 3) != 0 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!self.flags.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/ln/msgs.rs:71:3 [INFO] [stderr] | [INFO] [stderr] 71 | self.flags.len() > 0 && (self.flags[0] & 1) != 0 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!self.flags.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/ln/msgs.rs:75:3 [INFO] [stderr] | [INFO] [stderr] 75 | self.flags.len() > 0 && (self.flags[0] & (1 << 3)) != 0 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!self.flags.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/ln/msgs.rs:78:6 [INFO] [stderr] | [INFO] [stderr] 78 | if self.flags.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.flags.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/ln/msgs.rs:86:3 [INFO] [stderr] | [INFO] [stderr] 86 | self.flags.len() > 0 && (self.flags[0] & (3 << 4)) != 0 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!self.flags.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/ln/msgs.rs:89:3 [INFO] [stderr] | [INFO] [stderr] 89 | self.flags.len() > 0 && (self.flags[0] & (1 << 4)) != 0 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!self.flags.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] error: this `if` has identical blocks [INFO] [stderr] --> src/ln/msgs.rs:96:45 [INFO] [stderr] | [INFO] [stderr] 96 | } else if idx == 0 && (byte & 0x14) != 0 { [INFO] [stderr] | ______________________________________________________^ [INFO] [stderr] 97 | | return true; [INFO] [stderr] 98 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::if_same_then_else)] on by default [INFO] [stderr] note: same as this [INFO] [stderr] --> src/ln/msgs.rs:94:38 [INFO] [stderr] | [INFO] [stderr] 94 | if idx != 0 && (byte & 0x55) != 0 { [INFO] [stderr] | _______________________________________________^ [INFO] [stderr] 95 | | return true; [INFO] [stderr] 96 | | } else if idx == 0 && (byte & 0x14) != 0 { [INFO] [stderr] | |_____________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stderr] [INFO] [stderr] error: this `if` has identical blocks [INFO] [stderr] --> src/ln/msgs.rs:107:45 [INFO] [stderr] | [INFO] [stderr] 107 | } else if idx == 0 && (byte & 0xc4) != 0 { [INFO] [stderr] | ______________________________________________________^ [INFO] [stderr] 108 | | return true; [INFO] [stderr] 109 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] note: same as this [INFO] [stderr] --> src/ln/msgs.rs:105:29 [INFO] [stderr] | [INFO] [stderr] 105 | if idx != 0 && byte != 0 { [INFO] [stderr] | ______________________________________^ [INFO] [stderr] 106 | | return true; [INFO] [stderr] 107 | | } else if idx == 0 && (byte & 0xc4) != 0 { [INFO] [stderr] | |_____________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/ln/msgs.rs:376:3 [INFO] [stderr] | [INFO] [stderr] 376 | match self { [INFO] [stderr] | _________^ [INFO] [stderr] 377 | | &NetAddress::IPv4 {..} => { 1 }, [INFO] [stderr] 378 | | &NetAddress::IPv6 {..} => { 2 }, [INFO] [stderr] 379 | | &NetAddress::OnionV2 {..} => { 3 }, [INFO] [stderr] 380 | | &NetAddress::OnionV3 {..} => { 4 }, [INFO] [stderr] 381 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 376 | match *self { [INFO] [stderr] 377 | NetAddress::IPv4 {..} => { 1 }, [INFO] [stderr] 378 | NetAddress::IPv6 {..} => { 2 }, [INFO] [stderr] 379 | NetAddress::OnionV2 {..} => { 3 }, [INFO] [stderr] 380 | NetAddress::OnionV3 {..} => { 4 }, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/ln/msgs.rs:1156:4 [INFO] [stderr] | [INFO] [stderr] 1156 | match addr { [INFO] [stderr] | _____________^ [INFO] [stderr] 1157 | | &NetAddress::IPv4{addr, port} => { [INFO] [stderr] 1158 | | addr_slice.push(1); [INFO] [stderr] 1159 | | addr_slice.extend_from_slice(&addr); [INFO] [stderr] ... | [INFO] [stderr] 1178 | | }, [INFO] [stderr] 1179 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 1156 | match *addr { [INFO] [stderr] 1157 | NetAddress::IPv4{addr, port} => { [INFO] [stderr] 1158 | addr_slice.push(1); [INFO] [stderr] 1159 | addr_slice.extend_from_slice(&addr); [INFO] [stderr] 1160 | addr_slice.extend_from_slice(&byte_utils::be16_to_array(port)); [INFO] [stderr] 1161 | }, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/ln/msgs.rs:1211:9 [INFO] [stderr] | [INFO] [stderr] 1211 | if addresses.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!addresses.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/ln/msgs.rs:1245:33 [INFO] [stderr] | [INFO] [stderr] 1245 | if addresses.len() > 2 || (addresses.len() > 0 && addresses.last().unwrap().get_id() > 2) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!addresses.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/ln/msgs.rs:1262:33 [INFO] [stderr] | [INFO] [stderr] 1262 | if addresses.len() > 3 || (addresses.len() > 0 && addresses.last().unwrap().get_id() > 3) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!addresses.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/ln/router.rs:318:19 [INFO] [stderr] | [INFO] [stderr] 318 | src_node_id: msg.contents.node_id_1.clone(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `msg.contents.node_id_1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/ln/router.rs:328:19 [INFO] [stderr] | [INFO] [stderr] 328 | src_node_id: msg.contents.node_id_2.clone(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `msg.contents.node_id_2` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/ln/router.rs:395:3 [INFO] [stderr] | [INFO] [stderr] 395 | match update { [INFO] [stderr] | _________^ [INFO] [stderr] 396 | | &msgs::HTLCFailChannelUpdate::ChannelUpdateMessage { ref msg } => { [INFO] [stderr] 397 | | let _ = self.handle_channel_update(msg); [INFO] [stderr] 398 | | }, [INFO] [stderr] ... | [INFO] [stderr] 418 | | }, [INFO] [stderr] 419 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 395 | match *update { [INFO] [stderr] 396 | msgs::HTLCFailChannelUpdate::ChannelUpdateMessage { ref msg } => { [INFO] [stderr] 397 | let _ = self.handle_channel_update(msg); [INFO] [stderr] 398 | }, [INFO] [stderr] 399 | msgs::HTLCFailChannelUpdate::ChannelClosed { ref short_channel_id, ref is_permanent } => { [INFO] [stderr] 400 | let mut network = self.network_map.write().unwrap(); [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/ln/router.rs:452:21 [INFO] [stderr] | [INFO] [stderr] 452 | dest_node_id = channel.one_to_two.src_node_id.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `channel.one_to_two.src_node_id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/ln/router.rs:456:21 [INFO] [stderr] | [INFO] [stderr] 456 | dest_node_id = channel.two_to_one.src_node_id.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `channel.two_to_one.src_node_id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a BTreeMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/ln/router.rs:472:16 [INFO] [stderr] | [INFO] [stderr] 472 | let node = network.nodes.get(&dest_node_id).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&network.nodes[&dest_node_id]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a BTreeMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/ln/router.rs:475:17 [INFO] [stderr] | [INFO] [stderr] 475 | let chan = network.channels.get(chan_id).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&network.channels[chan_id]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/ln/router.rs:574:16 [INFO] [stderr] | [INFO] [stderr] 574 | nodes.insert(our_pubkey.clone(), NodeInfo { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `our_pubkey` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 69 [INFO] [stderr] --> src/ln/router.rs:654:2 [INFO] [stderr] | [INFO] [stderr] 654 | pub fn get_route(&self, target: &PublicKey, first_hops: Option<&[channelmanager::ChannelDetails]>, last_hops: &[RouteHint], final_value_msat: u64, final_cltv: u32) -> Result { [INFO] [stderr] | _____^ [INFO] [stderr] 655 | | // TODO: Obviously *only* using total fee cost sucks. We should consider weighting by [INFO] [stderr] 656 | | // uptime/success in using a node in the past. [INFO] [stderr] 657 | | let network = self.network_map.read().unwrap(); [INFO] [stderr] ... | [INFO] [stderr] 836 | | Err(HandleError{err: "Failed to find a path to the given destination", action: None}) [INFO] [stderr] 837 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/ln/router.rs:674:17 [INFO] [stderr] | [INFO] [stderr] 674 | src_node_id: network.our_node_id.clone(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `network.our_node_id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/ln/router.rs:712:90 [INFO] [stderr] | [INFO] [stderr] 712 | let proportional_fee_millions = ($starting_fee_msat + final_value_msat).checked_mul($directional_info.fee_proportional_millionths as u64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from($directional_info.fee_proportional_millionths)` [INFO] [stderr] ... [INFO] [stderr] 792 | add_entries_to_cheapest_to_target_node!(node, target, 0); [INFO] [stderr] | --------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/ln/router.rs:714:8 [INFO] [stderr] | [INFO] [stderr] 714 | ($directional_info.fee_base_msat as u64).checked_add(part / 1000000) }) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from($directional_info.fee_base_msat)` [INFO] [stderr] ... [INFO] [stderr] 792 | add_entries_to_cheapest_to_target_node!(node, target, 0); [INFO] [stderr] | --------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/ln/router.rs:734:88 [INFO] [stderr] | [INFO] [stderr] 734 | if let Some(fee_inc) = final_value_msat.checked_add(total_fee).and_then(|inc| { (old_entry.2 as u64).checked_mul(inc) }) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(old_entry.2)` [INFO] [stderr] ... [INFO] [stderr] 792 | add_entries_to_cheapest_to_target_node!(node, target, 0); [INFO] [stderr] | --------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/ln/router.rs:735:42 [INFO] [stderr] | [INFO] [stderr] 735 | total_fee += fee_inc / 1000000 + (old_entry.1 as u64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(old_entry.1)` [INFO] [stderr] ... [INFO] [stderr] 792 | add_entries_to_cheapest_to_target_node!(node, target, 0); [INFO] [stderr] | --------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/ln/router.rs:712:90 [INFO] [stderr] | [INFO] [stderr] 712 | let proportional_fee_millions = ($starting_fee_msat + final_value_msat).checked_mul($directional_info.fee_proportional_millionths as u64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from($directional_info.fee_proportional_millionths)` [INFO] [stderr] ... [INFO] [stderr] 792 | add_entries_to_cheapest_to_target_node!(node, target, 0); [INFO] [stderr] | --------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/ln/router.rs:714:8 [INFO] [stderr] | [INFO] [stderr] 714 | ($directional_info.fee_base_msat as u64).checked_add(part / 1000000) }) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from($directional_info.fee_base_msat)` [INFO] [stderr] ... [INFO] [stderr] 792 | add_entries_to_cheapest_to_target_node!(node, target, 0); [INFO] [stderr] | --------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/ln/router.rs:734:88 [INFO] [stderr] | [INFO] [stderr] 734 | if let Some(fee_inc) = final_value_msat.checked_add(total_fee).and_then(|inc| { (old_entry.2 as u64).checked_mul(inc) }) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(old_entry.2)` [INFO] [stderr] ... [INFO] [stderr] 792 | add_entries_to_cheapest_to_target_node!(node, target, 0); [INFO] [stderr] | --------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/ln/router.rs:735:42 [INFO] [stderr] | [INFO] [stderr] 735 | total_fee += fee_inc / 1000000 + (old_entry.1 as u64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(old_entry.1)` [INFO] [stderr] ... [INFO] [stderr] 792 | add_entries_to_cheapest_to_target_node!(node, target, 0); [INFO] [stderr] | --------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/ln/router.rs:753:28 [INFO] [stderr] | [INFO] [stderr] 753 | cltv_expiry_delta: $directional_info.cltv_expiry_delta as u32, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from($directional_info.cltv_expiry_delta)` [INFO] [stderr] ... [INFO] [stderr] 792 | add_entries_to_cheapest_to_target_node!(node, target, 0); [INFO] [stderr] | --------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/ln/router.rs:712:90 [INFO] [stderr] | [INFO] [stderr] 712 | let proportional_fee_millions = ($starting_fee_msat + final_value_msat).checked_mul($directional_info.fee_proportional_millionths as u64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from($directional_info.fee_proportional_millionths)` [INFO] [stderr] ... [INFO] [stderr] 792 | add_entries_to_cheapest_to_target_node!(node, target, 0); [INFO] [stderr] | --------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/ln/router.rs:714:8 [INFO] [stderr] | [INFO] [stderr] 714 | ($directional_info.fee_base_msat as u64).checked_add(part / 1000000) }) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from($directional_info.fee_base_msat)` [INFO] [stderr] ... [INFO] [stderr] 792 | add_entries_to_cheapest_to_target_node!(node, target, 0); [INFO] [stderr] | --------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/ln/router.rs:734:88 [INFO] [stderr] | [INFO] [stderr] 734 | if let Some(fee_inc) = final_value_msat.checked_add(total_fee).and_then(|inc| { (old_entry.2 as u64).checked_mul(inc) }) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(old_entry.2)` [INFO] [stderr] ... [INFO] [stderr] 792 | add_entries_to_cheapest_to_target_node!(node, target, 0); [INFO] [stderr] | --------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/ln/router.rs:735:42 [INFO] [stderr] | [INFO] [stderr] 735 | total_fee += fee_inc / 1000000 + (old_entry.1 as u64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(old_entry.1)` [INFO] [stderr] ... [INFO] [stderr] 792 | add_entries_to_cheapest_to_target_node!(node, target, 0); [INFO] [stderr] | --------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/ln/router.rs:753:28 [INFO] [stderr] | [INFO] [stderr] 753 | cltv_expiry_delta: $directional_info.cltv_expiry_delta as u32, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from($directional_info.cltv_expiry_delta)` [INFO] [stderr] ... [INFO] [stderr] 792 | add_entries_to_cheapest_to_target_node!(node, target, 0); [INFO] [stderr] | --------------------------------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/ln/router.rs:712:90 [INFO] [stderr] | [INFO] [stderr] 712 | let proportional_fee_millions = ($starting_fee_msat + final_value_msat).checked_mul($directional_info.fee_proportional_millionths as u64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from($directional_info.fee_proportional_millionths)` [INFO] [stderr] ... [INFO] [stderr] 801 | add_entry!(first_hop, hop.src_node_id, dummy_directional_info, 0); [INFO] [stderr] | ------------------------------------------------------------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/ln/router.rs:714:8 [INFO] [stderr] | [INFO] [stderr] 714 | ($directional_info.fee_base_msat as u64).checked_add(part / 1000000) }) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from($directional_info.fee_base_msat)` [INFO] [stderr] ... [INFO] [stderr] 801 | add_entry!(first_hop, hop.src_node_id, dummy_directional_info, 0); [INFO] [stderr] | ------------------------------------------------------------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/ln/router.rs:734:88 [INFO] [stderr] | [INFO] [stderr] 734 | if let Some(fee_inc) = final_value_msat.checked_add(total_fee).and_then(|inc| { (old_entry.2 as u64).checked_mul(inc) }) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(old_entry.2)` [INFO] [stderr] ... [INFO] [stderr] 801 | add_entry!(first_hop, hop.src_node_id, dummy_directional_info, 0); [INFO] [stderr] | ------------------------------------------------------------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/ln/router.rs:735:42 [INFO] [stderr] | [INFO] [stderr] 735 | total_fee += fee_inc / 1000000 + (old_entry.1 as u64); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(old_entry.1)` [INFO] [stderr] ... [INFO] [stderr] 801 | add_entry!(first_hop, hop.src_node_id, dummy_directional_info, 0); [INFO] [stderr] | ------------------------------------------------------------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/ln/router.rs:712:90 [WARN] too many lines in the log, truncating it