[INFO] crate lightfield_loader 0.3.0 is already in cache [INFO] extracting crate lightfield_loader 0.3.0 into work/ex/clippy-test-run/sources/stable/reg/lightfield_loader/0.3.0 [INFO] extracting crate lightfield_loader 0.3.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/lightfield_loader/0.3.0 [INFO] validating manifest of lightfield_loader-0.3.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of lightfield_loader-0.3.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing lightfield_loader-0.3.0 [INFO] finished frobbing lightfield_loader-0.3.0 [INFO] frobbed toml for lightfield_loader-0.3.0 written to work/ex/clippy-test-run/sources/stable/reg/lightfield_loader/0.3.0/Cargo.toml [INFO] started frobbing lightfield_loader-0.3.0 [INFO] finished frobbing lightfield_loader-0.3.0 [INFO] frobbed toml for lightfield_loader-0.3.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/lightfield_loader/0.3.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting lightfield_loader-0.3.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/lightfield_loader/0.3.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 2bf7b3b779c9a870ec547cdeef2aad8b13e9780a48e5fccb5638aaa8029d3bf5 [INFO] running `"docker" "start" "-a" "2bf7b3b779c9a870ec547cdeef2aad8b13e9780a48e5fccb5638aaa8029d3bf5"` [INFO] [stderr] Checking png v0.5.2 [INFO] [stderr] Checking zip v0.1.19 [INFO] [stderr] Checking cgmath v0.9.1 [INFO] [stderr] Checking image v0.10.4 [INFO] [stderr] Checking lightfield_loader v0.3.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lightfield.rs:91:17 [INFO] [stderr] | [INFO] [stderr] 91 | image: image, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `image` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lightfield.rs:92:17 [INFO] [stderr] | [INFO] [stderr] 92 | ix: ix, [INFO] [stderr] | ^^^^^^ help: replace it with: `ix` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lightfield.rs:93:17 [INFO] [stderr] | [INFO] [stderr] 93 | iy: iy, [INFO] [stderr] | ^^^^^^ help: replace it with: `iy` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lightfield.rs:97:25 [INFO] [stderr] | [INFO] [stderr] 97 | Ok(Lightfield { views: views }) [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `views` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lightfield.rs:91:17 [INFO] [stderr] | [INFO] [stderr] 91 | image: image, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `image` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lightfield.rs:92:17 [INFO] [stderr] | [INFO] [stderr] 92 | ix: ix, [INFO] [stderr] | ^^^^^^ help: replace it with: `ix` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lightfield.rs:93:17 [INFO] [stderr] | [INFO] [stderr] 93 | iy: iy, [INFO] [stderr] | ^^^^^^ help: replace it with: `iy` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lightfield.rs:97:25 [INFO] [stderr] | [INFO] [stderr] 97 | Ok(Lightfield { views: views }) [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `views` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/lightfield.rs:78:47 [INFO] [stderr] | [INFO] [stderr] 78 | let parts: Vec<&str> = name.split("_").collect(); [INFO] [stderr] | ^^^ help: try using a char instead: `'_'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/lightfield.rs:78:47 [INFO] [stderr] | [INFO] [stderr] 78 | let parts: Vec<&str> = name.split("_").collect(); [INFO] [stderr] | ^^^ help: try using a char instead: `'_'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> tests/lib.rs:31:22 [INFO] [stderr] | [INFO] [stderr] 31 | _ => {panic!(format!("failed to fail"))}, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"failed to fail".to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 20.04s [INFO] running `"docker" "inspect" "2bf7b3b779c9a870ec547cdeef2aad8b13e9780a48e5fccb5638aaa8029d3bf5"` [INFO] running `"docker" "rm" "-f" "2bf7b3b779c9a870ec547cdeef2aad8b13e9780a48e5fccb5638aaa8029d3bf5"` [INFO] [stdout] 2bf7b3b779c9a870ec547cdeef2aad8b13e9780a48e5fccb5638aaa8029d3bf5