[INFO] crate lifx-core 0.2.0 is already in cache [INFO] extracting crate lifx-core 0.2.0 into work/ex/clippy-test-run/sources/stable/reg/lifx-core/0.2.0 [INFO] extracting crate lifx-core 0.2.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/lifx-core/0.2.0 [INFO] validating manifest of lifx-core-0.2.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of lifx-core-0.2.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing lifx-core-0.2.0 [INFO] finished frobbing lifx-core-0.2.0 [INFO] frobbed toml for lifx-core-0.2.0 written to work/ex/clippy-test-run/sources/stable/reg/lifx-core/0.2.0/Cargo.toml [INFO] started frobbing lifx-core-0.2.0 [INFO] finished frobbing lifx-core-0.2.0 [INFO] frobbed toml for lifx-core-0.2.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/lifx-core/0.2.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting lifx-core-0.2.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/lifx-core/0.2.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 89a99dc365156f1824aa3247d30c0d76399dd217d72b9611061efe6fa5a4cd0c [INFO] running `"docker" "start" "-a" "89a99dc365156f1824aa3247d30c0d76399dd217d72b9611061efe6fa5a4cd0c"` [INFO] [stderr] Checking lifx-core v0.2.0 (/opt/crater/workdir) [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/lib.rs:1116:16 [INFO] [stderr] | [INFO] [stderr] 1116 | } else { [INFO] [stderr] | ________________^ [INFO] [stderr] 1117 | | if self.saturation == 0 { [INFO] [stderr] 1118 | | format!("{:.0}% White ({})", self.brightness as f32 / 655.35, describe_kelvin(self.kelvin)) [INFO] [stderr] 1119 | | } else { // colors [INFO] [stderr] 1120 | | format!("{}% hue: {} sat: {}", self.brightness as f32 / 655.35, self.hue, self.saturation) [INFO] [stderr] 1121 | | } [INFO] [stderr] 1122 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 1116 | } else if self.saturation == 0 { [INFO] [stderr] 1117 | format!("{:.0}% White ({})", self.brightness as f32 / 655.35, describe_kelvin(self.kelvin)) [INFO] [stderr] 1118 | } else { // colors [INFO] [stderr] 1119 | format!("{}% hue: {} sat: {}", self.brightness as f32 / 655.35, self.hue, self.saturation) [INFO] [stderr] 1120 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/lib.rs:1116:16 [INFO] [stderr] | [INFO] [stderr] 1116 | } else { [INFO] [stderr] | ________________^ [INFO] [stderr] 1117 | | if self.saturation == 0 { [INFO] [stderr] 1118 | | format!("{:.0}% White ({})", self.brightness as f32 / 655.35, describe_kelvin(self.kelvin)) [INFO] [stderr] 1119 | | } else { // colors [INFO] [stderr] 1120 | | format!("{}% hue: {} sat: {}", self.brightness as f32 / 655.35, self.hue, self.saturation) [INFO] [stderr] 1121 | | } [INFO] [stderr] 1122 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 1116 | } else if self.saturation == 0 { [INFO] [stderr] 1117 | format!("{:.0}% White ({})", self.brightness as f32 / 655.35, describe_kelvin(self.kelvin)) [INFO] [stderr] 1118 | } else { // colors [INFO] [stderr] 1119 | format!("{}% hue: {} sat: {}", self.brightness as f32 / 655.35, self.hue, self.saturation) [INFO] [stderr] 1120 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:1871:21 [INFO] [stderr] | [INFO] [stderr] 1871 | source: 1234567, [INFO] [stderr] | ^^^^^^^ help: consider: `1_234_567` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:1909:34 [INFO] [stderr] | [INFO] [stderr] 1909 | assert_eq!(frame.source, 0x524b5242); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x524b_5242` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:1926:34 [INFO] [stderr] | [INFO] [stderr] 1926 | assert_eq!(frame.source, 0x053741ca); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0537_41ca` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:1932:21 [INFO] [stderr] | [INFO] [stderr] 1932 | target: 0x11224488, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x1122_4488` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/lib.rs:1109:21 [INFO] [stderr] | [INFO] [stderr] 1109 | pub fn describe(&self, short: bool) -> String { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: casting u16 to f32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:1114:41 [INFO] [stderr] | [INFO] [stderr] 1114 | format!("{:.0}/{:.0}", (self.hue as f32 / 65535.0) * 360.0, self.saturation as f32 / 655.35) [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `f32::from(self.hue)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to f32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:1114:77 [INFO] [stderr] | [INFO] [stderr] 1114 | format!("{:.0}/{:.0}", (self.hue as f32 / 65535.0) * 360.0, self.saturation as f32 / 655.35) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f32::from(self.saturation)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to f32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:1118:46 [INFO] [stderr] | [INFO] [stderr] 1118 | format!("{:.0}% White ({})", self.brightness as f32 / 655.35, describe_kelvin(self.kelvin)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `f32::from(self.brightness)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to f32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:1120:48 [INFO] [stderr] | [INFO] [stderr] 1120 | format!("{}% hue: {} sat: {}", self.brightness as f32 / 655.35, self.hue, self.saturation) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `f32::from(self.brightness)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/lib.rs:1109:21 [INFO] [stderr] | [INFO] [stderr] 1109 | pub fn describe(&self, short: bool) -> String { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: casting u16 to f32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:1114:41 [INFO] [stderr] | [INFO] [stderr] 1114 | format!("{:.0}/{:.0}", (self.hue as f32 / 65535.0) * 360.0, self.saturation as f32 / 655.35) [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `f32::from(self.hue)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to f32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:1114:77 [INFO] [stderr] | [INFO] [stderr] 1114 | format!("{:.0}/{:.0}", (self.hue as f32 / 65535.0) * 360.0, self.saturation as f32 / 655.35) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f32::from(self.saturation)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to f32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:1118:46 [INFO] [stderr] | [INFO] [stderr] 1118 | format!("{:.0}% White ({})", self.brightness as f32 / 655.35, describe_kelvin(self.kelvin)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `f32::from(self.brightness)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to f32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:1120:48 [INFO] [stderr] | [INFO] [stderr] 1120 | format!("{}% hue: {} sat: {}", self.brightness as f32 / 655.35, self.hue, self.saturation) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `f32::from(self.brightness)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 3.29s [INFO] running `"docker" "inspect" "89a99dc365156f1824aa3247d30c0d76399dd217d72b9611061efe6fa5a4cd0c"` [INFO] running `"docker" "rm" "-f" "89a99dc365156f1824aa3247d30c0d76399dd217d72b9611061efe6fa5a4cd0c"` [INFO] [stdout] 89a99dc365156f1824aa3247d30c0d76399dd217d72b9611061efe6fa5a4cd0c