[INFO] crate life 0.1.5 is already in cache [INFO] extracting crate life 0.1.5 into work/ex/clippy-test-run/sources/stable/reg/life/0.1.5 [INFO] extracting crate life 0.1.5 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/life/0.1.5 [INFO] validating manifest of life-0.1.5 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of life-0.1.5 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing life-0.1.5 [INFO] finished frobbing life-0.1.5 [INFO] frobbed toml for life-0.1.5 written to work/ex/clippy-test-run/sources/stable/reg/life/0.1.5/Cargo.toml [INFO] started frobbing life-0.1.5 [INFO] finished frobbing life-0.1.5 [INFO] frobbed toml for life-0.1.5 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/life/0.1.5/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting life-0.1.5 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/life/0.1.5:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] a1ba329c0484806d563cd365ae131c0d7cbf485e1912341f389c6c5704010984 [INFO] running `"docker" "start" "-a" "a1ba329c0484806d563cd365ae131c0d7cbf485e1912341f389c6c5704010984"` [INFO] [stderr] Checking life v0.1.5 (/opt/crater/workdir) [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/main.rs:150:9 [INFO] [stderr] | [INFO] [stderr] 150 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::println_empty_string)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/main.rs:156:13 [INFO] [stderr] | [INFO] [stderr] 156 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/main.rs:161:13 [INFO] [stderr] | [INFO] [stderr] 161 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/main.rs:220:13 [INFO] [stderr] | [INFO] [stderr] 220 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/main.rs:150:9 [INFO] [stderr] | [INFO] [stderr] 150 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::println_empty_string)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/main.rs:156:13 [INFO] [stderr] | [INFO] [stderr] 156 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/main.rs:161:13 [INFO] [stderr] | [INFO] [stderr] 161 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/main.rs:220:13 [INFO] [stderr] | [INFO] [stderr] 220 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/main.rs:65:24 [INFO] [stderr] | [INFO] [stderr] 65 | fn next_life_state(&self) -> bool { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use `&Box`. Consider using just `&T` [INFO] [stderr] --> src/main.rs:73:24 [INFO] [stderr] | [INFO] [stderr] 73 | fn print(&self, t: &mut Box, top: bool) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&mut term::StdoutTerminal` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::borrowed_box)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrowed_box [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/main.rs:73:14 [INFO] [stderr] | [INFO] [stderr] 73 | fn print(&self, t: &mut Box, top: bool) { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/main.rs:74:9 [INFO] [stderr] | [INFO] [stderr] 74 | / match self.live { [INFO] [stderr] 75 | | true => { [INFO] [stderr] 76 | | t.fg(term::color::YELLOW).unwrap(); [INFO] [stderr] 77 | | t.bg(term::color::CYAN).unwrap(); [INFO] [stderr] ... | [INFO] [stderr] 90 | | }, [INFO] [stderr] 91 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] help: consider using an if/else expression [INFO] [stderr] | [INFO] [stderr] 74 | if self.live { [INFO] [stderr] 75 | t.fg(term::color::YELLOW).unwrap(); [INFO] [stderr] 76 | t.bg(term::color::CYAN).unwrap(); [INFO] [stderr] 77 | match top { [INFO] [stderr] 78 | true => write!(t, "/o.o\\").unwrap(), [INFO] [stderr] 79 | false => write!(t, "\\---/").unwrap(), [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/main.rs:78:17 [INFO] [stderr] | [INFO] [stderr] 78 | / match top { [INFO] [stderr] 79 | | true => write!(t, "/o.o\\").unwrap(), [INFO] [stderr] 80 | | false => write!(t, "\\---/").unwrap(), [INFO] [stderr] 81 | | } [INFO] [stderr] | |_________________^ help: consider using an if/else expression: `if top { write!(t, "/o.o\\").unwrap() } else { write!(t, "\\---/").unwrap() }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/main.rs:86:17 [INFO] [stderr] | [INFO] [stderr] 86 | / match top { [INFO] [stderr] 87 | | true => write!(t, "| ").unwrap(), [INFO] [stderr] 88 | | false => write!(t, "|____").unwrap(), [INFO] [stderr] 89 | | } [INFO] [stderr] | |_________________^ help: consider using an if/else expression: `if top { write!(t, "| ").unwrap() } else { write!(t, "|____").unwrap() }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:101:20 [INFO] [stderr] | [INFO] [stderr] 101 | fn new(points: &Vec<(usize, usize)>) -> Board { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: change this to: `&[(usize, usize)]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: avoid using `collect()` when not needed [INFO] [stderr] --> src/main.rs:134:13 [INFO] [stderr] | [INFO] [stderr] 134 | / .collect::>() [INFO] [stderr] 135 | | .len() as u8 [INFO] [stderr] | |__________________^ help: replace with: `.count()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_collect)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_collect [INFO] [stderr] [INFO] [stderr] warning: equality checks against true are unnecessary [INFO] [stderr] --> src/main.rs:133:26 [INFO] [stderr] | [INFO] [stderr] 133 | .filter(|&z| z == true) [INFO] [stderr] | ^^^^^^^^^ help: try simplifying it as shown: `z` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::bool_comparison)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/main.rs:65:24 [INFO] [stderr] | [INFO] [stderr] 65 | fn next_life_state(&self) -> bool { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use `&Box`. Consider using just `&T` [INFO] [stderr] --> src/main.rs:73:24 [INFO] [stderr] | [INFO] [stderr] 73 | fn print(&self, t: &mut Box, top: bool) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `&mut term::StdoutTerminal` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::borrowed_box)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrowed_box [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/main.rs:73:14 [INFO] [stderr] | [INFO] [stderr] 73 | fn print(&self, t: &mut Box, top: bool) { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/main.rs:74:9 [INFO] [stderr] | [INFO] [stderr] 74 | / match self.live { [INFO] [stderr] 75 | | true => { [INFO] [stderr] 76 | | t.fg(term::color::YELLOW).unwrap(); [INFO] [stderr] 77 | | t.bg(term::color::CYAN).unwrap(); [INFO] [stderr] ... | [INFO] [stderr] 90 | | }, [INFO] [stderr] 91 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] help: consider using an if/else expression [INFO] [stderr] | [INFO] [stderr] 74 | if self.live { [INFO] [stderr] 75 | t.fg(term::color::YELLOW).unwrap(); [INFO] [stderr] 76 | t.bg(term::color::CYAN).unwrap(); [INFO] [stderr] 77 | match top { [INFO] [stderr] 78 | true => write!(t, "/o.o\\").unwrap(), [INFO] [stderr] 79 | false => write!(t, "\\---/").unwrap(), [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/main.rs:78:17 [INFO] [stderr] | [INFO] [stderr] 78 | / match top { [INFO] [stderr] 79 | | true => write!(t, "/o.o\\").unwrap(), [INFO] [stderr] 80 | | false => write!(t, "\\---/").unwrap(), [INFO] [stderr] 81 | | } [INFO] [stderr] | |_________________^ help: consider using an if/else expression: `if top { write!(t, "/o.o\\").unwrap() } else { write!(t, "\\---/").unwrap() }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/main.rs:86:17 [INFO] [stderr] | [INFO] [stderr] 86 | / match top { [INFO] [stderr] 87 | | true => write!(t, "| ").unwrap(), [INFO] [stderr] 88 | | false => write!(t, "|____").unwrap(), [INFO] [stderr] 89 | | } [INFO] [stderr] | |_________________^ help: consider using an if/else expression: `if top { write!(t, "| ").unwrap() } else { write!(t, "|____").unwrap() }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:101:20 [INFO] [stderr] | [INFO] [stderr] 101 | fn new(points: &Vec<(usize, usize)>) -> Board { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: change this to: `&[(usize, usize)]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: avoid using `collect()` when not needed [INFO] [stderr] --> src/main.rs:134:13 [INFO] [stderr] | [INFO] [stderr] 134 | / .collect::>() [INFO] [stderr] 135 | | .len() as u8 [INFO] [stderr] | |__________________^ help: replace with: `.count()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_collect)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_collect [INFO] [stderr] [INFO] [stderr] warning: equality checks against true are unnecessary [INFO] [stderr] --> src/main.rs:133:26 [INFO] [stderr] | [INFO] [stderr] 133 | .filter(|&z| z == true) [INFO] [stderr] | ^^^^^^^^^ help: try simplifying it as shown: `z` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::bool_comparison)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.24s [INFO] running `"docker" "inspect" "a1ba329c0484806d563cd365ae131c0d7cbf485e1912341f389c6c5704010984"` [INFO] running `"docker" "rm" "-f" "a1ba329c0484806d563cd365ae131c0d7cbf485e1912341f389c6c5704010984"` [INFO] [stdout] a1ba329c0484806d563cd365ae131c0d7cbf485e1912341f389c6c5704010984