[INFO] crate lidar_lite_v3 0.1.0 is already in cache [INFO] extracting crate lidar_lite_v3 0.1.0 into work/ex/clippy-test-run/sources/stable/reg/lidar_lite_v3/0.1.0 [INFO] extracting crate lidar_lite_v3 0.1.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/lidar_lite_v3/0.1.0 [INFO] validating manifest of lidar_lite_v3-0.1.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of lidar_lite_v3-0.1.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing lidar_lite_v3-0.1.0 [INFO] finished frobbing lidar_lite_v3-0.1.0 [INFO] frobbed toml for lidar_lite_v3-0.1.0 written to work/ex/clippy-test-run/sources/stable/reg/lidar_lite_v3/0.1.0/Cargo.toml [INFO] started frobbing lidar_lite_v3-0.1.0 [INFO] finished frobbing lidar_lite_v3-0.1.0 [INFO] frobbed toml for lidar_lite_v3-0.1.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/lidar_lite_v3/0.1.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting lidar_lite_v3-0.1.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/lidar_lite_v3/0.1.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 6968a1a08419d2628c03b0d109886a8e2c0630f5cdf800c22a74a99e854078c2 [INFO] running `"docker" "start" "-a" "6968a1a08419d2628c03b0d109886a8e2c0630f5cdf800c22a74a99e854078c2"` [INFO] [stderr] Checking lidar_lite_v3 v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:41:26 [INFO] [stderr] | [INFO] [stderr] 41 | Ok(LidarLiteV3 { i2cdev: i2cdev }) [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `i2cdev` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:41:26 [INFO] [stderr] | [INFO] [stderr] 41 | Ok(LidarLiteV3 { i2cdev: i2cdev }) [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `i2cdev` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:24:36 [INFO] [stderr] | [INFO] [stderr] 24 | const BUSY = 0b00000001, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_0001` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:25:36 [INFO] [stderr] | [INFO] [stderr] 25 | const REFERENCE_OVERFLOW = 0b00000010, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_0010` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:26:36 [INFO] [stderr] | [INFO] [stderr] 26 | const SIGNAL_OVERFLOW = 0b00000100, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_0100` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:27:36 [INFO] [stderr] | [INFO] [stderr] 27 | const INVALID_SIGNAL = 0b00001000, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_1000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:28:36 [INFO] [stderr] | [INFO] [stderr] 28 | const SECONDARY_RETURN = 0b00010000, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0001_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:29:36 [INFO] [stderr] | [INFO] [stderr] 29 | const HEALTH = 0b00100000, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0010_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:30:36 [INFO] [stderr] | [INFO] [stderr] 30 | const PROCESS_ERROR = 0b01000000, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0100_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:24:36 [INFO] [stderr] | [INFO] [stderr] 24 | const BUSY = 0b00000001, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_0001` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:25:36 [INFO] [stderr] | [INFO] [stderr] 25 | const REFERENCE_OVERFLOW = 0b00000010, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_0010` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:26:36 [INFO] [stderr] | [INFO] [stderr] 26 | const SIGNAL_OVERFLOW = 0b00000100, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_0100` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:27:36 [INFO] [stderr] | [INFO] [stderr] 27 | const INVALID_SIGNAL = 0b00001000, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_1000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:28:36 [INFO] [stderr] | [INFO] [stderr] 28 | const SECONDARY_RETURN = 0b00010000, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0001_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:29:36 [INFO] [stderr] | [INFO] [stderr] 29 | const HEALTH = 0b00100000, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0010_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:30:36 [INFO] [stderr] | [INFO] [stderr] 30 | const PROCESS_ERROR = 0b01000000, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0100_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: constant item is never used: `RESET` [INFO] [stderr] --> src/lib.rs:18:1 [INFO] [stderr] | [INFO] [stderr] 18 | const RESET: u8 = 0x00; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: constant item is never used: `RESET` [INFO] [stderr] --> src/lib.rs:18:1 [INFO] [stderr] | [INFO] [stderr] 18 | const RESET: u8 = 0x00; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/lib.rs:58:56 [INFO] [stderr] | [INFO] [stderr] 58 | self.i2cdev.smbus_write_byte_data(ACQ_COMMAND, match receiver_bias_correction { [INFO] [stderr] | ________________________________________________________^ [INFO] [stderr] 59 | | true => DISTANCE_WITH_RECEIVER_BIAS_CORRECTION, [INFO] [stderr] 60 | | false => DISTANCE_WITHOUT_RECEIVER_BIAS_CORRECTION [INFO] [stderr] 61 | | })?; [INFO] [stderr] | |_________^ help: consider using an if/else expression: `if receiver_bias_correction { DISTANCE_WITH_RECEIVER_BIAS_CORRECTION } else { DISTANCE_WITHOUT_RECEIVER_BIAS_CORRECTION }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/lib.rs:58:56 [INFO] [stderr] | [INFO] [stderr] 58 | self.i2cdev.smbus_write_byte_data(ACQ_COMMAND, match receiver_bias_correction { [INFO] [stderr] | ________________________________________________________^ [INFO] [stderr] 59 | | true => DISTANCE_WITH_RECEIVER_BIAS_CORRECTION, [INFO] [stderr] 60 | | false => DISTANCE_WITHOUT_RECEIVER_BIAS_CORRECTION [INFO] [stderr] 61 | | })?; [INFO] [stderr] | |_________^ help: consider using an if/else expression: `if receiver_bias_correction { DISTANCE_WITH_RECEIVER_BIAS_CORRECTION } else { DISTANCE_WITHOUT_RECEIVER_BIAS_CORRECTION }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 2.68s [INFO] running `"docker" "inspect" "6968a1a08419d2628c03b0d109886a8e2c0630f5cdf800c22a74a99e854078c2"` [INFO] running `"docker" "rm" "-f" "6968a1a08419d2628c03b0d109886a8e2c0630f5cdf800c22a74a99e854078c2"` [INFO] [stdout] 6968a1a08419d2628c03b0d109886a8e2c0630f5cdf800c22a74a99e854078c2