[INFO] crate libtftp 0.1.2 is already in cache [INFO] extracting crate libtftp 0.1.2 into work/ex/clippy-test-run/sources/stable/reg/libtftp/0.1.2 [INFO] extracting crate libtftp 0.1.2 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/libtftp/0.1.2 [INFO] validating manifest of libtftp-0.1.2 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of libtftp-0.1.2 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing libtftp-0.1.2 [INFO] finished frobbing libtftp-0.1.2 [INFO] frobbed toml for libtftp-0.1.2 written to work/ex/clippy-test-run/sources/stable/reg/libtftp/0.1.2/Cargo.toml [INFO] started frobbing libtftp-0.1.2 [INFO] finished frobbing libtftp-0.1.2 [INFO] frobbed toml for libtftp-0.1.2 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/libtftp/0.1.2/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting libtftp-0.1.2 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/libtftp/0.1.2:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 1e67eb6683381339be528757955407b2d652985e6dea17e8b903c85770cfd6d7 [INFO] running `"docker" "start" "-a" "1e67eb6683381339be528757955407b2d652985e6dea17e8b903c85770cfd6d7"` [INFO] [stderr] Checking libtftp v0.1.2 (/opt/crater/workdir) [INFO] [stderr] warning: lint name `use_self` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/lib.rs:6:44 [INFO] [stderr] | [INFO] [stderr] 6 | #![cfg_attr(feature = "cargo-clippy", warn(use_self))] [INFO] [stderr] | ^^^^^^^^ help: change it to: `clippy::use_self` [INFO] [stderr] warning: lint name `use_self` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/lib.rs:6:44 [INFO] [stderr] | [INFO] [stderr] 6 | #![cfg_attr(feature = "cargo-clippy", warn(use_self))] [INFO] [stderr] | ^^^^^^^^ help: change it to: `clippy::use_self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(renamed_and_removed_lints)] on by default [INFO] [stderr] [INFO] [stderr] | [INFO] [stderr] = note: #[warn(renamed_and_removed_lints)] on by default [INFO] [stderr] [INFO] [stderr] warning: lint name `use_self` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/lib.rs:6:44 [INFO] [stderr] | [INFO] [stderr] 6 | #![cfg_attr(feature = "cargo-clippy", warn(use_self))] [INFO] [stderr] | ^^^^^^^^ help: change it to: `clippy::use_self` [INFO] [stderr] [INFO] [stderr] warning: lint name `use_self` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/lib.rs:6:44 [INFO] [stderr] | [INFO] [stderr] 6 | #![cfg_attr(feature = "cargo-clippy", warn(use_self))] [INFO] [stderr] | ^^^^^^^^ help: change it to: `clippy::use_self` [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'bytes::BufMut::put_u16': use put_u16_be or put_u16_le [INFO] [stderr] --> src/tftp/packet.rs:112:13 [INFO] [stderr] | [INFO] [stderr] 112 | buf.put_u16::(opcode); [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'bytes::BufMut::put_u16': use put_u16_be or put_u16_le [INFO] [stderr] --> src/tftp/packet.rs:119:13 [INFO] [stderr] | [INFO] [stderr] 119 | buf.put_u16::(3); [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'bytes::BufMut::put_u16': use put_u16_be or put_u16_le [INFO] [stderr] --> src/tftp/packet.rs:120:13 [INFO] [stderr] | [INFO] [stderr] 120 | buf.put_u16::(block); [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'bytes::BufMut::put_u16': use put_u16_be or put_u16_le [INFO] [stderr] --> src/tftp/packet.rs:125:13 [INFO] [stderr] | [INFO] [stderr] 125 | buf.put_u16::(4); [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'bytes::BufMut::put_u16': use put_u16_be or put_u16_le [INFO] [stderr] --> src/tftp/packet.rs:126:13 [INFO] [stderr] | [INFO] [stderr] 126 | buf.put_u16::(block); [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'bytes::BufMut::put_u16': use put_u16_be or put_u16_le [INFO] [stderr] --> src/tftp/packet.rs:130:13 [INFO] [stderr] | [INFO] [stderr] 130 | buf.put_u16::(4); [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'bytes::BufMut::put_u16': use put_u16_be or put_u16_le [INFO] [stderr] --> src/tftp/packet.rs:131:13 [INFO] [stderr] | [INFO] [stderr] 131 | buf.put_u16::(code); [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'bytes::Buf::get_u16': use get_u16_be or get_u16_le [INFO] [stderr] --> src/tftp/packet.rs:150:40 [INFO] [stderr] | [INFO] [stderr] 150 | let opcode = opcode.into_buf().get_u16::(); [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'bytes::Buf::get_u16': use get_u16_be or get_u16_le [INFO] [stderr] --> src/tftp/packet.rs:163:46 [INFO] [stderr] | [INFO] [stderr] 163 | 4 => Packet::ACK(rest.into_buf().get_u16::()), [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/tftp/packet.rs:44:40 [INFO] [stderr] | [INFO] [stderr] 44 | NotDefined(ref message) => format!("{}", message), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `message.to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'bytes::BufMut::put_u16': use put_u16_be or put_u16_le [INFO] [stderr] --> src/tftp/packet.rs:112:13 [INFO] [stderr] | [INFO] [stderr] 112 | buf.put_u16::(opcode); [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'bytes::BufMut::put_u16': use put_u16_be or put_u16_le [INFO] [stderr] --> src/tftp/packet.rs:119:13 [INFO] [stderr] | [INFO] [stderr] 119 | buf.put_u16::(3); [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'bytes::BufMut::put_u16': use put_u16_be or put_u16_le [INFO] [stderr] --> src/tftp/packet.rs:120:13 [INFO] [stderr] | [INFO] [stderr] 120 | buf.put_u16::(block); [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'bytes::BufMut::put_u16': use put_u16_be or put_u16_le [INFO] [stderr] --> src/tftp/packet.rs:125:13 [INFO] [stderr] | [INFO] [stderr] 125 | buf.put_u16::(4); [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'bytes::BufMut::put_u16': use put_u16_be or put_u16_le [INFO] [stderr] --> src/tftp/packet.rs:126:13 [INFO] [stderr] | [INFO] [stderr] 126 | buf.put_u16::(block); [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'bytes::BufMut::put_u16': use put_u16_be or put_u16_le [INFO] [stderr] --> src/tftp/packet.rs:130:13 [INFO] [stderr] | [INFO] [stderr] 130 | buf.put_u16::(4); [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'bytes::BufMut::put_u16': use put_u16_be or put_u16_le [INFO] [stderr] --> src/tftp/packet.rs:131:13 [INFO] [stderr] | [INFO] [stderr] 131 | buf.put_u16::(code); [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'bytes::Buf::get_u16': use get_u16_be or get_u16_le [INFO] [stderr] --> src/tftp/packet.rs:150:40 [INFO] [stderr] | [INFO] [stderr] 150 | let opcode = opcode.into_buf().get_u16::(); [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'bytes::Buf::get_u16': use get_u16_be or get_u16_le [INFO] [stderr] --> src/tftp/packet.rs:163:46 [INFO] [stderr] | [INFO] [stderr] 163 | 4 => Packet::ACK(rest.into_buf().get_u16::()), [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/tftp/packet.rs:44:40 [INFO] [stderr] | [INFO] [stderr] 44 | NotDefined(ref message) => format!("{}", message), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `message.to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 11.03s [INFO] running `"docker" "inspect" "1e67eb6683381339be528757955407b2d652985e6dea17e8b903c85770cfd6d7"` [INFO] running `"docker" "rm" "-f" "1e67eb6683381339be528757955407b2d652985e6dea17e8b903c85770cfd6d7"` [INFO] [stdout] 1e67eb6683381339be528757955407b2d652985e6dea17e8b903c85770cfd6d7